[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. In D106577#2944086 , @aaron.ballman wrote: >> I don't think that scenario is valid. MBCS-to-unicode mappings are a part of >> the definition of the MBCS (sometimes officially, sometimes de-facto defined >> by major vendors),

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367942. stevewan added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added a comment. @tejohnson Indirect calls are not captured in FunctionSummaries in CallGraph or in a flag form saying they exist. Also looks like speculative candidates for ICP do make

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

woodruffw updated this revision to Diff 367938. woodruffw added a comment. Updated the AST dump tests for JSON to refute the presence of the `Dumping ` prefix. Also, updated the `gen_ast_dump_json_test.py` generator to work with Python 3 and to behave better without the presence of the

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

LuoYuanke added a comment. In D108422#2957541 , @erichkeane wrote: > In D108422#2957528 , @RKSimon wrote: > >> There's nothing later than CannonLake here - does Intel need to at least >> reference up to

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo updated this revision to Diff 367937. modimo marked 3 inline comments as done. modimo edited the summary of this revision. modimo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding more test cases and changed logic around weak linkages

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

vsapsai added a comment. `DiagnosticError` looks like a good fit for the task at hand, so it is worth to try it. Though I don't know if it would end up in the end convoluted or OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108268/new/

[PATCH] D108499: [clang][codegen] Don't assert on CurLinkModule for silenced diagnostic

xur added a comment. This looks fine to me. But I agree you that a more complete fix would be having CurLinkModule set for all callers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108499/new/ https://reviews.llvm.org/D108499

[PATCH] D108483: [OpenMP] Correctly add member expressions to OpenMP info

This revision was automatically updated to reflect the committed changes. Closed by commit rGec66ed79f43c: [OpenMP] Correctly add member expressions to OpenMP info (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108483/new/

[clang] ec66ed7 - [OpenMP] Correctly add member expressions to OpenMP info

Author: Joseph Huber Date: 2021-08-20T20:45:14-04:00 New Revision: ec66ed79f43c3303e462b86eff65d08d6cf8229f URL: https://github.com/llvm/llvm-project/commit/ec66ed79f43c3303e462b86eff65d08d6cf8229f DIFF: https://github.com/llvm/llvm-project/commit/ec66ed79f43c3303e462b86eff65d08d6cf8229f.diff

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added a comment. The test is still missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108499: [clang][codegen] Don't assert on CurLinkModule for silenced diagnostic

inglorion added a comment. There are some possible follow-ups here: 1. Making sure CurLinkModule is set in all (or at least more) cases. 2. Addressing the FIXME about warnings and notes. I have some partial implementations of those ideas, but I figure we can take this change first while I

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150 +namespace AsanAccessInfo { + kstoimenov wrote: > vitalybuka wrote: > > It's not how enums described here > >

[PATCH] D108499: [clang][codegen] Don't assert on CurLinkModule for silenced diagnostic

inglorion created this revision. inglorion requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR51564. Under certain circumstances, it is possible to enter Clang's BackendConsumer::DiagnosticHandlerImpl without CurLinkModule set. For

[PATCH] D108494: [Driver] Remove discouraged -gcc-toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGb686fc7a1bea: [Driver] Remove discouraged -gcc-toolchain (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108494/new/

[clang] b686fc7 - [Driver] Remove discouraged -gcc-toolchain

Author: Fangrui Song Date: 2021-08-20T16:36:42-07:00 New Revision: b686fc7a1bea5847676ee0f4e03d4318b0e9e350 URL: https://github.com/llvm/llvm-project/commit/b686fc7a1bea5847676ee0f4e03d4318b0e9e350 DIFF: https://github.com/llvm/llvm-project/commit/b686fc7a1bea5847676ee0f4e03d4318b0e9e350.diff

[PATCH] D108494: [Driver] Remove discouraged -gcc-toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108494/new/ https://reviews.llvm.org/D108494

[PATCH] D108494: [Driver] Remove discouraged -gcc-toolchain

MaskRay created this revision. MaskRay added reviewers: luismarques, phosek. Herald added a subscriber: dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Space separated driver options are uncommon but Clang traditionally did

[PATCH] D108493: [HIP] Allow capture this pointer in device lambda

tra added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:881-882 + } else if (Capture.isThisCapture() && !LangOpts.HIP) { +// Capture of this pointer is allowed for HIP since this pointer may be +// pointing to managed memory which is accessible on both device

[clang] 40aab04 - [test] Migrate -gcc-toolchain with space separator to --gcc-toolchain=

Author: Fangrui Song Date: 2021-08-20T15:24:58-07:00 New Revision: 40aab0412fe7a14781e133627c2bb0a22761eac8 URL: https://github.com/llvm/llvm-project/commit/40aab0412fe7a14781e133627c2bb0a22761eac8 DIFF: https://github.com/llvm/llvm-project/commit/40aab0412fe7a14781e133627c2bb0a22761eac8.diff

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

bnbarham added a comment. In D108268#2958346 , @vsapsai wrote: > Not super happy with the complexity `DiagnosedError` introduces, want to > consider alternatives first. Ah yes, I wasn't happy with that either but couldn't come up with a decent

[PATCH] D108493: [HIP] Allow capture this pointer in device lambda

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. HIP currently diagnose capture of `this` pointer in device lambda in host member functions. If `this` pointer points to managed memory, it can be used in both device and host functions. Under

[PATCH] D108268: [Modules] Change result of reading AST block to llvm::Error instead

vsapsai added a comment. Not super happy with the complexity `DiagnosedError` introduces, want to consider alternatives first. Comment at: clang/lib/Serialization/ASTReader.cpp:3762 +return llvm::createStringError(std::errc::illegal_byte_sequence, +

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov added a comment. All tests are passing locally. Should be good to review now. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150 +namespace AsanAccessInfo { + vitalybuka wrote: > It's not how enums described here >

[PATCH] D108482: [Clang] Fixes instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 367907. ricejasonf added a comment. Fixed the formatting with clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108482/new/ https://reviews.llvm.org/D108482 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/TreeTransform.h Index:

[libunwind] 9ae9dd3 - [libunwind] Add UNW_AARCH64_* beside UNW_ARM64_*

Author: Fangrui Song Date: 2021-08-20T14:26:27-07:00 New Revision: 9ae9dd3fcfb9f471887ea6fbb0d0e8f2b9b46a28 URL: https://github.com/llvm/llvm-project/commit/9ae9dd3fcfb9f471887ea6fbb0d0e8f2b9b46a28 DIFF: https://github.com/llvm/llvm-project/commit/9ae9dd3fcfb9f471887ea6fbb0d0e8f2b9b46a28.diff

[clang] 644f88a - [NFC] addAttribute(FunctionIndex) => addFnAttribute()

Author: Arthur Eubanks Date: 2021-08-20T14:18:59-07:00 New Revision: 644f88a25b32600b1a48ba2e8b2f797ffa074193 URL: https://github.com/llvm/llvm-project/commit/644f88a25b32600b1a48ba2e8b2f797ffa074193 DIFF:

[PATCH] D108424: [NFC][clang] Move multiversion resolver code generation to llvm/ subdirectory

a.elovikov updated this revision to Diff 367890. a.elovikov added a comment. Fix a bug with not saving builder's insertion point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108424/new/ https://reviews.llvm.org/D108424 Files:

[PATCH] D108483: [OpenMP] Correctly add member expressions to OpenMP info

jhuber6 updated this revision to Diff 367887. jhuber6 added a comment. Add static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108483/new/ https://reviews.llvm.org/D108483 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D108483: [OpenMP] Correctly add member expressions to OpenMP info

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9439 +// Try to extract the base declaration from a `this->x` expression if possible. +ValueDecl

[PATCH] D108483: [OpenMP] Correctly add member expressions to OpenMP info

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Mapping expressions that have `this` as their base expression

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367882. kstoimenov added a comment. Upload after updating AddressSanitizer.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 Files:

[PATCH] D108482: [Clang] Fixes instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf created this revision. ricejasonf added a reviewer: aaron.ballman. ricejasonf added a project: clang. ricejasonf requested review of this revision. Herald added a subscriber: cfe-commits. The structured bindings decomposition of a non-dependent array in a dependent context (a

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 367881. kstoimenov added a comment. This time AddressSanitizer.cpp should be updated for real. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[clang] 5ca7131 - [DebugInfo] convert btf_tag attrs to DI annotations for record fields

Author: Yonghong Song Date: 2021-08-20T12:52:51-07:00 New Revision: 5ca7131eb369949ee3adf2d3a562bf7e56ca7422 URL: https://github.com/llvm/llvm-project/commit/5ca7131eb369949ee3adf2d3a562bf7e56ca7422 DIFF: https://github.com/llvm/llvm-project/commit/5ca7131eb369949ee3adf2d3a562bf7e56ca7422.diff

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

kstoimenov updated this revision to Diff 367876. kstoimenov added a comment. Herald added a subscriber: mgorny. Moved back to using AccessInfo and fixed the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367875. stevewan added a comment. De-Morgan-ize if condition for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 367873. kstoimenov added a comment. Moved files from the parent patch which didn't belong there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added a comment. Flag is not used anywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

RKSimon added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:57 + "Const_Reverse_Iterator", + "const_reverse_iterator" +

[PATCH] D108481: Avoid nullptr dereferencing of 'Constraint'

schittir created this revision. schittir added reviewers: erichkeane, saar.raz. schittir added a project: clang. schittir requested review of this revision. Herald added a subscriber: cfe-commits. Klocwork static code analysis exposed this bug: Pointer 'Constraint' returned from call to

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

kstoimenov updated this revision to Diff 367872. kstoimenov added a comment. Removed test code which should be added under a different directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 Files:

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG430e22388173: [DebugInfo] generate btf_tag annotations for DIDerived types (authored by yonghong-song). Changed prior to commit:

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 367863. beanz added a comment. Missed updating the flag name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm.org/D107095 Files: clang/docs/LanguageExtensions.rst

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 367861. beanz added a comment. Cleaning up documentation wording to make more sense with the rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm.org/D107095 Files:

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen added reviewers: nickdesaulniers, pcc. samitolvanen added a comment. Here's a PoC of the built-in function that returns the address of the function body with CFI. Based on D108478 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 367856. beanz added a comment. Fixing documentation line wrapping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm.org/D107095 Files: clang/docs/LanguageExtensions.rst

[PATCH] D107095: Implement #pragma clang header_unsafe

beanz updated this revision to Diff 367851. beanz added a comment. Renaming to restrict_expansion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107095/new/ https://reviews.llvm.org/D107095 Files: clang/docs/LanguageExtensions.rst

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen created this revision. Herald added a subscriber: martong. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds __builtin_addressof_nocfi(). This built-in function is similar to the existing

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:349 + unsigned VLENMax = 65536; + return std::make_pair(VLENMin / 64, VLENMax / 64); +} Should we move RVVBitsPerBlock to RISCVTargetParser.def? Or some other place that can be

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song updated this revision to Diff 367846. yonghong-song added a comment. - put checking btf_tag existence condition in function CollectBTFTagAnnotations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106616/new/

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song added a comment. For > (any chance have you measured/could you measure how much larger the bitcode > for, say, an LLVM self-host Debug build gets with all these btf patches? > (even without targeting/using btf, this is adding an extra field to lots of > the debug info metadata,

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367844. cor3ntin added a comment. Remove superfluous assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files:

[PATCH] D108407: [CodeGen][WIP] Avoid generating Record layouts for pointee types

rjmccall added a comment. I have no problem with breaking LLVM analyses that rely on record types being filled in when they don't need to be. I've been consistently telling people for years that they shouldn't be relying on IR types for things like that. I would stick with the frontend

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367840. cor3ntin added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. - Add more tests - Add a table for format codepoints - which we want to output as is. These include among other ZWJ (for emojis)

[PATCH] D108360: [clang][NFC] Remove dead code

rjmccall added a reviewer: Anastasia. rjmccall added a comment. Hi, Andy. This patch is obviously okay, although it makes me wonder if it was introduced by a patch collision or something similar that needs closer attention. CC'ing Anastasia. I'm not sure that I agree with your overall plan,

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6265-6268 +void CodeGenModule::printPostfixForExternalizedStaticVar( +llvm::raw_ostream ) const { + OS << ".static." << getContext().getCUIDHash(); +} Hahnfeld wrote: > I've tried

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + rjmccall wrote: > Okay, so first off, the comment and variable

[PATCH] D108450: [clang][CodeGen] GetDefaultAlignTempAlloca uses preferred alignment

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sure, I guess there's no harm in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108450/new/ https://reviews.llvm.org/D108450

[PATCH] D108458: [clang][CodeGen] Add default constructor for Address. NFC.

rjmccall added a comment. You can still use a type without a default constructor in a `DenseMap`; you just have to use `insert` instead of `dict[key] = ...`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108458/new/

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367833. stevewan added a comment. Address comments about the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D108445: [clang][NFC] GetOrCreateLLVMGlobal takes LangAS

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108445/new/ https://reviews.llvm.org/D108445

[PATCH] D106620: [Clang][LLVM] generate btf_tag annotations for func parameters

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106620/new/ https://reviews.llvm.org/D106620

[PATCH] D106619: [Clang][LLVM] generate btf_tag annotations for DIGlobalVariable

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good. (any chance have you measured/could you measure how much larger the bitcode for, say, an LLVM self-host Debug build gets with all these btf patches? (even without

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6450 llvm::raw_ostream ) const { - OS << ".static." << getContext().getCUIDHash(); + OS << "__static__" << getContext().getCUIDHash(); } I would expect

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good. Please do the `hasAttr`/`CollectBTFTagAnnotations` refactor in a separate preliminary commit (cleaning up any existing callers that have the null check like that), then

[PATCH] D104854: Introduce intrinsic llvm.isnan

kpn added a comment. In D104854#2957490 , @lebedev.ri wrote: > In D104854#2957471 , @sepavloff > wrote: > >> In D104854#2957423 , @spatel wrote: >> >>> Is it

[clang] b1efefa - Revert "[openmp][nfc] Refactor GridValues"

Author: Jon Chesterfield Date: 2021-08-20T18:17:27+01:00 New Revision: b1efeface70c26f2f2e30636943c02f356ce4faa URL: https://github.com/llvm/llvm-project/commit/b1efeface70c26f2f2e30636943c02f356ce4faa DIFF:

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

a.elovikov updated this revision to Diff 367821. a.elovikov added a comment. Remove stale FIXME comment in the code being moved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422 Files:

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:818 + llvm::raw_string_ostream stream(number); + stream << ""; + OutStr.append(number.begin(), number.end()); jfb wrote: > We don't have a better hex formatter?  > Not a

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") a.elovikov wrote: > craig.topper wrote: > >

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added a comment. In D108469#2957652 , @jfb wrote: > I worry that changing the general `static_assert` printing (adding a colon, > and dropping the quotes) will get @hwright's law to drop on us. We can try > and see if e.g. users of clang have

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

a.elovikov added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") craig.topper wrote: > erichkeane wrote: > >

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield added a comment. Failed a nvptx codegen test (maybe the change to calculate log2 at runtime), currently away from my desk but will revert when I get back unless beaten to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108469: Improve handling of static assert messages.

jfb added a subscriber: hwright. jfb added a comment. I worry that changing the general `static_assert` printing (adding a colon, and dropping the quotes) will get @hwright's law to drop on us. We can try and see if e.g. users of clang have automated checks for `static_assert` in their CI

[clang] 5cf5df8 - [X86] Add missing __inline__ to functions in amxintrin.h

Author: Craig Topper Date: 2021-08-20T09:35:02-07:00 New Revision: 5cf5df8014acc21c95f05f74bccf26144f6be5dc URL: https://github.com/llvm/llvm-project/commit/5cf5df8014acc21c95f05f74bccf26144f6be5dc DIFF: https://github.com/llvm/llvm-project/commit/5cf5df8014acc21c95f05f74bccf26144f6be5dc.diff

[PATCH] D104854: Introduce intrinsic llvm.isnan

spatel added a comment. In D104854#2957582 , @lebedev.ri wrote: > In D104854#2957529 , @spatel wrote: > >> In D104854#2957471 , @sepavloff >> wrote: >> >>> In

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367812. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 367811. cor3ntin added a comment. Fix diagnostic for avaibility attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files:

[PATCH] D108387: [WebAssembly] Restore builtins and intrinsics for pmin/pmax

This revision was automatically updated to reflect the committed changes. Closed by commit rG88962cea4680: [WebAssembly] Restore builtins and intrinsics for pmin/pmax (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108387/new/

[clang] 88962ce - [WebAssembly] Restore builtins and intrinsics for pmin/pmax

Author: Thomas Lively Date: 2021-08-20T09:21:31-07:00 New Revision: 88962cea46805dbcc60524f7107030c986833052 URL: https://github.com/llvm/llvm-project/commit/88962cea46805dbcc60524f7107030c986833052 DIFF: https://github.com/llvm/llvm-project/commit/88962cea46805dbcc60524f7107030c986833052.diff

[PATCH] D104854: Introduce intrinsic llvm.isnan

lebedev.ri added a comment. In D104854#2957529 , @spatel wrote: > In D104854#2957471 , @sepavloff > wrote: > >> In D104854#2957423 , @spatel wrote: >> >>> Is it

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 367805. jozefl added a comment. Here's an updated patch to fix the win64 failure. MSVC can't handle the conversion from a ForwardIterator to a const pointer when the container being searched with std::lower_bound is a std::array. Meanwhile clang-tidy warns

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

svenvh created this revision. svenvh added reviewers: Anastasia, jaykang10. svenvh added a project: clang. Herald added subscribers: ldrumm, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. With -fpreserve-vec3-type enabled, a cast was not created when

[PATCH] D104854: Introduce intrinsic llvm.isnan

xbolva00 added a comment. In D104854#2957529 , @spatel wrote: > In D104854#2957471 , @sepavloff > wrote: > >> In D104854#2957423 , @spatel wrote: >> >>> Is it

[PATCH] D108415: [WebAssembly] Make shift values unsigned in wasm_simd128.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG64a9957bf7b6: [WebAssembly] Make shift values unsigned in wasm_simd128.h (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108415/new/

[clang] 64a9957 - [WebAssembly] Make shift values unsigned in wasm_simd128.h

Author: Thomas Lively Date: 2021-08-20T09:10:37-07:00 New Revision: 64a9957bf7b65a0d10819918ac2a565d69e9c4bb URL: https://github.com/llvm/llvm-project/commit/64a9957bf7b65a0d10819918ac2a565d69e9c4bb DIFF: https://github.com/llvm/llvm-project/commit/64a9957bf7b65a0d10819918ac2a565d69e9c4bb.diff

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367802. cor3ntin retitled this revision from "Improve handling of static assert messages. Instead of dumping the string literal (which quotes it and escape every non-ascii symbol), we can use the content of the string (which we know is valid UTF-8 by virtue

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

erichkeane added a subscriber: LuoYuanke. erichkeane added a comment. In D108422#2957528 , @RKSimon wrote: > There's nothing later than CannonLake here - does Intel need to at least > reference up to Tiger/Rocketlake? @LuoYuanke ^^ Repository: rG

[PATCH] D108469: Improve handling of static assert messages. Instead of dumping the string literal (which quotes it and escape every non-ascii symbol), we can use the content of the string (which we

cor3ntin created this revision. Herald added a subscriber: martong. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...g). `FormatDiagnostic` is modified to escape non printable characters and invalid UTF-8. This ensures that

[PATCH] D104854: Introduce intrinsic llvm.isnan

spatel added a comment. In D104854#2957471 , @sepavloff wrote: > In D104854#2957423 , @spatel wrote: > >> Is it intentional that we are not canonicalizing the intrinsic call back to >> `fcmp uno` in the default

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added a comment. There's nothing later than CannonLake here - does Intel need to at least reference up to Tiger/Rocketlake? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1222 + DeclContext *DC = this; + while (DC && DC->isTransparentContext()) +DC = DC->getParent(); erichkeane wrote: > cor3ntin wrote: > > Can getParent() be null? If it cam, then

[clang] 65bcdea - Replace an unnecessary null check with an assert; NFC

Author: Aaron Ballman Date: 2021-08-20T12:04:46-04:00 New Revision: 65bcdeaa15b729dae40190c6a990cd67c12e9f10 URL: https://github.com/llvm/llvm-project/commit/65bcdeaa15b729dae40190c6a990cd67c12e9f10 DIFF: https://github.com/llvm/llvm-project/commit/65bcdeaa15b729dae40190c6a990cd67c12e9f10.diff

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

craig.topper added a comment. I'm not opposed either. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") erichkeane wrote: > RKSimon

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song added a comment. @dblaikie could you take a look at this patch? The same as previous DIComposite patch (D106615 ), if the patch is accepted, I will break into llvm part and clang part and commit them separately. Repository: rG LLVM Github

[PATCH] D108412: [WebAssembly] Add SIMD intrinsics using unsigned integers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2456e11614c1: [WebAssembly] Add SIMD intrinsics using unsigned integers (authored by tlively). Changed prior to commit:

[clang] 2456e11 - [WebAssembly] Add SIMD intrinsics using unsigned integers

Author: Thomas Lively Date: 2021-08-20T08:56:51-07:00 New Revision: 2456e11614c10a2e648005e27e3213c77b7ab7a4 URL: https://github.com/llvm/llvm-project/commit/2456e11614c10a2e648005e27e3213c77b7ab7a4 DIFF: https://github.com/llvm/llvm-project/commit/2456e11614c10a2e648005e27e3213c77b7ab7a4.diff

[PATCH] D106616: [Clang][LLVM] generate btf_tag annotations for DIDerived types

yonghong-song updated this revision to Diff 367797. yonghong-song added a comment. - fix clang-format warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106616/new/ https://reviews.llvm.org/D106616 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

erichkeane added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1222 + DeclContext *DC = this; + while (DC && DC->isTransparentContext()) +DC = DC->getParent(); cor3ntin wrote: > Can getParent() be null? If it cam, then this function can return

  1   2   >