[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG319ce9801174: [clang-repl] Re-implement clang-interpreter as a test case. (authored by v.g.vassilev). Herald added a project: clang. Changed prior

[clang] 319ce98 - [clang-repl] Re-implement clang-interpreter as a test case.

Author: Vassil Vassilev Date: 2021-09-01T05:23:21Z New Revision: 319ce98011742141dad8dd95a2f9de9c0449be5c URL: https://github.com/llvm/llvm-project/commit/319ce98011742141dad8dd95a2f9de9c0449be5c DIFF: https://github.com/llvm/llvm-project/commit/319ce98011742141dad8dd95a2f9de9c0449be5c.diff

[PATCH] D108794: Fully qualify template template parameters when printing

rtrieu added a comment. It looks like a strict improvement on printing and most callers using the default args won't need to be updated. There's one more function call that should be updated: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/DumpAST.cpp#L298 Fixing that

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

rjmccall added a comment. Yes, that's right. OVE allows us to logically place a single expression in multiple positions in the expression hierarchy. This can be useful for either source or semantic fidelity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 369828. ricejasonf added a comment. I think I found a simple solution that bypasses transforming the OVE. The ArrayInitLoop always has an OVE in it so I strip it along with it in TransformInitializer. I looked around in CodeGen and might have a better

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109023: libclang: Document the soname change in the release notes

tstellar accepted this revision. tstellar added a comment. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109023/new/ https://reviews.llvm.org/D109023 ___ cfe-commits mailing list

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

rjmccall added a comment. In D108905#2975712 , @rsmith wrote: > No decision as yet, but so far it looks very likely that we'll settle on the > rule that exceptions cannot have potentially-throwing destructors, and that > we should reject `throw`s of

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

dim added a comment. Just encountered another similar error, apparently introduced in rGc8937b6cb9751807de1e69f0f0f70a9a58f8f5dc (as more additions to the `defineXLCompatMacros` function, by @lei): In file included from

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

rsmith added a comment. No decision as yet, but so far it looks very likely that we'll settle on the rule that exceptions cannot have potentially-throwing destructors, and that we should reject `throw`s of such types. I don't think that should be applied retroactively to C++98, though, because

[PATCH] D109023: libclang: Document the soname change in the release notes

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:311 -- ... +- Make libclang SONAME independent from LLVM version. It will be updated only when + needed. MaskRay wrote: > While here, mention the exact CMake variable. Also link to

[PATCH] D109023: libclang: Document the soname change in the release notes

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/docs/ReleaseNotes.rst:311 -- ... +- Make libclang SONAME independent from LLVM version. It will be updated only when + needed.

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen added inline comments. Comment at: clang/test/CodeGen/builtin-addressof-nocfi.c:18 + // CHECK: call void @c(void ()* no_cfi @a) + c(__builtin_addressof_nocfi(a)); + e(); nickdesaulniers wrote: > do we ever need the builtin address of a global

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen updated this revision to Diff 369795. samitolvanen marked 2 inline comments as done. samitolvanen added a comment. Fixed clang-tidy warnings, dropped an unnecessary auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108479/new/

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

arames updated this revision to Diff 369794. arames marked an inline comment as done. arames added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102943/new/ https://reviews.llvm.org/D102943 Files:

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

arames marked 2 inline comments as done. arames added inline comments. Comment at: clang/include/clang/Basic/ObjCRuntime.h:486 + template + friend void addHash(llvm::HashBuilderImpl , + const ObjCRuntime ) { dexonsmith wrote: > arames

[PATCH] D109023: libclang: Document the soname change in the release notes

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: MaskRay, tstellar. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109023 Files:

[PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne update? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov updated this revision to Diff 369745. apivovarov added a comment. Add `sifive-s51` to test `target-invalid-cpu-note.c` error messages match string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:101-105 + // FIXME: Somehow when we build this test in release mode argc is not 0. + // printf("%d\n", argc); + // for (int I = 0; I < argc; ++I) + //

[PATCH] D102943: [modules] Use `HashBuilder` and `MD5` for the module hash.

dexonsmith added a comment. A couple of suggestions inline, but this basically LGTM. @jansvoboda11 @Bigcheese : can you take a look as well and confirm this looks reasonable from your perspectives? Comment at: clang/include/clang/Basic/ObjCRuntime.h:486 + template +

[PATCH] D108917: [PowerPC] Define __powerpc and __PPC macros

nemanjai added a comment. In D108917#2974490 , @cebowleratibm wrote: > I'd like to see the rationale for adding these forms of the macros in the > review and also in the extended commit message. These forms are being added > primarily because the AIX

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 369729. v.g.vassilev marked 3 inline comments as done. v.g.vassilev added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. Documentation is much improved. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108291/new/ https://reviews.llvm.org/D108291

[PATCH] D109003: Ensure field-annotations on pointers properly match the AS of the field.

erichkeane created this revision. erichkeane added reviewers: Tyker, aaron.ballman. Herald added subscribers: Naghasan, Anastasia. erichkeane requested review of this revision. Discovered in SYCL, the field annotations were always cast to an i8*, which is an invalid bitcast for a pointer type

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Accepting patch since no reaction from @fghanim CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107430/new/ https://reviews.llvm.org/D107430

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. The error state of the stream can store these combinations: | | FERROR flag | FEOF flag | file position indeterminate | | 1 | false | false | false | No error (single state)

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rG10d78a06baa2: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir (authored by yaron.keren). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 10d78a0 - [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

Author: Yaron Keren Date: 2021-08-31T18:57:47+03:00 New Revision: 10d78a06baa217b8a4b853eff962e9ae719a8a45 URL: https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45 DIFF: https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45.diff

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109000/new/ https://reviews.llvm.org/D109000

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro `__opencl_c_images` in C++ for OpenCL

[clang] b8debab - [clang] Remove redundant calls to c_str() (NFC)

Author: Kazu Hirata Date: 2021-08-31T08:53:51-07:00 New Revision: b8debabb775b6d9eec5aa16f1b0c3428cc076bcb URL: https://github.com/llvm/llvm-project/commit/b8debabb775b6d9eec5aa16f1b0c3428cc076bcb DIFF: https://github.com/llvm/llvm-project/commit/b8debabb775b6d9eec5aa16f1b0c3428cc076bcb.diff

[PATCH] D108998: [SystemZ][z/OS] Create html report file with text flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGae206db2d653: [SystemZ][z/OS] Create html report file with text flag (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108998/new/

[clang] ae206db - [SystemZ][z/OS] Create html report file with text flag

Author: Fanbo Meng Date: 2021-08-31T11:52:04-04:00 New Revision: ae206db2d653cfeb1021e4e8f5783de797e521a5 URL: https://github.com/llvm/llvm-project/commit/ae206db2d653cfeb1021e4e8f5783de797e521a5 DIFF: https://github.com/llvm/llvm-project/commit/ae206db2d653cfeb1021e4e8f5783de797e521a5.diff

[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

dexonsmith added inline comments. Comment at: clang/test/ClangScanDeps/strip_diag_serialize.cpp:1-3 +// FIXME: Make this pass again. +// XFAIL: * + Can you clarify why a temporary regression is necessary? Is there a way of reordering patches to avoid it?

[PATCH] D108918: [clang] NFC: Extract DiagnosticOptions parsing

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. A few comments inline, but LGTM once you fix those. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2259-2260 +DiagnosticOptions

[PATCH] D108919: [clan-repl] Install clang-repl

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9948e9254fb: [clang-repl] Install clang-repl (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c9948e9 - [clang-repl] Install clang-repl

Author: Vassil Vassilev Date: 2021-08-31T15:20:15Z New Revision: c9948e9254fbb6ea00f66c7b4542311d21e060be URL: https://github.com/llvm/llvm-project/commit/c9948e9254fbb6ea00f66c7b4542311d21e060be DIFF: https://github.com/llvm/llvm-project/commit/c9948e9254fbb6ea00f66c7b4542311d21e060be.diff

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

yaron.keren added a comment. Addressing comment in https://reviews.llvm.org/D108085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109000/new/ https://reviews.llvm.org/D109000 ___ cfe-commits mailing

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren marked an inline comment as done. yaron.keren added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit =

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

yaron.keren created this revision. yaron.keren added a reviewer: tstellar. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109000 Files:

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

dexonsmith added a comment. In D108979#2974642 , @dexonsmith wrote: > I'm approving as-is, since this is a step forward, but I'm curious if you can > clarify what ToolInvocation is providing, and whether that's worth it or if > it'd make sense

[PATCH] D108998: [SystemZ][z/OS] Create html report file with text flag

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108998/new/ https://reviews.llvm.org/D108998

[PATCH] D108981: [clang][deps] NFC: Remove CompilationDatabase from DependencyScanningTool API

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108981/new/ https://reviews.llvm.org/D108981

[PATCH] D108980: [clang][deps] NFC: Remove CompilationDatabase from DependencyScanningWorker API

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108980/new/ https://reviews.llvm.org/D108980

[PATCH] D108982: [clang][deps] Avoid creating diagnostic serialization file, add test

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Code changes LGTM, just a comment on the test. Comment at: clang/test/ClangScanDeps/diagnostics.c:8 + +// CHECK-NOT: error: invalid iOS deployment version

[PATCH] D108998: [SystemZ][z/OS] Create html report file with text flag

fanbo-meng created this revision. Herald added a subscriber: martong. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change OF_None to OF_Text flag in file creation, same reasoning as https://reviews.llvm.org/D97785

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. I've independently been wondering for a while whether ClangTool was doing more harm than good for the scanning usecase. I'm approving as-is, since this is a step forward, but

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:101 + } else { +RVVBitsMin = RVVVectorBitsMinOpt; +RVVBitsMax = RVVVectorBitsMaxOpt; craig.topper wrote: > If clang always emits the attribute, are these options

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added a comment. We had a meeting outside phabricator, here is the gist of it: - It'd be better to have your initially proposed schrödinger-like `NoteTag`s. - The intent is to emit a warning for each of the error states in `StreamState`. It seems to me that this is not what we're

[PATCH] D108917: [AIX] Define __powerpc and __PPC macros

cebowleratibm requested changes to this revision. cebowleratibm added a comment. This revision now requires changes to proceed. I'd like to see the rationale for adding these forms of the macros in the review and also in the extended commit message. These forms are being added primarily

[PATCH] D107450: [clang-tidy] Fix wrong FIxIt in performance-move-const-arg

Sockke marked an inline comment as not done. Sockke added a comment. Thanks for your review, I greatly appreciate it. @whisperity There is no wrong case in the original test file, which is why we did not catch the bug in the test suite. From this, I added some new cases. I tested the functions

[PATCH] D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro `__opencl_c_fp64` in C++ for OpenCL

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

saiislam marked an inline comment as done. saiislam added a comment. Ping. Any more suggestions/questions? I will update requested changes/documentation for D105191 once this gets through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104344: [modules] Track how headers are included by different modules.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. I see, thanks for the explanation. This LGTM provided the failing clangd test gets fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added a comment. In D106262#2939532 , @balazske wrote: > Really I still not understand why the previous `BugType` dependent `NoteTag` > functions were bad design (except that it could make the code difficult to > understand). If we would have

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

dim added subscribers: adalava, jhibbits. dim added a comment. In D104386#2973372 , @nemanjai wrote: > In D104386#2973245 , @dim wrote: > >> Note that this unexpectedly broke FreeBSD's powerpc64 builds, as we've

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added a comment. In D108765#2974153 , @MyDeveloperDay wrote: > error: pathspec './plurals.txt' did not match any file(s) known to git > Traceback (most recent call last): > File "./dump_format_style.py", line 18, in >

[PATCH] D108982: [clang][deps] Avoid creating diagnostic serialization file, add test

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inject custom diagnostic options into `ToolInvocation` with stripped diagnostic

[PATCH] D108981: [clang][deps] NFC: Remove CompilationDatabase from DependencyScanningTool API

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch simplifies the dependency scanner API. Made possibly by D108979

[PATCH] D108980: [clang][deps] NFC: Remove CompilationDatabase from DependencyScanningWorker API

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch simplifies the dependency scanner API. Made possibly by D108979

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner currently uses `ClangTool` to invoke the dependency

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

steakhal resigned from this revision. steakhal added a comment. I think it looks good, I don't have much objection to this. I've also participated in the offline-review of this patch, so the current shape of this reflects my intentions, thus I resign. At the same time, I'm requesting others to

[clang] f9bc1b3 - [OpenCL] Defines helper function for kernel language compatible OpenCL version

Author: Justas Janickas Date: 2021-08-31T10:08:38+01:00 New Revision: f9bc1b3bee557de5735c745f9558c47ca568bd96 URL: https://github.com/llvm/llvm-project/commit/f9bc1b3bee557de5735c745f9558c47ca568bd96 DIFF:

[PATCH] D108693: [OpenCL] Defines helper function for kernel language compatible OpenCL version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9bc1b3bee55: [OpenCL] Defines helper function for kernel language compatible OpenCL version (authored by Topotuna). Repository: rG LLVM Github

[PATCH] D108976: [clang][tooling] Allow providing custom diagnostic options to ToolInvocation

jansvoboda11 updated this revision to Diff 369658. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108976/new/ https://reviews.llvm.org/D108976 Files: clang/include/clang/Tooling/Tooling.h

[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

jansvoboda11 updated this revision to Diff 369657. jansvoboda11 added a comment. XFAIL clang-scan-deps test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108974/new/ https://reviews.llvm.org/D108974 Files: clang/lib/Tooling/Tooling.cpp

[PATCH] D108976: [clang][tooling] Allow providing custom diagnostic options to ToolInvocation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows the clients of `ToolInvocation` to provide custom diagnostic

[PATCH] D108975: [clangd] Omit default template arguments from type hints

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In `ToolInvocation::run`, the driver -> cc1 command-line transformation uses

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. error: pathspec './plurals.txt' did not match any file(s) known to git Traceback (most recent call last): File "./dump_format_style.py", line 18, in subprocess.check_call(['git', 'checkout', '--', PLURAL_FILE]) File

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:9 import re +import inspect +import subprocess FederAndInk wrote: > HazardyKnusperkeks wrote: > > I think these should be sorted. > ok, it will be done are these standard

[PATCH] D108818: [clang] Add a -canonical-prefixes option

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108818/new/ https://reviews.llvm.org/D108818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108972: [clangd] Omit type hints that are too long

nridge added a comment. (The relevant issue is https://github.com/clangd/clangd/issues/824_ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108972/new/ https://reviews.llvm.org/D108972 ___ cfe-commits

[PATCH] D108972: [clangd] Omit type hints that are too long

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:346 + + static const size_t TypeNameLimit = 32; }; I'm open to suggestions for what the length limit should be, here I made a fairly arbitrary choice. Repository: rG LLVM

[PATCH] D108972: [clangd] Omit type hints that are too long

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thank! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77470/new/ https://reviews.llvm.org/D77470

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

pengfei added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3902 + case X86::VFCMADDCSHZr: + case X86::VFCMADDCSHZrb: + case X86::VFCMADDCSHZrbk: pengfei wrote: > LuoYuanke wrote: > > "b" means rounding. Right? > broadcasting

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Hi, svenvh and Anastasia. If you approve the patch, could you please submit it? I don't have permission to do it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 ___

[PATCH] D98254: Fix typo in two files in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGe01ac501af20: Fix typo in two files in Clang, patch by FusionBolt (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98254/new/

[clang] e01ac50 - Fix typo in two files in Clang, patch by FusionBolt

Author: Shivam Gupta Date: 2021-08-31T12:33:37+05:30 New Revision: e01ac501af20cdbbc199f4f4ac3e6d705442 URL: https://github.com/llvm/llvm-project/commit/e01ac501af20cdbbc199f4f4ac3e6d705442 DIFF: https://github.com/llvm/llvm-project/commit/e01ac501af20cdbbc199f4f4ac3e6d705442.diff

[PATCH] D98254: Fix typo in two files in Clang

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98254/new/ https://reviews.llvm.org/D98254

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a6d8a11f89b: [clang] Fix Typo in AST Matcher Reference (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/

[clang] 4a6d8a1 - [clang] Fix Typo in AST Matcher Reference

Author: Shivam Gupta Date: 2021-08-31T12:21:47+05:30 New Revision: 4a6d8a11f89b9eae984e1b9608c1c010dc6a037b URL: https://github.com/llvm/llvm-project/commit/4a6d8a11f89b9eae984e1b9608c1c010dc6a037b DIFF: https://github.com/llvm/llvm-project/commit/4a6d8a11f89b9eae984e1b9608c1c010dc6a037b.diff

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/ https://reviews.llvm.org/D102836

[PATCH] D91311: Add new 'preferred_name' attribute.

dblaikie added a comment. @rsmith - would it make sense to disable preferred names use when `PrintingPolicy::PrintCanonicalTypes` is used? It's used in `CGDebugInfo`, but also in `Sema::findFailedBooleanCondition` - so maybe we need another `PrintingPolicy` flag for this so `CGDebugInfo` can

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov updated this revision to Diff 369635. apivovarov added a comment. update the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 Files: clang/test/Driver/riscv-cpus.c

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

JonChesterfield planned changes to this revision. JonChesterfield added a comment. Yeah, we probably can't leave the installed program with a search path only used for testing. I'm planning to revisit this to use libomptarget_amdgcn_bc_path instead of LIBRARY_PATH for testing, then drop the