[PATCH] D108189: [RISCV] Add arch attribute support for P extension

Jim updated this revision to Diff 370484. Jim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Base on D105168 to support arch features, arch attributes and preprocessor definitions. Repository: rG LLVM Github Monorepo

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

Jim added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:416 +ExtensionInfoIterator->Version.Minor); + if (ExtName == "e") { +if (XLen != 32) Could this checking put before ISAInfo->addExtension...

[PATCH] D109128: [VFS] Use original path when falling back to external FS

keith updated this revision to Diff 370480. keith marked 2 inline comments as done. keith added a comment. Update variable name and add unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 Files:

[PATCH] D108421: Mark openmp internal global dso_local

umesh.kalappa0 added a comment. In D108421#2977216 , @MaskRay wrote: > In D108421#2977107 , @kamleshbhalui > wrote: > >> In D108421#2958848 , @MaskRay >> wrote: >> >>>

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

mattbeardsley created this revision. mattbeardsley added reviewers: njames93, aaron.ballman. Herald added a subscriber: xazax.hun. mattbeardsley requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Per this commit, "Note"

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123 set(RUNTIMES_${target}_COMPILER_RT_USE_BUILTINS_LIBRARY ON CACHE BOOL "") +set(RUNTIMES_${target}_COMPILER_RT_BUILD_BUILTINS ON CACHE BOOL "") +

[PATCH] D108886: Add RISC-V sifive-s51 cpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cd4b508a8a5: [RISCV] Add SiFive core S51 (authored by apivovarov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/

[clang] 6cd4b50 - [RISCV] Add SiFive core S51

Author: Alexander Pivovarov Date: 2021-09-02T18:45:25-07:00 New Revision: 6cd4b508a8a51ecd16d2b0297dfeb445ab41b42e URL: https://github.com/llvm/llvm-project/commit/6cd4b508a8a51ecd16d2b0297dfeb445ab41b42e DIFF:

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

daltenty added a comment. For the missing library implementation, we may be able to use the implementation in compiler-rt. Seems like some other platforms do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109139/new/

[PATCH] D109128: [VFS] Use original path when falling back to external FS

vsapsai added a comment. Was looking at an issue caused by over-eager RedirectingFileSystem path canonicalization and this patch fixes it. The repro we have is more complicated (involves 3 modules), so I don't think it is worth including with this change. Comment at:

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added a comment. Split also into https://reviews.llvm.org/D109207 and https://reviews.llvm.org/D109208 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan updated this revision to Diff 370447. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:141 +set(RUNTIMES_${target}_SANITIZER_COMMON_TEST_TARGET_CFLAGS "--unwindlib=libunwind -static-libgcc" CACHE STRING "") +set(RUNTIMES_${target}_TSAN_TEST_TARGET_CFLAGS

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

GMNGeoffrey added a comment. I can't repro the failure locally and it appears to also be broken at head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109181/new/ https://reviews.llvm.org/D109181 ___

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc2d4dc3e0cc: Reland Try to unbreak Win build differently after 973519826edb76 (authored by thakis, committed by GMNGeoffrey). Repository: rG

[clang] cc2d4dc - Reland "Try to unbreak Win build differently after 973519826edb76""

Author: Nico Weber Date: 2021-09-02T16:19:58-07:00 New Revision: cc2d4dc3e0ccb50e341f4ea301087bdd14be78a7 URL: https://github.com/llvm/llvm-project/commit/cc2d4dc3e0ccb50e341f4ea301087bdd14be78a7 DIFF: https://github.com/llvm/llvm-project/commit/cc2d4dc3e0ccb50e341f4ea301087bdd14be78a7.diff

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan added a comment. In D109199#2981174 , @phosek wrote: > @leonardchan would it be possible to break this up into 3 changes? Can do. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

thakis added a comment. In D109181#2981093 , @GMNGeoffrey wrote: > Hmmm so pre-merge checks on Linux are failing > > https://buildkite.com/llvm-project/premerge-checks/builds/54955#8fea4a06-e971-48ad-a6d7-31173315d83d I can't repro this locally. I

[PATCH] D105092: [RISCV] Add the tail policy argument to builtins/intrinsics.

HsiangKai updated this revision to Diff 370440. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 Files: llvm/include/llvm/IR/IntrinsicsRISCV.td

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

phosek added a comment. @leonardchan would it be possible to break this up into 3 changes? Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:123 set(RUNTIMES_${target}_COMPILER_RT_USE_BUILTINS_LIBRARY ON CACHE BOOL "") +

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

NeHuang updated this revision to Diff 370428. NeHuang added a comment. Address review comments - typo update - use proper mcpu in the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108302/new/ https://reviews.llvm.org/D108302 Files:

Maintenance works in llvm lab today at 5PM

Hello, LLVM lab and build master will be unavailable today September 2 for about 30 minutes starting 5PM PST due maintenance works in the lab. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108794: Fully qualify template template parameters when printing

This revision was automatically updated to reflect the committed changes. dblaikie marked an inline comment as done. Closed by commit rG5fb3f43778f8: Fully qualify template template parameters when printing (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 5fb3f43 - Fully qualify template template parameters when printing

Author: David Blaikie Date: 2021-09-02T15:04:34-07:00 New Revision: 5fb3f43778f85ebea48e880eef9493d188253890 URL: https://github.com/llvm/llvm-project/commit/5fb3f43778f85ebea48e880eef9493d188253890 DIFF: https://github.com/llvm/llvm-project/commit/5fb3f43778f85ebea48e880eef9493d188253890.diff

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

GMNGeoffrey added a comment. Hmmm so pre-merge checks on Linux are failing https://buildkite.com/llvm-project/premerge-checks/builds/54955#8fea4a06-e971-48ad-a6d7-31173315d83d FAIL: libomp :: lock/omp_init_lock.c (84929 of 87948) TEST 'libomp :: lock/omp_init_lock.c'

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

ABataev added a comment. In D109175#2981054 , @jdoerfert wrote: > In D109175#2980905 , @weiwang wrote: > >> In D109175#2980900 , @jdoerfert >> wrote: >> >>> In

[PATCH] D109191: [clang] fix error recovery ICE on copy elision when returing invalid variable

mizvekov created this revision. mizvekov published this revision for review. mizvekov added reviewers: rsmith, rtrieu. Herald added a project: clang. Herald added a subscriber: cfe-commits. See PR51708. Attempting copy elision in dependent contexts with invalid variable, such as a variable with

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:526 + union { +int K; + }; Can you add a `CHECK-FIXES-NOT` that we're not adding the fix for this case?

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

jdoerfert added a subscriber: ABataev. jdoerfert added a comment. In D109175#2980905 , @weiwang wrote: > In D109175#2980900 , @jdoerfert > wrote: > >> In D109175#2980806

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: Sanitizers. Herald added subscribers: mgorny, dberris. leonardchan requested review of this revision. Herald added a project: clang. Herald added subscribers: Sanitizers, cfe-commits.

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

lxfind accepted this revision. lxfind added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___ cfe-commits mailing list

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

aaron.ballman added inline comments. Comment at: clang/tools/clang-nvlink-wrapper/ClangNvlinkWrapper.cpp:63 + ErrorOr> BufOrErr = + MemoryBuffer::getFileOrSTDIN(Filename, -1, false); + if (std::error_code EC = BufOrErr.getError()) The `-1` is odd here --

[PATCH] D108761: [OpenCL] Remove decls for scalar vloada_half and vstorea_half* fns

This revision was automatically updated to reflect the committed changes. Closed by commit rG32955be6bf7d: [OpenCL] Remove decls for scalar vloada_half and vstorea_half* fns (authored by stuart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz added subscribers: gonzalobg, toklinke. salman-javed-nz added a comment. @gonzalobg, @toklinke - I think you two might be interested in this because you have made proposals about this feature before. gonzalobg - your Bugzilla ticket: https://bugs.llvm.org/show_bug.cgi?id=3

[clang] 32955be - [OpenCL] Remove decls for scalar vloada_half and vstorea_half* fns

Author: Stuart Brady Date: 2021-09-02T22:08:09+01:00 New Revision: 32955be6bf7d8401ea8271e1097bf783bf492eb9 URL: https://github.com/llvm/llvm-project/commit/32955be6bf7d8401ea8271e1097bf783bf492eb9 DIFF: https://github.com/llvm/llvm-project/commit/32955be6bf7d8401ea8271e1097bf783bf492eb9.diff

[PATCH] D108794: Fully qualify template template parameters when printing

rtrieu accepted this revision. rtrieu added a comment. This revision is now accepted and ready to land. In D108794#2978134 , @dblaikie wrote: > Ping > > In D108794#2976063 , @rtrieu wrote: > >> It looks like a

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980900 , @jdoerfert wrote: > In D109175#2980806 , @weiwang wrote: > >> In D109175#2980744 , @jdoerfert >> wrote: >> >>> Why do we

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

jdoerfert added a comment. In D109175#2980806 , @weiwang wrote: > In D109175#2980744 , @jdoerfert > wrote: > >> Why do we need this flag, is the absence of -fopenmp-targets not sufficient? > > Just double

[PATCH] D105092: [RISCV] Add the tail policy argument to builtins/intrinsics.

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:169 + llvm_anyint_ty, LLVMMatchType<1>], [NoCapture>, IntrReadMem]>, RISCVVIntrinsic; // For unit stride fault-only-first load with mask

[PATCH] D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py

mattbeardsley added a comment. No worries! Figured I'd start the conversation with the easy fix, but was fully prepared to hear that we can't let go of python 2 just yet, as much as we may want to :). Let me know if this fix looks suitable. Thanks for your time! Repository: rG LLVM Github

[PATCH] D109127: Fix python 2-vs-3 issues in add_new_check.py and rename_check.py

mattbeardsley updated this revision to Diff 370393. mattbeardsley retitled this revision from "Use python 3 in add_new_check.py and rename_check.py" to "Fix python 2-vs-3 issues in add_new_check.py and rename_check.py". mattbeardsley edited the summary of this revision. mattbeardsley added a

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

kamaub accepted this revision as: kamaub. kamaub added a comment. This LGTM, small nit on the comment, but that can be fixed on commit Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:1544 + // If the condition branch uses a physical register, then it cannot be turned +

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980744 , @jdoerfert wrote: > Why do we need this flag, is the absence of -fopenmp-targets not sufficient? Just double checked, this is the full omp related options currently in use: "-fopenmp"

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107430/new/ https://reviews.llvm.org/D107430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

jdoerfert added a comment. Why do we need this flag, is the absence of -fopenmp-targets not sufficient? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D109175 ___

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

sylvestre.ledru added a comment. Maybe add this to the release notes of clang 13 or 14? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106813/new/ https://reviews.llvm.org/D106813 ___ cfe-commits mailing

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

sylvestre.ledru added a comment. Maybe add this to the release notes of clang 14? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108291/new/ https://reviews.llvm.org/D108291 ___ cfe-commits mailing list

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added reviewers: vsapsai, dexonsmith. dexonsmith requested changes to this revision. dexonsmith added a subscriber: vsapsai. dexonsmith added a comment. This revision now requires changes to proceed. I think @vsapsai was looking at this as well. This mostly LGTM, but I think this can

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370370. jozefl added a comment. Updated patch to use hasFeature() to check for msp430x support, instead of a new function. Fixed use of tools::getCPUName() after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

wenlei added a comment. In D109175#2980446 , @lebedev.ri wrote: > In D109175#2980333 , @weiwang wrote: > >> Our internal codebase never uses the target directive. Once the deferred >> diags is bypassed, we

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

mehdi_amini added a comment. > @goncharov @mehdi_amini is there a way to change the way the phab UI or the > pre-merge checks work here to make failing pre-merge checks clearer? This > isn't the first time I've seen someone be very confused about this UI I asked the same thing a few days ago

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

thakis added a comment. In D109167#2980604 , @GMNGeoffrey wrote: >> I had fixed this in >> https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f >> . Precommit bot on this change was green though as far as I can tell. >

[PATCH] D109158: [clang][deps] Test diagnostic options are being respected

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. The test LGTM. I'd prefer you to squash this into https://reviews.llvm.org/D108974 though, since it seems to contain the necessary bits to make the test pass. Repository: rG LLVM

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added subscribers: goncharov, mehdi_amini. GMNGeoffrey added a comment. In D109167#2980604 , @GMNGeoffrey wrote: >> I had fixed this in >> https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f >> . Precommit

[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

dexonsmith added a comment. (If you can squash the changes from https://reviews.llvm.org/D109158 into here, even better.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108974/new/ https://reviews.llvm.org/D108974

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

dexonsmith added a comment. Thanks for explaining why ToolInvocation fits well here. SGTM. In D108979#2979484 , @jansvoboda11 wrote: > I think we can move that conversion into the current constructor that accepts > `std::vector`, add another

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added a comment. > I had fixed this in > https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f > . Precommit bot on this change was green though as far as I can tell. Harbormaster comments with a green check mark that build has completed, but if you

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109181/new/ https://reviews.llvm.org/D109181

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf updated this revision to Diff 370353. ricejasonf marked 2 inline comments as done. ricejasonf added a comment. Fixed minor formatting issue.  (Perhaps this should be in the tests included with check-clang?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109181: Reland "Try to unbreak Win build differently after 973519826edb76""

GMNGeoffrey created this revision. Herald added subscribers: dexonsmith, mgrang. GMNGeoffrey requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Build should be fixed by https://github.com/llvm/llvm-project/commit/9d22754389

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

thakis added a comment. In D109167#2980560 , @GMNGeoffrey wrote: > I'm seeing a build failure coming out of this: > >> llvm-project/lld/wasm/Writer.cpp:521:16: error: non-const lvalue reference >> to type 'llvm::StringRef' cannot bind to a temporary of

[clang] df052e1 - Revert "Try to unbreak Win build differently after 973519826edb76"

Author: Geoffrey Martin-Noble Date: 2021-09-02T12:05:33-07:00 New Revision: df052e1732ab57f5d9c684ceeaed3ab39073cd9f URL: https://github.com/llvm/llvm-project/commit/df052e1732ab57f5d9c684ceeaed3ab39073cd9f DIFF:

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

GMNGeoffrey added a comment. I'm seeing a build failure coming out of this: > llvm-project/lld/wasm/Writer.cpp:521:16: error: non-const lvalue reference to > type 'llvm::StringRef' cannot bind to a temporary of type 'llvm::StringRef' > > for (auto : used.keys()) { Looks like pre-merge

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370350. jozefl added a comment. Rebased onto current upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 Files:

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

lei updated this revision to Diff 370349. lei added a comment. fix spelling in commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109178/new/ https://reviews.llvm.org/D109178 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D109167: Try to unbreak Win build differently after 973519826edb76

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5881dcff7e76: Try to unbreak Win build differently after 973519826edb76 (authored by thakis). Herald added a project: clang. Herald added a

[clang] 5881dcf - Try to unbreak Win build differently after 973519826edb76

Author: Nico Weber Date: 2021-09-02T14:45:56-04:00 New Revision: 5881dcff7e76a68323edc8bb3c6e14420ad9cf7c URL: https://github.com/llvm/llvm-project/commit/5881dcff7e76a68323edc8bb3c6e14420ad9cf7c DIFF: https://github.com/llvm/llvm-project/commit/5881dcff7e76a68323edc8bb3c6e14420ad9cf7c.diff

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980446 , @lebedev.ri wrote: > In D109175#2980333 , @weiwang wrote: > >> Our internal codebase never uses the target directive. Once the deferred >> diags is bypassed, we

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

lei created this revision. lei added reviewers: hubert.reinterpretcast, nemanjai, power-llvm-team. Herald added a subscriber: shchenz. lei requested review of this revision. Herald added a project: clang. Update clang to treat vector unsigned long long and friends as invalid for AlttiVec without

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

lebedev.ri added a comment. In D109175#2980333 , @weiwang wrote: > Our internal codebase never uses the target directive. Once the deferred > diags is bypassed, we observed 18% e2e build time improvement. Is that with `-fopenmp` or without? That seems,

[PATCH] D109139: [AIX][RFC] Undefine __STDC_NO_ATOMICS__ to enable c11 atomics functionality

daltenty added a comment. Hmm, I'm not sure that the limitations you outline in the description are the only problems that cause us to define the macro in the first place (though the lack of libc implementation was part of it). I'll try to dig up the original issues. Repository: rG LLVM

[PATCH] D107547: [CodeGen] More bits for calling convention

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107547/new/ https://reviews.llvm.org/D107547 ___ cfe-commits mailing list

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. I'm guessing the tests were not pass on buildbot but passed on the author's side is due to the assertion was disabled on the author's side. Here is the patch for avoiding all the assertion errors and I'm able to get all the metadirective tests passed (and no regression

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

dexonsmith accepted this revision. dexonsmith added a comment. In D108976#2979598 , @jansvoboda11 wrote: > Tests that cover this functionality were moved into a follow-up patch D108974 > . The reason is to avoid

[PATCH] D108974: [clang][tooling] Properly initialize DiagnosticsEngine for cc1 command-line construction

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108974/new/ https://reviews.llvm.org/D108974

[PATCH] D108982: [clang][deps] Use correct DiagnosticOptions for command-line handling

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM too, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108982/new/ https://reviews.llvm.org/D108982

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. Our internal codebase never uses the target directive. Once the deferred diags is bypassed, we observed 18% e2e build time improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added a comment. gentle ping @tejohnson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36850/new/ https://reviews.llvm.org/D36850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang created this revision. Herald added subscribers: hoy, dexonsmith, wenlei, dang, guansong, yaxunl. weiwang requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. There are cases where no target

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG37f23ea97fde: [AIX][PowerPC] Define __powerpc and __PPC macros (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/

[clang] 37f23ea - [AIX][PowerPC] Define __powerpc and __PPC macros

Author: Jake Egan Date: 2021-09-02T13:32:35-04:00 New Revision: 37f23ea97fdef4484ef33877c6d8464beafd3b0f URL: https://github.com/llvm/llvm-project/commit/37f23ea97fdef4484ef33877c6d8464beafd3b0f DIFF: https://github.com/llvm/llvm-project/commit/37f23ea97fdef4484ef33877c6d8464beafd3b0f.diff

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl created this revision. jozefl added reviewers: asl, atrosinenko. Herald added a subscriber: hiraditya. jozefl requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. clang::driver::tools::getCPUName can now infer the CPU

[libunwind] 1bc175d - [Unwind] Cast exception class pointer for strcpy

Author: Hans Wennborg Date: 2021-09-02T19:01:30+02:00 New Revision: 1bc175d486b5bf2ae5dd46c1e85342f2f2734b1f URL: https://github.com/llvm/llvm-project/commit/1bc175d486b5bf2ae5dd46c1e85342f2f2734b1f DIFF: https://github.com/llvm/llvm-project/commit/1bc175d486b5bf2ae5dd46c1e85342f2f2734b1f.diff

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +addSystemInclude(DriverArgs, CC1Args, PathCPP.str()); +CC1Args.push_back("-D__LIBC_NO_CPP_MATH_OVERLOADS__"); +return; Maybe a comment as to why we need this,

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 370293. salman-javed-nz added a comment. Add additional checks in `test/clang-tidy/infrastructure/nolintbeginend.cpp` to check that error suppressions in one file are carried over when the file is `#included` in another file. Repository: rG LLVM

[clang] e5438f3 - clang/win: Add __readfsdword to intrin.h

Author: Nico Weber Date: 2021-09-02T12:22:07-04:00 New Revision: e5438f386854136d848989315f53788808afa37a URL: https://github.com/llvm/llvm-project/commit/e5438f386854136d848989315f53788808afa37a DIFF: https://github.com/llvm/llvm-project/commit/e5438f386854136d848989315f53788808afa37a.diff

[PATCH] D109085: clang/win: Add __readfsdword to intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5438f386854: clang/win: Add __readfsdword to intrin.h (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang-tools-extra] e1bb54b - [clangd, llvm] Remove redundant calls to c_str() (NFC)

Author: Kazu Hirata Date: 2021-09-02T09:07:13-07:00 New Revision: e1bb54b5930544b48c3a94069c037648a6adfc65 URL: https://github.com/llvm/llvm-project/commit/e1bb54b5930544b48c3a94069c037648a6adfc65 DIFF: https://github.com/llvm/llvm-project/commit/e1bb54b5930544b48c3a94069c037648a6adfc65.diff

[clang] 123f811 - Try to unbreak Win build after 973519826edb76

Author: Nico Weber Date: 2021-09-02T12:06:53-04:00 New Revision: 123f811fe5b0ba33f271c1c6172e6dff1463717a URL: https://github.com/llvm/llvm-project/commit/123f811fe5b0ba33f271c1c6172e6dff1463717a DIFF: https://github.com/llvm/llvm-project/commit/123f811fe5b0ba33f271c1c6172e6dff1463717a.diff

[PATCH] D109128: [VFS] Use original path when falling back to external FS

varungandhi-apple added a comment. cc @JDevlieghere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

kiranchandramohan added a comment. Thanks @peixin. I am going through the patch today and will accept or provide some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107430/new/ https://reviews.llvm.org/D107430 ___ cfe-commits

[PATCH] D109127: Use python 3 in add_new_check.py and rename_check.py

kbobyrev added a comment. Hey, thanks for noticing! Ugh, I think that's not good, I was trying to make sure the `io.open` piece really works with Python 2 and Python 3 as this was the purpose fo the patch :( I need t check that again, I think it's really unfortunate to lose Python 2 support

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

peixin added a comment. Here is the PR for codegen of ordered construct for LLVM Flang: https://github.com/flang-compiler/f18-llvm-project/pull/1027. I create the PR on fir-dev branch since the test of lowering parse-tree to MLIR for LLVM Flang is still not supported in upstream llvm-project.

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added a comment. Now this patch supports only one-dimensional arrays. Previously there were a bug when didn't take into account array's dimension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104285/new/ https://reviews.llvm.org/D104285

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

peixin added a comment. @Meinersbur Thanks a lot for your review and accepting this patch. BTW, I finished the implementation of the codegen of ordered construct for LLVM Flang and the OpenMP IRBuilder of ordered construct in this patch also works well for LLVM Flang. Is it OK to land this

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov updated this revision to Diff 370284. ASDenysPetrov retitled this revision from "[analyzer][AST] Retrieve value by direct index from list initialization of constant array declaration." to "[analyzer] Retrieve a value from list initialization of constant array declaration in a

[PATCH] D105092: [RISCV] Add the tail policy argument to builtins/intrinsics.

HsiangKai updated this revision to Diff 370285. HsiangKai added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 Files: llvm/include/llvm/IR/IntrinsicsRISCV.td

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Hi, Could anyone please review this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108370/new/ https://reviews.llvm.org/D108370 ___ cfe-commits mailing list

[PATCH] D108982: [clang][deps] Use correct DiagnosticOptions for command-line handling

arphaman accepted this revision. arphaman added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108982/new/ https://reviews.llvm.org/D108982 ___ cfe-commits mailing list

[PATCH] D108976: [clang][tooling] Accept custom diagnostic options in ToolInvocation

arphaman added a comment. In D108976#2979867 , @arphaman wrote: > Could you add a test case for this change? Maybe a unit test? Ah I see, you mentioned that the tests are in a follow-up patch. Sorry about that. Repository: rG LLVM Github Monorepo

  1   2   >