[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 371509. kito-cheng marked 2 inline comments as done. kito-cheng added a comment. Changes: - Address Jim's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. In D36850#2990847 , @modimo wrote: > In D36850#2990771 , @tejohnson wrote: > >> In D36850#2968536 , @modimo wrote: >> >>> In D36850#2964293

[PATCH] D109260: [RISCV] Add SiFive cores E and S series

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109260/new/ https://reviews.llvm.org/D109260

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12dcbf913c49: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h (authored by Pushpinder Singh pushpinderdhaliwa...@gmail.com).

[clang] 12dcbf9 - [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

Author: Pushpinder Singh Date: 2021-09-09T10:55:17+05:30 New Revision: 12dcbf913c49db839b3669db0dcacd5de25facde URL: https://github.com/llvm/llvm-project/commit/12dcbf913c49db839b3669db0dcacd5de25facde DIFF:

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

modimo added a comment. In D36850#2990771 , @tejohnson wrote: > In D36850#2968536 , @modimo wrote: > >> In D36850#2964293 , @tejohnson >> wrote: >> >>> Good point on

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

HsiangKai updated this revision to Diff 371499. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 Files: llvm/include/llvm/IR/IntrinsicsRISCV.td

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

NoQ added a comment. Thanks! Can you add a regression test for this, like D99260 does in `test/Analysis/inner-pointer.cpp`? We typically want all commits to have associated test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D36850: [ThinLTO] Add norecurse function attribute propagation

tejohnson added a comment. In D36850#2968536 , @modimo wrote: > In D36850#2964293 , @tejohnson wrote: > >> Good point on indirect calls. Rather than add a bit to the summary, can the >> flags just be set

[PATCH] D109386: Change to use ValueHandle for associated data of GlobalCtors

rnk added a comment. In D109386#2990606 , @wlei wrote: > I think this is what we desire. Do you think this can cause other issues or > anything I missed? I forgot to mention, yes, sounds good, I see, it is only weak when the value is erased without

[PATCH] D109386: Change to use ValueHandle for associated data of GlobalCtors

rnk added a comment. In D109386#2990606 , @wlei wrote: > Not swift, it seems this use-after-free needs a large program to repro, I > tried to simplify it but failed to expose it by small program. If you use an ASan build to detect the use-after-free,

[PATCH] D109386: Change to use ValueHandle for associated data of GlobalCtors

rjmccall added a comment. It shouldn't need a large program to duplicate, but the test will need to exercise some unusual, arguably invalid conditions. We need to add an entry with associated data to `GlobalCtors` or `GlobalDtors` and then replace the associated data. We only actually use

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:153 -/// bitcode library and add it to the LIBRARY_PATH. -// RUN: env LIBRARY_PATH=%S/Inputs/libomptarget %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \ -// RUN:

[PATCH] D109386: Change to use ValueHandle for associated data of GlobalCtors

wlei added a comment. In D109386#2990504 , @rnk wrote: > This seems incorrect: a weak VH won't have the same semantics, it will just > drop the comdat associativity when the underlying global changes type. @rnk Thanks. Here I tried to use

[PATCH] D108243: Revert "Avoid needlessly copying a block to the heap when a block literal"

waltl updated this revision to Diff 371467. waltl added a comment. Herald added a subscriber: dang. As suggested, I put the optimization behind an off-by-default flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108243/new/

[PATCH] D109260: [RISCV] Add SiFive cores E and S series

apivovarov added a comment. Craig, I fixed all of the issue on Fri. Could you look at the patch again? Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109260/new/ https://reviews.llvm.org/D109260

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a9d740c232e: [clang][Driver] Update/cleanup LTO logic to ensure that the last lto argument… (authored by mnadeem). Repository: rG LLVM Github

[clang] 0a9d740 - [clang][Driver] Update/cleanup LTO logic to ensure that the last lto argument is honored

Author: Usman Nadeem Date: 2021-09-08T15:53:49-07:00 New Revision: 0a9d740c232e1e4b71fcbbaf844211d70b06d873 URL: https://github.com/llvm/llvm-project/commit/0a9d740c232e1e4b71fcbbaf844211d70b06d873 DIFF: https://github.com/llvm/llvm-project/commit/0a9d740c232e1e4b71fcbbaf844211d70b06d873.diff

[clang] 78f7ad5 - [clang][Fuchsia] Remove COMPILER_RT_CAN_EXECUTE_TESTS

Author: Leonard Chan Date: 2021-09-08T15:52:02-07:00 New Revision: 78f7ad5a83c3b7f37b5331486c289eba1040d56a URL: https://github.com/llvm/llvm-project/commit/78f7ad5a83c3b7f37b5331486c289eba1040d56a DIFF: https://github.com/llvm/llvm-project/commit/78f7ad5a83c3b7f37b5331486c289eba1040d56a.diff

[clang] 54612a0 - Revert "[clang][Driver] Update/cleanup LTO logic to ensure that the last lto argument is honored"

Author: Usman Nadeem Date: 2021-09-08T15:49:35-07:00 New Revision: 54612a037aff42150e4c605e90a530fe1cc34c64 URL: https://github.com/llvm/llvm-project/commit/54612a037aff42150e4c605e90a530fe1cc34c64 DIFF: https://github.com/llvm/llvm-project/commit/54612a037aff42150e4c605e90a530fe1cc34c64.diff

[clang] d2d2e5e - [clang][Driver] Update/cleanup LTO logic to ensure that the last lto argument is honored

Author: Usman Nadeem Date: 2021-09-08T15:40:32-07:00 New Revision: d2d2e5ea480feb09dc0edeac2eb14310de74b372 URL: https://github.com/llvm/llvm-project/commit/d2d2e5ea480feb09dc0edeac2eb14310de74b372 DIFF: https://github.com/llvm/llvm-project/commit/d2d2e5ea480feb09dc0edeac2eb14310de74b372.diff

[PATCH] D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default

Szelethus added a comment. In D108753#2988632 , @NoQ wrote: > This looks good! > > I guess one way to make this //even more// conservative would be to match the > variable inside the delete-expression to the one we expect to get deallocated. Yeah, I

[PATCH] D109470: Add "profiling" to the list of absl libraries.

nilayvaish created this revision. nilayvaish requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109470 Files: clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h

[PATCH] D109386: Change to use ValueHandle for associated data of GlobalCtors

rnk added a comment. This seems incorrect: a weak VH won't have the same semantics, it will just drop the comdat associativity when the underlying global changes type. BTW, can this be tested, or is this only possible when clang is being used as a library, perhaps as in swift? Repository:

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

mizvekov added a comment. In D105756#2988022 , @NoQ wrote: > I don't think this is intended. @mizvekov, do you think you can add more hard > checks to make sure it's constrained to C++? (Or maybe there's another, more > precise solution?) Hello!

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s __enable_if_t as well.

dblaikie added a comment. Looks like most of the testing for the enable_if custom dialog was added in `clang/test/SemaTemplate/overload-candidates.cpp` in rG6f8d2c6c9c3451effdf075a7034bbe77045bfeba . (improved in

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

wlei added a comment. @rnk @rjmccall Thanks for the suggestion! @wenlei Thanks for the helpful example! Changed to use ValueHandle(WeakTrackingVH) for this, please see if this looks good to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

wlei updated this revision to Diff 371455. wlei added a comment. change to use ValueHandle for associated data Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109386/new/ https://reviews.llvm.org/D109386 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

alishuja created this revision. alishuja added reviewers: NoQ, steakhal, xazax.hun, ASDenysPetrov. Herald added subscribers: manas, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. alishuja requested review of this revision. Herald added a

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 371450. JonChesterfield added a comment. - Use regex for windows path compat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files:

[clang] e62f4f1 - [openmp] 41c73671d0, this time with staged patch applied

Author: Jon Chesterfield Date: 2021-09-08T22:07:47+01:00 New Revision: e62f4f172e34b9283ce04c871512165c78ef5f39 URL: https://github.com/llvm/llvm-project/commit/e62f4f172e34b9283ce04c871512165c78ef5f39 DIFF:

[clang] 41c7367 - [openmp] Re-enable test from D109057, now with windows path aware regex

Author: Jon Chesterfield Date: 2021-09-08T21:57:38+01:00 New Revision: 41c73671d0b851c601ceb85c7e38afa21819bde7 URL: https://github.com/llvm/llvm-project/commit/41c73671d0b851c601ceb85c7e38afa21819bde7 DIFF:

[PATCH] D109461: [clang][darwin] Add support for --emit-static-lib

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This uses darwin's default libtool since llvm-ar isn't normally available. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109461 Files:

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG806ff3c4a42c: [AIX] Check for typedef properly when getting preferred type align (authored by stevewan). Repository: rG LLVM Github Monorepo

[clang] 806ff3c - [AIX] Check for typedef properly when getting preferred type align

Author: Steven Wan Date: 2021-09-08T16:21:52-04:00 New Revision: 806ff3c4a42c7393a0bbeab3dd1c0295f61ad457 URL: https://github.com/llvm/llvm-project/commit/806ff3c4a42c7393a0bbeab3dd1c0295f61ad457 DIFF: https://github.com/llvm/llvm-project/commit/806ff3c4a42c7393a0bbeab3dd1c0295f61ad457.diff

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

rjmccall accepted this revision. rjmccall added a comment. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109387/new/ https://reviews.llvm.org/D109387 ___ cfe-commits mailing list

[PATCH] D101400: [Driver] Add -print-multiarch-triple

jrtc27 added a comment. Answering the last part myself: GCC only has MULTIARCH_DIRNAME definitions for various linux-gnu*, linux-musl, linux-uclibc, kfreebsd-gnu and -gnu (as an OS, for GNU/Hurd) targets, everything else prints a blank string here. So either we need to decide what the right

[PATCH] D101400: [Driver] Add -print-multiarch-triple

jrtc27 added a comment. This includes the version number, at least for FreeBSD, in its output, which doesn't make a huge deal of sense to me. This then breaks the build of Python because it generates a module with a name like `_sysconfigdata__freebsd14_x86_64-unknown-freebsd14.0.py`, and when

[PATCH] D109460: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

ldionne added a comment. Herald added a subscriber: ormris. @arphaman This is a WIP patch -- I'm trying to see whether this idea is good or just bad from the start. To summarize, people have been complaining (e.g. here ) that Clang on Darwin doesn't

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. @alokmishra.besu do you mind if I push the patch for solving those assertions with rebase? The patch does not change the logic in your program and I've made sure that the tests could pass in debug mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109460: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

ldionne created this revision. ldionne added a reviewer: arphaman. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On Apple platforms, the base system does not contain headers (e.g. in /usr/include). As a result, one needs to

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 371419. JonChesterfield added a comment. - Keep LIBRARY_PATH search, as fallback if local file is missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061

LLVM lab and buildbot master are back to normal

Hello everyone, The LLVM lab and buildbot master are back to normal, up and running. Died network hardware has been replaced. Please let me know if you still see issues. Sorry for the inconvenience and thanks for your patience. Thanks Galina ___

[PATCH] D109451: Summary: Introduce a new frontend flag `-fswift-async-fp={auto|always|never}` that controls how code generation sets the Swift extended async frame info bit. There are three possibili

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Looks great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109451/new/ https://reviews.llvm.org/D109451

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan updated this revision to Diff 371418. stevewan added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109387/new/ https://reviews.llvm.org/D109387 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s __enable_if_t as well.

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This seems reasonable to me. Comment at: clang/lib/Sema/SemaTemplate.cpp:3514 /// Determine whether this alias template is "enable_if_t". +/// libc++ >=14 uses

[PATCH] D109387: [NFC][AIX] Check for typedef properly when getting preferred type align

stevewan added a comment. In D109387#2987843 , @rjmccall wrote: > Oh, no, I don't think this is NFC. It seems very likely that there's some > case where the behavior is distinguishable. Maybe a typedef of a record with > an alignment attribute? > >

[clang] 59cc39a - [ObjC][ARC] Use the addresses of the ARC runtime functions instead of

Author: Akira Hatanaka Date: 2021-09-08T11:56:22-07:00 New Revision: 59cc39ae141f92c01836064cd033c537f16dec5e URL: https://github.com/llvm/llvm-project/commit/59cc39ae141f92c01836064cd033c537f16dec5e DIFF:

[PATCH] D102996: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of integer 0/1 for the operand of bundle "clang.arc.attachedcall"

This revision was automatically updated to reflect the committed changes. Closed by commit rG59cc39ae141f: [ObjC][ARC] Use the addresses of the ARC runtime functions instead of (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D102996?vs=347291=371412#toc Repository:

[PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

zhouyizhou added a comment. In D109408#2988417 , @ldionne wrote: > FWIW, I dislike that we don't indent stuff at all inside namespaces -- often > I find it useful to indent things inside short-lived namespaces. But let's go > for simplicity and

Re: [PATCH] D109408: [libcxxabi] NFC: fix incorrect indentation of braces

Hi， On Wed, Sep 8, 2021 at 10:01 AM zhouyizhou via Phabricator wrote: > > zhouyizhou added a comment. > > In D109408#2988417 , @ldionne wrote: > > > FWIW, I dislike that we don't indent stuff at all inside namespaces -- > > often I find it useful to

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5673564a06b: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on… (authored by leonardchan). Repository: rG LLVM Github

[clang] e567356 - [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

Author: Leonard Chan Date: 2021-09-08T11:32:11-07:00 New Revision: e5673564a06b7792c6aa9afe3d82f8b2203f975e URL: https://github.com/llvm/llvm-project/commit/e5673564a06b7792c6aa9afe3d82f8b2203f975e DIFF: https://github.com/llvm/llvm-project/commit/e5673564a06b7792c6aa9afe3d82f8b2203f975e.diff

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

woodruffw added a comment. Another gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 ___ cfe-commits mailing list

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

yaxunl added a comment. In D109175#2989823 , @weiwang wrote: > In D109175#2987048 , @jdoerfert > wrote: > >> In D109175#2986782 , @yaxunl wrote: >> >>> I agree with

[PATCH] D108493: [HIP] Warn capture this pointer in device lambda

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26e492e134c0: [HIP] Warn capture this pointer in device lambda (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github

[clang] 26e492e - [HIP] Warn capture this pointer in device lambda

Author: Yaxun (Sam) Liu Date: 2021-09-08T13:45:26-04:00 New Revision: 26e492e134c006c63b3d9f9f9eabdeba014b1d2c URL: https://github.com/llvm/llvm-project/commit/26e492e134c006c63b3d9f9f9eabdeba014b1d2c DIFF:

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Nice, thanks! I'll wait for the main CI to come back up before trying that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 ___

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

Meinersbur added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu.c:178 // CHK-BCLIB-USER: clang{{.*}}-triple{{.*}}nvptx64-nvidia-cuda{{.*}}-mlink-builtin-bitcode{{.*}}libomptarget-nvptx-test.bc - +// CHK-BCLIB-USER-DIR:

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

weiwang added a comment. In D109175#2987048 , @jdoerfert wrote: > In D109175#2986782 , @yaxunl wrote: > >> I agree with Johannes and Alexey that deferred diags are only needed when >>

[PATCH] D109451: Summary: Introduce a new frontend flag `-fswift-async-fp={auto|always|never}` that controls how code generation sets the Swift extended async frame info bit. There are three possibili

aschwaighofer created this revision. aschwaighofer added reviewers: doug.gregor, t.p.northover. Herald added subscribers: ormris, dexonsmith, dang. aschwaighofer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `auto`: the default, which

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. I am not familiar with offloading side of LTO driver but the change looks functionally the same to me. Thanks for doing this! Remember to update the commit message with the correct

[PATCH] D108493: [HIP] Warn capture this pointer in device lambda

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCUDA.cpp:881-882 + } else if (Capture.isThisCapture() && !LangOpts.HIP) { +// Capture of this pointer is allowed for HIP since this pointer

[PATCH] D108493: [HIP] Warn capture this pointer in device lambda

tra added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:881-882 + } else if (Capture.isThisCapture() && !LangOpts.HIP) { +// Capture of this pointer is allowed for HIP since this pointer may be +// pointing to managed memory which is accessible on both device

[PATCH] D108493: [HIP] Warn capture this pointer in device lambda

yaxunl updated this revision to Diff 371363. yaxunl marked an inline comment as done. yaxunl retitled this revision from "[HIP] Allow capture this pointer in device lambda" to "[HIP] Warn capture this pointer in device lambda". yaxunl edited the summary of this revision. CHANGES SINCE LAST

[PATCH] D108493: [HIP] Allow capture this pointer in device lambda

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:881-882 + } else if (Capture.isThisCapture() && !LangOpts.HIP) { +// Capture of this pointer is allowed for HIP since this pointer may be +// pointing to

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s __enable_if_t as well.

Quuxplusone updated this revision to Diff 371350. Quuxplusone retitled this revision from "[clang] Enable the special enable_if_t diagnostics for libc++'s _EnableIf as well." to "[clang] Enable the special enable_if_t diagnostics for libc++'s __enable_if_t as well.". Quuxplusone edited the

[PATCH] D108567: Implement #pragma clang final extension

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3968-3984 +Final Macros + + +Clang supports the pragma ``#pragma clang final``, which can be used to +mark macros as final, meaning they cannot be undef'd or re-defined. For example:

[clang] 608338c - [OpenMP][NFC] Added comment on OpenMP 5.0 task affinity pilot implementation

Author: AndreyChurbanov Date: 2021-09-08T18:12:31+03:00 New Revision: 608338cca579900a85f60a501adf6fa378c5 URL: https://github.com/llvm/llvm-project/commit/608338cca579900a85f60a501adf6fa378c5 DIFF:

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. In D109061#2989363 , @JonChesterfield wrote: > @tianshilei1992 can we agree that the tests must point to a specific > deviceRTL, and not dig one out of LIBRARY_PATH? That can be factored out of > this patch to make the

[PATCH] D109386: Fix use-after-free from GlobalCtors associated data

wenlei added a comment. Yes, this looks like the kind of stuff VH is designed for. @wlei here's an example of how VH is used to handle deletion of BFI of basic blocks: https://reviews.llvm.org/D75341. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch is in a series of patches to provide builtins for

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. Discussed at weekly call. Going to go with the priority order: 1/ commandline argument 2/ look next to clang 3/ LIBRARY_PATH 4/ error That means people who have installed clang+openmp together have something that works out of the box, and they can override the

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. @tianshilei1992 can we agree that the tests must point to a specific deviceRTL, and not dig one out of LIBRARY_PATH? That can be factored out of this patch to make the tests always use exactly the library that was just built, and also makes them easier to run

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

SjoerdMeijer added inline comments. Comment at: llvm/test/CodeGen/ARM/cmse-cve-2021-35465-return.ll:6 +; RUN: FileCheck %s --check-prefix=CHECK-8M-FP-CVE-2021-35465 + +%indirect = type { double, double, double, double, double, double, double, double } As

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1796 +// trigger an error. +def RISCVOverlayCall : InheritableAttr { + let Spellings = [GCC<"overlaycall">]; jrtc27 wrote: > aaron.ballman wrote: > > edward-jones wrote: > > >

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1796 +// trigger an error. +def RISCVOverlayCall : InheritableAttr { + let Spellings = [GCC<"overlaycall">]; aaron.ballman wrote: > edward-jones wrote: > > jrtc27 wrote: > > > If you

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

jsji added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration,

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1793-1795 +// This is not marked as a TargetSpecificAttr because that would trigger +// an 'attribute ignored' warning, but we want to check it explicitly and +// trigger an error.

[PATCH] D109060: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support

Jake-Egan added inline comments. Comment at: clang/test/Modules/ExtDebugInfo.cpp:208 - -// CHECK: !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !{{[0-9]+}}, entity: ![[STRUCT]], file: ![[CPP]], line: 27) +// CHECK: !DIImportedEntity(tag:

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s _EnableIf as well.

ldionne added a comment. Actually, scratch that, we could tweak this patch so it accepts `__enable_if_t` as well (that will be the new spelling for `enable_if_t` for pre-C++14 places going forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s _EnableIf as well.

ldionne added a comment. This shouldn't be necessary anymore since we won't be using `_EnableIf` in libc++ going forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109411/new/ https://reviews.llvm.org/D109411

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

edward-jones added a comment. In D109372#2987411 , @jrtc27 wrote: > In D109372#2987405 , @MaskRay wrote: > >> The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and >> overlayfs, I am

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

aaron.ballman added a comment. Is this syntax used by any other tools? Comment at: clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:6 + +// NOLINTEND +class B1 { B1(int i); }; Do you think this should be diagnosed as a sign of user

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc updated this revision to Diff 371315. sherwin-dc added a comment. - Consolidate test cases into one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 Files:

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc marked 2 inline comments as done. sherwin-dc added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 371308. salman-javed-nz added a comment. clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp: - Added test to check what happens when NOLINTEND marker is used before NOLINTBEGIN marker (class B1 , line

[clang] 9838076 - [clang-offload-bundler] Make Bundle Entry ID backward compatible

Author: Saiyedul Islam Date: 2021-09-08T16:06:12+05:30 New Revision: 98380762c3b734c23d206182605ab9e035c93caa URL: https://github.com/llvm/llvm-project/commit/98380762c3b734c23d206182605ab9e035c93caa DIFF:

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

This revision was automatically updated to reflect the committed changes. Closed by commit rG98380762c3b7: [clang-offload-bundler] Make Bundle Entry ID backward compatible (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added a comment. Thanks a lot @benshi001! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103136/new/ https://reviews.llvm.org/D103136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Atomics in C++ for OpenCL 2021 are now handled the same way as in

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders added a comment. I’d say commit as is and have a look at the SmallVector -> unit32_t thing together with the std::map issue afterwards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://reviews.llvm.org/D108320

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin added a comment. In D109321#2987783 , @jdoerfert wrote: > As noted before, this is not the right fix. Not inlining should not cause a > semantic difference here, the problem is something else. @jdoerfert Yes, I agree that this is not the right

[PATCH] D109199: [compiler-rt][Fuchsia] Support building + running compiler-rt tests on fuchsia's host toolchain

phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109199/new/ https://reviews.llvm.org/D109199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

nridge added a comment. I'm happy to commit it. Did you want to make the `SmallVector<1>` --> `uint32_t` change, or should I just commit it as is? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/ https://reviews.llvm.org/D108320

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

tom-anders added a comment. Yeah, I‘d need someone to commit this for me. About the std::map thing: let’s proceed as suggested and have @sammccall take look at it himself after :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108320/new/

[PATCH] D109411: [clang] Enable the special enable_if_t diagnostics for libc++'s _EnableIf as well.

dblaikie added a comment. Would at. least need a test case, but otherwise sounds OK to make things a bit better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109411/new/ https://reviews.llvm.org/D109411

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. Ping? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

janosimas added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >