[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. In D109632#3021644 , @rmaz wrote: > @vsapsai just checking on where we are with this one. Is the current plan to > investigate an approach only serializing the methods declared in each module, > or are we good to go ahead with

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. In D109632#3013620 , @dexonsmith wrote: > In D109632#3013523 , @vsapsai wrote: > >> 2. Serialize only methods owned by the current module (and change >> `ReadMethodPoolVisitor`

[clang] 37adc4f - [clang] set templates as invalid when any of the parameters are invalid

Author: Matheus Izvekov Date: 2021-09-25T04:04:47+02:00 New Revision: 37adc4f957c2383a625e2e593ba1d18a25d92b91 URL: https://github.com/llvm/llvm-project/commit/37adc4f957c2383a625e2e593ba1d18a25d92b91 DIFF:

[PATCH] D110460: [clang] set templates as invalid when any of the parameters are invalid

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37adc4f957c2: [clang] set templates as invalid when any of the parameters are invalid (authored by mizvekov). Repository: rG LLVM Github Monorepo

[PATCH] D110460: [clang] set templates as invalid when any of the parameters are invalid

mizvekov created this revision. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. See PR51872 for the original repro. This fixes a crash when converting a templated constructor into a deduction guide, in case any of the template

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. In D110128#3021876 , @thakis wrote: > Note that stage 2 fails, where we're supposed to use lld. So I think this is > probably some compiler-rt test config problem you need to sort out, and not a > fundamental problem with the

[PATCH] D110463: [CMake] Pass through CMAKE_READELF to subbuilds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd893692024b8: [CMake] Pass through CMAKE_READELF to subbuilds (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d893692 - [CMake] Pass through CMAKE_READELF to subbuilds

Author: Petr Hosek Date: 2021-09-24T18:20:30-07:00 New Revision: d893692024b8f05c63329f9a4e5f2432380be27c URL: https://github.com/llvm/llvm-project/commit/d893692024b8f05c63329f9a4e5f2432380be27c DIFF: https://github.com/llvm/llvm-project/commit/d893692024b8f05c63329f9a4e5f2432380be27c.diff

[PATCH] D110463: [CMake] Pass through CMAKE_READELF to subbuilds

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This matches handling of other CMake

[PATCH] D110458: [clang] Put original flags on 'Driver args:' crash report line

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. We used to put the canonical spelling of flags after alias processing on that line. For clang-cl in particular, that meant that we put flags on that line that the clang-cl driver doesn't even

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

amyk updated this revision to Diff 374990. amyk edited the summary of this revision. amyk added a comment. Addressed Lei's review comments to output: error: option '-mpcrel' cannot be specified without '-mcpu=pwr10 -mprefixed' when PC-Rel is specified pre-P10. Also updated the comment for

[PATCH] D110455: DebugInfo: Use clang's preferred names for integer types

dblaikie created this revision. dblaikie added reviewers: probinson, aprantl. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts c7f16ab3e3f27d944db72908c9c1b1b7366f5515 / r109694 - which suggested this was done to

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan added a comment. Updated to exclude readelf. We also don't need any of the other tools added in the `NOT COMPILER_RT_STANDALONE_BUILD` case, so I just added them to `LIT_ONLY_TOOLS` in the `COMPILER_RT_STANDALONE_BUILD` case. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 374984. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625 Files: compiler-rt/cmake/Modules/AddCompilerRT.cmake compiler-rt/test/CMakeLists.txt Index:

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added a comment. In D110089#3021652 , @jlebar wrote: > Okay, I give up on the phab interface. It's unreadable with all the existing > comments and lint errors. Yeah. Phabricator experience is not great. > +// Put all functions into anonymous

[PATCH] D110452: [modules] Fix tracking ObjCInterfaceType decl when there are multiple definitions.

vsapsai added a comment. This is a clean-up before https://reviews.llvm.org/D110453 Comment at: clang/lib/AST/DeclObjC.cpp:608 - // Make the type point at the definition, now that we have one. - if (TypeForDecl) -cast(TypeForDecl)->Decl = this; Tracking

[PATCH] D110453: [modules] Update visibility for merged ObjCInterfaceDecl definitions.

vsapsai created this revision. vsapsai added reviewers: bruno, bnbarham. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. We keep using the first encountered definition and need to take into account visibility from subsequent

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 374979. tra added a comment. More comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/lib/Headers/CMakeLists.txt

[PATCH] D110452: [modules] Fix tracking ObjCInterfaceType decl when there are multiple definitions.

vsapsai created this revision. vsapsai added reviewers: bruno, rsmith, arphaman. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. With the old approach we were updating `ObjCInterfaceType.Decl` to the last encountered definition. But

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

thakis added a comment. Re-reverted for now in 6ece82e9006d16b7fba7660ce09b2c62ab8460fa . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/

[clang] 6ece82e - Revert "[Driver] Correctly handle static C++ standard library"

Author: Nico Weber Date: 2021-09-24T18:44:53-04:00 New Revision: 6ece82e9006d16b7fba7660ce09b2c62ab8460fa URL: https://github.com/llvm/llvm-project/commit/6ece82e9006d16b7fba7660ce09b2c62ab8460fa DIFF: https://github.com/llvm/llvm-project/commit/6ece82e9006d16b7fba7660ce09b2c62ab8460fa.diff

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

thakis added a comment. Note that stage 2 fails, where we're supposed to use lld. So I think this is probably some compiler-rt test config problem you need to sort out, and not a fundamental problem with the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

thakis added a comment. This breaks our packaging builders too: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8835201798501639249/+/u/package_clang/stdout?format=raw Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

salman-javed-nz updated this revision to Diff 374969. salman-javed-nz added a comment. Pre-merge build error doesn't seem related to my change, but rebasing patch anyway just to be sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108560/new/

[PATCH] D110445: [NFC] Avoid some AttrBuilder redundant initialization

nikic added a comment. Wouldn't this go against https://llvm.org/docs/CodingStandards.html#do-not-use-static-constructors? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110445/new/ https://reviews.llvm.org/D110445

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. Using to `PrivateLinkage`, all the profc/profd for each weak symbol will be *local* to objects, and all kept in the csect, so we won't have problem. The downside is that we won't be able to discard the duplicated counters and profile data, but those can not be discarded

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. We have verified all the profile counters in SPEC , all are OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 ___ cfe-commits mailing

[PATCH] D109557: Adds a BreakBeforeClosingParen option

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. In D109557#3021312 , @MyDeveloperDay wrote: > FYI, this is a very aggressive change, I highly recommend you run

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

HazardyKnusperkeks added a comment. In D110432#3021391 , @MyDeveloperDay wrote: > I agree this looks better > > F19213646: image.png Full support for that. And for the whole change. Comment at:

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

jlebar added a comment. Presumably as a separate commit we should add tests to the test_suite repository to ensure that this at least still compiles with different versions of CUDA? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/

[PATCH] D109693: Driver: Remove major release version detection for RHEL

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, please reformat the code though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109693/new/

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

jlebar accepted this revision. jlebar added a comment. Okay, I give up on the phab interface. It's unreadable with all the existing comments and lint errors. Hope you don't mind comments this way. I'm just going to put it all in a giant code block so it doesn't get wrapped or whatever. +//

[PATCH] D110392: [clang-format] Left/Right alignment fixer can cause false positive replacements when they don't actually change anything

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:95 + if (Err) +llvm::errs() << "Error removing no op replacements : " + << llvm::toString(std::move(Err)) << "\n"; The message may

[PATCH] D109632: [clang] de-duplicate methods from AST files

rmaz added a comment. @vsapsai just checking on where we are with this one. Is the current plan to investigate an approach only serializing the methods declared in each module, or are we good to go ahead with the set de-duplication approach? I tried profiling with D110123

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. In D110422#3021572 , @jsji wrote: > In D110422#3021535 , @MaskRay wrote: > >> The description is still unclear. >> >> Say a.o has a weak `foo, __profc_foo, __profd_foo`, b.o has a weak

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. In D110422#3021535 , @MaskRay wrote: > The description is still unclear. > > Say a.o has a weak `foo, __profc_foo, __profd_foo`, b.o has a weak `foo, > __profc_foo, __profd_foo`. > The linker picks the definitions from `a.o`. In

[PATCH] D36850: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

modimo added inline comments. Comment at: clang/test/CodeGen/thinlto-funcattr-prop.ll:17 -; CHECK: ^2 = gv: (guid: 13959900437860518209, summaries: (function: (module: ^0, flags: (linkage: external, visibility: default, notEligibleToImport: 0, live: 1, dsoLocal: 1,

[PATCH] D36850: [ThinLTO] Add noRecurse and noUnwind thinlink function attribute propagation

modimo updated this revision to Diff 374934. modimo marked an inline comment as done. modimo added a comment. Complete explanation in thinlto-funcattr-prop.ll, also fix up diff to contain all changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. The description is still unclear. Say a.o has a weak `foo, __profc_foo, __profd_foo`, b.o has a weak `foo, __profc_foo, __profd_foo`. The linker picks the definitions from `a.o`. In the PGO implementation, it doesn't whether the non-discarded b.o `__profd_foo` has

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

feg208 added a comment. I am. I'll jump on this over the weekend. Sorry been a bit buried in my day job Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/ https://reviews.llvm.org/D101868 ___

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. Pos_Rel __profc_weak_func notation is just the normal relocation to symbol __profc_weak_func. The relocation here is to calculate the relative pointer (offset) to __profc__weak_func from __profd__weak__func. In example above, the offsets value after binding will be the

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. In D110422#3021283 , @jsji wrote: >> In other binary formats the first weak definition is selected and other weak >> definitions are discarded. >> Do you mean that AIX ld doesn't pick the first weak definition? > > No. I think

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov updated this revision to Diff 374921. mizvekov added a comment. update print-type.cpp test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 Files:

[PATCH] D110436: [WIP] Add %n format specifier warning

lebedev.ri added a comment. The patch description says what the change is, but not why it is the way it is. In particular, it might be helpful to be more verbose than just stating that something is unsafe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

xgupta added a comment. Nice work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay added a comment. I agree this looks better F19213646: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110432/new/ https://reviews.llvm.org/D110432

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

krasimir added a comment. I like this. Consider only displaying the major version (e.g., `clang-format 14` instead of `clang-format 14.0.0`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110432/new/ https://reviews.llvm.org/D110432

[PATCH] D110436: [WIP] Add %n format specifier warning

Jaysonyan created this revision. Jaysonyan added reviewers: leonardchan, phosek. Jaysonyan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This warning is to dissuade developers from using the potentially unsafe %n format specifier.

Re: [clang] 38c09ea - DebugInfo: Add (initially no-op) -gsimple-template-names={simple, mangled}

On Thu, Sep 23, 2021 at 7:12 AM wrote: > Resending to cfe-commits instead of llvm-commits (doh!). > > > -Original Message- > > From: Robinson, Paul > > Sent: Thursday, September 23, 2021 10:05 AM > > To: David Blaikie ; 'llvm-comm...@lists.llvm.org' > > > > Cc: Adrian Prantl ; Jonas

[clang] 8ec7d9b - DebugInfo: Move the '=' version of -gsimple-template-names to the frontend

Author: David Blaikie Date: 2021-09-24T11:18:10-07:00 New Revision: 8ec7d9b8f875368a5f92596332cd05059df6bbd2 URL: https://github.com/llvm/llvm-project/commit/8ec7d9b8f875368a5f92596332cd05059df6bbd2 DIFF: https://github.com/llvm/llvm-project/commit/8ec7d9b8f875368a5f92596332cd05059df6bbd2.diff

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

MyDeveloperDay added a comment. There are a number of bugs logged against this feature, are you still around to look into them? https://bugs.llvm.org/show_bug.cgi?id=51926 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101868/new/

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. anirudhp marked an inline comment as done. Closed by commit rGe09a1dc47515: [SystemZ][z/OS] Add GOFF Support to the DataLayout (authored by anirudhp). Repository:

[clang] e09a1dc - [SystemZ][z/OS] Add GOFF Support to the DataLayout

Author: Anirudh Prasad Date: 2021-09-24T14:09:01-04:00 New Revision: e09a1dc47515d27ba5ca572a225208bb0d79fb3f URL: https://github.com/llvm/llvm-project/commit/e09a1dc47515d27ba5ca572a225208bb0d79fb3f DIFF:

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); rnk wrote: > hsmhsm wrote: > > jdoerfert wrote: > > > arsenm

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

Conanap updated this revision to Diff 374908. Conanap added a comment. Fixed an old test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110273/new/ https://reviews.llvm.org/D110273 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D109557: Adds a BreakBeforeClosingParen option

MyDeveloperDay added a comment. FYI, this is a very aggressive change, I highly recommend you run this over a large code base before landing. to double check, here is one slight oddity which I cannot determine if its correct or not. void foo() { if (quitelongarg != (alsolongarg - 1)) {

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374906. Conanap added a comment. This modifies a test case introduced in this commit: https://github.com/llvm/llvm-project/commit/3678df5ae6618eec656ae0ea0dab3be09d73bc9a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/

[PATCH] D109541: Increase expected line number for ExtDebugInfo.cpp

aprantl added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109541/new/ https://reviews.llvm.org/D109541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added a comment. > In other binary formats the first weak definition is selected and other weak > definitions are discarded. > Do you mean that AIX ld doesn't pick the first weak definition? No. I think this is exactly what is causing problem here. eg: if we have two weak symbols

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. In D110128#3020468 , @nemanjai wrote: > In D110128#3018992 , @phosek wrote: > >> @MaskRay Do you think we should gate the use of this feature on >> `-fbinutils-version=` or

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

sammccall added a comment. Just nits left really. In D110386#3020890 , @tschuett wrote: > Do you want to wrap the `unsigned` in a struct to make it slightly safer, but > more complicated to use? I like this idea, though it's probably not a huge deal

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM (without the integrated assembler there will be an assembler invocation in the compilation database that actually produces the `.o` instead of the clang invocation we are looking

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay added a comment. This is just a very rough idea, feel free to pull it apart. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110432/new/ https://reviews.llvm.org/D110432 ___ cfe-commits

[PATCH] D110432: [clang-format][docs] mark new clang-format configuration options based on which version they would GA

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, krasimir. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. Sometimes I see people unsure about which versions they can use in clang-format

[clang] e8e2edd - Fix test from 8dd42f, capitalization in test

Author: Erich Keane Date: 2021-09-24T10:24:32-07:00 New Revision: e8e2edd8ca88f8b0a7dba141349b2aa83284f3af URL: https://github.com/llvm/llvm-project/commit/e8e2edd8ca88f8b0a7dba141349b2aa83284f3af DIFF: https://github.com/llvm/llvm-project/commit/e8e2edd8ca88f8b0a7dba141349b2aa83284f3af.diff

[clang] 77d200a - Add test for DR1307, which we have already implemented.

Author: Erich Keane Date: 2021-09-24T10:24:32-07:00 New Revision: 77d200a546136c2855063613ff4bca1f682fb23a URL: https://github.com/llvm/llvm-project/commit/77d200a546136c2855063613ff4bca1f682fb23a DIFF: https://github.com/llvm/llvm-project/commit/77d200a546136c2855063613ff4bca1f682fb23a.diff

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 374897. saiislam marked an inline comment as done. saiislam added a comment. Added nvptx test cases, simplified amdgpu test case, modified commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. > we can NOT guarantee that the relocations get resolved to the intended weak > symbol, so we can not ensure the correctness of the relative CounterPtr, so > we have to use private linkage for counter and data symbols. In other binary formats the first weak definition

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:413 } else -BCLibs.push_back(AsanRTL.str()); +BCLibs.push_back({AsanRTL.str(), false}); } tra wrote: > Nit: I'd add

[PATCH] D108370: [clang-tidy] Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

aaron.ballman closed this revision. aaron.ballman added a comment. In D108370#3020793 , @Sockke wrote: > In D108370#3017800 , @aaron.ballman > wrote: > >> LGTM! > > Thanks for your review! I don't have commit

[clang-tools-extra] e490248 - Fix wrong FixIt about union in cppcoreguidelines-pro-type-member-init

Author: liuke Date: 2021-09-24T13:15:21-04:00 New Revision: e4902480f1e2f12f73c2b504e3d717536653dd7b URL: https://github.com/llvm/llvm-project/commit/e4902480f1e2f12f73c2b504e3d717536653dd7b DIFF: https://github.com/llvm/llvm-project/commit/e4902480f1e2f12f73c2b504e3d717536653dd7b.diff LOG:

[PATCH] D110431: Explicitly specify -fintegrated-as to clang/test/Driver/compilation_database.c test case.

amyk created this revision. amyk added reviewers: hubert.reinterpretcast, daltenty, sammccall. amyk added a project: clang. amyk requested review of this revision. It appears that this test assumes that the toolchain utilizes the integrated assembler by default, since the expected output in the

[PATCH] D110429: [OpenMP] Introduce a new worksharing RTL function for distribute

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch adds a new RTL

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869 + // symbol, so we can not ensure the correctness of the relative CounterPtr, so + // we have to use private linkage for counter and data symbols. + if

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e1aaf18af6c: [PowerPC] Mark splat immediate instructions as rematerializable (authored by NeHuang). Changed prior to commit: https://reviews.llvm.org/D108823?vs=369101=374892#toc Repository: rG

[PATCH] D110428: [AIX] Define WCHAR_T_TYPE as unsigned short on AIX for wchar.c test case.

amyk created this revision. amyk added reviewers: hubert.reinterpretcast, daltenty, thakis. amyk added projects: clang, PowerPC. amyk requested review of this revision. The default wchar type is different on AIX vs. Linux. When this test is run on AIX, WCHAR_T_TYPE ends up being set to `int`.

[PATCH] D110421: Write test for CWG1772/CWG1779, mark them 'done', and update cxx_dr_status.html

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some nits, thank you! Comment at: clang/test/CXX/drs/dr17xx.cpp:75 // Direct-list-initialization of a non-class object - int a{0};

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:413 } else -BCLibs.push_back(AsanRTL.str()); +BCLibs.push_back({AsanRTL.str(), false}); }

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374891. quinnp added a comment. Rebase with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

NeHuang added inline comments. Comment at: clang/test/Sema/ppc-mma-builtins.c:1 +// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown -target-cpu pwr10 \ +// RUN: -target-feature -mma -fsyntax-only %s -verify can you please add `// REQUIRES:

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

quinnp updated this revision to Diff 374888. quinnp added a comment. Addressing nit in SemaChecking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109437/new/ https://reviews.llvm.org/D109437 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:752 +static void unescapeSlashes(SmallVectorImpl ) { + auto Read = Str.begin(); rnk wrote: > aganea wrote: > > rnk wrote: > > > This isn't unescaping them, it's just

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea updated this revision to Diff 374884. aganea marked 5 inline comments as done. aganea edited reviewers, added: akhuang; removed: zturner, gratianlup. aganea edited subscribers, added: zturner, gratianlup; removed: aganea. aganea added a comment. Herald added subscribers: dang, mgorny. As

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869 + // symbol, so we can not ensure the correctness of the relative CounterPtr, so + // we have to use private linkage for counter and data symbols. + if

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

NeHuang added a comment. Do we already have a backend test case for `fdiv` emitting a software estimate when `-Ofast` is used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji updated this revision to Diff 374879. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:978 if (NS == 0 && !(DataReferencedByCode && NeedComdat && !Renamed) && - (TT.isOSBinFormatELF() || + (TT.isOSBinFormatELF() || TT.isOSBinFormatXCOFF() ||

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:869 + // symbol, so we can not ensure the correctness of the relative CounterPtr, so +

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:103 +if (!ArraySize) { + auto *EBB = AllocaInsertPt->getParent(); + auto Iter = AllocaInsertPt->getIterator(); hsmhsm wrote: > jdoerfert wrote: > > arsenm wrote: > > > Why is there

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0240e6c89d: [PowerPC] Add range check for vec_genpcvm builtins (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 3b0240e - [PowerPC] Add range check for vec_genpcvm builtins

Author: Quinn Pham Date: 2021-09-24T11:15:44-05:00 New Revision: 3b0240e6c89d9201430ee83b09fe7c94256e8838 URL: https://github.com/llvm/llvm-project/commit/3b0240e6c89d9201430ee83b09fe7c94256e8838 DIFF: https://github.com/llvm/llvm-project/commit/3b0240e6c89d9201430ee83b09fe7c94256e8838.diff

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:27 char test_lbarx(volatile unsigned char *a) { // CHECK-LABEL: @test_lbarx Do you also need to update the input argument type here as well to match

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

yaxunl updated this revision to Diff 374868. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110304/new/ https://reviews.llvm.org/D110304 Files:

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 374869. hsmhsm added a comment. Remove "!llvm.access.group" metadata from check lines in test files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files:

[PATCH] D110304: [HIP] Fix linking of asanrt.bc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:116-117 + // Enums corresponding to clang options for linking bitcode, i.e., + // -mlink-builtin-bitcode or -mlink-bitcode-file + enum BitCodeLinkOpt {

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

frasercrmck added a comment. In D93298#3014160 , @jrtc27 wrote: > The amount of duplication here really depresses me and is only going to get > worse once codegen is added, but TableGen isn't able to have operands that > use different register classes

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji updated this revision to Diff 374867. jsji added a comment. Restore the limitation of sample profiling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

lei accepted this revision as: lei. lei added a comment. LGTM Pleases address nit on commit. Comment at: clang/lib/Sema/SemaChecking.cpp:3495-3496 +ArgType != QualType(Context.DoubleTy)) { + Diag(TheCall->getBeginLoc(), diag::err_ppc_invalid_test_data_class_type);

[PATCH] D110386: [clangd] Refactor IncludeStructure: use File (unsigned) for most computations

tschuett added a comment. Do you want to wrap the `unsigned` in a struct to make it slightly safer, but more complicated to use? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110386/new/ https://reviews.llvm.org/D110386

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:219 +def GPR32Pairs : RegisterTuples<[gpr32_pair_lo, gpr32_pair_hi], +[(add X0, X2, X4, X6, + X8, X10, X12, X14,

  1   2   >