[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf updated this revision to Diff 378561. qiucf added a comment. Add codegen test to show generated type in IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.llvm.org/D109950 Files: clang/lib/Basic/TargetInfo.cpp

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

yonghong-song added a comment. @aaron.ballman Ping. This is to address your concern in D110127 , could you take a look whether my proposal for a new attribute btf_type_tag will be okay for you or not? Thanks! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111518: Add release note about `TypeLoc` matchers.

jcking1034 created this revision. jcking1034 added reviewers: ymandel, aaron.ballman, tdl-g. jcking1034 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111518 Files:

[PATCH] D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fc0d439a4b6: [Clang] [PowerPC] Fix header include typo in smmintrin.h (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D111482?vs=378414=378550#toc Repository: rG LLVM Github

[clang] 2fc0d43 - [Clang] [PowerPC] Fix header include typo in smmintrin.h

Author: Qiu Chaofan Date: 2021-10-11T10:44:08+08:00 New Revision: 2fc0d439a4b6dd231f5b40e67e5c4c5863f5ae45 URL: https://github.com/llvm/llvm-project/commit/2fc0d439a4b6dd231f5b40e67e5c4c5863f5ae45 DIFF: https://github.com/llvm/llvm-project/commit/2fc0d439a4b6dd231f5b40e67e5c4c5863f5ae45.diff

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added a comment. Thanks for all the changes. You've addressed all my questions ad I don't have anything more to add. Let's wait for the reviewers to take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ https://reviews.llvm.org/D111208

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru added a comment. @Quuxplusone fixed, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 ___ cfe-commits mailing list

[clang] b07ea8a - clang release notes: improve the wording

Author: Sylvestre Ledru Date: 2021-10-10T22:26:11+02:00 New Revision: b07ea8a967c5e77b42eeac9307fa006b7df87ca4 URL: https://github.com/llvm/llvm-project/commit/b07ea8a967c5e77b42eeac9307fa006b7df87ca4 DIFF:

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea added a subscriber: dexonsmith. aganea added a comment. In D80833#3052551 , @dexonsmith wrote: > In D80833#2069411 , @aganea wrote: > >> In D80833#2069246 , @amccarth

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

Quuxplusone added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 -- ... +- -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands xbolva00 wrote: > I think we should mention that with boolean

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c8f950a0400: clang release notes: document the -Wbool-operation improvement (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9c8f950 - clang release notes: document the -Wbool-operation improvement

Author: Sylvestre Ledru Date: 2021-10-10T21:28:40+02:00 New Revision: 9c8f950a04004736bddb5093eda15f9a1c4f2eea URL: https://github.com/llvm/llvm-project/commit/9c8f950a04004736bddb5093eda15f9a1c4f2eea DIFF:

[clang] 62abc18 - clang: Add range-based CFG::try_blocks()

Author: Nico Weber Date: 2021-10-10T15:15:37-04:00 New Revision: 62abc1842bc8b4860f9f7c1165164740fccef64e URL: https://github.com/llvm/llvm-project/commit/62abc1842bc8b4860f9f7c1165164740fccef64e DIFF: https://github.com/llvm/llvm-project/commit/62abc1842bc8b4860f9f7c1165164740fccef64e.diff

[clang] 23d5fe6 - clang: Convert two loops to for-each

Author: Nico Weber Date: 2021-10-10T14:55:46-04:00 New Revision: 23d5fe6235e599388a1cb3c52596ff22cd557a9c URL: https://github.com/llvm/llvm-project/commit/23d5fe6235e599388a1cb3c52596ff22cd557a9c DIFF: https://github.com/llvm/llvm-project/commit/23d5fe6235e599388a1cb3c52596ff22cd557a9c.diff

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:407-409 + if (!NolintBegins.empty() && + (NolintBegins.back().second == NolintBracket)) { +NolintBegins.pop_back();

[PATCH] D77598: Integral template argument suffix and cast printing

dblaikie added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1101 Out << ", "; -Args[I].print(Policy, Out); +if (TemplOverloaded || !Params) + Args[I].print(Policy, Out, /*IncludeType*/ true); dblaikie wrote: > Looks like this (&

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added a comment. @aaron.ballman Let me know if this addresses your comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111041/new/ https://reviews.llvm.org/D111041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp updated this revision to Diff 378514. carlosgalvezp edited the summary of this revision. carlosgalvezp added a comment. Added an extra RUN line to run the checks also for the alias, cppcoreguidelines-explicit-virtual-functions. CHANGES SINCE LAST ACTION

[clang] 0e9373a - [Basic] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2021-10-10T08:52:14-07:00 New Revision: 0e9373a6a638430c67fa8378c774003acfcf5990 URL: https://github.com/llvm/llvm-project/commit/0e9373a6a638430c67fa8378c774003acfcf5990 DIFF: https://github.com/llvm/llvm-project/commit/0e9373a6a638430c67fa8378c774003acfcf5990.diff

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added a comment. Oh, I found `misc-non-private-member-in-classes` that does what you proposed. I'll add another `RUN` line to run the `cppcoreguidelines` check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111041/new/ https://reviews.llvm.org/D111041

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp added a comment. Regarding test coverage, I'm unsure if what you propose is intended. I have looked at similar aliases and I can't find any test at all for them either. For example `modernize-avoid-c-arrays` is aliased by "cppcoreguidelines" and "hicpp" and I cannot find tests

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

carlosgalvezp updated this revision to Diff 378510. carlosgalvezp added a comment. Added documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111041/new/ https://reviews.llvm.org/D111041 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:325 StringRef Line, size_t *FoundNolintIndex = nullptr, - bool *SuppressionIsSpecific = nullptr) { +

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 378507. carlosgalvezp marked 9 inline comments as done. carlosgalvezp added a comment. Fixed comments from @salman-javed-nz CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111208/new/ https://reviews.llvm.org/D111208 Files:

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

SamuelMarks added a comment. In D111490#3053564 , @xgupta wrote: > The patch is not applying cleanly so can't be committed. please follow the > above phabricator docs I suggested before to upload it. Oh there was an error in the web interface which

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 378501. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

HsiangKai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:446 SuppressionErrors.emplace_back(Error.getValue()); -return false; } carlosgalvezp wrote: > I had to remove these "return false",

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

salman-javed-nz added a comment. In D111208#3053660 , @carlosgalvezp wrote: > Now, the requirements for a match are stricter (and simpler), making the code > easier to reason about: any NOLINTBEGIN(X) must be matched by an identical > NOLINTEND(X),

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:446 SuppressionErrors.emplace_back(Error.getValue()); -return false; } I had to remove these "return false", otherwise I would not get

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

carlosgalvezp updated this revision to Diff 378495. carlosgalvezp added a comment. Refactored NOLINTBEGIN/END slightly. Now, the requirements for a match are stricter (and simpler), making the code easier to reason about: any NOLINTBEGIN(X) must be matched by an identical NOLINTEND(X), for any