[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 384344. pcwang-thead marked an inline comment as done. pcwang-thead added a comment. Adds `ADDITIONAL_COMPILE_FLAGS` and guard macros to: - `libcxx\test\std\language.support\support.dynamic\new.delete\new.delete.single\sized_delete14.pass.cpp` -

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

noajshu created this revision. Herald added subscribers: ormris, dexonsmith, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: MaskRay. Herald added a reviewer: gkm. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. noajshu requested review of this

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence marked 4 inline comments as done. achieveartificialintelligence added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 384337. achieveartificialintelligence added a comment. Address @asb 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files:

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

manmanren added a comment. This commit seems to cause some regression for "-save-temps" as there is no new line before the pragma. See the below test case, -E will output int test();#pragma clang assume_nonnull It will fail the compilation on the preprocessed output with error: expected

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

rjmccall added a comment. Mostly LGTM, although I am not the most unbiased reviewer. :) Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:839 +def err_ptrauth_disabled : + Error<"pointer authentication is disabled for the current target">; +def

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

vsapsai added a comment. I'm not going to cover the entire change, some parts I need to consider more carefully. There can be other reasons to keep `IncludeMap` out of `SubmoduleState` but I'm not sure the local submodule visibility is the right reason. I might be reading the code incorrectly

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Lets keep AddressSanitizerPass for a while, we don't have to remove it in the same patch Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1289 +

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka updated this revision to Diff 384303. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D113072: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

vitalybuka updated this revision to Diff 384302. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113072/new/ https://reviews.llvm.org/D113072 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. @aaron.ballman I checked the source. Looks like we can easily get TypeLoc from TypeSourceInfo, but not from TypeSourceInfo to TypeLoc. But We need TypeLoc so we can get attr information and also traverse TypeLoc's.. We might be able to pass TypeSourceInfo in a

[PATCH] D113072: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

vitalybuka updated this revision to Diff 384292. vitalybuka added a comment. unused var Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113072/new/ https://reviews.llvm.org/D113072 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks added a comment. Turns out the comments are misleading, they aren't to prevent specific functions from being removed, they're to force an odr usage of various functions, which in turn makes sure that globals in the corresponding translation units with the function definition are

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3104558 , @dblaikie wrote: > In D107049#3103984 , @lhames wrote: > >> In D107049#3101456 , @dblaikie >> wrote: >> >>> Yeah, seems

[PATCH] D113072: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

vitalybuka created this revision. Herald added subscribers: ormris, hiraditya. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113072 Files:

[clang] ee4634f - [NFC][asan] Fix confusing variable name

Author: Vitaly Buka Date: 2021-11-02T16:49:15-07:00 New Revision: ee4634f7feb38982bd90192e3d2866c07db3e065 URL: https://github.com/llvm/llvm-project/commit/ee4634f7feb38982bd90192e3d2866c07db3e065 DIFF: https://github.com/llvm/llvm-project/commit/ee4634f7feb38982bd90192e3d2866c07db3e065.diff

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

apazos added a comment. The plan to push support for ptrauth_sign_constant, and ptrauth_type_discriminator/ptrauth_string_discriminator in a separate patch is good. This current patch is already big. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

apazos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:839 +def err_ptrauth_disabled : + Error<"pointer authentication is disabled for the current target">; +def err_ptrauth_invalid_key : These two error types are confusing.

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

dblaikie added a comment. In D107049#3103984 , @lhames wrote: > In D107049#3101456 , @dblaikie > wrote: > >> In D107049#3100630 , @rnk wrote: >> >>> So, to back up a

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. Hmm. When I try to compile an object file where the resolver is a declaration, both clang-13, clang-14, and gcc-9.3 complain that the ifunc must point to a defined function: void *foo_resolver(); void foo(void) __attribute__((ifunc("foo_resolver"))); clang (13

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. In D112883#3101685 , @GMNGeoffrey wrote: > In D112883#3101665 , @chandlerc > wrote: > >> However, I thought with Bazel having a consistent repo name was important to >> allow

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang updated this revision to Diff 384239. avogelsgesang marked 2 inline comments as done. avogelsgesang added a comment. Use `llvm::Optional` instead of pointer as suggested by @ymandel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112914: Misleading identifier detection

rsmith added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingIdentifier.h:2 +//===--- MisleadingIdentifierCheck.h - clang-tidy *- C++ +//-*-===// +// This needs fixing too. CHANGES SINCE LAST ACTION

[PATCH] D112913: Misleading bidirectional detection

rsmith added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:59 +// If conversion fails, utf-8 is designed so that we can just try next char. +if (Result != llvm::conversionOK) { + ++CurPtr; Is there a

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

eugenis added a comment. You are absolutely right. X86 variant uses an "=a" constraint (rax register), others pin the output variable to a specific register with __asm__ declaration. It appears we've missed it in Aarch64. Could you check if __asm__("x0") in the declaration of res helps?

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. > [...] If we want to follow container-size-empty's convention, we should > include the replaced method in the name [...] Note that this commit is slightly different from `container-size-empty`: it doesn't only replace `count(...)` by `contains(...)` but also

[clang] 60a085b - Revert "[clang] deprecate frelaxed-template-template-args, make it on by default"

Author: Yaxun (Sam) Liu Date: 2021-11-02T17:02:19-04:00 New Revision: 60a085beb04b055cf44c379c56cb247cb3587658 URL: https://github.com/llvm/llvm-project/commit/60a085beb04b055cf44c379c56cb247cb3587658 DIFF:

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 384220. Jake-Egan added a comment. Fix llvm/test/DebugInfo/omit-empty.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files:

[PATCH] D113043: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a91bc7bf436: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp (authored by HarrietAkot, committed by aartbik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8a91bc7 - [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

Author: HarrietAkot Date: 2021-11-02T13:54:33-07:00 New Revision: 8a91bc7bf436d345cc1b26d0073753a7f5e66e10 URL: https://github.com/llvm/llvm-project/commit/8a91bc7bf436d345cc1b26d0073753a7f5e66e10 DIFF: https://github.com/llvm/llvm-project/commit/8a91bc7bf436d345cc1b26d0073753a7f5e66e10.diff

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan created this revision. Herald added subscribers: ormris, lxfind, pengfei, arphaman, steven_wu, hiraditya. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D113043: [mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

aartbik accepted this revision. aartbik added a comment. This revision is now accepted and ready to land. I removed the quotes from the title, no need for these. Also, please address the last open question (on arc diff --update). But good to go as revision. I have approved the revision and

[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"

HarrietAkot added a comment. In D113043#3103979 , @aartbik wrote: > Did you see my comment on clang/docs/tools/clang-formatted-files.txt? > You will need to update that file too (SparseUtils.cpp -> > SparseTensorUtils.cpp) > > after that this revision

[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"

aartbik added a comment. One last question, I just noticed you started a whole new revision (instead of updating https://reviews.llvm.org/D112995). Was that intentional? If you use arc, then arc diff first time creates one, but subsequent updates should use arc diff ... --update D to

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. In D109496#3103978 , @mizvekov wrote: > Feel free to revert it if this is blocking you. I don't seem to find a way to > do it via web interface, so I need more time to have access to a machine that > can do it I will revert it

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. In D109496#3103963 , @mizvekov wrote: > Thanks for reporting this! > > This change in the standard was worked a long time ago, and there was some > expectation that there would be follow up work to add new partial ordering >

[PATCH] D113043: "[mlir][sparse]Rename SparseUtils.cpp library to SparseTensorUtils.cpp"

HarrietAkot updated this revision to Diff 384203. HarrietAkot marked an inline comment as done. HarrietAkot added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - "Updating clang-formatted-files" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3101456 , @dblaikie wrote: > In D107049#3100630 , @rnk wrote: > >> So, to back up a bit, do I understand correctly that this change adds tests >> to the check-clang test suite

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov added a comment. Feel free to revert it if this is blocking you. I don't seem to find a way to do it via web interface, so I need more time to have access to a machine that can do it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

mizvekov added a comment. Thanks for reporting this! This change in the standard was worked a long time ago, and there was some expectation that there would be follow up work to add new partial ordering rules so that reasonable code would keep working. But the person behind that effort

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rnk accepted this revision. rnk added a comment. Looks good from my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___ cfe-commits mailing list

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks added a comment. Looks good, and I really need this to land, to expand it. ;) Comment at: clang/include/clang/Format/Format.h:3369 +/// \endcode +bool AfterForeachMacros; +/// If ``true``, put a space before opening parentheses only if the

[PATCH] D113000: [clang-format] NOT FOR COMMIT - Demo of AutomaticBraces: Remove

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3230 return false; - } else if (Style.isCSharp()) { -// Require spaces around '{' and before '}' unless they appear in -// interpolated strings. Interpolated strings are

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. In D95168#3102247 , @owenpan wrote: > In D95168#3100969 , @MyDeveloperDay > wrote: > >> In D95168#3099920 , @owenpan wrote: >> >>> In

[PATCH] D112975: Fix complex types declared using mode TC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c8d3053fa0c: Fix complex types declared using mode TC (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 5c8d305 - Fix complex types declared using mode TC

Author: Elizabeth Andrews Date: 2021-11-02T12:00:26-07:00 New Revision: 5c8d3053fa0c183ea4f908e51a111ada3d4031f2 URL: https://github.com/llvm/llvm-project/commit/5c8d3053fa0c183ea4f908e51a111ada3d4031f2 DIFF:

[PATCH] D112664: [clang-format][docs] fix indentation of rst code block

HazardyKnusperkeks added a comment. In D112664#3101142 , @MyDeveloperDay wrote: > This should be Format.h, didn't we recently fix this? Yes we did, this is from before. :) So it is now obsolete. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3177-3179 + if (!Args.hasArg(options::OPT_mstack_protector_guard_offset_EQ)) { +D.Diag(diag::err_drv_ssp_missing_offset_argument) +<< A->getOption().getName() << Value;

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

sammccall added a comment. In D112996#3102925 , @ckandeler wrote: >> WDYT about detecting QT headers specifically? It seems hacky, but I don't >> see a way out of this that doesn't involve hardcoding some filenames. Are >> they in a directory like

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

ardb marked 2 inline comments as done. ardb added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:160-161 +if (ThreadPointer == ReadTPMode::Cp15 && +getARMSubArchVersionNumber(Triple) < 7 && +llvm::ARM::parseArch(Triple.getArchName()) !=

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

ardb updated this revision to Diff 384175. ardb edited the summary of this revision. ardb added a comment. Fix test issue and add more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113026/new/ https://reviews.llvm.org/D113026 Files:

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. I reverted this patch locally and try building with clang modules (`-DLLVM_ENABLE_MODULE=On`) which confirmed it was causing the build failure on the bots. I had to revert your patch upstream to fix our bots. If you need some help to reproduce the build failure, let me

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. Hi @Ericson2314, I think this patch broke our macOS lldb-incremental bot on GreenDragon (https://green.lab.llvm.org/green/job/lldb-cmake/37560/console). Could you please take a look ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3177-3179 + if (!Args.hasArg(options::OPT_mstack_protector_guard_offset_EQ)) { +D.Diag(diag::err_drv_ssp_missing_offset_argument) +<< A->getOption().getName() <<

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Herald added a subscriber: luke957. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay updated this revision to Diff 384171. MyDeveloperDay removed a reviewer: klimek. MyDeveloperDay set the repository for this revision to rG LLVM Github Monorepo. MyDeveloperDay added a comment. Add some more testcases to catch handling removing {} from the nested if, but not the

[clang] 797b50d - Revert "Use `GNUInstallDirs` to support custom installation dirs. -- LLVM"

Author: Med Ismail Bennani Date: 2021-11-02T19:11:44+01:00 New Revision: 797b50d4be873b4662983413a06806fca544c276 URL: https://github.com/llvm/llvm-project/commit/797b50d4be873b4662983413a06806fca544c276 DIFF:

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

nickdesaulniers added a comment. Thanks for the patch! Don't forget to run `git-clang-format HEAD~`. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:160-161 +if (ThreadPointer == ReadTPMode::Cp15 && +getARMSubArchVersionNumber(Triple) < 7 && +

[clang] 5a892be - [clang] Fix cmake error

Author: Dave Lee Date: 2021-11-02T10:47:44-07:00 New Revision: 5a892be237a20002c88a80b618e6f5febfd7a4f6 URL: https://github.com/llvm/llvm-project/commit/5a892be237a20002c88a80b618e6f5febfd7a4f6 DIFF: https://github.com/llvm/llvm-project/commit/5a892be237a20002c88a80b618e6f5febfd7a4f6.diff

[PATCH] D113021: [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d3953499c8c: [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 2d39534 - [cmake] Make LLVM_ENABLE_LLD=ON work better on macOS

Author: Nico Weber Date: 2021-11-02T13:35:21-04:00 New Revision: 2d3953499c8ca73c12e9417f5c4516c8a930a689 URL: https://github.com/llvm/llvm-project/commit/2d3953499c8ca73c12e9417f5c4516c8a930a689 DIFF: https://github.com/llvm/llvm-project/commit/2d3953499c8ca73c12e9417f5c4516c8a930a689.diff

[clang] 98b761f - [RISCV] Rename vfredusum/vfredosum intrinsic test files. Merge some tests. NFC

Author: Craig Topper Date: 2021-11-02T10:33:20-07:00 New Revision: 98b761fce68b194674a98f347c641f8ce3e85eff URL: https://github.com/llvm/llvm-project/commit/98b761fce68b194674a98f347c641f8ce3e85eff DIFF: https://github.com/llvm/llvm-project/commit/98b761fce68b194674a98f347c641f8ce3e85eff.diff

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb updated this revision to Diff 384154. ardb added a comment. - fix failure in newly added LLVM test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112768/new/ https://reviews.llvm.org/D112768 Files:

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

rsmith added a comment. I think the idea of this change is OK. The key is that the dereference expression will still be type-dependent, even if we happen to actually know its type. (For an `Expr` that `isTypeDependent()`, the type produced by `getType()` isn't something the standard knows or

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some possible nits. Comment at: clang/lib/Serialization/ASTWriter.cpp:5018 Record.AddStmt(A->getAllocator()); +Record.AddStmt(A->getAlignment());

[PATCH] D113029: [clangd] Find definition of ClassTemplate without going through index.

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. I noticed that, while go-to-def works

[PATCH] D113026: [ARM] reject -mtp=cp15 if target subarch does not support it

ardb created this revision. ardb added reviewers: nickdesaulniers, peter.smith, rengolin, kees, ostannard. Herald added a subscriber: kristof.beyls. ardb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, we permit -mtp=cp15 even

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

aaron.ballman added a comment. In D112453#3084394 , @courbet wrote: > As per the comment in BuiltinTypes.def (see below), `Dependent` is > allowed in context where the type is deducible, but is there any reason > **not** to deduce the type if we can do

[PATCH] D112975: Fix complex types declared using mode TC

eandrews added a comment. In D112975#3101720 , @rjmccall wrote: > For posterity in case someone tracks down this review: `TC` corresponds to an > unspecified 128-bit format, which on some targets is a double-double format > (like `__ibm128_t`) and on

[clang] e2024d7 - Revert "[NFC] Remove LinkAll*.h"

Author: Arthur Eubanks Date: 2021-11-02T09:08:09-07:00 New Revision: e2024d72fae778e0369127e078a40b4d6eb6c7bd URL: https://github.com/llvm/llvm-project/commit/e2024d72fae778e0369127e078a40b4d6eb6c7bd DIFF:

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fd2db04d0f2: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fe364e5 - [NFC] Remove LinkAll*.h

Author: Arthur Eubanks Date: 2021-11-02T08:43:17-07:00 New Revision: fe364e5dc78c58a915986d9a44cfd65f919a00c2 URL: https://github.com/llvm/llvm-project/commit/fe364e5dc78c58a915986d9a44cfd65f919a00c2 DIFF:

[PATCH] D112971: [NFC] Remove LinkAll*.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe364e5dc78c: [NFC] Remove LinkAll*.h (authored by aeubanks). Herald added a subscriber: awarzynski. Changed prior to commit:

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb updated this revision to Diff 384116. ardb added a comment. - add diagnostics to the frontend and asserts to the backend to ensure that the TLS stack protector is only used on target subarchs that implement the hardware TLS register to begin with - ensure that the offset parameter is not

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong updated this revision to Diff 384122. martong added a comment. - Add essay about complexity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106823/new/ https://reviews.llvm.org/D106823 Files:

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384118. serge-sans-paille added a comment. Minor typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1699-1701 + ProgramStateRef OldState; + do { +OldState = State; steakhal wrote: > IMO we should have a `llvm::Statistic` here, tracking the maximum

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong updated this revision to Diff 384117. martong marked 3 inline comments as done. martong added a comment. - Reach the fixpoint by recursively calling `State->assume` on the simplified symbol. - Address review nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet added a comment. Ping ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112453/new/ https://reviews.llvm.org/D112453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 384114. jcking1034 added a comment. Update documentation for `capturesVar` matcher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491 Files:

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 384111. serge-sans-paille added a comment. - recover from failed utf8 decoding - doc and release note updated - clang-formatting - more examples / testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/

[PATCH] D111866: [RISCV] Support Zfhmin extension

asb added inline comments. Herald added a subscriber: luke957. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1153 bool ForCodeSize) const { - if (VT == MVT::f16 && !Subtarget.hasStdExtZfh()) + if (VT == MVT::f16 &&

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5880c835bdbe: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions (authored by sammccall). Repository: rG LLVM Github

[clang] 5880c83 - [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

Author: Sam McCall Date: 2021-11-02T15:35:53+01:00 New Revision: 5880c835bdbe50542a19c3e4065d1536db711443 URL: https://github.com/llvm/llvm-project/commit/5880c835bdbe50542a19c3e4065d1536db711443 DIFF: https://github.com/llvm/llvm-project/commit/5880c835bdbe50542a19c3e4065d1536db711443.diff

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang added a subscriber: alexfh. avogelsgesang added a comment. >> Those relative paths are meant to be resolved relative to the corresponding >> build directory. > > Is this behavior documented somewhere? I couldn't find this documented anywhere. My assumption is based on behavior

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. In D112914#3102728 , @carlosgalvezp wrote: > Ok! I don't really know what applies when you take //part// of a file, so > I'll leave that up to people who know. I don't know how to remove the > "Requested changes"

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. I note now that asserts build fails for it: https://godbolt.org/z/r738hGoKf Should this be reverted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112349/new/ https://reviews.llvm.org/D112349

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

erichkeane added a comment. So I've noticed in my downstream that this fires in the cpu-dispatch.c codegen test, though it doesn't seem to catch it here? I'm not sure how this happens, but from your description, it SEEMS like this case https://godbolt.org/z/nejWhbsxa should cause this error.

[libclc] 6fd2db0 - Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Author: John Ericson Date: 2021-11-02T10:23:30-04:00 New Revision: 6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 URL: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 DIFF: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73.diff

[clang] 6fd2db0 - Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Author: John Ericson Date: 2021-11-02T10:23:30-04:00 New Revision: 6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 URL: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73 DIFF: https://github.com/llvm/llvm-project/commit/6fd2db04d0f22ea22c5317d98ce2126aa64b6a73.diff

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

sammccall added a comment. Thanks, and sorry for sitting on this so long. Addressed comments. I think the failing windows bots were implicit `-fms-extensions` or so that sometimes makes diagnosis more lazy. Moving the test to recovery-expr-type.cpp should take care of this as that test case

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 384089. pcwang-thead added a comment. Makes required changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 Files:

[PATCH] D108451: [Sema] Avoid crash in CheckEnumConstant with contains-error expressions

sammccall updated this revision to Diff 384084. sammccall marked 3 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108451/new/ https://reviews.llvm.org/D108451 Files:

[PATCH] D112001: [Clang] Add min/max reduction builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7999355106fb: [Clang] Add min/max reduction builtins. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7999355 - [Clang] Add min/max reduction builtins.

Author: Florian Hahn Date: 2021-11-02T15:01:42+01:00 New Revision: 7999355106fb2fcc8de243d2e34b4b73ae4f3d2f URL: https://github.com/llvm/llvm-project/commit/7999355106fb2fcc8de243d2e34b4b73ae4f3d2f DIFF: https://github.com/llvm/llvm-project/commit/7999355106fb2fcc8de243d2e34b4b73ae4f3d2f.diff

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. > WDYT about detecting QT headers specifically? It seems hacky, but I don't see > a way out of this that doesn't involve hardcoding some filenames. Are they in > a directory like `"qt-11/QFoo"` that we can recognize? Even Q followed by > another capital letter might

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay updated this revision to Diff 384070. MyDeveloperDay added a comment. Herald added a subscriber: mgorny. Move BraceInserter into its own file and tests Add experimental support for "Remove" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/

[PATCH] D112889: [analyzer] Dump checker name if multiple checkers evaluate the same call

steakhal added a comment. Committed with the requested changes. Comment at: clang/lib/StaticAnalyzer/Core/CheckerManager.cpp:679 +#ifndef NDEBUG + if (evaluated && evaluatorChecker.hasValue()) { +const auto dump = [](const CallEvent ) -> std::string {

[PATCH] D112889: [analyzer] Dump checker name if multiple checkers evaluate the same call

This revision was automatically updated to reflect the committed changes. steakhal marked 2 inline comments as done. Closed by commit rG9b5c9c469d90: [analyzer] Dump checker name if multiple checkers evaluate the same call (authored by steakhal). Herald added a project: clang. Herald added a

[clang] 9b5c9c4 - [analyzer] Dump checker name if multiple checkers evaluate the same call

Author: Balazs Benics Date: 2021-11-02T14:42:14+01:00 New Revision: 9b5c9c469d90227251d9da9108ee7985ba415f2b URL: https://github.com/llvm/llvm-project/commit/9b5c9c469d90227251d9da9108ee7985ba415f2b DIFF: https://github.com/llvm/llvm-project/commit/9b5c9c469d90227251d9da9108ee7985ba415f2b.diff

  1   2   >