[PATCH] D113168: [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

ikudrin created this revision. ikudrin added reviewers: arphaman, aaron.ballman, rsmith. Herald added a subscriber: mgrang. ikudrin requested review of this revision. Herald added a project: clang. `llvm::MapVector`, compared to `std::map`, guarantees the same iteration order in different runs.

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. This patch is waiting for an action for a long time. I am expecting at-least anyone of the reviewers to either say "yes" or "no" or "further required improvements" on this patch so that I can take further action on this patch. If you say "no" to this patch with a

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 384661. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

skan marked 3 inline comments as done. skan added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8 + // CHECK: @arr = internal global [10 x i32] + // CHECK: call void asm sideeffect inteldialect "mov dword ptr $0[edx * $$4],edx",

[PATCH] D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)

ricejasonf added a comment. In D108482#3105889 , @tambre wrote: > I presume you lack the permissions to push this to the main repo yourself. > Would you like me to do that for you? Yes, please. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. @lxfind @Quuxplusone @lewissbaker Thanks for looking into this! I have committed this. Since the remained problem is that whether or not should we support the case that user uses "std::coroutine*" and "std::experimental::coroutine*" at the same time. As the reason we

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

pengfei added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8 + // CHECK: @arr = internal global [10 x i32] + // CHECK: call void asm sideeffect inteldialect "mov dword ptr $0[edx * $$4],edx", "=*m,{{.*}}([10 x i32]* @arr) + __asm mov dword

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5748-5750 +else if (isa(Cur)) + Diag(Loc, diag::err_invalid_declarator_in_export) + << Name << cast(DC) << SS.getRange(); ChuanqiXu wrote: > aaron.ballman wrote: > >

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7784-7785 "because namespace %1 does not enclose namespace %2">; +def err_invalid_declarator_in_export : Error<"cannot export %0 here " + "because it had be declared in %1.">; def

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. In D111863#3071356 , @steven_wu wrote: > In D111863#3071328 , @housel wrote: > >> In D111863#3069279 , @lhames wrote: >> >>> I think the ORC

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared

ChuanqiXu updated this revision to Diff 384645. ChuanqiXu retitled this revision from "[C++20] [Module] Fix front end crashes when trying to export a type out of a module " to "[C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared". ChuanqiXu

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

Sockke added a comment. This seems to be an existing check. Have you compared it with **bugprone-string-constructor**? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

lxfind accepted this revision. lxfind added a comment. I also agree that we should try to keep the compiler simple and not support the complicated case. It should be fairly straightforward for a codebase to update fully to use std instead of std::experimental (we have a large coroutine codebase

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

vsapsai added a comment. In D112915#3106472 , @jansvoboda11 wrote: > That's interesting. I think `HeaderFileInfo::isImport` should definitely be > tracked in the preprocessor, not in `HeaderFileInfo`. The fact that the > header was `#import`ed is not

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1759 // It is widely common for MS InlineAsm to use a global variable and one/two // registers in a mmory expression, and though unaccessible via rip/eip. if (IsGlobalLV &&

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1511 + if (ClUseStackSafety && SSGI != nullptr && findAllocaForValue(Ptr) && +

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

nemanjai requested changes to this revision. nemanjai added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5001 + case ISD::INTRINSIC_VOID: { +if (N->getConstantOperandVal(1) == Intrinsic::ppc_tdw || +

[PATCH] D110123: [clang][objc] Speed up populating the global method pool from modules.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/ https://reviews.llvm.org/D110123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110123: [clang][objc] Speed up populating the global method pool from modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a35cc40b881: [clang][objc] Speed up populating the global method pool from modules. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0a35cc4 - [clang][objc] Speed up populating the global method pool from modules.

Author: Volodymyr Sapsai Date: 2021-11-03T17:11:14-07:00 New Revision: 0a35cc40b881a35c6a7a748f5fdefac4cafc33ce URL: https://github.com/llvm/llvm-project/commit/0a35cc40b881a35c6a7a748f5fdefac4cafc33ce DIFF:

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

skan marked 2 inline comments as done. skan added inline comments. Comment at: llvm/test/CodeGen/X86/ms-inline-asm-array.ll:15-22 +!llvm.module.flags = !{!0, !1, !2} +!llvm.ident = !{!3} + +!0 = !{i32 1, !"wchar_size", i32 4} +!1 = !{i32 7, !"uwtable", i32 1} +!2 = !{i32 7,

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

skan marked 3 inline comments as done. skan added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8 + // CHECK: @arr = internal global [10 x i32] + // CHECK: call void asm sideeffect inteldialect "mov dword ptr $0[edx * $$4],edx",

[PATCH] D110123: [clang][objc] Speed up populating the global method pool from modules.

vsapsai updated this revision to Diff 384606. vsapsai added a comment. Rebase. Hopefully MLIR build is fixed and I'll be able to see relevant pre-merge check results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110123/new/

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 384599. CJ-Johnson added a comment. Add missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 384598. CJ-Johnson added a comment. Remove mistaken changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 384597. CJ-Johnson added a comment. Remove mistaken changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

eugenis added a comment. The approach looks reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111639: [Sema] check PseudoObject when rebuilding CXXOperatorCallExpr in template instantiation

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Sorry for the delay Comment at: clang/lib/Sema/TreeTransform.h:14576 !Second->getType()->isOverloadableType()) return

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

noajshu updated this revision to Diff 384592. noajshu added a comment. Rebase against main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113080/new/ https://reviews.llvm.org/D113080 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. I'll first explain my thought process about the representation of aliases and ifuncs in the IR, and why I think both aliasees and resolvers must always be defined; I hope I'm not completely off track and would love it if @MaskRay could weigh in as to whether I make

[PATCH] D113146: Fix the assertion in Sema::ActOnDependentMemberExpr

ychen created this revision. ychen added a reviewer: rsmith. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 617007240cbfb97c introduced the use of

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384587. kstoimenov added a comment. Restored StackSafetyAnalysis.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D113145: Remove two sema checkings as assertions introduced by D79719.

ychen created this revision. ychen added reviewers: hubert.reinterpretcast, Xiangling_L. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sema layer should handle these already. Otherwise checking build of the compiler would crash for

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

kstoimenov updated this revision to Diff 384583. kstoimenov added a comment. After removing function pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112098/new/ https://reviews.llvm.org/D112098 Files:

[PATCH] D112732: [ASan] Process functions in Asan module pass

aeubanks added a comment. can we rename "asan-module" to "asan" after this change? and remove the extra "asan-pipeline"/"asan-function-pipeline" parsing callbacks in NewPMDriver.cpp? and previously we had `-passes=require` because a function pass couldn't invoke a module analysis, but that's

[PATCH] D113143: [clang][asan] Add test for ensuring PR52382 is fixed

leonardchan created this revision. leonardchan added reviewers: aeubanks, vitalybuka. leonardchan added a project: Sanitizers. leonardchan requested review of this revision. Herald added a project: clang. The fix for PR52382 was already introduced in D112732

[PATCH] D112491: Add `LambdaCapture`-related matchers.

fowles added a comment. Do we also want a `forEachCapture` matcher? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491 ___ cfe-commits mailing list

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 384578. jcking1034 added a comment. Rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:59 +// If conversion fails, utf-8 is designed so that we can just try next char. +if (Result != llvm::conversionOK) { + ++CurPtr;

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

dexonsmith added a comment. Just a few comments on implementation details. The only high-level piece to call out is that I wonder if `NumIncludes` could/should be simplified (semantically) to a Boolean in a prep commit. Comment at:

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. To me this looks good, if the sorting is finalized. :) Do you need someone to push this for you? If yes please state name and email, if not please wait a few days for

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was automatically updated to reflect the committed changes. Closed by commit rGa55c4ec1cee7: [ASan] Process functions in Asan module pass (authored by kstoimenov). Changed prior to commit: https://reviews.llvm.org/D112732?vs=384544=384571#toc Repository: rG LLVM Github

[clang] a55c4ec - [ASan] Process functions in Asan module pass

Author: Kirill Stoimenov Date: 2021-11-03T20:27:53Z New Revision: a55c4ec1cee7683d9095327d9d33e7137ec25292 URL: https://github.com/llvm/llvm-project/commit/a55c4ec1cee7683d9095327d9d33e7137ec25292 DIFF: https://github.com/llvm/llvm-project/commit/a55c4ec1cee7683d9095327d9d33e7137ec25292.diff

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Looks great! Nice job! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112768/new/ https://reviews.llvm.org/D112768

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb marked 2 inline comments as done. ardb added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3190-3191 + } + CmdArgs.push_back("-target-feature"); + CmdArgs.push_back("+read-tp-hard"); +} nickdesaulniers wrote: > ardb

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

ardb updated this revision to Diff 384564. ardb added a comment. - disallow -mtp=soft when TLS based stack protector is enabled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112768/new/ https://reviews.llvm.org/D112768 Files:

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ddpagan added a comment. Thanks for reviewing the code, Aaron. Comment at: clang/lib/Serialization/ASTWriter.cpp:5018 Record.AddStmt(A->getAllocator()); +Record.AddStmt(A->getAlignment()); Record.AddSourceRange(A->getRange());

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. nice, thank you for improving this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113080/new/ https://reviews.llvm.org/D113080

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:224 + +def HasStdExtVIntegerEEW32 +: Predicate<"Subtarget->hasStdExtV() || SubTarget->hasStdExtZve32x()">, Can we add the AssemblerPredicate to HasVInstructions and use that? Or

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:225 +def HasStdExtVIntegerEEW32 +: Predicate<"Subtarget->hasStdExtV() || SubTarget->hasStdExtZve32x()">, + AssemblerPredicate< StdExtV depends on Zve64d which depends on

[PATCH] D113126: [OpenMP][NFCI] Embed the source location string size in the ident_t

jdoerfert updated this revision to Diff 384554. jdoerfert added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Include the clang changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113126/new/

[PATCH] D113136: [Clang] Pass -z rel to linker for Fuchsia

mcgrathr created this revision. mcgrathr added a reviewer: phosek. Herald added a subscriber: abrachet. mcgrathr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fuchsia already supports the more compact relocation format. Make it the

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:170 // D and Zfh imply F. bool hasVInstructionsAnyF() const { return HasStdExtV && hasStdExtF(); } unsigned getMaxInterleaveFactor() const { This needs to be the same

[PATCH] D113080: [Support] Improve Caching conformance with Support library behavior

noajshu updated this revision to Diff 384545. noajshu added a comment. Improve error handling in Caching support library. Most of the functions now return Expected<>, except for the non-trivial destructor of CacheStream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384544. kstoimenov added a comment. After merging D113072 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao added a comment. In D112041#3106936 , @nikic wrote: > I'd still like an answer to: > > In D112041#3073464 , @nikic wrote: > >> Is it actually necessary to thread this through AssumptionCache, given how >>

[PATCH] D112732: [ASan] Process functions in Asan module pass

vitalybuka updated this revision to Diff 384539. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

nikic added a comment. I'd still like an answer to: In D112041#3073464 , @nikic wrote: > Is it actually necessary to thread this through AssumptionCache, given how > InferAddressSpaces is the only place that looks at these assumes? I'd prefer not to

[PATCH] D113072: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

This revision was automatically updated to reflect the committed changes. Closed by commit rG3131714f8dac: [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3131714 - [NFC][asan] Use AddressSanitizerOptions in ModuleAddressSanitizerPass

Author: Vitaly Buka Date: 2021-11-03T11:32:14-07:00 New Revision: 3131714f8daca338492a7d5b189e4d63131bc808 URL: https://github.com/llvm/llvm-project/commit/3131714f8daca338492a7d5b189e4d63131bc808 DIFF: https://github.com/llvm/llvm-project/commit/3131714f8daca338492a7d5b189e4d63131bc808.diff

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 384535. hliao added a comment. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll

[PATCH] D113131: [ASan] Process functions in Asan module pass.

kstoimenov created this revision. kstoimenov added a reviewer: vitalybuka. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Re-land of D112732

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn));

[PATCH] D112732: [ASan] Process functions in Asan module pass

rupprecht added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn));

[PATCH] D112732: [ASan] Process functions in Asan module pass

rupprecht added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1189 +MPM.addPass(ModuleAddressSanitizerPass( +CompileKernel, Recover, ModuleUseAfterScope, UseOdrIndicator, +DestructorKind, UseAfterScope, UseAfterReturn));

[PATCH] D113129: Revert "[ASan] Process functions in Asan module pass"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb3145323b549: Revert [ASan] Process functions in Asan module pass (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] b314532 - Revert "[ASan] Process functions in Asan module pass"

Author: Kirill Stoimenov Date: 2021-11-03T18:01:01Z New Revision: b3145323b549eea95b3b088cb2064bf0bf81cfe6 URL: https://github.com/llvm/llvm-project/commit/b3145323b549eea95b3b088cb2064bf0bf81cfe6 DIFF: https://github.com/llvm/llvm-project/commit/b3145323b549eea95b3b088cb2064bf0bf81cfe6.diff

[PATCH] D113129: Revert "[ASan] Process functions in Asan module pass"

kstoimenov created this revision. Herald added subscribers: ormris, hiraditya. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This reverts commit 76ea87b94e5cba335d691e4e18e3464ad45c8b52

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 384521. Jake-Egan added a comment. Updated patch to XFAIL only on 64-bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files:

[PATCH] D112732: [ASan] Process functions in Asan module pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76ea87b94e5c: [ASan] Process functions in Asan module pass (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 76ea87b - [ASan] Process functions in Asan module pass

Author: Kirill Stoimenov Date: 2021-11-03T17:51:01Z New Revision: 76ea87b94e5cba335d691e4e18e3464ad45c8b52 URL: https://github.com/llvm/llvm-project/commit/76ea87b94e5cba335d691e4e18e3464ad45c8b52 DIFF: https://github.com/llvm/llvm-project/commit/76ea87b94e5cba335d691e4e18e3464ad45c8b52.diff

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384515. kstoimenov added a comment. After rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

tra added a comment. LGTM in general, modulo remaining nits. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:196 void inferAddressSpaces(ArrayRef Postorder, - ValueToAddrSpaceMapTy *InferredAddrSpace) const; +

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3190-3191 + } + CmdArgs.push_back("-target-feature"); + CmdArgs.push_back("+read-tp-hard"); +} ardb wrote: > nickdesaulniers wrote: > > Isn't this

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

dblaikie added a comment. In D111477#3106171 , @ldionne wrote: > This broke libc++'s CI: > https://buildkite.com/llvm-project/libcxx-ci/builds/6374#7569da95-c852-44f9-8b69-947245cf0b65 > > When you make a change to Clang AND the libc++ tests at the same

[PATCH] D111669: No longer crash when a consteval function returns a structure

erichkeane accepted this revision. erichkeane added a comment. Looks to accomplish this exactly the way that @rjmccall suggested! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111669/new/ https://reviews.llvm.org/D111669 ___ cfe-commits

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384488. kstoimenov marked 3 inline comments as done. kstoimenov added a comment. Moved module after function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

jansvoboda11 added a comment. In D112915#3104873 , @vsapsai wrote: > There can be other reasons to keep `IncludeMap` out of `SubmoduleState` but > I'm not sure the local submodule visibility is the right reason. I might be > reading the code

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added a comment. In D112996#3106459 , @sammccall wrote: > can we the tests again though? Sorry, I don't understand what you mean by that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:9619 +const bool ExtensionlessHeaders = IsSystem || isQt +|| Dir.endswith(".framework/Headers"); std::error_code EC; I'm just noticing that this is often a symlink

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! can we the tests again though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

ckandeler updated this revision to Diff 384485. ckandeler added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 Files: clang/lib/Sema/SemaCodeComplete.cpp Index:

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108643/new/ https://reviews.llvm.org/D108643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112616/new/ https://reviews.llvm.org/D112616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112915: WIP: [clang][modules] Granular tracking of includes

jansvoboda11 updated this revision to Diff 384484. jansvoboda11 added a comment. Avoid copying data between submodules Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112915/new/ https://reviews.llvm.org/D112915 Files:

[PATCH] D111669: No longer crash when a consteval function returns a structure

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111669/new/ https://reviews.llvm.org/D111669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113115: Add diagnostic groups for attribute extensions

aaron.ballman added a comment. In D113115#3106360 , @erichkeane wrote: > I like the approach, and a pretty trivial implementation. Thanks for the review! I'm going to hold off on landing for a little bit in case @rsmith has opinions because he had

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz added a comment. Hey Kadir. This is my naive approach at solving that large memory usage issue you reported. It works, although I wish this was more generic. I'm not an expert on this piece of code, so I tried to keep things similar to how they worked previously. Let me know what you

[PATCH] D113120: [clang] Add early exit when checking for const init of arrays.

adamcz created this revision. adamcz added a reviewer: kadircet. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this commit, on code like: struct S { ... }; S arr[1000]; while checking if arr is constexpr, clang

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The AST structural equivalence check did not differentiate between a struct

[PATCH] D113115: Add diagnostic groups for attribute extensions

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I like the approach, and a pretty trivial implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113115/new/

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384467. kstoimenov added a comment. Moved empty check to the top of the function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D112732: [ASan] Process functions in Asan module pass

kstoimenov updated this revision to Diff 384465. kstoimenov added a comment. Moved module instumentation back ahead of function instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files:

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

ldionne added a comment. Trying to fix this in https://reviews.llvm.org/D113112. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111477/new/ https://reviews.llvm.org/D111477 ___ cfe-commits mailing list

[PATCH] D113115: Add diagnostic groups for attribute extensions

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, jyknight, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. Some users have a need to control attribute extension diagnostics independent of other extension

[PATCH] D111100: enable plugins for clang-tidy

vtjnash added a comment. bump? tagging some more people who seemed like possible reviewers. I realized my original list of candidates might have mostly been inactive people. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/

[PATCH] D112453: [Sema] When dereferencing a pointer of dependent type, infer the result type.

courbet added a comment. In D112453#3103515 , @rsmith wrote: > I think this change is being made in an imperfect place, though. Instead of > putting a special case in here, how would we feel about making > `Type::isOverloadableType()` smarter, to

[PATCH] D113096: [X86][MS-InlineAsm] Add constraint *m for memory access w/ global var

pengfei added a comment. How about the GV is function pointer? I believe @xiangzhangllvm has lots of experience on it :) Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8 + // CHECK: @arr = internal global [10 x i32] + // CHECK: call void asm sideeffect

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

ldionne added a comment. This broke libc++'s CI: https://buildkite.com/llvm-project/libcxx-ci/builds/6374#7569da95-c852-44f9-8b69-947245cf0b65 When you make a change to Clang AND the libc++ tests at the same time, you have to account for the fact that we support older versions of Clang. For

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 384451. mbenfield added a comment. Renamed to diagnose_as_builtin (since two people suggested that name). Let me know if a name mentioning fortify is preferred. Validation in handleDiagnoseAsBuiltinAttr: - first argument is a builtin function - number of

  1   2   >