[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 399689. clemenswasser edited the summary of this revision. clemenswasser added a comment. Updated the Tests. The Problem with Lsan+Asan still exists. I have just disabled them for now. I hope anyone can help me with getting the tests to run correctly?

[PATCH] D117232: [clang] Respect -Wdeclaration-after-statement with C99 or later

melver created this revision. melver added reviewers: aaron.ballman, dblaikie, rsmith. melver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC allows using -Wdeclaration-after-statement to warn when mixing code and declarations not just

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

aaron.ballman closed this revision. aaron.ballman added a comment. In D115253#3240789 , @jyknight wrote: > Accepting assuming the last comment will be addressed before pushing. Thanks! Thank you for the excellent reviews, I really appreciate it! I made

[clang] bf7d997 - Support the *_WIDTH macros in limits.h and stdint.h

Author: Aaron Ballman Date: 2022-01-13T11:46:34-05:00 New Revision: bf7d9970ba0ac5ecfa1a469086f5789de5c94e3f URL: https://github.com/llvm/llvm-project/commit/bf7d9970ba0ac5ecfa1a469086f5789de5c94e3f DIFF: https://github.com/llvm/llvm-project/commit/bf7d9970ba0ac5ecfa1a469086f5789de5c94e3f.diff

[PATCH] D116748: [AArch64][ARM][Clang] PerfMon Extension Added

mubashar_ updated this revision to Diff 399685. mubashar_ added a comment. The command line option for Clang is now +pmuv3 to enable PerfMon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116748/new/ https://reviews.llvm.org/D116748 Files: clang/test/Driver/aarch64-perfmon.c

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

yaxunl added a comment. In D115523#3237857 , @Anastasia wrote: > In D115523#3237410 , @yaxunl wrote: > >> It is possible that block kernels are defined and invoked in static >> functions, therefore two block

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1022 +SVal clang::ento::SValBuilder::simplifySymbolCast(SymbolRef SE, + QualType CastTy) { And it'd be great if you

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. @nathanchance You were right. I succeeded in reproducing the warning with `-fsanitize-coverage=trace-pc` However, this problem seems to be fixed in the latest version. (I used `57a551a`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added a comment. Ping. This review has been waiting for a week without any comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 ___ cfe-commits mailing list

[PATCH] D116328: [ast-matchers] Add hasSubstatement() traversal matcher for caseStmt(), defaultStmt(), labelStmt()

LegalizeAdulthood added a comment. Ping. This review has been waiting for a week without any comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116328/new/ https://reviews.llvm.org/D116328 ___ cfe-commits mailing list

[PATCH] D115932: [Analyzer] Create and handle SymbolCast for pointer to integral conversion

martong added a comment. > I took Denys' patch D105340 and created a > prototype on top of that to create the SymbolCast in > SValBuilder::evalCastSubKind(loc::MemRegionVal V, Here is the new (alternative) patch: https://reviews.llvm.org/D117229 Repository:

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood added a comment. Ping. This review has been waiting for a week without any comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116386/new/ https://reviews.llvm.org/D116386 ___ cfe-commits mailing list

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong created this revision. martong added reviewers: ASDenysPetrov, NoQ, steakhal. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. martong requested

[PATCH] D116025: [analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap

steakhal added a comment. Sweet stuff! Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:55 /// Check if tainted data is used as a buffer size ins strn.. functions, /// and allocators. typo Comment at:

[PATCH] D111566: [SYCL] Fix function pointer address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG4eaf5846d0e7: [clang] Fix function pointer address space (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4eaf584 - [clang] Fix function pointer address space

Author: Elizabeth Andrews Date: 2022-01-13T08:06:19-08:00 New Revision: 4eaf5846d0e738264d9328b4a919bc352ea83b7a URL: https://github.com/llvm/llvm-project/commit/4eaf5846d0e738264d9328b4a919bc352ea83b7a DIFF:

[PATCH] D115253: [C2x] Support the *_WIDTH macros in limits.h and stdint.h

jyknight accepted this revision. jyknight added a comment. Accepting assuming the last comment will be addressed before pushing. Thanks! Comment at: clang/lib/Frontend/InitPreprocessor.cpp:257 + if (IsSigned) +DefineTypeSizeAndWidth("__INT" + Twine(TypeWidth), Ty, TI,

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 added a comment. Thank you! I'm pretty sure it's this commit that causes the failure. I now see that `HeaderSearch::LookupFile` callers perform pointer arithmetics on the out-parameter `const DirectoryLookup *`. They rely on the fact that all `DirectoryLookup` instances are in

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. This is coming together well. I think structs `U23` to `U26` in the C test are duplicates - how about surrounding them all in `#pragma pack(push, 2)` so they're different from the earlier cases? Quite a few more comments inline on the tests. Comment

[clang] ccd7e78 - Revert "[clang][lex] Keep references to `DirectoryLookup` objects up-to-date"

Author: Jan Svoboda Date: 2022-01-13T16:29:44+01:00 New Revision: ccd7e7830f0cef74dbb7e776f76f8ede36b55e8e URL: https://github.com/llvm/llvm-project/commit/ccd7e7830f0cef74dbb7e776f76f8ede36b55e8e DIFF: https://github.com/llvm/llvm-project/commit/ccd7e7830f0cef74dbb7e776f76f8ede36b55e8e.diff

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156 +- Add new option ``cppcoreguidelines-pro-bounds-constant-array-index.FixHint`` + to allow users to specify a different fix hint than

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp updated this revision to Diff 399675. carlosgalvezp added a comment. Fix check order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117205/new/ https://reviews.llvm.org/D117205 Files:

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156 +- Add new option ``cppcoreguidelines-pro-bounds-constant-array-index.FixHint`` + to allow users to specify a different fix hint than ``gsl::at``. carlosgalvezp

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156 +- Add new option ``cppcoreguidelines-pro-bounds-constant-array-index.FixHint`` + to allow users to specify a different fix hint than ``gsl::at``. Eugene.Zelenko

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp updated this revision to Diff 399674. carlosgalvezp marked an inline comment as done. carlosgalvezp added a comment. Single backticks for gsl::at Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117205/new/

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

khchen added a comment. > The main reason I want to add the prefix "llvm::" is all None in the files > are "llvm::None" form. It makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117199/new/ https://reviews.llvm.org/D117199

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

carlosgalvezp added a comment. In D116750#3240680 , @jansvoboda11 wrote: > In D116750#3240363 , @carlosgalvezp > wrote: > >> Hi @jansvoboda11 ! >> >> I believe this commit is the root cause of this issue: >>

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

fhahn added a comment. @junaire did you already get commit access or should I commit this change on your behalf? In D116736#3239530 , @junaire wrote: > In D116736#3230040 , @fhahn wrote: > >> LGTM, thanks! >>

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:156 +- Add new option ``cppcoreguidelines-pro-bounds-constant-array-index.FixHint`` + to allow users to specify a different fix hint than ``gsl::at``. Please sort checks

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

thakis added a comment. Since this is changing serialization format you might have to do something like https://reviews.llvm.org/rGb8b7a9dcdcbc as well (see https://reviews.llvm.org/D73202 for background). I doubt that's the cause of mstorsjo's repro given that LLVM_APPEND_VC_REV is on by

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 added a comment. In D116750#3240363 , @carlosgalvezp wrote: > Hi @jansvoboda11 ! > > I believe this commit is the root cause of this issue: > https://github.com/llvm/llvm-project/issues/53161 > > Believe it or not, I was (un)lucky enough

[PATCH] D116859: [clang-format] Fix break being added to macro define with ColumnLimit: 0

curdeius added a comment. @MyDeveloperDay, do you have any more objections? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116859/new/ https://reviews.llvm.org/D116859 ___ cfe-commits mailing list

[clang] b699e8b - Add another assert to cpu-dispatch emission to help track down a tough

Author: Erich Keane Date: 2022-01-13T06:54:08-08:00 New Revision: b699e8b11aa92ca4fcade2616d4a4bbc1d3a717e URL: https://github.com/llvm/llvm-project/commit/b699e8b11aa92ca4fcade2616d4a4bbc1d3a717e DIFF: https://github.com/llvm/llvm-project/commit/b699e8b11aa92ca4fcade2616d4a4bbc1d3a717e.diff

[PATCH] D117177: [NFC][DFSan] Update DataFlowSanitizer user docs for -dfsan-conditional-callbacks, added in https://reviews.llvm.org/D116207

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117177/new/ https://reviews.llvm.org/D117177

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

sammccall updated this revision to Diff 399656. sammccall added a comment. add test, fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116925/new/ https://reviews.llvm.org/D116925 Files: clang-tools-extra/clangd/Diagnostics.cpp

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

aganea added subscribers: hans, rnk, aganea. aganea added reviewers: hans, rnk. aganea added a comment. +@hans @rnk Since we discussed this in one of the past Windows/COFF calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/

[clang-tools-extra] fc7a9f3 - [clangd] Ignore cvr-qualifiers in selection.

Author: Sam McCall Date: 2022-01-13T15:08:50+01:00 New Revision: fc7a9f36a9232794f8b5414347024b726954fe53 URL: https://github.com/llvm/llvm-project/commit/fc7a9f36a9232794f8b5414347024b726954fe53 DIFF: https://github.com/llvm/llvm-project/commit/fc7a9f36a9232794f8b5414347024b726954fe53.diff

[PATCH] D117185: [clangd] Ignore cvr-qualifiers in selection.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGfc7a9f36a923: [clangd] Ignore cvr-qualifiers in selection. (authored by sammccall). Changed prior to commit:

[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.

sammccall added a comment. PTAL Comment at: clang-tools-extra/clangd/Selection.cpp:350 +return *Offset < First; + StartInvalid = false; + return false; sammccall wrote: > hokein wrote: > > this should be `true`. > Oh shoot, now

[PATCH] D117218: [clang][dataflow] Add transfer functions for constructors

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis

[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.

sammccall updated this revision to Diff 399643. sammccall marked 3 inline comments as done. sammccall added a comment. Handle EOF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117107/new/ https://reviews.llvm.org/D117107 Files:

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3524 return false; if (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator)) return false; mprobst wrote: > curdeius wrote: > > HazardyKnusperkeks

[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.

sammccall planned changes to this revision. sammccall marked 5 inline comments as done. sammccall added a comment. Thanks! You caught a serious bug, I'm digging into it. Comment at: clang-tools-extra/clangd/Selection.cpp:289 +// surround the selection, including when

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

hokein added a comment. add a unittest? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116925/new/ https://reviews.llvm.org/D116925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117107: [clangd] Elide even more checks in SelectionTree.

hokein added a comment. this looks good in general. Comment at: clang-tools-extra/clangd/Selection.cpp:289 +// surround the selection, including when generated by macros. +if (ExpandedTokens.empty() || +() > >ExpandedTokens.back() || if it is

[PATCH] D116978: [clangd] Selection: Prune gtest TEST()s earlier

This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rG2b2dbe6126f8: [clangd] Selection: Prune gtest TEST()s earlier (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 2b2dbe6 - [clangd] Selection: Prune gtest TEST()s earlier

Author: Sam McCall Date: 2022-01-13T13:58:42+01:00 New Revision: 2b2dbe6126f8c016e0cbef45a6d22e1359ce39fd URL: https://github.com/llvm/llvm-project/commit/2b2dbe6126f8c016e0cbef45a6d22e1359ce39fd DIFF: https://github.com/llvm/llvm-project/commit/2b2dbe6126f8c016e0cbef45a6d22e1359ce39fd.diff

[PATCH] D116978: [clangd] Selection: Prune gtest TEST()s earlier

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:306 +// If the node starts after the selection ends, it is not selected. +// All tokens a macro location might claim are >= its expansion site.

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

carlosgalvezp added a comment. Hi @jansvoboda11 ! I believe this commit is the root cause of this issue: https://github.com/llvm/llvm-project/issues/53161 Believe it or not, I was lucky enough to run into it. I have bisected the repo and my tests indicate that this commit is the offender. Do

[clang-tools-extra] a9bf327 - [clangd] Fix build after D115243

Author: Kirill Bobyrev Date: 2022-01-13T13:44:19+01:00 New Revision: a9bf32763d3929672fe243f84e6a103c91260ef0 URL: https://github.com/llvm/llvm-project/commit/a9bf32763d3929672fe243f84e6a103c91260ef0 DIFF:

[PATCH] D116443: [clangd] Implement textDocument/typeDefinition

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Comment at: clang-tools-extra/clangd/XRefs.cpp:1869 + QualType VisitDesignatedInitExpr(const DesignatedInitExpr *S) { +for (auto :

[PATCH] D105340: [analyzer] Produce SymbolCast symbols for integral types in SValBuilder::evalCast

ASDenysPetrov added a comment. Thank you @martong. I'll load it ASAP. It's great to see symcasts is closer. Shame on me :) I'm mixed up in my own patches. I forgot that I separated them consciously for this purpose. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105340/new/

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan updated this revision to Diff 399632. owenpan added a comment. - Rebased to main. - Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/ https://reviews.llvm.org/D116316 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

JonChesterfield reopened this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I don't know the context of this patch but changing attribute((used)) to put things under compiler.used is definitely a breaking change. Please introduce a new attribute if

[PATCH] D116904: Fix build failure with MSVC in C++20 mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG971bd6f83440: Fix build failure with MSVC in C++20 mode (authored by Godin, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 971bd6f - Fix build failure with MSVC in C++20 mode

Author: Evgeny Mandrikov Date: 2022-01-13T12:55:16+01:00 New Revision: 971bd6f83440701cf95047b0f4e2baf75cd31c48 URL: https://github.com/llvm/llvm-project/commit/971bd6f83440701cf95047b0f4e2baf75cd31c48 DIFF:

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

sammccall added a comment. In D116925#3231110 , @hokein wrote: > In D116925#3230991 , @sammccall > wrote: > >> I wasn't sure whether to suppress this in clang or clangd, wonder what you >> think. > > I think it

[PATCH] D116925: [clangd] Suppress warning about system_header pragma when editing headers

sammccall updated this revision to Diff 399624. sammccall added a comment. add fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116925/new/ https://reviews.llvm.org/D116925 Files: clang-tools-extra/clangd/Diagnostics.cpp

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff added a comment. P1330R0 (https://wg21.link/P1330R0) allowed changing the active member of a union in constexpr expressions. To implement it the Constant Evaluator starting from https://github.com/llvm/llvm-project/commit/31c69a3d6363463c08b86914c0c8cfc5c929c37e checks if an

[PATCH] D116978: [clangd] Selection: Prune gtest TEST()s earlier

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks good. Comment at: clang-tools-extra/clangd/Selection.cpp:306 +// If the node starts after the selection ends, it is not selected. +// All tokens a

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTestJS.cpp:1705-1713 verifyFormat("let x: {x: number|null} = {x: number | null};"); verifyFormat("let nested: {x: {y: number|null}};"); verifyFormat("let mixed: {x: [number|null, {w: number}]};");

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3524 return false; if (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator)) return false; curdeius wrote: > HazardyKnusperkeks wrote: > > mprobst wrote: > > >

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/TokenAnnotator.cpp:3524-3525 return false; if (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator))

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp updated this revision to Diff 399604. carlosgalvezp added a comment. Fix doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117205/new/ https://reviews.llvm.org/D117205 Files:

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp updated this revision to Diff 399603. carlosgalvezp added a comment. Update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117205/new/ https://reviews.llvm.org/D117205 Files:

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

fakepaper56 added a comment. The main reason I want to add the prefix "llvm::" is all None in the files are "llvm::None" form. But also it is more feasible when we want to add a variable name 'None' in the file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index

carlosgalvezp created this revision. Herald added subscribers: shchenz, arphaman, kbarton, kristof.beyls, xazax.hun, nemanjai. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently the fix hint is hardcoded

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTestJS.cpp:1708-1713 verifyFormat("class X {\n" " contructor(x: {\n" "a: a|null,\n" "b: b|null,\n" " }) {}\n"

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM apart from nits. I agree though that spaceRequired(Before|Between) need some refactoring love. Comment at: clang/docs/ReleaseNotes.rst:327 +- Option

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:205 +AARCH64_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_RAS)) AARCH64_CPU_NAME("cortex-x2", ARMV9A, FK_NEON_FP_ARMV8, false,

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3475 return false; +if (Left.is(TT_JsTypeOperator) && Right.isTypeOrIdentifier() || +(Left.isTypeOrIdentifier() || Left.is(TT_TemplateCloser)) && Be

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius marked 2 inline comments as done. curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:297 + return true; +if (Style.isCpp() && RecordTok->is(tok::kw_union)) + return true;

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:297 + return true; +if (Style.isCpp() && RecordTok->is(tok::kw_union)) + return true; Is union used in another

[PATCH] D116904: Fix build failure with MSVC in C++20 mode

Godin added a comment. Thank you for the review @sammccall ! Can someone please commit this on my behalf since I do not have commit rights? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116904/new/ https://reviews.llvm.org/D116904

[PATCH] D116843: [Driver][Gnu] -r: imply -nostdlib like GCC

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116843/new/ https://reviews.llvm.org/D116843 ___ cfe-commits mailing list

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch upstreams support for the Arm-v8 Cortex-X1C processor for AArch64 and ARM.

[PATCH] D117185: [clangd] Ignore cvr-qualifiers in selection.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:194 + return Tok.kind() == tok::comment || Tok.kind() == tok::semi || + Tok.kind() == tok::kw_const || Tok.kind() == tok::kw_volatile || + Tok.kind() == tok::kw_restrict;

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

achieveartificialintelligence added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:300 if (Log2ScaleResult < 0) -return None; +return llvm::None; return 1 << Log2ScaleResult; We have used using namespace llvm; Repository:

[PATCH] D117119: [clang] Remove uses of `std::vector`

jansvoboda11 updated this revision to Diff 399586. jansvoboda11 added a comment. Split patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117119/new/ https://reviews.llvm.org/D117119 Files:

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

fakepaper56 created this revision. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3524 return false; if (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator)) return false; MyDeveloperDay wrote: > mprobst wrote: > > shouldn't you change this

[libclc] ec0a880 - libclc: Add clspv64 target

Author: Kévin Petit Date: 2022-01-13T09:28:19Z New Revision: ec0a880d54632923b4d0742f38d565830fc0d0e0 URL: https://github.com/llvm/llvm-project/commit/ec0a880d54632923b4d0742f38d565830fc0d0e0 DIFF: https://github.com/llvm/llvm-project/commit/ec0a880d54632923b4d0742f38d565830fc0d0e0.diff LOG:

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:481-485 - // The gro variable has to outlive coroutine frame and coroutine promise, but, - // it can only be initialized after coroutine promise was created, thus, we - // split its emission in

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3524 return false; if (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator)) return false; mprobst wrote: > shouldn't you change this line here? You

[PATCH] D117087: [C++20] [Coroutines] Implement return value optimization for get_return_object

ChuanqiXu updated this revision to Diff 399578. ChuanqiXu retitled this revision from "[WIP] [C++20] [Coroutines] Implement return value optimization for get_return_object" to "[C++20] [Coroutines] Implement return value optimization for get_return_object". ChuanqiXu edited the summary of this

[PATCH] D117036: [clangd] Remove --inlay-hints flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG54eb70886cda: [clangd] Remove --inlay-hints flag (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117036/new/

[clang-tools-extra] 54eb708 - [clangd] Remove --inlay-hints flag

Author: Sam McCall Date: 2022-01-13T10:02:28+01:00 New Revision: 54eb70886cda06c66122f346520cee7cc6113975 URL: https://github.com/llvm/llvm-project/commit/54eb70886cda06c66122f346520cee7cc6113975 DIFF: https://github.com/llvm/llvm-project/commit/54eb70886cda06c66122f346520cee7cc6113975.diff

[PATCH] D117036: [clangd] Remove --inlay-hints flag

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, as discussed offline, i was mostly worried about the user confusion we would get when people can't turn it off with `--inlay-hints=false` but this has both made it into clangd-13

[PATCH] D117036: [clangd] Remove --inlay-hints flag

sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:296 RetiredFlag ClangTidyChecks("clang-tidy-checks"); +RetiredFlag InlayHints("inlay-hints"); kadircet wrote: > oops, missed this one in the previous revision. > > any

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3524 return false; if (Left.is(TT_JsTypeOperator) || Right.is(TT_JsTypeOperator)) return false; shouldn't you change this line here? Repository: rG LLVM Github

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mprobst, krasimir, HazardyKnusperkeks, curdeius, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/49858 The following

[PATCH] D117195: supdate

phyBrackets created this revision. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D117195 Files: clang/docs/AddressSanitizer.rst Index:

[PATCH] D117036: [clangd] Remove --inlay-hints flag

kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:296 RetiredFlag ClangTidyChecks("clang-tidy-checks"); +RetiredFlag InlayHints("inlay-hints"); oops, missed this one in the previous revision. any reason for not directly

[PATCH] D117112: [AArch64] Support for Ampere1 core

dmgreen added a comment. You could consider adding some scheduling tests, like those in llvm/test/tools/llvm-mca/AArch64/Cortex/A55-basic-instructions.s. In the past we have tended not to add them for schedules, so they are not necessary, but can be useful for checking the details are as you

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

HazardyKnusperkeks resigned from this revision. HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3059 + /// and ``while``) in C++ according to the LLVM coding style. + /// \warning + /// This option will be renamed and expanded to

<    1   2