[PATCH] D113837: Sema: Let InitListExpr have dependent type instead of 'void'

aaron.ballman added a comment. FWIW, I think this direction seems reasonable to me. Before semantic analysis, we can't know the type, it depends on the context that we haven't analyzed yet. However, I'd ultimately like to hear from @rsmith just in case I am missing some concerns with the

[PATCH] D117706: [openmp] Unconditionally set march commandline argument

JonChesterfield created this revision. JonChesterfield added a reviewer: jhuber6. Herald added subscribers: kerbowa, guansong, tpr, yaxunl, nhaehnle, jvesely. JonChesterfield requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

teemperor added a comment. I'm really sorry @martong , but I no longer work on LLDB (or the ASTImporter) and I'm not really in the loop regarding LLDB development. (Having said that, I still happy to answer questions about my own patches/reviews that I did in the past in case there are

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:11 +`ES.31

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:23 -namespace { - -bool isCapsOnly(StringRef Name) { - return std::all_of(Name.begin(), Name.end(),

[clang-tools-extra] a4bdeb9 - [clang-tidy][NFC] replace some redundant std::string creations

Author: Nathan James Date: 2022-01-19T18:36:35Z New Revision: a4bdeb9a563475fd989d97138971895f606f45d3 URL: https://github.com/llvm/llvm-project/commit/a4bdeb9a563475fd989d97138971895f606f45d3 DIFF: https://github.com/llvm/llvm-project/commit/a4bdeb9a563475fd989d97138971895f606f45d3.diff LOG:

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:297 + +std::string Arch = DAL->getLastArgValue(options::OPT_march_EQ).str(); +if (Arch.empty()) { JonChesterfield wrote: > This part is valuable as-is and probably

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:11 +`ES.31 `_, and +`ES.32

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

craig.topper added a comment. In D117468#3253879 , @Chenbing.Zheng wrote: > In D117468#3253493 , @craig.topper > wrote: > >> Out of curiosity, what is your interest in Zbt? Do you work for a company >> that is

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

JonChesterfield added a comment. A bit nervous about the automatic appending of host library search paths for the device link but I see that's pre-existing in nvptx. I'll check whether -### changes behaviour as expected and approve if it does Comment at:

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Looks reasonable to me! I'm fairly new here so I might not be the most "authoritative reviewer", let me know if you'd like someone else to give the final approval

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113507/new/ https://reviews.llvm.org/D113507 ___

[PATCH] D116174: [clang] support relative roots to vfs overlays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f61749e16f6: [clang] support relative roots to vfs overlays (authored by rmaz, committed by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4f61749 - [clang] support relative roots to vfs overlays

Author: Richard Howell Date: 2022-01-19T10:13:06-08:00 New Revision: 4f61749e16f63b0c9ebd9bdd1f8bf4f570a31692 URL: https://github.com/llvm/llvm-project/commit/4f61749e16f63b0c9ebd9bdd1f8bf4f570a31692 DIFF:

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The CI failure is finally down to just an unrelated one (yay?). Do you need someone to commit on your behalf? If so, what name and email address would you like used for

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 401304. Ericson2314 added a comment. Avoid warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117419/new/ https://reviews.llvm.org/D117419 Files: clang/CMakeLists.txt

[PATCH] D5980: unique_ptrify ownership of ModuleFiles in the ModuleManager

dblaikie added a comment. In D5980#3253378 , @dblaikie wrote: > Looks like @dexonsmith got this (putting the ownership in `Chain` & using > some iterator adapters to narrow the cleanup scope/fallout) in > rGa897f7cd40b12f693acbb04b81ef928244637aae >

[clang] baa9b7c - unique_ptrify the ModuleManager's VisitState linked list

Author: David Blaikie Date: 2022-01-19T09:57:46-08:00 New Revision: baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810 URL: https://github.com/llvm/llvm-project/commit/baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810 DIFF: https://github.com/llvm/llvm-project/commit/baa9b7c3c83ab6e4dfb15b8d7815a9958d5b5810.diff

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 401299. LegalizeAdulthood added a comment. - clang-format - prefer `llvm::any_of` over `std::any_of` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files:

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85c2bd2a0e0e: Prevent adding module flag amdgpu_hostcall multiple

[clang] 85c2bd2 - Prevent adding module flag amdgpu_hostcall multiple times

Author: Yaxun (Sam) Liu Date: 2022-01-19T12:52:33-05:00 New Revision: 85c2bd2a0e0e2c1706bbf50203d5bbbeedbbd741 URL: https://github.com/llvm/llvm-project/commit/85c2bd2a0e0e2c1706bbf50203d5bbbeedbbd741 DIFF:

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx updated this revision to Diff 401293. ksyx edited the summary of this revision. ksyx added a comment. Recognize long (len>=5) uppercased name taking a single line as return type and fix the problem of adding newline below it: void afunc(int x) { return; } TYPENAME func(int x,

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

aaron.ballman added reviewers: cor3ntin, sammccall. aaron.ballman added a comment. Adding a few more reviewers in case there are differing opinions. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5173-5174 +/// Matches consteval function declarations, +///

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

dblaikie added inline comments. Comment at: clang/lib/CodeGen/Address.h:30 + // Int portion stores lower 3 bits of the log of the alignment. + llvm::PointerIntPair ElementType; nikic wrote: > dblaikie wrote: > > aeubanks wrote: > > > nikic wrote: > > > > Are

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

martong added a subscriber: teemperor. martong added a comment. Adding Raphael @teemperor , he might have useful comments about the minimal mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155

[PATCH] D115521: [Templight] Don't display empty strings for names of unnamed template parameters

martong accepted this revision. martong added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115521/new/ https://reviews.llvm.org/D115521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:3 +include(GNUInstallDirs) + beanz wrote: > If GNUInstallDirs is included before the `project` call enables languages it > results in a CMake warning being logged. See D117639 where we are

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

erichkeane added a comment. No comments other than the ones others have made, though the make_signed/make_unsigned needs to work for _BitInt Comment at: clang/lib/Sema/SemaType.cpp:9113 + BaseType.isReferenceable() || BaseType->isVoidType() + ?

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587 ___

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1022 +SVal clang::ento::SValBuilder::simplifySymbolCast(SymbolRef SE, + QualType CastTy) { ASDenysPetrov wrote: > And it'd

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong updated this revision to Diff 401274. martong marked an inline comment as done. martong added a comment. - Move the comment hunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117229/new/ https://reviews.llvm.org/D117229 Files:

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added reviewers: rsmith, rjmccall, erichkeane. aaron.ballman added a comment. Adding a few more reviewers in case there are more opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. In D116203#3220165 , @aaron.ballman wrote: > The summary for the patch explains what's being added, but there's really no > information as to why it's being added. Why do we need these builtins? Btw, I still think the

[PATCH] D117301: [clang][NFC] Wrap TYPE_SWITCH in "do while (0)" in the interpreter

owenpan updated this revision to Diff 401257. owenpan added a comment. - Also wrapped `COMPOSITE_TYPE_SWITCH` with do-while. - Cleaned up the macro definitions by removing the superfluous do-while statements. - Removed the unused `INT_TPYE_SWITCH` macro. CHANGES SINCE LAST ACTION

[PATCH] D117468: [RISCV] Add intrinsic for Zbt extension

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rv32zbt-intrinsic.ll:21 +; RV32ZBT: # %bb.0: +; RV32ZBT-NEXT:fsr a0, a1, a0, a2 +; RV32ZBT-NEXT:ret This should have the same register order as the fsl test case. I think the

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fbd33ad623d: [OMPIRBuilder] Add support for simd (loop) directive. (authored by arnamoy10). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114379/new/

[clang] 9fbd33a - [OMPIRBuilder] Add support for simd (loop) directive.

Author: Arnamoy Bhattacharyya Date: 2022-01-19T11:32:17-05:00 New Revision: 9fbd33ad623d2b576fc563545bbdf2c257cdf709 URL: https://github.com/llvm/llvm-project/commit/9fbd33ad623d2b576fc563545bbdf2c257cdf709 DIFF:

[PATCH] D117667: [clang][dataflow] Add a transfer function for conditional operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e53ae3d3719: [clang][dataflow] Add a transfer function for conditional operator (authored by sgatev). Repository: rG LLVM Github Monorepo

[clang] 8e53ae3 - [clang][dataflow] Add a transfer function for conditional operator

Author: Stanislav Gatev Date: 2022-01-19T16:25:05Z New Revision: 8e53ae3d37190c7442f87915a49f3f292d1d9956 URL: https://github.com/llvm/llvm-project/commit/8e53ae3d37190c7442f87915a49f3f292d1d9956 DIFF: https://github.com/llvm/llvm-project/commit/8e53ae3d37190c7442f87915a49f3f292d1d9956.diff

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

Jake-Egan added inline comments. Comment at: clang/test/InterfaceStubs/object.c:2 // RUN: %clang_cc1 -fvisibility default -o - -emit-interface-stubs %s | FileCheck -check-prefix=CHECK-TAPI %s -// RUN: %clang -fvisibility=default -c -o - %s | llvm-nm - 2>&1 | FileCheck

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

Jake-Egan updated this revision to Diff 401254. Jake-Egan marked an inline comment as done. Jake-Egan added a comment. Removed the unncessary pipe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587 Files:

[PATCH] D117431: [IRBuilder] Migrate and-folding to value-based FoldAnd.

fhahn updated this revision to Diff 401253. fhahn added a comment. rebase to trigger new run of precommit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117431/new/ https://reviews.llvm.org/D117431 Files:

[PATCH] D93164: [AST] Add generator for source location introspection

lancethepants added a comment. > @lancethepants @smeenai thanks for the pointers! Unfortunately, it still > doesn't work for me after passing -DCMAKE_SYSTEM_NAME="Linux". Passing that > option did change the CMake output, so it's definitely recognized at least > (the messages about which

[clang] d261660 - Fix the use of -fno-approx-func along with -Ofast or -ffast-math

Author: Masoud Ataei Date: 2022-01-19T08:05:08-08:00 New Revision: d261660af96d402689d025b4584e925869a9b413 URL: https://github.com/llvm/llvm-project/commit/d261660af96d402689d025b4584e925869a9b413 DIFF: https://github.com/llvm/llvm-project/commit/d261660af96d402689d025b4584e925869a9b413.diff

[PATCH] D96286: [clangd][NFC] Change TidyProvider cache to use a linked list approach

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96286/new/ https://reviews.llvm.org/D96286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood updated this revision to Diff 401242. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. - Update from comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116386/new/ https://reviews.llvm.org/D116386 Files:

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

hubert.reinterpretcast added inline comments. Comment at: clang/test/InterfaceStubs/object.c:2 // RUN: %clang_cc1 -fvisibility default -o - -emit-interface-stubs %s | FileCheck -check-prefix=CHECK-TAPI %s -// RUN: %clang -fvisibility=default -c -o - %s | llvm-nm - 2>&1 |

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:11 +`ES.31

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

njames93 updated this revision to Diff 401241. njames93 added a comment. Uploaded wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875 Files:

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

hubert.reinterpretcast added a comment. We should update the description to reflect the cause more accurately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 401238. LegalizeAdulthood added a comment. - Handle macros inside header files with include guards - Track state per-file and push/pop that state as files are included CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:182 + MD->getMacroInfo()->isUsedForHeaderGuard() || + MD->getMacroInfo()->isBuiltinMacro() || ConditionScope > 0) +return;

[PATCH] D117681: [RISCV] Add the policy operand for some masked RVV ternary IR intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

njames93 updated this revision to Diff 401234. njames93 marked an inline comment as done. njames93 added a comment. Use inheriting constructor for check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.h:25-26 +public: + InefficientArrayTraversalCheck(StringRef Name, ClangTidyContext *Context) + :

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nlopes added a comment. In D105169#3254692 , @DavidSpickett wrote: > Hi, this patch has caused a gcc test suite failure on our SVE bots: > https://lab.llvm.org/buildbot/#/builders/184/builds/1941 > (test source is >

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

aaron.ballman added inline comments. Comment at: clang/lib/Lex/MacroInfo.cpp:33 + +// MacroInfo is expected to take 40 bytes on platforms with an 8 byte pointer. +template class MacroInfoSizeChecker { dexonsmith wrote: > aaron.ballman wrote: > > Should we do

[PATCH] D117463: [clangd] Disable expand-auto action on constrained auto.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/ExpandAutoTypeTests.cpp:88 + R"cpp(template concept C = true; +^C a^uto abc(); +)cpp"); hokein wrote: > sammccall wrote: > > This shouldn't be unavailable because

[PATCH] D117568: [Analyzer] Add docs to StdCLibraryFunctionArgsChecker

martong added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2361 +(void)ret; +clang_analyzer_eval(EOF <= x && x <= 255); // this reports TRUE + } NoQ wrote: > I recommend against using `clang_analyzer_eval` in user docs. Users aren't >

[PATCH] D117568: [Analyzer] Add docs to StdCLibraryFunctionArgsChecker

martong updated this revision to Diff 401230. martong marked 3 inline comments as done. martong added a comment. - Describe the different kind of constraints and limitations - Some rewording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117568/new/

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

JonChesterfield added inline comments. Comment at: clang/lib/AST/Decl.cpp:1080 + if (const VarDecl *VD = dyn_cast(D)) +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(VD)) + return LinkageInfo(LV.getLinkage(), DefaultVisibility, false);

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 added a subscriber: ronlieb. jhuber6 added a comment. In D117362#3254681 , @JonChesterfield wrote: > If I'm following correctly, this broke the amdgpu buildbot and it has been > moved into staging as a workaround. I haven't debugged what breaks

[clang-tools-extra] 55b702c - [clangd] NFC, emit source ranges in selection debug messages.

Author: Haojian Wu Date: 2022-01-19T16:06:58+01:00 New Revision: 55b702c37b7e8b5fde04b6a60b5bb12806bdb697 URL: https://github.com/llvm/llvm-project/commit/55b702c37b7e8b5fde04b6a60b5bb12806bdb697 DIFF: https://github.com/llvm/llvm-project/commit/55b702c37b7e8b5fde04b6a60b5bb12806bdb697.diff

[PATCH] D117475: [clangd] NFC, emit source ranges in selection debug messages.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55b702c37b7e: [clangd] NFC, emit source ranges in selection debug messages. (authored by hokein). Changed prior to commit:

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

DavidSpickett added a comment. Hi, this patch has caused a gcc test suite failure on our SVE bots: https://lab.llvm.org/buildbot/#/builders/184/builds/1941 (test source is https://github.com/llvm/llvm-test-suite/blob/main/SingleSource/Regression/C/gcc-c-torture/execute/pr79286.c) I've only

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

JonChesterfield added a comment. If I'm following correctly, this broke the amdgpu buildbot and it has been moved into staging as a workaround. I haven't debugged what breaks but 'DefaultVisibility' is relatively likely to behave differently on cuda vs hsa systems so that's my first guess.

[PATCH] D117587: [ifs] Use a tmp file instead of "-"

DiggerLin accepted this revision. DiggerLin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117587/new/ https://reviews.llvm.org/D117587

[PATCH] D117475: [clangd] NFC, emit source ranges in selection debug messages.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Selection.cpp:551 printNodeKind(OS, N); OS << " "; return std::move(OS.str()); hmm, while here,

[PATCH] D117475: [clangd] NFC, emit source ranges in selection debug messages.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:704 + dlog("{1}skip: {0}", printNodeToString(N, PrintPolicy, SM), indent()); dlog("{1}skipped range = {0}", S.printToString(SM), indent(1)); return true;

[PATCH] D117475: [clangd] NFC, emit source ranges in selection debug messages.

hokein updated this revision to Diff 401219. hokein added a comment. address commment, only printing range on push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117475/new/ https://reviews.llvm.org/D117475 Files:

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

njames93 updated this revision to Diff 401209. njames93 added a comment. Remove now unnecessary changes in ClangTidyModule. Fix Cache miss reporting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117529/new/ https://reviews.llvm.org/D117529 Files:

[PATCH] D115349: [analyzer][NFC] Re-enable skipped SValTests by relaxing expectations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG881b6a009fb6: [analyzer][NFC] Re-enable skipped SValTests by relaxing expectations (authored by steakhal). Herald added a project: clang. Herald

[clang] 881b6a0 - [analyzer][NFC] Re-enable skipped SValTests by relaxing expectations

Author: Balazs Benics Date: 2022-01-19T15:16:18+01:00 New Revision: 881b6a009fb6e2dd5fb924524cd6eacd14148a08 URL: https://github.com/llvm/llvm-project/commit/881b6a009fb6e2dd5fb924524cd6eacd14148a08 DIFF: https://github.com/llvm/llvm-project/commit/881b6a009fb6e2dd5fb924524cd6eacd14148a08.diff

[PATCH] D117667: [clang][dataflow] Add a transfer function for conditional operator

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: steakhal, rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow

[PATCH] D117463: [clangd] Disable expand-auto action on constrained auto.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/ExpandAutoTypeTests.cpp:88 + R"cpp(template concept C = true; +^C a^uto abc(); +)cpp"); sammccall wrote: > This shouldn't be unavailable because it's constrained, it

[PATCH] D117529: [clangd][NFC] Cache ClangTidy check globs to speed up createChecks

njames93 updated this revision to Diff 401197. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117529/new/ https://reviews.llvm.org/D117529 Files: clang-tools-extra/clang-tidy/ClangTidyModule.h

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

joerg added a comment. Correct me if I'm wrong, but I don't think this stubs are async signal safe nor will they work for preemptive multitasking systems? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116088/new/ https://reviews.llvm.org/D116088

[clang] 5ea9898 - [clang-format] [docs] Fix link to avoid redirection. NFC.

Author: Marek Kurdej Date: 2022-01-19T14:23:04+01:00 New Revision: 5ea98988c65bc50f23cedaf11ead9470f1141235 URL: https://github.com/llvm/llvm-project/commit/5ea98988c65bc50f23cedaf11ead9470f1141235 DIFF: https://github.com/llvm/llvm-project/commit/5ea98988c65bc50f23cedaf11ead9470f1141235.diff

[PATCH] D117009: [AST] Fix the incorrect auto-keyword loc for constrained auto type loc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c78703e3abc: [AST] Fix the incorrect auto-keyword loc for constrained auto type loc. (authored by hokein). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 6c78703 - [AST] Fix the incorrect auto-keyword loc for constrained auto type loc.

Author: Haojian Wu Date: 2022-01-19T14:18:38+01:00 New Revision: 6c78703e3abcd9c76aefbf066869fe6a32d59516 URL: https://github.com/llvm/llvm-project/commit/6c78703e3abcd9c76aefbf066869fe6a32d59516 DIFF: https://github.com/llvm/llvm-project/commit/6c78703e3abcd9c76aefbf066869fe6a32d59516.diff

[PATCH] D117549: [clangd] Sort targets before printing for tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcae932b6c6d3: [clangd] Sort targets before printing for tests (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] cae932b - [clangd] Sort targets before printing for tests

Author: Kadir Cetinkaya Date: 2022-01-19T14:06:53+01:00 New Revision: cae932b6c6d3caedca4ad39d6e1345bcdbc0c863 URL: https://github.com/llvm/llvm-project/commit/cae932b6c6d3caedca4ad39d6e1345bcdbc0c863 DIFF:

[PATCH] D117549: [clangd] Sort targets before printing for tests

kadircet updated this revision to Diff 401178. kadircet marked an inline comment as done. kadircet added a comment. - Store in vector and sort Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117549/new/ https://reviews.llvm.org/D117549 Files:

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Grammar.h:52 +// Terminal IDs correspond to the clang TokenKind enum. +using SymbolID = uint16_t; +// SymbolID is only 12 bits wide. sammccall wrote: > If we want strong types,

[PATCH] D114790: [syntax][pseudo] Add grammar facilities for the pseudo-parser

hokein updated this revision to Diff 401175. hokein marked 8 inline comments as done. hokein added a comment. refine the patch: - address comments - remove unneeded code - move the BNF-grammar parsing code to a dedicate class, rather in Grammar. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:264 + if (Module || !AllowSearch || !HSOpts->ImplicitModuleMaps) { +noteModuleLookupUsage(Module, ImportLoc); return Module;

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:132-134 + /// Non-owning pointer to the file contents. This can be shared between + /// multiple entries (e.g. between a symlink and its target). +

[PATCH] D114966: [clang][deps] Split stat and file content caches

jansvoboda11 updated this revision to Diff 401171. jansvoboda11 marked 7 inline comments as done. jansvoboda11 added a comment. Update comments, remove `std::atomic<>`, merge `getOrEmplaceContentsForUID` into `getOrEmplaceEntryForUID`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117568: [Analyzer] Add docs to StdCLibraryFunctionArgsChecker

dkrupp added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2371 +diagnostics) for functions that are defined in the POSIX standard. This option +is disabled by default. + I think it would be useful for the user to see one example per constraint

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. In D111081#3212890 , @mgorny wrote: > Well, I dunno how MinGW works, so can't judge that part. Furthermore, I'm > thoroughly confused why this works on top of existing (non-Gentoo?) test > tree. Could you explain it a bit

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. I think this looks reasonable. I haven't tried it, but I guess we should proceed with it instead of holding it back, as there's nobody else reviewing it. Repository: rG LLVM Github

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2f488c6a5ce: [clang][AVR] Implement __flashN for variables on different flash banks (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D115982?vs=398846=401159#toc Repository:

[clang] a2f488c - [clang][AVR] Implement '__flashN' for variables on different flash banks

Author: Ben Shi Date: 2022-01-19T11:24:01Z New Revision: a2f488c6a5ce251426e4108fe3276f554f5bafac URL: https://github.com/llvm/llvm-project/commit/a2f488c6a5ce251426e4108fe3276f554f5bafac DIFF: https://github.com/llvm/llvm-project/commit/a2f488c6a5ce251426e4108fe3276f554f5bafac.diff LOG:

[clang] 6ee9654 - [Doc] Fix wrong indentation

Author: Saiyedul Islam Date: 2022-01-19T11:15:31Z New Revision: 6ee965471363972fafbed60ad8d27d0f666f8671 URL: https://github.com/llvm/llvm-project/commit/6ee965471363972fafbed60ad8d27d0f666f8671 DIFF: https://github.com/llvm/llvm-project/commit/6ee965471363972fafbed60ad8d27d0f666f8671.diff

[PATCH] D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.

steakhal added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-shared-ptr-array-mismatch.rst:22 + std::shared_ptr x(new Foo[10]); // -> std::shared_ptr x(new Foo[10]); + // ^ warning: shared pointer to non-array is

[PATCH] D117120: [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0731f6ba4f57: [Doc] Add documentation for the clang-offload-wrapper tool (NFC) (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0731f6b - [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

Author: Saiyedul Islam Date: 2022-01-19T10:45:13Z New Revision: 0731f6ba4f5773071a7b91248caf79a287703a28 URL: https://github.com/llvm/llvm-project/commit/0731f6ba4f5773071a7b91248caf79a287703a28 DIFF: https://github.com/llvm/llvm-project/commit/0731f6ba4f5773071a7b91248caf79a287703a28.diff

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/test/Sema/avr-flash.c:10 + static __flash5 const int a5[] = {4, 6}; // expected-error {{unknown type name '__flash5'}} + // TODO: It would be better to report "'__flash5' is not

[PATCH] D115982: [clang][AVR] Implement '__flashN' for variables on different flash banks

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:27 const char *DefineName; + const int MaxFlashBank; // -1 means the device does not support LPM/ELPM. }; aykevl wrote: > This works and

[PATCH] D93164: [AST] Add generator for source location introspection

andrew-wja added a comment. In D93164#3252509 , @lancethepants wrote: > In D93164#3250945 , @andrew-wja > wrote: > >> In D93164#3048130 , @lancethepants >> wrote: >> >>>

<    1   2   3   >