[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. See this github issue for the bug this fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp created this revision. JesApp added a reviewer: alexfh. JesApp added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. JesApp requested review of this revision. Herald added a subscriber: cfe-commits. The test invocation at the start of run-clang-tidy.py (line 257)

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 added a comment. In D117091#3267980 , @reames wrote: > In D117091#3265986 , @xbolva00 > wrote: > >> Ping @reames > > Not qualified to review clang/c++ library semantic changes. > > Also, did we

[PATCH] D118103: [X86]Fix the wrong value of bit_AVXVNNI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6984b299afc: Fix the wrong value of bit_AVXVNNI (authored by LiuChen3). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] f6984b2 - Fix the wrong value of bit_AVXVNNI

Author: Liu, Chen3 Date: 2022-01-25T14:41:23+08:00 New Revision: f6984b299afcbeddefe53db7ee1ce62e5d68cc4f URL: https://github.com/llvm/llvm-project/commit/f6984b299afcbeddefe53db7ee1ce62e5d68cc4f DIFF: https://github.com/llvm/llvm-project/commit/f6984b299afcbeddefe53db7ee1ce62e5d68cc4f.diff

[PATCH] D89105: [X86] Support Intel avxvnni

LiuChen3 added inline comments. Comment at: clang/lib/Headers/cpuid.h:199 /* Features in %eax for leaf 7 sub-leaf 1 */ +#define bit_AVXVNNI 0x0008 #define bit_AVX512BF160x0020 craig.topper wrote: > RKSimon wrote: > > @liuchen3

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham added a comment. In D117937#3268114 , @dexonsmith wrote: > The scenario you describe reminds me of the testcase in > https://reviews.llvm.org/D117730 ; can you explain if/how this patch relates > to that one? So a "fallback" is what we

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5149 + // Devices in the avr-1 family only support assembly programming. + if (TC.getArch() == llvm::Triple::avr) { +auto const =

[PATCH] D118095: [AVR][clang] Reject non assembly source files for the avr1 family

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, dylanmckay. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 402742. psigillito added a comment. - revert of .arclint file delete Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: clang/lib/Format/FormatToken.h

[clang-tools-extra] 810f13f - [clang-tools-extra] Fix documentation build (NFC)

Author: Richard Date: 2022-01-24T20:19:03-07:00 New Revision: 810f13f0ebde70e679a097a9f5dbe37fe58ffa27 URL: https://github.com/llvm/llvm-project/commit/810f13f0ebde70e679a097a9f5dbe37fe58ffa27 DIFF: https://github.com/llvm/llvm-project/commit/810f13f0ebde70e679a097a9f5dbe37fe58ffa27.diff LOG:

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood updated this revision to Diff 402741. LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/ https://reviews.llvm.org/D117939 Files:

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

achieveartificialintelligence updated this revision to Diff 402739. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. @asb Thank you very much! Could you please take a look at what needs to be modified now? Repository: rG LLVM

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood marked 16 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:301-317 +The Transformer library allows you to write a check that transforms source code by +expressing the

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 402737. psigillito added a comment. - revert bad arclint changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 402736. psigillito added a comment. Base diff on upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint clang/lib/Format/FormatToken.h

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 402735. psigillito added a comment. undo arclint change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint Index: .arclint

[PATCH] D107290: [RISCV] Add support for the vscale_range attribute

khchen added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vscale-range.ll:162 + +attributes #0 = { vscale_range(2,1024) } +attributes #1 = { vscale_range(4,1024) } I'm thinking do we need to test zvl and vscale_range in the same

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

keryell accepted this revision. keryell added a comment. That looks good. Comment at: clang/include/clang/Basic/AttrDocs.td:459 + SpecialType T; + cgh.single_task([=]() { + T.getF2(); CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

psigillito updated this revision to Diff 402733. psigillito marked 6 inline comments as done. psigillito added a comment. Review Changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117416/new/ https://reviews.llvm.org/D117416 Files: .arclint

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

dexonsmith added a comment. Haven't had a chance to look at the code (maybe @keith/@vsapsai/others will have time before I do) but at a high-level this seems pretty sound / SGTM. The scenario you describe reminds me of the testcase in https://reviews.llvm.org/D117730 ; can you explain if/how

[PATCH] D118092: review revisions

psigillito created this revision. psigillito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118092 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D118015: [RISCV][NFC] Rename RequiredExtensions to RequiredFeatures.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ea3dfa5d015: [RISCV][NFC] Rename RequiredExtensions to RequiredFeatures. (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9ea3dfa - [RISCV][NFC] Rename RequiredExtensions to RequiredFeatures.

Author: jacquesguan Date: 2022-01-25T10:26:16+08:00 New Revision: 9ea3dfa5d015f61ff282ed88d08125bb38fd19a8 URL: https://github.com/llvm/llvm-project/commit/9ea3dfa5d015f61ff282ed88d08125bb38fd19a8 DIFF: https://github.com/llvm/llvm-project/commit/9ea3dfa5d015f61ff282ed88d08125bb38fd19a8.diff

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 402725. LegalizeAdulthood added a comment. Remove -std for test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

daltenty updated this revision to Diff 402720. daltenty added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117935/new/ https://reviews.llvm.org/D117935 Files: clang/lib/Headers/float.h clang/test/Headers/Inputs/include/float.h

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

reames added a comment. In D117091#3265986 , @xbolva00 wrote: > Ping @reames Not qualified to review clang/c++ library semantic changes. Also, did we implement allocalign in LLVM? Last I knew it was a clang only attribute. If we did, it's missing

[PATCH] D113237: [RISCV] Support I extension version 2.1

achieveartificialintelligence added a comment. > @achieveartificialintelligence Do you know what is the relation between your > patch and D115921 ? This commit doesn't depend on D115921 , but if D115921

[PATCH] D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT

benlangmuir added a comment. > Does check-orc-rt need to be added to COMPILER_RT_TEST_SUITES too? I guess > not, otherwise we wouldn't have seen this missing dependency in the first > place? It doesn't affect `check-compiler-rt`, because `check-compiler-rt` actually wraps the `check-all`

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.cpp:1 +// RUN: %check_clang_tidy -std c++14-or-later %s modernize-macro-to-enum %t -- -- -I%S/Inputs/modernize-macro-to-enum + Ah, this

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood updated this revision to Diff 402716. LegalizeAdulthood added a comment. Update from additional testing: - reject floating-point literals (they can't be enumerations) - add more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida accepted this revision. cishida added a comment. This revision is now accepted and ready to land. I followed up about this approach with folks more familiar with SourceKit and seems fine, so LGTM. I'd wait a day to see if Jan has any concerns. Comment at:

[PATCH] D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. LGTM! Does check-orc-rt need to be added to `COMPILER_RT_TEST_SUITES` too? I guess not, otherwise we wouldn't have seen this missing dependency in the first place? Repository: rG LLVM

[PATCH] D117262: [NFC] Store Address's alignment into PointerIntPairs

rnk added inline comments. Comment at: clang/lib/CodeGen/Address.h:30 + // Int portion stores lower 3 bits of the log of the alignment. + llvm::PointerIntPair ElementType; dblaikie wrote: > nikic wrote: > > dblaikie wrote: > > > aeubanks wrote: > > > > nikic

[PATCH] D118087: Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT

benlangmuir created this revision. benlangmuir added reviewers: lhames, fhahn. Herald added a subscriber: mgorny. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add missing dependency on llvm-jitlink when building compiler-rt

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

jrtc27 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116774/new/ https://reviews.llvm.org/D116774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117938: [clang][dataflow] Avoid MaxIterations overflow

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd01d971aa2c: [clang][dataflow] Avoid MaxIterations overflow (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] dd01d97 - [clang][dataflow] Avoid MaxIterations overflow

Author: Jan Korous Date: 2022-01-24T15:58:38-08:00 New Revision: dd01d971aa2c4b464a295ca5c78ff93fc4441dc3 URL: https://github.com/llvm/llvm-project/commit/dd01d971aa2c4b464a295ca5c78ff93fc4441dc3 DIFF: https://github.com/llvm/llvm-project/commit/dd01d971aa2c4b464a295ca5c78ff93fc4441dc3.diff

[PATCH] D118082: [clang][Driver] use DWARF4 for wasm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d8d2d572cd: [clang][Driver] use DWARF4 for wasm (authored by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d0d8d2d - [clang][Driver] use DWARF4 for wasm

Author: Derek Schuff Date: 2022-01-24T15:46:54-08:00 New Revision: d0d8d2d572cd1db54d0f6d90f8dd3825f9c7b36b URL: https://github.com/llvm/llvm-project/commit/d0d8d2d572cd1db54d0f6d90f8dd3825f9c7b36b DIFF: https://github.com/llvm/llvm-project/commit/d0d8d2d572cd1db54d0f6d90f8dd3825f9c7b36b.diff

[PATCH] D118084: [CUDA, NVPTX] Pass byval aggregates directly

tra created this revision. tra added reviewers: jdoerfert, yaxunl. Herald added subscribers: asavonic, bixia. tra requested review of this revision. Herald added a project: clang. Changes the NVPTX ABI to pass aggregates directly. Only clang-generated IR is affected. The change does not affect

[PATCH] D89105: [X86] Support Intel avxvnni

craig.topper added inline comments. Comment at: clang/lib/Headers/cpuid.h:199 /* Features in %eax for leaf 7 sub-leaf 1 */ +#define bit_AVXVNNI 0x0008 #define bit_AVX512BF160x0020 RKSimon wrote: > @liuchen3

[PATCH] D118082: [clang][Driver] use DWARF4 for wasm

dschuff updated this revision to Diff 402695. dschuff added a comment. fix diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118082/new/ https://reviews.llvm.org/D118082 Files: clang/lib/Driver/ToolChains/WebAssembly.h

[PATCH] D118082: [clang][Driver] use DWARF4 for wasm

dschuff updated this revision to Diff 402694. dschuff added a comment. just one blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118082/new/ https://reviews.llvm.org/D118082 Files: clang/test/Driver/debug-options.c Index:

[PATCH] D117809: [clang] Add an extract-api driver option

zixuw added a comment. Ping for any additional reviews/comments. I must admit that I got really confused and lost in the layers of the driver and setting up the phases. I wasn't sure if I made enough (or too many?) changes to make this work. So any comments or advice are welcomed. Repository:

[PATCH] D117423: [AVR][clang] Reject non assembly source files for the avr1 family

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5149 + // Devices in the avr-1 family only support assembly programming. + if (TC.getArch() == llvm::Triple::avr) { +auto const = static_cast(TC); Try moving the check from

[PATCH] D118082: [clang][Driver] use DWARF4 for wasm

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options.c:141 +// RUN: | FileCheck -check-prefix=G_DWARF4 %s + + Keep just one blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [clang] d3b26de - Clang: Change the default DWARF version to 5

Oh, sorry, I see you are zmodem... yay for getting used to more usernames - thanks for the workaround :) On Mon, Jan 24, 2022 at 3:05 PM David Blaikie wrote: > Looks like that got addressed/worked around with > https://github.com/llvm/llvm-project/commit/38e16e1cebb891ad47b85727bf46f7dac6d7da94

Re: [clang] d3b26de - Clang: Change the default DWARF version to 5

Looks like that got addressed/worked around with https://github.com/llvm/llvm-project/commit/38e16e1cebb891ad47b85727bf46f7dac6d7da94 I'll look into it further once I've cleaned up other live fallout. On Mon, Jan 24, 2022 at 10:01 AM Hans Wennborg wrote: > For me, this broke some tests of the

[PATCH] D118082: [clang][Driver] use DWARF4 for wasm

dschuff added subscribers: pfaffe, azakai. dschuff added a comment. Also +cc @pfaffe and @azakai I'd like to land this soon to fix our emscripten tests for now. But we should talk about what the default should be. I'm curious if @sunfish has any any opinions on DWARF for their use cases and

[PATCH] D118082: [clang][Driver] use DWARF4 for wasm

dschuff created this revision. dschuff added reviewers: aardappel, sunfish. Herald added subscribers: wingo, jgravelle-google, sbc100. dschuff requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Opt into the old default of DWARF4 for

[PATCH] D112119: [ObjC Availability] Add missing const to getVersion function of ObjCAvailabilityCheckExpr class

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1c9e7bdc921: [ObjC Availability] Add missing const to getVersion function of… (authored by lcs, committed by kyulee). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f1c9e7b - [ObjC Availability] Add missing const to getVersion function of ObjCAvailabilityCheckExpr class

Author: Chaoshuai Lu Date: 2022-01-24T14:52:57-08:00 New Revision: f1c9e7bdc921cec0cc3f61c19c4ac4a7f1bd8525 URL: https://github.com/llvm/llvm-project/commit/f1c9e7bdc921cec0cc3f61c19c4ac4a7f1bd8525 DIFF: https://github.com/llvm/llvm-project/commit/f1c9e7bdc921cec0cc3f61c19c4ac4a7f1bd8525.diff

[PATCH] D89105: [X86] Support Intel avxvnni

RKSimon added inline comments. Comment at: clang/lib/Headers/cpuid.h:199 /* Features in %eax for leaf 7 sub-leaf 1 */ +#define bit_AVXVNNI 0x0008 #define bit_AVX512BF160x0020 @liuchen3 https://github.com/llvm/llvm-project/issues/53392 reports

[PATCH] D118075: [Fuchsia] Remove i386 from iossim architectures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe0c5309c4a8: [Fuchsia] Remove i386 from iossim architectures (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] fe0c530 - [Fuchsia] Remove i386 from iossim architectures

Author: Petr Hosek Date: 2022-01-24T14:48:47-08:00 New Revision: fe0c5309c4a8bf022b2ec66a0d28513e7fb1441b URL: https://github.com/llvm/llvm-project/commit/fe0c5309c4a8bf022b2ec66a0d28513e7fb1441b DIFF: https://github.com/llvm/llvm-project/commit/fe0c5309c4a8bf022b2ec66a0d28513e7fb1441b.diff

[PATCH] D117746: [CMake] Pass CMAKE_C/CXX_COMPILER_LAUNCHER down to cross-compile and runtime build

This revision was automatically updated to reflect the committed changes. Closed by commit rGda85307ba699: [CMake] Pass CMAKE_C/CXX_COMPILER_LAUNCHER down to cross-compile and runtime… (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98110: [NFC][clangd] Use table to collect option aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b64ab574d98: [NFC][clangd] Use table to collect option aliases (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98110/new/

[clang] da85307 - [CMake] Pass CMAKE_C/CXX_COMPILER_LAUNCHER down to cross-compile and runtime build

Author: Yuanfang Chen Date: 2022-01-24T14:27:14-08:00 New Revision: da85307ba699ea2260252f523e089c85e863d671 URL: https://github.com/llvm/llvm-project/commit/da85307ba699ea2260252f523e089c85e863d671 DIFF: https://github.com/llvm/llvm-project/commit/da85307ba699ea2260252f523e089c85e863d671.diff

[clang-tools-extra] 3b64ab5 - [NFC][clangd] Use table to collect option aliases

Author: Yuanfang Chen Date: 2022-01-24T14:27:14-08:00 New Revision: 3b64ab574d985b70cb4ec0f69c1fc1c1c4527cde URL: https://github.com/llvm/llvm-project/commit/3b64ab574d985b70cb4ec0f69c1fc1c1c4527cde DIFF: https://github.com/llvm/llvm-project/commit/3b64ab574d985b70cb4ec0f69c1fc1c1c4527cde.diff

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel added inline comments. Comment at: clang/lib/Tooling/Transformer/SourceCodeBuilders.cpp:78 + returns(qualType(references(type())); + const auto SmartPointer = qualType(hasDeclaration( + cxxRecordDecl(anyOf(KnownSmartPointer,

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel updated this revision to Diff 402663. ymandel marked 9 inline comments as done. ymandel added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116377/new/ https://reviews.llvm.org/D116377 Files:

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 402662. zahiraam marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 402661. amilendra added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 402659. amilendra added a comment. Add new interface isArmMClass() to the Triple class. Use isArmT32() and isArmMClass() to emit PACBTI warnings for ARM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117137: [Driver] Add CUDA support for --offload param

tra added a subscriber: linjamaki. tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:153-155 + if (TT->getArch() == llvm::Triple::spirv64 && + TT->getVendor() == llvm::Triple::UnknownVendor && + TT->getOS() == llvm::Triple::UnknownOS)

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna marked an inline comment as done. dcastagna added inline comments. Comment at: clang/lib/Driver/Driver.cpp:153-155 + if (TT->getArch() == llvm::Triple::spirv64 && + TT->getVendor() == llvm::Triple::UnknownVendor && + TT->getOS() == llvm::Triple::UnknownOS)

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna updated this revision to Diff 402657. dcastagna added a comment. Remove unknown-unknown check from HIP offload logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117137/new/ https://reviews.llvm.org/D117137 Files:

[PATCH] D117137: [Driver] Add CUDA support for --offload param

dcastagna added inline comments. Comment at: clang/lib/Driver/Driver.cpp:153-155 + if (TT->getArch() == llvm::Triple::spirv64 && + TT->getVendor() == llvm::Triple::UnknownVendor && + TT->getOS() == llvm::Triple::UnknownOS) tra wrote: > What's expected

[PATCH] D117137: [Driver] Add CUDA support for --offload param

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:153-155 + if (TT->getArch() == llvm::Triple::spirv64 && + TT->getVendor() == llvm::Triple::UnknownVendor && + TT->getOS() == llvm::Triple::UnknownOS) What's expected to happen if

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

dgoldman added a comment. In D117830#3267404 , @cishida wrote: > My understanding for the header map restriction is because headermaps are > generally emitted once for a framework build and only consumed to build such > framework and this struct

[PATCH] D118075: [Fuchsia] Remove i386 from iossim architectures

phosek updated this revision to Diff 402650. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118075/new/ https://reviews.llvm.org/D118075 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index: clang/cmake/caches/Fuchsia-stage2.cmake

[PATCH] D118075: [Fuchsia] Remove i386 from iossim architectures

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is no longer supported in newer SDK versions. Repository:

[PATCH] D117830: [HeaderSearch] Track framework name in LookupFile

cishida added a comment. My understanding for the header map restriction is because headermaps are generally emitted once for a framework build and only consumed to build such framework and this struct information is only queried during this. It sounds like for the clangd support, you're not as

[PATCH] D112073: [PowerPC] Emit warning when SP is clobbered by asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a028296fe62: [PowerPC] Emit warning when SP is clobbered by asm (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 6a02829 - [PowerPC] Emit warning when SP is clobbered by asm

Author: Quinn Pham Date: 2022-01-24T15:12:23-06:00 New Revision: 6a028296fe62252791a6b470eeb8409b17d48cd0 URL: https://github.com/llvm/llvm-project/commit/6a028296fe62252791a6b470eeb8409b17d48cd0 DIFF: https://github.com/llvm/llvm-project/commit/6a028296fe62252791a6b470eeb8409b17d48cd0.diff

[PATCH] D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC).

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:131 + if (const auto *TU = Result.Nodes.getNodeAs("TU")) { +// Call graph must be populated with the entire TU at the begin. +// (It is possible to add a single

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

tra added a comment. The patch uses a `@gmail.com` email. Should I change it to `JackAKirk ` to match the sign-off email? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118023/new/ https://reviews.llvm.org/D118023

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16686-16687 +if (RD->hasAttr()) { + auto *Def = RD->getDefinition(); + if (Def && !Def->hasInitMethod()) +Diag(RD->getLocation(), zahiraam wrote: > aaron.ballman

[PATCH] D118063: [DONOTSUBMIT] work on prototyping bracket fix its

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118063

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam marked 11 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16686-16687 +if (RD->hasAttr()) { + auto *Def = RD->getDefinition(); + if (Def && !Def->hasInitMethod()) +Diag(RD->getLocation(),

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

erichkeane added a comment. I don't have sufficient experience to approve this, but I DID look through it and found 1 suspicious thing. Comment at: clang/lib/Sema/SemaAccess.cpp:1799 +R = SourceRange(ArgExprs.front()->getBeginLoc(), +

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk added a comment. In D118023#3266987 , @tra wrote: > If you are not sure if you have commit access, you probably do not. It must > be explicitly granted: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > > As for landing

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402610. cor3ntin added a comment. Fix another typo in the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994 Files:

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

tra added a comment. If you are not sure if you have commit access, you probably do not. It must be explicitly granted: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access As for landing the patch, I do it manually with git. Never tried it with `arc`, so I can't say much, except

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

aaron.ballman added reviewers: rsmith, erichkeane, rjmccall. aaron.ballman added a comment. I've not had the chance to review yet, but adding some more reviewers for better visibility (I've got WG14 meetings coming up so my availability is a bit limited at the moment). Repository: rG LLVM

[PATCH] D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC).

aaron.ballman added a comment. Thanks for the cleanup, I like the direction this is heading. But is this actually NFC? I thought using a `CallGraph` would change the behavior in code like: if (false) { // Statically known never to take this branch bad_call(); // Used to diagnose, does it

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr added a comment. @rsmith Weekly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117391/new/ https://reviews.llvm.org/D117391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117390: [AST] Reformat CastExpr unittest suite

kimgr added a comment. @rsmith Weekly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117390/new/ https://reviews.llvm.org/D117390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117939: [clang-tidy] Add more documentation about check development

aaron.ballman added a comment. In D117939#3266228 , @njames93 wrote: > @aaron.ballman I think this has exposed some limitations with the > add-new-check script. Maybe there is merit for the script to be updated to > support preprocessor callbacks and

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

JackAKirk added a comment. In D118023#3266877 , @tra wrote: > LGTM. Should I commit the patch on your behalf? > > In D118023#3265601 , @JackAKirk > wrote: > >> Note that the test, llvm/test/CodeGen/NVPTX/wmma.py

[PATCH] D118023: Corrected fragment size for tf32 LD B matrix.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Should I commit the patch on your behalf? In D118023#3265601 , @JackAKirk wrote: > Note that the test, llvm/test/CodeGen/NVPTX/wmma.py line 210, had

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman added a comment. Thanks! Mostly just minor nits from me. Comment at: clang/include/clang/AST/DeclCXX.h:1143 + void SetInitMethod(bool val) { data().HasInitMethod = val; } + bool hasInitMethod() const { return data().HasInitMethod; }

[PATCH] D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute

aaron.ballman added a comment. I am not particularly comfortable with allowing type attributes to be applied via `#pragma clang attribute`; the interface for that pragma is centered around declarations and not types, and I'm not certain how viable the idea is to shotgun blast out type

[PATCH] D117913: [Clang][RISCV] Guard vmulh, vsmul correctly

craig.topper accepted this revision. craig.topper added a comment. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117913/new/ https://reviews.llvm.org/D117913 ___ cfe-commits mailing list

Re: [clang] d3b26de - Clang: Change the default DWARF version to 5

For me, this broke some tests of the profiling runtime: $ ninja check-profile ... Failed Tests (2): Profile-i386 :: Linux/instrprof-debug-info-correlate.c Profile-x86_64 :: Linux/instrprof-debug-info-correlate.c Annoyingly, I can't find any buildbots where this fails, but I'm not really sure

[PATCH] D117730: [DNM][VFS] Do not overwrite the path when nesting RedirectingFileSystems

keith added a comment. In D117730#3262622 , @dexonsmith wrote: > @keith, any thoughts on this? IIRC, you'd found a few other bugs while you > were in there which you'd left for later; not sure if this is related to them > or not. This issue wasn't

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM, just one suggestion. It would be great to get @aaron.ballman approve too. Comment at: clang/lib/Sema/SemaDecl.cpp:16690 +

[PATCH] D107290: [PoC][RISCV] Add support for the vscale_range attribute

frasercrmck updated this revision to Diff 402572. frasercrmck added a comment. Herald added a subscriber: pcwang-thead. rebase take minimum from zvl extensions allow backend options to override attribute values add extra testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118044: [ARM] Undeprecate complex IT blocks

MarkMurrayARM added inline comments. Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:10977 -Warning(IDLoc, "deprecated instruction in IT block"); - } } DavidSpickett wrote: > Is this warning something you'd still want if you opted

  1   2   3   >