[PATCH] D118439: [scan-build] Fix deadlock at failures in libears/ear.c

steakhal added a comment. We missed the release, let's backport it to 14.0.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118439/new/ https://reviews.llvm.org/D118439 ___ cfe-commits mailing list

[PATCH] D119256: [OpenMP][Clang] Move partial support of reverse offload to a future version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4db88a54b6d4: [OpenMP][Clang] Move partial support of reverse offload to a future version (authored by saiislam). Repository: rG LLVM Github

[clang] 4db88a5 - [OpenMP][Clang] Move partial support of reverse offload to a future version

Author: Saiyedul Islam Date: 2022-02-09T07:11:41Z New Revision: 4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e URL: https://github.com/llvm/llvm-project/commit/4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e DIFF: https://github.com/llvm/llvm-project/commit/4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e.diff

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added a comment. In D84225#3305140 , @rnk wrote: > In D84225#3304189 , @pengfei wrote: > >> It's not a workaround. We do need to avoid the merging sometime. For >> example, given we have 2 branches begin

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added inline comments. Comment at: lld/ELF/Driver.cpp:690 +if (config->memtagStack || config->memtagHeap) + error("When using --memtag-stack or --memtag-heap, a --memtag-mode value " +"is required."); lld uses the diagnostic format

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added a comment. In D118948#3295589 , @hctim wrote: > In D118948#3295321 , @MaskRay wrote: > >> I haven't investigated the use case yet, just commented a few things. Please >> split the patch into 3: >>

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} ABataev

[PATCH] D119296: KCFI sanitizer

joaomoreira added inline comments. Comment at: clang/include/clang/Basic/Attr.td:696 +def KCFIUnchecked : Attr { + let Spellings = [Clang<"kcfi_unchecked">]; + let Subjects = SubjectList<[Var, TypedefName]>; Are you considering that perhaps one could use KCFI

[clang] a163cdf - [docs] Re-generate ClangCommandLineReference.rst

Author: Fangrui Song Date: 2022-02-08T20:54:52-08:00 New Revision: a163cdf6b50c0b7706fcf7805fd29736ad4eb9c2 URL: https://github.com/llvm/llvm-project/commit/a163cdf6b50c0b7706fcf7805fd29736ad4eb9c2 DIFF: https://github.com/llvm/llvm-project/commit/a163cdf6b50c0b7706fcf7805fd29736ad4eb9c2.diff

[PATCH] D117809: [clang] Add an extract-api driver option

MaskRay added a comment. Thanks for working on such tools but the patch order is not right. You should implement the functionality first, and in the last, add the driver option. The driver option is user-facing and the availability makes users think the functionality is ready when it actually

[PATCH] D119309: [Driver][test] Clean up some AIX tests

MaskRay updated this revision to Diff 407038. MaskRay edited the summary of this revision. MaskRay added a comment. update more Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119309/new/ https://reviews.llvm.org/D119309 Files:

[PATCH] D119309: [Driver][test] Clean up some AIX tests

MaskRay created this revision. MaskRay added reviewers: DiggerLin, hubert.reinterpretcast, jasonliu, stevewan, Xiangling_L. Herald added a reviewer: ctetreau. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - For `-###`, `-o %t.o`

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

MaskRay added inline comments. Comment at: clang/lib/Driver/Job.cpp:304 +void Command::setRedirectFiles(std::vector> Redirects) { + RedirectFiles = Redirects; Comment at: clang/lib/Driver/Job.cpp:370 +

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:555 +def GPRF64 : RegisterClass<"RISCV", [f64], 64, (add GPR)>; +def GPRPF64 : RegisterClass<"RISCV", [f64], 64, (add +X10_PD, X12_PD, X14_PD, X16_PD, Is XLenRI correct for

[PATCH] D119299: [NFC] clang-format one function.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I don't think you need approval for that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119299/new/ https://reviews.llvm.org/D119299

[PATCH] D119026: [HIP] Emit amdgpu_code_object_version module flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d97cb1f6e44: [HIP] Emit amdgpu_code_object_version module flag (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1d97cb1 - [HIP] Emit amdgpu_code_object_version module flag

Author: Yaxun (Sam) Liu Date: 2022-02-08T21:58:40-05:00 New Revision: 1d97cb1f6e44a77cfc6911b916656e3c5de9bec8 URL: https://github.com/llvm/llvm-project/commit/1d97cb1f6e44a77cfc6911b916656e3c5de9bec8 DIFF:

[PATCH] D119250: [RISCV][NFC] Refactor RISCVISAInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe7f690367b: [RISCV][NFC] Refactor RISCVISAInfo. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cfe7f69 - [RISCV][NFC] Refactor RISCVISAInfo.

Author: Zakk Chen Date: 2022-02-08T18:37:43-08:00 New Revision: cfe7f690367b9d2903f099162f0bcbbfd18c7610 URL: https://github.com/llvm/llvm-project/commit/cfe7f690367b9d2903f099162f0bcbbfd18c7610 DIFF: https://github.com/llvm/llvm-project/commit/cfe7f690367b9d2903f099162f0bcbbfd18c7610.diff

[clang] 8440ec6 - [docs] Document -ffinite-math-only, -fhonor-{infinities,infinites,nans}

Author: Jon Roelofs Date: 2022-02-08T18:10:17-08:00 New Revision: 8440ec66f4f0f2e4f49061262648809345952bf7 URL: https://github.com/llvm/llvm-project/commit/8440ec66f4f0f2e4f49061262648809345952bf7 DIFF: https://github.com/llvm/llvm-project/commit/8440ec66f4f0f2e4f49061262648809345952bf7.diff

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1658-1659 Target.getNewAlign(), getContext().getTypeSize(allocType))); allocationAlign = std::max( allocationAlign, getContext().toCharUnitsFromBits(AllocatorAlign)); }

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

ChuanqiXu added a comment. In D115610#3304289 , @urnathan wrote: > the landed version is good, with Richard's suggested member name change. > Can't see a way of post-commit accepting? Yeah, maybe we can't do post-commit accept formally. Repository:

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + jdoerfert wrote: > sameerds wrote: > > jdoerfert wrote: > > > jdoerfert wrote: > > > > sameerds wrote: > > > > > jdoerfert wrote: > > > > >

[PATCH] D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

shangwuyao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322 ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const { - if (getContext().getLangOpts().HIP) { + if (getContext().getLangOpts().CUDAIsDevice) { // Coerce pointer

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdeaf22bc0e30: [X86] Implement -fzero-call-used-regs option (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] deaf22b - [X86] Implement -fzero-call-used-regs option

Author: Bill Wendling Date: 2022-02-08T17:42:54-08:00 New Revision: deaf22bc0e306bc44c70d2503e9364b5ed312c49 URL: https://github.com/llvm/llvm-project/commit/deaf22bc0e306bc44c70d2503e9364b5ed312c49 DIFF: https://github.com/llvm/llvm-project/commit/deaf22bc0e306bc44c70d2503e9364b5ed312c49.diff

[clang] dc8f4e1 - [cxx_status] Add a couple of Feb 2022 library papers that need compiler support.

Author: Richard Smith Date: 2022-02-08T17:25:52-08:00 New Revision: dc8f4e118d92982ff5f6316fe7d541d120ebabd1 URL: https://github.com/llvm/llvm-project/commit/dc8f4e118d92982ff5f6316fe7d541d120ebabd1 DIFF: https://github.com/llvm/llvm-project/commit/dc8f4e118d92982ff5f6316fe7d541d120ebabd1.diff

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4667 + + SmallVector Expr; + AppendAddressSpaceXDeref(AddressSpace, Expr); aprantl wrote: > 13 seems to be unnecessarily high. Shouldn't 1 be enough for the expected > single

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647 +const bool UsePointerValue) { + assert(CGM.getCodeGenOpts().hasReducedDebugInfo()); + assert(!LexicalBlockStack.empty() && "Region stack mismatch,

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen created this revision. ychen added reviewers: mubashar_, lenary, pbarrio. Herald added a subscriber: kristof.beyls. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rnk added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1658-1659 Target.getNewAlign(), getContext().getTypeSize(allocType))); allocationAlign = std::max( allocationAlign, getContext().toCharUnitsFromBits(AllocatorAlign)); }

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 reopened this revision. tyb0807 added a comment. This revision is now accepted and ready to land. Reverted due to buildbots failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199

[clang] 9b81d2f - Revert "[AArch64] ACLE feature macro for Armv8.8-A MOPS"

Author: tyb0807 Date: 2022-02-09T00:10:09Z New Revision: 9b81d2fae8c05ea611578137101e46a7b61fbaed URL: https://github.com/llvm/llvm-project/commit/9b81d2fae8c05ea611578137101e46a7b61fbaed DIFF: https://github.com/llvm/llvm-project/commit/9b81d2fae8c05ea611578137101e46a7b61fbaed.diff LOG:

[PATCH] D119296: KCFI sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); We considered a scheme like this

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5419 + typedef typeof(f1) * __attribute__((kcfi_unchecked) unchecked_t; + ((unchecked_t)p2)(); // unchecked + `p2` is already unchecked. Would it be more demonstrative to

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

eugenis created this revision. eugenis added reviewers: kda, vitalybuka. eugenis requested review of this revision. Herald added projects: clang, Sanitizers. Herald added a subscriber: Sanitizers. -fsanitize-memory-use-after-dtor detects memory access after a subobject is destroyed but its memory

[PATCH] D119299: [NFC] clang-format one function.

eugenis created this revision. eugenis added reviewers: kda, vitalybuka. eugenis requested review of this revision. Herald added a project: clang. fix code formatting Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119299 Files: clang/lib/CodeGen/CGClass.cpp Index:

[PATCH] D119296: KCFI sanitizer

samitolvanen created this revision. Herald added subscribers: dexonsmith, dang, jdoerfert, cryptoad. Herald added a reviewer: aaron.ballman. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The KCFI sanitizer, enabled with

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

browneee added a comment. Hi, This change appears to break on of the buildbots (clang-ppc64le-linux-lnt ): https://lab.llvm.org/buildbot/#/builders/105/builds/21233/steps/7/logs/FAIL__Clang__aarch64-mops_c TEST 'Clang ::

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rjmccall added a comment. If we want to assume a weaker alignment, we should change the calculation of `allocationAlign` rather than just changing this point downstream of that computation. But replacements of the standard `operator new` are restricted and cannot simply choose to return

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

MaskRay added a comment. In D119257#3306151 , @krzysz00 wrote: > Having checked with other folks more familiar with the context of our > project, it looks like we might actually be fine using lld as a subprocess, > since we'll always be sitting on top

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai updated this revision to Diff 406977. vsapsai added a comment. Herald added a project: clang. Rebase and address clang-format comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118525/new/ https://reviews.llvm.org/D118525 Files:

[clang] ca9f0ec - [clang] Document objc_unsafeClaimAutoreleasedReturnValue.

Author: Ahmed Bougacha Date: 2022-02-08T14:30:39-08:00 New Revision: ca9f0ec1a30b899ce9df3d2173aa9a295b510509 URL: https://github.com/llvm/llvm-project/commit/ca9f0ec1a30b899ce9df3d2173aa9a295b510509 DIFF:

[clang] 6ba68a5 - [clang][Driver] Use a VersionTuple for darwin linker version checks.

Author: Ahmed Bougacha Date: 2022-02-08T14:30:39-08:00 New Revision: 6ba68a5fc34271c85f438217f50e165cb0158c04 URL: https://github.com/llvm/llvm-project/commit/6ba68a5fc34271c85f438217f50e165cb0158c04 DIFF:

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

krzysz00 added a comment. Having checked with other folks more familiar with the context of our project, it looks like we might actually be fine using lld as a subprocess, since we'll always be sitting on top of a ROCm installation, which includes lld, and since "take this object file and wrap

[PATCH] D119291: [Clang] Add support for STDC CX_LIMITED_RANGE pragma.

jcranmer-intel created this revision. Herald added a subscriber: dexonsmith. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This pragma is defined in the C specification. Notably, the C specification makes the "DEFAULT"

[PATCH] D119290: [Clang] Add support for -fcx-limited-range, -fcx-fortran-rules options.

jcranmer-intel created this revision. Herald added a subscriber: dang. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These are built on top of, and require, the complex intrinsics definitions to work with. They are

[PATCH] D119289: [Clang] Add lowering for _C complex arithmetic to complex intrinsics.

jcranmer-intel created this revision. Herald added subscribers: dexonsmith, dang, pengfei. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a new guard flag, -fuse-complex-intrinsics, that is defaulted to on for the

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXIntrinsics.td:937 +class FMA_TUPLE Preds = [hasPTX70, hasSM80]> { + string Variant = V; I think the default should be the most useful/common and the least surprising value. I'd argue that in

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

krzysz00 added a comment. (Since it looks like the discussion moved here) @MaskRay We can't spawn lld as a subprocess due to customer requirements around having the kernel generator/compiler delivered as a static library in some cases. (And there's LLVM version compatibility concerns, but

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

mehdi_amini added a comment. Yes, I saw these, thanks a lot @aganea !! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119257/new/ https://reviews.llvm.org/D119257 ___ cfe-commits mailing list

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

aganea added a comment. @mehdi_amini Just to unblock users, I've posted https://reviews.llvm.org/D119277 which fixes the issue originally raised by @krzysz00 I'm also working on a more long term solution in https://reviews.llvm.org/D119049 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

mehdi_amini added a comment. (The discussion seems to be happening in two places: https://github.com/llvm/llvm-project/issues/53475 ) You can break downstream users, the relationship inside the monorepo is different as far as I know: I believe we will have to live with revert like the one

[PATCH] D118936: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16cc5df2288: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address… (authored by aeubanks). Repository: rG LLVM Github

[clang] f16cc5d - [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

Author: Arthur Eubanks Date: 2022-02-08T13:22:43-08:00 New Revision: f16cc5df2288ef4637de29cd878627967b0fee3b URL: https://github.com/llvm/llvm-project/commit/f16cc5df2288ef4637de29cd878627967b0fee3b DIFF:

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Thanks to @aganea for working on this. I agree that lld/ELF is not ready for library usage. So far the arguments have always been "the library usage is easy since lld headers

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf05a63f9a09b: [clang] Properly cache member pointer LLVM types (authored by aeubanks). Changed prior to commit:

[clang] f05a63f - [clang] Properly cache member pointer LLVM types

Author: Arthur Eubanks Date: 2022-02-08T13:22:24-08:00 New Revision: f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149 URL: https://github.com/llvm/llvm-project/commit/f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149 DIFF:

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 406948. void added a comment. Remove obsolete change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd379ec99085e: [AArch64] ACLE feature macro for Armv8.8-A MOPS (authored by tyb0807). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d379ec9 - [AArch64] ACLE feature macro for Armv8.8-A MOPS

Author: tyb0807 Date: 2022-02-08T21:07:49Z New Revision: d379ec99085e33ace51740f2b93bda5e5c72326f URL: https://github.com/llvm/llvm-project/commit/d379ec99085e33ace51740f2b93bda5e5c72326f DIFF: https://github.com/llvm/llvm-project/commit/d379ec99085e33ace51740f2b93bda5e5c72326f.diff LOG:

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

aganea added a comment. All things considered I think in the short term it is better to aim for small patches/fixes that can be transplanted to `release/14.x` if need be. I've posted D119277 for the issue you were seeing @krzysz00, but I am still planning on

[clang] f2c2e92 - Fix a typo (occured => occurred)

Author: Sylvestre Ledru Date: 2022-02-08T21:35:26+01:00 New Revision: f2c2e924e73a76562b7cc6d8fd96df5b177eaf18 URL: https://github.com/llvm/llvm-project/commit/f2c2e924e73a76562b7cc6d8fd96df5b177eaf18 DIFF:

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 406927. ychen marked an inline comment as done. ychen added a comment. - address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files:

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 406924. void added a comment. Move register clearning to after the "pop"s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:595 +continue; + XorOp = X86::PXORrr; +} else if (X86::VR256RegClass.contains(Reg)) { nickdesaulniers wrote: > void wrote: > > nickdesaulniers wrote: > > > Is there

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen marked an inline comment as done. ychen added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:180 + "JMC instrument more than once?"); + FunctionCallee Fn = + M.getOrInsertFunction(CheckFunctionName, getCheckFunctionType(Ctx));

[PATCH] D119231: [clang][lex][minimizer] Ensure whitespace between squashed lines

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119231/new/ https://reviews.llvm.org/D119231

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

xbolva00 added inline comments. Comment at: clang/test/CodeGen/alloc-align-attr.c:14 // CHECK-NEXT:[[CASTED_ALIGN:%.*]] = zext i32 [[TMP0]] to i64 // CHECK-NEXT:call void @llvm.assume(i1 true) [ "align"(i32* [[CALL]], i64 [[CASTED_ALIGN]]) ] // CHECK-NEXT:

[PATCH] D119234: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG079b6d02d1f5: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt (authored by mstorsjo). Repository: rG LLVM Github Monorepo

[clang] 079b6d0 - [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt

Author: Martin Storsjö Date: 2022-02-08T21:57:07+02:00 New Revision: 079b6d02d1f52301e2d3276fadba822bf87b75b2 URL: https://github.com/llvm/llvm-project/commit/079b6d02d1f52301e2d3276fadba822bf87b75b2 DIFF:

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 created this revision. Herald added a subscriber: jdoerfert. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM is growing knowledge of this, so we should inform it when we have the information available. Depends on

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119215/new/ https://reviews.llvm.org/D119215 ___

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9545976ff160: Revert [Clang] Propagate guaranteed alignment for malloc and others (authored by jyknight). Repository: rG LLVM Github Monorepo

[clang] 9545976 - Revert "[Clang] Propagate guaranteed alignment for malloc and others"

Author: James Y Knight Date: 2022-02-08T14:34:44-05:00 New Revision: 9545976ff160e19805a84a06a7e59d446f9994d9 URL: https://github.com/llvm/llvm-project/commit/9545976ff160e19805a84a06a7e59d446f9994d9 DIFF:

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

aeubanks updated this revision to Diff 406908. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119215/new/ https://reviews.llvm.org/D119215 Files: clang/lib/CodeGen/CodeGenTypes.cpp

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

dblaikie added a comment. Yeah, looks like GCC believes `cxx11_pod::t1` to be C++03 POD even though it doesn't quite follow the letter of the standard - but since teh "= default" is an extension, I guess they get to define what that extension means. Here's an example: struct t1 { int i; };

[PATCH] D119051: Fix pod-packed functionality to use the C++11 definition of pod-ness

dblaikie updated this revision to Diff 406904. dblaikie added a comment. - Change the definition of C++03 POD to include defaulted functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files:

[PATCH] D119268: avoid the warning of assignment operation inside the if statement

phyBrackets created this revision. Herald added a subscriber: martong. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119268 Files:

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

eugenis added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware support (+memtag)">; + "'-fsanitize=memtag-stack' requires hardware support

[PATCH] D119166: [clang][ARM] Re-word PACBTI warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rG424e850f1ebc: [clang][ARM] Re-word PACBTI warning. (authored by amilendra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119166/new/

[clang] 424e850 - [clang][ARM] Re-word PACBTI warning.

Author: Amilendra Kodithuwakku Date: 2022-02-08T19:13:02Z New Revision: 424e850f1ebc3e7011cb4af44cb2d62c02a58fbe URL: https://github.com/llvm/llvm-project/commit/424e850f1ebc3e7011cb4af44cb2d62c02a58fbe DIFF:

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

MaskRay added a comment. In D118804#3304261 , @urnathan wrote: > While C2X has blessed such smaller alignments, the x86_64 ABI (in > particular), has not. However, using that ABI to justify 'It. Is. 16. > Bytes.', is really an exercise in reality

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

aganea added a comment. @krzysz00 I will revert and re-land with both fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119257/new/ https://reviews.llvm.org/D119257 ___ cfe-commits mailing list

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rG4ac58b61022d: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the… (authored by

[clang] 4ac58b6 - [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

Author: Leonard Chan Date: 2022-02-08T10:53:22-08:00 New Revision: 4ac58b61022d128d60ffea06c20611b8eaf8601a URL: https://github.com/llvm/llvm-project/commit/4ac58b61022d128d60ffea06c20611b8eaf8601a DIFF: https://github.com/llvm/llvm-project/commit/4ac58b61022d128d60ffea06c20611b8eaf8601a.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in ead1690d31f815c00fdd2bc23db4766191bbeabc , thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/

[clang] ead1690 - Allow parameter pack expansions and initializer lists in annotate attribute

Author: Steffen Larsen Date: 2022-02-08T13:38:07-05:00 New Revision: ead1690d31f815c00fdd2bc23db4766191bbeabc URL: https://github.com/llvm/llvm-project/commit/ead1690d31f815c00fdd2bc23db4766191bbeabc DIFF:

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. @kpyzhov Usually people don't accept without comment, especially if there is clearly ongoing discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

jdoerfert added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + sameerds wrote: > jdoerfert wrote: > > jdoerfert wrote: > > > sameerds wrote: > > > > jdoerfert wrote: > > > > > You can use AAPointerInfo

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds updated this revision to Diff 406889. sameerds added a comment. added tests for i128 load. hostcall position is now independent of subtarget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119216/new/ https://reviews.llvm.org/D119216

[PATCH] D118428: [clang-cl] Support the /JMC flag

hans added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:180 + "JMC instrument more than once?"); + FunctionCallee Fn = + M.getOrInsertFunction(CheckFunctionName, getCheckFunctionType(Ctx)); might as well get the

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

rjmccall added a comment. I'm not sure your new wording is any clearer; a In D118804#3304337 , @urnathan wrote: > In D118804#3304280 , @aaron.ballman > wrote: > >> In D118804#3304261

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

krzysz00 added a comment. @aganea Can we expect fixes for both the issues with this revision (the HIP-on-Windows problems noted last night and the MLIR breakage) shortly or should we revert while y'all work out fixes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

mehdi_amini added a comment. In D72404#3304205 , @aykevl wrote: > I would be very interested in this patch, because for me to use ThinLTO > without size regressions I need to set the optimization size level in the > linker

[PATCH] D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118862/new/ https://reviews.llvm.org/D118862

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

steven_wu added a comment. I just saw this. I know it is a good idea to have choice during link time for the pipeline configuration and from your benchmark it also has size impact on the output. I also feel like this is going in the wrong direction as if I have part of the object files built

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

rnk added a comment. Seems reasonable Comment at: clang/lib/CodeGen/CodeGenTypes.cpp:776 + auto *C = MPTy->getClass(); + auto I = RecordsWithOpaqueMemberPointers.find(C); + if (I == RecordsWithOpaqueMemberPointers.end()) { Can this use something

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you for all the good discussion and work on this! I'll commit on your behalf once the precommit CI pipeline comes back green. CHANGES SINCE LAST ACTION

[PATCH] D119201: [clang][Fuchsia] Ensure static sanitizer libs are only linked in after the -nostdlib check

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:158-160 +bool NeedsXRayDeps = addXRayRuntime(ToolChain, Args, CmdArgs); if (NeedsXRayDeps)

  1   2   3   >