[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay updated this revision to Diff 411016. MaskRay marked an inline comment as done. MaskRay added a comment. Explain pie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 Files: clang/CMakeLists.txt

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD added a comment. Friendly ping @VincentWu ;) Any comments to the latest response? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/ https://reviews.llvm.org/D119530 ___ cfe-commits mailing

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

eopXD updated this revision to Diff 411014. eopXD added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119530/new/

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:180 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPassThru = false; eopXD wrote: > Nit: V-spec prefers to call instructions without masking operands

[PATCH] D117989: [RISCV] Add the passthru operand for RVV nomask binary intrinsics.

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:180 + // The nomask intrinsic IR have the passthru operand. + bit HasNoMaskPassThru = false; Nit: V-spec prefers to call instructions without masking operands "unmasked

[PATCH] D120297: [Driver][RISCV] Add missing rv64 test case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b62f19f27d4: [Driver][RISCV] Add missing rv64 test case (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8b62f19 - [Driver][RISCV] Add missing rv64 test case

Author: eopXD Date: 2022-02-23T22:53:42-08:00 New Revision: 8b62f19f27d4152e2ba0e329261fbe2a964f9950 URL: https://github.com/llvm/llvm-project/commit/8b62f19f27d4152e2ba0e329261fbe2a964f9950 DIFF: https://github.com/llvm/llvm-project/commit/8b62f19f27d4152e2ba0e329261fbe2a964f9950.diff LOG:

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

fakepaper56 closed this revision. fakepaper56 added a comment. Herald added subscribers: pcwang-thead, eopXD. The patch content is in D119727 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117199/new/

[PATCH] D120454: clang/www: Add links to tracking issues for C++20 features

tstellar created this revision. tstellar requested review of this revision. Herald added a project: clang. Also add some javascript to automatically change that status to "In Progress" when the issue is assigned to someone, and "Clang ToT" when the issue is closed. Note that the feature entries

[PATCH] D120310: [clang][analyzer] Add modeling of 'errno' (work-in-progress).

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:767-768 s->getType()->isBlockPointerType()); -assert(isa(sreg) || isa(sreg)); +assert(isa(sreg) || isa(sreg) || + isa(sreg)); }

[clang] 9d899d8 - [HIP] Support `-fgpu-default-stream`

Author: Yaxun (Sam) Liu Date: 2022-02-23T22:28:29-05:00 New Revision: 9d899d8f01872e91b9909a6ee5937a796a399276 URL: https://github.com/llvm/llvm-project/commit/9d899d8f01872e91b9909a6ee5937a796a399276 DIFF:

[PATCH] D120298: [HIP] Support `-fgpu-default-stream`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d899d8f0187: [HIP] Support `-fgpu-default-stream` (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/ https://reviews.llvm.org/D117740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

arcbbb created this revision. arcbbb added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, monkchiang, eopXD, khchen. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:531-532 + DriverArgs.hasArg(options::OPT_nostdlibinc)) { +CC1Args.push_back("-internal-isystem"); +CC1Args.push_back(HipIncludePath); + } tra wrote: > yaxunl wrote: >

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

MTC added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-non-const-parameter.cpp:293 + // CHECK-MESSAGES-NOT: warning: pointer parameter 'p' can be + int = *p; +} Sockke wrote: > MTC wrote: > > @Sockke Could you please

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

Sockke added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-non-const-parameter.cpp:293 + // CHECK-MESSAGES-NOT: warning: pointer parameter 'p' can be + int = *p; +} MTC wrote: > @Sockke Could you please add the

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

MTC added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-non-const-parameter.cpp:293 + // CHECK-MESSAGES-NOT: warning: pointer parameter 'p' can be + int = *p; +} @Sockke Could you please add the following tests? ```

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6067 + if (VPtr) { +VOpVal = {VPtr, VPtr->getType()->getPointerElementType(), + V->getType().isVolatileQualified(),

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 410986. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/

[PATCH] D120445: [clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

penagos created this revision. penagos added reviewers: curdeius, MyDeveloperDay. penagos published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/44544. Repository: rG LLVM Github Monorepo

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

aminya added a comment. Clang-tidy is very slow if you use it on a medium or large project. Something like this feature, even if it is not perfect, will definitely improve the experience with clang-tidy. The low performance of clang-tidy is one of the biggest frictions for using it.

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119004/new/ https://reviews.llvm.org/D119004 ___ cfe-commits mailing list

[PATCH] D120394: [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections for ELF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0477cac332d5: [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections… (authored by MaskRay). Changed prior to commit:

[clang] 0477cac - [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections for ELF

Author: Fangrui Song Date: 2022-02-23T16:08:25-08:00 New Revision: 0477cac332d5abf7b2b51b470370afcbb1e8d513 URL: https://github.com/llvm/llvm-project/commit/0477cac332d5abf7b2b51b470370afcbb1e8d513 DIFF: https://github.com/llvm/llvm-project/commit/0477cac332d5abf7b2b51b470370afcbb1e8d513.diff

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

xazax.hun added a comment. In D120289#3341008 , @sgatev wrote: > it seems tailored to the Z3 API. As far as I understand, there were downstream patches that used the same API with other SMT solvers. The authors did not upstream it because they did not

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. Actually, I did it myself in 34285bcd5ac260246c9d59708a63ea3d5972f75c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 34285bc - Reland "unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after 32b73bc6ab82"

Author: Nico Weber Date: 2022-02-23T18:41:20-05:00 New Revision: 34285bcd5ac260246c9d59708a63ea3d5972f75c URL: https://github.com/llvm/llvm-project/commit/34285bcd5ac260246c9d59708a63ea3d5972f75c DIFF: https://github.com/llvm/llvm-project/commit/34285bcd5ac260246c9d59708a63ea3d5972f75c.diff

[PATCH] D120132: [HIP] Fix HIP include path

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:531-532 + DriverArgs.hasArg(options::OPT_nostdlibinc)) { +CC1Args.push_back("-internal-isystem"); +CC1Args.push_back(HipIncludePath); + } yaxunl wrote: > tra wrote: > >

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

thakis added a comment. In D109239#3331917 , @zahiraam wrote: > In D109239#3331914 , @thakis wrote: > >> Thank you for reverting my follow-up as well! >> >> zahiraam, for the reland please include that follow-up

[PATCH] D120132: [HIP] Fix HIP include path

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:531-532 + DriverArgs.hasArg(options::OPT_nostdlibinc)) { +CC1Args.push_back("-internal-isystem"); +CC1Args.push_back(HipIncludePath); + } tra wrote: > yaxunl wrote: >

[PATCH] D120298: [HIP] Support `-fgpu-default-stream`

yaxunl added a comment. In D120298#3341250 , @tra wrote: > LGTM with a minor nit. > >> Also -DHIP_API_PER_THREAD_DEFAULT_STREAM is passed to clang -cc1 to enable >> other per-thread stream > > You may want to rephrase patch description it a bit to match

[PATCH] D120383: [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18fa0b15ccf6: [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain. NFC. (authored by vvereschaka). Repository: rG LLVM Github

[clang] 18fa0b1 - [CMake] Use CMAKE_SYSROOT to build libs for Win to ARM cross tooolchain. NFC.

Author: Vladimir Vereschaka Date: 2022-02-23T15:16:56-08:00 New Revision: 18fa0b15ccf610f34af1231440f89d20cb99e7a0 URL: https://github.com/llvm/llvm-project/commit/18fa0b15ccf610f34af1231440f89d20cb99e7a0 DIFF:

[clang] 119d71c - [OpenMP][NFC] Address warnings and lint messages in CGOpenMPRuntime

Author: Joseph Huber Date: 2022-02-23T18:07:25-05:00 New Revision: 119d71cb73a888a57b368cb5c74ac8ac07fb5c32 URL: https://github.com/llvm/llvm-project/commit/119d71cb73a888a57b368cb5c74ac8ac07fb5c32 DIFF: https://github.com/llvm/llvm-project/commit/119d71cb73a888a57b368cb5c74ac8ac07fb5c32.diff

[PATCH] D117611: [Sema] Warn about printf %n on Android and Fuchsia

enh added a comment. In D117611#3339137 , @glandium wrote: > This doesn't leave much room to use `__attribute__((format(printf)))` on > custom printf implementations that do support `%n` on Android does it? it would be pretty hard to get into that

[clang] 1592d88 - Add support for floating-point option `ffp-eval-method` and for

Author: Zahira Ammarguellat Date: 2022-02-23T15:00:18-08:00 New Revision: 1592d88aa7bc13c9f53cf09d25b98e7318a57bfb URL: https://github.com/llvm/llvm-project/commit/1592d88aa7bc13c9f53cf09d25b98e7318a57bfb DIFF:

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 added a comment. In D119061#3340884 , @kuhar wrote: > LGTM but please get at least one additional approval before submitting Thank you. Yeah, I would like to get lgtm from @aaron.ballman here :) CHANGES SINCE LAST ACTION

[clang] dcc4feb - Use function prototypes when appropriate; NFC

Author: Aaron Ballman Date: 2022-02-23T17:12:25-05:00 New Revision: dcc4feb9a49ab88e892dd626ebb0a69ff5a8dc42 URL: https://github.com/llvm/llvm-project/commit/dcc4feb9a49ab88e892dd626ebb0a69ff5a8dc42 DIFF: https://github.com/llvm/llvm-project/commit/dcc4feb9a49ab88e892dd626ebb0a69ff5a8dc42.diff

[clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

Author: Reid Kleckner Date: 2022-02-23T14:07:04-08:00 New Revision: 1d1b089c5d503e2fc8697887411730105f66c774 URL: https://github.com/llvm/llvm-project/commit/1d1b089c5d503e2fc8697887411730105f66c774 DIFF: https://github.com/llvm/llvm-project/commit/1d1b089c5d503e2fc8697887411730105f66c774.diff

[clang] cd37594 - Fix unused lambda capture warning, NFC

Author: Reid Kleckner Date: 2022-02-23T14:01:01-08:00 New Revision: cd37594c0374f287318d47818cc6d55496d3e9c0 URL: https://github.com/llvm/llvm-project/commit/cd37594c0374f287318d47818cc6d55496d3e9c0 DIFF: https://github.com/llvm/llvm-project/commit/cd37594c0374f287318d47818cc6d55496d3e9c0.diff

[PATCH] D119157: [NVPTX] Add ex2 f16 support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69a8350c232a: [NVPTX] Add ex2.approx.f16/f16x2 support (authored by npmiller, committed by tra). Changed prior to commit:

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe672934ff88: [NVPTX] Add more FMA intriniscs/builtins (authored by jchlanda, committed by tra). Changed prior to commit:

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0dc4ac28f00: [NVPTX] Expose float tys min, max, abs, neg as builtins (authored by jchlanda, committed by tra). Changed prior to commit:

[clang] 0c1fd90 - [Clang][Docs] Add '-fopenmp-offload-mandatory' to command line reference

Author: Joseph Huber Date: 2022-02-23T16:54:01-05:00 New Revision: 0c1fd90fe0828aa87518d9be542bd00d36d258d7 URL: https://github.com/llvm/llvm-project/commit/0c1fd90fe0828aa87518d9be542bd00d36d258d7 DIFF: https://github.com/llvm/llvm-project/commit/0c1fd90fe0828aa87518d9be542bd00d36d258d7.diff

[PATCH] D120323: [clang][SVE] Add support for arithmetic operators on SVE types

efriedma added a comment. Is there a corresponding ARM specification update for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120323/new/ https://reviews.llvm.org/D120323 ___ cfe-commits mailing

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b97b16f294a: [OpenMP] Add option to make offloading mandatory (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2b97b16 - [OpenMP] Add option to make offloading mandatory

Author: Joseph Huber Date: 2022-02-23T16:45:36-05:00 New Revision: 2b97b16f294af91281d8a138759f3f772952a902 URL: https://github.com/llvm/llvm-project/commit/2b97b16f294af91281d8a138759f3f772952a902 DIFF: https://github.com/llvm/llvm-project/commit/2b97b16f294af91281d8a138759f3f772952a902.diff

[clang] 4cb24ef - [clang] Remove Address::deprecated() from CGClass.cpp

Author: Arthur Eubanks Date: 2022-02-23T13:31:56-08:00 New Revision: 4cb24ef90a691489f22a36976a1b33acd65901fa URL: https://github.com/llvm/llvm-project/commit/4cb24ef90a691489f22a36976a1b33acd65901fa DIFF:

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

erichkeane added a comment. In D120266#3341378 , @ibookstein wrote: > Yeah, that's what happens with this patch; Reference binds against an > `llvm::Function` declaration, linker resolves it to the actual ifunc in > another translation unit and

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray marked an inline comment as done. lichray added a comment. In D113393#3340878 , @aaron.ballman wrote: > I spotted some test coverage that I think we should add: > > static_cast(whatever); > reinterpret_cast(whatever); >

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

ibookstein added a comment. Yeah, that's what happens with this patch; Reference binds against an `llvm::Function` declaration, linker resolves it to the actual ifunc in another translation unit and therefore emits IFUNC relocation. Thinking about it more, this is inelegant. I would have liked

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 updated this revision to Diff 410919. jhuber6 added a comment. Guarding where we set attrs in the case that it's not a valid function now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/ https://reviews.llvm.org/D120353 Files:

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray updated this revision to Diff 410915. lichray added a comment. - Add more tests to diagnose other forms of casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 Files:

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

aaron.ballman added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:119 +++End; + return llvm::makeArrayRef([Start], [End]); +} hokein wrote: > aaron.ballman wrote: > > This is causing an assertion with debug builds on Windows

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein added inline comments. Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:119 +++End; + return llvm::makeArrayRef([Start], [End]); +} aaron.ballman wrote: > This is causing an assertion with debug builds on Windows because > `Actions[End]` is

[clang] 302ca27 - [pseudo] fix an out-of-bound error in LRTable.

Author: Haojian Wu Date: 2022-02-23T21:34:54+01:00 New Revision: 302ca279cb83043ef7d60115eb5ba58f12064a4a URL: https://github.com/llvm/llvm-project/commit/302ca279cb83043ef7d60115eb5ba58f12064a4a DIFF: https://github.com/llvm/llvm-project/commit/302ca279cb83043ef7d60115eb5ba58f12064a4a.diff

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

li.zhe.hua marked an inline comment as done. li.zhe.hua added a comment. In D120360#3341118 , @ymandel wrote: > High level question: why use `Any` rather than templating? (Aside: Not sure how to "respond" to comments... just quote in a new comment?)

[PATCH] D120298: [HIP] Support `-fgpu-default-stream`

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a minor nit. > Also -DHIP_API_PER_THREAD_DEFAULT_STREAM is passed to clang -cc1 to enable > other per-thread stream You may want to rephrase patch description it a bit to match the

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

aaron.ballman added a comment. In D118196#3341159 , @hokein wrote: > In D118196#3341110 , @aaron.ballman > wrote: > >> Hi, this commit is causing runtime failures on Windows in debug builds. Can >> you please

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a comment. Ah, one more thing I missed -- you should add a release note for this functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120159/new/ https://reviews.llvm.org/D120159

[PATCH] D120159: [Clang] Implement __builtin_source_location.

aaron.ballman added a comment. Thank you for this! I've got some initial comments on it. Btw, I think there may be some functionality missing for AST dumping, so I'd like to see some additional tests for that. Comment at: clang/docs/LanguageExtensions.rst:3343-3344 +defined,

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

li.zhe.hua updated this revision to Diff 410907. li.zhe.hua added a comment. Update alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120360/new/ https://reviews.llvm.org/D120360 Files:

[PATCH] D120132: [HIP] Fix HIP include path

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:531-532 + DriverArgs.hasArg(options::OPT_nostdlibinc)) { +CC1Args.push_back("-internal-isystem"); +CC1Args.push_back(HipIncludePath); + } yaxunl wrote: > tra wrote: > >

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks updated this revision to Diff 410904. HazardyKnusperkeks added a comment. Corrected diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120359/new/ https://reviews.llvm.org/D120359 Files: clang/unittests/Format/TokenAnnotatorTest.cpp Index:

[PATCH] D120426: [Sema] Mark the referenced destructor during transformation of a `CXXBindTemporaryExpr`

akyrtzi created this revision. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Otherwise we will fail to generate the definition of a defaulted destructor, if the only reference was in a templated temporary. rdar://89366678

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

hokein added a comment. In D118196#3341110 , @aaron.ballman wrote: > Hi, this commit is causing runtime failures on Windows in debug builds. Can > you please correct or revert? Thanks! sorry for the trouble. I'm mostly running out of time today, I

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

durin42 updated this revision to Diff 410896. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/alloc-align-attr.c

[PATCH] D120416: [clangd] Function return type hints: support lambdas, don't duplicate "->"

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:626 +auto f4() -> auto* { return "foo"; } + // `auto` conversion operator Should there be a test for `void` too or does it just work? Repository: rG

[PATCH] D120361: [clang-format] Extract doc for entire configuration structs

HazardyKnusperkeks added a comment. Seems to be correct, but I have not enough knowledge about the python or rst stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120361/new/ https://reviews.llvm.org/D120361

[PATCH] D120391: [Driver] Add -fno-sanitize-address-globals-dead-stripping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe87c32e390bb: [Driver] Add -fno-sanitize-address-globals-dead-stripping (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] e87c32e - [Driver] Add -fno-sanitize-address-globals-dead-stripping

Author: Fangrui Song Date: 2022-02-23T11:51:30-08:00 New Revision: e87c32e390bb812d9390d3df39357409d073ac3f URL: https://github.com/llvm/llvm-project/commit/e87c32e390bb812d9390d3df39357409d073ac3f DIFF: https://github.com/llvm/llvm-project/commit/e87c32e390bb812d9390d3df39357409d073ac3f.diff

[PATCH] D120416: [clangd] Function return type hints: support lambdas, don't duplicate "->"

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:539 + // Lambda return hint shown even if no param list. + assertTypeHints("auto $L[[x]] =

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

HazardyKnusperkeks added a comment. In D120359#3339638 , @curdeius wrote: > I don't really understand this change. You say in the description that you > remove the semicolon, but you actually add it. > Also, it's a common pattern not to add a semicolon

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

ymandel added a comment. High level question: why use `Any` rather than templating? Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:68 +using AnyGenerator2 = std::shared_ptr>; + li.zhe.hua wrote: > Placeholder name; suggestions welcome.

[PATCH] D118196: [syntax][pseudo] Implement LR parsing table.

aaron.ballman added a comment. Hi, this commit is causing runtime failures on Windows in debug builds. Can you please correct or revert? Thanks! Comment at: clang/lib/Tooling/Syntax/Pseudo/LRTable.cpp:119 +++End; + return llvm::makeArrayRef([Start], [End]); +}

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120258/new/ https://reviews.llvm.org/D120258

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

aaron.ballman added a comment. Mostly small nits, but it looks like precommit CI is failing due to the changes: Failed Tests (2): Clang Tools :: clang-tidy/checkers/bugprone-signal-handler-minimal.c Clang Tools :: clang-tidy/checkers/bugprone-signal-handler-posix.c

[PATCH] D120289: [clang][dataflow] Add SAT solver interface and implementation

sgatev added a comment. In D120289#3338262 , @xazax.hun wrote: > In D120289#3338244 , @sgatev wrote: > >>> I wonder if it would make sense to have a SAT base class for the SMT API >>> and reuse that here? >> >>

[PATCH] D120394: [asan] Allow -fsanitize-address-globals-dead-stripping with -fno-data-sections for ELF

kstoimenov accepted this revision. kstoimenov added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120394/new/ https://reviews.llvm.org/D120394 ___ cfe-commits mailing list

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

craig.topper added a comment. In D120395#3340891 , @andrew.w.kaylor wrote: > In D120395#3340496 , @pengfei wrote: > >> Update LangRef. We use `i16` type to represent bfloat16. > > Why are we using i16 to

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

mwyman updated this revision to Diff 410863. mwyman added a comment. Added new inner scope for test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120372/new/ https://reviews.llvm.org/D120372 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

andrew.w.kaylor added a comment. In D120395#3340496 , @pengfei wrote: > Update LangRef. We use `i16` type to represent bfloat16. Why are we using i16 to represent bfloat16? The bfloat type is better. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119061: [Clang] noinline call site attribute

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. LGTM put please get at least one additional approval before submitting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

aaron.ballman added a comment. I spotted some test coverage that I think we should add: static_cast(whatever); reinterpret_cast(whatever); const_cast(whatever); dynamic_cast(whatever); (auto)whatever; I believe all of those should be rejected because of

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. @fhahn I think the last commit fixes the issue. I am currently testing it on MacOS 10.14 and it is still going (slow remote machine). I would like to get your permission to push this patch now. It will probably be faster to confirm that the patch fixes the issue

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3340863 , @JonChesterfield wrote: > Thanks! Seems a good thing to add to the offloading test runner, preferably > in a separate change to avoid reverting this in case of unforeseen problems Could definitely do that,

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

JonChesterfield added a comment. Thanks! Seems a good thing to add to the offloading test runner, preferably in a separate change to avoid reverting this in case of unforeseen problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/

[PATCH] D120391: [Driver] Add -fno-sanitize-address-globals-dead-stripping

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. LGTM. But please wait for LTGM from vitalybuka@. Also there is internal asan-globals-live-support flag if you need it before this one lands. Repository: rG LLVM Github Monorepo

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. In D119479#3339220 , @MaskRay wrote: > There is a circular dependency if you use `-DBUILD_SHARED_LIBS=on`: > > CMake Error: The inter-target dependency graph contains the following > strongly connected component (cycle): >

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Trass3r added a comment. In D120258#3340717 , @sammccall wrote: > (I think this patch is good to go now, ready for a stamp if anyone agrees > :-)). I agree. There's still D120258#3336114 but I don't have the

[PATCH] D119361: [clang] Rename missing-declarations to useless-declarations

aaron.ballman added reviewers: rsmith, rjmccall, jyknight. aaron.ballman added a subscriber: cfe-commits. aaron.ballman added a comment. Thank you for this, but I'd like to get a better understanding of the long-term goals here (and where we diverge from GCC in terms of some code examples).

[clang] 6eec483 - [clang] Remove getPointerElementType() in EmitVTableTypeCheckedLoad()

Author: Arthur Eubanks Date: 2022-02-23T09:38:33-08:00 New Revision: 6eec4835844439ab932515ff4ac857773c639171 URL: https://github.com/llvm/llvm-project/commit/6eec4835844439ab932515ff4ac857773c639171 DIFF:

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/ https://reviews.llvm.org/D120353

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 added a comment. In D120353#3340775 , @ABataev wrote: > I assume it would be good to notify the user somehow about target regions, > which may require execution on the host. Maybe add a note during the codegen > phase? Technically all of them

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

ABataev added a comment. I assume it would be good to notify the user somehow about target regions, which may require execution on the host. Maybe add a note during the codegen phase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

erichkeane added a comment. Please add all the context (see https://llvm.org/docs/Phabricator.html). Also, I'd like to see some level of negative tests. Finally, I'll have to evaluate how this works with the delayed concepts build. I don't see this as making it into Clang-14, we are pretty

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

jhuber6 updated this revision to Diff 410851. jhuber6 added a comment. Adding test function with device clause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120353/new/ https://reviews.llvm.org/D120353 Files:

[PATCH] D120262: [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

arkangath added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:1183 + SmallVector ExtVec; + TypeExt.split(ExtVec, " "); + for (const auto Ext : ExtVec) { svenvh wrote: > arkangath wrote: > > Just in case if

[PATCH] D120353: [OpenMP] Add option to make offloading mandatory

ABataev added a comment. In D120353#3340749 , @jhuber6 wrote: > In D120353#3340744 , @ABataev wrote: > >> Could you add a test with the device clause too? > > Which clause exactly? `device(device_id)`

  1   2   3   >