[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker marked an inline comment as done. SAtacker added a comment. Gentle reminder @JonasToth @alexfh @aaron.ballman @njames93 @LegalizeAdulthood Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120331/new/

[PATCH] D121465: WIP: [clang][modules] Do not report declarations without linkage as ambiguous

vsapsai added a comment. My concern with this approach is I'm not sure if `isEquivalentInternalLinkageDeclaration` is a desired long-term solution for anonymous C++ enums. If it is, we can piggy-back on it, otherwise hitching our wagon to this train might be undesirable. Also I need to check

[PATCH] D111400: [Clang] Implement P2242R3

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2b.cpp:101 + + auto b = [](int n) constexpr { +if (!n) I think a lambda marked `constexpr` and one that isn't has fundamental differences in behaviour in

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

vsapsai added a comment. Sorry, I'm pretty ignorant in this area but based on > The job construction is altered to build a C++20 header unit (rather than a > PCH file, as would be the case for other headers). I want to clarify. The goal is to allow mixing PCH and PCM files, right? I haven't

[PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham added a comment. In D121425#3384492 , @dexonsmith wrote: > Can you be more detailed about the overall state at the time of `cat`, which > causes it to fail? Sure. I think there's also some confusion with names here but I'm generally trying

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

lkail updated this revision to Diff 415684. lkail added a comment. Fix typo; Add `pwr7` and `pwr8` as `-target-cpu`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441 Files:

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

pcwang-thead commandeered this revision. pcwang-thead edited reviewers, added: zixuan-wu; removed: pcwang-thead. pcwang-thead added a comment. Herald added a subscriber: arichardson. Herald added a project: All. In D70401#3250049 , @khchen wrote: > 1.

[PATCH] D121765: [CUDA][HIP] Fix hostness check with -fopenmp

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: carlosgalvezp, guansong. Herald added a project: All. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CUDA/HIP determines whether a function can

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415677. zhouyizhou edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-noexcept.cpp Index:

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a subscriber: rsmith. ChuanqiXu added a comment. @rsmith told me that the ideal situation would combine C++20 modules and clang modules together in D113391 I think the most important thing here is to get in consensus for the module status.

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall added a comment. Trolling for reviewers: @hokein: this is another -10 lines per test suite! @thakis: the GN changes seem trivial (no standalone build) but wonder if you have opinions @mgorny: because I don't truly understand the standalone build, and only hope I'm getting this right

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall updated this revision to Diff 415672. sammccall added a comment. add gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121763/new/ https://reviews.llvm.org/D121763 Files: clang-tools-extra/clangd/test/CMakeLists.txt

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall created this revision. sammccall added reviewers: hokein, thakis, mgorny. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers:

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

yonghong-song added inline comments. Comment at: clang/test/Sema/warn-unused-but-set-variables.c:66 + for (int i = 0; i < 1000; i++) +j += 1; + return; efriedma wrote: > The handling of this testcase without your patch seems fine. Even if the > value of

[PATCH] D121715: [Clang] Fix an unused-but-set-variable warning with volatile variable

yonghong-song updated this revision to Diff 415665. yonghong-song retitled this revision from "[Clang] Fix an unused-but-set-variable warning with compond assignment" to "[Clang] Fix an unused-but-set-variable warning with volatile variable". yonghong-song edited the summary of this revision.

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

ChuanqiXu added a comment. In D121098#3383835 , @iains wrote: >> I am a little bit confused for the intuition. Couldn't we just import the >> pre-processed header? What's the problem? Could you elaborate on this? > > We cannot import a pre-processed

[clang-tools-extra] e4cab4e - [lit] Remove clang_libs_dir

Author: Sam McCall Date: 2022-03-16T03:03:02+01:00 New Revision: e4cab4e24d17e4a434d0edd6d7d037f0d05ced36 URL: https://github.com/llvm/llvm-project/commit/e4cab4e24d17e4a434d0edd6d7d037f0d05ced36 DIFF: https://github.com/llvm/llvm-project/commit/e4cab4e24d17e4a434d0edd6d7d037f0d05ced36.diff

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. Hi @aaron.ballman @erichkeane, I have already left a comment in GCC's Bugzilla, but unfortunately there's been no response for almost a week. I'm even not sure there's really a bug fix for GCC or not. Can you guys decide how to deal with this issue? Repository: rG

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall added a comment. In D121233#3384495 , @thakis wrote: > Is there a reason why this can't be part of clang-tools-extra/test This was discussed pretty extensively in the review above. Other projects across LLVM use

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 415658. zixuw added a comment. - Address reviews - Add and handle unconditionally unavailable - Delete the default constructor of `APIRecord` - Make `APIRecord` abstract for LLVM RTTI - Improve `getFormattedText` and `getFormattedLines` - Fix wordings

[PATCH] D120959: [clang][AST matchers] new hasExpectedReturnType submatcher for ReturnStmts

ajohnson-uoregon added a comment. This is our use case: https://github.com/ajohnson-uoregon/llvm-project/blob/feature-ajohnson/clang-tools-extra/clang-rewrite/MatcherGenCallback.h#L365 I'm not sure if anyone else would want to use this, but it feels like it could be generally useful. Now that

[PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

dexonsmith added a comment. In D121425#3384479 , @bnbarham wrote: > In D121425#3384188 , @bnbarham > wrote: > >> There's two failing tests with this change: >> >> - VFSFromYAMLTest.ReturnsExternalPathVFSHit >> -

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415655. zhouyizhou edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-deduction.cpp Index:

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

thakis added a comment. Is there a reason why this can't be part of clang-tools-extra/test and check-clang-tools? Why is this in a directory called "pseudo" instead of "clang-pseudo"? This makes everything fairly self-inconsistent (`pseudo/tool` vs `clang-pseudo` in there, but then also

[PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

dexonsmith added a comment. In D121425#3384188 , @bnbarham wrote: > There's two failing tests with this change: > > - VFSFromYAMLTest.ReturnsExternalPathVFSHit > - VFSFromYAMLTest.ReturnsInternalPathVFSHit > > Apparently we allow relative paths in

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. It looks like all tests succeed for `x64 debian`: https://buildkite.com/llvm-project/premerge-checks/builds/83802#c5002be5-e01c-46fc-a767-50fe6f854465 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121736/new/

[PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham added a comment. In D121425#3384188 , @bnbarham wrote: > There's two failing tests with this change: > > - VFSFromYAMLTest.ReturnsExternalPathVFSHit > - VFSFromYAMLTest.ReturnsInternalPathVFSHit > > Apparently we allow relative paths in

[PATCH] D120956: [clang][AST matchers] new AST matcher argumentsGivenCountIs(n) that checks the actual number of arguments given in a function call

ajohnson-uoregon added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4452 +/// \endcode +AST_POLYMORPHIC_MATCHER_P(argumentsGivenCountIs, + AST_POLYMORPHIC_SUPPORTED_TYPES( aaron.ballman wrote: > I have a

[clang-tools-extra] 89cd86b - Reapply [pseudo] Move pseudoparser from clang to clang-tools-extra"

Author: Sam McCall Date: 2022-03-16T01:10:55+01:00 New Revision: 89cd86bbc58afe7d036bdb2f656dca38b62d8ef0 URL: https://github.com/llvm/llvm-project/commit/89cd86bbc58afe7d036bdb2f656dca38b62d8ef0 DIFF: https://github.com/llvm/llvm-project/commit/89cd86bbc58afe7d036bdb2f656dca38b62d8ef0.diff

[PATCH] D120956: [clang][AST matchers] new AST matcher argumentsGivenCountIs(n) that checks the actual number of arguments given in a function call

ajohnson-uoregon added a comment. This is the same use case as my other patches :) https://github.com/ajohnson-uoregon/llvm-project/blob/feature-ajohnson/clang-tools-extra/clang-rewrite/ConstructMatchers.cpp#L545 If there's a function with default arguments, and our user doesn't specify some

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall added a comment. Ah I see what happened - there was one incorrect (and unneeded) dependency left behind, which caused tests to fail if you *didn't* have clang-tools-extra enabled. Relanding... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

Sorry, this broke the world and I wasn't watching it carefully enough. Reverted in 049f4e4eab19c6e468e029232e94ca71245b0f56, trying to work out why the tests passed locally. On Wed, Mar 16, 2022 at 12:48 AM Ron Lieberman via Phabricator < revi...@reviews.llvm.org> wrote: > ronlieb added a

[clang] 049f4e4 - Revert "[pseudo] Move pseudoparser from clang to clang-tools-extra"

Author: Sam McCall Date: 2022-03-16T01:06:24+01:00 New Revision: 049f4e4eab19c6e468e029232e94ca71245b0f56 URL: https://github.com/llvm/llvm-project/commit/049f4e4eab19c6e468e029232e94ca71245b0f56 DIFF: https://github.com/llvm/llvm-project/commit/049f4e4eab19c6e468e029232e94ca71245b0f56.diff

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song updated this revision to Diff 415638. yonghong-song added a comment. - change TransformBTFTagAttributedType() implementation with a simple llvm_unreachable() message. I tested linux kernel and its selftests/bpf compilation with clang and found the only TreeTransformation function

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

arphaman added a comment. Is there a way this can be tested from Clang? Also, is there a Swift-based test case you have that demonstrates the original problem from Swift's clang importer side? I'm curious to see where it manifests in Swift. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:534 continue; - parseBlock(/*MustBeDeclaration=*/false, /*AddLevels=*/1u, - /*MunchSemi=*/true, /*UnindentWhitesmithBraces=*/false, -

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

ronlieb added a comment. Hi Sam i think this breaks our amdgpu buildbot https://lab.llvm.org/buildbot/#/builders/193/builds/8513 any suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121233/new/ https://reviews.llvm.org/D121233

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s | \ I am not sure about having a

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

sstwcw added a subscriber: svenvh. sstwcw added a comment. Do we have people who use Verilog and knows the clang-format code base? @svenvh Your email address looks like you work for a hardware company. If you know Verilog would you please have a look at this patch? Repository: rG LLVM

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

iamsergio added a comment. Herald added a subscriber: usaxena95. Herald added a project: All. I don't think we need to worry about formatting, that's the IDE's job (and whatever formatter it uses). In general, the code that knows how to warn should also be the one that knows how to fix it, this

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:2-6 +// RUN: %clang_cc1 -verify -triple powerpc-unkonwn-unknown -emit-llvm -o - %s | \ +// RUN: FileCheck %s --check-prefixes=PPC,PPC32 +// RUN: %clang_cc1 -verify -triple

[PATCH] D121756: [clang-format] Clean up code looking for if statements

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously several places had code to determine

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

sstwcw created this revision. sstwcw added a reviewer: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After all these years, having the two functions now serves to confuse people.

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was some duplicate code in

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

ajohnson-uoregon added a comment. For the specific argument matchers (`cudaBlockDim()`, `cudaStream()`, etc), I agree, I'm not sure if there's any other use cases in tree. I wasn't aware you could write local definitions like that, I could definitely do that within my project for those. I

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

sstwcw created this revision. sstwcw added a reviewer: clang-format. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We had to add a bunch of keywords for a new

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

sstwcw added a comment. Yes. I probably forgot to generate the doc. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121749/new/ https://reviews.llvm.org/D121749 ___ cfe-commits mailing list

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

vitalybuka accepted this revision. vitalybuka added a comment. Herald added a project: All. @eugenis I will prepare google3 and land it? Comment at: clang/lib/CodeGen/CGClass.cpp:1872 // Ignore trivial destructors. + if (BaseClassDecl->hasTrivialDestructor()) {

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 415622. jhuber6 added a comment. Fix wrong condition for picking up input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/ https://reviews.llvm.org/D120272 Files: clang/include/clang/Basic/Cuda.h

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb97856c4cfe7: [pseudo] Move pseudoparser from clang to clang-tools-extra (authored by sammccall). Changed prior to commit:

[clang-tools-extra] b97856c - [pseudo] Move pseudoparser from clang to clang-tools-extra

Author: Sam McCall Date: 2022-03-16T00:14:11+01:00 New Revision: b97856c4cfe7efb13887d5691002a7aa38440924 URL: https://github.com/llvm/llvm-project/commit/b97856c4cfe7efb13887d5691002a7aa38440924 DIFF: https://github.com/llvm/llvm-project/commit/b97856c4cfe7efb13887d5691002a7aa38440924.diff

[PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham added a comment. There's two failing tests with this change: - VFSFromYAMLTest.ReturnsExternalPathVFSHit - VFSFromYAMLTest.ReturnsInternalPathVFSHit Apparently we allow relative paths in external-contents *without* specifying `overlay-relative: true`. In this case the relative paths

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall updated this revision to Diff 415619. sammccall marked 4 inline comments as done. sammccall added a comment. Rebase and restore conventional test/Unit suite Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121233/new/

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

kuzkry added a comment. @sstwcw, I think you must have forgotten to regenerate the rst file :) I added you as a reviewer to this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121749/new/ https://reviews.llvm.org/D121749

[PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham marked an inline comment as done. bnbarham added a comment. Merged into D121425 instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121426/new/ https://reviews.llvm.org/D121426

[PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

bnbarham updated this revision to Diff 415615. bnbarham edited the summary of this revision. bnbarham added a comment. Herald added subscribers: cfe-commits, lldb-commits, carlosgalvezp. Herald added projects: clang, LLDB, clang-tools-extra. Re-order to be before D121424

[PATCH] D121749: [clang-format][docs] Regenerate ClangFormatStyleOptions.rst

kuzkry created this revision. kuzkry added reviewers: sstwcw, MyDeveloperDay. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Misalignment of

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

bulbazord added a comment. I'm not quite sure the best way to test this. Looks like `Sema::LookupName` isn't currently directly tested. I've run the test suite and did not find any new failing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName

bulbazord created this revision. bulbazord added a reviewer: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: clang. `Sema::LookupName` essentially has two possible code paths based on what language is currently being used. The predicate

[PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a reviewer: bollu. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou updated this revision to Diff 415601. zhouyizhou edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 Files: clang/lib/AST/Type.cpp clang/test/SemaTemplate/class-template-deduction.cpp Index:

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

Trass3r added a comment. Hmm just a few curious questions from the sidelines. Why a "custom system" instead of something -ftime-trace based? How much overhead does this introduce, esp. for normal use-cases? What's the gain? The information is very coarse and general-purpose system profiling

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd added a comment. This was something that I was hitting an issue with. In particular, it was a module build for a module which pulled in intsafe.h. Now, given that it is a preprocessor macro, it would stand to reason that it will normally be dropped and thus won't matter if the

[PATCH] D116635: Add warning to detect when calls passing arguments are made to functions without prototypes.

delcypher abandoned this revision. delcypher added inline comments. Herald added a project: All. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5529 +def warn_call_function_without_prototype : Warning< + "calling function %0 with arguments when function has no

[clang-tools-extra] 2b69eb4 - [clang-tools-extra] Reuse llvm_config.use_clang() to set up test environment

Author: Sam McCall Date: 2022-03-15T22:14:24+01:00 New Revision: 2b69eb4a7d1d1e6829081aa677cd52ad8eef2d5b URL: https://github.com/llvm/llvm-project/commit/2b69eb4a7d1d1e6829081aa677cd52ad8eef2d5b DIFF: https://github.com/llvm/llvm-project/commit/2b69eb4a7d1d1e6829081aa677cd52ad8eef2d5b.diff

[PATCH] D121422: [clang-tools-extra] Reuse llvm_config.use_clang() to set up test environment

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b69eb4a7d1d: [clang-tools-extra] Reuse llvm_config.use_clang() to set up test environment (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D121422?vs=414514=415581#toc

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains added a comment. In D121098#3378375 , @ChuanqiXu wrote: > It lacks tests. This is not NFC, right? Right, (there are tests with the next patch which introduces the mechanism for producing the pre-processed output) but, I will find a suitable one

[clang] 1bb13b3 - Fix sphinx build because of indentation

Author: Aleksandr Platonov Date: 2022-03-16T00:11:56+03:00 New Revision: 1bb13b3f4956370afc01a8a9315dabed8c09a2cd URL: https://github.com/llvm/llvm-project/commit/1bb13b3f4956370afc01a8a9315dabed8c09a2cd DIFF:

[PATCH] D121427: [lit] add lit_config.substitute to interpolate lit_config.params

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa1019fa1843: [lit] add lit_config.substitute to interpolate lit_config.params (authored by sammccall). Changed prior to commit:

[clang-tools-extra] fa1019f - [lit] add lit_config.substitute to interpolate lit_config.params

Author: Sam McCall Date: 2022-03-15T22:09:43+01:00 New Revision: fa1019fa184344a9ba57e56c8ae6c52e65b5f05c URL: https://github.com/llvm/llvm-project/commit/fa1019fa184344a9ba57e56c8ae6c52e65b5f05c DIFF: https://github.com/llvm/llvm-project/commit/fa1019fa184344a9ba57e56c8ae6c52e65b5f05c.diff

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415574. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415573. cor3ntin added a comment. - Add tests in lambdas - Do not allow static constexpr: I can't think of a scenario in which that would be problematic *today*, but I agree it would be non-conforming and should be discussed. For example it would affect

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Hi @Orlando and @RKSimon, would you be able to confirm that this version avoids the previous `opt: Unknown command line argument '-lower-global-dtors'` error? Lit invocation: `env LIT_FILTER='dtor' ninja check-llvm` Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith abandoned this revision. keith added a comment. There were 2 competing revisions for this bug fix, I landed https://reviews.llvm.org/D121663 instead since it sounds like having an empty `directory` is more correct in this case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. New revision here: D121736 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121327/new/ https://reviews.llvm.org/D121327 ___ cfe-commits mailing list

[PATCH] D121663: reland: [clang] Don't append the working directory to absolute paths

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2db7d5e9c52: reland: [clang] Dont append the working directory to absolute paths (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121596: [clang-format] Fix crash with ObjC Blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG1db8112311c7: [clang-format] Fix crash with ObjC Blocks (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121596/new/

[clang] a2db7d5 - reland: [clang] Don't append the working directory to absolute paths

Author: Keith Smiley Date: 2022-03-15T13:42:35-07:00 New Revision: a2db7d5e9c52804544363ea819de174bfaa7ecdd URL: https://github.com/llvm/llvm-project/commit/a2db7d5e9c52804544363ea819de174bfaa7ecdd DIFF: https://github.com/llvm/llvm-project/commit/a2db7d5e9c52804544363ea819de174bfaa7ecdd.diff

[clang] 1db8112 - [clang-format] Fix crash with ObjC Blocks

Author: Björn Schäpers Date: 2022-03-15T21:41:57+01:00 New Revision: 1db8112311c7f3c1d39c3b62637ac26055ad9d8f URL: https://github.com/llvm/llvm-project/commit/1db8112311c7f3c1d39c3b62637ac26055ad9d8f DIFF:

[PATCH] D121441: [PowerPC][NFC] Add atomic alignments and ops tests for powerpc

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121441/new/ https://reviews.llvm.org/D121441

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln created this revision. yln added reviewers: Orlando, RKSimon. Herald added subscribers: asb, ormris, pengfei, sunfish, hiraditya, jgravelle-google, sbc100, mgorny, dschuff. Herald added a project: All. yln requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. You're right it's version 5 not 4, maybe the issue is that some platforms (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 because passing 6 also reproduces, but I didn't also try 5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. Hi @Orlando and @RKSimon! Thanks for pointing out the test failure and reverting the change. I see this failure: : 'RUN: at line 1'; /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/opt -lower-global-dtors -S <

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov created this revision. Herald added subscribers: dexonsmith, arphaman. Herald added a project: All. ppluzhnikov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reduces visual noise ("./foo.h" -> "foo.h") in error messages.

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc7034c1ecfb: [Concepts] Fix an assertion failure while diagnosing constrained (authored by royjacobson, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bc7034c - [Concepts] Fix an assertion failure while diagnosing constrained

Author: Roy Jacobson Date: 2022-03-15T13:11:32-07:00 New Revision: bc7034c1ecfbe942bc55ed054fca856c5ab90dc8 URL: https://github.com/llvm/llvm-project/commit/bc7034c1ecfbe942bc55ed054fca856c5ab90dc8 DIFF: https://github.com/llvm/llvm-project/commit/bc7034c1ecfbe942bc55ed054fca856c5ab90dc8.diff

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks added a comment. Some test with a main header and blocks would be nice. Comment at: clang/lib/Format/Format.cpp:2779 /*CheckMainHeader=*/!MainIncludeFound && FirstIncludeBlock); -int Priority = Categories.getSortIncludePriority( -

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

royjacobson added a comment. In D121646#3382243 , @erichkeane wrote: > In D121646#3380902 , @royjacobson > wrote: > >> In D121646#3380893 , @erichkeane >> wrote: >>

[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Nice! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121295/new/ https://reviews.llvm.org/D121295

[PATCH] D121685: [clang][deps] NFC: Use range-based for loop instead of iterators

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. (Not sure if you were waiting for review, but I think it's fine to push this kind of thing after checking the tests pass.) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with another comment inline (up to you whether to do something with it). Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:92 + //

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks added a comment. In D121550#3381903 , @owenpan wrote: > Nvm. See https://github.com/llvm/llvm-project/issues/54384. Phew. I thought I needed a fix for the fix, for the fix, for the fix. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd00557e3f4: [clang][parser] Allow GNU attributes before namespace identifier (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8bd0055 - [clang][parser] Allow GNU attributes before namespace identifier

Author: Aleksandr Platonov Date: 2022-03-15T22:30:22+03:00 New Revision: 8bd00557e3f43b46a96cf0e357d5e65624c85a2b URL: https://github.com/llvm/llvm-project/commit/8bd00557e3f43b46a96cf0e357d5e65624c85a2b DIFF:

[PATCH] D121709: [NFC][AIX] Disable precompiled module file test on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1873d395d57: [NFC][AIX] Disable precompiled module file test on AIX (authored by Jake-Egan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121709/new/

[clang] d1873d3 - [NFC][AIX] Disable precompiled module file test on AIX

Author: Jake Egan Date: 2022-03-15T15:16:15-04:00 New Revision: d1873d395d5799fe7344d08de7f2b01e53697eca URL: https://github.com/llvm/llvm-project/commit/d1873d395d5799fe7344d08de7f2b01e53697eca DIFF: https://github.com/llvm/llvm-project/commit/d1873d395d5799fe7344d08de7f2b01e53697eca.diff

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5791e28f3016: Complete the list of single-underscore keywords for MSVC compat. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5791e28 - Complete the list of single-underscore keywords for MSVC compat.

Author: Eli Friedman Date: 2022-03-15T11:58:40-07:00 New Revision: 5791e28f30168a5a930c1f869529b03b95405afe URL: https://github.com/llvm/llvm-project/commit/5791e28f30168a5a930c1f869529b03b95405afe DIFF: https://github.com/llvm/llvm-project/commit/5791e28f30168a5a930c1f869529b03b95405afe.diff

[PATCH] D121723: [clang] CWG 2354: prohibit alignas for enums

Endill added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4291 // declared with the register storage class specifier. An // alignment-specifier may also be applied to the declaration of a class // or enumeration type.

  1   2   3   >