[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

arsenm added a comment. Can you add a test to make sure the hazard recognizer and code size estimate don’t think this is a real instruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124700/new/ https://reviews.llvm.org/D124700

[PATCH] D124509: [RISCV] Fix int16 -> __fp16 conversion code gen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41b951c92931: [RISCV] Fix int16 - __fp16 conversion code gen (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 41b951c - [RISCV] Fix int16 -> __fp16 conversion code gen

Author: Kito Cheng Date: 2022-04-30T11:10:44+08:00 New Revision: 41b951c92931b65c25485b224901d8cb00163b8e URL: https://github.com/llvm/llvm-project/commit/41b951c92931b65c25485b224901d8cb00163b8e DIFF: https://github.com/llvm/llvm-project/commit/41b951c92931b65c25485b224901d8cb00163b8e.diff

[PATCH] D124510: [RISCV] Precommit test for D124509

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02c7de3a4c32: [RISCV] Precommit test for D124509 (authored by kito-cheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 02c7de3 - [RISCV] Precommit test for D124509

Author: Kito Cheng Date: 2022-04-30T11:09:12+08:00 New Revision: 02c7de3a4c32f2456df09df07e473bb95c85529c URL: https://github.com/llvm/llvm-project/commit/02c7de3a4c32f2456df09df07e473bb95c85529c DIFF: https://github.com/llvm/llvm-project/commit/02c7de3a4c32f2456df09df07e473bb95c85529c.diff

[clang] 9f7ac52 - [OpenMP] Fix printing commands twice in verbose mode

Author: Joseph Huber Date: 2022-04-29T23:06:22-04:00 New Revision: 9f7ac522ae1cacd954e12f89cd4f3d049251188e URL: https://github.com/llvm/llvm-project/commit/9f7ac522ae1cacd954e12f89cd4f3d049251188e DIFF: https://github.com/llvm/llvm-project/commit/9f7ac522ae1cacd954e12f89cd4f3d049251188e.diff

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

briantracy created this revision. briantracy added a reviewer: echristo. Herald added subscribers: martong, kerbowa, hiraditya, jvesely. Herald added a project: All. briantracy requested review of this revision. Herald added projects: clang, libc++, LLVM. Herald added subscribers: llvm-commits,

[clang] 26c82f3 - Revert "[clangd] More precisely enable clang warnings through ClangTidy options"

Author: Nico Weber Date: 2022-04-29T20:34:10-04:00 New Revision: 26c82f3d1de11cdada57e499b63a05d24e18b656 URL: https://github.com/llvm/llvm-project/commit/26c82f3d1de11cdada57e499b63a05d24e18b656 DIFF: https://github.com/llvm/llvm-project/commit/26c82f3d1de11cdada57e499b63a05d24e18b656.diff

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

thakis added a comment. This broke check-clangd everywhere, e.g.: https://lab.llvm.org/buildbot/#/builders/109/builds/37635 http://45.33.8.238/linux/75019/step_9.txt http://45.33.8.238/macm1/34369/step_9.txt http://45.33.8.238/win/57278/step_9.txt Please run tests before committing, please

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. In D124700#3483715 , @kerbowa wrote: > In D124700#3483633 , @rampitec > wrote: > >> In D124700#3483609

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

kerbowa added a comment. In D124700#3483633 , @rampitec wrote: > In D124700#3483609 , @kerbowa wrote: > >> In D124700#3483556 , @rampitec >> wrote: >> >>> You do not

[PATCH] D124348: [RISCV]Add CTZ Intrinsic for ZBB in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG19978e08749f: [RISCV]Add CTZ Intrinsic for ZBB in Clang (authored by joker881). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124348/new/

[clang] 19978e0 - [RISCV]Add CTZ Intrinsic for ZBB in Clang

Author: joker881 Date: 2022-04-30T08:18:10+08:00 New Revision: 19978e08749f5f68fbd535121c4f2ed7297b3a4f URL: https://github.com/llvm/llvm-project/commit/19978e08749f5f68fbd535121c4f2ed7297b3a4f DIFF: https://github.com/llvm/llvm-project/commit/19978e08749f5f68fbd535121c4f2ed7297b3a4f.diff

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73417c517644: [HLSL][clang][Driver] Support validator version command line option. (authored by python3kgae). Repository: rG LLVM Github Monorepo

[clang] 73417c5 - [HLSL][clang][Driver] Support validator version command line option.

Author: python3kgae Date: 2022-04-29T16:48:08-07:00 New Revision: 73417c517644db5c419c85c0b3cb6750172fcab5 URL: https://github.com/llvm/llvm-project/commit/73417c517644db5c419c85c0b3cb6750172fcab5 DIFF: https://github.com/llvm/llvm-project/commit/73417c517644db5c419c85c0b3cb6750172fcab5.diff

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

python3kgae updated this revision to Diff 426191. python3kgae added a comment. NO change, fix UNKNOWN REVISION when arc land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files:

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

kstoimenov added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:558 + TU.ClangTidyProvider = addClangArgs({"-Wunused"}, "*"); + EXPECT_THAT(*TU.build().getDiagnostics(), ElementsAre(UnusedFooWarning)); + // And we can explicitly exclude a

[PATCH] D124348: [RISCV]Add CTZ Intrinsic for ZBB in Clang

joker881 updated this revision to Diff 426187. joker881 added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124348/new/ https://reviews.llvm.org/D124348 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 426185. ken-matsui added a comment. Add a diagnostic for line directive of a gnu extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files:

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

rampitec added a comment. In D124700#3483609 , @kerbowa wrote: > In D124700#3483556 , @rampitec > wrote: > >> You do not handle masks other than 0 yet? > > We handle 0 and 1 only. Do you mean 1 is supported

[clang] 4bdb505 - [Driver] Support for compressed debug info on Fuchsia

Author: Petr Hosek Date: 2022-04-29T15:38:51-07:00 New Revision: 4bdb505d62659491b8b935e0c2e19584839eab74 URL: https://github.com/llvm/llvm-project/commit/4bdb505d62659491b8b935e0c2e19584839eab74 DIFF: https://github.com/llvm/llvm-project/commit/4bdb505d62659491b8b935e0c2e19584839eab74.diff

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek added a comment. In D114115#3477967 , @probinson wrote: > Lit is aware of zlib's presence or absence, you could use `REQUIRES: zlib` > (or you might factor that bit out into its own test with the REQUIRES). I have moved that test to

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek updated this revision to Diff 426182. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/D114115 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/compress.c Index:

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

kerbowa added a comment. In D124700#3483556 , @rampitec wrote: > You do not handle masks other than 0 yet? We handle 0 and 1 only. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:219 +// MASK = 0: No instructions may be

[PATCH] D123884: [HLSL][clang][Driver] Support validator version command line option.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 ___

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 426177. hctim added a comment. (restoring after uploading the diff for D123534 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 426176. hctim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. (restoring after uploading the diff for D123534 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 426175. hctim added a comment. (restoring after uploading the diff for D123538 here accidentally) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

nridge added reviewers: sammccall, kadircet. nridge added a comment. I'll have a proper look at this when I get a chance but meanwhile adding Sam and Kadir who may have thoughts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim updated this revision to Diff 426172. hctim marked an inline comment as done. hctim added a comment. Herald added subscribers: rupprecht, MaskRay, emaste. Herald added a reviewer: jhenderson. Update test, rebase off of string debuginfo. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

rampitec added a comment. You do not handle masks other than 0 yet? Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:219 +// MASK = 0: No instructions may be scheduled across SCHED_BARRIER. +// MASK = 1: Non-memory, non-side-effect producing instructions may be +//

[PATCH] D124702: [MSVC] Add support for pragma function

steplong created this revision. steplong added reviewers: rnk, rsmith, whunt, hans, thakis. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC pragma function tells the compiler to generate calls to

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

kerbowa updated this revision to Diff 426169. kerbowa added a comment. Add mir tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124700/new/ https://reviews.llvm.org/D124700 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + ()) + << "ScratchSize [bytes/thread]: " + << ore::NV("ScratchSize", CurrentProgramInfo.ScratchSize);

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong created this revision. steplong added reviewers: gchatelet, aaron.ballman, courbet, rsmith. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support for `__attribute__((no_builtin("foo")))` was

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

kerbowa created this revision. Herald added subscribers: hsmhsm, foad, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm. Herald added a project: All. kerbowa requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood updated this revision to Diff 426163. LegalizeAdulthood added a comment. Surround replacements with parens CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124650/new/ https://reviews.llvm.org/D124650 Files:

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1178-1266 + +void AMDGPUAsmPrinter::emitResourceUsageRemarks( +const MachineFunction , const SIProgramInfo , +bool isModuleEntryFunction, bool hasMAIInsts) { + if (!ORE) +return;

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood added a comment. In D124650#3481514 , @LegalizeAdulthood wrote: > General question: > > There is the question of whether or not the replacement should have `()`s > around the whole > thing because we don't analyze the context to see

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 426160. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124500/new/ https://reviews.llvm.org/D124500 Files:

[PATCH] D124211: Add __builtin_kcfi_call_unchecked

samitolvanen added a comment. LKML RFC: https://lore.kernel.org/lkml/20220429203644.2868448-1-samitolva...@google.com/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211/new/ https://reviews.llvm.org/D124211

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

upsj added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:448-450 +return Type->isReferenceType() && + !Type.getNonReferenceType().isConstQualified() + ? (Type->isLValueReferenceType() ? "&" : "&&") It

[clang] 0314dba - Thread safety analysis: Don't pass capability kind where not needed (NFC)

Author: Aaron Puchert Date: 2022-04-29T22:30:33+02:00 New Revision: 0314dbac026f58aaaf0a9ee4515f401f0d43ee76 URL: https://github.com/llvm/llvm-project/commit/0314dbac026f58aaaf0a9ee4515f401f0d43ee76 DIFF: https://github.com/llvm/llvm-project/commit/0314dbac026f58aaaf0a9ee4515f401f0d43ee76.diff

[clang] f8afb8f - Thread safety analysis: Store capability kind in CapabilityExpr

Author: Aaron Puchert Date: 2022-04-29T22:30:33+02:00 New Revision: f8afb8fdedae04ad2670857c97925c439d47d862 URL: https://github.com/llvm/llvm-project/commit/f8afb8fdedae04ad2670857c97925c439d47d862 DIFF: https://github.com/llvm/llvm-project/commit/f8afb8fdedae04ad2670857c97925c439d47d862.diff

[PATCH] D124132: Thread safety analysis: Don't pass capability kind where not needed (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0314dbac026f: Thread safety analysis: Dont pass capability kind where not needed (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d65c922 - Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)

Author: Aaron Puchert Date: 2022-04-29T22:30:33+02:00 New Revision: d65c922450d1fdf0f44f4a10a8f33b11c6c01bf5 URL: https://github.com/llvm/llvm-project/commit/d65c922450d1fdf0f44f4a10a8f33b11c6c01bf5 DIFF: https://github.com/llvm/llvm-project/commit/d65c922450d1fdf0f44f4a10a8f33b11c6c01bf5.diff

[clang] dd1790c - Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC)

Author: Aaron Puchert Date: 2022-04-29T22:30:33+02:00 New Revision: dd1790cd05ae124e9e5d57dfe9279ff54f34b488 URL: https://github.com/llvm/llvm-project/commit/dd1790cd05ae124e9e5d57dfe9279ff54f34b488 DIFF: https://github.com/llvm/llvm-project/commit/dd1790cd05ae124e9e5d57dfe9279ff54f34b488.diff

[PATCH] D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd65c922450d1: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124127: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd1790cd05ae: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124131: Thread safety analysis: Store capability kind in CapabilityExpr

This revision was automatically updated to reflect the committed changes. aaronpuchert marked 2 inline comments as done. Closed by commit rGf8afb8fdedae: Thread safety analysis: Store capability kind in CapabilityExpr (authored by aaronpuchert). Changed prior to commit:

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5227be8b6aa0: [clangd] More precisely enable clang warnings through ClangTidy options (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 5227be8 - [clangd] More precisely enable clang warnings through ClangTidy options

Author: Sam McCall Date: 2022-04-29T22:24:34+02:00 New Revision: 5227be8b6aa0edb2edb0b76e1039a7dd5641c80a URL: https://github.com/llvm/llvm-project/commit/5227be8b6aa0edb2edb0b76e1039a7dd5641c80a DIFF: https://github.com/llvm/llvm-project/commit/5227be8b6aa0edb2edb0b76e1039a7dd5641c80a.diff

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { aaron.ballman wrote: > ken-matsui wrote: > > aaron.ballman wrote: > > > I speculate that

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood marked 7 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.h:18-20 +// Parses an array of tokens and returns true if they conform to the rules of +// C++ for

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 updated this revision to Diff 426150. jhuber6 added a comment. Fixed missing info flag for `--offload-new-driver`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123471/new/ https://reviews.llvm.org/D123471 Files:

[PATCH] D124694: [randstruct] Move initializer check to be more effective

void created this revision. void added reviewers: stuij, MaskRay, aaron.ballman. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a randomized structure has an

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2171 if (Field == FieldEnd) { // We've run out of fields. We're done. stuij wrote: > @void Unfortunately this end of fields check will break the non-designated > initializer check

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ModernizeModuleTest.cpp:66 +{false, "1.23"}, +{false, "0x1p3"}, +{false, R"("string")"}, LegalizeAdulthood

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood added a comment. In D124500#3483224 , @aaron.ballman wrote: > To clarify my previous comments, I'm fine punting on the edge cases until > user reports come in, so don't let them block this review if you feel > strongly about not

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

xbolva00 added a comment. >> The intent is to allow adding arbitrary annotations to types for use in >> static analysis tools This patch should not land until we see some real use cases to justify new hundreds of lines of code. We should more careful and take maintanence cost really into

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || +

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

erichkeane added a comment. I don't really know how useful this ends up being, these attributes (since they are part of `AttributedType` end up disappearing pretty quickly/easily. Anything that causes canonicalization will cause these to go away, they don't apply to references to these types,

[PATCH] D124669: [flang][driver] Add support for -save-temps

unterumarmung added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; Why not to add `FC1Option`

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman added a reviewer: erichkeane. aaron.ballman added subscribers: rsmith, erichkeane. aaron.ballman added a comment. Adding in @erichkeane just in case he spots anything I've missed. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added a comment. To clarify my previous comments, I'm fine punting on the edge cases until user reports come in, so don't let them block this review if you feel strongly about not supporting them. But when user reports start coming in, at some point I might start asking to

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || + !isIntegralConstant(*Current)) { LegalizeAdulthood

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3483175 , @manojgupta wrote: > Unless I probably mis-interpreted something, -fno-knr-functions does not > suppress the warning: https://godbolt.org/z/rbEfbbb33 Godbolt hasn't had the chance to catch up to

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3483163 , @manojgupta wrote: > Basically, I'm wondering if you'd be able to enable -fno-knr-function? > > Thanks. this looks promising. Any ideas when -fno-knr-function support was > added? Oops, I had a

[PATCH] D119296: KCFI sanitizer

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. In D119296#3481573 , @joaomoreira wrote: > I'm not an expert on LLVM's pipeline, but it just feels a little awkward and >

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

manojgupta added a comment. Unless I probably mis-interpreted something, -fno-knr-functions does not suppress the warning: https://godbolt.org/z/rbEfbbb33 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { ken-matsui wrote: > aaron.ballman wrote: > > I speculate that this change is wrong. > >

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

manojgupta added a comment. Basically, I'm wondering if you'd be able to enable -fno-knr-function? Thanks. this looks promising. Any ideas when -fno-knr-function support was added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/

[PATCH] D124537: [AMDGPU][clang] Definition of gfx11 subtarget

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bdfc73f633d: [AMDGPU][clang] Definition of gfx11 subtarget (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 8bdfc73 - [AMDGPU][clang] Definition of gfx11 subtarget

Author: Joe Nash Date: 2022-04-29T13:55:56-04:00 New Revision: 8bdfc73f633dca9859123b8596bcb521700c6a7f URL: https://github.com/llvm/llvm-project/commit/8bdfc73f633dca9859123b8596bcb521700c6a7f DIFF: https://github.com/llvm/llvm-project/commit/8bdfc73f633dca9859123b8596bcb521700c6a7f.diff

[PATCH] D124669: [flang][driver] Add support for -save-temps

schweitz added inline comments. Comment at: clang/include/clang/Driver/Options.td:3989 Group; -def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, NoXarchOption]>, +def save_temps_EQ : Joined<["-", "--"], "save-temps=">,

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

rnk added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx; yaxunl wrote: > rnk wrote: > > It

[PATCH] D119296: KCFI sanitizer

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. (tentatively removing my +1 since this patch has changed quite a bit since my initial review) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f7970083029: [randstruct] Automatically randomize a structure of function pointers (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6f79700 - [randstruct] Automatically randomize a structure of function pointers

Author: Bill Wendling Date: 2022-04-29T11:05:09-07:00 New Revision: 6f79700830292d86afec5f3cf5143b00e6f3f1fd URL: https://github.com/llvm/llvm-project/commit/6f79700830292d86afec5f3cf5143b00e6f3f1fd DIFF: https://github.com/llvm/llvm-project/commit/6f79700830292d86afec5f3cf5143b00e6f3f1fd.diff

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj created this revision. upsj added a reviewer: nridge. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. upsj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. I am

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen updated this revision to Diff 426116. samitolvanen marked 2 inline comments as done. samitolvanen added a comment. - Renamed the builtin. - Addressed Nick's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211/new/

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:32-33 + // not a decimal floating-point literal + return std::none_of( + Begin, End,

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3482575 , @aaron.ballman wrote: > In D122895#3482555 , @tahonermann > wrote: > >>> I think it's debatable whether this is a bug or not >> >> For C99 through C17, I kind

[clang] ef87865 - Silence -Wstrict-prototype diagnostics in C2x mode

Author: Aaron Ballman Date: 2022-04-29T13:37:33-04:00 New Revision: ef87865b98fa25af1d2c045bab1268b2a1503374 URL: https://github.com/llvm/llvm-project/commit/ef87865b98fa25af1d2c045bab1268b2a1503374 DIFF: https://github.com/llvm/llvm-project/commit/ef87865b98fa25af1d2c045bab1268b2a1503374.diff

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood updated this revision to Diff 426111. LegalizeAdulthood added a comment. Sort changes by check name in docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124650/new/ https://reviews.llvm.org/D124650 Files:

[clang] 9c8a883 - [Clang][Docs] Add new offloading flags to the clang documentation

Author: Joseph Huber Date: 2022-04-29T13:07:11-04:00 New Revision: 9c8a88382d86c731db3c5c92d8ecd6ef296329ab URL: https://github.com/llvm/llvm-project/commit/9c8a88382d86c731db3c5c92d8ecd6ef296329ab DIFF: https://github.com/llvm/llvm-project/commit/9c8a88382d86c731db3c5c92d8ecd6ef296329ab.diff

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added a comment. In D122895#3482707 , @manojgupta wrote: > Is disabling the pedantic warning an option for your users? > > Disabling it wholesale is not an option since they actually want this warning > (the older version). But we

[PATCH] D124536: [AMDGPU] Add gfx11 subtarget ELF definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG813e521e55b1: [AMDGPU] Add gfx11 subtarget ELF definition (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 813e521 - [AMDGPU] Add gfx11 subtarget ELF definition

Author: Joe Nash Date: 2022-04-29T12:27:17-04:00 New Revision: 813e521e55b11165138b071f446eda94b14570dc URL: https://github.com/llvm/llvm-project/commit/813e521e55b11165138b071f446eda94b14570dc DIFF: https://github.com/llvm/llvm-project/commit/813e521e55b11165138b071f446eda94b14570dc.diff

[PATCH] D124621: [Analyzer] Fix assumptions about const field with member-initializer

steakhal accepted this revision. steakhal added a comment. In D124621#3482782 , @mantognini wrote: > In D124621#3481973 , @steakhal > wrote: > >> BTW have you measured the observable impact of this patch on

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D124462#3482728 , @mantognini wrote: > In D124462#3480348 , @aaron.ballman > wrote: > >> In

[PATCH] D124534: Add a diagnostic for line directive of a gnu extension

ken-matsui added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:1356 + +PP.Diag(FlagTok, diag::ext_pp_gnu_line_directive); } else if (FlagVal == 2) { aaron.ballman wrote: > I speculate that this change is wrong. > > The goal here is to

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ParsedAST.cpp:240 +// Note that unlike -Wunused, clang-diagnostics-unused does not imply +// subcategories like

[PATCH] D124621: CPP-2461 [Analyzer] Fix assumptions about const field with member-initializer

mantognini marked 2 inline comments as done. mantognini added a comment. In D124621#3481973 , @steakhal wrote: > LGTM > > In D124621#3481906 , @mantognini > wrote: > >> One thing I'm not sure about and couldn't

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

steakhal added a comment. Finally, we have this! Can we have this https://godbolt.org/z/oferc6P5Y in addition to the one you proposed? I find it more readable. What performance hit will we suffer from this change? Please do a differential analysis. Comment at:

[PATCH] D124621: CPP-2461 [Analyzer] Fix assumptions about const field with member-initializer

mantognini updated this revision to Diff 426077. mantognini added a comment. Update commit message and add FIXMEs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124621/new/ https://reviews.llvm.org/D124621 Files:

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang,

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini added a comment. In D124462#3480348 , @aaron.ballman wrote: > In D124462#3480219 , @steakhal > wrote: > >> Thanks for the stats. >> @aaron.ballman WDYT, where should we put the `LLVM_DUMP_METHOD` ? >

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9c64d33b98b: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d9c64d3 - [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

Author: Joseph Huber Date: 2022-04-29T11:38:40-04:00 New Revision: d9c64d33b98be695fc78a65624242033058ed117 URL: https://github.com/llvm/llvm-project/commit/d9c64d33b98be695fc78a65624242033058ed117 DIFF: https://github.com/llvm/llvm-project/commit/d9c64d33b98be695fc78a65624242033058ed117.diff

  1   2   >