[PATCH] D125037: [pseudo] Add fuzzer for the pseudoparser.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/pseudo/fuzzer/Fuzzer.cpp:81 + bool PrintForest = false; + unsigned O = 1; + for (int I = 1; I < *Argc; ++I) { nit:

[PATCH] D125064: [clang-format][NFC] Make all TokenAnnotator member functions const

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125064/new/ https://reviews.llvm.org/D125064

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 427529. njames93 added a comment. Remove unnecessary tests in ReadabilityTidyModule now that the SimplifyBooleanExprMatchers header has been removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/test/crash/bad-ucn.c:4 +// RUN: clang-pseudo -source=%s +A\U nit: this test seems duplicated with the one

[PATCH] D104975: Implement P1949

intractabilis added a comment. In D104975#3493992 , @tahonermann wrote: > Please refrain from such unhelpful comments. Absolutely, no problem. It's great that my other comments were helpful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125061: [clang] A more robust way to attach comments

akyrtzi added a comment. Since the issue is specific to enumerators I would recommend against increasing the size of `DeclBase`, which would increase the size of every single `Decl` in the AST. There are multiple ways to approach this: - Consider whether bringing back the comma check just for

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov updated this revision to Diff 427526. ppluzhnikov added a comment. Fix more UNIX and Winx64 failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121733/new/ https://reviews.llvm.org/D121733 Files:

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

benshi001 added a comment. In D123200#3495356 , @aykevl wrote: > @benshi001 I have been looking through the GCC code and I think avr-gcc also > has a special calling convention for many other functions, including > `__mulqi3` and `__mulhi3`. > >

[PATCH] D124285: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b762b3ab8d2: [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of… (authored by vsapsai). Repository: rG LLVM Github

[clang] 3b762b3 - [clang][NFC] In parts of Objective-C Sema use Obj-C-specific types instead of `Decl`.

Author: Volodymyr Sapsai Date: 2022-05-05T19:19:41-07:00 New Revision: 3b762b3ab8d205cd6a7d42c96d39d5f4f701f2ab URL: https://github.com/llvm/llvm-project/commit/3b762b3ab8d205cd6a7d42c96d39d5f4f701f2ab DIFF:

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 marked 3 inline comments as done. int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind();

[PATCH] D125061: [clang] A more robust way to attach comments

zixuw added a comment. Well, apparently there are still some corner-case bugs in the logic. ExtractAPI and a few other tests failed. Will look into it tomorrow. And if folks have concerns or opinions of the performance/space cost of adding the extra pointer to `DeclBase`, I can try to keep the

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427509. int3 added a comment. make things work under cc1as too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D125064: [clang-format][NFC] Make all TokenAnnotator member functions const

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D118355: Add -mmanual-endbr switch to allow manual selection of control-flow protection

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:156-161 if (needsPrologueENDBR(MF, M)) { -auto MBB = MF.begin(); -Changed |= addENDBR(*MBB, MBB->begin()); +if (!ManualENDBR || MF.getFunction().doesCfCheck()) { +

[PATCH] D125061: [clang] A more robust way to attach comments

zixuw created this revision. Herald added a subscriber: arphaman. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current implementation in

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 marked 3 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:788-789 + options::OPT_fno_openmp, false) && + (C.getInputArgs().hasArg(options::OPT_fopenmp_targets_EQ) || +

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 updated this revision to Diff 427496. jhuber6 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125050/new/ https://reviews.llvm.org/D125050 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

sammccall added a comment. With this and D125049 , I no longer get any low-hanging fuzzer crashes. (Though we're probably mostly fuzzing the lexer. Providing a list of tokens as a dictionaly may help) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:313 + if (BoundArch.empty()) +checkSystemForAMDGPU(Args, *this, Arch); DAL->AddJoinedArg(nullptr, Opts.getOption(options::OPT_march_EQ), Arch); tra wrote:

[PATCH] D125059: [Lex] Don't assert when decoding invalid UCNs.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Currently if a lexically-valid UCN encodes an invalid codepoint,

[PATCH] D125049: [pseudo] Only expand UCNs for raw_identifiers

sammccall updated this revision to Diff 427490. sammccall added a comment. oops, forgot testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125049/new/ https://reviews.llvm.org/D125049 Files:

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; ymandel wrote: >

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

tra added a comment. Just a drive-by style review. I didn't look at the functionality of the changes much. Comment at: clang/lib/Driver/Driver.cpp:788-789 + options::OPT_fno_openmp, false) && +

[clang] f6c7493 - [docs] Fix uses of `foo` that should be ``foo`` throughout release notes.

Author: Richard Smith Date: 2022-05-05T16:04:19-07:00 New Revision: f6c74932b59619aa1a680caa7c4b78d4d29c2877 URL: https://github.com/llvm/llvm-project/commit/f6c74932b59619aa1a680caa7c4b78d4d29c2877 DIFF: https://github.com/llvm/llvm-project/commit/f6c74932b59619aa1a680caa7c4b78d4d29c2877.diff

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

aykevl added a comment. @benshi001 I have been looking through the GCC code and I think avr-gcc also has a special calling convention for many other functions, including `__mulqi3` and `__mulhi3`. Source: 1. I think this is where the ABI is specified in the compiler:

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. @aaron.ballman I could suppress the strange warnings by using `isWrittenInBuiltinFile` and `isWrittenInCommandLineFile`. Thank you! Could you please review this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c2572d8 - [docs] Add blank lines to help Sphinx parse nested bullets.

Author: Richard Smith Date: 2022-05-05T15:58:26-07:00 New Revision: c2572d8b1fccffcc5dd7b900cf3c4cfa07df3b50 URL: https://github.com/llvm/llvm-project/commit/c2572d8b1fccffcc5dd7b900cf3c4cfa07df3b50 DIFF: https://github.com/llvm/llvm-project/commit/c2572d8b1fccffcc5dd7b900cf3c4cfa07df3b50.diff

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 427482. ken-matsui added a comment. Update codes as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files:

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:313 + if (BoundArch.empty()) +checkSystemForAMDGPU(Args, *this, Arch);

[clang] 1c50909 - Revert "Pedantically warn about // comments in gnu89 mode"

Author: Aaron Ballman Date: 2022-05-05T18:39:13-04:00 New Revision: 1c50909f6f8ac183b82e973457522439a8856e96 URL: https://github.com/llvm/llvm-project/commit/1c50909f6f8ac183b82e973457522439a8856e96 DIFF: https://github.com/llvm/llvm-project/commit/1c50909f6f8ac183b82e973457522439a8856e96.diff

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae created this revision. python3kgae added reviewers: svenvh, asavonic, beanz, pow2clk. Herald added subscribers: Anastasia, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Vector

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124721/new/ https://reviews.llvm.org/D124721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125049: [pseudo] Only expand UCNs for raw_identifiers

sammccall updated this revision to Diff 427475. sammccall added a comment. rename testcase to be more descriptive, add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125049/new/ https://reviews.llvm.org/D125049 Files:

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, yaxunl, JonChesterfield, saiislam, ronlieb. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a

[PATCH] D125049: [pseudo] Only expand UCNs for raw_identifiers

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. It turns out clang::expandUCNs only works on tokens that

[clang] e7aed73 - [clang-format][NFC] Add a few regression tests

Author: owenca Date: 2022-05-05T15:12:24-07:00 New Revision: e7aed737eb2d8fb2150f38e48d1c3e0108931999 URL: https://github.com/llvm/llvm-project/commit/e7aed737eb2d8fb2150f38e48d1c3e0108931999 DIFF: https://github.com/llvm/llvm-project/commit/e7aed737eb2d8fb2150f38e48d1c3e0108931999.diff LOG:

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b626a2caa67: [clang-format] Fix another bug in AlignConsecutiveAssignments (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124956/new/

[clang] 8b626a2 - [clang-format] Fix another bug in AlignConsecutiveAssignments

Author: owenca Date: 2022-05-05T14:48:56-07:00 New Revision: 8b626a2caa672a174829105ff7749d8d9a080f2a URL: https://github.com/llvm/llvm-project/commit/8b626a2caa672a174829105ff7749d8d9a080f2a DIFF: https://github.com/llvm/llvm-project/commit/8b626a2caa672a174829105ff7749d8d9a080f2a.diff LOG:

[PATCH] D121733: Clean pathnames in FileManager.

ppluzhnikov updated this revision to Diff 427460. ppluzhnikov added a comment. Herald added a subscriber: carlosgalvezp. Fix Winx64 `clang-tidy/checkers/google-upgrade-googletest-case.cpp` failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 16dcbb5 - [ORC] Return ExecutorAddrs rather than JITEvaluatedSymbols from LLJIT::lookup.

Author: Lang Hames Date: 2022-05-05T13:56:00-07:00 New Revision: 16dcbb53dc7968a3752661aac731172ebe0faf64 URL: https://github.com/llvm/llvm-project/commit/16dcbb53dc7968a3752661aac731172ebe0faf64 DIFF: https://github.com/llvm/llvm-project/commit/16dcbb53dc7968a3752661aac731172ebe0faf64.diff

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

aaron.ballman added a comment. Thanks for working on this compatibility extension! This is missing all of the lexing tests which validate that we correctly diagnose malformed pragmas. We're also missing all sema tests for the diagnostics added or emitted from there. When you add the sema

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 427436. njames93 added a comment. Remove SimplifyBoolExprMatchers header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files:

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun accepted this revision. xazax.hun added a comment. It looks like all of my comments are resolved now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45643cfcc12e: [clang][dataflow] Centralize expression skipping logic (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 45643cf - [clang][dataflow] Centralize expression skipping logic

Author: Eric Li Date: 2022-05-05T20:28:11Z New Revision: 45643cfcc12ea6152fb9516ed24f5adf7469eb4c URL: https://github.com/llvm/llvm-project/commit/45643cfcc12ea6152fb9516ed24f5adf7469eb4c DIFF: https://github.com/llvm/llvm-project/commit/45643cfcc12ea6152fb9516ed24f5adf7469eb4c.diff LOG:

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 427430. njames93 added a comment. Transform final matcher, Benchmark -> 0.82s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files:

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel marked an inline comment as done. ymandel added a comment. In D121120#3494427 , @xazax.hun wrote: > Overall this looks good to me. However, I think this might not use the full > potential of the check itself. With the information that the

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427429. ymandel marked an inline comment as done. ymandel added a comment. add assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120 Files:

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua marked an inline comment as done. li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; xazax.hun wrote: >

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; ymandel wrote: >

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth marked an inline comment as done. JonasToth added a comment. Thank you for the review! I adjusted the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth updated this revision to Diff 427423. JonasToth marked 3 inline comments as done. JonasToth added a comment. - addressing review comments and remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added a comment. In D124998#3494814 , @erichkeane wrote: > First: I care very little about `FunctionNoProtoType`. I care insomuch as it doesn't break valid user code. > Second, it is used only in "C" afaik, where our memory pressure

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. I don't want to change with the distinction between FunctionProtoType and FunctionNoProtoType; that would involve auditing a bunch of code we don't really want to mess with. FunctionProtoType and FunctionNoProtoType don't have any member variables at the moment,

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +dyn_cast_or_null(Env.getValue(RHS,

[PATCH] D125037: [pseudo] Add fuzzer for the pseudoparser.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. As confirmation,

[PATCH] D117829: [Clang] Add integer mul reduction builtin

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! IIRC @scanon had some opinions about `__builtin_reduce_mul` during some earlier discussions. Please wait a few days in case there are additional comments. Repository: rG LLVM

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494785 , @aaron.ballman wrote: > In D124998#3494500 , @erichkeane > wrote: > >> In D124998#3494442 , @efriedma >> wrote: >> >>>

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added a comment. In D124998#3494500 , @erichkeane wrote: > In D124998#3494442 , @efriedma > wrote: > >> In D124998#3494426 , @erichkeane >> wrote: >> >>>

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 427418. njames93 added a comment. Remove redundant traversal of CompoundStmt in a replace method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files:

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +dyn_cast_or_null(Env.getValue(RHS,

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua updated this revision to Diff 427417. li.zhe.hua marked 3 inline comments as done. li.zhe.hua added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124965/new/ https://reviews.llvm.org/D124965 Files:

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unchecked-optional-access.rst:29 + +Checking if a value exists, then accessing the value + ymandel wrote: >

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unchecked-optional-access.rst:29 + +Checking if a value exists, then accessing the value +

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427412. ymandel added a comment. reorder examples Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120 Files:

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb906757ada: [clang][ASTImporter][NFC]: Move clang::ImportError into own header. (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] dcb9067 - [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

Author: phyBrackets Date: 2022-05-06T00:14:32+05:30 New Revision: dcb906757ada24edf8da89439c72d015b53f204b URL: https://github.com/llvm/llvm-project/commit/dcb906757ada24edf8da89439c72d015b53f204b DIFF: https://github.com/llvm/llvm-project/commit/dcb906757ada24edf8da89439c72d015b53f204b.diff

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[clang] f6dff93 - Pedantically warn about // comments in gnu89 mode

Author: Aaron Ballman Date: 2022-05-05T14:35:47-04:00 New Revision: f6dff93641b2259623e686eb13a1884b8b9f4a00 URL: https://github.com/llvm/llvm-project/commit/f6dff93641b2259623e686eb13a1884b8b9f4a00 DIFF: https://github.com/llvm/llvm-project/commit/f6dff93641b2259623e686eb13a1884b8b9f4a00.diff

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. Thanks @martong @balazske for the Review . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 ___ cfe-commits mailing list

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski added a comment. Pre-merge CI is  . If there are no new comments, I'd like to merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427398. int3 added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:368 void Environment::setStorageLocation(const Expr , StorageLocation ) { - assert(!isa());

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427396. int3 retitled this revision from "[MC] Omit DWARF unwind info if compact unwind is present for all archs" to "[MC] Omit DWARF unwind info if compact unwind is present where eligible". int3 edited the summary of this revision. int3 added a comment.

[clang] 967137c - No longer accept scoped enumerations in C

Author: Aaron Ballman Date: 2022-05-05T14:00:01-04:00 New Revision: 967137ca3cb7cf38b2fedf0415946ff3ffd0ef50 URL: https://github.com/llvm/llvm-project/commit/967137ca3cb7cf38b2fedf0415946ff3ffd0ef50 DIFF: https://github.com/llvm/llvm-project/commit/967137ca3cb7cf38b2fedf0415946ff3ffd0ef50.diff

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 created this revision. njames93 added reviewers: alexfh, klimek, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

tschuett added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, tschuett wrote: > aaron.ballman wrote: > > peterwaller-arm wrote: > > > peterwaller-arm wrote: > > > > It

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. In D124998#3494426 , @erichkeane wrote: > In D124998#3494424 , @efriedma > wrote: > >> If you're really concerned about the size of FunctionProtoType increasing, >> can we just shove

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Overall this looks good to me. However, I think this might not use the full potential of the check itself. With the information that the dataflow framework have it could distinguish

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494424 , @efriedma wrote: > If you're really concerned about the size of FunctionProtoType increasing, > can we just shove the infrequently used calling convention bits into > TrailingObjects? I don't believe

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. If you're really concerned about the size of FunctionProtoType increasing, can we just shove the infrequently used calling convention bits into TrailingObjects? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124998/new/

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; xazax.hun wrote: >

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; Could the size of

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427381. ymandel added a comment. Factor out analysis code into separate function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120 Files:

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494388 , @paulwalker-arm wrote: > In D124998#3494127 , @aaron.ballman > wrote: > >> In D124998#3493791 , >> @paulwalker-arm

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

paulwalker-arm added a comment. In D124998#3494127 , @aaron.ballman wrote: > In D124998#3493791 , > @paulwalker-arm wrote: > >> Just wanted to say this is not a new calling convention as such, but rather >> an

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:38 + + auto HasOptionalCallDescendant = hasDescendant(callExpr(callee(cxxMethodDecl( + ofClass(anyOf(hasName("std::optional"), hasName("absl::optional"),

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427377. ymandel marked 2 inline comments as done. ymandel added a comment. added fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120 Files:

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

sammccall added a comment. In D124974#3494279 , @dexonsmith wrote: > Can we add a test for this? I think the problem with testing it is that this variable comes from the CMake config, and in the default configuration (as used by all the bots) it's not

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427374. ymandel marked 2 inline comments as done. ymandel added a comment. Herald added a project: clang. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added a comment. This is unfortunately true, unless we generate some code that calculates the length of the string at runtime. I find it difficult to draw the line between defining this built-in functionality and developers developing printf-like functionality, if built-in does too

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427367. awarzynski added a comment. Mark the tests as unsupported on Windows Pre-merge testing is failing on Windows. Here is the error message: flang-new: error: there is no external assembler that can be used on this platform I will update the

  1   2   3   >