[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 438173. brad added a comment. Further tweak tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128127/new/ https://reviews.llvm.org/D128127 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

2022-06-18 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 438171. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

2022-06-18 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 438169. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h

[PATCH] D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. This should probably be applied to Fuchsia and NetBSD as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127826/new/ https://reviews.llvm.org/D127826 ___ cfe-commits mailing

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 438160. brad added a comment. Update tests to conform to recent style changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128127/new/ https://reviews.llvm.org/D128127 Files:

[clang] c5935af - [Toolchains] Use llvm::is_contained (NFC)

2022-06-18 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-06-18T15:57:50-07:00 New Revision: c5935af0583b6988a8e4f9fdcab1f4d29f04a021 URL: https://github.com/llvm/llvm-project/commit/c5935af0583b6988a8e4f9fdcab1f4d29f04a021 DIFF: https://github.com/llvm/llvm-project/commit/c5935af0583b6988a8e4f9fdcab1f4d29f04a021.diff

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: luke957, StephenFan, s.egerton, simoncook, fedor.sergeev. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: pcwang-thead. Have the

[clang] 6dd094d - [Driver][OpenBSD] Use Arch reference instead of getArch(). NFC

2022-06-18 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2022-06-18T18:11:15-04:00 New Revision: 6dd094dd435d09872687c1bdcce6845f70cf25cc URL: https://github.com/llvm/llvm-project/commit/6dd094dd435d09872687c1bdcce6845f70cf25cc DIFF: https://github.com/llvm/llvm-project/commit/6dd094dd435d09872687c1bdcce6845f70cf25cc.diff

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG119a13199a91: [Driver] Pass -X to ld for riscv64-openbsd (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 119a131 - [Driver] Pass -X to ld for riscv64-openbsd

2022-06-18 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2022-06-18T17:58:58-04:00 New Revision: 119a13199a91abd43818412c34b9308db3c9270d URL: https://github.com/llvm/llvm-project/commit/119a13199a91abd43818412c34b9308db3c9270d DIFF: https://github.com/llvm/llvm-project/commit/119a13199a91abd43818412c34b9308db3c9270d.diff

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

2022-06-18 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: clang/test/Driver/openbsd.c:133 +// RUN: | FileCheck -check-prefix=CHECK-RISCV64-FLAGS %s +// CHECK-RISCV64-FLAGS: "-X" MaskRay wrote: > It's useful to check other values like the `-m` emulation and the dynamic >

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

2022-06-18 Thread Roy Jacobson via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21eb1af469c3: [Concepts] Implement overload resolution for destructors (P0848) (authored by royjacobson). Repository: rG LLVM Github Monorepo

[clang] 21eb1af - [Concepts] Implement overload resolution for destructors (P0848)

2022-06-18 Thread Roy Jacobson via cfe-commits
Author: Roy Jacobson Date: 2022-06-19T00:30:37+03:00 New Revision: 21eb1af469c3257606aec2270d544e0e8ecf77b2 URL: https://github.com/llvm/llvm-project/commit/21eb1af469c3257606aec2270d544e0e8ecf77b2 DIFF: https://github.com/llvm/llvm-project/commit/21eb1af469c3257606aec2270d544e0e8ecf77b2.diff

[PATCH] D128064: [Static Analyzer] Small array binding policy

2022-06-18 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. There's nothing immediately wrong with this patch so no need to revert it. It makes sense to revert a patch if it breaks buildbots or if there's no fix coming soon (eg. if we're about to have an entire LLVM release broken). If there was a revert it would have made sense to

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

2022-06-18 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Thanks for updating the summary. I'm not too confident around diagnostics though. I'm going to piggyback on @scott.linder's comments. I think they are on the point. nit: I'm not sure if `size_t` is a thing in c++, `std::size_t` is though. Comment

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

2022-06-18 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added inline comments. Comment at: clang/test/Analysis/symbol-simplification-mem-region-to-int-cast.cpp:23 + clang_analyzer_eval(p == 0);// expected-warning{{TRUE}} + clang_analyzer_eval(p_as_integer == 0); // expected-warning{{UNKNOWN}} +

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

2022-06-18 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1082 + // FIXME support cast from non-integers. + // E.g (char)(double)(double x) -> (char)(double x) +

[PATCH] D128068: [analyzer] Do not emit redundant SymbolCasts

2022-06-18 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. > We can't just do that check in `evalCast` because there are many additonal > logic before we'd end up in `makeNonLoc`. I'm not exactly up to date. Could you please extend the summary

[clang] af6d2a0 - [docs] Re-generate ClangCommandLineReference.rst

2022-06-18 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-06-18T11:01:54-07:00 New Revision: af6d2a0b6825e71965f3e2701a63c239fa0ad70f URL: https://github.com/llvm/llvm-project/commit/af6d2a0b6825e71965f3e2701a63c239fa0ad70f DIFF: https://github.com/llvm/llvm-project/commit/af6d2a0b6825e71965f3e2701a63c239fa0ad70f.diff

[clang] 80c12bd - [clang] Call *set::insert without checking membership first (NFC)

2022-06-18 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-06-18T10:41:26-07:00 New Revision: 80c12bdb3bbdb2b0250ff6f712da65b9c7788c9d URL: https://github.com/llvm/llvm-project/commit/80c12bdb3bbdb2b0250ff6f712da65b9c7788c9d DIFF: https://github.com/llvm/llvm-project/commit/80c12bdb3bbdb2b0250ff6f712da65b9c7788c9d.diff

[PATCH] D127812: [AArch64] Function multiversioning support added.

2022-06-18 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + ilinpv wrote: > MaskRay wrote: > > This file is auto-generated. Don't touch it. > It looked out of sync with options td files: > > ``` > +..

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-18 Thread Yuki Okushi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7eb046624f2a: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile` (authored by JohnTitor). Repository: rG LLVM Github Monorepo

[clang] 7eb0466 - Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-18 Thread Yuki Okushi via cfe-commits
Author: Yuki Okushi Date: 2022-06-18T23:48:30+09:00 New Revision: 7eb046624f2a35f32f0821c91ad5c6a26f250e5f URL: https://github.com/llvm/llvm-project/commit/7eb046624f2a35f32f0821c91ad5c6a26f250e5f DIFF: https://github.com/llvm/llvm-project/commit/7eb046624f2a35f32f0821c91ad5c6a26f250e5f.diff

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-18 Thread Yuki Okushi via Phabricator via cfe-commits
JohnTitor added a comment. Alright, let's go ahead then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127509/new/ https://reviews.llvm.org/D127509 ___ cfe-commits mailing list

[PATCH] D128120: [Clang][VE] Add missing intrinsics

2022-06-18 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: efocht, simoll. kaz7 added projects: clang, VE. Herald added a project: All. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Add missing intrinsics and tests for them. An expanding macro from _vel_pack_f32p to

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

2022-06-18 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 438118. mizvekov added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

2022-06-18 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 438117. mizvekov edited the summary of this revision. mizvekov added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/

[clang] cd64a42 - Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder"

2022-06-18 Thread Jun Zhang via cfe-commits
Author: Jun Zhang Date: 2022-06-18T20:27:21+08:00 New Revision: cd64a427efa0baaf1bb7ae624d4301908afc07f7 URL: https://github.com/llvm/llvm-project/commit/cd64a427efa0baaf1bb7ae624d4301908afc07f7 DIFF: https://github.com/llvm/llvm-project/commit/cd64a427efa0baaf1bb7ae624d4301908afc07f7.diff

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

2022-06-18 Thread serge via Phabricator via cfe-commits
serge-sans-paille updated this revision to Diff 438114. serge-sans-paille added a comment. (rebased on main branch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119 Files: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

2022-06-18 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. I"m not 100% sure of the fix but it fixes bug #55560 and does not introduce regression :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

2022-06-18 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, tbaeder. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix #55560 Repository: rG LLVM Github

[PATCH] D128064: [Static Analyzer] Small array binding policy

2022-06-18 Thread Domján Dániel via Phabricator via cfe-commits
isuckatcs added a comment. What's out desired approach for that? Create a new patch, or update this one? Also, should I commit it as usual, or revert this commit first? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128064/new/

[PATCH] D128116: [clang][docs] Sync generated command line doc with td files.

2022-06-18 Thread Pavel Iliin via Phabricator via cfe-commits
ilinpv created this revision. ilinpv added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. ilinpv requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It seems auto-generated

[clang] 6e070c3 - [NFC] Specifing clang namespace for builtins.

2022-06-18 Thread Pavel Iliin via cfe-commits
Author: Pavel Iliin Date: 2022-06-18T10:44:25+01:00 New Revision: 6e070c3c9101ac7b7a3736021bff98e9a1f5a362 URL: https://github.com/llvm/llvm-project/commit/6e070c3c9101ac7b7a3736021bff98e9a1f5a362 DIFF: https://github.com/llvm/llvm-project/commit/6e070c3c9101ac7b7a3736021bff98e9a1f5a362.diff

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

2022-06-18 Thread Matthew Smith via Phabricator via cfe-commits
asymptotically updated this revision to Diff 438106. asymptotically added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Updated users' manual following Arfrever's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/

[PATCH] D127207: [flang][driver] Fix support for `-x`

2022-06-18 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. In D127207#3593665 , @sunho wrote: > Hi! I'm not exactly sure what's going on. But, seems like build is failing > here? https://lab.llvm.org/buildbot/#/builders/177/builds/5571 Thanks for flagging this up! I am also rather

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

2022-06-18 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder accepted this revision. tbaeder added a comment. This revision is now accepted and ready to land. Those are all libomp tests, I doubt they are related. I think it's fine to just push this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION