[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135707/new/ https://reviews.llvm.org/D135707

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

phosek added a comment. This is just a nit, but I'd avoid extra formatting such as using `|` for separators and instead use just spaces and alignment akin to https://github.com/ClangBuiltLinux/frame-larger-than (or `llvm-readelf`) since that output tends to be easier to parse with tools like

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie added a comment. In D135326#3851672 , @dblaikie wrote: > (abandoned this, but still kind of curious) > > @rjmccall - any background/history of having the CXXABI distinct from the OS? > I guess the point might've been that the C ABI is part

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie added a subscriber: rjmccall. dblaikie added a comment. (abandoned this, but still kind of curious) @rjmccall - any background/history of having the CXXABI distinct from the OS? I guess the point might've been that the C ABI is part of/the definition of the OS, but maybe the CXX ABI

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 467024. dblaikie added a comment. Add doc comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3ce1339264d: [clang] Do not override libclang.sos SOVERSION if… (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d3ce133 - [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

Author: Michał Górny Date: 2022-10-12T07:14:28+02:00 New Revision: d3ce1339264dff3ea5571e9d5cf53d41e49a0879 URL: https://github.com/llvm/llvm-project/commit/d3ce1339264dff3ea5571e9d5cf53d41e49a0879 DIFF: https://github.com/llvm/llvm-project/commit/d3ce1339264dff3ea5571e9d5cf53d41e49a0879.diff

[PATCH] D135384: [AIX] Enable the use of the -pg flag

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:38-40 +const Twine targetTwine(M.getTargetTriple()); +Triple targetTriple(targetTwine); +if (targetTriple.isOSAIX()) { A `Twine` can be

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

mgorny added a comment. In D135701#3850251 , @MaskRay wrote: > I don't understand this well, though. Is `CLANG_VERSION_MAJOR` wrong or not > defined in some cases? It's about `LLVM_VERSION_SUFFIX`. Normally, `SOVERSION` for all libraries is

[PATCH] D135091: Fix assert in generated `direct` property getter/setters due to removal of `_cmd` parameter.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fbb6d8b34de: Fix assert in generated `direct` property getter/setters due to removal of… (authored by mwyman). Repository: rG LLVM Github

[clang] 1fbb6d8 - Fix assert in generated `direct` property getter/setters due to removal of `_cmd` parameter.

Author: Michael Wyman Date: 2022-10-11T21:15:53-07:00 New Revision: 1fbb6d8b34dec217179d8e46d8c5d8e243047045 URL: https://github.com/llvm/llvm-project/commit/1fbb6d8b34dec217179d8e46d8c5d8e243047045 DIFF: https://github.com/llvm/llvm-project/commit/1fbb6d8b34dec217179d8e46d8c5d8e243047045.diff

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a reviewer: tschuett. ChuanqiXu added a comment. In D134267#3849629 , @dblaikie wrote: > To the original point I was making about implicit modules (which might've > been my own confusion due to the term being brought up in D134269 >

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

rjmccall added a comment. I think that's fair. I don't know how much concrete information we'll get about this in a short period of time, but it's worth trying to collect it. Was this change in LLVM 15, or is it still unreleased? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:327 +/// if the argument is smaller than a slot, set this flag will force +/// right-adjust the argument in its slot irrespective of the type. static Address emitVoidPtrDirectVAArg(CodeGenFunction

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

ChuanqiXu added a comment. > In the near future I was planning to add various Objective-C and Swift > attributes. For other attributes I don't know which are high-value. I > definitely want to check attributes affecting the memory layout (alignment, > packing) and believe I've addressed them

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

rjmccall added a reviewer: t.p.northover. rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5461 // Otherwise, just use the general rule. + // TODO: a better approach may refer to SystemZABI use same logic for caller Please add

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:852 +def err_module_odr_violation_attribute : Error< + "%q0 has different definitions in different modules; first difference is " + "%select{definition in module '%2'|defined here}1

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw abandoned this revision. sstwcw added a comment. I am closing it now there is D135740 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw added a project: clang-format. sstwcw added a comment. Should I add a test with comments to be aligned like in the bug report? I was not sure because I didn't find an existing test for alignment of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan, sammccall. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 2183fe2

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

kees added a comment. Change log typo? "but for all" should be "but not for all" ? Comment at: clang/lib/AST/Expr.cpp:223 // arrays to be treated as flexible-array-members, we still emit diagnostics // as if they are not. Pending further discussion... +if

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thanks for explaining. This LGTM, but you might want to get a second opinion. Comment at: clang/lib/AST/ODRDiagsEmitter.cpp:1660 + case TypeDef: + case Var: +

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 466992. tingwang added a comment. Address comment: move TODO close to PPC64 specific case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files:

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added a comment. In D18#3850091 , @rjmccall wrote: > This seems be to a genuine target difference, right? PPC64 has this ABI rule: > >> An aggregate or union smaller than one doubleword in size is padded so that >> it appears in the least

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen accepted this revision as: ychen. ychen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135045/new/ https://reviews.llvm.org/D135045

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai added a comment. In D135472#3844688 , @ChuanqiXu wrote: > I guess the reason why we didn't check odr violation for attributes is that > the attributes was not a part of declarations in C++ before. But it is odd to > skip the check for

[PATCH] D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

vsapsai added a comment. Thanks for the review! I'll wait for the blocking D130324 to land before I commit this change. I appreciate your speedy response. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3850667 , @hubert.reinterpretcast wrote: > In D128745#3834435 , @ychen wrote: > >> New flag or not, as long as we allow users to use the old behavior, it is >> already

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

vsapsai added a comment. In D130324#3843934 , @jansvoboda11 wrote: > Should we also update `ODRHash::isDeclToBeProcessed`? No, as `isDeclToBeProcessed` is only for sub-decls and protocols cannot be nested inside other entities. Looks like nested

[PATCH] D135730: Make inalloca lambda parameters work (for 32-bit windows).

akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug where inalloca arguments can't be used as parameters in non-capturing lambdas. Repository: rG LLVM

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

drodriguez created this revision. drodriguez added reviewers: bc-lee, MaskRay, arphaman. Herald added a subscriber: StephenFan. Herald added a project: All. drodriguez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D121868

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. Hi @mizvekov , after D135088 , this patch is ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue);

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7791 +/// functionDecl(isEffectivelyInline()) will match f(). +AST_MATCHER(FunctionDecl, isEffectivelyInline) { return Node.isInlined(); } + Is there any value in adding

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

void created this revision. void added reviewers: kees, serge-sans-paille, rsmith, efriedma. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang doesn't have the same behavior as GCC does with union

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings marked an inline comment as done. gracejennings added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 466964. gracejennings added a comment. Includng formatting update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/ https://reviews.llvm.org/D135721 Files: clang/include/clang/AST/ExprCXX.h

[PATCH] D135724: [HIP] Fix unbundling archive

yaxunl created this revision. yaxunl added reviewers: tra, saiislam. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. When `-lxxx` is specified, if there happens to have a directory or file with name `xxx`, clang will not look up

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi added a comment. @nikic, it seems to have recovered (http://llvm-compile-time-tracker.com/compare.php?from=c49cde6467f9bf200640db763152a9dc7f009520=0456acbfb942f127359a8defd1b4f1f44420df3e=instructions) let me know if you have concerns. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 466962. gracejennings added a comment. Formatting Added new line file ending Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/ https://reviews.llvm.org/D135721 Files:

[PATCH] D135721: [HLSL] Added HLSL this as a reference

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:179 +AST, SourceLocation(), +Constructor->getThisType().getTypePtr()->getPointeeType(), true); +This->setValueKind(ExprValueKind::VK_LValue); Should this

[PATCH] D135637: [clang][deps] Prevent emitting diagnostics outside of source file

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1c72302fe45: [clang][deps] Prevent emitting diagnostics outside of source file (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135720: [clang][deps] Remove more codegen options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG060b25346b95: [clang][deps] Remove more codegen options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c1c7230 - [clang][deps] Prevent emitting diagnostics outside of source file

Author: Jan Svoboda Date: 2022-10-11T15:57:20-07:00 New Revision: c1c72302fe4553a39be37b5c310d046975e55019 URL: https://github.com/llvm/llvm-project/commit/c1c72302fe4553a39be37b5c310d046975e55019 DIFF: https://github.com/llvm/llvm-project/commit/c1c72302fe4553a39be37b5c310d046975e55019.diff

[clang] 060b253 - [clang][deps] Remove more codegen options

Author: Jan Svoboda Date: 2022-10-11T15:57:19-07:00 New Revision: 060b25346b95cc161d21418f31c333f9a115d77e URL: https://github.com/llvm/llvm-project/commit/060b25346b95cc161d21418f31c333f9a115d77e DIFF: https://github.com/llvm/llvm-project/commit/060b25346b95cc161d21418f31c333f9a115d77e.diff

[PATCH] D135715: [Clang] Do not build the OffloadActionBuilder when using the new driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadf36ea32891: [Clang] Do not build the OffloadActionBuilder when using the new driver (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] adf36ea - [Clang] Do not build the OffloadActionBuilder when using the new driver

Author: Joseph Huber Date: 2022-10-11T17:46:20-05:00 New Revision: adf36ea328910ce019893b426aac044bab166e73 URL: https://github.com/llvm/llvm-project/commit/adf36ea328910ce019893b426aac044bab166e73 DIFF: https://github.com/llvm/llvm-project/commit/adf36ea328910ce019893b426aac044bab166e73.diff

[PATCH] D135721: [HLSL] Added HLSL this as a reference

beanz added a reviewer: aaron.ballman. beanz added a subscriber: aaron.ballman. beanz added a comment. Looping in @aaron.ballman here too because this is a bit of a fun one... I know Aaron loves when we show him the best of HLSL  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D135721: [HLSL] Added HLSL this as a reference

bob80905 added inline comments. Comment at: clang/test/AST/HLSL/this-reference.hlsl:62 +// CHECK-NEXT:`-ImplicitCastExpr 0x{{[0-9A-Fa-f]+}} 'Pair' lvalue +// CHECK-NEXT:`-CXXThisExpr 0x{{[0-9A-Fa-f]+}} 'PairInfo' lvalue implicit this One small nitpick I've

[PATCH] D135720: [clang][deps] Remove more codegen options

jansvoboda11 added a comment. In D135720#3850954 , @Bigcheese wrote: > lgtm. Although I wonder if long term we should add something to the option > tablegen file for this case? I think a good option would be to have a function that uses the information

[PATCH] D135720: [clang][deps] Remove more codegen options

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Although I wonder if long term we should add something to the option tablegen file for this case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135658: demangle OptFunction trace names

Trass3r updated this revision to Diff 466946. Trass3r added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135658/new/ https://reviews.llvm.org/D135658

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings created this revision. gracejennings added reviewers: python3kgae, beanz, pow2clk, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. gracejennings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D135720: [clang][deps] Remove more codegen options

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Codegen options are typically

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

ziqingluo-90 added reviewers: aaron.ballman, njames93, t-rasmud. ziqingluo-90 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersMacros.h:96 namespace internal { \ - class

[PATCH] D131858: [clang] Track the templated entity in type substitution.

davrec accepted this revision. davrec added a comment. Looks good, over to @ChuanqiXu Comment at: clang/include/clang/Sema/Template.h:80 +struct ArgumentListLevel { + Decl *AssociatedDecl; + ArgList Args; mizvekov wrote: > davrec wrote: > >

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

nickdesaulniers added a comment. Nice! Diff 466919 fixes up my confusion regarding Slot vs SlotID. Though I do like how the Slots are sorted, since it keeps the Offsets in order FWICT. Maybe we could drop the SlotID column, then print out Slot for the variables, rather than the SlotID? I

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

vitalybuka added a comment. It may help with some cases, but still does not guarantee that pointer will not survive in paddings or red-zones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135713/new/ https://reviews.llvm.org/D135713

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

leonardchan added a comment. In D135713#3850730 , @mcgrathr wrote: > I had imagined making lsan always do this since there's a specific > lsan-related rationale for it that applies to everybody. > I'm not clear on how cmake structures things and whether

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added a comment. In D129443#3847319 , @rymiel wrote: > Note that I didn't change the LLVM config, which right now is still set to > `Keyword`. We should change it back to `OuterScope`. Comment at:

[PATCH] D135715: [Clang] Do not build the OffloadActionBuilder when using the new driver

jhuber6 added a comment. Thanks for the quick review. Comment at: clang/lib/Driver/Driver.cpp:3987-3988 // required. if (!UseNewOffloadingDriver) - if (OffloadBuilder.addHostDependenceToDeviceActions(Current, InputArg)) + if

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added a comment. In D130096#3850708 , @b-sumner wrote: >> Different functions providing different behaviors can be handled at link >> time like any other function, instead of the same functions providing >> different behaviors per translation

[PATCH] D135715: [Clang] Do not build the OffloadActionBuilder when using the new driver

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3987-3988 // required. if (!UseNewOffloadingDriver) - if (OffloadBuilder.addHostDependenceToDeviceActions(Current,

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4045 +def HLSLGroupSharedAddressSpace : TypeAttr { + let Spellings = [Keyword<"groupshared">, Clang<"groupshared">]; + let Documentation = [HLSLGroupSharedAddressSpaceDocs];

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 466925. python3kgae marked 12 inline comments as done. python3kgae added a comment. Code cleanup to match comments. Reuse opencl error. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

Trass3r created this revision. Trass3r added a reviewer: ziqingluo-90. Herald added a project: All. Trass3r updated this revision to Diff 466881. Trass3r added a comment. Trass3r updated this revision to Diff 466882. Trass3r published this revision for review. Herald added a project: clang. Herald

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

BertalanD added a comment. In D126907#3849583 , @erichkeane wrote: > In D126907#3846591 , @erichkeane > wrote: > >> In D126907#3844788 , @BertalanD >> wrote: >> >>> Hi

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert marked 5 inline comments as done. aaronpuchert added a comment. @hans, where you able to fix or work around the warnings? I'd like to land this again, but if you need more time it can also wait a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

mcgrathr added a comment. I had imagined making lsan always do this since there's a specific lsan-related rationale for it that applies to everybody. I'm not clear on how cmake structures things and whether sanitizer_common would have to do it unconditionally since it's used by lsan code.

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert updated this revision to Diff 466923. aaronpuchert added a comment. Add sentence to release notes that we now look into more constructor calls and that this could lead to additional warnings being emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135416: [clang][deps] Respect VFS overlays in canonical preprocessing mode

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Ah, I hit the same thing recently, thanks. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135416/new/

[PATCH] D135715: [Clang] Do not build the OffloadActionBuilder when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The Offloading toolchain currently has two

[PATCH] D135637: [clang][deps] Prevent emitting diagnostics outside of source file

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135637/new/ https://reviews.llvm.org/D135637

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

b-sumner added a comment. > Different functions providing different behaviors can be handled at link time > like any other function, instead of the same functions providing different > behaviors per translation unit and requires cloning. The current scheme > transfers complexity from the

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. In D130096#3850628 , @arsenm wrote: > In D130096#3850550 , @b-sumner > wrote: > >> There's the "small matter" of implementing the new device library functions. >> Why is all that more

[PATCH] D135657: add time traces for AST serialization

Trass3r updated this revision to Diff 466921. Trass3r retitled this revision from "add time traces for loading PCH files" to "add time traces for AST serialization". Trass3r edited the summary of this revision. Trass3r added a reviewer: jansvoboda11. Trass3r added a comment. rebased

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth updated this revision to Diff 466919. paulkirth added a comment. Add SlotID to output Improve some initialization Still need to do significant code cleanup and testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/

[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

jansvoboda11 updated this revision to Diff 466918. jansvoboda11 added a comment. Rebase, update test description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135636/new/ https://reviews.llvm.org/D135636 Files:

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

hubert.reinterpretcast added a comment. In D128745#3834435 , @ychen wrote: > New flag or not, as long as we allow users to use the old behavior, it is > already fracturing the ecosystem. Do you mean (1) we shouldn't give the user > the choices or (2)

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

jansvoboda11 updated this revision to Diff 466911. jansvoboda11 added a comment. Use `ArrayRef`, `move` VFS smart pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135634/new/ https://reviews.llvm.org/D135634 Files:

[clang] 1079662 - [clang][codegen] Don't emit atomic loads for threadsafe init if they aren't inline

Author: Eli Friedman Date: 2022-10-11T14:00:33-07:00 New Revision: 1079662d2fff7ae799503d910b299c5108d105fd URL: https://github.com/llvm/llvm-project/commit/1079662d2fff7ae799503d910b299c5108d105fd DIFF: https://github.com/llvm/llvm-project/commit/1079662d2fff7ae799503d910b299c5108d105fd.diff

[PATCH] D135628: [clang][codegen] Don't emit atomic loads for threadsafe init if they aren't inline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1079662d2fff: [clang][codegen] Dont emit atomic loads for threadsafe init if they arent… (authored by efriedma). Repository: rG LLVM Github

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. This might allow lsan to find more leaks that would have gone

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added a comment. In D130096#3850550 , @b-sumner wrote: > There's the "small matter" of implementing the new device library functions. > Why is all that more likeable than two kinds of control constants? Different functions providing different

[PATCH] D135636: [clang][modules][deps] Serialize inputs into PCMs using the "as requested" name

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135636/new/ https://reviews.llvm.org/D135636

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

jansvoboda11 added a comment. In D135634#3850224 , @akyrtzi wrote: > This seems fine to me but note that we no longer depend on the functionality > that `test/Index/index-module-with-vfs.m` is testing (and not sure anyone > else does), so if there is

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

steven_wu created this revision. steven_wu added reviewers: sammccall, akyrtzi, rymiel. Herald added subscribers: ributzka, kadircet, arphaman. Herald added a project: All. steven_wu requested review of this revision. Herald added projects: LLVM, clang-tools-extra. Herald added a subscriber:

[PATCH] D135490: [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused-variable` diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG0456acbfb942: [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0456acb - [clang/Sema] Follow-up for fix of non-deterministic order of `-Wunused-variable` diagnostic

Author: Argyrios Kyrtzidis Date: 2022-10-11T13:39:26-07:00 New Revision: 0456acbfb942f127359a8defd1b4f1f44420df3e URL: https://github.com/llvm/llvm-project/commit/0456acbfb942f127359a8defd1b4f1f44420df3e DIFF:

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

b-sumner added a comment. In D130096#3850473 , @arsenm wrote: > In D130096#3850472 , @jhuber6 wrote: > >> I don't like the fact that we need to have two different kinds of control >> constants, one per-TU and

[clang] c49cde6 - [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

Author: Michele Scandale Date: 2022-10-11T13:29:20-07:00 New Revision: c49cde6467f9bf200640db763152a9dc7f009520 URL: https://github.com/llvm/llvm-project/commit/c49cde6467f9bf200640db763152a9dc7f009520 DIFF:

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc49cde6467f9: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case. (authored by michele.scandale). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

dblaikie added a subscriber: rnk. dblaikie added a comment. In D135551#3850391 , @aaron.ballman wrote: > In D135551#3850308 , @dblaikie > wrote: > >> In D135551#3850266

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

arsenm added a comment. In D130096#3850472 , @jhuber6 wrote: > I don't like the fact that we need to have two different kinds of control > constants, one per-TU and others per-link job. I'm wondering how difficult it > would be to make the fast

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added a comment. I don't like the fact that we need to have two different kinds of control constants, one per-TU and others per-link job. I'm wondering how difficult it would be to make the fast versions of the math calls use different entry points. That way we could handle this in the

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

MaskRay updated this revision to Diff 466891. MaskRay marked an inline comment as done. MaskRay added a comment. Don't test SOURCE_DATE_EPOCH=253402300799 on Windows (which only supports upto 32536850399) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131698: [Sema] Fix `ExtVectorElementExpr` tree transform for the `isArrow` case.

michele.scandale added a comment. In D131698#3848469 , @michele.scandale wrote: > @rjmccall would you be able to land this on my behalf? Thanks in advance. I got commit access. I will take care of landing the change. Thanks anyway. Repository: rG

[clang] f83347b - [TokenLexer][NFC] Rename the InstLoc to ExpandLoc

Author: Haojian Wu Date: 2022-10-11T21:34:22+02:00 New Revision: f83347b0bedb22ea676861c8e4e2ed9c31371ade URL: https://github.com/llvm/llvm-project/commit/f83347b0bedb22ea676861c8e4e2ed9c31371ade DIFF: https://github.com/llvm/llvm-project/commit/f83347b0bedb22ea676861c8e4e2ed9c31371ade.diff

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Inside the arguments part of a function

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

aaron.ballman added a comment. In D135551#3850308 , @dblaikie wrote: > In D135551#3850266 , @inclyc wrote: > >> This makes sense! However I think `assert(0)` should not be used in this >> case, we could expose

  1   2   3   >