[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman abandoned this revision. MosheBerman added a comment. In the interest of not leaving detritus on the internet, I'm going to abandon this diff. I believe there's an alternate approach worth pursuing, with clang tidy. Thanks for your reviews and constructive feedback! Repository:

[PATCH] D137054: [X86][Driver] Remove stale FIXME. NFC

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137054/new/ https://reviews.llvm.org/D137054

[PATCH] D136951: [clangd] Populate ranges and symbol origin for paramname completions

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGda5ded4fc9d8: [clangd] Populate ranges and symbol origin for paramname completions (authored by kadircet). Changed prior to commit:

[clang-tools-extra] da5ded4 - [clangd] Populate ranges and symbol origin for paramname completions

Author: Kadir Cetinkaya Date: 2022-10-31T11:34:06+01:00 New Revision: da5ded4fc9d8c8edfd4a79fa0e75c2ac9165fa7b URL: https://github.com/llvm/llvm-project/commit/da5ded4fc9d8c8edfd4a79fa0e75c2ac9165fa7b DIFF:

[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:212 +log("Building semantic highlighting"); +getSemanticHighlightings(*AST); + } can you also vlog the highlights, while limitting the output to ranges that intersect

[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rG1258747a59db: [clangd] Fix a semantic-highlighting crash. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D137064?vs=471930=471947#toc

[clang-tools-extra] 1258747 - [clangd] Fix a semantic-highlighting crash.

Author: Haojian Wu Date: 2022-10-31T11:19:01+01:00 New Revision: 1258747a59db5200112fca7c6140d184f3b8748e URL: https://github.com/llvm/llvm-project/commit/1258747a59db5200112fca7c6140d184f3b8748e DIFF: https://github.com/llvm/llvm-project/commit/1258747a59db5200112fca7c6140d184f3b8748e.diff

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb created this revision. krisb added reviewers: ellis, aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. krisb requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Having AllEnumtypes to

[PATCH] D136071: [include-cleaner] Add PragmaIncludes which handles include-mapping pragmas.

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:41 +// spelling header rather than the header directly defines the symbol. +class PragmaIncludes { +public: hokein wrote: > kadircet wrote: > >

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:1254 +HelpText<"Use profi to infer block and edge counts.">, +DocBrief<[{Profi - a flow-based profile inference algorithm is an extended + and significantly re-engineered classic

[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:664 bool VisitCXXMemberCallExpr(CXXMemberCallExpr *CE) { -if (isa(CE->getMethodDecl())) { +

[PATCH] D136951: [clangd] Populate ranges and symbol origin for paramname completions

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2019 + // Point back to cursor location. + Offset += 2; + CompletionRange.start =

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/test/system-include-extractor.test:14-17 +# The purpose of the three lines below is to test that the -nostdinc etc. +#

[PATCH] D135937: [WIP][X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 471938. FreddyYe marked an inline comment as done. FreddyYe added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 Files:

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:41 +// spelling header rather than the header directly defines the symbol. +class PragmaIncludes { +public: kadircet wrote: > i think this

[PATCH] D136071: [include-cleaner] WIP: Add PragmaIncludes which handles include-mapping pragmas.

hokein updated this revision to Diff 471936. hokein marked 6 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136071/new/ https://reviews.llvm.org/D136071 Files:

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

kadircet added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. egorzhdan wrote: > kadircet wrote: > > i don't follow the reason

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) FreddyYe wrote: > pengfei wrote: > > pengfei wrote: > > > RKSimon wrote: > > > > Is

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added inline comments. Comment at: clang-tools-extra/clangd/test/system-include-extractor.test:82 + +# Skip past the lack of diagnostics in the workspace and user config files... +# CHECK2: "method": "textDocument/publishDiagnostics", Ugh, this doesn't

[PATCH] D137064: [clangd] Fix a semantic-highlighting crash.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D133756: [clangd] Pass the entire tooling::CompileCommand to CommandMangler

nridge added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: sammccall wrote: > nridge wrote: > > sammccall

[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Allowing us to test this

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

nridge added a comment. I believe this addresses the remaining review comments. I will follow up with a patch to rename QueryDriverDatabase.{h,cpp} to SystemIncludeExtractor,{h,cpp}. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:318 /// compilation database.

[PATCH] D133757: [clangd] Turn QueryDriverDatabase into a CompileCommandsAdjuster

nridge updated this revision to Diff 471925. nridge added a comment. reformulate test as lit test address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757 Files:

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 added a comment. After digging more deeply into tests, I found that if we decide to make clang include `stdc-predef.h` or other things, the behavior of many libtooling-related tools (e.g. clang-tidy, clangd, and python binding) will be affected. For example,

[clang] fd3d7a9 - Handle errors in expansion of response files

Author: Serge Pavlov Date: 2022-10-31T15:36:41+07:00 New Revision: fd3d7a9f8cbb5ad81fb96d92d5f7b1d51a4d4127 URL: https://github.com/llvm/llvm-project/commit/fd3d7a9f8cbb5ad81fb96d92d5f7b1d51a4d4127 DIFF: https://github.com/llvm/llvm-project/commit/fd3d7a9f8cbb5ad81fb96d92d5f7b1d51a4d4127.diff

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) pengfei wrote: > pengfei wrote: > >

[PATCH] D136554: Implement CWG2631

ChuanqiXu added a comment. The serialization part looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 ___ cfe-commits mailing list

[PATCH] D136221: [docs] Add the description about mixing use of clang modules and c++ modules

This revision was automatically updated to reflect the committed changes. Closed by commit rGe12b627a35ee: [docs] Add the description about mixing use of clang modules and c++ (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] e12b627 - [docs] Add the description about mixing use of clang modules and c++

Author: Chuanqi Xu Date: 2022-10-31T16:02:43+08:00 New Revision: e12b627a35ee41e2bee069bf871c8b779f4d4e35 URL: https://github.com/llvm/llvm-project/commit/e12b627a35ee41e2bee069bf871c8b779f4d4e35 DIFF: https://github.com/llvm/llvm-project/commit/e12b627a35ee41e2bee069bf871c8b779f4d4e35.diff

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3892629 , @ben.boeckel wrote: > In D134267#3876071 , @dblaikie > wrote: > >> I'm getting a bit exhausted with all the words involved here & not sure how >> to

[PATCH] D137036: [X86] Enable EVEX GFNI instructions without avx512bw.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/avx512-gfni-intrinsics.ll:29 +; +; X86NOBW-LABEL: test_vgf2p8affineinvqb_128: +; X86NOBW: # %bb.0: pengfei wrote: > Since we are able to lower the mask version intrinsics, we have 3

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file

ChuanqiXu created this revision. ChuanqiXu added reviewers: dblaikie, ben.boeckel, iains, tschuett. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[clang] 21bac59 - Fix unused-variable warning in release build, NFC

Author: Haojian Wu Date: 2022-10-31T08:53:30+01:00 New Revision: 21bac595041d46d9882fb930a4467055b99ffa0a URL: https://github.com/llvm/llvm-project/commit/21bac595041d46d9882fb930a4467055b99ffa0a DIFF: https://github.com/llvm/llvm-project/commit/21bac595041d46d9882fb930a4467055b99ffa0a.diff

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

ChuanqiXu created this revision. ChuanqiXu added reviewers: dblaikie, ben.boeckel, iains, tschuett. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

chapuni added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1310 +const auto *FD2 = dyn_cast(D2); +assert(IsExpectedEntity(FD1) && FD2 && IsExpectedEntity(FD2) && + "use non-instantiated function declaration for constraints partial "

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

nridge updated this revision to Diff 471909. nridge added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137056/new/ https://reviews.llvm.org/D137056 Files: clang-tools-extra/clangd/test/system-include-extractor.test Index:

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

nridge updated this revision to Diff 471908. nridge added a comment. format comment better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137056/new/ https://reviews.llvm.org/D137056 Files:

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

nridge created this revision. nridge added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Also add an

[PATCH] D137036: [X86] Enable EVEX GFNI instructions without avx512bw.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch! Comment at: llvm/test/CodeGen/X86/avx512-gfni-intrinsics.ll:29 +; +; X86NOBW-LABEL: test_vgf2p8affineinvqb_128: +; X86NOBW: # %bb.0:

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder updated this revision to Diff 471906. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:803 + // Make sure we don't accidentally register the same decl twice. + if (const Decl *VD = Src.dyn_cast(); VD && isa(VD)) { +assert(!P.getGlobal(cast(VD))); shafik

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder updated this revision to Diff 471905. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

<    1   2   3