[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5056-5059 + "if (A) { \\\n" + "B(); \\\n" + "}\\\n" + "C();\n" goldstein.w.n

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. With `ColumnLimit: 16` and `IndentPPDirectives: BeforeHash`, the format should be: #ifdef foo #define bar() \ if (A) { \ B(); \ } \ C(); #endif With `IndentPPDirectives: AfterHash`, it should look like: #ifdef foo #

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

jyu2 created this revision. jyu2 added reviewers: abhinavgaba, ABataev, mikerice. jyu2 added a project: OpenMP. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

jansvoboda11 added a comment. I'm not sure about that. The failing test isn't using modules and it has failed with the same error before: https://lab.llvm.org/buildbot/#/builders/237/builds/345 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

MaskRay added a comment. Herald added a subscriber: Moerafaat. > We held off on this before as `LLVM_LIBDIR_SUFFIX` conflicted with it. Now we > return this. > > I imagine this is too potentially-breaking to make LLVM 15. That's fine. ... These sentences are no longer relevant and should be

[PATCH] D137287: [Test] Fix CHECK typo.

zequanwu updated this revision to Diff 472833. zequanwu added a comment. Herald added subscribers: lldb-commits, nemanjai. Herald added projects: LLDB, clang-tools-extra, Flang. Fix more typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3902564 , @ben.boeckel wrote: > I tried applying this patch to your MyP1689 branch (fixing conflicts with > attempts there), but it seems that something isn't being plumbed properly: > > clang-15: error: unknown

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ChuanqiXu added a comment. In D137059#3899339 , @ben.boeckel wrote: > There is another motivating factor for 1-phase: the build graph is far > simpler. With 2-phase, CMake will have to write out rules to perform: > > - source -> .bmi > - .bmi ->

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

MaskRay abandoned this revision. MaskRay added a comment. Herald added subscribers: Enna1, jeroen.dobbelaere, StephenFan. Herald added a project: All. Obsoleted by D137227 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ada819c237b: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows (authored by MaskRay). Repository: rG LLVM Github Monorepo

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

MaskRay updated this revision to Diff 472827. MaskRay marked 2 inline comments as done. MaskRay added a comment. address comments Thanks for the quick review:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137227/new/

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5056-5059 + "if (A) { \\\n" + "B(); \\\n" + "}\\\n" + "C();\n" owenpan

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. In D137263#3904184 , @MaskRay wrote: > The summary and comments use Markdown. You comment is currently formatted > strangely because you did not use fenced code blocks :) > (The commit message does not necessarily use

[PATCH] D137309: [clang] Added Swift support for RISCV64

colemancda created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator for non-Windows

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:777 // Enable aliases as they should have no downside with ODR indicators. -UsePrivateAlias(UseOdrIndicator || ClUsePrivateAlias), -

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

MaskRay added a comment. The summary and comments use MarkDown. You comment is currently formatted strangely because you did not use fenced code blocks :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137263/new/ https://reviews.llvm.org/D137263

[PATCH] D137304: [clang] Store filename per include instead of mutating filename

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:135-139 /// References the file which the contents were actually loaded from. /// /// Can be different from 'Entry' if we overridden the contents of one file /// with the contents

[PATCH] D136811: WIP: RFC: NFC: C++ Buffer Hardening user documentation.

xazax.hun added inline comments. Comment at: clang/docs/SafeBuffers.rst:31 +convert large amounts of old code to conform to the warning; + - Attribute ``[[unsafe_buffer_usage]]`` lets you annotate custom functions as +unsafe, while providing a safe alternative that can

[PATCH] D137304: [clang] Store filename per include instead of mutating filename

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:261-263 + /// FIXME: Make non-optional using a virtual file as needed, remove \c + /// Filename and use \c OrigEntry.getNameAsRequested() instead. +

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5056-5059 + "if (A) { \\\n" + "B(); \\\n" + "}\\\n" + "C();\n" I just noticed

[PATCH] D137308: [clang-format][NFC] Remove parsePPElIf()

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12940-12941 .Case(STR, {2u, static_cast(llvm::X86::ENUM)}) +#define X86_CPU_SUBTYPE_ALIAS(ENUM, STR) \ + .Case(STR, {2u, static_cast(llvm::X86::ENUM)})

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 472822. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 Files:

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

vitalybuka added subscribers: fmayer, vitalybuka. vitalybuka added a comment. FYI @fmayer Probably this patch https://lab.llvm.org/buildbot/#/builders/237/builds/350/steps/13/logs/stdio -- Testing: 66920 tests, 48 workers -- Testing: 0.. 10.. 20 FAIL: Clang ::

[PATCH] D137304: [clang] Store filename per include instead of mutating filename

benlangmuir added a comment. Thanks for the timely review! > the DenseMaps that need this unique-by-FileEntry* behaviour should probably > be the ones using a custom DenseMapInfo. Yeah, that's the way I'm currently leaning. Make the default for `DenseMap` and `==` be path equality and have a

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

zhouyizhou added a comment. In D137263#3903845 , @rjmccall wrote: > Good catch! Easy to see how this escaped notice for a decade, but still, > it'll be good to fix. > > LGTM with a minor improvement. Thank John for your encouragement and guidance! I

[PATCH] D137304: [clang] Store filename per include instead of mutating filename

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:652-662 + llvm::DenseMap + NamedFileInfos; + /// Memoized information about all of the files tracked by this /// SourceManager. /// It feels expensive to have

[PATCH] D137304: [clang] Store filename per include instead of mutating filename

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:135-139 /// References the file which the contents were actually loaded from. /// /// Can be different from 'Entry' if we overridden the contents of one file /// with the contents

[PATCH] D137304: [clang] Store filename per include instead of mutating filename

dexonsmith added a comment. > Consider making the FileEntryRef changes here the default -- it doesn't make > sense to me that FileEntryRef == or DenseMap would match FileEntry pointer > semantics instead of filename semantics. Yeah, that was something I added, and I agree it's unfortunate /

[PATCH] D137289: [Driver] Don't preprocess source files when reproducing linker crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rG78ed64d89fd6: [Driver] Dont preprocess source files when reproducing linker crashes (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] 78ed64d - [Driver] Don't preprocess source files when reproducing linker crashes

Author: Alex Brachet Date: 2022-11-03T00:12:10Z New Revision: 78ed64d89fd6ea348a963516a2e49028e4079f65 URL: https://github.com/llvm/llvm-project/commit/78ed64d89fd6ea348a963516a2e49028e4079f65 DIFF: https://github.com/llvm/llvm-project/commit/78ed64d89fd6ea348a963516a2e49028e4079f65.diff LOG:

[PATCH] D137304: [clang] Store filename per include instead of mutating filename

benlangmuir created this revision. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When including a header, store the filename per include (per FileInfo) rather than storing it once in the

[PATCH] D137303: [clang] Move accessors for OrigEntry and Filename to FileInfo NFC

benlangmuir created this revision. Herald added subscribers: arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor ContentCache::OrigEntry and

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:121 + + Converts standard library type traits of the form `traits<...>::type` and + `traits<...>::value` into `traits_t<...>` and `traits_v<...>` respectively. Please use

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thesamesam updated this revision to Diff 472807. thesamesam added a comment. Use PARENT_SCOPE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136283/new/ https://reviews.llvm.org/D136283 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG40e99473170f: [Clang] follow-up D128745, remove ClangABICompat checks (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/

[clang] 40e9947 - [Clang] follow-up D128745, remove ClangABICompat checks

Author: Yuanfang Chen Date: 2022-11-02T16:33:10-07:00 New Revision: 40e99473170f5045e0b5f2cafabd2a1be8c7ec26 URL: https://github.com/llvm/llvm-project/commit/40e99473170f5045e0b5f2cafabd2a1be8c7ec26 DIFF: https://github.com/llvm/llvm-project/commit/40e99473170f5045e0b5f2cafabd2a1be8c7ec26.diff

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

thakis added a comment. We're happy to switch to any setup that allows us to do a bootstrap build of clang on macOS (ie one where we build clang with whatever host compiler, and then build it again with just-built clang). We've switched to the currently recommended method several times; if

[PATCH] D137263: add boundary check for ASTUnresolvedSet::erase

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Good catch! Easy to see how this escaped notice for a decade, but still, it'll be good to fix. LGTM with a minor improvement. Comment at:

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType());

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings marked an inline comment as done. gracejennings added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:1158-1161 + static CXXThisExpr *Create(const ASTContext , SourceLocation Loc, + QualType Ty, bool IsImplicit) { +

[PATCH] D135721: [HLSL] Added HLSL this as a reference

gracejennings updated this revision to Diff 472791. gracejennings marked an inline comment as done. gracejennings added a comment. - Add codegen test and fix member implicit this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135721/new/

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

rnk added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType()); +

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3590-3593 + getTarget().getCXXABI().isMicrosoft() && + llvm::any_of(cast(FD)->parameters(), [&](ParmVarDecl *P) { +return isInAllocaArgument(getCXXABI(), P->getType());

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:3064 +if (I.getName().equals("this")) { + VMap[] = llvm::PoisonValue::get(I.getType()); +} else { Let's use getNullValue instead, just to avoid any complications for msan or

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. The changes in this patch look good to me. I talked to @andrew.w.kaylor offline: I was thinking that it might be necessary to make the two driver changes we talked about, before merging this patch. But if the tests pass then I think it's okay to implement the driver

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

abrachet added a comment. In D120175#3902838 , @thakis wrote: > Great, thanks :) > > For context, we're trying to use this flag In Production to try and debug a > linker crash, but making the compiler repro failed for some reason – and then > we

[clang] ea64e66 - [OPENMP]Initial support for error directive.

Author: Jennifer Yu Date: 2022-11-02T14:25:28-07:00 New Revision: ea64e66f7b71dfd52e9701a080b8216052344962 URL: https://github.com/llvm/llvm-project/commit/ea64e66f7b71dfd52e9701a080b8216052344962 DIFF: https://github.com/llvm/llvm-project/commit/ea64e66f7b71dfd52e9701a080b8216052344962.diff

[PATCH] D137209: [OPENMP]Initial support for error directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rGea64e66f7b71: [OPENMP]Initial support for error directive. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137209/new/

[PATCH] D136811: WIP: RFC: NFC: C++ Buffer Hardening user documentation.

jkorous added a comment. Thank you for the feedback Aaron! We really appreciate the effort you put into this! Comment at: clang/docs/SafeBuffers.rst:69-70 +containers such as ``std::span``, you can achieve bounds safety by +*simply writing good modern C++ code*. This is what

[PATCH] D137287: [Test] Fix CHECK typo.

zequanwu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, pmatos, asb, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:107-111 +if (const auto *BD = dyn_cast(Decl)) + VD = dyn_cast_if_present(BD->getDecomposedDecl()); +else + VD = dyn_cast(Decl); +if (VD) { aaron.ballman wrote: >

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n marked an inline comment as done. goldstein.w.n added a comment. In D137181#3899874 , @MyDeveloperDay wrote: > This needs a unit test in clang/unittest/Format Fixed in V2 I think but not sure as the summary doesn't seem to have changed.

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 472761. akhuang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 472759. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. If there's nothing else to add wrt telling people what's changed, I think this looks good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

aemerson updated this revision to Diff 472753. aemerson added a comment. Add a clang release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https://reviews.llvm.org/D137269 Files: clang/docs/ReleaseNotes.rst

[PATCH] D137280: [RISCV] Prevent autovectorization using vscale with Zvl32b.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ad7ab89ef5: [RISCV] Prevent autovectorization using vscale with Zvl32b. (authored by craig.topper). Repository: rG LLVM Github Monorepo

[clang] b6ad7ab - [RISCV] Prevent autovectorization using vscale with Zvl32b.

Author: Craig Topper Date: 2022-11-02T13:55:21-07:00 New Revision: b6ad7ab89ef5e1772e90248ee728fd955089c949 URL: https://github.com/llvm/llvm-project/commit/b6ad7ab89ef5e1772e90248ee728fd955089c949 DIFF: https://github.com/llvm/llvm-project/commit/b6ad7ab89ef5e1772e90248ee728fd955089c949.diff

[clang] f4be5ed - [clang][pp] only __is_target_environment(unknown) should match unknown target triple environment

Author: Alex Lorenz Date: 2022-11-02T13:49:04-07:00 New Revision: f4be5ed6a3fef0b2b0c60b29e1c0638926638d28 URL: https://github.com/llvm/llvm-project/commit/f4be5ed6a3fef0b2b0c60b29e1c0638926638d28 DIFF: https://github.com/llvm/llvm-project/commit/f4be5ed6a3fef0b2b0c60b29e1c0638926638d28.diff

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG117d792f35e6: [clang-format] Dont skip #else/#elif of #if 0 (authored by owenpan). Changed prior to commit:

[clang] 117d792 - [clang-format] Don't skip #else/#elif of #if 0

Author: Owen Pan Date: 2022-11-02T13:32:08-07:00 New Revision: 117d792f35e6f84f2f29183408284c7e1cc838e7 URL: https://github.com/llvm/llvm-project/commit/117d792f35e6f84f2f29183408284c7e1cc838e7 DIFF: https://github.com/llvm/llvm-project/commit/117d792f35e6f84f2f29183408284c7e1cc838e7.diff

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhuber6 added a comment. Is this good to land now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136796/new/ https://reviews.llvm.org/D136796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137180: [LinkerWrapper] report on missing libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9ee2acc9c5c: [LinkerWrapper] report on missing libraries (authored by jhuber6). Changed prior to commit:

[clang] b9ee2ac - [LinkerWrapper] report on missing libraries

Author: Joseph Huber Date: 2022-11-02T15:28:09-05:00 New Revision: b9ee2acc9c5c129bce5503dd8d2ab4757e42c990 URL: https://github.com/llvm/llvm-project/commit/b9ee2acc9c5c129bce5503dd8d2ab4757e42c990 DIFF: https://github.com/llvm/llvm-project/commit/b9ee2acc9c5c129bce5503dd8d2ab4757e42c990.diff

[PATCH] D137073: [clang] Fix inline builtin functions of an __asm__ renamed function with symbol prefixes

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b3834ef67e3: [clang] Fix inline builtin functions of an __asm__ renamed function with symbol… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9b3834e - [clang] Fix inline builtin functions of an __asm__ renamed function with symbol prefixes

Author: Martin Storsjö Date: 2022-11-02T22:24:42+02:00 New Revision: 9b3834ef67e3f320fe78dd63f6d5f1bafeafba78 URL: https://github.com/llvm/llvm-project/commit/9b3834ef67e3f320fe78dd63f6d5f1bafeafba78 DIFF:

[PATCH] D137180: [LinkerWrapper] report on missing libraries

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137180/new/ https://reviews.llvm.org/D137180

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5047 + style.IndentPPDirectives = FormatStyle::PPDIS_None; + verifyFormat("#ifdef foo\n" + "#define bar() \\\n" goldstein.w.n wrote: > owenpan wrote: > > Do you need

[PATCH] D137266: [RISCV] Move RVVBitsPerBlock to TargetParser.h so we can use it in clang. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6254495c6b4f: [RISCV] Move RVVBitsPerBlock to TargetParser.h so we can use it in clang. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6254495 - [RISCV] Move RVVBitsPerBlock to TargetParser.h so we can use it in clang. NFC

Author: Craig Topper Date: 2022-11-02T13:09:14-07:00 New Revision: 6254495c6b4f35ad862c9a5fc28720664d28d816 URL: https://github.com/llvm/llvm-project/commit/6254495c6b4f35ad862c9a5fc28720664d28d816 DIFF: https://github.com/llvm/llvm-project/commit/6254495c6b4f35ad862c9a5fc28720664d28d816.diff

[PATCH] D137280: [RISCV] Prevent autovectorization using vscale with Zvl32b.

craig.topper added a comment. In D137280#3903292 , @reames wrote: > LGTM > > I'm fine with this, but I thought we didn't support zve32f during compilation > at all right now? Is this the only issue which needs fixed. I think zve32f works fine with

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

hans accepted this revision. hans added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136846/new/ https://reviews.llvm.org/D136846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137275/new/ https://reviews.llvm.org/D137275

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as not done. v.g.vassilev added a comment. In D127284#3902487 , @aaron.ballman wrote: > It looks like precommit CI caught a relevant issue that should be addressed. Yes, I have a comment (starting with "The only

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a subscriber: akyrtzi. v.g.vassilev added inline comments. Comment at: clang/include/clang/Basic/DeclNodes.td:98 def FileScopeAsm : DeclNode; +def TopLevelStmt : DeclNode; def AccessSpec : DeclNode; aaron.ballman wrote: > Oh boy, that node

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 472731. v.g.vassilev marked 21 inline comments as done. v.g.vassilev added a comment. Address more comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files:

[PATCH] D137280: [RISCV] Prevent autovectorization using vscale with Zvl32b.

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM I'm fine with this, but I thought we didn't support zve32f during compilation at all right now? Is this the only issue which needs fixed. Repository: rG LLVM Github Monorepo

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

ychen updated this revision to Diff 472727. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/ https://reviews.llvm.org/D136120 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3903161 , @owenpan wrote: > Can you fix the format of the summary? I see the misindentation of the After/Before hash examples. Will fix those for V2. Anything else? Repository: rG LLVM Github Monorepo

[PATCH] D137240: [clang][Interp] Support alignof()

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:444 +// alignment of the referenced type. +if (const ReferenceType *Ref = ArgType->getAs()) + ArgType = Ref->getPointeeType(); You're missing the rest of

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5024 style); + verifyFormat("#if 1\n" owenpan wrote: > Don't add an empty line here. Will drop for V2. Comment at:

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

nickdesaulniers added a comment. In D136841#3893956 , @xen0n wrote: > Inching closer to ClangBuiltLinux on LoongArch it seems! Cool! Stay in touch when this is closer to working and we'll wire up support in CI to keep the build green. Repository:

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyOnLastUseCheck.h:1 +//===--- UnnecessaryCopyOnLastUseCheck.h - clang-tidy-*- C++-*-===// +// Sorry, overlooked last time. Please add space

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe marked 4 inline comments as done. Febbe added a comment. I applied the rest of your feedback. There are other usages of `auto` like `auto FoundUsage` which is a Usage for example. ~Shall I also replace those obvious cases?~ - I just checked the guidelines. Obvious cases can be auto.

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

tschuett added a comment. A release note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https://reviews.llvm.org/D137269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 472722. Febbe added a comment. Applied feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. Can you fix the format of the summary? Comment at: clang/unittests/Format/FormatTest.cpp:5024 style); + verifyFormat("#if 1\n" Don't add an empty line here. Comment at:

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn<

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3463a9f5cb0: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to… (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a3463a9 - [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

Author: Akash Banerjee Date: 2022-11-02T18:54:25Z New Revision: a3463a9f5cb0880357fd3e4c47ed4c2b09f0e6fc URL: https://github.com/llvm/llvm-project/commit/a3463a9f5cb0880357fd3e4c47ed4c2b09f0e6fc DIFF: https://github.com/llvm/llvm-project/commit/a3463a9f5cb0880357fd3e4c47ed4c2b09f0e6fc.diff

[PATCH] D137209: [OPENMP]Initial support for error directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137209/new/ https://reviews.llvm.org/D137209

[PATCH] D137280: [RISCV] Prevent autovectorization using vscale with Zvl32b.

craig.topper created this revision. craig.topper added reviewers: reames, frasercrmck, rogfer01, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D136936: [clang][Interp] Handle undefined functions better

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:30 if (!FuncDecl->isDefined(FuncDecl) || - (!FuncDecl->hasBody() && FuncDecl->willHaveBody())) -return nullptr; + (FuncDecl->hasBody() && FuncDecl->willHaveBody())) +

[clang-tools-extra] 990c189 - [clangd] Add scoped enum constants to all-scopes-completion

Author: Tom Praschan Date: 2022-11-02T20:38:01+01:00 New Revision: 990c189379679f92cd9af4cd384e476a94c0e819 URL: https://github.com/llvm/llvm-project/commit/990c189379679f92cd9af4cd384e476a94c0e819 DIFF: https://github.com/llvm/llvm-project/commit/990c189379679f92cd9af4cd384e476a94c0e819.diff

  1   2   >