[PATCH] D141463: [clang-tidy] Improve rename_check.py

carlosgalvezp added a comment. Thanks for the fix! Some minor comments/questions. Comment at: clang-tools-extra/clang-tidy/rename_check.py:75 print("Renaming '%s' -> '%s'..." % (fileName, newFileName)) - os.rename(fileName, newFileName) + subprocess.check_call(["git",

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter added a comment. I tested with https://reviews.llvm.org/D141133 where I renamed my new check, but noticed rename_tool.py did not rename or update the check name in the test file. The result of running the updated script against my tool is on github:

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre-vh abandoned this revision. Pierre-vh added a comment. Makes sense to abandon this given that D136919 exists Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139608/new/ https://reviews.llvm.org/D139608

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. rename_check.py now find

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EnumToIntCheck.cpp:31 + const auto *MatchedExpr = Result.Nodes.getNodeAs("x"); + diag(MatchedExpr->getBeginLoc(), "enum is implictly converted to an integral") + <<

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. If i'm reading this right, the change means we emit the same save-temps files as hip with the same naming convention. That sounds great, makes life easier for backend devs

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f75827fedb: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics (authored by eopXD). Changed prior to commit:

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 488085. ccotter added a comment. - Rename test to match check name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files:

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 488084. ccotter added a comment. - clang-format - Show whether 'this' is implicitly captured - fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files:

[PATCH] D141105: [OpenMP] Add support for '--offload-arch=native' to OpenMP offloading

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Looks reasonable to me. See comments though Comment at: clang/include/clang/Driver/Driver.h:488 + Action::OffloadKind Kind, const ToolChain *TC, +

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added inline comments. Comment at: clang/test/FixIt/fixit-const-var-init.cpp:24 + +template <> constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{24:42-24:42}:" = 0.0" aaron.ballman

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry updated this revision to Diff 488081. v1nh1shungry added a comment. implement `VarTemplateSpecializationDecl::getSourceRange()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 Files:

[PATCH] D141459: [RISCV] Use Zvl*b as a lower bound for VScaleRange.

craig.topper created this revision. craig.topper added reviewers: reames, frasercrmck, rogfer01, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, ctetreau, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4042351 , @Jake-Egan wrote: >> Would you like to take a double look? > > Yes, it still fails on the bot and on my local machine. I've added an XFAIL > to the test for now just to get the AIX bot green. Weird. Maybe

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:354 ^^^ +- Clang now supports implicit conversion warnings (-Wsign-conversion, + Wshorten-64-to-32, etc) for compound assignment operators (like +=, >=, etc)

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

MaskRay added inline comments. Comment at: libunwind/src/AddressSpace.hpp:249 const uint8_t *pend = (uint8_t *)end; - int64_t result = 0; + uint64_t result = 0; int bit = 0; Thanks. LGTM for this file. You can just fix libunwind in a separate commit so

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. > Would you like to take a double look? Yes, it still fails on the bot and on my local machine. I've added an XFAIL to the test for now just to get the AIX bot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141349: Remove the ThreadLocal template from LLVM.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e0f9330798: Remove the ThreadLocal template from LLVM. (authored by resistor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] e4e0f93 - Remove the ThreadLocal template from LLVM.

Author: Owen Anderson Date: 2023-01-10T21:07:52-07:00 New Revision: e4e0f933079859c12983f955e7ee66ba4fb39932 URL: https://github.com/llvm/llvm-project/commit/e4e0f933079859c12983f955e7ee66ba4fb39932 DIFF: https://github.com/llvm/llvm-project/commit/e4e0f933079859c12983f955e7ee66ba4fb39932.diff

[PATCH] D141288: [clang-format] Inherit RightAlign options across scopes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51ba660a0700: [clang-format] Inherit RightAlign options across scopes (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139211: [clang-format] Properly handle the C11 _Generic keyword.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0904e0bac831: [clang-format] Properly handle the C11 _Generic keyword. (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0904e0b - [clang-format] Properly handle the C11 _Generic keyword.

Author: Emilia Dreamer Date: 2023-01-11T06:00:16+02:00 New Revision: 0904e0bac8314249ee7c1b0658f1a1cc92ccd050 URL: https://github.com/llvm/llvm-project/commit/0904e0bac8314249ee7c1b0658f1a1cc92ccd050 DIFF:

[clang] 51ba660 - [clang-format] Inherit RightAlign options across scopes

Author: Emilia Dreamer Date: 2023-01-11T05:59:45+02:00 New Revision: 51ba660a0700e659e1a97f3ca5879b8617ec5c26 URL: https://github.com/llvm/llvm-project/commit/51ba660a0700e659e1a97f3ca5879b8617ec5c26 DIFF:

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

yaxunl added a comment. need a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141447/new/ https://reviews.llvm.org/D141447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

ChuanqiXu added a comment. In D140867#4040590 , @Jake-Egan wrote: > In D140867#4038388 , @ChuanqiXu > wrote: > >> In D140867#4036239 , @Jake-Egan >> wrote: >> >>> Hi,

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12428 F->addFnAttr(llvm::Attribute::NoUnwind); + F->addFnAttr(llvm::Attribute::Convergent); How about using CGF.CGM.addDefaultFunctionDefinitionAttributes? same as below CHANGES

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM as far as I'm able to review in phabricator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 488061. eopXD added a comment. Recover mis-deleted handcrafted test case for vmulh, vmulhu, and vmulhsu on e8 ~ e64 with zve32x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5736 + C.getArgs().hasArg(options::OPT_fmodule_output) && + C.getArgs().hasArg(options::OPT_o)) { +SmallString<128> OutputPath;

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 488057. ChuanqiXu added a comment. Address comments: merge the conditions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 488055. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org/D141198 Files:

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee requested changes to this revision. browneee added a comment. This revision now requires changes to proceed. Hello! Thank you for the patch. I think your changes for `__dfsw_strsep` are conflating the taint value of a pointer with the taint value of the value(s) it points to. This is

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141450/new/ https://reviews.llvm.org/D141450

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

NoQ added a comment. In D139737#4037455 , @ziqingluo-90 wrote: > Since we do not have any `FixableGadget` to trigger fix-its at this point, I > let fix-its of local variable declarations always be emitted for the purpose > of testing. It sounds to

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers created this revision. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Due to inlining, descovering which

[PATCH] D141338: [WIP][-Wunsafe-buffer-usage] Filter out conflicting fix-its

NoQ added a comment. Looks awesome! I'm worried that the test is going to rapidly become stale as you develop fixits for `DeclStmt` further. It might make sense to write some //unittests// for this class directly, to put into `clang/unittest/Analysis/...`. Then you can create some fixits

[clang] f9559b1 - clang: Convert test to generated checks and opaque pointers

Author: Matt Arsenault Date: 2023-01-10T20:35:49-05:00 New Revision: f9559b1e300ec636b15b350a981eebec65d3419a URL: https://github.com/llvm/llvm-project/commit/f9559b1e300ec636b15b350a981eebec65d3419a DIFF:

[PATCH] D141450: [Clang][cc1] Add -fno-modules-local-submodule-visibility to override the default

Bigcheese created this revision. Bigcheese added reviewers: jansvoboda11, dblaikie, iains, ChuanqiXu. Bigcheese added projects: clang-modules, clang. Herald added a subscriber: ributzka. Herald added a project: All. Bigcheese requested review of this revision. Currently there is no way to have

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe29a1695a6c: This is to fix runtime problem for member data used in target region. (authored by jyu2). Changed prior to commit:

[clang] fe29a16 - This is to fix runtime problem for member data used in target region.

Author: Jennifer Yu Date: 2023-01-10T16:59:49-08:00 New Revision: fe29a1695a6c69eb6616db01a559a3804d55fde8 URL: https://github.com/llvm/llvm-project/commit/fe29a1695a6c69eb6616db01a559a3804d55fde8 DIFF: https://github.com/llvm/llvm-project/commit/fe29a1695a6c69eb6616db01a559a3804d55fde8.diff

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl, jdoerfert. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Yet another example how convergent not being the default

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141448/new/ https://reviews.llvm.org/D141448

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change includes llvm-ml tool in Fuchsia toolchain.

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< cjdb wrote: > It's

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added a comment. Thanks for working on this! Needs a bit of work, but we should be able to get this in very soon methinks. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm created this revision. arsenm added reviewers: yaxunl, Anastasia. Herald added subscribers: kosarev, tpr. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The AMDGPU value for this is not really a function. Currently we're emitting IR

[clang] 07aaae1 - [NFC][AIX] Temporarily XFAIL test while investigating

Author: Jake Egan Date: 2023-01-10T19:53:44-05:00 New Revision: 07aaae13037dadcbf3988fb503c83fd90a3310b1 URL: https://github.com/llvm/llvm-project/commit/07aaae13037dadcbf3988fb503c83fd90a3310b1 DIFF: https://github.com/llvm/llvm-project/commit/07aaae13037dadcbf3988fb503c83fd90a3310b1.diff

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. This looks great, thanks for updating this! A few more comments inline. Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:55 +Variable, // a Slot used to store a local data (could be a tmp) +Error // Its an error

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488023. paulkirth added a comment. Add test for YAML output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Frontend/stack-layout-remark.c

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

brad.king updated this revision to Diff 488021. brad.king edited the summary of this revision. brad.king added a comment. Clarify commit message Revise the message to clarify the changes are for implicitly generated members. Also link to the corresponding issue with a full URL. Repository:

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

brad.king created this revision. Herald added a subscriber: arphaman. Herald added a project: All. brad.king requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the change from commit 15f3cd6bfc67

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal updated this revision to Diff 488012. evansmal added a comment. Added additional test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 Files:

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 added a comment. I would like to see this merged in. Is there anyone available to review or approve? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void updated this revision to Diff 488005. void added a comment. Use EllipsisLoc instead of one of the Brackets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/ https://reviews.llvm.org/D140584 Files:

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 created this revision. jhuber6 added reviewers: arsenm, jdoerfert, tianshilei1992, yaxunl, JonChesterfield. Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 487999. paulkirth added a comment. Rebase. - Switch to multi-line remarks - Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files:

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. so that clang can recognize it and handle it automatically without -x hip-cpp-output https://reviews.llvm.org/D141437 Files:

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan added a comment. In D140956#4038988 , @krasimir wrote: > It looks like this regressed the following example: > > % cat test.cc # formatted with older clang-format > a > () { > return 1; > } > %

Re: [clang] b597992 - Revert "[perf-training] Check extension in findFilesWithExtension"

Reminder to please always mention the reason for the revert/recommit in the commit message. On Wed, Jan 11, 2023 at 1:22 AM Amir Aupov via cfe-commits wrote: > > > Author: Amir Aupov > Date: 2023-01-10T14:22:36-08:00 > New Revision: b59799241b3902a460c3b1156477af369934a13e > > URL: >

[clang] b597992 - Revert "[perf-training] Check extension in findFilesWithExtension"

Author: Amir Aupov Date: 2023-01-10T14:22:36-08:00 New Revision: b59799241b3902a460c3b1156477af369934a13e URL: https://github.com/llvm/llvm-project/commit/b59799241b3902a460c3b1156477af369934a13e DIFF: https://github.com/llvm/llvm-project/commit/b59799241b3902a460c3b1156477af369934a13e.diff

[PATCH] D141384: [clang][dataflow] Fix 2 bugs in `MemberExpr` interpretation.

gribozavr2 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141384/new/ https://reviews.llvm.org/D141384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141432: Add two additional float8 types to MLIR and APFloat.

jakeh-gc created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini,

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/test/CXX/dcl.decl/dcl.init/dcl.init.string/p2.cpp:2 // RUN: %clang_cc1 -fsyntax-only -verify %s -char test1[1]="f"; // expected-error {{initializer-string for char array is too long}} +char

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} aaron.ballman wrote: > lebedev.ri wrote: > >

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

kkwli0 added a comment. In D140795#4033559 , @awarzynski wrote: >> However, I don't think the patch does what we want. Given a procedure name >> `foo`, the `-fno-underscoring` option will give `_QPfoo` instead of `foo`. >> We will look into it. > >

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} lebedev.ri wrote: > aaron.ballman wrote: > > lebedev.ri wrote: > > > aaron.ballman

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. Note both the Clang maintainer, and attributes maintainer have requested changes in some way, please let that finish before committing. CHANGES SINCE LAST ACTION

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. LGTM, thanks Alex! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. I expect this to be a common issue for all single-source offloading programming models (i.e. CUDA and HIP in addition to SYCL and OpenMP offload). Probably we can generalize the code

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

eugenis accepted this revision. eugenis added a comment. LGTM Comment at: llvm/lib/CodeGen/GlobalMerge.cpp:655 +// Don't merged tagged globals, as each global should have its own unique +// memory tag at runtime. TODO(hctim): This can be relaxed: constant globals

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4041169 , @vedgy wrote: > In D139774#4040705 , @aaron.ballman > wrote: > >> At a point where we have a `CIndexer` object, we eventually call >>

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} aaron.ballman wrote: > lebedev.ri wrote: > >

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 487962. fpetrogalli added a comment. Formatting changes in RISCV.td (NFC). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/D137517 Files:

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai added a comment. Want to note that originally the issue was noticed with the modules because we serialize and deserialize `PointerTypeLoc::starLoc` and on deserialization we assert if the value is too big. With uninitialized memory the value can be too big //sometimes// and clang was

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

vsapsai added a comment. Doing this minor clean-up for D141424 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422 ___

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel updated this revision to Diff 487960. jcranmer-intel added a comment. Fix some of the code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141008/new/ https://reviews.llvm.org/D141008 Files:

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel added a comment. Comment at: clang/lib/CodeGen/CGOpenCLRuntime.cpp:80 + + if (useSPIRVTargetExtType(CGM)) { +switch (cast(T)->getKind()) { Anastasia wrote: > Perhaps it's best to split into separate functions and reflect in naming what >

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai updated this revision to Diff 487959. vsapsai added a comment. clang-format the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141424/new/ https://reviews.llvm.org/D141424 Files: clang/lib/Sema/SemaType.cpp

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4133 +def NoUnwind : DeclOrStmtAttr { + let Spellings = [Clang<"nounwind", /*allowInC =*/0>]; + let Accessors = [Accessor<"isClangNoUnwind", [CXX11<"clang", "nounwind">]>];

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai created this revision. vsapsai added reviewers: rnk, leonardchan, yonghong-song. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some `TypeLoc`s are

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

ldionne created this revision. Herald added subscribers: mstorsjo, arichardson. Herald added a project: All. ldionne requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Previously, we

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 487955. fahadnayyar retitled this revision from "[Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator. " to "[Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.". fahadnayyar added a

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added a comment. In D141324#4041159 , @arphaman wrote: > In D141324#4039629 , @erichkeane > wrote: > >> I'm disturbed that the string-literal diagnostic you changed never shows up >> in the tests. I

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

vsapsai created this revision. vsapsai added a reviewer: fhahn. Herald added subscribers: StephenFan, tschuett, ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `MatrixTypeLoc` is not "sugar"

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

ldionne added subscribers: fahad, rprichard, MaskRay. ldionne added a comment. The code in libunwind does look fishy to me (before the change), so I think flagging this in the compiler is good. I don't know that code at all, though, so I'm pinging a few libunwind regulars so they can let us

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5733-5735 + if (!AtTopLevel && isa(JA) && + JA.getType() == types::TY_ModuleFile && + C.getArgs().hasArg(options::OPT_fmodule_output) && These conditions might be shared with the

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. In D139774#4040705 , @aaron.ballman wrote: > At a point where we have a `CIndexer` object, we eventually call > `ASTUnit::LoadFromCommandLine()` and `ASTUnit` has a member > `FileSystemOptions FileSystemOpts`, and

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Peter updated this revision to Diff 487946. Peter added a comment. use const ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. In D141324#4039629 , @erichkeane wrote: > I'm disturbed that the string-literal diagnostic you changed never shows up > in the tests. I suspect this attribute needs significantly better test > coverage. Please elaborate.

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 487944. arphaman marked 3 inline comments as done. arphaman added a comment. Herald added a subscriber: jdoerfert. Updated to address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 487936. tkuchta added a comment. applied newer version of clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f3081dc6fe8: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too (authored by sylvestre.ledru). Repository: rG LLVM Github

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4133 +def NoUnwind : DeclOrStmtAttr { + let Spellings = [Clang<"nounwind", /*allowInC =*/0>]; + let Accessors = [Accessor<"isClangNoUnwind", [CXX11<"clang", "nounwind">]>];

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 487933. lebedev.ri marked 10 inline comments as done. lebedev.ri added a comment. @aaron.ballman thank you for taking a look! Addressed all review notes other than the SEH question and the simplehandler one. (i'll deal with whitespace changes when

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers updated this revision to Diff 487931. nickdesaulniers added a comment. - rebase, format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140508/new/ https://reviews.llvm.org/D140508 Files: clang/lib/Analysis/UninitializedValues.cpp

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 487929. nickdesaulniers added a comment. - rebase, format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 487927. nickdesaulniers added a comment. - rebase, format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index:

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, assuming, you actually tested that locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141047/new/

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

arsenm closed this revision. arsenm added a comment. 2ad4c3c88d884684a3efb42181e87fe305df51bd CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140639/new/ https://reviews.llvm.org/D140639

[PATCH] D141342: [perf-training] Check extension in findFilesWithExtension

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fbbf92e4fda: [perf-training] Check extension in findFilesWithExtension (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141342/new/

  1   2   3   >