[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

ccotter added a comment. Herald added a subscriber: PiotrZSL. @Febbe - checking in. is this still on your radar? I would love to see this merged! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 508476. ccotter added a comment. - alpha Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat updated this revision to Diff 508475. 4vtomat added a comment. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 508474. ccotter added a comment. - fix bad rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a9827dc1185: [Driver][NetBSD] Simplify NetBSD version handling (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146891/new/

[clang] 9a9827d - [Driver][NetBSD] Simplify NetBSD version handling

Author: Brad Smith Date: 2023-03-27T00:01:42-04:00 New Revision: 9a9827dc1185f3757433b973fbb37c7ad7219e32 URL: https://github.com/llvm/llvm-project/commit/9a9827dc1185f3757433b973fbb37c7ad7219e32 DIFF: https://github.com/llvm/llvm-project/commit/9a9827dc1185f3757433b973fbb37c7ad7219e32.diff

[PATCH] D146891: [Driver][NetBSD] Simplify NetBSD version handling

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. WFM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146891/new/ https://reviews.llvm.org/D146891

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper added inline comments. Comment at: clang/include/clang/Driver/Options.td:4346 MarshallingInfoFlag>; +def print_supported_marchs : Flag<["-", "--"], "print-supported-marchs">, + Group, Flags<[CC1Option, CoreOption]>, Maybe this should be

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper added inline comments. Comment at: clang/tools/driver/cc1_main.cpp:189 + std::string Error; + const llvm::Target *TheTarget = + llvm::TargetRegistry::lookupTarget(TargetStr, Error); Why do we need to lookup the TargetRegistry? Repository:

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains added a comment. In D126959#4222637 , @bjope wrote: > This seem to case problems when building with asan enabled > (LLVM_USE_SANITIZER='Address'): investigating... do you need the patch reverted? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146895: [clang-format] Don't annotate left brace of struct as FunctionLBrace

owenpan updated this revision to Diff 508464. owenpan added a comment. Handles consecutive attributes too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146895/new/ https://reviews.llvm.org/D146895 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added a comment. The numbers are backreferences of the sort generated by mangleSourceName(), I think. If you nest deeply enough, MSVC stops using them; for example: struct A { union {union { union {union { struct B {struct C {struct D {struct E {struct F {struct G { struct H

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat updated this revision to Diff 508461. 4vtomat added a comment. Resolved MaskRay and Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files:

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

gribozavr2 added a comment. Could you upload an updated sample HTML file? It is easier to review the HTML generation and javascript code when an example is available. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:388 +std::unique_ptr flagLogger()

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b103edf5b2c: [clangd] Fix a hover crash on unsigned 64bit value (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/

[clang-tools-extra] 0b103ed - [clangd] Fix a hover crash on unsigned 64bit value

Author: Younan Zhang Date: 2023-03-27T10:27:11+08:00 New Revision: 0b103edf5b2c6178c2725a9ff085c6ccc866bccb URL: https://github.com/llvm/llvm-project/commit/0b103edf5b2c6178c2725a9ff085c6ccc866bccb DIFF: https://github.com/llvm/llvm-project/commit/0b103edf5b2c6178c2725a9ff085c6ccc866bccb.diff

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1247 + unsigned DiagID = Diags.getCustomDiagID( + DiagnosticsEngine::Error, "cannot mangle anonymous struct/union yet"); + Diags.Report(DiagID); efriedma wrote:

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added a comment. > Additional levels of nesting append 3's: @3, @33, > etc. Yes, but if you have such a code: struct A { union { union { struct B {}; using T = B; }; }; }; void f(A::T); you have `?f@@YAXUB@@2A@@@Z` for `f`, and for such a

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt added a comment. I am sorry for protracting implementation. I am still interested to finish this (if no volunteer takes over sooner). In D134475#4070995 , @RIscRIpt wrote: > I asked MSFT >

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

ccotter added a comment. Herald added subscribers: mgehre, shchenz. Herald added projects: clang-tools-extra, All. bump - I know this is really old, but @lewmpk do you plan on finishing up the last remaining comments? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter added a comment. I didn't update the release notes since this check is new. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929 ___ cfe-commits mailing

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 508452. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 508451. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508450. ccotter added a comment. - add tests, simplify expr, handle unevaluated exprs - formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files:

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cef325481a8: [clang-format] Dont squash Verilog escaped identifiers (authored by sstwcw). Changed prior to commit:

[clang] 6cef325 - [clang-format] Don't squash Verilog escaped identifiers

Author: sstwcw Date: 2023-03-26T22:45:44Z New Revision: 6cef325481a8efc039ae9df5630609fd3a84560c URL: https://github.com/llvm/llvm-project/commit/6cef325481a8efc039ae9df5630609fd3a84560c DIFF: https://github.com/llvm/llvm-project/commit/6cef325481a8efc039ae9df5630609fd3a84560c.diff LOG:

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

apwadkar added a comment. Sorry about the premature review, this is my first commit, and I didn't realize it wouldn't create a draft first. - For rebuilding the docs, I assume I need to add `-DLLVM_BUILD_DOCS=true` to CMake and then run `ninja -C build`? Repository: rG LLVM Github Monorepo

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:127 + + Warns when a forwarding reference parameter is not forwarded within the function body. + Please follow 80 characters limit for text. Repository: rG LLVM

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/noexcept-move-constructor-fix.cpp:64 // CHECK-FIXES: ){{.*}}noexcept{{.*}} {} \ No newline at end of file Please add. Repository: rG LLVM Github

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added a comment. You need to add unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146926/new/ https://reviews.llvm.org/D146926 ___ cfe-commits mailing list

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added a comment. You need to regenerate the documentation after changing Format.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146926/new/ https://reviews.llvm.org/D146926 ___

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

apwadkar created this revision. Herald added a project: All. apwadkar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added the DecorateReflowComments option to control whether '* ' are added to the beginnings of continuation lines for

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

tahonermann added a comment. @cor3ntin, do you have any thoughts about this? CWG 1871 (Non-identifier characters in ud-suffix) is somewhat related. I think the changed behavior makes sense when `-fdollars-in-identifiers` is in effect (which is the default).

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added a comment. > I don't still understand how to mangle nested unnamed tags in general. According to some quick experiments, for the non-virtual case, you mangle a member of an unnamed union it the same way as a regular member, except you stick `@` into the mangling. Additional

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardingReferenceParamNotForwardedCheck.cpp:83-84 + + if (!Param) +return; + PiotrZSL wrote: > I thing this can never happen Another review suggested I check the

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508441. ccotter marked 4 inline comments as done. ccotter retitled this revision from "[clang-tidy] Implement cppcoreguidelines F.19 " to "[clang-tidy] Implement cppcoreguidelines F.19". ccotter added a comment. - add tests, simplify expr, handle

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/ https://reviews.llvm.org/D146874

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + probinson wrote: > This doesn't become `Foo` ? The name stays as `Foo>` but the type of the template parameter becomes `BarInt`. So the dwarf would

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

bjope added a comment. This seem to case problems when building with asan enabled (LLVM_USE_SANITIZER='Address'): Failed Tests (24): Clang :: CXX/basic/basic.link/p2.cpp Clang :: CXX/basic/basic.lookup/basic.lookup.argdep/p5-ex2.cpp Clang ::

[clang] 5b5c49a - [clang-format] Don't format already formatted integer literals

Author: Owen Pan Date: 2023-03-26T13:25:41-07:00 New Revision: 5b5c49ad4563f75debccbc6c3017d27a47ca217d URL: https://github.com/llvm/llvm-project/commit/5b5c49ad4563f75debccbc6c3017d27a47ca217d DIFF: https://github.com/llvm/llvm-project/commit/5b5c49ad4563f75debccbc6c3017d27a47ca217d.diff

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b5c49ad4563: [clang-format] Dont format already formatted integer literals (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

owenpan accepted this revision. owenpan added a comment. This patch is effectively NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146501/new/ https://reviews.llvm.org/D146501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

annara created this revision. Herald added a project: All. annara requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146924 Files: clang/lib/Lex/Lexer.cpp

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:720 +const CXXRecordDecl *RD, const ValueDecl *VD) { + MSInheritanceModel IM = RD->getMSInheritanceModel(); + // ::= rjmccall wrote: > efriedma wrote: > > It's not obvious

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a updated this revision to Diff 508437. bolshakov-a added a comment. Mangle pointer-to-members with conversion. Pointer-to-member-functions with conversions across hierarchy work fine, as I can see. I don't still understand how to mangle nested unnamed tags in general. CHANGES

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a updated this revision to Diff 508436. bolshakov-a added a comment. Add test cases on unspecified inheritance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/D146386 Files: clang/lib/AST/MicrosoftMangle.cpp

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

PiotrZSL added a comment. maybe some other name for check, like missing-std-forward. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardingReferenceParamNotForwardedCheck.cpp:62 + namedDecl(hasUnderlyingDecl(hasName("::std::forward")), +

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL added a comment. Update ReleaseNotes for this check, and validate documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 ___ cfe-commits

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Current solution is invalid, defaulted move constructors can throw by default. There are 2 more issues for this case: https://github.com/llvm/llvm-project/issues/38081

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

PiotrZSL added a comment. In D144347#4222534 , @ccotter wrote: > Is it worth adding a cppcoreguidelines alias (ES.56)? Yes, you can pull this change (arc patch D144347 --nobranch) and create change that would depend

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 created this revision. AMS21 added a reviewer: njames93. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously a struct

[PATCH] D146921: Reviewers:

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Is it worth adding a cppcoreguidelines alias (ES.56)? Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/forward-usage.rst:98 + +.. option:: DisableTypeMismatchSuggestion + Curious what others thing but I think the tool

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:139-142 + // Clang does not append all target features to the clang -cc1 invocation. + // Some AMDGPU features are passed implicitly by the Clang frontend. + // That's why we need to extract

[PATCH] D146913: [clang-tidy] Add option to ignore user-defined literals in readability-magic-numbers

This revision was automatically updated to reflect the committed changes. Closed by commit rG556600af6a8a: [clang-tidy] Add option to ignore user-defined literals in readability-magic… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 556600a - [clang-tidy] Add option to ignore user-defined literals in readability-magic-numbers

Author: Carlos Galvez Date: 2023-03-26T16:41:17Z New Revision: 556600af6a8a7f241277f7a22c3e3746e7b09123 URL: https://github.com/llvm/llvm-project/commit/556600af6a8a7f241277f7a22c3e3746e7b09123 DIFF: https://github.com/llvm/llvm-project/commit/556600af6a8a7f241277f7a22c3e3746e7b09123.diff

[PATCH] D146888: [clang-tidy] Flag std::forward on non-forwarding references

ccotter abandoned this revision. ccotter added a comment. Indeed - sorry i missed that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146888/new/ https://reviews.llvm.org/D146888 ___ cfe-commits mailing

[PATCH] D146895: [clang-format] Don't annotate left brace of struct as FunctionLBrace

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146895/new/ https://reviews.llvm.org/D146895

[PATCH] D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG938deaad8ac9: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs (authored by asb). Repository: rG LLVM Github

[clang] 938deaa - [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

Author: Alex Bradbury Date: 2023-03-26T16:18:47+01:00 New Revision: 938deaad8ac92d9a45db8ef2d8a71fbf04958d90 URL: https://github.com/llvm/llvm-project/commit/938deaad8ac92d9a45db8ef2d8a71fbf04958d90 DIFF: https://github.com/llvm/llvm-project/commit/938deaad8ac92d9a45db8ef2d8a71fbf04958d90.diff

[PATCH] D142326: [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa742511cbe9a: [clang][RISCV][test] Add test cases for empty structs and the FP calling… (authored by asb). Herald added a subscriber: jobnoorman.

[clang] a742511 - [clang][RISCV][test] Add test cases for empty structs and the FP calling conventions

Author: Alex Bradbury Date: 2023-03-26T16:11:18+01:00 New Revision: a742511cbe9ada478e8a42847f443aa807bb147c URL: https://github.com/llvm/llvm-project/commit/a742511cbe9ada478e8a42847f443aa807bb147c DIFF: https://github.com/llvm/llvm-project/commit/a742511cbe9ada478e8a42847f443aa807bb147c.diff

[PATCH] D146916: [include-cleaner] Fix crash on unresolved headers

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5b6e9b6d355: [include-cleaner] Fix crash on unresolved headers

[clang-tools-extra] f5b6e9b - [include-cleaner] Fix crash on unresolved headers

Author: Kadir Cetinkaya Date: 2023-03-26T16:37:56+02:00 New Revision: f5b6e9b6d355866c2aa4e440438b870885ec0373 URL: https://github.com/llvm/llvm-project/commit/f5b6e9b6d355866c2aa4e440438b870885ec0373 DIFF:

[PATCH] D146916: [include-cleaner] Fix crash on unresolved headers

kadircet created this revision. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Make sure unresolved headers are not analyzed as part of unused includes. Also introduces a testing fixture

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

PiotrZSL updated this revision to Diff 508411. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Use auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146904/new/ https://reviews.llvm.org/D146904 Files:

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantDeclarationCheck.cpp:84 + SourceLocation BeginLoc; + if (const LinkageSpecDecl *Extern = + Result.Nodes.getNodeAs("extern"); `auto` could

[PATCH] D146913: [clang-tidy] Add option to ignore user-defined literals in readability-magic-numbers

carlosgalvezp updated this revision to Diff 508410. carlosgalvezp added a comment. Move implementation to .cpp file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146913/new/ https://reviews.llvm.org/D146913 Files:

[PATCH] D146882: [clang-tidy] Correct union & macros handling in modernize-use-equals-default

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb87e55c9aad: [clang-tidy] Correct union macros handling in modernize-use-equals-default (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] eb87e55 - [clang-tidy] Correct union & macros handling in modernize-use-equals-default

Author: Piotr Zegar Date: 2023-03-26T13:22:44Z New Revision: eb87e55c9aade5d7b42606487e69b5f3a6da1e65 URL: https://github.com/llvm/llvm-project/commit/eb87e55c9aade5d7b42606487e69b5f3a6da1e65 DIFF: https://github.com/llvm/llvm-project/commit/eb87e55c9aade5d7b42606487e69b5f3a6da1e65.diff LOG:

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

This revision was automatically updated to reflect the committed changes. Closed by commit rG52296f5ed88b: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D145617?vs=508321=508408#toc Repository:

[clang-tools-extra] 52296f5 - [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

Author: Piotr Zegar Date: 2023-03-26T13:20:14Z New Revision: 52296f5ed88b20af29cac517e349b221ed84cc2a URL: https://github.com/llvm/llvm-project/commit/52296f5ed88b20af29cac517e349b221ed84cc2a DIFF: https://github.com/llvm/llvm-project/commit/52296f5ed88b20af29cac517e349b221ed84cc2a.diff LOG:

[PATCH] D146913: [clang-tidy] Add option to ignore user-defined literals in readability-magic-numbers

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.h:52-59 + bool isUserDefinedLiteral( + const

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145617/new/ https://reviews.llvm.org/D145617

[PATCH] D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check

carlosgalvezp added a comment. In D145617#4221369 , @PiotrZSL wrote: > @carlosgalvezp Do you want me to shorten documentation ? Or we leave it like > it is ? It's fine for me either way! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D146913: [clang-tidy] Add option to ignore user-defined literals in readability-magic-numbers

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Some user-defined

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. In D146148#4221651 , @rjmccall wrote: > In D146148#4220591 , @zahiraam > wrote: > >> In D146148#4220495 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D146908: [clang][MinGW] Add asan link flags before other libs and objects

alvinhochun created this revision. alvinhochun added reviewers: mstorsjo, MaskRay. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As stated in https://github.com/llvm/llvm-project/issues/61685, by

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan updated this revision to Diff 508401. zyounan marked an inline comment as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/ https://reviews.llvm.org/D146874 Files:

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan marked 2 inline comments as done. zyounan added a comment. Thank you! Comment at: clang-tools-extra/clangd/Hover.cpp:396 // -2=> 0xfffe -// -2^32 => 0xfffe +// -2^32 => 0x static llvm::FormattedNumber printHex(const llvm::APSInt )

[PATCH] D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently check does

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:396 // -2=> 0xfffe -// -2^32 => 0xfffe +// -2^32 => 0x static llvm::FormattedNumber printHex(const llvm::APSInt ) { Just to make sure I'm not

[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

samuelmaina added a comment. All the testcases are passing. The first unit tests I could find are for functions that are 6 levels higher from this function .The function is very low level and couldn't find a way to affect it from the higher functions. CHANGES SINCE LAST ACTION

[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

samuelmaina updated this revision to Diff 508381. samuelmaina edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146370/new/ https://reviews.llvm.org/D146370 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp Index: clang/lib/CodeGen/CGOpenMPRuntime.cpp