[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. A small ping to ask for some reviewer attention on this patch if at all possible please! Thank you for your time as always, it is greatly appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://rev

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, jdoerfert, dpalermo. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added pr

[PATCH] D148689: [clang][Interp] Handle PredefinedExprs

shafik added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:783 + +namespace PredefinedExprs { + constexpr char heh(unsigned index) { Can we add tests for each predefined expressions, it does not look like there are a lot of them. Repository

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. Small ping to ask for some reviewer attention on this patch if at all possible! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/ https://reviews.llvm.org/D148370 ___ c

[PATCH] D148982: [clang][Interp] Fix ignoring conditional operators

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148982/new/ https://reviews.llvm.org/D148982 ___

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

Manna added a comment. Thank you @erichkeane and @tahonermann for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list cfe-comm

[PATCH] D148614: [clang][Interp] Add frame depth checking

shafik added a comment. The changes make sense, I am sure about any trade-offs of doing the checking during the call Vs doing at return. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148614/new/ https://reviews.llvm.org/D148614 ___ cfe-commi

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

tahonermann accepted this revision. tahonermann added a comment. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 518777. aeubanks added a comment. add module test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/I

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

cor3ntin updated this revision to Diff 518776. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149637/new/ https://reviews.llvm.org/D149637 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante added a comment. In D149553#4310478 , @aaron.ballman wrote: > Thank you for working on this! The Clang changes are mostly all good, but I > think we should hold off on changing the value of `__cplusplus` for the > moment as it's not set in sto

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

ymandel added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149640/new/ https://reviews.llvm.org/D149640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 64888d4 - SemaRISCVVectorLookup.cpp: Prune `default:` block. [-Wcovered-switch-default]

Author: NAKAMURA Takumi Date: 2023-05-03T01:37:37+09:00 New Revision: 64888d437c9e0dd52adad9b26784369a4ea24b7f URL: https://github.com/llvm/llvm-project/commit/64888d437c9e0dd52adad9b26784369a4ea24b7f DIFF: https://github.com/llvm/llvm-project/commit/64888d437c9e0dd52adad9b26784369a4ea24b7f.dif

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 planned changes to this revision. eddyz87 added a comment. In D143967#4312746 , @yonghong-song wrote: > I see the following in the Summary: > > Type tag for CVR modifier type > > C: > > volatile int __attribute__((btf_type_tag("__b"))

[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

dmgreen added a comment. My preference would be for fixing the code we have, not introducing new intrinsics. Intrinsics act as black-boxes for the optimizer, and I'm pretty sure I've heard of cases in the past of the compiler optimizing the or/and/xor's to nicer sequences of instructions. It wo

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

yonghong-song added a comment. I see the following in the Summary: Type tag for CVR modifier type C: volatile int __attribute__((btf_type_tag("__b"))) b; DWARF: 0x31: DW_TAG_variable DW_AT_name ("b") DW_AT_type (0x3c "volatile int") 0

[PATCH] D148723: [clang] Enforce external linkage for inline builtin original declaration

serge-sans-paille added a comment. In D148723#4296111 , @efriedma wrote: > I'm a little concerned that this will explode in unexpected ways... in > particular, it'll fail to link if the function doesn't actually exist > externally. Which it probably do

[PATCH] D147621: [clang][Interp] Start handling mutable record members

shafik added a comment. Two cases to consider: https://godbolt.org/z/ovofPExGK namespace MutableFields { class Foo { public: constexpr Foo() : I(1) {} mutable int I; // ref-note {{declared here}} }; constexpr int foo() { constexpr Foo F; F.I = 12;

[clang] e6ffd42 - [tests] Add missing REQUIRES: riscv-registered-target to clang test

Author: 4vtomat Date: 2023-05-02T09:19:32-07:00 New Revision: e6ffd42a933e74e2b634e84ef8666483e53552f3 URL: https://github.com/llvm/llvm-project/commit/e6ffd42a933e74e2b634e84ef8666483e53552f3 DIFF: https://github.com/llvm/llvm-project/commit/e6ffd42a933e74e2b634e84ef8666483e53552f3.diff LOG:

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7979-7986 { ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); -if (FirstArgResult.isInvalid()) +if (checkBuiltinArgument(*this, TheCall, 0)) r

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

yonghong-song added a comment. Related to `btf_type_is_modifier()` issue, Not that depending on call site, sometimes typedef is skipped and sometimes are not. So we could keep btf_type_is_modifier() as is and modify the call size to not skip typedef in specific places. Or we could remove typede

[PATCH] D148723: [clang] Enforce external linkage for inline builtin original declaration

serge-sans-paille added a comment. In D148723#4296112 , @efriedma wrote: > Really, I'd prefer to keep isInlineBuiltinDeclaration() targeted as narrowly > as possible; part of that is making it not trigger for C++ inline functions > (which it never did i

[PATCH] D148690: [clang][Interp] Handle __extension__ unary operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/AST/Interp/literals.cpp:791 +#endif return __FUNCTION__[index]; } tbaeder wrote: > erichkeane wrote: > > tb

[PATCH] D149655: [tests] Add missing REQUIRES: riscv-registered-target to clang test

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149655/new/ https://reviews.llvm.org/D149655 ___ c

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

barannikov88 added a comment. In D148767#4311589 , @chapuni wrote: > In D148767#4311564 , @barannikov88 > wrote: > >> Adding CodeGen dependency to MCTargetDesc/AsmParser/Disassembler does not >> seem right. Why

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu updated this revision to Diff 518762. kinu added a comment. Updated changes further not to lose the existing checks with the do-while test. Also restored the simplest test that exercises the while-true one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D149272: [clang] Call printName to get name of Decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGea6ecdbfe09d: Call printName to get name of Decl (authored by dankm, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D149272?vs=518050&id=518761#toc Repository: rG LLVM

[clang] ea6ecdb - Call printName to get name of Decl

Author: Dan McGregor Date: 2023-05-02T11:56:23-04:00 New Revision: ea6ecdbfe09d4318f2d616af794e2930f996e393 URL: https://github.com/llvm/llvm-project/commit/ea6ecdbfe09d4318f2d616af794e2930f996e393 DIFF: https://github.com/llvm/llvm-project/commit/ea6ecdbfe09d4318f2d616af794e2930f996e393.diff

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon updated this revision to Diff 518759. agozillon added a comment. Rebase on an updated main to see if it fixes bolt error (like it appears to on my local machine) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.l

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:46 + +#define REPL_BUILTIN_TYPES \ + X(bool, Bool) \ v.g

[clang] 45905b5 - Add missing include

Author: Adrian Prantl Date: 2023-05-02T08:37:40-07:00 New Revision: 45905b53f0eddb7b07a35a9a493a5ebd508bedda URL: https://github.com/llvm/llvm-project/commit/45905b53f0eddb7b07a35a9a493a5ebd508bedda DIFF: https://github.com/llvm/llvm-project/commit/45905b53f0eddb7b07a35a9a493a5ebd508bedda.diff

[PATCH] D149657: [clang-format] Stop indent Verilog `begin` keyword on single line

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. When the line is too long and the `begin` keyword wraps to t

[PATCH] D149561: [clang-format] Recognize Verilog edge identifiers

sstwcw updated this revision to Diff 518752. sstwcw added a comment. - add annotator test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149561/new/ https://reviews.llvm.org/D149561 Files: clang/lib/Format/FormatToken.h clang/unittests/Format/F

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu added a comment. (comment only) Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2673 - -EXPECT_EQ(BarVal, FooPointeeVal); }); mboehme wrote: > It's unfortuante that all of these checks have gone away. I think the test >

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw added a comment. In D149562#4310396 , @HazardyKnusperkeks wrote: > I don't see the problem, could you elaborate a bit more? (Keep in mind, I > have no idea about Verilog.) The current way the port list gets formatted is like this: module x

[PATCH] D149633: [clang][codegen] Add F128 vsnprintf_chk builtin

tuliom requested changes to this revision. tuliom added a comment. This revision now requires changes to proceed. @tbaeder Keep in mind that I don't think this will completely fix issue 61913 because there are other 2 functions affected. Otherwise, I believe this patch is in the right direction.

[PATCH] D149655: [tests] Add missing REQUIRES: riscv-registered-target to clang test

4vtomat created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuas

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312515 , @dyung wrote: > In D148223#4312460 , @4vtomat wrote: > >> Hi @craig.topper and @kito-cheng , the build error message was: >> 'Z:\test\llvm-project\clang\test\CodeGen\

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147840: [clang][Interp] Handle DiscardResult for DeclRef- and ParenExprs

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147840/new/ https://reviews.llvm.org/D147840 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d71ec6e448f: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT (authored by chapuni). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9cfeba5b12b6: Restore CodeGen/LowLevelType from `Support` (authored by chapuni). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312460 , @4vtomat wrote: > Hi @craig.topper and @kito-cheng , the build error message was: > 'Z:\test\llvm-project\clang\test\CodeGen\RISCV\rvv-intrinsics-autogenerated\non-policy\non-overloaded\xsfvcp-x-rv64.c:4:10:

[PATCH] D149119: [CMake] Use llvm-nm to extract symbols for staged LTO builds on Windows

simon_tatham added a comment. Do LLVM's current portability goals include the constraint that you can only build LLVM for a platform it can also target? If not, then there surely still needs to be //some// kind of escape hatch so that you can avoid needing `llvm-nm` to already support the objec

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

dyung added a comment. In D148223#4312460 , @4vtomat wrote: > Hi @craig.topper and @kito-cheng , the build error message was: > 'Z:\test\llvm-project\clang\test\CodeGen\RISCV\rvv-intrinsics-autogenerated\non-policy\non-overloaded\xsfvcp-x-rv64.c:4:10: >

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. I reverted due to the workaround (which I'd objected to before, I don't think it is acceptable) and the breakage David mentioned. I'll make sure to review the commit message when you put it back up for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2b-overloaded-operator.cpp:101 + int arr[] = {1, 2, 3}; + return arr[Is...]; // expected-error 2{{type 'int[3]' does not provide a subscript operator}} +} shafik wrote: > The diagnostic is not g

[clang] 3e850a6 - Revert "[Clang][Sema] Fix comparison of constraint expressions"

Author: Erich Keane Date: 2023-05-02T08:09:35-07:00 New Revision: 3e850a6eea5277082a0b7b701754c86530d25c40 URL: https://github.com/llvm/llvm-project/commit/3e850a6eea5277082a0b7b701754c86530d25c40 DIFF: https://github.com/llvm/llvm-project/commit/3e850a6eea5277082a0b7b701754c86530d25c40.diff L

[clang] ad71114 - Revert "[Clang][Sema] Add a temporary workaround in SemaConcept.cpp"

Author: Erich Keane Date: 2023-05-02T08:09:01-07:00 New Revision: ad7111495f43fe8f837007b9e21afb9e515df4d1 URL: https://github.com/llvm/llvm-project/commit/ad7111495f43fe8f837007b9e21afb9e515df4d1 DIFF: https://github.com/llvm/llvm-project/commit/ad7111495f43fe8f837007b9e21afb9e515df4d1.diff L

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:329 + // against this above. + ProcessVarDecl(*VD); + auto *VDLoc = Env.getStorageLocation(*VD); mboehme wrote: > y

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:162 + if (P->getCurToken().is(tok::annot_repl_input_end)) { +P->ConsumeAnyToken(); // FIXME: Clang does not call ExitScope on finalizing the regular TU, we rsmith wro

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire updated this revision to Diff 518738. junaire marked 3 inline comments as done. junaire added a comment. Address comments, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/ https://reviews.llvm.org/D148997 Files: clang/in

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

shafik accepted this revision. shafik added a comment. LGTM, other than my comment on the diagnostic wording Comment at: clang/test/SemaCXX/cxx2b-overloaded-operator.cpp:101 + int arr[] = {1, 2, 3}; + return arr[Is...]; // expected-error 2{{type 'int[3]' does not provide a s

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4312473 , @davidtgoldblatt wrote: > This breaks ~the world in the versions of libstdc++ I can easily check -- see > e.g. https://gcc.godbolt.org/z/ETeGzc3ve (crashes at this commit, changes to > an error at ce861e

[PATCH] D148654: Modify BoundsSan to improve debuggability

smeenai added a comment. Thinking about this a bit more, should the trap not have an associated stack trace that can be symbolicated to tell you which line of code was crashing? If the issue is that multiple traps can get folded together, the `nomerge` attribute (D78659

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

davidtgoldblatt added a comment. This breaks ~the world in the versions of libstdc++ I can easily check -- see e.g. https://gcc.godbolt.org/z/ETeGzc3ve (crashes at this commit, changes to an error at ce861ec782ae3f41807b61e855512aaccf3c2149

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. Hi @craig.topper and @kito-cheng , the build error message was: 'z:\test\build\lib\clang\17\include\sifive_vector.h:12:10: fatal error: 'riscv_vector.h' file not found'. Have you ever met this before? I'm not sure if I forgot to add something or not.. Repository: rG

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

TWeaver added a comment. In D148223#4312352 , @4vtomat wrote: > I'll take a look, thanks! Much obliged and thanks for the speedy reply! 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://

[PATCH] D149492: [clang] makes built-in traits match their stdlib counterparts' names

aaron.ballman added a comment. In D149492#4311026 , @cjdb wrote: > Looks like I need to special-case `__is_null_pointer` as a function for > libstdc++. Yeah, precommit CI found an issue with that. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

tianshilei1992 added a comment. Looks good on the OpenMP side as we don’t generally have a good API doc anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641

[PATCH] D149650: Give NullabilityKind a printing operator<

aaron.ballman added a comment. I guess I'm not seeing much motivation for this change. We already have `clang::getNullabilitySpelling()` and `const StreamingDiagnostic &clang::operator<<(const StreamingDiagnostic &DB, DiagNullabilityKind nullability)` and now we're adding a third way to get thi

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT

chapuni updated this revision to Diff 518722. chapuni edited the summary of this revision. chapuni added a comment. - Updat the desc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148769/new/ https://reviews.llvm.org/D148769 Files: clang/lib/Code

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312296 , @TWeaver wrote: > Hello and Good Afternoon from the UK, > > I believe this revision has started the following build bot to start failing > on these 5 tests: > > https://lab.llvm.org/buildbot/#/builders/216/bu

[PATCH] D149215: [MemProf] Control availability of hot/cold operator new from LTO link

tejohnson updated this revision to Diff 518721. tejohnson added a comment. Address comment (add TODO about automatically detecting support) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149215/new/ https://reviews.llvm.org/D149215 Files: clang/t

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aaron.ballman added a comment. In D146764#4310655 , @aeubanks wrote: > In D146764#4310398 , @aaron.ballman > wrote: > >> I think you're missing changes in ASTReaderStmt.cpp and ASTWriterStmt.cpp, >> so serializa

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:852 +llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, NullabilityKind NK) { + switch (NK) { IdentifierTable.cpp is a weird place to implement this function (I put it next to

[PATCH] D149650: Give NullabilityKind a printing operator<

sammccall created this revision. sammccall added a reviewer: mboehme. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is more useful for debug/test than getNullabilitySpelling: - default form has

[PATCH] D149380: [clang] Add -Wunused-result-always warning

aaron.ballman added a comment. In D149380#4311237 , @dblaikie wrote: > Seems more stylistic/unlikely to meet the diagnostic bar (certtainly couldn't > be on-by-default for instance) for clang to me (but could go into something > like clang-tidy), at lea

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme marked 5 inline comments as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:307-311 + auto &ParamLoc = + createStorageLocation(ParamDecl->getType().getNonReferenceType()); setStorageLocation(*P

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

TWeaver added a comment. Hello and Good Afternoon from the UK, I believe this revision has started the following build bot to start failing on these 5 tests: https://lab.llvm.org/buildbot/#/builders/216/builds/20627 xsfvcp-x-rv64.c xsfvcp-x.c xsfvcp-xv.c xsfvcp-xvv.c xsfvcp-xvw.c Is anyone ab

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added inline comments. Comment at: clang/test/SemaObjCXX/flexible-array.mm:7 int s; - char c[]; + char c[]; //expected-error {{flexible array member 'c' in a union is not allowed}} }; CC @rjmccall -- this is changing Objective-C++ behavior, w

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

chapuni updated this revision to Diff 518713. chapuni retitled this revision from "Restore CodeGen/LowLevelType" to "Restore CodeGen/LowLevelType from `Support`". chapuni edited the summary of this revision. chapuni added a comment. - Rebase and update the desc Repository: rG LLVM Github Mono

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

simonwallis2 added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:434 // range otherwise. - return !NoMovt && hasV8MBaselineOps() && + return !NoMovt && hasV6MOps() && (isTargetWindows() || !OptMinSize || genExecuteOnly()); simon

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 518710. oontvoo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. updated clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

mboehme updated this revision to Diff 518709. mboehme marked an inline comment as done. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149144/new/ https://reviews.llvm.org/D149144 File

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

aaron.ballman added a comment. In D141451#4311199 , @dblaikie wrote: >> probably too much, but then I wonder "how do we make Fortify work?". > > (I'm still sort of on the side of "if the compile-time costs to get more > verbose diagnostics is high, we co

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

yronglin added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7979-7986 { ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); -if (FirstArgResult.isInvalid()) +if (checkBuiltinArgument(*this, TheCall, 0)) retur

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

erichkeane added a subscriber: rjmccall. erichkeane added a comment. I Comment at: clang/include/clang/AST/ASTContext.h:28 #include "clang/AST/TemplateName.h" +#include "clang/AST/Type.h" #include "clang/Basic/IdentifierTable.h" What is this needed for? =

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

tbaeder added a comment. In D149645#4312193 , @erichkeane wrote: > In D149645#4312190 , @tbaeder wrote: > >> In D149645#4312162 , @erichkeane >> wrote: >> >>> For C, sho

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

simonwallis2 added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:434 // range otherwise. - return !NoMovt && hasV8MBaselineOps() && + return !NoMovt && hasV6MOps() && (isTargetWindows() || !OptMinSize || genExecuteOnly()); V6M d

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

tbaeder updated this revision to Diff 518707. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149645/new/ https://reviews.llvm.org/D149645 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/c.c Index: clang/test/AST/Interp/c.c ==

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

aaron.ballman added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1, JDevlieghere. I think this is a reasonable change -- I don't see a whole lot of value out from the include or collaboration graphs, so unless someone has strong opinions otherwise, I th

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

aaron.ballman added a comment. Precommit CI found a valid issue (at least on Debian, the Windows failure appears to be unrelated but it's really hard to tell from that output). Also, this should have a release note, right? Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:220

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2673 - -EXPECT_EQ(BarVal, FooPointeeVal); }); It's unfortuante that all of these checks have gone away. I think the test was actually trying to test

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2641 TEST(TransferTest, VarDeclInDoWhile) { std::string Code = R"( Could you update the test name to reflect what the test is checking now? (the comment t

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

erichkeane added a comment. In D149645#4312190 , @tbaeder wrote: > In D149645#4312162 , @erichkeane > wrote: > >> For C, should we instead be teaching our boolean operations to understand it >> might be int? I

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

tbaeder added a comment. In D149645#4312162 , @erichkeane wrote: > For C, should we instead be teaching our boolean operations to understand it > might be int? I fear this will end up causing conversion problems later, > such as with: > > `int F = 1 >

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

kinu updated this revision to Diff 518702. kinu added a comment. Changing the existing test to reflect the flag change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149640/new/ https://reviews.llvm.org/D149640 Files: clang/lib/Analysis/FlowSensi

[PATCH] D149649: Update comment.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [class.rel] has been renamed to [class.compare.secondary]. Repository: rG LL

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626

[PATCH] D149634: [clang][Interp] Implement inc/dec operators for floats

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks right to me. Comment at: clang/lib/AST/Interp/Floating.h:132 +*R = Floating(A.F); + +return R->F.add(One, RM); Extra new line vs t

[PATCH] D149645: [clang][Interp] Optionally cast comparison result to non-bool

erichkeane added a comment. For C, should we instead be teaching our boolean operations to understand it might be int? I fear this will end up causing conversion problems later, such as with: `int F = 1 > 2;`. We won't end up having a conversion operation there, since the RHS is already `int

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 518698. skatrak added a comment. Rebase. Disable some known failing 'declare target' tests temporarily until they are fixed by parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://re

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added a comment. In D144634#4308872 , @koops wrote: > 1. Taken care of some of the comments by Alexey. > 2. Added extra tests of loop_bind_messages.cpp > > However, generic_loop_messages.cpp & generic_loop_ast_print.cpp are present > and provide

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6241-6244 def ext_flexible_array_empty_aggregate_ms : Extension< "flexible array member %0 in otherwise empty " "%select{struct|interface|union|class|enum}1 is a Microsoft extensi

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon updated this revision to Diff 518695. Fznamznon added a comment. Rebase, add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D148308: [RISCV][RISCV][clang] Split out SiFive VCIX C intrinsics from riscv_vector.td

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa43608d1649: [RISCV][RISCV][clang] Split out SiFive Vector C intrinsics from riscv_vector.td (authored by 4vtomat). Changed prior to commit: http

[clang] fa43608 - [RISCV][RISCV][clang] Split out SiFive Vector C intrinsics from riscv_vector.td

Author: 4vtomat Date: 2023-05-02T05:51:51-07:00 New Revision: fa43608d1649553814a179cd76d67ea7bdc068d3 URL: https://github.com/llvm/llvm-project/commit/fa43608d1649553814a179cd76d67ea7bdc068d3 DIFF: https://github.com/llvm/llvm-project/commit/fa43608d1649553814a179cd76d67ea7bdc068d3.diff LOG:

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperD

<    1   2   3   >