[PATCH] D149657: [clang-format] Don't indent Verilog `begin` keyword on its own line

2023-05-06 Thread sstwcw via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdf722b01246d: [clang-format] Dont indent Verilog `begin` keyword on its own line (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149561: [clang-format] Recognize Verilog edge identifiers

2023-05-06 Thread sstwcw via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe12428557a45: [clang-format] Recognize Verilog edge identifiers (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149561/new/

[clang] e124285 - [clang-format] Recognize Verilog edge identifiers

2023-05-06 Thread via cfe-commits
Author: sstwcw Date: 2023-05-07T05:13:04Z New Revision: e12428557a4545c0bd1b277dac2d5b56cae3c156 URL: https://github.com/llvm/llvm-project/commit/e12428557a4545c0bd1b277dac2d5b56cae3c156 DIFF: https://github.com/llvm/llvm-project/commit/e12428557a4545c0bd1b277dac2d5b56cae3c156.diff LOG:

[clang] df722b0 - [clang-format] Don't indent Verilog `begin` keyword on its own line

2023-05-06 Thread via cfe-commits
Author: sstwcw Date: 2023-05-07T05:13:04Z New Revision: df722b01246de56a1d3c6f5b1e7aaa881c39f642 URL: https://github.com/llvm/llvm-project/commit/df722b01246de56a1d3c6f5b1e7aaa881c39f642 DIFF: https://github.com/llvm/llvm-project/commit/df722b01246de56a1d3c6f5b1e7aaa881c39f642.diff LOG:

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

2023-05-06 Thread WÁNG Xuěruì via Phabricator via cfe-commits
xen0n added a comment. From a LoongArch developer's perspective, it may be better to only enable UAL for LA464 and other supporting models, instead of for the generic `loongarch64` model too. This is because although all server- and desktop-class LoongArch models have UAL, the embedded-class

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

2023-05-06 Thread Chris Cotter via Phabricator via cfe-commits
ccotter added a comment. bump please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

2023-05-06 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 520143. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

2023-05-06 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2762 // These comments should *not* be aligned - EXPECT_NE( // change for EQ when fixed + EXPECT_EQ( // change for EQ when fixed "#if FOO\n" rymiel wrote: >

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

2023-05-06 Thread Emilia Kond via Phabricator via cfe-commits
rymiel added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2762 // These comments should *not* be aligned - EXPECT_NE( // change for EQ when fixed + EXPECT_EQ( // change for EQ when fixed "#if FOO\n" Should probably get

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

2023-05-06 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. See D150057 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134042/new/ https://reviews.llvm.org/D134042 ___ cfe-commits mailing list

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

2023-05-06 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added a reviewer: mitchell-stellar. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Since 3.8 or earlier,

[PATCH] D141892: Implement modernize-use-constraints

2023-05-06 Thread Chris Cotter via Phabricator via cfe-commits
ccotter added a comment. Addressed all comments except for the `handleReturnType` one which I responded to - let me know your thoughts, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892

[PATCH] D141892: Implement modernize-use-constraints

2023-05-06 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 520125. ccotter added a comment. - Better handling for ctor inits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

2023-05-06 Thread Chris Cotter via Phabricator via cfe-commits
ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:247-248 +ParamsRange.getEnd(), SM, LangOpts, tok::r_paren, tok::r_paren); +return

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [6/6]

2023-05-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/CodeGen/ABIInfo.h:98 +/// isHomogeneousAggregate - Return true if a type is an ELFv2 homogeneous +/// aggregate. Base is set to the base element type, and Members is set Remove

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

2023-05-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/test/MC/X86/intel-syntax-branch-fail.s:5 +// call [offset fn_ref] +// // TODO-CHECK: {{.*}}intel-syntax-branch-fail.s:[[#@LINE+-1]]:1: error: `OFFSET` operator cannot be used in an unconditional branch +// jmp [offset fn_ref]

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

2023-05-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/test/MC/X86/intel-syntax-branch-fail.s:1 +// RUN: not llvm-mc -triple i686-unknown-unknown -x86-asm-syntax=intel %s 2>&1 | FileCheck %s + Don't create a separate test for negative tests. Use the `--defsym=ERR=1`

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

2023-05-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:2662 +// TODO: Consider making the `call [offset fn_ref]` syntax an error? +#if 0 +if (!PtrInOperand && SM.isOffsetOperator()) I think this patch can be pushed now.

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

2023-05-06 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:3387 + } + case RISCV::CM_POPRET: + case RISCV::CM_POPRETZ: Why is this needed? Comment at:

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

2023-05-06 Thread Ivan Murashko via Phabricator via cfe-commits
ivanmurashko updated this revision to Diff 520117. ivanmurashko added a comment. windows marked as non supported Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

2023-05-06 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15357 - if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || Result.HasSideEffects) -return false; + { +FullExpressionRAII Scope(Info); Can you add a comment explaining why

[libunwind] f56ea14 - [libunwind] Unwind through Linux riscv sigreturn trampoline

2023-05-06 Thread Fangrui Song via cfe-commits
Author: Feng Wang Date: 2023-05-06T11:17:02-07:00 New Revision: f56ea14c299490671c1c157a6fb08ce3e452be2d URL: https://github.com/llvm/llvm-project/commit/f56ea14c299490671c1c157a6fb08ce3e452be2d DIFF: https://github.com/llvm/llvm-project/commit/f56ea14c299490671c1c157a6fb08ce3e452be2d.diff

[PATCH] D141892: Implement modernize-use-constraints

2023-05-06 Thread Chris Cotter via Phabricator via cfe-commits
ccotter updated this revision to Diff 520104. ccotter marked 3 inline comments as done. ccotter added a comment. Fix bug, other cleanups, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[clang-tools-extra] b857645 - [clangd] Fix missing dependency on clang/Driver/Options.inc's tblgen target

2023-05-06 Thread Jon Roelofs via cfe-commits
Author: Jon Roelofs Date: 2023-05-06T10:11:39-07:00 New Revision: b8576450c7c7469483fe01c3129071b307b7e6b5 URL: https://github.com/llvm/llvm-project/commit/b8576450c7c7469483fe01c3129071b307b7e6b5 DIFF: https://github.com/llvm/llvm-project/commit/b8576450c7c7469483fe01c3129071b307b7e6b5.diff

[PATCH] D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64

2023-05-06 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc1ab19850d5c: [Clang][OpenMP]Solved the the always truth condition in Arm64 (authored by samuelmaina, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c1ab198 - [Clang][OpenMP]Solved the the always truth condition in Arm64

2023-05-06 Thread Shivam Gupta via cfe-commits
Author: Samuel Maina Date: 2023-05-06T22:00:00+05:30 New Revision: c1ab19850d5c42a6f76d9bd6049f9cba6e08fba1 URL: https://github.com/llvm/llvm-project/commit/c1ab19850d5c42a6f76d9bd6049f9cba6e08fba1 DIFF: https://github.com/llvm/llvm-project/commit/c1ab19850d5c42a6f76d9bd6049f9cba6e08fba1.diff

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

2023-05-06 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.h:20 +if (ReplacementPrintFunction == "std::print") + return LangOpts.CPlusPlus2b; +return LangOpts.CPlusPlus; This will need rebasing and changing

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-05-06 Thread Jorge Pinto Sousa via Phabricator via cfe-commits
sousajo added a comment. have been sick, and could not advance much except I added the tests to replicate the issue. Any ideas on how to proceed here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276

[clang-tools-extra] 9ad45b4 - [clang-tidy] Modernize HungarianNotationOption (NFC)

2023-05-06 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-06T08:56:27-07:00 New Revision: 9ad45b4ab72cbb7acd15fdbea9aefcd66bf867e7 URL: https://github.com/llvm/llvm-project/commit/9ad45b4ab72cbb7acd15fdbea9aefcd66bf867e7 DIFF: https://github.com/llvm/llvm-project/commit/9ad45b4ab72cbb7acd15fdbea9aefcd66bf867e7.diff

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

2023-05-06 Thread Ivan Murashko via Phabricator via cfe-commits
ivanmurashko updated this revision to Diff 520096. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

2023-05-06 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdd6a58babc85: [Sema] Avoid emitting warnings for constant destruction. (authored by pkasting, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] dd6a58b - [Sema] Avoid emitting warnings for constant destruction.

2023-05-06 Thread Shivam Gupta via cfe-commits
Author: Peter Kasting Date: 2023-05-06T20:54:22+05:30 New Revision: dd6a58babc853d180b9a7e5bd709ae12477da004 URL: https://github.com/llvm/llvm-project/commit/dd6a58babc853d180b9a7e5bd709ae12477da004 DIFF: https://github.com/llvm/llvm-project/commit/dd6a58babc853d180b9a7e5bd709ae12477da004.diff

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

2023-05-06 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:546 addLinkerCompressDebugSectionsOption(getToolChain(), Args, CmdArgs); AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs, JA); + Args.AddAllArgs(CmdArgs, options::OPT_L);

[PATCH] D150040: [clang][Interp] Call invalid destructors

2023-05-06 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to call them like any other function, so

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

2023-05-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:546 addLinkerCompressDebugSectionsOption(getToolChain(), Args, CmdArgs); AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs, JA); + Args.AddAllArgs(CmdArgs, options::OPT_L);

[PATCH] D149548: [IR] Update to use new shufflevector semantics

2023-05-06 Thread Manuel Brito via Phabricator via cfe-commits
ManuelJBrito added a reviewer: nemanjai. ManuelJBrito added a comment. Hello Nemanja is the change codegen for vec_promote OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149548/new/ https://reviews.llvm.org/D149548

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

2023-05-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 520085. cor3ntin added a comment. Address @tbaeder feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

2023-05-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The logic of whether an entity needs to be captured has become quite complex and the recent changes in

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

2023-05-06 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } aaron.ballman wrote: > Nit: nothing actually tests that this

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

2023-05-06 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:15356-15360 - if (!::EvaluateInPlace(Result.Val, Info, LVal, this) || Result.HasSideEffects) + FullExpressionRAII Scope(Info); + if (!::EvaluateInPlace(Result.Val, Info, LVal, this) ||

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-05-06 Thread Andrey Ali Khan Bolshakov via Phabricator via cfe-commits
bolshakov-a updated this revision to Diff 520080. bolshakov-a added a comment. Rebased; somehow incorrectly merged `ReleaseNotes.rst` fixed. `CXX/drs/dr12xx.cpp` starts to show that clang accepts now references to bitfields as template arguments in C++20 mode. It is probably not OK. CHANGES

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

2023-05-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #62462 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150036 Files:

[PATCH] D149904: Generic selection expressions that accept a type operand

2023-05-06 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:5691 + unsigned getIndexOfControllingExpression() const { +// If controlled by an expression, the first offset into the Stmt * aaron.ballman wrote: > erichkeane wrote: > > What is

[PATCH] D149723: [clang-tidy] Optimize performance of RenamerClangTidyCheck

2023-05-06 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1c282052624f: [clang-tidy] Optimize performance of RenamerClangTidyCheck (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149723/new/

[clang-tools-extra] 1c28205 - [clang-tidy] Optimize performance of RenamerClangTidyCheck

2023-05-06 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-05-06T12:23:06Z New Revision: 1c282052624f9d0bd273bde0b47b30c96699c6c7 URL: https://github.com/llvm/llvm-project/commit/1c282052624f9d0bd273bde0b47b30c96699c6c7 DIFF: https://github.com/llvm/llvm-project/commit/1c282052624f9d0bd273bde0b47b30c96699c6c7.diff LOG:

[PATCH] D149518: [clang][NFC] Optimize clang::ASTNodeKind::isBaseOf

2023-05-06 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3d16514d061: [clang][NFC] Optimize clang::ASTNodeKind::isBaseOf (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] c3d1651 - [clang][NFC] Optimize clang::ASTNodeKind::isBaseOf

2023-05-06 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-05-06T12:22:28Z New Revision: c3d16514d061be30636eca89a8a8a35d06847fe0 URL: https://github.com/llvm/llvm-project/commit/c3d16514d061be30636eca89a8a8a35d06847fe0 DIFF: https://github.com/llvm/llvm-project/commit/c3d16514d061be30636eca89a8a8a35d06847fe0.diff LOG:

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

2023-05-06 Thread Yingchi Long via Phabricator via cfe-commits
inclyc accepted this revision. inclyc added a comment. This revision is now accepted and ready to land. I think this fix is simple and straightforward and resolved the problem mentioned on GH. However, please wait for #clang-language-wg member's

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

2023-05-06 Thread Ivan Murashko via Phabricator via cfe-commits
ivanmurashko updated this revision to Diff 520069. ivanmurashko added a comment. small fix at the lit-test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

2023-05-06 Thread Piotr Zegar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5902bb9584d6: [clang-tidy] Implement cppcoreguidelines F.19 (authored by ccotter, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 5902bb9 - [clang-tidy] Implement cppcoreguidelines F.19

2023-05-06 Thread Piotr Zegar via cfe-commits
Author: Chris Cotter Date: 2023-05-06T10:49:23Z New Revision: 5902bb9584d686789a80005b35de1b2c2e2ce0b4 URL: https://github.com/llvm/llvm-project/commit/5902bb9584d686789a80005b35de1b2c2e2ce0b4 DIFF: https://github.com/llvm/llvm-project/commit/5902bb9584d686789a80005b35de1b2c2e2ce0b4.diff LOG:

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

2023-05-06 Thread Ivan Murashko via Phabricator via cfe-commits
ivanmurashko updated this revision to Diff 520062. ivanmurashko added a comment. `split-file` was used for lit-test simplification (see @ChuanqiXu comment) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

2023-05-06 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 520047. ChuanqiXu added a comment. Code cleanup and gentle ping~. Given this is small and innocent, I'd like to land this in 2 weeks if no comments come in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148506/new/

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

2023-05-06 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu updated this revision to Diff 520046. VincentWu added a comment. rebase & address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files:

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

2023-05-06 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL updated this revision to Diff 520043. PiotrZSL added a comment. Add delayed template parsing in tests (to fix windows tests) Reorder release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [6/6]

2023-05-06 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 updated this revision to Diff 520041. barannikov88 added a comment. - Move misplaced isHomogenousAggregate definition - Rearrange definitions in ABIInfo.cpp to match the order of declarations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150021: [RISCV] Make zve32f imply F and zve64d imply D.

2023-05-06 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan accepted this revision. jacquesguan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150021/new/ https://reviews.llvm.org/D150021

[PATCH] D148457: [clangd] Support macro evaluation on hover

2023-05-06 Thread Younan Zhang via Phabricator via cfe-commits
zyounan added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150021: [RISCV] Make zve32f imply F and zve64d imply D.

2023-05-06 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: asb, kito-cheng, reames, frasercrmck, rogfer01. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[clang-tools-extra] 283427a - [clang-tidy] Modernize Handler (NFC)

2023-05-06 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-06T00:02:56-07:00 New Revision: 283427afd41097a04e5d0db95877c7a0bc10c7df URL: https://github.com/llvm/llvm-project/commit/283427afd41097a04e5d0db95877c7a0bc10c7df DIFF: https://github.com/llvm/llvm-project/commit/283427afd41097a04e5d0db95877c7a0bc10c7df.diff

[clang-tools-extra] 38d8b1f - [clangd] Replace None with std::nullopt in comments (NFC)

2023-05-06 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-05-06T00:02:53-07:00 New Revision: 38d8b1f2b4c41cb9b7559db971772885c1ef86ad URL: https://github.com/llvm/llvm-project/commit/38d8b1f2b4c41cb9b7559db971772885c1ef86ad DIFF: https://github.com/llvm/llvm-project/commit/38d8b1f2b4c41cb9b7559db971772885c1ef86ad.diff

[clang] 5326c9e - Revert "Give NullabilityKind a printing operator<<"

2023-05-06 Thread Caroline Tice via cfe-commits
Author: Caroline Tice Date: 2023-05-05T23:37:30-07:00 New Revision: 5326c9e480d70e16c2504cb5143524aff3ee2605 URL: https://github.com/llvm/llvm-project/commit/5326c9e480d70e16c2504cb5143524aff3ee2605 DIFF: https://github.com/llvm/llvm-project/commit/5326c9e480d70e16c2504cb5143524aff3ee2605.diff

[PATCH] D149650: Give NullabilityKind a printing operator<

2023-05-06 Thread Caroline Tice via Phabricator via cfe-commits
cmtice added a comment. This is breaking some of our tests. I will give the author a reproducible test case. I am going to revert this while waiting for a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149650/new/

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

2023-05-06 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149579/new/ https://reviews.llvm.org/D149579