[PATCH] D151356: [OpenMP] Fix transformed loop's var privacy

jdenny created this revision. jdenny added reviewers: Meinersbur, ABataev. jdenny added a project: OpenMP. Herald added subscribers: sunshaoce, zzheng, guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

craig.topper added a comment. In D150670#4367736 , @pmatos wrote: > In D150670#4352094 , @craig.topper > wrote: > >>> Preventing the simplification means adding target specific code in >>> instcombine which

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

yaxunl added a comment. In D150985#4357207 , @tra wrote: > The code changes look OK to me. > > Whether allowing FP for clang builtins is OK -- I have no idea, especially > for the c11 ones. hardware atomic fmax/fmin instructions are added because users

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

MaskRay added a comment. In D151186#4369181 , @phosek wrote: > That alias is already recognized by the GNU driver. I'm sharing the > implementation between the two drivers. Would you prefer to reject `-nopie` > when targeting Fuchsia? Hmm, handling

[PATCH] D151186: [Driver] Properly handle -pie and -nopie on Fuchsia

phosek added a comment. That alias is already recognized by the GNU driver. I'm sharing the implementation between the two drivers. Would you prefer to reject `-nopie` when targeting Fuchsia? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

Fznamznon added inline comments. Comment at: clang/test/CodeGenCXX/gh62818.cpp:1 +// RUN: %clang_cc1 -no-opaque-pointers -std=c++17 -emit-llvm -triple x86_64-linux-gnu -o - %s | FileCheck %s + Why no opaque pointers? AFAIK since LLVM 17 typed pointers are not

[clang] b46be15 - Publicly document the C & C++ Language WG meetings

Author: Aaron Ballman Date: 2023-05-24T13:39:18-04:00 New Revision: b46be151d25f88457338e27b5ab0e7f027ebe7ce URL: https://github.com/llvm/llvm-project/commit/b46be151d25f88457338e27b5ab0e7f027ebe7ce DIFF: https://github.com/llvm/llvm-project/commit/b46be151d25f88457338e27b5ab0e7f027ebe7ce.diff

[clang] 61262f9 - Fix shared library build from 1c9a800.

Author: Amy Kwan Date: 2023-05-24T12:29:23-05:00 New Revision: 61262f9ef4194963c3231932e39f11d89cf80a12 URL: https://github.com/llvm/llvm-project/commit/61262f9ef4194963c3231932e39f11d89cf80a12 DIFF: https://github.com/llvm/llvm-project/commit/61262f9ef4194963c3231932e39f11d89cf80a12.diff

[PATCH] D151350: [OpenMP] Extend omp teams to permit nested omp tile

jdenny updated this revision to Diff 525250. jdenny added a comment. Added phab review number to status doc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151350/new/ https://reviews.llvm.org/D151350 Files: clang/docs/OpenMPSupport.rst clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151235: [Clang] Switch from TransformExpr to TransformInitializer in places we need to revert initializer to it syntactic form for Sema

shafik updated this revision to Diff 525248. shafik added a comment. - Update test gh62818.cpp to be more precise CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151235/new/ https://reviews.llvm.org/D151235 Files: clang/lib/Sema/TreeTransform.h

[PATCH] D151350: [OpenMP] Extend omp teams to permit nested omp tile

jdenny created this revision. jdenny added reviewers: Meinersbur, ABataev, jhuber6, jdoerfert. jdenny added projects: OpenMP, OpenACC. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a reviewer: clementval. Herald added a project: All. jdenny requested review of this revision.

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

yaxunl created this revision. yaxunl added reviewers: b-sumner, arsenm, tra. Herald added subscribers: kerbowa, hiraditya, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: llvm-commits, wdng. Herald added a project: LLVM. HIP texture/image

[PATCH] D151342: [Clang] Correctly handle generic lambda used as default template argument.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. So I think this is the right approach here. Unfortunately my knowledge of the parser is a little wonky, so I don't feel comfortable JUST approving this right away(though it DOES look

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

MaskRay added a comment. Herald added a subscriber: JDevlieghere. Thank you for making another try for the treewide change (which is admittedly very painful and not many people do such work). Can you include the original patch description to the summary? That is the main part and the message

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga added a comment. Jobs are now passing, CC: @nlopes @chandlerc @jgalenson for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 ___

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin marked 2 inline comments as done. yronglin added a comment. Thanks, maybe I can do these trivially change in separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin updated this revision to Diff 525224. yronglin added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst

[PATCH] D150966: [clang] Don't define predefined macros multiple times

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78bf8a0a2212: [clang] Dont define predefined macros multiple times (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 78bf8a0 - [clang] Don't define predefined macros multiple times

Author: John Brawn Date: 2023-05-24T17:28:41+01:00 New Revision: 78bf8a0a2212c1826ce2a9c0f98c73e9b9b16367 URL: https://github.com/llvm/llvm-project/commit/78bf8a0a2212c1826ce2a9c0f98c73e9b9b16367 DIFF: https://github.com/llvm/llvm-project/commit/78bf8a0a2212c1826ce2a9c0f98c73e9b9b16367.diff

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill marked an inline comment as done. Endill added a comment. Thank for for providing a nice explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill updated this revision to Diff 525216. Endill added a comment. Add missing comma after enum item Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files:

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. I've created D151344 @glandium @hans @thakis I really would appreciate when you can test the patch locally to avoid another revert round. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

Mordante created this revision. Mordante added reviewers: glandium, hans, thakis. Herald added subscribers: libc-commits, bviyer, ekilmer, Moerafaat, zero9178, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D151342: [Clang] Correctly handle generic lambda used as default template argument.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adjust the template pparameter depth when parsing default template arguments as they may introduce generic lambda whose

[PATCH] D150966: [clang] Don't define predefined macros multiple times

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Preprocessor/predefined-macros-no-warnings.c:5 +// warnings suppressed by default. +// RUN: %clang_cc1 %s -E -o /dev/null

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

aaron.ballman added a comment. > This patch introduces a `// expected-maybe-not-diagnostic` that silence typo in the summary, it introduces `// expected-maybe-no-diagnostics` To save other reviewers some clicking around, the reason why this is being proposed is because we want to use the

[PATCH] D151192: [clang-tidy] have bugprone-unchecked-optional-access check boost::optional usage

muggenhor added a comment. FYI: I've added a set of tests. But in the process discovered there's at least one assumption that doesn't hold for boost::optional. So I'll have to adjust the implementation for that. That's a bit more involved change, so will take some time. (Specifically the

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > nikic wrote: > > nikic

[PATCH] D146809: [clang-repl] Implement Value pretty printing

aaron.ballman added a comment. I didn't have the chance to complete my review (this is a pretty massive change), but here are some in-progress comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:105 + Parser () const; + const mismatch here

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. If you are really determined to do this, then OK. I'm in a very bad mood and I don't want to spend my mental strength on debating (esp. on a corner case unlikely to affect "real" code) anymore. But remember to add a entry in GCC 14 changes.html, and test this thing:

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > nikic wrote: > > hnrklssn

[PATCH] D151339: [OpenCL] Add cl_ext_image_raw10_raw12 extension

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the defines for the

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 525174. hnrklssn added a comment. Herald added a subscriber: ormris. Overhauled how update_cc_tests.py checks globals It now: - no longer matches the literal names, like update_test_checks.py does unless --preserve-names (which doesn't seem to see much

[PATCH] D151337: ARM: default to arm_aapcscc (or VFP) for embedded MachO targets.

t.p.northover created this revision. Herald added subscribers: kristof.beyls, mcrosier. Herald added a project: All. t.p.northover requested review of this revision. Herald added a project: clang. These were always intended to be AAPCS targets and LLVM does treat the usual C calling convention

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn updated this revision to Diff 525165. john.brawn added a comment. Use -Eonly in test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150966/new/ https://reviews.llvm.org/D150966 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/ARM.cpp

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:241-242 Builder.defineMacro("__ARM_FEATURE_QRDMX", "1"); - Builder.defineMacro("__ARM_FEATURE_ATOMICS", "1"); - Builder.defineMacro("__ARM_FEATURE_CRC32", "1"); }

[clang] 77908ef - [clang][NFC] Add a blank line in ReleaseNotes.rst

Author: Sheng Date: 2023-05-24T22:02:41+08:00 New Revision: 77908efab4391e7d401480c6cec307a5c45f1cce URL: https://github.com/llvm/llvm-project/commit/77908efab4391e7d401480c6cec307a5c45f1cce DIFF: https://github.com/llvm/llvm-project/commit/77908efab4391e7d401480c6cec307a5c45f1cce.diff LOG:

[PATCH] D151062: [clang][Sema] Fix a crash when instantiating a non-type template argument in a dependent scope.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcde139016a4e: [clang][Sema] Fix a crash when instantiating a non-type template argument in a… (authored by 0x59616e). Herald added a project: clang.

[clang] cde1390 - [clang][Sema] Fix a crash when instantiating a non-type template argument in a dependent scope.

Author: Sheng Date: 2023-05-24T21:46:31+08:00 New Revision: cde139016a4eb2d71950e135f9c037987ecdb7cf URL: https://github.com/llvm/llvm-project/commit/cde139016a4eb2d71950e135f9c037987ecdb7cf DIFF: https://github.com/llvm/llvm-project/commit/cde139016a4eb2d71950e135f9c037987ecdb7cf.diff LOG:

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

nikic added a comment. In D150670#4368241 , @pmatos wrote: > In D150670#4368238 , @pmatos wrote: > >> In D150670#4352163 , @nikic wrote: >> >>> 1. Say that we prefer

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4368238 , @pmatos wrote: > In D150670#4352163 , @nikic wrote: > >> 1. Say that we prefer preserving rotates over "simplifying" funnel shifts >> (ending up with the rot2

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4352163 , @nikic wrote: > 1. Say that we prefer preserving rotates over "simplifying" funnel shifts > (ending up with the rot2 pattern). Basically by skipping the optimization at >

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

steakhal added a comment. Please leave a link in the summary to the RFC to discuss. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325 ___ cfe-commits mailing

[clang-tools-extra] 32ffc55 - [clang-tidy] Really fix rG9182c679dde7

Author: Clement Courbet Date: 2023-05-24T15:21:50+02:00 New Revision: 32ffc1feda4cf3eeec5740af5c5f386e584c URL: https://github.com/llvm/llvm-project/commit/32ffc1feda4cf3eeec5740af5c5f386e584c DIFF:

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

CarolineConcatto updated this revision to Diff 525146. CarolineConcatto marked an inline comment as done. CarolineConcatto edited the summary of this revision. CarolineConcatto added a comment. -Address review's comments about Q target type. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

aaron.ballman added a comment. In D151092#4368225 , @courbet wrote: > In D151092#4368151 , @aaron.ballman > wrote: > >> The release note references documentation that doesn't exist, so Sphinx is >> failing:

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

courbet added a comment. In D151092#4368151 , @aaron.ballman wrote: > The release note references documentation that doesn't exist, so Sphinx is > failing: https://lab.llvm.org/buildbot/#/builders/115/builds/46942 Sorry, fixed in rG62dc3ba8442f

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

ronlieb added a comment. seeing this issue in our downstream builders: [2023-05-24T11:46:07.333Z] /opt/rocm-5.6.0-12074/llvm/lib/clang/17.0.0/include/cpuid.h:333:22: error: static declaration of '__cpuidex' follows non-static declaration [2023-05-24T11:46:07.333Z] static __inline void

[clang-tools-extra] 62dc3ba - [clang-tidy]Fix rG9182c679dde7cb6480e66b9231a53d43ad03908b

Author: Clement Courbet Date: 2023-05-24T15:19:00+02:00 New Revision: 62dc3ba8442fa3f7003d46d2838307452a0391f4 URL: https://github.com/llvm/llvm-project/commit/62dc3ba8442fa3f7003d46d2838307452a0391f4 DIFF:

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

aaron.ballman added a comment. The release note references documentation that doesn't exist, so Sphinx is failing: https://lab.llvm.org/buildbot/#/builders/115/builds/46942 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151092/new/

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

aaron.ballman added a comment. In D150528#4368023 , @yronglin wrote: > In D150528#4365688 , @aaron.ballman > wrote: > >> In general, I think this is looking pretty good, thank you! I'll leave it to >>

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All.

[PATCH] D151301: [clang][Diagnostics] Print empty lines in multiline snippets

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Misc/diag-style.cpp:10 +// CHECK-NEXT: {{^}} | ^~~~{{$}} +// CHECK-NEXT: {{^}}5 | {{$}} +// CHECK-NEXT:

[clang-tools-extra] 9182c67 - [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

Author: Clement Courbet Date: 2023-05-24T15:05:39+02:00 New Revision: 9182c679dde7cb6480e66b9231a53d43ad03908b URL: https://github.com/llvm/llvm-project/commit/9182c679dde7cb6480e66b9231a53d43ad03908b DIFF:

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9182c679dde7: [clang-tidy]performance-no-automatic-move: fix false negative on `const T`… (authored by courbet). Repository: rG LLVM Github

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

erichkeane requested changes to this revision. erichkeane added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1343 const ConstantArrayType *CAT = CGM.getContext().getAsConstantArrayType(T); +assert(CAT

[PATCH] D151286: [clang][Diagnostics][NFC] Don't create oversized CaretLine

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151286/new/ https://reviews.llvm.org/D151286

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

michaelplatings accepted this revision. michaelplatings added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://reviews.llvm.org/D151308 ___ cfe-commits mailing list

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin added a comment. In D150528#4365688 , @aaron.ballman wrote: > In general, I think this is looking pretty good, thank you! I'll leave it to > @erichkeane to do the final sign-off as attributes code owner since this is > making a fair number of

[PATCH] D151214: [clang][Sema] `-Wshadow` warns about shadowings by static local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG29dc47a9eeeb: [clang][Sema] `-Wshadow` warns about shadowings by static local variables (authored by hazohelet). Changed prior to commit: https://reviews.llvm.org/D151214?vs=524709=525126#toc

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG456d072405d2: Reland: [clang][AST] Print name instead of type when diagnosing uninitialized… (authored by hazohelet). Repository: rG LLVM Github

[clang] 29dc47a - [clang][Sema] `-Wshadow` warns about shadowings by static local variables

Author: Takuya Shimizu Date: 2023-05-24T21:31:25+09:00 New Revision: 29dc47a9eeeb2e080170109e3e2fb3cd5aad58d2 URL: https://github.com/llvm/llvm-project/commit/29dc47a9eeeb2e080170109e3e2fb3cd5aad58d2 DIFF:

[clang] 456d072 - Reland: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

Author: Takuya Shimizu Date: 2023-05-24T21:31:25+09:00 New Revision: 456d072405d29ac731ad22fa1ec198b9f8265c4e URL: https://github.com/llvm/llvm-project/commit/456d072405d29ac731ad22fa1ec198b9f8265c4e DIFF:

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. rjmccall wrote: > Suggested

[PATCH] D151321: [clangd] Dont run raw-lexer for OOB source locations

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We can get

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

Endill created this revision. Endill added reviewers: aaron.ballman, hfinkel, dblaikie. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces a `// expected-maybe-not-diagnostic` that

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder added a comment. In D151300#4367943 , @aaron.ballman wrote: > In D151300#4367939 , @tbaeder wrote: > >> In D151300#4367884 , >> @aaron.ballman wrote: >> >>>

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

aaron.ballman added a comment. In D151300#4367939 , @tbaeder wrote: > In D151300#4367884 , @aaron.ballman > wrote: > >> LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` >> and there's

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

tbaeder added a comment. In D151300#4367884 , @aaron.ballman wrote: > LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` > and there's no guarantee that there's not an extra allocation involved as a > result. However, I've not

[PATCH] D151300: [clang][Diagnostics][NFC] Remove unnecessary StringRef

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but it's worth noting that `std::string::pop_back()` calls `erase()` and there's no guarantee that there's not an extra allocation involved as a result. However, I've not

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham updated this revision to Diff 525111. simon_tatham added a comment. Clarify mask construction as @michaelplatings suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://reviews.llvm.org/D151308 Files:

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

aaron.ballman added reviewers: efriedma, rjmccall. aaron.ballman added a comment. Adding codegen code owners as reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151298/new/ https://reviews.llvm.org/D151298

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; While this patch is an improvement, I wonder we should move it further. Has been thinking about

[PATCH] D151315: [clangd] Add a switch to specify a default clangd configuration file

voertler created this revision. voertler added reviewers: dgoldman, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. voertler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xen0n added a comment. FYI, in the matching GCC patch discussion it was suggested that such a treatment wouldn't be necessary in principle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4352094 , @craig.topper wrote: >> Preventing the simplification means adding target specific code in >> instcombine which seems even worse than adding it here given as @dschuff >> pointed out, there's precedent with

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

michaelplatings added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5380-5381 +Builder.CreatePtrToInt(CalleePtr, IntPtrTy); +llvm::Value *AlignedCalleeAddress = Builder.CreateAnd( +CalleeAddress, llvm::ConstantInt::get(IntPtrTy, -2));

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder updated this revision to Diff 525094. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150843/new/ https://reviews.llvm.org/D150843 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

peter.smith added a comment. This looks good to me. Will be worth waiting for a day to give the US time zone time to leave any comments. I note that this is also broken in -fsanitize=kcfi [*] (https://reviews.llvm.org/D135411) although fixing that is a separate patch. Would you be able to

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham updated this revision to Diff 525084. simon_tatham added a comment. How embarrassing. _Really_ upload the clang-formatted version this time. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 525082. vikramRH added a comment. Handled review comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files:

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:194 + NoMovt = false; +assert(hasV6MOps() && "Cannot generate execute-only code for this target"); } tschuett wrote: > What happens in release mode? At the top you now

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 525079. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367620 , @wangleiat wrote: If we want to ignore empty structures, it is not enough to only modify psABI, because the current implementations of gcc and clang do not ignore empty structures in all

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. >>> If we want to ignore empty structures, it is not enough to only modify >>> psABI, because the current implementations of gcc and clang do not ignore >>> empty structures in all cases. For example: >>> >>> struct { struct{}; int i; }; // in this case, the empty

[PATCH] D151293: [clang][ExtractAPI] Refactor serializer to the CRTP

dang requested changes to this revision. dang added a comment. This revision now requires changes to proceed. Great start but there are still some rough edges to polish! Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:19 #include

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return std::make_pair(SmallString<16>(Begin, End), true); + }

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return std::make_pair(SmallString<16>(Begin, End), true); + }

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367496 , @xry111 wrote: > In D151298#4367458 , @wangleiat > wrote: > >>> I think the paragraph means: >>> >>> class Empty {}; >>> int test(Empty empty, int a); >>> >>>

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367458 , @wangleiat wrote: >> I think the paragraph means: >> >> class Empty {}; >> int test(Empty empty, int a); >> >> Then we should put `a` into `a1`, not `a0`. And we are indeed doing so. > > yes. with this

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

krasimir added a comment. Thank you! That's a bug in the raw string format manager. This code effectively first looks for a matching top-level style, and if that's not found, then it tries to derive one via the RawFormat's BasedOnStyle:

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

cor3ntin added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return std::make_pair(SmallString<16>(Begin, End), true); +

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham updated this revision to Diff 525065. simon_tatham added a comment. (oops, forgot to clang-format) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151308/new/ https://reviews.llvm.org/D151308 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham added a comment. I think this began going wrong as a result of D148573 , which enabled `-fsanitize=function` on all targets, where previously it hadn't been running on Arm at all. But I'd rather make it work than turn it off again! Repository:

[PATCH] D151308: -fsanitize=function: fix alignment fault on Arm targets.

simon_tatham created this revision. simon_tatham added reviewers: peter.smith, MaskRay, dmgreen. Herald added a subscriber: kristof.beyls. Herald added a project: All. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Function

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

wangleiat added a comment. > I think the paragraph means: > > class Empty {}; > int test(Empty empty, int a); > > Then we should put `a` into `a1`, not `a0`. And we are indeed doing so. yes. with this patch, `a` will be passed with `a1` register. > I mean now GCC and Clang have the same

[PATCH] D151307: [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As described in:

[PATCH] D151298: [clang][LoongArch] Fix the calling convention for empty struct in C++ mode

xry111 added a comment. In D151298#4367349 , @wangleiat wrote: > In D151298#4367225 , @xry111 wrote: > >> In D151298#4367215 , @wangleiat >> wrote: >> >>> In

<    1   2   3   >