[PATCH] D152285: Add support for the NO_COLOR environment variable

arichardson added a comment. >>> [...] I don't know what compelling use case there is for forcing colors >>> *on*, [...] until we know why users need to force-enable colors. >> >> The reason is that adding `-fcolor-diagnostics` to the command line is not >> always feasible, e.g. most build

[PATCH] D152396: [clang][doc] Rescue some deleted bits of the command-line reference.

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Another argument for not having generated file in-tree. Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152418: [clang] set python3 as required build dependency

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152418/new/ https://reviews.llvm.org/D152418

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

sameerds added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:386-387 +} else { + auto IntTy = dyn_cast(Args[i]->getType()); + if (IntTy && IntTy->getBitWidth() == 32) +WhatToStore.push_back( vikramRH wrote: >

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:267 StructuredBindingPolicy = TypeHintPolicy; StructuredBindingPolicy.PrintCanonicalTypes = true; } zyounan wrote: > nridge wrote: > > zyounan wrote: > > >

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:386-387 +} else { + auto IntTy = dyn_cast(Args[i]->getType()); + if (IntTy && IntTy->getBitWidth() == 32) +WhatToStore.push_back( arsenm wrote: >

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:14427 SDValue Callee = CLI.Callee; + bool IsCFICall = CLI.CB && CLI.CB->isIndirectCall() && CLI.CFIType; bool = CLI.IsTailCall; If `CLI.CFIType != 0`, is

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

MaskRay added a comment. Thanks for the description. The code generally looks good. If the kernel wants a specific code sequence, implementing conditions in the LLVMCodeGen looks good to me. Consider adding a link to the discussion. I wonder whether it will be more useful to give more context

[PATCH] D152418: [clang] set python3 as required build dependency

Avimitin created this revision. Avimitin added reviewers: gribozavr, aaron.ballman, phosek. Herald added a project: All. Avimitin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The required HTMLLogger include file needs python3 to run

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 529494. kushanam added a comment. rebasing and readding the first commit changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files:

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 529491. akshaykhadse added a comment. Rename test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 updated this revision to Diff 529490. jhuber6 added a comment. Updating, in order to do this starting with bitcode I had to expose a helper that performs this operation using the options directly rather than through the `CodeGenModule`. This should keep the existing interfaces intact by

[PATCH] D152250: [Clang][RISCV] Add test cases for intrinsics clz/ctz codegen when has extension zbb/xtheadbb

Yunzezhu abandoned this revision. Yunzezhu added a comment. Abandon this revision because https://reviews.llvm.org/D151867 is abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152250/new/ https://reviews.llvm.org/D152250

[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

Yunzezhu abandoned this revision. Yunzezhu added a comment. In D151867#4401987 , @craig.topper wrote: > In D151867#4401952 , @Yunzezhu > wrote: > >> In D151867#4400255

[PATCH] D152416: add -dump-tokens-bg option for clang

ChuanqiXu added a comment. In D152416#4404862 , @Anarion-zuo wrote: > I see that plugin is a more elegant way of doing this. Do you still want this > as a part of LLVM? No, I don't feel this is needed. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D152416: add -dump-tokens-bg option for clang

Anarion-zuo added a comment. I see that plugin is a more elegant way of doing this. Do you still want this as a part of LLVM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152416/new/ https://reviews.llvm.org/D152416

[PATCH] D152416: add -dump-tokens-bg option for clang

ChuanqiXu added a comment. I think such requirement should be done by something like a plugin or an analysis tool by using clang as a library instead of implementing it in clang compiler itself directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152416: add -dump-tokens-bg option for clang

Anarion-zuo added a comment. We intend to build a deep learning model with code as input, then noticed clang does not currently have a convenient way of dumping tokens in huge projects. The dumped tokens are supposed to be converted to vectors, then given to a deep learning model.

[PATCH] D152416: add -dump-tokens-bg option for clang

ChuanqiXu added a comment. What is the intended use case of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152416/new/ https://reviews.llvm.org/D152416 ___ cfe-commits mailing list

[PATCH] D152416: add -dump-tokens-bg option for clang

Anarion-zuo added a comment. It's my first time here. I don't know if I got everything right. CodeOwners.rst says you guys are relevant somewhat. Thanks! @ChuanqiXu @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152416/new/

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 529485. felix642 added a comment. Improved documentation Removed duplicated messages in tests. Added support for regular expressions Added method to store options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } tra wrote: > Should it be `AuxTI &&

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov added inline comments. Comment at: clang/test/SemaCUDA/neon-attrs.cu:2 +// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature +neon -x cuda -fsyntax-only -DNO_DIAG -verify %s +// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature -neon -x cuda

[PATCH] D152416: add -dump-tokens-bg option for clang

Anarion-zuo created this revision. Herald added a project: All. Anarion-zuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152416 Files:

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

rupprecht added a comment. In D150226#4401188 , @jyknight wrote: > In D150226#4400782 , @rupprecht > wrote: > >> As a general question/feature request: is there a way to have specific >> warnings apply even for

[PATCH] D152415: [RISCV] Add test cases to show that rvv_vectreo-bits attributes is not accepted for vbool or LMUL!=1 RVV types. NFC

craig.topper created this revision. craig.topper added a reviewer: aaron.ballman. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. > Can we extend the test cases to exercise both with and without > relative-vtables also enabled? Yup, the cases here already test with the regular itanium c++ abi and relative vtables abi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc81d2a4d5b3: [OpenMP] Fix using the target ID when using the new driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D150998?vs=523924=529476#toc Repository: rG LLVM

[clang] dc81d2a - [OpenMP] Fix using the target ID when using the new driver

Author: Joseph Huber Date: 2023-06-07T19:17:27-05:00 New Revision: dc81d2a4d5b38a82cdc76c41522e61f0de716904 URL: https://github.com/llvm/llvm-project/commit/dc81d2a4d5b38a82cdc76c41522e61f0de716904 DIFF: https://github.com/llvm/llvm-project/commit/dc81d2a4d5b38a82cdc76c41522e61f0de716904.diff

[clang] 9f00eb9 - Revert "Revert "[clang-format] Fix overlapping replacements before PPDirectives""

Author: Leonard Chan Date: 2023-06-08T00:15:30Z New Revision: 9f00eb99759b62c4a81ce84d686b212e46ec7452 URL: https://github.com/llvm/llvm-project/commit/9f00eb99759b62c4a81ce84d686b212e46ec7452 DIFF: https://github.com/llvm/llvm-project/commit/9f00eb99759b62c4a81ce84d686b212e46ec7452.diff LOG:

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

mcgrathr added a comment. In D152405#4404616 , @leonardchan wrote: > Oh this is completely independent from relative vtables. I'll update the > wording. Great. I'd like to see us try some experiments with enabling both together in places like the

[PATCH] D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses

dwang created this revision. Herald added a project: All. dwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152412 Files: clang/test/CodeGen/lifetime3.cpp Index:

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

thakis added a comment. Looks like the revert broke tests: http://45.33.8.238/linux/109159/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 ___

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:386-387 +} else { + auto IntTy = dyn_cast(Args[i]->getType()); + if (IntTy && IntTy->getBitWidth() == 32) +WhatToStore.push_back( vikramRH wrote: >

[clang] 94e7546 - Revert "[clang-format] Fix overlapping replacements before PPDirectives"

Author: Leonard Chan Date: 2023-06-07T23:44:32Z New Revision: 94e75469597f197f9c4b45baa6c8a576c78dbd02 URL: https://github.com/llvm/llvm-project/commit/94e75469597f197f9c4b45baa6c8a576c78dbd02 DIFF: https://github.com/llvm/llvm-project/commit/94e75469597f197f9c4b45baa6c8a576c78dbd02.diff LOG:

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

tra added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } Should it be `AuxTI && (AuxTI->getTriple().isAArch64() ||

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

dblaikie added a comment. https://github.com/llvm/llvm-project/issues/63169 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 ___ cfe-commits mailing list

[clang] e3f91ac - Fix namespace of operator<< defn

Author: Sam McCall Date: 2023-06-08T01:36:59+02:00 New Revision: e3f91acad38e6637f1589bb4b33e9c4b8b58581f URL: https://github.com/llvm/llvm-project/commit/e3f91acad38e6637f1589bb4b33e9c4b8b58581f DIFF: https://github.com/llvm/llvm-project/commit/e3f91acad38e6637f1589bb4b33e9c4b8b58581f.diff

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4404596 , @mcgrathr wrote: > It's not clear from the change description if this can be enabled > orthogonally to relative-vtables. I think it should be possible to choose > each switch independently, thus

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. In D149162#4404379 , @fmayer wrote: > In D149162#4404271 , @agozillon > wrote: > >> I have hopefully fixed the sanitizer issue (the incorrect assert, thank you >> again for the catch)

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. Scratch that, `ASTContext::getFunctionFeatureMap` is used. I wonder if we could forgo that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152391

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

mcgrathr added a comment. It's not clear from the change description if this can be enabled orthogonally to relative-vtables. I think it should be possible to choose each switch independently, thus generating 4 variants of the vtable layout ABI. Does any runtime code (libc++abi) ever need to

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a project: All. leonardchan requested review of this revision. Herald added a subscriber: MaskRay. For programs that don't use RTTI, the rtti component is just

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov created this revision. alexander-shaposhnikov added a reviewer: tra. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. alexander-shaposhnikov requested review of this

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. Just realized this is probably going to be a bit more painful. the attribute propagation pass requires a `CodeGenModule` which isn't built without an `ASTContext` so it's not available here. Nothing those functions do explicitly requires the full `CGM`, they only use

[PATCH] D152401: CGExprCXX: emit family and allockind attributes

durin42 created this revision. Herald added subscribers: JDevlieghere, hiraditya. Herald added a project: All. durin42 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This allows us to remove most of the special knowledge

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 updated this revision to Diff 529447. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119271/new/ https://reviews.llvm.org/D119271 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 updated this revision to Diff 529446. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D152400: CodeGen: hand two tests to the care of update_cc_test_checks

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These two tests were pretty challenging to manage by hand, and in rebasing the next change in my stack I finally ran out of

[PATCH] D123085: CGExprCXX: emit allocptr attributes for operator delete

durin42 updated this revision to Diff 529444. durin42 requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123085/new/ https://reviews.llvm.org/D123085 Files: clang/lib/CodeGen/CGExprCXX.cpp

[PATCH] D150083: [clang-format] ObjCPropertyAttributeOrder to sort ObjC property attributes

jaredgrubb added a comment. Are there any other comments on this patch? I would love to make this into clang-17! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150083/new/ https://reviews.llvm.org/D150083 ___ cfe-commits mailing list

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added a comment. In D149162#4404271 , @agozillon wrote: > I have hopefully fixed the sanitizer issue (the incorrect assert, thank you > again for the catch) with the following patch: >

[PATCH] D152305: [clang-format] Add the KeepEmptyLinesAtEOF option

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2627cf88d25: [clang-format] Add the KeepEmptyLinesAtEOF option (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152305/new/

[clang] d2627cf - [clang-format] Add the KeepEmptyLinesAtEOF option

Author: Owen Pan Date: 2023-06-07T14:17:58-07:00 New Revision: d2627cf88d2553a4c2e850430bdb908a4b7d2e52 URL: https://github.com/llvm/llvm-project/commit/d2627cf88d2553a4c2e850430bdb908a4b7d2e52 DIFF: https://github.com/llvm/llvm-project/commit/d2627cf88d2553a4c2e850430bdb908a4b7d2e52.diff

[PATCH] D152396: [clang][doc] Rescue some deleted bits of the command-line reference.

efriedma created this revision. efriedma added reviewers: serge-sans-paille, aaron.ballman. Herald added a subscriber: dschuff. Herald added a project: All. efriedma requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. Back when the command-line

[PATCH] D73459: [ARM] Add documentation for -march= and -mfpu= command line options

efriedma reopened this revision. efriedma added a comment. This revision is now accepted and ready to land. Herald added a project: All. This patch was reverted by 9624beb38a46037f69362650a52e06d8be4fd006 . I have a patch

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. I have hopefully fixed the sanitizer issue (the incorrect assert, thank you again for the catch) with the following patch: https://github.com/llvm/llvm-project/commit/309023263dba3b02bc885101faa47d110f662f99 it was a slightly more involved change than I expected, I

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152369/new/ https://reviews.llvm.org/D152369

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8338 // The attribute vector size must match -mrvv-vector-bits. - if (VecSize != VScale->first * MinElts * EltSize) { + unsigned ExpectedSize = VScale->first * MinElts * EltSize; + if (VecSize !=

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc1636815cb: [Clang] Check for abstract parameters only when functions are defined. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D152096?vs=529045=529408#toc Repository:

[clang] 6dc1636 - [Clang] Check for abstract parameters only when functions are defined.

Author: Corentin Jabot Date: 2023-06-07T21:44:14+02:00 New Revision: 6dc1636815cb9321657f1cb7ac87a46553870dc7 URL: https://github.com/llvm/llvm-project/commit/6dc1636815cb9321657f1cb7ac87a46553870dc7 DIFF:

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

HazardyKnusperkeks added a comment. In D151761#4403828 , @galenelias wrote: > In D151761#4400693 , > @HazardyKnusperkeks wrote: > >> I'd say: align it. > > If it was straightforward, I would definitely agree to

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

shafik added inline comments. Comment at: clang/test/SemaTemplate/default-template-arguments.cpp:12 + auto lambda1 = [] {}; // expected-error {{default argument references local variable x_constexpr of enclosing function}} + auto lambda2 = [] {}; // expected-error {{default

[clang] 3090232 - [Clang][OpenMP] Rework recently moved getTargetEntryUniqueInfo to fix incorrect error breaking sanitizer

Author: Andrew Gozillon Date: 2023-06-07T14:30:25-05:00 New Revision: 309023263dba3b02bc885101faa47d110f662f99 URL: https://github.com/llvm/llvm-project/commit/309023263dba3b02bc885101faa47d110f662f99 DIFF:

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529400. scchan added a comment. Removed redundant comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:80 + // directive, since these do not terminate a code block. + if (!Line.InPPDirective && Line.Level < IndentForLevel.size()) +IndentForLevel.resize(Line.Level +

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

rjmccall added inline comments. Comment at: clang/test/SemaObjCXX/parameters.mm:14-17 +struct test2 { virtual void foo() = 0; }; @interface Test2 -- (void) foo: (test2) foo; // expected-error {{parameter type 'test2' is an abstract class}} +- (void) foo: (test2) foo ; @end

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

erichkeane added a comment. In D152335#4404118 , @aaron.ballman wrote: > LGTM with a release note. > > In D152335#4404114 , @erichkeane > wrote: > >> Needs a release note. Also, the changing of order is

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a release note. In D152335#4404114 , @erichkeane wrote: > Needs a release note. Also, the changing of order is POSSIBLY a change in > behavior (in that we're now

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Needs a release note. Also, the changing of order is POSSIBLY a change in behavior (in that we're now diagnosing 'out of range' before 'power of 2'), but I don't think we care.

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a comment. In D152391#4404106 , @tra wrote: >> clang in.bc -Xclang -mlink-builtin-bitcode -Xclang libdevice.10.bc > > If that's something we intend to expose to the user, should we consider > promoting it to a top-level driver option? I'm

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

tra added a comment. > clang in.bc -Xclang -mlink-builtin-bitcode -Xclang libdevice.10.bc If that's something we intend to expose to the user, should we consider promoting it to a top-level driver option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/test/Sema/attr-aligned.c:1 -// RUN: %clang_cc1 -triple i386-apple-darwin9 -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple x86_64-apple-darwin9 -fsyntax-only -verify %s

[PATCH] D152335: [Clang] Add check to Sema::AddAlignedAttr to verify active bits is not out of range

shafik updated this revision to Diff 529396. shafik marked 2 inline comments as done. shafik added a comment. - Switched to using APSInt::operator> as discussed offline w/ Erich and Aaron CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152335/new/ https://reviews.llvm.org/D152335 Files:

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

owenpan added a comment. In D151954#4403921 , @paulkirth wrote: > This patch seems to introduce some significant regressions to formatting. > I've filed https://github.com/llvm/llvm-project/issues/63170 with some > candidate code. I'll try to reduce

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

This revision was automatically updated to reflect the committed changes. Closed by commit rG467688527017: [clang] Implement P2564 consteval must propagate up (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/

[clang] 4676885 - [clang] Implement P2564 "consteval must propagate up"

Author: Corentin Jabot Date: 2023-06-07T20:45:36+02:00 New Revision: 467688527017efb611b09c0cbf92f2d3ecdd1724 URL: https://github.com/llvm/llvm-project/commit/467688527017efb611b09c0cbf92f2d3ecdd1724 DIFF:

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. Thanks for the review and the testing! >> [...] What do you think about this design direction? > > Could you elaborate on this part? In short, this review should've been a discourse thread about my "switch to the PreStmt route" plan: I wanted to ask for

[PATCH] D152207: [HIP] Instruct lld to go through all archives

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:184 + // pair with the --whole-archive being added previously + LldArgs.push_back("--no-whole-archive"); For complete sentences in comments, capitalize and add a full stop.

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

JonChesterfield added a comment. That's cleaner than I expected, thanks. Might be reasonable to factor out the method as an initial NFC then insert the call to it along with the new test case as the functional change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

asb added a comment. In D152279#4403940 , @phosek wrote: > We're planning to default to `-msmall-data-limit=0` for Android and Fuchsia > so I'm supportive of this change because it means less complexity and fewer > differences between platforms. > > I

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, jdoerfert, tianshilei1992, MaskRay, JonChesterfield, phosek. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang provides the

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 added a comment. In D151855#4403879 , @benlangmuir wrote: >> I think it should be fine to allow dropping the >> A.framework/Frameworks/B.framework directory from the reproducer VFS > > I think technically this is wrong, since if you're

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

phosek added a comment. We're planning to default to `-msmall-data-limit=0` for Android and Fuchsia so I'm supportive of this change because it means less complexity and fewer differences between platforms. I think it would be worth bringing up this topic at the RISC-V LLVM sync-up call

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

paulkirth added a comment. I'd also suggest reverting this until it can be fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 ___ cfe-commits mailing list

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

paulkirth added a comment. This patch seems to introduce some significant regressions to formatting. I've filed https://github.com/llvm/llvm-project/issues/63170 with some candidate code. I'll try to reduce the case as I can, but I'm guessing something is incorrect w/ how the indentation level

[PATCH] D152351: [clang] Add __builtin_isfpclass

aaron.ballman added a comment. In D152351#4402785 , @arsenm wrote: > Also should get mentioned in the builtin docs and release notes +1, also, should there be named constants for the mask values? Comment at:

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

benlangmuir added a subscriber: JDevlieghere. benlangmuir added a comment. > I think it should be fine to allow dropping the > A.framework/Frameworks/B.framework directory from the reproducer VFS I think technically this is wrong, since if you're missing the symlink, then A might not build --

[PATCH] D150926: [RISCV] Support LMUL!=1 for __attribute__((riscv_rvv_vector_bits(N)))

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2350 + +``vbool*_t`` types are not supported at this time. }]; Do you have test coverage that demonstrates this? Comment at: clang/lib/AST/Type.cpp:2437

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 updated this revision to Diff 529367. jansvoboda11 added a comment. Fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151855/new/ https://reviews.llvm.org/D151855 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D151855: [clang] Use `{File,Directory}EntryRef` in modular header search (part 2/2)

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. Regarding the failing `Modules/crash-vfs-umbrella-frameworks.m` test, this is my understanding after debugging it. Whenever we find that `A.framework/Frameworks/B.framework` is a symlink, we treat `B` as a separate

[PATCH] D152207: [HIP] Instruct lld to go through all archives

scchan updated this revision to Diff 529366. scchan added a comment. added a matching --no-whole-archive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152207/new/ https://reviews.llvm.org/D152207 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias updated this revision to Diff 529365. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/ https://reviews.llvm.org/D151761 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

galenelias added a comment. In D151761#4400693 , @HazardyKnusperkeks wrote: > In D151761#4400056 , @galenelias > wrote: > >> In D151761#4394758 , >> @MyDeveloperDay

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5201-5204 + if (auto EC = sys::fs::getUniqueID(FileName, ID)) { +assert(EC && + "Unable to get unique ID for file, during getTargetEntryUniqueInfo"); + }

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5201-5204 + if (auto EC = sys::fs::getUniqueID(FileName, ID)) { +assert(EC && + "Unable to get unique ID for file, during getTargetEntryUniqueInfo"); + } This

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. Thank you very much! I'm aware and currently trying to reproduce it locally and fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150998/new/ https://reviews.llvm.org/D150998

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

fmayer added a comment. This triggered an MSAN error: https://lab.llvm.org/buildbot/#/builders/237/builds/3127/steps/13/logs/stdio 1: ==1184292==WARNING: MemorySanitizer: use-of-uninitialized-value check:6'0 X~~~

  1   2   3   >