[clang] 985dace - [AIX][tests] Temporarily disable test index-with-module.m

Author: Jake Egan Date: 2023-06-16T01:24:19-04:00 New Revision: 985daceac9cbe4d08a3f018fec47cfc371a9f60b URL: https://github.com/llvm/llvm-project/commit/985daceac9cbe4d08a3f018fec47cfc371a9f60b DIFF: https://github.com/llvm/llvm-project/commit/985daceac9cbe4d08a3f018fec47cfc371a9f60b.diff

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

Manna added a comment. Thank you @erichkeane and @steakhal for reviews and comments. In D152194#4402377 , @steakhal wrote: > Please update the title and the summary of this patch to reflect what it > actually achieves. > We also usually use the

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2552-2554 auto AddrAS = addr ? addr->getType()->getPointerAddressSpace() : 0; - auto AddrInt8PtrTy = - AddrAS ? CGF.Int8Ty->getPointerTo(AddrAS) : CGF.Int8PtrTy; + auto AddrPtrTy = +

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

Manna added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:505-511 const unsigned *i = C.lookup(D); llvm::errs() << " -> "; + if (!i) { +llvm::errs() << "<>"; +return; + } dumpVarDefinitionName(*i);

[PATCH] D152924: [libLTO][AIX] Respect `-f[no]-integrated-as` on AIX

shchenz added a comment. Seems passing `-Wl,-bplugin_opt:-no-integrated-as=1` from clang driver does not work as expected. Is this expected or by design(We can only use -fno-integrated-as but no -Wl,-bplugin_opt:-no-integrated-as=1)? clang -flto -Wl,-bplugin_opt:-no-integrated-as=1 *.c -v

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

Manna updated this revision to Diff 531976. Manna retitled this revision from "[NFC][CLANG] Fix potential null pointer dereference bugs" to "[CLANG]Fix potential null pointer dereference bugs". Manna added a comment. Herald added subscribers: steakhal, martong. Address review comment and update

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 requested changes to this revision. barannikov88 added a comment. This revision now requires changes to proceed. @JOE1994 Please run the testsuite locally (`ninja check-clang`), there is at least one test that crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143617: [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options

Amir added a comment. Ping @beanz, @phosek Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143617/new/ https://reviews.llvm.org/D143617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

yaxunl added a comment. In D151349#4426008 , @jhuber6 wrote: > I've started seeing these errors when compiling for OpenMP targeting AMDGPU: > > $ clang input.c -fopenmp --offload-arch=gfx1030 > warning: feature flag '+image-insts' is ignored since

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2269 + +IntrinsicTypes = {ResultType, Ops[Offset]->getType(), Ops[Offset + 1]->getType(), + Ops.back()->getType()}; craig.topper wrote: > I think

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2269 + +IntrinsicTypes = {ResultType, Ops[Offset]->getType(), Ops[Offset + 1]->getType(), + Ops.back()->getType()}; I think we if we used

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:697 +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], +[LLVMMatchType<0>, llvm_anyvector_ty, llvm_any_ty, + LLVMScalarOrSameVectorWidth<0, llvm_i1_ty>,

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:697 +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], +[LLVMMatchType<0>, llvm_anyvector_ty, llvm_any_ty, + LLVMScalarOrSameVectorWidth<0,

[PATCH] D152889: [2/2][RISCV] Model vxrm control for vsadd, vsaddu, vssub, and vssubu

eopXD abandoned this revision. eopXD added a comment. Dropping the revision because no change in vsadd(u)/vssub(u) is needed since the computation does not consider rounding mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152889/new/

[PATCH] D153038: [Clang] Fixes a diagnostic typo.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153038/new/ https://reviews.llvm.org/D153038

[PATCH] D152879: [1/2][RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 531966. eopXD added a comment. Fix sema checking test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152879: [1/2][RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 531963. eopXD added a comment. Add semanic check to the vxrm parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files:

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx created this revision. AlexVlx added reviewers: rjmccall, efriedma, yaxunl. Herald added subscribers: arichardson, tpr. Herald added a project: All. AlexVlx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. All data structures and

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

bryanpkc updated this revision to Diff 531953. bryanpkc added a comment. Also added SME attributes to the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134678/new/ https://reviews.llvm.org/D134678 Files:

[PATCH] D134678: [Clang][AArch64][SME] Add intrinsics for ZA array load/store (LDR/STR)

bryanpkc updated this revision to Diff 531949. bryanpkc added a comment. Instead of defining new type flags, `EmitAArch64SMEBuiltinExpr` is updated to switch on `BuiltinID`, as suggested by @sdesmalen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145848: [Driver] Correct -f(no-)xray-function-index behavior

ilammy abandoned this revision. ilammy added a comment. @MaskRay, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145848/new/ https://reviews.llvm.org/D145848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:1470 +->getLambdaStaticInvoker()) && + !Fn->getName().contains("__impl")) { +// If emitting a lambda with static invoker on X86 Windows, change

[PATCH] D153033: [NFC][CLANG] Fix potential null pointer dereference bugs

aaronpuchert added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:505-511 const unsigned *i = C.lookup(D); llvm::errs() << " -> "; + if (!i) { +llvm::errs() << "<>"; +return; + } dumpVarDefinitionName(*i);

[clang] 0cbbfb8 - [CGCall] Prune ArgStruct [-Wunused-variable]

Author: NAKAMURA Takumi Date: 2023-06-16T08:00:57+09:00 New Revision: 0cbbfb8c2e03275e2f67e4f953693601785069a4 URL: https://github.com/llvm/llvm-project/commit/0cbbfb8c2e03275e2f67e4f953693601785069a4 DIFF:

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

dankm updated this revision to Diff 531931. dankm added a comment. Update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Expr.cpp

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

dankm added a comment. Thanks, I'll update the release notes & description right away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152570/new/ https://reviews.llvm.org/D152570 ___ cfe-commits mailing

[clang] 06a0ae6 - Reland "[DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)"

Author: Vladislav Dzhidzhoev Date: 2023-06-16T00:49:59+02:00 New Revision: 06a0ae652497513398865d9a1b0cc3f95aa82f54 URL: https://github.com/llvm/llvm-project/commit/06a0ae652497513398865d9a1b0cc3f95aa82f54 DIFF:

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1065 + if (CodeGenOpts.FatLTO) { +// Set EnableSplitLTOUnit, since the config above won't +if (!TheModule->getModuleFlag("EnableSplitLTOUnit")) tejohnson wrote: > Can you

[PATCH] D153059: [-Wunsafe-buffer-usage][WIP] Group parameter fix-its

t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2264 + // variable `x` implicates fixing `y`: DepMapTy PtrAssignmentGraph{}; + ziqingluo-90 wrote: > ziqingluo-90 wrote: > > How about changing the variable name to

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall looks good.. Comment at: clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp:50 +if (!AllowedIdentifiers.back().isValid()) +

[PATCH] D153059: [-Wunsafe-buffer-usage][WIP] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2264 + // variable `x` implicates fixing `y`: DepMapTy PtrAssignmentGraph{}; + ziqingluo-90 wrote: > How about changing the variable name to `PtrImplicationGraph`? For

[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

bader added inline comments. Comment at: clang/docs/ReleaseNotes.rst:590 +- Clang now supports CUDA SDK up to 12.1 tra wrote: > bader wrote: > > @tra, could you update llvm/docs/CompileCudaWithLLVM.rst as well, please? > Done in

[PATCH] D153078: [clang][dataflow] Change iteration algorithm to use WTO instead of reverse post order.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch replaces use of the reverse-post order

[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

tra added inline comments. Comment at: clang/docs/ReleaseNotes.rst:590 +- Clang now supports CUDA SDK up to 12.1 bader wrote: > @tra, could you update llvm/docs/CompileCudaWithLLVM.rst as well, please? Done in

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

eddyz87 added a comment. In D152986#4425736 , @rnk wrote: > Thank you for the review! > The purpose of the attribute is really limited to preserving source location > information on instructions, and this isn't really a supported usage. But it would

[PATCH] D151361: [CUDA] bump supported CUDA version to 12.1/11.8

bader added inline comments. Comment at: clang/docs/ReleaseNotes.rst:590 +- Clang now supports CUDA SDK up to 12.1 @tra, could you update llvm/docs/CompileCudaWithLLVM.rst as well, please? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:85 +/// (including not_interesting). +/// - The rest of the values represent builtin IDs (including not_builtin). +static constexpr int FirstObjCKeywordID = 1; The

[PATCH] D152275: Use memory region declaration intrinsic when generating code for array subscripts

efriedma added a comment. In D152275#4423845 , @simeon wrote: >> - User code might not actually obey the language rules; do we have any >> sanitizer that checks if user code trips over this? > > I believe AddressSanitizer >

[PATCH] D144911: adding bf16 support to NVPTX

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXIntrinsics.td:1271-1287 -def : Pat<(int_nvvm_ff2f16x2_rn Float32Regs:$a, Float32Regs:$b), - (CVT_f16x2_f32 Float32Regs:$a, Float32Regs:$b, CvtRN)>; -def : Pat<(int_nvvm_ff2f16x2_rn_relu Float32Regs:$a,

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. Hi, there's a test failure on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/8005/steps/6/logs/FAIL__Clang__index-with-module_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 531895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h

[PATCH] D153071: [clang][dataflow] Refactor `DataflowWorklist` types and add a WTO version.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Removes dependency of the DataflowWorklistBase

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. I do not have commit access yet. Could one of the reviewers land this patch for me? Please use "Youngsuk Kim " to commit the change. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

dblaikie added a comment. Judging by @aaron.ballman's comment on the bug, I can see the logic here. Though perhaps this notion generalizes to all non-note types, not just errors (like perhaps we should print the include stack for each warning, too?) Repository: rG LLVM Github Monorepo

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic accepted this revision. nikic added a comment. LGTM -- do you have commit access, or should someone commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm.org/D152321

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

jhuber6 added a comment. I've started seeing these errors when compiling for OpenMP targeting AMDGPU: $ clang input.c -fopenmp --offload-arch=gfx1030 warning: feature flag '+image-insts' is ignored since the feature is read only [-Winvalid-command-line-argument] Any suggestions for what

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2045 if (IsIndirect) -LLTy = LLTy->getPointerTo(0); +LLTy = llvm::PointerType::get(getVMContext(), 0); FrameFields.push_back(LLTy); nikic wrote: > getLLVMContext?

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 531889. JOE1994 added a comment. - Rebase onto latest llvm-project main : 2cd4dc59792578f833b838e3c9a376a4bcafc568 - Use `llvm::PointerType::getUnqual` whenever possible Repository:

[PATCH] D153059: [-Wunsafe-buffer-usage][WIP] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2085 continue; } for (const auto : Fixables) { I changed the rest of this function drastically so let me explain what I did. The table `FixItsForVariable`

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

SlaterLatiao updated this revision to Diff 531885. SlaterLatiao added a comment. Remove unnecessary condition and assignment in implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 Files:

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 531884. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td

[PATCH] D153068: Remove unnecessary condition and assignment.

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153068 Files:

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

MaskRay accepted this revision. MaskRay added a comment. Looks great! Comment at: clang/test/Driver/arm-execute-only.c:1 -// RUN: not %clang -c -target thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: %clang -c -### --target=thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN:

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. > My concern with `ShowInSystemHeaders` is that this seems like a bad user > experience. I guess you're comparing this user experience to the one when this feature was a normal warning/without `ShowInSystemHeaders` - I'm comparing this situation to the future where

[PATCH] D152975: [clang-format] Allow break after return keyword

HazardyKnusperkeks added a comment. I'd like more tests (and examples how it is before the change), some operations (+, *, etc.), your stated string literal with and without many spaces, call chains. I have nothing against the introduction, I'm just not sure about the default value and the

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel updated this revision to Diff 531874. ymandel added a comment. more comment expansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 Files:

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:89 + /// `Value`. These literals are the same every time. + IntegerValue (llvm::APInt Value); + xazax.hun wrote: >

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel updated this revision to Diff 531865. ymandel added a comment. Fix build break and add some field comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 Files:

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

mboehme updated this revision to Diff 531863. mboehme added a comment. Clarify that integer literals aren't typed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152813/new/ https://reviews.llvm.org/D152813 Files:

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

zequanwu added a comment. In D152472#4425713 , @thakis wrote: > This is still breaking check-clang on windows: > http://45.33.8.238/win/79908/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Sorry, I thought I applied

[clang] 9d910b1 - Fix test breakage in 879e88693338657aec092db749ddfcb582c65491.

Author: Zequan Wu Date: 2023-06-15T14:46:54-04:00 New Revision: 9d910b1073198716f85e5a7e7e9c8fd1f24d4c60 URL: https://github.com/llvm/llvm-project/commit/9d910b1073198716f85e5a7e7e9c8fd1f24d4c60 DIFF: https://github.com/llvm/llvm-project/commit/9d910b1073198716f85e5a7e7e9c8fd1f24d4c60.diff

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

MaskRay added inline comments. Herald added a subscriber: wangpc. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2442 +OperandMatchResultTy RISCVAsmParser::parseZcmpSpimm(OperandVector ) { + if (getLexer().is(AsmToken::Minus)) +getLexer().Lex();

[PATCH] D152986: [clang] Allow 'nomerge' attribute for function pointers

rnk added a comment. The purpose of the attribute is really limited to preserving source location information on instructions, and this isn't really a supported usage. The BPF backend and verifier needs to learn to tolerate valid LLVM transforms if it wants to be a real LLVM backend. Of

[PATCH] D152472: [Clang][MS] Remove assertion on BaseOffset can't be smaller than Size.

thakis added a comment. This is still breaking check-clang on windows: http://45.33.8.238/win/79908/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152472/new/

[PATCH] D153059: [-Wunsafe-buffer-usage][WIP] Group parameter fix-its

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, t-rasmud, jkorous, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For a function `F` whose parameters need to

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:294-295 // UntouchedAndPossiblyDestroyed or UnlockedAndPossiblyDestroyed. - assert(lstate->isUntouchedAndPossiblyDestroyed() || -

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

MaskRay added a comment. You may add a test file beside `llvm/test/CodeGen/RISCV/inline-asm*`. I hope that this patch focuses on `getLexer().Lex()` instances that actually cause a problem. Many `getLexer().Lex()` instances followed by `is(...)` form a pattern that can be rewritten in a better

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel updated this revision to Diff 531843. ymandel added a comment. fix some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153058/new/ https://reviews.llvm.org/D153058 Files:

[PATCH] D153058: [clang][CFG] Support construction of a weak topological ordering of the CFG.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds support for building a weak topological ordering of the CFG blocks,

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

steakhal accepted this revision. steakhal added a comment. Looks good. Thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:294-295 // UntouchedAndPossiblyDestroyed or UnlockedAndPossiblyDestroyed. - assert(lstate->isUntouchedAndPossiblyDestroyed()

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:294-295 // UntouchedAndPossiblyDestroyed or UnlockedAndPossiblyDestroyed. - assert(lstate->isUntouchedAndPossiblyDestroyed() || -

[PATCH] D152139: [6/6][Clang][RISCV] Replace indexed segment store with tuple type interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG1de5de4b7300: [6/6][Clang][RISCV] Replace indexed segment store with tuple type interfaces (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152138: [5/6][Clang][RISCV] Replace indexed segment load with tuple type interfaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8447dd94422: [5/6][Clang][RISCV] Replace indexed segment load with tuple type interfaces (authored by eopXD). Repository: rG LLVM Github

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:461 +assert(NamedCtx, "NamedCtx cannot be null"); + aaron.ballman wrote: > This doesn't build. ;-) Thanks for the catch. Something was wrong with my workspace build setup,

[PATCH] D152977: [NFC] Fix potential dereferencing of null return value.

schittir updated this revision to Diff 531824. schittir marked an inline comment as done. schittir added a comment. Fix the assert causing build failure and address another review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152977/new/ https://reviews.llvm.org/D152977

[PATCH] D152137: [4/6][Clang][RISCV] Replace strided segment store with tuple type interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit rGa30b1b4af11f: [4/6][Clang][RISCV] Replace strided segment store with tuple type interfaces (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152136: [3/6][Clang][RISCV] Replace strided segment load with tuple type interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc7afbfaf35: [3/6][Clang][RISCV] Replace strided segment load with tuple type interfaces (authored by eopXD). Herald added a subscriber: wangpc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit rG8720bdff91cc: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces (authored by eopXD). Herald added a subscriber: wangpc. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

rogfer01 added a comment. >> Can you check if clang crashes for you? > > I am seeing messages related to builtin type, but they do not seem related to > RVV builtin types. > > $ touch t.c > $ clang -cc1 -triple riscv64 -w -emit-pch -o test.pch t.c > $ clang -cc1 -triple riscv64 -w -x c

[PATCH] D152134: [1/6][Clang][RISCV] Replace unit-stride (fault-first) segment load with tuple type interfaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a80ef3fde9c: [1/6][Clang][RISCV] Replace unit-stride (fault-first) segment load with tuple… (authored by eopXD). Herald added a subscriber: wangpc.

[clang] b8ea03a - Revert "Reland "[DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)""

Author: Vladislav Dzhidzhoev Date: 2023-06-15T19:36:36+02:00 New Revision: b8ea03a4be0123cbff958711ec6d89e1ddaa347a URL: https://github.com/llvm/llvm-project/commit/b8ea03a4be0123cbff958711ec6d89e1ddaa347a DIFF:

[PATCH] D152889: [2/2][RISCV] Model vxrm control for vsadd, vsaddu, vssub, and vssubu

craig.topper added a comment. These instructions don't read vxrm why do they need to change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152889/new/ https://reviews.llvm.org/D152889 ___ cfe-commits

[PATCH] D152889: [2/2][RISCV] Model vxrm control for vsadd, vsaddu, vssub, and vssubu

craig.topper added a comment. SemaChecking.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152889/new/ https://reviews.llvm.org/D152889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152879: [1/2][RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper added a comment. Herald added a subscriber: wangpc. SemaChecking.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 ___ cfe-commits mailing list

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD added a comment. In D152070#4425378 , @rogfer01 wrote: > In D152070#4425358 , @eopXD wrote: > >> In D152070#4425318 , @rogfer01 >> wrote: >> >>> In D152070#4421004

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. Thanks everyone, taking notes of all the comments for improving the test: - Simplify the test (can be one instruction, no problem). - Check at IR level - Check for the comments to be placed in the output - Do "arc diff" with one-line descriptions Will update

[clang] 046f624 - Fix NATVIS for some Clang types

Author: Aaron Ballman Date: 2023-06-15T13:00:39-04:00 New Revision: 046f62492b4be8a1d043ae66d82ce2d8915bd10b URL: https://github.com/llvm/llvm-project/commit/046f62492b4be8a1d043ae66d82ce2d8915bd10b DIFF: https://github.com/llvm/llvm-project/commit/046f62492b4be8a1d043ae66d82ce2d8915bd10b.diff

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

rogfer01 added a comment. In D152070#4425358 , @eopXD wrote: > In D152070#4425318 , @rogfer01 > wrote: > >> In D152070#4421004 , >> @DavidSpickett wrote: >> >>> FYI

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

eopXD added a comment. In D152070#4425318 , @rogfer01 wrote: > In D152070#4421004 , @DavidSpickett > wrote: > >> FYI after this change: >> >> Building CXX object >>

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:663 + const auto *Var = dyn_cast(D); + if (Var && !llvm::isa(Var)) { if (const Expr *Init = Var->getInit()) We're ignoring all `ParmVarDecl` cases, The crash here is for broken

[PATCH] D152137: [4/6][Clang][RISCV] Replace strided segment store with tuple type interfaces

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wangpc. LGTM. Thanks @eopXD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152137/new/

[PATCH] D152070: [2/11][Clang][RISCV] Expand all variants of RVV intrinsic tuple types

rogfer01 added a comment. Herald added a subscriber: wangpc. In D152070#4421004 , @DavidSpickett wrote: > FYI after this change: > > Building CXX object > tools/lldb/sou...luginTypeSystemClang.dir/TypeSystemClang.cpp.o > >

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:105 + +BuildMI(MBB, MI, MI.getDebugLoc(), TII->get(RISCV::WriteFRMImm)) +.addImm(FRMImm); craig.topper wrote: > Don't we need to restore the original

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wangpc. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

aaron.ballman added a comment. In D149573#4418001 , @codemzs wrote: > @tahonermann Gentle ping, please let me know if you have any questions. FWIW, there are C++ standards meetings all week this week, and C standards meetings all next week (and into

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added a comment. In D149444#4425134 , @stuij wrote: > - Moved the backend parts of this patch to D149443 > . Wrong Phab review -^ It should be D152795 . Repository: rG LLVM

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

aaron.ballman added a comment. In D142388#4415349 , @rsmith wrote: > I think `__builtin_any_value` works pretty well, and emphasizes that this can > really return any value. I'd also be OK with `__builtin_convenient_value`, to > emphasize that the

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

jrtc27 added a comment. In D153008#4425238 , @abel-bernabeu wrote: > In D153008#4424821 , @jrtc27 wrote: > >> Clang tests should not compile to asm. You want an IR test. > > Jessica, are there any exceptions for

  1   2   3   >