[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

ilammy added a comment. In D145849#4412286 , @MaskRay wrote: > However, `Triple.isMacOSX()` is allowed before the feature actually works and > `compiler-rt/test/xray/lit.cfg.py` tests it. I have some patches for `compiler-rt` cooking, fixing the build

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare added a comment. In D153205#4430528 , @owenpan wrote: > It seems to me that there has been a proliferation of new options being > proposed and/or accepted recently. I'd like to remind everyone of the > long-standing policy >

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

AMS21 added a comment. If there are no more problems, I would kindly ask for someone to push this no my behalf :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153198/new/ https://reviews.llvm.org/D153198

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG44e63ffe2bf7: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC) (authored by JOE1994, committed by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 44e63ff - [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

Author: Youngsuk Kim Date: 2023-06-18T04:13:15+03:00 New Revision: 44e63ffe2bf7e5c026b828054d67088239939e81 URL: https://github.com/llvm/llvm-project/commit/44e63ffe2bf7e5c026b828054d67088239939e81 DIFF: https://github.com/llvm/llvm-project/commit/44e63ffe2bf7e5c026b828054d67088239939e81.diff

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

owenpan updated this revision to Diff 532434. owenpan edited the summary of this revision. owenpan added a comment. Took out `Language: Cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153208/new/ https://reviews.llvm.org/D153208 Files: clang/include/clang/Format/.clang-format

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7298 + if (IsUsingLTO && Args.getLastArg(options::OPT_ffat_lto_objects)) { +assert(LTOMode == LTOK_Full || LTOMode == LTOK_Thin); +CmdArgs.push_back(Args.MakeArgString( We

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu added a comment. In D153008#4430491 , @MaskRay wrote: > In D153008#4428694 , @abel-bernabeu > wrote: > >> In D153008#4428568 , @MaskRay >> wrote: >> >>>

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:250 +- `-ffat-lto-objects` can now be used to emit object files with both object + code and bitcode. Previously this flag was ignored for GCC compatibility. MaskRay wrote: > `bitcode` =>

[PATCH] D146777: [clang] Preliminary fat-lto-object support

MaskRay accepted this revision. MaskRay added a comment. There is a `-fno-fat-lto-objects` issue, but otherwise looks good after some nits are addressed. Thanks! Comment at: clang/docs/ReleaseNotes.rst:250 +- `-ffat-lto-objects` can now be used to emit object files with

[PATCH] D134677: [Clang][AArch64][SME] Add ZA zeroing intrinsics

bryanpkc updated this revision to Diff 532431. bryanpkc marked 3 inline comments as done. bryanpkc added a comment. Rebased. NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134677/new/ https://reviews.llvm.org/D134677 Files:

[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Also, add `Language: Cpp` to make it explicit. Then reformat all

[clang] 8411bdb - [clang-format][NFC] Remove redundant getLLVMStyle() in unit tests

Author: Owen Pan Date: 2023-06-17T15:25:59-07:00 New Revision: 8411bdb0acde8569c9bfcd08401fa587f7dea834 URL: https://github.com/llvm/llvm-project/commit/8411bdb0acde8569c9bfcd08401fa587f7dea834 DIFF: https://github.com/llvm/llvm-project/commit/8411bdb0acde8569c9bfcd08401fa587f7dea834.diff

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:559 +emitError |= DefaultCC == LangOptions::DCC_StdCall && + Arch != llvm::Triple::m68k && Arch != llvm::Triple::x86; emitError |= (DefaultCC ==

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 532423. myhsu marked 5 inline comments as done. myhsu edited the summary of this revision. myhsu added a comment. Herald added a subscriber: MaskRay. - Add a new default calling convention `-fdefault-calling-conv=rtdcall` to model using `m68k_rtdcc` globally -

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532424. JOE1994 added a comment. - git clang-format (update clang/lib/CodGen/CGBlocks.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files:

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1262-1263 auto = getBlockByrefInfo(variable); addr = Address(Builder.CreateLoad(addr), Int8Ty, byrefInfo.ByrefAlignment); - -addr = Builder.CreateElementBitCast(addr, byrefInfo.Type,

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532422. JOE1994 added a comment. - Apply suggested change (combining 2 lines) from barannikov88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files:

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1262-1263 auto = getBlockByrefInfo(variable); addr = Address(Builder.CreateLoad(addr), Int8Ty, byrefInfo.ByrefAlignment); - -addr = Builder.CreateElementBitCast(addr, byrefInfo.Type,

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532421. JOE1994 added a comment. Herald added subscribers: jrtc27, fedor.sergeev, jyknight. - Rebase onto latest llvm-project main - Remove awkward empty line in `clang/lib/CodeGen/CGBlocks.cpp`, as suggested by barannikov88 Repository: rG LLVM Github

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This needs to be rebased, there will be conflicts with 992cb984 . Comment at: clang/lib/CodeGen/CGBlocks.cpp:1264 -addr =

[PATCH] D152975: [clang-format] Allow break after return keyword

owenpan added a comment. See D153205#4430528 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152975/new/ https://reviews.llvm.org/D152975 ___ cfe-commits

[PATCH] D153205: [clang-format] Add new block type ListInit

owenpan added a comment. It seems to me that there has been a proliferation of new options being proposed and/or accepted recently. I'd like to remind everyone of the long-standing policy of adding new

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:355-356 // Region 00 +// CK2-DAG: [[DEV:%[^,]+]] = sext i32 [[DEVi32:%[^,]+]] to i64 +// CK2-DAG: [[DEVi32]] = load i32, ptr %{{[^,]+}}, // CK2: br i1 %{{[^,]+}}, label %[[IFTHEN:[^,]+]],

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. C89 and C90 list initializers are treated differently than

[PATCH] D152975: [clang-format] Allow break after return keyword

gedare added a comment. In D152975#4425932 , @HazardyKnusperkeks wrote: > I'd like more tests (and examples how it is before the change), some > operations (+, *, etc.), your stated string literal with and without many > spaces, call chains. Ok.

[PATCH] D148827: -fsanitize=function: support C

MaskRay added a comment. In D148827#4424237 , @uabelho wrote: > Hi, > > A question: it seems like this messes with alignment on functions? > So with input program al.c: > > __attribute__((aligned(64))) > void alignedfn(void) { > __asm("nop"); >

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

MaskRay added a comment. In D153008#4428694 , @abel-bernabeu wrote: > In D153008#4428568 , @MaskRay wrote: > >> This new update still applies many unneeded `getParser().Lex();` and adds a >> test at a wrong

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

AMS21 updated this revision to Diff 532414. AMS21 marked an inline comment as done. AMS21 added a comment. So somehow I didn't add the actual `BaseNoexceptFunctionCheck` files, thats why the build failed. Also implemented the two new suggestions. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 532404. JOE1994 added a comment. - Apply suggestions from @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153196/new/ https://reviews.llvm.org/D153196 Files: clang/lib/CodeGen/Address.h

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. The is compiler error in CI "Cannot find source file: BaseNoexceptFunctionCheck.cpp". Consider naming it NoexceptFunctionBase.cpp or NoexceptFunctionBaseCheck.cpp unless there are

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGObjC.cpp:2207 llvm::Type *origType = addr.getElementType(); - addr = CGF.Builder.CreateElementBitCast(addr, CGF.Int8PtrTy); + addr =

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

AMS21 updated this revision to Diff 532394. AMS21 marked 3 inline comments as done. AMS21 added a comment. Implement suggested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153198/new/ https://reviews.llvm.org/D153198 Files:

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

steakhal added a comment. Let me come back to this once again in the upcoming days to make sure everything is good. Comment at: clang/test/Analysis/pr22954.c:581 clang_analyzer_eval(m27.s3[i] == 1); // expected-warning{{UNKNOWN}}\ expected-warning{{Potential leak of

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

PiotrZSL added a comment. Overall good, my main concern is base class name & location. Comment at: clang-tools-extra/clang-tidy/performance/NoexceptDestructorCheck.h:23 /// https://clang.llvm.org/extra/clang-tidy/checks/performance/noexcept-destructor.html -class

[PATCH] D153198: [clang-tidy] Refactor common code from the Noexcept*Checks into `NoexceptFunctionCheck`

AMS21 created this revision. AMS21 added a reviewer: PiotrZSL. Herald added subscribers: ChuanqiXu, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2193 +// (the output registers are stored in this array on return). +static MachineBasicBlock *insertMultibyteShiftLoop( +MachineInstr , MachineBasicBlock *BB, Register ShiftNum,

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 created this revision. Herald added subscribers: Jim, JDevlieghere, hiraditya, dylanmckay. Herald added a project: All. Patryk27 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Some passes can introduce shifts

[PATCH] D152551: [clang] Remove dead parameter of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 abandoned this revision. JOE1994 added a comment. By mistake, I created a new revision D153196 instead of updating this one. Please refer to the new revision instead. I apologize for the inconvenience. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 created this revision. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add `Address::withElementType()` as a replacement for `CGBuilderTy::CreateElementBitCast`. - Partial progress towards

[PATCH] D152696: Prevent deadlocks in death tests.

mgorny added a comment. This change is causing a lot of unittests to fail on Gentoo. I've tested both on amd64 and arm64; on amd64 additionally the test suite seems to hang. Failed Tests (75): LLVM-Unit :: ADT/./ADTTests/APFloatTest/SemanticsDeath LLVM-Unit ::

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie added inline comments. Comment at: clang/test/Analysis/issue-55019.cpp:13-14 + +void *malloc(size_t); +void free(void *); + > Ah, I see that it's for c function declarations. If that's the case, have you > considered adding the malloc and free

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie updated this revision to Diff 532372. OikawaKirie edited the summary of this revision. OikawaKirie added a comment. Update the implementation of InvalidateBuffer in a multi-entrance-with-callback manner. Update test cases as suggested. CHANGES SINCE LAST ACTION

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added a comment. Could you please rebase the patch to current main? I wasn't able to apply it. The behavior you describe sounds reasonable to me. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if

[clang] f2a352e - [Clang] Add the list of core papers approved in Varna to the status page

Author: Corentin Jabot Date: 2023-06-17T09:52:36+03:00 New Revision: f2a352e0584093c65f07cdd7cc62c5cc66beacbd URL: https://github.com/llvm/llvm-project/commit/f2a352e0584093c65f07cdd7cc62c5cc66beacbd DIFF: