[PATCH] D153403: [RISCV] Use unsigned types for orc_b builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf67dfb3cdb4b: [RISCV] Use unsigned types for orc_b builtins. (authored by craig.topper). Changed prior to commit:

[clang] f67dfb3 - [RISCV] Use unsigned types for orc_b builtins.

Author: Craig Topper Date: 2023-06-25T22:54:07-07:00 New Revision: f67dfb3cdb4b980103e262fb4c575e6310032dd4 URL: https://github.com/llvm/llvm-project/commit/f67dfb3cdb4b980103e262fb4c575e6310032dd4 DIFF: https://github.com/llvm/llvm-project/commit/f67dfb3cdb4b980103e262fb4c575e6310032dd4.diff

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 534428. BeMg added a comment. 1. Attrstring -> AttrString 2. using StringRef instead of string 3. Append unsupported target feature Let follow-up procedure raise diagnostic code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

xen0n updated this revision to Diff 534427. xen0n marked an inline comment as done. xen0n added a comment. Unify the diagnostic messages and show the actual `-m*-float` option being passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153707/new/

[PATCH] D153738: Add LibClang guide

manuel5975p created this revision. manuel5975p added a reviewer: aaron.ballman. manuel5975p added projects: clang, clang-c. Herald added a project: All. manuel5975p requested review of this revision. Herald added a subscriber: cfe-commits. Add a libclang .rst file with some code examples, going

[PATCH] D153235: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUZi/iUWi

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG612b7e10a9af: [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUZi/iUWi (authored by Jim). Changed prior to commit:

[clang] 612b7e1 - [RISCV] Change the type of argument to clz and ctz from ZiZi/WiWi to iUZi/iUWi

Author: Jim Lin Date: 2023-06-26T13:15:37+08:00 New Revision: 612b7e10a9afa797d41e134bc62a8ef87a014caf URL: https://github.com/llvm/llvm-project/commit/612b7e10a9afa797d41e134bc62a8ef87a014caf DIFF: https://github.com/llvm/llvm-project/commit/612b7e10a9afa797d41e134bc62a8ef87a014caf.diff LOG:

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd added a comment. In D129635#4442580 , @h-vetinari wrote: > In D129635#4440613 , @animeshk-amd > wrote: > >> In the multi-company community meeting, the agreement was to move to the 5.1 >> version

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:732 +def warn_drv_loongarch_conflicting_mabi : Warning< + "ignoring -mabi value '%0' as it conflicts with that implied by -m*-float (%1)">, + InGroup; You can make

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 534417. HaohaiWen added a comment. Add -- to clang_cl input file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 534413. HaohaiWen edited the summary of this revision. HaohaiWen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files:

[PATCH] D153737: [clang] __is_trivially_equality_comparable should return false for arrays

philnik created this revision. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When comparing two arrays, their pointers are compared instead of their elements, which menas that they are not trivially

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen reopened this revision. HaohaiWen added a comment. This revision is now accepted and ready to land. The path of this test you were running (/Users/thakis/src/llvm-project/clang/test/Driver/split-debug.c) started with /User which was interpreted as OPT_U option. Therefore split-debug.c

[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a32b0273b9: [doc][LoongArch] Add missed release note about `ual` feature addition (authored by SixWeining). Repository: rG LLVM Github Monorepo

[clang] d0a32b0 - [doc][LoongArch] Add missed release note about `ual` feature addition

Author: Weining Lu Date: 2023-06-26T10:37:29+08:00 New Revision: d0a32b0273b9e5d881417cc668e944e35e55c845 URL: https://github.com/llvm/llvm-project/commit/d0a32b0273b9e5d881417cc668e944e35e55c845 DIFF: https://github.com/llvm/llvm-project/commit/d0a32b0273b9e5d881417cc668e944e35e55c845.diff

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2043 Abv->Add(BitCodeAbbrevOp(BitCodeAbbrevOp::Fixed, 1)); // isMutable - Abv->Add(BitCodeAbbrevOp(0)); // StorageKind +

[PATCH] D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`

philnik added a comment. @aaron.ballman Do you have any opinion here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151625/new/ https://reviews.llvm.org/D151625 ___ cfe-commits mailing list

[PATCH] D153542: [C++20][Modules] Implement P2615R1 exported specialization diagnostics.

ChuanqiXu added a comment. BTW, since this will break existing code. Let's mention this in ReleaseNotes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153542/new/ https://reviews.llvm.org/D153542 ___

[PATCH] D153542: [C++20][Modules] Implement P2615R1 exported specialization diagnostics.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11275-11278 +def err_export_partial_specialization : Error< + "partial %select{class|variable}0 specialization %1 cannot be exported">; +def err_export_explicit_specialization : Error<

[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

SixWeining updated this revision to Diff 534404. SixWeining added a comment. Address xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152671/new/ https://reviews.llvm.org/D152671 Files: clang/docs/ReleaseNotes.rst

[PATCH] D152671: [doc][LoongArch] Add missed release note about `ual` feature addition

SixWeining added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:163 * The ``lp64s`` ABI is supported now and has been tested on Rust bare-matal target. +* An target feature ``ual`` is introduced to allow unaligned memory accesses and + this feature is enabled by

[PATCH] D153724: [clang] Fix a crash on invalid destructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76d72a715038: [clang] Fix a crash on invalid destructor (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 76d72a7 - [clang] Fix a crash on invalid destructor

Author: Younan Zhang Date: 2023-06-26T09:35:12+08:00 New Revision: 76d72a715038ae3bce711ddc372e7e273a5c2b6b URL: https://github.com/llvm/llvm-project/commit/76d72a715038ae3bce711ddc372e7e273a5c2b6b DIFF: https://github.com/llvm/llvm-project/commit/76d72a715038ae3bce711ddc372e7e273a5c2b6b.diff

[PATCH] D153724: [clang] Fix a crash on invalid destructor

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Make sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534387. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534386. zyounan added a comment. Simplify test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 534380. AlexVlx added a comment. Fixed issue found via internal testing (thanks @yaxunl). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

owenpan added a comment. In D148131#4304960 , @jp4a50 wrote: > Hey @MyDeveloperDay @owenpan . I'd appreciate if you guys have time to > consider this change. It's the last significant issue my team and I are > tracking that's blocking our adoption of

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

aaronpuchert added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1046 def ThreadSafetyPrecise: DiagGroup<"thread-safety-precise">; def ThreadSafetyReference : DiagGroup<"thread-safety-reference">; +def ThreadSafetyReturn :

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

thakis added a comment. None i know of, but given the bot's already red, you won't make it worse :) Tests shouldn't include any headers generally, not even inttypes.h (unless the test tests that header). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153728: [llvm] Move AttributeMask to a separate header

IncludeGuardian added a comment. This was found with IncludeGuardian 0.0.8 and the recommendation was given here https://gist.github.com/IncludeGuardian/4132d5149576a55e0560fae6f8ff4a38#file-before-yaml-L4053-L4055 The estimates of token count were run before and after this commit and can be

[PATCH] D153728: [llvm] Move AttributeMask to a separate header

IncludeGuardian created this revision. IncludeGuardian added a reviewer: aaron.ballman. Herald added subscribers: mtrofin, Enna1, ormris, foad, jdoerfert, kerbowa, hiraditya, jvesely, arsenm, qcolombet, MatzeB. Herald added a project: All. IncludeGuardian requested review of this revision. Herald

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

owenpan added a comment. In D151047#4396727 , @Sedeniono wrote: > So, the new patch basically just reverts the original fix of > https://reviews.llvm.org/D129064 (i.e. it re-introduces the `resize()` in > `LevelIndentTracker::nextLine()`). The other

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe marked an inline comment as done. mikecrowe added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-print.cpp:9-15 +#include +#include +#include +// CHECK-FIXES: #include +#include +#include +#include

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added a comment. In D149280#4447363 , @thakis wrote: > This breaks tests on windows: http://45.33.8.238/win/80283/step_8.txt > > Please take a look and revert for now if it takes a while to fix. Thanks for letting me know, I thought I could

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL reopened this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. @thakis Thank you. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-print.cpp:9-15 +#include +#include +#include +// CHECK-FIXES: #include

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/80283/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149280/new/

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 added a comment. In D117929#4445858 , @MaskRay wrote: > I am still interested in a RISC-V XRay port :) Sorry - lost track of this, things have been hectic for the last few months, but we also seem to have got custom events working with

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

serge-sans-paille added a comment. Gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151753/new/ https://reviews.llvm.org/D151753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153716: [ASTMatchers] Add argumentCountAtLeast narrowing matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae8a4a17888: [ASTMatchers] Add argumentCountAtLeast narrowing matcher (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2ae8a4a - [ASTMatchers] Add argumentCountAtLeast narrowing matcher

Author: Mike Crowe Date: 2023-06-25T18:41:55Z New Revision: 2ae8a4a17888f739c1082f52eed56887c2004908 URL: https://github.com/llvm/llvm-project/commit/2ae8a4a17888f739c1082f52eed56887c2004908 DIFF: https://github.com/llvm/llvm-project/commit/2ae8a4a17888f739c1082f52eed56887c2004908.diff LOG:

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

thakis added a comment. Reverted in b851308b870a67ccb606d0d33f159a70fd3522c7 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 ___ cfe-commits mailing

[clang] b851308 - Revert "[COFF] Support -gsplit-dwarf for COFF on Windows"

Author: Nico Weber Date: 2023-06-25T14:32:36-04:00 New Revision: b851308b870a67ccb606d0d33f159a70fd3522c7 URL: https://github.com/llvm/llvm-project/commit/b851308b870a67ccb606d0d33f159a70fd3522c7 DIFF: https://github.com/llvm/llvm-project/commit/b851308b870a67ccb606d0d33f159a70fd3522c7.diff

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

xen0n marked 2 inline comments as done. xen0n added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:732 +def warn_drv_loongarch_conflicting_mabi : Warning< + "the -mabi setting '%0' conflicts with that implied by -m*-float (%1); using %1">, +

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

xen0n updated this revision to Diff 534365. xen0n added a comment. Address @MaskRay's review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153707/new/ https://reviews.llvm.org/D153707 Files:

[PATCH] D153716: [ASTMatchers] Add argumentCountAtLeast narrowing matcher

PiotrZSL updated this revision to Diff 534363. PiotrZSL added a comment. Rebase + Added change to Registry.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153716/new/ https://reviews.llvm.org/D153716 Files:

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 534361. yonghong-song added a comment. - added support of new instructions in inline assembly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144829/new/ https://reviews.llvm.org/D144829 Files:

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534362. zyounan added a comment. Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D153725: [clang] Make amdgpu-arch tool work on Windows

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Herald added a reviewer: jdoerfert. Currently

[PATCH] D153716: [ASTMatchers] Add argumentCountAtLeast narrowing matcher

PiotrZSL added a comment. NOTE: Registry.cpp were not changed, I will add it there during commit if all tests locally pass. If tests fail, I will just add this matcher as private in clang-tidy check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534359. zyounan added a comment. And this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdPrintCheck.cpp:64 + if (MaybeHeaderToInclude) +Options.store(Opts, "PrintHeader", *MaybeHeaderToInclude); +} This is going to write the default value set in the

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:732 +def warn_drv_loongarch_conflicting_mabi : Warning< + "the -mabi setting '%0' conflicts

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan added inline comments. Comment at: clang/docs/ReleaseNotes.rst:524 crash when we encounter a unresolved TypoExpr during diagnostic emission. - (`#50244 _`). + (`#50244

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan created this revision. zyounan added reviewers: royjacobson, aaron.ballman, erichkeane, shafik. Herald added a project: All. zyounan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up patch to D126194

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL accepted this revision. PiotrZSL added a comment. Consider delivering this check. I do not think that it will become much better with more refactoring. Comment at: clang-tools-extra/clang-tidy/utils/FormatStringConverter.cpp:202-203 + assert(FormatExpr); + if

[PATCH] D153716: [ASTMatchers] Add argumentCountAtLeast narrowing matcher

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, Personally probably I would extract this to this level, and I would leave it private to a check, but it's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

This revision was automatically updated to reflect the committed changes. Closed by commit rG409a8097c5c7: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes (authored by hazohelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fa0dbd7bf35: [llvm] Move StringExtras.h include from Error.h to Error.cpp (authored by IncludeGuardian). Changed prior to commit: https://reviews.llvm.org/D153229?vs=533989=534347#toc Repository:

[PATCH] D152746: [C++20][Modules] Complete implementation of module.import p7.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb37233a253f3: [C++20][Modules] Complete implementation of module.import p7. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152746/new/

[PATCH] D153699: [clang] Fix pretty-printing for variables declared in a for-loop condition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf8d6d95ca64: [clang] Fix pretty-printing for variables declared in a for-loop condition (authored by vaithak, committed by MaskRay). Repository:

[clang] 409a809 - [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

Author: Takuya Shimizu Date: 2023-06-26T00:27:15+09:00 New Revision: 409a8097c5c728607eb6b05efb1744bf5f9096e1 URL: https://github.com/llvm/llvm-project/commit/409a8097c5c728607eb6b05efb1744bf5f9096e1 DIFF:

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/63504/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. @MaskRay good idea, I have split into 2 commits and pushed to the `main` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 ___

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

cor3ntin updated this revision to Diff 534328. cor3ntin added a comment. Rebase and update feature macro tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153702/new/ https://reviews.llvm.org/D153702 Files: clang/docs/ReleaseNotes.rst

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 534329. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://reviews.llvm.org/D153536 Files:

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

xen0n updated this revision to Diff 534326. xen0n marked an inline comment as done. xen0n added a comment. Grammatical fix of comment text ("is" -> "are"). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153707/new/ https://reviews.llvm.org/D153707

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:64 +// conflicts with the higher-priority settings implied by -m*-float. +if (!ImpliedABI.empty()) { + if (const Arg *A = Args.getLastArg(options::OPT_mabi_EQ)) {

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked an inline comment as done. Sedeniono added a comment. In D153228#4446523 , @MyDeveloperDay wrote: > For us to land this for you we'll need your name and email Please use: `Sedenion <39583823+sedeni...@users.noreply.github.com>` Thanks!

[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4967 +void Sema::checkRVVTypeSupport(QualType Ty, SourceLocation Loc, ValueDecl *D) { + const TargetInfo = Context.getTargetInfo(); craig.topper

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:15 #include "clang/AST/DeclObjC.h" +#include "clang/AST/Expr.h" #include "clang/AST/ExprCXX.h" ychen wrote: > shafik wrote: > > I saw your adding headers. How did you figure out which ones

[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

eopXD updated this revision to Diff 534317. eopXD added a comment. Herald added a subscriber: MaskRay. Add check for RVV boolean types and simplify if-condition under checkRVVTypeSupport. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153510/new/

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:64 +// conflicts with the higher-priority settings implied by -m*-float. +if

[PATCH] D153716: [ASTMatchers] Add argumentCountAtLeast narrowing matcher

mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. mikecrowe added inline comments. Comment at:

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

xen0n updated this revision to Diff 534325. xen0n added a comment. Refactored to reduce duplication of flag processing logic and save one level of indent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153707/new/ https://reviews.llvm.org/D153707

[PATCH] D151634: [clang] Add test for CWG253

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > Endill wrote: > >

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4626-4627 + verifyFormat(Code1, Style); + EXPECT_EQ(Code2, format(Code2, Style)); + EXPECT_EQ(Code3, format(Code3, Style)); + We have `verifyNoChange` now. See D153109.

[PATCH] D153716: [ASTMatchers] Add argumentCountAtLeast narrowing matcher

mikecrowe added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:1671 + notMatches("void x(int, int = 1) { x(0); }", + traverse(TK_IgnoreUnlessSpelledInSource, Call2PlusArgs))); + EXPECT_TRUE( I'm not

[clang-tools-extra] b0abd48 - [llvm] Add missing StringExtras.h includes

Author: Elliot Goodrich Date: 2023-06-25T15:42:22+01:00 New Revision: b0abd4893fa1bfae7f71b6b6e98770c9b1c07620 URL: https://github.com/llvm/llvm-project/commit/b0abd4893fa1bfae7f71b6b6e98770c9b1c07620 DIFF:

[clang] 5421057 - [Clang][NFC] Add feature test macro checks for C++2c

Author: Corentin Jabot Date: 2023-06-25T10:27:42+02:00 New Revision: 54210573ae918f6e0cab59bc5955a66bc34b5f6c URL: https://github.com/llvm/llvm-project/commit/54210573ae918f6e0cab59bc5955a66bc34b5f6c DIFF:

[clang] b37233a - [C++20][Modules] Complete implementation of module.import p7.

Author: Iain Sandoe Date: 2023-06-25T08:33:39+01:00 New Revision: b37233a253f30e4bd5f040d598826df443293bee URL: https://github.com/llvm/llvm-project/commit/b37233a253f30e4bd5f040d598826df443293bee DIFF: https://github.com/llvm/llvm-project/commit/b37233a253f30e4bd5f040d598826df443293bee.diff