[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3320 + // Annotate */&/&& in `operator` function calls as binary operators. + for (const auto *Tok = Line.First; Tok; Tok = Tok->Next) { rymiel wrote: > I assume this extra fixup

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9818 + D.hasClausesOfKind() || + (CGM.getLangOpts().OpenMP >= 51 && D.getDirectiveKind() == OMPD_target && + D.hasClausesOfKind()); ABataev wrote: > What if D

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. As long as there are no other failing tests, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154251/new/

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw added a comment. See the updated summary. There does not seem to be an issue on GitHub when I searched. I simply noticed it when reading the code in order to understand how strings got broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen added a comment. In D154176#4465223 , @mstorsjo wrote: > Is this a NFC change, as a preparation for a separate change? In that case, > please add an NFC tag to the subject - if not, please explain (and test) the > expected behaviour change.

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536501. owenpan added a comment. Don't fix the token type of */&/&& if the line is a function declaration. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

HaohaiWen updated this revision to Diff 536502. HaohaiWen added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154176/new/ https://reviews.llvm.org/D154176 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

h-vetinari added a comment. In D129635#4451189 , @saiislam wrote:> > Are there any features in this table which have been already implemented but > have not been tagged? > https://clang.llvm.org/docs/OpenMPSupport.html#openmp-5-1-implementation-details

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

FreddyYe updated this revision to Diff 536495. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address comment, thanks review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154209/new/ https://reviews.llvm.org/D154209 Files:

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added a comment. In any case the patch is good to go. It no longer relies on VLA size checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 ___ cfe-commits mailing list

[PATCH] D154070: [lld/COFF] Add /dwodir to enable DWARF fission with LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a631a8fedc2: [lld/COFF] Add /dwodir to enable DWARF fission with LTO (authored by HaohaiWen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154070/new/

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added a comment. @ABataev This is as close as I could get it to what you wanted. I don't know how to get hold of the target directive so late in the emission process i.e. in markedAsEscaped function. The target directive doesn't get visited in the var checked for escaped vars so I

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536489. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRuntime.h clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > doru1004 wrote: > > doru1004 wrote:

[PATCH] D153989: [compiler-rt] Move crt into builtins

smeenai added a comment. In D153989#4465907 , @phosek wrote: > In D153989#4465759 , @smeenai wrote: > >> Sorry, it's been a week :D I assume that crt doesn't need the builtins to be >> available for its

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. In D153989#4465759 , @smeenai wrote: > Sorry, it's been a week :D I assume that crt doesn't need the builtins to be > available for its configure (the way the rest of compiler-rt does)? If so, > this LGTM. Great question, I

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > doru1004 wrote: > > ABataev wrote: >

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > ABataev wrote: > > doru1004 wrote:

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > doru1004 wrote: > > doru1004 wrote:

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

ahatanak updated this revision to Diff 536479. ahatanak added a comment. Fix clang/test/Misc/warning-flags.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154251/new/ https://reviews.llvm.org/D154251 Files:

[PATCH] D154253: [clang] detect integer overflow through temporary values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb776e2a0b03e: [clang] detect integer overflow through temporary values (authored by lnihlen). Changed prior to commit:

[clang] b776e2a - [clang] detect integer overflow through temporary values

Author: Lucile Nihlen Date: 2023-06-30T23:19:04Z New Revision: b776e2a0b03e93c45deb92f36a391d457ae5b43f URL: https://github.com/llvm/llvm-project/commit/b776e2a0b03e93c45deb92f36a391d457ae5b43f DIFF: https://github.com/llvm/llvm-project/commit/b776e2a0b03e93c45deb92f36a391d457ae5b43f.diff

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa57bdc8fe687: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test (authored by hamishknight, committed by bnbarham). Changed prior

[clang] a57bdc8 - [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

Author: Hamish Knight Date: 2023-06-30T16:02:12-07:00 New Revision: a57bdc8fe68753c341cac0fcecabcd4d35e45466 URL: https://github.com/llvm/llvm-project/commit/a57bdc8fe68753c341cac0fcecabcd4d35e45466 DIFF: https://github.com/llvm/llvm-project/commit/a57bdc8fe68753c341cac0fcecabcd4d35e45466.diff

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > doru1004 wrote: > > doru1004 wrote:

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > doru1004 wrote: > > ABataev wrote:

[PATCH] D154270: [clang][CodeGen] Fix global variables initialized with an inheriting constructor.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Wow, what an amazing bug :) Comment at: clang/lib/CodeGen/CGDecl.cpp:2459 + if (!isa(Arg.getAnyValue())) +Arg.getAnyValue()->setName(D.getName()); Is

[PATCH] D154270: [clang][CodeGen] Fix global variables initialized with an inheriting constructor.

efriedma created this revision. efriedma added reviewers: rsmith, rnk, rjmccall, akhuang. Herald added a subscriber: kristof.beyls. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. For inheriting constructors which have to be emitted inline,

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp:293 + e = {E::E1}; + e = {0}; // expected-error {{cannot initialize a value of type 'E'

[PATCH] D153989: [compiler-rt] Move crt into builtins

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Sorry, it's been a week :D I assume that crt doesn't need the builtins to be available for its configure (the way the rest of compiler-rt does)? If so, this LGTM.

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15441-15443 // C++11 5.17p9: // The meaning of x = {v} [...] is that of x = T(v) [...]. The meaning // of x = {} is x = T(). The code change doesn't match this comment,

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen updated this revision to Diff 536466. lnihlen added a comment. remove extrneous clang:: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 Files: clang/docs/ReleaseNotes.rst

[PATCH] D153989: [compiler-rt] Move crt into builtins

phosek added a comment. @smeenai Do you have any opinion on this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 ___ cfe-commits mailing list

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains updated this revision to Diff 536457. iains added a comment. just rebased to support p1815 work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 Files:

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b29b8a2aba2: Expose DataflowAnalysisContext.querySolver(). (authored by bazuzi, committed by gribozavr). Repository: rG LLVM Github Monorepo

[clang] 3b29b8a - Expose DataflowAnalysisContext.querySolver().

Author: Samira Bazuzi Date: 2023-07-01T00:15:45+02:00 New Revision: 3b29b8a2aba205b59163ba11c537fbfe25133181 URL: https://github.com/llvm/llvm-project/commit/3b29b8a2aba205b59163ba11c537fbfe25133181 DIFF: https://github.com/llvm/llvm-project/commit/3b29b8a2aba205b59163ba11c537fbfe25133181.diff

[PATCH] D153375: [Clang] Fix incorrect use of direct initialization with copy initialization

shafik updated this revision to Diff 536451. shafik marked an inline comment as done. shafik added a comment. - Added release note - Added test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153375/new/ https://reviews.llvm.org/D153375 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11401-11402 llvm::Value *Args[] = { - emitUpdateLocation(CGF, C->getBeginLoc()), - getThreadID(CGF, C->getBeginLoc()), + RT.emitUpdateLocation(CGF, C->getBeginLoc()), +

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536443. jyu2 added a comment. Thanks Alexey!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/ https://reviews.llvm.org/D154180 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D154253: [clang] detect integer overflow through temporary values

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:15215 Exprs.append(Construct->arg_begin(), Construct->arg_end()); +else if (auto Temporary = dyn_cast(E)) + Exprs.push_back(Temporary->getSubExpr()); nit: `clang::` isn't

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f32baf17db1: [clang] Replace uses of CreateElementBitCast (NFC) (authored by JOE1994). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5f32baf - [clang] Replace uses of CreateElementBitCast (NFC)

Author: Youngsuk Kim Date: 2023-06-30T17:35:36-04:00 New Revision: 5f32baf17db172478f1081e3d345f08e1053579f URL: https://github.com/llvm/llvm-project/commit/5f32baf17db172478f1081e3d345f08e1053579f DIFF: https://github.com/llvm/llvm-project/commit/5f32baf17db172478f1081e3d345f08e1053579f.diff

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

yaxunl updated this revision to Diff 536431. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154207/new/ https://reviews.llvm.org/D154207 Files: clang/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix a FIXME from an earlier commit. Repository:

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

hamishknight marked an inline comment as done. hamishknight added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3965 unsaved_files); - std::unique_ptr Unit(ASTUnit::LoadFromCommandLine( + auto Unit = ASTUnit::LoadFromCommandLine( Args->data(),

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

hamishknight updated this revision to Diff 536426. hamishknight added a comment. Updated to use explicit `std::unique_ptr` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154257/new/ https://reviews.llvm.org/D154257 Files: clang/include/clang/Frontend/ASTUnit.h

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

arsenm added a comment. lgtm except for dropping test coverage Comment at: clang/test/Driver/hip-macros.hip:20 // RUN: -mwavefrontsize64 %s 2>&1 | FileCheck --check-prefixes=WAVE64 %s -// WAVE64-DAG: #define __AMDGCN_WAVEFRONT_SIZE 64 -// WAVE32-DAG: #define

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

benlangmuir accepted this revision. benlangmuir added a comment. Gotta love `return AST.release()` being passed directly back into `std::unique_ptr(...)`. Thanks for fixing! Comment at: clang/tools/libclang/CIndex.cpp:3965 unsaved_files); - std::unique_ptr

[PATCH] D154207: [AMDGPU] Rename predefined macro __AMDGCN_WAVEFRONT_SIZE

jdoerfert added a comment. I think this is a step in the right direction. @arsenm ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154207/new/ https://reviews.llvm.org/D154207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > ABataev wrote: > > doru1004 wrote:

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen added a comment. Added release note, fixed commit log. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 ___ cfe-commits mailing list

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen updated this revision to Diff 536413. lnihlen added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154253: [clang] detect integer overflow through temporary values

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253

[PATCH] D154253: [clang] detect integer overflow through temporary values

shafik added a comment. Nice catch, I missed that in my last fix: https://reviews.llvm.org/D137897 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154253/new/ https://reviews.llvm.org/D154253 ___

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11401-11402 llvm::Value *Args[] = { - emitUpdateLocation(CGF, C->getBeginLoc()), - getThreadID(CGF, C->getBeginLoc()), + RT.emitUpdateLocation(CGF, C->getBeginLoc()), +

[PATCH] D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test

hamishknight created this revision. hamishknight added a reviewer: bnbarham. hamishknight added a project: clang. Herald added subscribers: arphaman, martong. Herald added a project: All. hamishknight requested review of this revision. Herald added a subscriber: cfe-commits. Change

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:11383 void CGOpenMPRuntime::emitDoacrossOrdered(CodeGenFunction , - const OMPDependClause *C) { + const OMPClause *CL)

[PATCH] D154180: [OPENMP52] Codegen support for doacross clause.

jyu2 updated this revision to Diff 536394. jyu2 marked an inline comment as done. jyu2 added a comment. Thanks Alexey's review. This address Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154180/new/

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

JOE1994 updated this revision to Diff 536398. JOE1994 added a comment. Rebase Wait to check whether the libCXX CI passes after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154229/new/ https://reviews.llvm.org/D154229 Files:

[PATCH] D154176: [Driver][MSVC] Move lld specific flags before inputs

mstorsjo added a comment. Is this a NFC change, as a preparation for a separate change? In that case, please add an NFC tag to the subject - if not, please explain (and test) the expected behaviour change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154070: [lld/COFF] Add /dwodir to enable DWARF fission with LTO

mstorsjo added a comment. No objection from me here, this seems straightforward. We should probably add a corresponding option in the lld mingw frontend too (as a separate patch later). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154070/new/

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

eddyz87 added a comment. Hi Yonghong, What is the current plan for these changes? I'd like to refresh D140804 to make BPF_ST instruction available for cpu v4. I see that the latest CI run failed because of libcxx issue, I think it is completely unrelated to

[PATCH] D154253: [clang] detect integer overflow through temporary values

cjdb added a comment. > Fixes GH63629. Would you mind changing this to `Fixes #63629` please? That'll get it connected in GitHub. The patch looks good, would you mind adding some release notes before I give LGTM please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154253: [clang] detect integer overflow through temporary values

lnihlen created this revision. Herald added a project: All. lnihlen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes GH63629. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154253 Files:

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

lamb-j added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + arsenm wrote: > "on amdgpu target" doesn't sound grammatical "for the //amdgpu// target"? or "on AMD GPU targets?"

[PATCH] D154251: Add a flag to disable "duplicate definition of category" warnings

ahatanak created this revision. ahatanak added reviewers: Bigcheese, vsapsai. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154251 Files:

[PATCH] D154133: [amdgpu] start documenting amdgpu support by clang

arsenm added inline comments. Comment at: clang/docs/AMDGPUSupport.rst:20 + +Clang supports OpenCL, HIP and OpenMP on amdgpu target. + "on amdgpu target" doesn't sound grammatical CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154133/new/

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > doru1004 wrote: > > ABataev wrote: >

[PATCH] D152857: OpenMP: Don't use target regions in library function test

arsenm closed this revision. arsenm added a comment. 917eddfdcb15bddf67a54ede1f1643d5fc83628d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152857/new/ https://reviews.llvm.org/D152857

[clang] 917eddf - OpenMP: Don't use target regions in library function test

Author: Matt Arsenault Date: 2023-06-30T15:04:03-04:00 New Revision: 917eddfdcb15bddf67a54ede1f1643d5fc83628d URL: https://github.com/llvm/llvm-project/commit/917eddfdcb15bddf67a54ede1f1643d5fc83628d DIFF:

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Formula.h:71 + bool literal() const { +assert(kind() == Literal); castAsLiteral() ? Comment at:

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Arena.h:61 + /// Passing in the same formula will result in the same BoolValue. + /// FIXME: This

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > ABataev wrote: > > doru1004 wrote: >

[PATCH] D153962: [clang] Do not discard cleanups while processing immediate invocation

rsmith added a comment. LGTM, thank you for doing this! Comment at: clang/lib/Sema/SemaExpr.cpp:18201 +// Hence, in correct code any cleanup objects created inside current +// evaluation context must be outside the immediate invocation. +E =

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536326. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D152109: Update clang-repl documentation

Krishna-13-cyber added a comment. In D152109#4464563 , @v.g.vassilev wrote: > LGTM! If you don't have commit access I can commit this on your behalf. Yes, It would be great if you could land it on my behalf! Thanks. Repository: rG LLVM Github

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty); CGF.Builder.CreateMemCpy(DestPtr, SrcPtr, Size.getQuantity()); } JOE1994 wrote: > barannikov88 wrote: > > Just

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

dblaikie added a comment. In D152017#4462263 , @probinson wrote: >> we might emit member function declarations for call sites in DWARF, for >> instance > > So are you now leaning more toward wanting to emit the "used" declarations as > well? I'm sure

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added a comment. Since the timeline for being able to use this is dependent not only on commits but integrates as well, lets go ahead with this then. Can someone commit it for me when we're ready? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > doru1004 wrote: > > ABataev wrote: >

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2168 +ElementType = VLAType->getElementType(); +llvm::Value *VLASize = VLASizeMap[VLAType->getSizeExpr()]; +if (!VLASize) Use VLASizeMap.find() instead

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536322. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Formula.h:27 +/// +/// This often represents an assertion that is interesting to the analysis but +///

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1605-1606 +if (getLangOpts().OpenMPIsDevice) { + CGOpenMPRuntimeGPU = + *(static_cast(())); + if (RT.isDelayedVariableLengthDecl(*this, )) { ABataev wrote: > No need

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 updated this revision to Diff 536321. doru1004 marked 4 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153883/new/ https://reviews.llvm.org/D153883 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D153659: [RISCV] Fix name mangling for LMUL!=1 vector types with attribute(rvv_vector_bits)

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153659/new/ https://reviews.llvm.org/D153659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

craig.topper added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:275 CPU_SPECIFIC("core_5th_gen_avx_tsx", "broadwell", 'Y', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+movbe,+popcnt,+f16c,+avx,+fma,+bmi,+lzcnt,+avx2,+adx")

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + doru1004 wrote: > ABataev wrote: > > 1. Is it possible

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty); CGF.Builder.CreateMemCpy(DestPtr, SrcPtr, Size.getQuantity()); } barannikov88 wrote: > Just something to think about. >

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

cjdb added a comment. In D153359#4463009 , @tbaeder wrote: > @cjdb I know this is kind of silly after @hazohelet has already added it to > the release notes... but it seems like showing the difference is useless > since the difference was only

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:2806 + /// Return true if all the emissions for the VLA size have occured. + bool hasVLASize(const VariableArrayType *type); + ABataev wrote: > 1. Is it possible that

[PATCH] D152109: Update clang-repl documentation

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM! If you don't have commit access I can commit this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152109/new/ https://reviews.llvm.org/D152109

[PATCH] D153883: [Clang][OpenMP] Delay emission of __kmpc_alloc_shared for escaped VLAs

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:590-591 +void Emit(CodeGenFunction , Flags EmissionFlags) override { + CGOpenMPRuntimeGPU = + *(static_cast(())); + RT.getKmpcFreeShared(CGF, AddrSizePair); ``` auto

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall added a comment. In D153805#4464487 , @bazuzi wrote: > It looks like D153485 changes the context > for the last few comments significantly. What's the appetite for adding yet > another child commit to the

[PATCH] D154229: [clang] Replace uses of CreateElementBitCast (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. Looks pretty straightforward. Comment at: clang/lib/CodeGen/CGClass.cpp:1000 + SrcPtr = SrcPtr.withElementType(CGF.Int8Ty);

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added a comment. It looks like D153485 changes the context for the last few comments significantly. What's the appetite for adding yet another child commit to the chain D153485 is in that exposes the solver directly?

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

sammccall added a comment. LG as is, sorry for the noise! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + gribozavr2

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. Thank you @yaxunl. @rjmccall / @efriedma any input on this? I'd like to try landing it next week to unblock some additional work. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092

[PATCH] D154134: [clang] Fix ASTUnit working directory handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62e4c22c95a9: [clang] Fix ASTUnit working directory handling (authored by hamishknight, committed by bnbarham). Repository: rG LLVM Github

[clang] 62e4c22 - [clang] Fix ASTUnit working directory handling

Author: Hamish Knight Date: 2023-06-30T09:56:42-07:00 New Revision: 62e4c22c95a9c5fbbebded43388006d5fed3b613 URL: https://github.com/llvm/llvm-project/commit/62e4c22c95a9c5fbbebded43388006d5fed3b613 DIFF: https://github.com/llvm/llvm-project/commit/62e4c22c95a9c5fbbebded43388006d5fed3b613.diff

  1   2   3   >