[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

2023-07-15 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. It looks like the paragraphs in `class.member.lookup` have changed a lot and so the tests don't totally match in that directory. Fixing that seems like a big piece of work but maybe worth doing. Comment at: clang/include/clang/Sema/Lookup.h:152 +

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

2023-07-15 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik created this revision. shafik added reviewers: aaron.ballman, rsmith, cor3ntin. Herald added a project: All. shafik requested review of this revision. There are some cases during member lookup we are aggressively suppressing diagnostics when we should just be suppressing access control

[PATCH] D154093: [clang-format] Break long strings in Verilog

2023-07-15 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2247 bool DryRun, bool Strict) { - std::unique_ptr Token = + std::unique_ptr Token =

[PATCH] D154093: [clang-format] Break long strings in Verilog

2023-07-15 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 540752. sstwcw added a comment. - Add back the const qualifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

2023-07-15 Thread Younan Zhang via Phabricator via cfe-commits
zyounan created this revision. zyounan added reviewers: nridge, tom-anders, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added a comment. zyounan updated this revision to Diff 540687. zyounan published this revision for review. Herald added

[PATCH] D155385: [clangd] enable unused-include warnings for standard library headers

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Other

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9e6a342fdac8: [clangd] Implement end-definition-comment inlay hints (authored by daiyousei-qz, committed by sammccall). Changed prior to commit: https://reviews.llvm.org/D150635?vs=525922=540750#toc

[clang-tools-extra] 9e6a342 - [clangd] Implement end-definition-comment inlay hints

2023-07-15 Thread Sam McCall via cfe-commits
Author: daiyousei-qz Date: 2023-07-16T01:19:02+02:00 New Revision: 9e6a342fdac8978ef6d3e373cbbc7425e3dfe0f8 URL: https://github.com/llvm/llvm-project/commit/9e6a342fdac8978ef6d3e373cbbc7425e3dfe0f8 DIFF: https://github.com/llvm/llvm-project/commit/9e6a342fdac8978ef6d3e373cbbc7425e3dfe0f8.diff

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Oh no, I just saw this never landed - I suspect you were waiting for me to commit it, and I was expecting you to do it! I've rebased and I'll commit it for you now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

2023-07-15 Thread Ziqing Luo via Phabricator via cfe-commits
ziqingluo-90 added a comment. Re-landed in `a07a6f6c74a03405eccdcd3832acb2187d8b9c21` Moved the use of `clang::Sema` from `UnsafeBufferAnalysis` to `AnalysisBasedWarnings`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150338/new/

[clang] a07a6f6 - Re-land "5b012bf5ab5fcb840fe7f6c8664b8981ce6f24f3"

2023-07-15 Thread via cfe-commits
Author: ziqingluo-90 Date: 2023-07-15T16:11:37-07:00 New Revision: a07a6f6c74a03405eccdcd3832acb2187d8b9c21 URL: https://github.com/llvm/llvm-project/commit/a07a6f6c74a03405eccdcd3832acb2187d8b9c21 DIFF: https://github.com/llvm/llvm-project/commit/a07a6f6c74a03405eccdcd3832acb2187d8b9c21.diff

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

2023-07-15 Thread Ziqing Luo via Phabricator via cfe-commits
ziqingluo-90 added a comment. In D150338#4502885 , @chapuni wrote: > Excuse me, I have reverted this due to circular deps. > `clangAnalysis` should not depend on `clangSema`. Thank you @chapuni , I will fix it soon. Repository: rG LLVM Github

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

2023-07-15 Thread Richard Dzenis via Phabricator via cfe-commits
RIscRIpt updated this revision to Diff 540741. RIscRIpt marked 7 inline comments as done. RIscRIpt added a comment. Addressed review comments, rebased onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153914/new/

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

2023-07-15 Thread Richard Dzenis via Phabricator via cfe-commits
RIscRIpt added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1972-1987 + SmallString<64> Str; + llvm::raw_svector_ostream OS(Str); + Token Exp; + Exp.startToken(); + if (Tok.getKind() == tok::kw_L__FUNCTION__ || + Tok.getKind() ==

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

2023-07-15 Thread Timo Stripf via Phabricator via cfe-commits
strimo378 created this revision. strimo378 added reviewers: aaron.ballman, hazohelet, stephenkelly. strimo378 added a project: clang. Herald added a project: All. strimo378 requested review of this revision. Herald added a subscriber: cfe-commits. Extended TextNodeDumper::VisitFunctionProtoType

[PATCH] D146777: [clang] Preliminary fat-lto-object support

2023-07-15 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Thank you for the update. I think this Clang patch is good enough to land even if the lld part is still in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/

[PATCH] D155339: Enable zba and zbs for RISCV64 Android

2023-07-15 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Driver/riscv-features.c:13 +// ANDROID: "-target-feature" "+zba" // ANDROID: "-target-feature" "+zbb" If the features are adjacent, test them on one line. `// ANDROID: "-target-feature" "+zba"

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D153946#4503585 , @sammccall wrote: > - maybe we can come up with some heuristics to improve the "no reserved > names" rule, with or without configuration. (Maybe apply it to only -isystem > headers? Linux uses

[PATCH] D155381: [clangd] Allow indexing of __reserved_names outside system headers

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D150221: Add option -fkeep-persistent-storage-variables to emit all variables that have a persistent storage duration

2023-07-15 Thread Hubert Tong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6ab91b1dcd: Add option -fkeep-persistent-storage-variables to emit all variables that have… (authored by qianzhen, committed by hubert.reinterpretcast). Changed prior to commit:

[clang] bb6ab91 - Add option -fkeep-persistent-storage-variables to emit all variables that have a persistent storage duration

2023-07-15 Thread Hubert Tong via cfe-commits
Author: Zheng Qian Date: 2023-07-15T16:13:48-04:00 New Revision: bb6ab91b1dcd2fadfddffcd020439978af184862 URL: https://github.com/llvm/llvm-project/commit/bb6ab91b1dcd2fadfddffcd020439978af184862 DIFF: https://github.com/llvm/llvm-project/commit/bb6ab91b1dcd2fadfddffcd020439978af184862.diff

[PATCH] D155380: [clang] Fix delayed template parsing

2023-07-15 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, efriedma, mgorny. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Commit 98390ccb80569e8fbb20e6c996b4b8cff87fbec6

[PATCH] D153946: [clangd] Add a flag to allow indexing of reserved identifiers

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks for putting this together, it definitely seems like something people want. My main concern is that the configuration has the wrong scope. We're checking whether reserved-ident indexing is on for the **TU** we're indexing, but really we want to specify which

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

2023-07-15 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 540716. craig.topper added a comment. Merge identical tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154647/new/ https://reviews.llvm.org/D154647 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

2023-07-15 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 540714. craig.topper added a comment. Rebase. Will merge tests next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154647/new/ https://reviews.llvm.org/D154647 Files:

[PATCH] D154616: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

2023-07-15 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG599421ae36c3: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 599421a - [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

2023-07-15 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2023-07-15T11:19:18-07:00 New Revision: 599421ae36c332474c5034b4baaab59833e76418 URL: https://github.com/llvm/llvm-project/commit/599421ae36c332474c5034b4baaab59833e76418 DIFF: https://github.com/llvm/llvm-project/commit/599421ae36c332474c5034b4baaab59833e76418.diff

[PATCH] D155358: [clang-format] Correctly annotate overloaded operator function name

2023-07-15 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc2ff02eaded: [clang-format] Correctly annotate overloaded operator function name (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] cc2ff02 - [clang-format] Correctly annotate overloaded operator function name

2023-07-15 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-07-15T11:02:31-07:00 New Revision: cc2ff02eadede988ab890b2d0f428bd1531a3803 URL: https://github.com/llvm/llvm-project/commit/cc2ff02eadede988ab890b2d0f428bd1531a3803 DIFF: https://github.com/llvm/llvm-project/commit/cc2ff02eadede988ab890b2d0f428bd1531a3803.diff

[PATCH] D155374: [clang][Interp] Implement __builtin_isnormal

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155372: [clang][Interp] Implement __builtin_isfinite

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 540699. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155372/new/ https://reviews.llvm.org/D155372 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/Interp/builtin-functions.cpp

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Sorry about the delay here. Making the whole AutoTypeLoc resolve to the concept doesn't seem right - the `auto` part does not refer to the concept, and in principle refers to another type entirely. Really I think there should be a child node representing just the

[PATCH] D155372: [clang][Interp] Implement __builtin_isfinite

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155371: [clang][Interp] Implement __builtin_isinf

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 540693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155371/new/ https://reviews.llvm.org/D155371 Files: clang/lib/AST/Interp/Floating.h clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index:

[PATCH] D153485: [dataflow] use true/false literals in formulas, rather than variables

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall reopened this revision. sammccall added a comment. This revision is now accepted and ready to land. (this was reverted, I want to reland sometime, but there's a bad interaction with a bug in nullability analysis) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; cor3ntin wrote: >

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 540692. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155369/new/ https://reviews.llvm.org/D155369 Files: clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h

[PATCH] D155371: [clang][Interp] Implement __builtin_isinf

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

2023-07-15 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; tbaeder wrote: > cor3ntin wrote: > > You can compare

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; cor3ntin wrote: > You can compare getBuiltinID(), which is

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

2023-07-15 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4220 /// \version 3.7 bool SpacesInParentheses; The deprecated options should be removed from the struct, see `AllowAllConstructorInitializersOnNextLine` for an

[PATCH] D154093: [clang-format] Break long strings in Verilog

2023-07-15 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2247 bool DryRun, bool Strict) { - std::unique_ptr Token = + std::unique_ptr Token = createBreakableToken(Current, State,

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

2023-07-15 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; You can compare getBuiltinID(), which is better than using

[PATCH] D155204: [clang][dataflow] Add `refreshStructValue()`.

2023-07-15 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:706-711 +/// This function is primarily intended for use by checks that set custom +/// properties on `StructValue`s to model the

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-15 Thread Sedenion via Phabricator via cfe-commits
Sedeniono added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:664 +"#endif\n" // That this line is also formatted might be a bug. +"}};", // Dito: Bug? +format(" class Foo {\n"

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-15 Thread Sedenion via Phabricator via cfe-commits
Sedeniono updated this revision to Diff 540683. Sedeniono marked 4 inline comments as done. Sedeniono added a comment. Fixed typo in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 Files:

[PATCH] D155094: Refactoring and asserts in LevelIndentTracker. (NFC)

2023-07-15 Thread Sedenion via Phabricator via cfe-commits
Sedeniono updated this revision to Diff 540682. Sedeniono added a comment. Implemented review changes suggested by @owenpan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155094/new/ https://reviews.llvm.org/D155094 Files:

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a way to pop arguments based on the call

[PATCH] D155368: [clang][Interp] __builtin_copysign

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Tests will come in a later commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155367/new/ https://reviews.llvm.org/D155367 ___ cfe-commits mailing list

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-15 Thread Sedenion via Phabricator via cfe-commits
Sedeniono marked 4 inline comments as done. Sedeniono added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:641-646 + Style = getLLVMStyle(); + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

2023-07-15 Thread Tristan Labelle via Phabricator via cfe-commits
MrTrillian added a comment. > That could impose a significant performance and drive space penalty in the > event that substitute drive paths are changed, but I would expect such > changes to be rare. I think the more likely case is that one would build their repo under the substitute drive

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

2023-07-15 Thread Tristan Labelle via Phabricator via cfe-commits
MrTrillian added a comment. > I took a look at the code and it looks to me like it would be safe to change > ModuleMap::canonicalizeModuleMapPath() to use a drive preserving > canonicalization Symbolic links can point across drives so I think a drive preserving canonicalization cannot be much

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

2023-07-15 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:791-800 + // This unnecessary copy is because: + // warning: captured structured bindings are a C++20 extension + // [-Wc++20-extensions] + LabelDecl *TL = TargetLabel; + //

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

2023-07-15 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. Thanks a lot for working on this. This probably needs a release note entry Comment at: clang/lib/Sema/JumpDiagnostics.cpp:790 // reach this label scope. for (auto [JumpScope, JumpStmt] : JumpScopes) { + // This unnecessary copy is

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

2023-07-15 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu added a comment. What about combine the rv32 and rv64 into one file, since they are entire same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154647/new/ https://reviews.llvm.org/D154647 ___

[PATCH] D154647: [RISCV] Re-define sha256, Zksed, and Zksh intrinsics to use i32 types.

2023-07-15 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154647/new/ https://reviews.llvm.org/D154647

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

2023-07-15 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:3288-3291 + assert( + (StringToks.size() != 1 || + !tok::isUnexpandableMsMacro(StringToks[0].getKind())) && + "single predefined identifiers shall be handled by ActOnPredefinedExpr");

[PATCH] D153616: [clang][Interp] Create a new local variable in visitLambdaExpr()

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153616/new/ https://reviews.llvm.org/D153616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155358: [clang-format] Correctly annotate overloaded operator function name

2023-07-15 Thread Emilia Kond via Phabricator via cfe-commits
rymiel accepted this revision. rymiel added a comment. Was caused by 3f3620e5c9ee0f7b64afc39e5a26c6f4cc5e7b37 , thank you for fixing it up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155361: [Tooling] Avoid boilerplate in common cases

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 540660. sammccall added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155361/new/ https://reviews.llvm.org/D155361 Files: clang/include/clang/Tooling/AllTUsExecution.h

[PATCH] D155361: [Tooling] Avoid boilerplate in common cases

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 540659. sammccall added a comment. squash commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155361/new/ https://reviews.llvm.org/D155361 Files: clang/include/clang/Tooling/AllTUsExecution.h

[PATCH] D155361: [Tooling] Avoid boilerplate in common cases

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 540657. sammccall added a comment. tweak comment, remove unused overload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155361/new/ https://reviews.llvm.org/D155361 Files:

[PATCH] D155361: [Tooling] Avoid boilerplate in common cases

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 540656. sammccall edited the summary of this revision. sammccall added a comment. update description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155361/new/ https://reviews.llvm.org/D155361 Files:

[PATCH] D155361: [Tooling] Avoid boilerplate in common cases

2023-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tooling APIs have a lot of extension points for customization: e.g. Executor, FrontendActionFactory,

[PATCH] D154616: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

2023-07-15 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 540651. craig.topper added a comment. Rebase. I'll commit tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154616/new/ https://reviews.llvm.org/D154616 Files:

[PATCH] D155358: [clang-format] Correctly annotate overloaded operator function name

2023-07-15 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. The `operator` keyword preceded by a template closer should be

[PATCH] D154616: [RISCV] Use unsigned instead of signed types for Zk* and Zb* builtins.

2023-07-15 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu accepted this revision. VincentWu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154616/new/ https://reviews.llvm.org/D154616

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

2023-07-15 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One existing problem is that we can't do much with