[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

PiotrZSL updated this revision to Diff 554028. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Fix some Pylint issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ https://reviews.llvm.org/D158929 Files: clang-t

[clang] cd591e0 - Revert "Reland "[Profile] Allow online merging with debug info correlation.""

Author: Vitaly Buka Date: 2023-08-28T13:01:25-07:00 New Revision: cd591e02d4563d4b90792ed5f441e1cf5b30443e URL: https://github.com/llvm/llvm-project/commit/cd591e02d4563d4b90792ed5f441e1cf5b30443e DIFF: https://github.com/llvm/llvm-project/commit/cd591e02d4563d4b90792ed5f441e1cf5b30443e.diff L

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl marked 2 inline comments as done. AntonRydahl added inline comments. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:11 +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fexceptions %s -emit-llvm -S -verify=with -Wopenmp-target-ex

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 updated this revision to Diff 554025. jyu2 added a comment. Thanks @rnk. This is address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158538/new/ https://reviews.llvm.org/D158538 Files: clang/lib/AST/ASTContext.cpp clang/li

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 added a comment. Hi @rnk, Thank you so much for the suggestion. >> Before we do that, you should be able to delete the logic in >> CodeGenModule::getFunctionLinkage to handle inheriting constructor thunks. >> Your change should have the same effect. Can you do that, and check that it >>

[PATCH] D154382: [ClangRepl] support code completion at a REPL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ab25a42ba70: Reland "[clang-repl] support code completion at a REPL." (authored by capfredf, committed by v.g.vassilev). Changed prior to commit:

[clang-tools-extra] 5ab25a4 - Reland "[clang-repl] support code completion at a REPL."

Author: Fred Fu Date: 2023-08-28T19:59:56Z New Revision: 5ab25a42ba70c4b50214b0e78eaaccd30696fa09 URL: https://github.com/llvm/llvm-project/commit/5ab25a42ba70c4b50214b0e78eaaccd30696fa09 DIFF: https://github.com/llvm/llvm-project/commit/5ab25a42ba70c4b50214b0e78eaaccd30696fa09.diff LOG: Relan

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Basic/SizedDeallocation.h:23 +namespace clang { +inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) { + switch (OS) { Does this need to be in Ba

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. Could this be related https://lab.llvm.org/buildbot/#/builders/127/builds/54239 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 _

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

vitalybuka added a comment. It's more convenient if you upload new patches into original review and reland that one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 __

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e2a5e260c2: [clang-tidy][readability] add Leading_upper_snake_case (authored by MasterCopy8GB, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D158787?vs=553593&id=554022#toc

[clang-tools-extra] f0e2a5e - [clang-tidy][readability] add Leading_upper_snake_case

Author: MasterCopy8GB Date: 2023-08-28T19:53:09Z New Revision: f0e2a5e260c24597f11b122d20051f057d96b544 URL: https://github.com/llvm/llvm-project/commit/f0e2a5e260c24597f11b122d20051f057d96b544 DIFF: https://github.com/llvm/llvm-project/commit/f0e2a5e260c24597f11b122d20051f057d96b544.diff LOG:

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554021. AntonRydahl added a comment. Moved emission of warnings from CodeGen to Sema to allow using `-verify -analyze`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/D1

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne added a comment. Herald added a subscriber: JDevlieghere. Sorry for spamming everyone, I'm trying to ensure that the CI will work with all the sub-projects in the monorepo once we move to GH PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:287 + static_assert((char16_t)L'ゆ' == L"C̵̭̯̠̎͌ͅť̺"[1], ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''ゆ' (0

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6207f6e0d04: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang-tools-extra] 6e2d94a - [clang-tidy][NFC] Relase notes for modernize-use-std-print

Author: Piotr Zegar Date: 2023-08-28T19:44:24Z New Revision: 6e2d94a40d17832a04de7bb5294388fbf7f95991 URL: https://github.com/llvm/llvm-project/commit/6e2d94a40d17832a04de7bb5294388fbf7f95991 DIFF: https://github.com/llvm/llvm-project/commit/6e2d94a40d17832a04de7bb5294388fbf7f95991.diff LOG: [

[clang-tools-extra] c6207f6 - [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

Author: Mike Crowe Date: 2023-08-28T19:44:23Z New Revision: c6207f6e0d04f129b4ec2ada644c0224038f4705 URL: https://github.com/llvm/llvm-project/commit/c6207f6e0d04f129b4ec2ada644c0224038f4705 DIFF: https://github.com/llvm/llvm-project/commit/c6207f6e0d04f129b4ec2ada644c0224038f4705.diff LOG: [c

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne updated this revision to Diff 554016. ldionne marked an inline comment as done. ldionne added a comment. Herald added a reviewer: bollu. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, Enna1, yota9, ayermolo, jvesely. Herald ad

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c760ca8ecfd: [Clang][CodeGen] `typeid` needs special care when `type_info` is not in the… (authored by AlexVlx). Repository: rG LLVM Github Monor

[clang] 9c760ca - [Clang][CodeGen] `typeid` needs special care when `type_info` is not in the default AS

Author: Alex Voicu Date: 2023-08-28T20:44:06+01:00 New Revision: 9c760ca8ecfd570212b47a5e980d38575b879029 URL: https://github.com/llvm/llvm-project/commit/9c760ca8ecfd570212b47a5e980d38575b879029 DIFF: https://github.com/llvm/llvm-project/commit/9c760ca8ecfd570212b47a5e980d38575b879029.diff LO

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554015. ldionne added a comment. Set VC variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe added a comment. > Additionally user could always take "main" version, and use it just to apply > fixes from this check. OK. Can this land on main then? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156616/new/ https://reviews.

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. I think it's fine now given that it's passing tests. Others feel free to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ h

[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:121 const ArgList &Args, - std::vector &Features) { + std::vector &Features, bool ForAS) { + if (ForAS)

[PATCH] D159010: [Driver,X86] Ignore -mfpmath= for assembler input

MaskRay created this revision. MaskRay added reviewers: mgorny, thesamesam. Herald added subscribers: pengfei, kristof.beyls. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang.

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

DiggerLin added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:566 static bool checkAliasedGlobal( -DiagnosticsEngine &Diags, SourceLocation Location, bool IsIFunc, -const llvm::GlobalValue *Alias, const llvm::GlobalValue *&GV, +ASTContext &Context,

[PATCH] D158923: [clang-c] Visit ranged for initializer

aaron.ballman added a comment. In D158923#4619375 , @kiloalphaindia wrote: > Can we get this into release/17.x still? Alas, but no -- 17.x changes are being limited to just fixes for critical issues/regressions at this point. (Once we start issuing rel

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a small nit Comment at: clang/lib/Sema/SemaDecl.cpp:13453-13466 +if (!VDeclType->isDependentType() && +Context.getAsIncompleteArrayType(VDeclType)) { + if (Init && !Init->getType().i

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added a comment. Are these matchers going to be used in-tree (by clang-tidy, or something else)? We typically do not add new AST matches until there's a need for them because the AST matchers have a pretty big impact on build times of Clang itself. Comment at: c

[PATCH] D126586: [InstrProf] Single byte counters in coverage

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4812 +} else + CGF.incrementProfileCounter(E); + } This can be hoist outside `if (llvm::EnableSingleByteCoverage)` Comment at: clang/lib/CodeGe

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 554002. capfredf added a comment. fix memory issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang-tools-extra/clangd/CodeComplete.cpp clang/includ

[PATCH] D158857: [clang][aarch64] Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr for aarch64

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. I think this looks good to me. I remember I also had to make this change to accept old datalayout strings https://reviews.llvm.org/D67631. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D158709#4622006 , @iana wrote: > In D158709#4621199 , @aaron.ballman > wrote: > >> At a hig

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 553995. ldionne added a comment. Poke CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-buildbot

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. + llvm:

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

iana added a comment. In D158709#4621199 , @aaron.ballman wrote: > At a high-level (not just for this patch, but for the entire series): is this > need specific to your downstream or is this a more general need? e.g., should > this complexity be kept d

[PATCH] D126586: [InstrProf] Single byte counters in coverage

gulfem updated this revision to Diff 553992. gulfem added a comment. Fixed the issue that causes a crash in InstCombinePHI.cpp. Phi instructions need to be inserted at the beginning of basic blocks, and profile increments need to inserted after phis for conditional operators. Repository: rG LL

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

PiotrZSL added a comment. In D156616#4621975 , @mikecrowe wrote: > The removal of `c_str()` happens even without StrictMode set to True. I still think we will be fine. There are not many situations when arguments need to be reorder. And most probably no

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 553991. saiislam marked 3 inline comments as done. saiislam added a comment. Minor fixes addressing reviewer's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D13973

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

MaskRay added a comment. > [VE][Clang] Change to enable VPU flag by default For components like llvm/, clang/, we usually use a more specific tag. I'd pick `[Driver]` over `[Clang]`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe added a comment. In D156616#4621945 , @PiotrZSL wrote: > In D156616#4621914 , @mikecrowe > wrote: > >> @PiotrZSL, I think that this is quite an important fix since without it the >> check completely ma

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

This revision was automatically updated to reflect the committed changes. Closed by commit rG824b13659130: [clang][dataflow] Support range-for loops in fixpoint algorithm. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158848/ne

[clang] 824b136 - [clang][dataflow] Support range-for loops in fixpoint algorithm.

Author: Yitzhak Mandelbaum Date: 2023-08-28T17:35:34Z New Revision: 824b136591303a2bec62cc752ec89843fbbc0ca0 URL: https://github.com/llvm/llvm-project/commit/824b136591303a2bec62cc752ec89843fbbc0ca0 DIFF: https://github.com/llvm/llvm-project/commit/824b136591303a2bec62cc752ec89843fbbc0ca0.diff

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector &Features) { + // Defaults. + bool EnableVPU = true;

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rGd80992032fd0: Reland "[Profile] Allow online merging with debug info correlation." (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D1

[clang] d809920 - Reland "[Profile] Allow online merging with debug info correlation."

Author: Zequan Wu Date: 2023-08-28T13:32:55-04:00 New Revision: d80992032fd0d7da70b2bd1a59066703c3c21fbb URL: https://github.com/llvm/llvm-project/commit/d80992032fd0d7da70b2bd1a59066703c3c21fbb DIFF: https://github.com/llvm/llvm-project/commit/d80992032fd0d7da70b2bd1a59066703c3c21fbb.diff LOG

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. In D156616#4621914 , @mikecrowe wrote: > @PiotrZSL, I think that this is quite an important fix since without it the > check completely mangles th

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

rnk added a comment. It took me a while to find this code to understand the issue. The problem is that there is an inconsistency between the GVA linkage and the LLVM IR linkage for these constructors. In this godbolt example , `??0?$TInputDataVertexModel..`

[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

MaskRay added a comment. Ping:) This is probably a good candidate for `release/17.x` backporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158688/new/ https://reviews.llvm.org/D158688 ___ cfe-commit

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. Started a thread: https://discourse.llvm.org/t/exposing-the-diagnostic-engine-to-c/73092 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157572/new/ https://reviews.llvm.org/D157572

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

MasterCopy8GB added a comment. In D158787#4621915 , @PiotrZSL wrote: > In D158787#4621587 , @MasterCopy8GB > wrote: > >> Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. >> Could you pleas

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

PiotrZSL added a comment. In D158787#4621587 , @MasterCopy8GB wrote: > Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could > you please commit these changes for me? Thank you for all of your time and > effort! Under which use

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe added a comment. @PiotrZSL, I think that this is quite an important fix since without it the check completely mangles the code. Should it be put in the 17.x release branch too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156616/new/ h

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4617504 , @aaron.ballman wrote: > In D157572#4614561 , @cjdb wrote: > >> In D157572#4613622 , >> @aaron.ballman wrote: >> >>> In D157572

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

ldionne accepted this revision. ldionne added a comment. Sorry for missing a couple of direct pings. I have no concerns with the patch, perhaps I should not have marked my review as blocking in the first place. Thanks for doing this work, it's about time we updated this default! Repository:

[clang] b9b81e3 - [clang][modules] NFC: Use local instead of `ModuleFile` member

Author: Jan Svoboda Date: 2023-08-28T09:54:39-07:00 New Revision: b9b81e37fe63d661afa356eacc97208ccc85da29 URL: https://github.com/llvm/llvm-project/commit/b9b81e37fe63d661afa356eacc97208ccc85da29 DIFF: https://github.com/llvm/llvm-project/commit/b9b81e37fe63d661afa356eacc97208ccc85da29.diff L

[clang] 6fb08d8 - Reland "[clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file"

Author: Jan Svoboda Date: 2023-08-28T09:54:39-07:00 New Revision: 6fb08d8f558a6f28db7835acdb88cab83aea2eb4 URL: https://github.com/llvm/llvm-project/commit/6fb08d8f558a6f28db7835acdb88cab83aea2eb4 DIFF: https://github.com/llvm/llvm-project/commit/6fb08d8f558a6f28db7835acdb88cab83aea2eb4.diff L

[clang] d4a9121 - Reland "[clang][modules] Use relative offsets for input files"

Author: Jan Svoboda Date: 2023-08-28T09:54:39-07:00 New Revision: d4a912153488308ea9ab96a0267150460cdfc697 URL: https://github.com/llvm/llvm-project/commit/d4a912153488308ea9ab96a0267150460cdfc697 DIFF: https://github.com/llvm/llvm-project/commit/d4a912153488308ea9ab96a0267150460cdfc697.diff L

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12395-12398 + // TODO: This should probably just be llvm_unreachable and we should + // reject triples with random ABIs and such when we build the target. + // For now, crash. + llvm::report

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 553968. ldionne added a comment. Run script through bash on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

ellis accepted this revision. ellis added a comment. This revision is now accepted and ready to land. Thanks for adding the test case! Can you also link the original diff in the summary? Comment at: compiler-rt/test/profile/instrprof-merge-empty-data.test:1 +// Test +// RUN:

[PATCH] D158615: [clang] Emit an error if variable ends up with incomplete array type

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. I Think this change makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158615/new/ https://reviews.llvm.org/D158615 ___

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

aeubanks added a comment. I don't have all the context here, but seems fine once the commit description is updated with the new spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61670/new/ https://reviews.llvm.org/D61670

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3008-3011 + void ActOnHLSLTopLevelFunction(FunctionDecl *FD); void CheckHLSLEntryPoint(FunctionDecl *FD); + void CheckHLSLSemanticAnnotation(FunctionDecl *EntryPoint, Decl *Param, +

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

aeubanks added a comment. looks fine to me but I'll let ellis lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. In D158071#4621631 , @zaks.anna wrote: > Looks like @NoQ wetted the remaining code changes. The rest LGTM. > > Thank you for preparing the patch! Thank you for the help with review (to both you and @NoQ)! I've landed the c

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

bogner updated this revision to Diff 553964. bogner added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158803/new/ https://reviews.llvm.org/D158803 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/Diagnosti

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

enh added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower srhines wrote: > MaskRay wrote: > > enh wrote: > > > ilinpv wrote: >

[PATCH] D158538: [MS-ABI] Remove comdat attribute for inheriting ctor.

jyu2 added a comment. Ping, Our customer fond problem I submit bug: in https://github.com/llvm/llvm-project/issues/65045 This issue related with big change of 5179eb78210a2ad01a18c37b75048ccfe78414ac Where internal linkage for inheriting ctor were set in change set at following code. Could s

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

FlashSheridan added a comment. A couple of low-priority suggestions from Pylint 3 at 326 and 95: Comment at: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py:95 -def start_workers(max_tasks, tidy_caller, task_queue, lock, timeout): +def start_workers(max_tasks, tidy_calle

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

aaron.ballman added a comment. In D158995#4621441 , @ldionne wrote: > @aaron.ballman for awareness Thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D1

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

sepavloff updated this revision to Diff 553960. sepavloff added a comment. Fix documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153339/new/ https://reviews.llvm.org/D153339 Files: clang/docs/LanguageExtensions.rst clang/lib/Sema/Sem

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

ymandel updated this revision to Diff 553958. ymandel added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158848/new/ https://reviews.llvm.org/D158848 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp

[PATCH] D158071: [clang] Remove rdar links; NFC

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks like @NoQ wetted the remaining code changes. The rest LGTM. Thank you for preparing the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

zequanwu created this revision. zequanwu added reviewers: ellis, aeubanks. Herald added subscribers: Enna1, ormris. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Fixed the issue

[PATCH] D158247: [CUDA][HIP] Fix overloading resolution in global variable initializer

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158247/new/ https://reviews.llvm.org/D158247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158787: [clang-tidy][readability] add Leading_upper_snake_case

MasterCopy8GB added a comment. Hello @PiotrZSL, I do not have rights to commit to the LLVM repository. Could you please commit these changes for me? Thank you for all of your time and effort! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158787/new/ https://reviews.llvm.org/D158787 _

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added a comment. Just a few more nits. I think it's looking fine but I haven't tested it. Anyone else? Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:406 + // pass on -mllvm options to the clang + for (const opt::Arg *Arg : Args.filtered(OPT_ml

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a comment. > According to documentation of noteBottomOfStack, those should be tied to > thread creation, i.e. main and AsyncTaskRunner are two most common entry > points for threads that do parsing. Yeah, I was about to put this call there. But they both boil down to the single `

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

donat.nagy added a comment. Yes, adding tests that demonstrate the current behavior is a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158707/new/ https://reviews.llvm.org/D158707 ___ cfe-comm

[PATCH] D158985: [AST] Fix crash in evaluation of OpaqueExpr in Clangd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd703dcdfb08d: [AST] Fix crash in evaluation of OpaqueExpr in Clangd (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang-tools-extra] d703dcd - [AST] Fix crash in evaluation of OpaqueExpr in Clangd

Author: Ilya Biryukov Date: 2023-08-28T17:10:44+02:00 New Revision: d703dcdfb08dbd591589a12e0ca0852c5fd30a72 URL: https://github.com/llvm/llvm-project/commit/d703dcdfb08dbd591589a12e0ca0852c5fd30a72 DIFF: https://github.com/llvm/llvm-project/commit/d703dcdfb08dbd591589a12e0ca0852c5fd30a72.diff

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne added a subscriber: aaron.ballman. ldionne added a comment. @aaron.ballman for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 ___ cfe-commits

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a CI job for Clang on Windows that is separate from the monolithic job that gets added automatically via the

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added a comment. In D158707#4621270 , @donat.nagy wrote: > In D158707#4621135 , @steakhal > wrote: > >> Oh, so we would canonicalize towards a signed extent type. I see. I think >> I'm okay with that.

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a subscriber: rsmith. zyounan added a comment. Thanks for the reply. And I understand (and agree with) the point that it's better to solve this problem once and for all. > Currently the code in CompilerInstance::ExecuteAction seems to acknowledge > that there should be a fallback.

[PATCH] D158981: [clang][dataflow][NFC] Eliminate `getStorageLocation()` / `setStorageLocation()` in `DataflowAnalysisContext`.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. I love this! (specifically, that it simplifies the API surface) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158981/new/ https://reviews.llvm

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

kadircet added a comment. In D157963#4621206 , @HazardyKnusperkeks wrote: > @kadircet shouldn't you at least say why it got reverted? Even better state > your problem and give a chance to fix before you revert? Hi, https://reviews.llvm.org/rG7590b76570

[PATCH] D158991: [NFC][Clang] Add missing & to function argument

jmmartinez created this revision. Herald added a project: All. jmmartinez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158991 Files: clang/lib/CodeGen/CGCall.cpp Index

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1631 + const AnalysisOutputs &) { +EXPECT_THAT(Results.keys(), UnorderedElementsAre("after_loop")); + }); mboehme wrote: > I

[PATCH] D158848: [clang][dataflow] Support range-for loops in fixpoint algorithm.

ymandel updated this revision to Diff 553929. ymandel marked 2 inline comments as done. ymandel added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158848/new/ https://reviews.llvm.org/D158848 Files: clang/lib/

[PATCH] D158990: [NFC][Clang] Remove unused function `CodeGenModule::addDefaultFunctionDefinitionAttributes`

jmmartinez created this revision. Herald added a project: All. jmmartinez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158990 Files: clang/lib/CodeGen/CGCall.cpp clang

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

donat.nagy added a comment. In D158707#4621135 , @steakhal wrote: > Oh, so we would canonicalize towards a signed extent type. I see. I think I'm > okay with that. > However, I think this needs a little bit of polishing and testing when the > region doe

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

HazardyKnusperkeks added a subscriber: kadircet. HazardyKnusperkeks added a comment. @kadircet shouldn't you at least say why it got reverted? Even better state your problem and give a chance to fix before you revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D158709: [Headers][Modules] Make separate headers for the stdarg.h and stddef.h pieces so that they can be modularized

aaron.ballman added a comment. In D158709#4617783 , @iana wrote: > In D158709#4617295 , @aaron.ballman > wrote: > >> I'm a bit concerned about the impact on (non-modules) build time >> performance. This splits s

[PATCH] D158985: [AST] Fix crash in evaluation of OpaqueExpr in Clangd

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, clang-tools-extra. The cod

[PATCH] D158135: [Clang][CodeGen] Add __builtin_bcopy

cseo added a comment. FWIW, the pre-merge checks failed due to a problem with git-clang-format, not the tests themselves (they are all green). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158135/new/ https://reviews.llvm.org/D158135

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added a comment. Oh, so we would canonicalize towards a signed extent type. I see. I think I'm okay with that. However, I think this needs a little bit of polishing and testing when the region does not point to the beginning of an array or object, but rather inside an object, or like t

[PATCH] D158824: [RISCV][MC] MC layer support for xcvmem and xcvelw extensions

liaolucy updated this revision to Diff 553911. liaolucy added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments from Jim, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158824/new/ https://rev

<    1   2   3   >