[PATCH] D159293: [driver] Perform fallback target searches for stdlib

smeenai created this revision. smeenai added reviewers: MaskRay, phosek, thakis, glandium. Herald added a subscriber: abrachet. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Searching for

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

smeenai created this revision. smeenai added reviewers: danalbert, srhines, pcc, phosek, thakis, MaskRay, glandium. Herald added a subscriber: danielkiss. Herald added a project: All. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6658db5e5014: [clang] Fix timing of propagation of MSInheritanceAttr for template… (authored by tahonermann). Repository: rG LLVM Github Monorepo

[clang] 6658db5 - [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

Author: Tom Honermann Date: 2023-08-31T09:10:05-07:00 New Revision: 6658db5e501475bf288f6d9eb2a8ff21d5fee8b5 URL: https://github.com/llvm/llvm-project/commit/6658db5e501475bf288f6d9eb2a8ff21d5fee8b5 DIFF: https://github.com/llvm/llvm-project/commit/6658db5e501475bf288f6d9eb2a8ff21d5fee8b5.diff

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann updated this revision to Diff 555076. tahonermann added a comment. Added a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158869/new/ https://reviews.llvm.org/D158869 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

steakhal added inline comments. Comment at: clang/test/Analysis/memory-model.cpp:167 + clang_analyzer_dumpExtent(a); // expected-warning {{0 S64b}} + clang_analyzer_dumpElementCount(a); // expected-warning {{5 S64b}} + clang_analyzer_dumpExtent(t); //

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

PiotrZSL added a comment. In D159045#4631650 , @felix642 wrote: > We can already disable those options if we don't define them in the config. > Adding the possibility to provide optional values seems redundant to me. Do > you see any reason why we

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 555074. victorkingi added a comment. Moved function implementations from llvm directory to clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files:

[PATCH] D159045: [clang-tidy] Improved documentation for readability-function-size

felix642 added a comment. We can already disable those options if we don't define them in the config. Adding the possibility to provide optional values seems redundant to me. Do you see any reason why we would absolutely need to add this option to the config if we want to disable it?

[PATCH] D137338: Fix dupe word typos

ldionne added a comment. Herald added subscribers: wangpc, gysit, Dinistro, hoy, bviyer, wlei, jplehr, PiotrZSL, luke, sunshaoce. Herald added a reviewer: springerm. Herald added a reviewer: kiranchandramohan. Herald added a project: clang-format. Herald added reviewers: rymiel,

[libunwind] b397921 - [runtimes] Fix some duplicate word typos

Author: Louis Dionne Date: 2023-08-31T11:55:10-04:00 New Revision: b397921fc7ef4e2882b3ae9c5f12fb40daca4078 URL: https://github.com/llvm/llvm-project/commit/b397921fc7ef4e2882b3ae9c5f12fb40daca4078 DIFF: https://github.com/llvm/llvm-project/commit/b397921fc7ef4e2882b3ae9c5f12fb40daca4078.diff

[libunwind] ba55034 - [libunwind][NFC] Fix whitespace in comments

Author: Louis Dionne Date: 2023-08-31T11:55:10-04:00 New Revision: ba55034a898baf728f4d78ec811664b2a154bbfe URL: https://github.com/llvm/llvm-project/commit/ba55034a898baf728f4d78ec811664b2a154bbfe DIFF: https://github.com/llvm/llvm-project/commit/ba55034a898baf728f4d78ec811664b2a154bbfe.diff

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi abandoned this revision. victorkingi added a comment. Replaced by a series of patches already merged on github, starting from https://reviews.llvm.org/D157410 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne commandeered this revision. ldionne added a reviewer: t-tye. ldionne added a comment. Herald added a subscriber: jplehr. Herald added a project: All. [GitHub PR transition cleanup] This has been open for 2 years with multiple subscribers able to see this discussion, but there doesn't

[clang] 282da83 - [XCOFF][AIX] Issue an error when specifying an alias for a common symbol

Author: Stephen Peckham Date: 2023-08-31T11:43:47-04:00 New Revision: 282da837565fcf8598a81b5f3b34bc25705917d3 URL: https://github.com/llvm/llvm-project/commit/282da837565fcf8598a81b5f3b34bc25705917d3 DIFF:

[PATCH] D158739: AIX: Issue an error when specifying an alias for a common symbol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG282da837565f: [XCOFF][AIX] Issue an error when specifying an alias for a common symbol (authored by stephenpeckham). Changed prior to commit:

[PATCH] D157813: [Driver][VE] Change to enable VPU flag by default

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ce86002401: [Driver][VE] Change to enable VPU flag by default (authored by kaz7). Changed prior to commit: https://reviews.llvm.org/D157813?vs=554742=555063#toc Repository: rG LLVM Github Monorepo

[clang] b6ce860 - [Driver][VE] Change to enable VPU flag by default

Author: Kazushi (Jam) Marukawa Date: 2023-09-01T00:41:38+09:00 New Revision: b6ce860024013397982cdd26b762df8182b14df9 URL: https://github.com/llvm/llvm-project/commit/b6ce860024013397982cdd26b762df8182b14df9 DIFF:

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added a comment. Thanks for clarifying! If no further comments I'll commit this revison in a day or two! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158707/new/ https://reviews.llvm.org/D158707

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

nickdesaulniers added inline comments. Comment at: clang/test/Sema/warn-fortify-source.c:100-102 + __builtin_snprintf(buf, 2, "%#x", n); + __builtin_snprintf(buf, 2, "%#X", n); + __builtin_snprintf(buf, 2, "%#o", n); Note that GCC -Wformat-truncation can warn

[PATCH] D159263: [clang-tidy] misc-include-cleaner: fix duplicated fixes

danix800 updated this revision to Diff 555059. danix800 retitled this revision from "[clang-tidy] misc-include-cleaner: remove duplicated includes & fixes" to "[clang-tidy] misc-include-cleaner: fix duplicated fixes". danix800 edited the summary of this revision. danix800 added a comment. 1.

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

hazohelet added a comment. In D159138#4628858 , @nickdesaulniers wrote: > Mind adding tests for `%#X` and `%#o` as well, since you're changing the > behavior of those, too? > > I think it would also be good to have explicit tests for `%o` and `%b`

[PATCH] D159263: [clang-tidy] misc-include-cleaner: remove duplicated includes & fixes

danix800 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:169 + else +Unused.push_back(); + continue; sammccall wrote: > If we want this policy, it should be provided at the include-cleaner library >

[PATCH] D159263: [clang-tidy] misc-include-cleaner: remove duplicated includes & fixes

danix800 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:227 + << Inc.SymRef.Target.name(); + if (!AlreadyInserted.contains(Inc.Missing.resolvedPath())) { +DB << FixItHint::CreateInsertion(

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal added a comment. There are still a few FPs of the kind, where they iterate over the result of `getenv` in a loop, and continuously checks the character against the zero terminator. I refined the suppression heuristic as follows: - If the offset is zero, don't report taint issue. (as I

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez updated this revision to Diff 555051. jmmartinez added a comment. - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159206/new/ https://reviews.llvm.org/D159206 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

hazohelet updated this revision to Diff 555043. hazohelet marked an inline comment as done. hazohelet added a comment. Added `%X` and `%o` tests, which are also affected CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159138/new/ https://reviews.llvm.org/D159138 Files:

[PATCH] D159284: [clang][dataflow] Fix Record initialization with InitListExpr and inheritances

kinu added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:131 +// initialized with InitListExpr. assert(>getLoc() == >getLoc()); Note, this hits regardless of my change, but not very often. I haven't looked

[PATCH] D159284: Fix Record initialization with InitListExpr and inheritances

kinu created this revision. Herald added a reviewer: NoQ. Herald added a project: All. kinu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Usually RecordValues for record objects (e.g. struct) are initialized with

[PATCH] D159212: [MLIR] Allow dialects to disable CSE for certain operations

skatrak added a comment. Thank you for your comments @jsjodin and @kiranchandramohan , I created an RFC here to try to get consensus on what the best solution

[PATCH] D159261: [clang][dataflow] Eliminate deprecated `DataflowAnalysis` constructor.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159261/new/ https://reviews.llvm.org/D159261

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddb1b5da4: [clang][ci] Dont block all jobs on clang-format (authored by ldionne). Repository: rG LLVM Github

[clang] e34ddb1 - [clang][ci] Don't block all jobs on clang-format

Author: Louis Dionne Date: 2023-08-31T09:52:41-04:00 New Revision: e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1 URL: https://github.com/llvm/llvm-project/commit/e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1 DIFF: https://github.com/llvm/llvm-project/commit/e34ddb1b5da499d0e7c8e0d33ff1ec89d97cf5f1.diff

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

ldionne added a comment. In D159197#4628232 , @aaron.ballman wrote: > Thank you for this! I'm not qualified to say the changes are correct (they > look sensible to me though), but I am really appreciative of the change. Yup this is mostly for

[libclc] 37a3de1 - libclc: Fix signed integer underflow in abs_diff

Author: Fraser Cormack Date: 2023-08-31T14:28:16+01:00 New Revision: 37a3de1e2eedf848b8442217ef3790436f69a7db URL: https://github.com/llvm/llvm-project/commit/37a3de1e2eedf848b8442217ef3790436f69a7db DIFF:

[clang] 27313b6 - Revert "[CUDA][HIP] Fix overloading resolution in global variable initializer"

Author: Yaxun (Sam) Liu Date: 2023-08-31T09:02:49-04:00 New Revision: 27313b68ef0ec9a94c4288eca9af6ca25cd17f8f URL: https://github.com/llvm/llvm-project/commit/27313b68ef0ec9a94c4288eca9af6ca25cd17f8f DIFF:

[PATCH] D159107: [analyzer] ArrayBoundCheckerV2 should disallow forming lvalues to out-of-bounds locations

steakhal added a comment. In D159107#4631069 , @donat.nagy wrote: > In D159107#4630764 , @steakhal > wrote: > >> In D159107#4630573 , @donat.nagy >> wrote: >> >>> I

[PATCH] D159279: [clang] Emit `Wformat` for bool value and char specifier confusion in scanf

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/64987 Repository: rG LLVM Github Monorepo

[PATCH] D157747: Support Unicode Microsoft predefined macros

RIscRIpt abandoned this revision. RIscRIpt added a comment. I found a way to implement `__LPREFIX`-macros-family in Clang. I need some more time to finish and polish it. Going to post it a couple of weeks later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159107: [analyzer] ArrayBoundCheckerV2 should disallow forming lvalues to out-of-bounds locations

donat.nagy added a comment. In D159107#4630764 , @steakhal wrote: > In D159107#4630573 , @donat.nagy > wrote: > >> I don't think that the `[N]` issue is too serious: we can just increment >> the array extent

[PATCH] D158296: [clang] Diagnose overly complex Record in __builtin_dump_struct

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:732-733 +int RDKind = RD->isClass() ? 0 : (RD->isStruct() ? 1 : 2); +S.Diag(PtrArg->getBeginLoc(), diag::err_builtin_dump_struct_too_complex) +<< RDKind << RD->getName(); +return

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jmmartinez added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159256/new/ https://reviews.llvm.org/D159256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19550e79b50f: [NFC][Clang] Remove redundant function definitions (authored by jmmartinez). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 19550e7 - [NFC][Clang] Remove redundant function definitions

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2023-08-31T14:47:42+02:00 New Revision: 19550e79b50f0689404309a2c6091f0b53770e08 URL: https://github.com/llvm/llvm-project/commit/19550e79b50f0689404309a2c6091f0b53770e08 DIFF:

[PATCH] D159274: [clang][dataflow] When dumping `ExprToVal`, dump the `Value`, not just its location.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes `ExprToVal` dumping consistent with

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM but please add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158869/new/ https://reviews.llvm.org/D158869 ___

[PATCH] D159105: [analyzer] ArrayBoundCheckerV2 should check the region for taint as well

steakhal added a comment. I'm thinking of a heuristic like this: bool IsAtOffsetZero = [ByteOffset] { const auto *Int = ByteOffset.getAsInteger(); return Int && Int->isZero(); }(); // ... if (state_precedesLowerBound && state_withinLowerBound && !IsAtOffsetZero &&

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. In D159256#4630915 , @jmmartinez wrote: > In D159256#4630876 , @jhuber6 wrote: > >> In D159256#4630410

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jmmartinez added a comment. In D159256#4630876 , @jhuber6 wrote: > In D159256#4630410 , @jmmartinez > wrote: > >> @jhuber6 I was wondering if there is a reason you kept 3 versions of >>

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 closed this revision. usaxena95 added a comment. closed by ac2d2652db8de9ea2b750dd2bf1232941039dffe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] ac2d265 - [include-cleaner] Handle decls/refs to concepts

Author: Utkarsh Saxena Date: 2023-08-31T13:57:22+02:00 New Revision: ac2d2652db8de9ea2b750dd2bf1232941039dffe URL: https://github.com/llvm/llvm-project/commit/ac2d2652db8de9ea2b750dd2bf1232941039dffe DIFF:

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti marked an inline comment as done. 5chmidti added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D141757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jhuber6 added a comment. In D159256#4630410 , @jmmartinez wrote: > @jhuber6 I was wondering if there is a reason you kept 3 versions of > `mergeDefaultFunctionDefinitionAttributes` in > https://reviews.llvm.org/D152391 ? I believe it's because one

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc39dcd2c2bc7: [c++20][clangd] Simplify code using the new `ConceptReference` nodes. (authored by massberg). Repository: rG LLVM Github Monorepo

[clang-tools-extra] c39dcd2 - [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

Author: Jens Massberg Date: 2023-08-31T13:53:56+02:00 New Revision: c39dcd2c2bc7fd142ac8305b3a41f24e1addbd8c URL: https://github.com/llvm/llvm-project/commit/c39dcd2c2bc7fd142ac8305b3a41f24e1addbd8c DIFF: https://github.com/llvm/llvm-project/commit/c39dcd2c2bc7fd142ac8305b3a41f24e1addbd8c.diff

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

massberg updated this revision to Diff 554985. massberg marked an inline comment as done. massberg added a comment. Use VisitConceptReference instead of TraverseConceptReference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159268/new/

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:1059 - bool TraverseTypeConstraint(const TypeConstraint *TC) { -// We want to handle all

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM Unclear to me whether the FIXME will be addressed by an AST bug or a local change, either way continuing to look into it SG but this is fine to land as-is. Repository: rG LLVM

[PATCH] D159268: [c++20][clangd] Simplify code using the new `ConceptReference` nodes.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D159107: [analyzer] ArrayBoundCheckerV2 should disallow forming lvalues to out-of-bounds locations

steakhal added a comment. In D159107#4630573 , @donat.nagy wrote: > I don't think that the `[N]` issue is too serious: we can just increment > the array extent when the parent expression of the array subscript operator > is the unary operator `&`. If

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 updated this revision to Diff 554962. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/ https://reviews.llvm.org/D158842 Files:

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:244 + bool VisitConceptDecl(ConceptDecl *CD) { +report(CD->getLocation(), CD); I don't know why we're doing this, decls in general are not considered

[PATCH] D159263: [clang-tidy] misc-include-cleaner: remove duplicated includes & fixes

sammccall added a comment. Thanks! @kadircet should make the call on these features (they look good to me), I have some implementation notes. This is making two independent changes, one is a policy change that should be applied to the include-cleaner library, and one is a bugfix to the

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:217 +void $2^func2() requires $Bar4^Bar {} + )cpp"); + Inputs.Code = Code.code(); sammccall wrote: > to complete the set I think you want > > `void

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 updated this revision to Diff 554955. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Rebased over AST changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/ https://reviews.llvm.org/D158842 Files:

[PATCH] D159264: [clang][dataflow] Remove deprecated synonyms related to `RecordStorageLocation` and `RecordValue`

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D159263: [clang-tidy] misc-include-cleaner: remove duplicated includes & fixes

danix800 created this revision. danix800 added reviewers: VitaNuo, kadircet, sammccall. danix800 added a project: clang-tools-extra. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. danix800 requested review of this

[PATCH] D154838: [analyzer] Add check for null pointer passed to the %p of printf family

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. I'd suggest renaming the checker to `alpha.unix.NullFormatSpecifier`. Maybe add tests where multiple format specifiers are null, and also one test where no variadic args are

[PATCH] D159262: [clang][dataflow] Eliminate deprecated `ControlFlowContext::build()` overload.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D159261: [clang][dataflow] Eliminate deprecated `DataflowAnalysis` constructor.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro updated this revision to Diff 554946. ro marked an inline comment as done. ro added a comment. Move `isLinkerGnuLd` to `Solaris.{h,cpp}` and into `solaris` namespace to make it unambigously clear where to use it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85309: [Driver] Support GNU ld on Solaris

ro marked an inline comment as done. ro added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:305 +bool tools::isLinkerGnuLd(const ToolChain , const ArgList ) { + // Only used if targetting Solaris. MaskRay wrote: > I suppose that this

[PATCH] D159107: [analyzer] ArrayBoundCheckerV2 should disallow forming lvalues to out-of-bounds locations

donat.nagy added a comment. I don't think that the `[N]` issue is too serious: we can just increment the array extent when the parent expression of the array subscript operator is the unary operator `&`. If the past-the-end pointer ends up dereferenced later, the current code is sufficient to

[PATCH] D159188: [AArch64][SME] Make the overloaded svreinterpret_* functions streaming-compatible.

david-arm added inline comments. Comment at: clang/include/clang/Basic/Attr.td:418 def TargetARM : TargetArch<["arm", "thumb", "armeb", "thumbeb"]>; -def TargetAArch64 : TargetArch<["aarch64"]>; +def TargetAArch64 : TargetArch<["aarch64", "aarch64_be"]>; def TargetAnyArm :

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. Got it. Thanks for your explanation. I can continue my experiment : ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153114/new/ https://reviews.llvm.org/D153114 ___ cfe-commits mailing list

[PATCH] D159257: [Clang] Drop functions with incompatible target-features when using mlink-builtin-bitcode

jmmartinez created this revision. jmmartinez added reviewers: arsenm, Pierre-vh, yaxunl, jhuber6. Herald added a project: All. jmmartinez requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D159206: [Clang] Propagate target-features if compatible when using mlink-builtin-bitcode

jmmartinez updated this revision to Diff 554934. jmmartinez added a comment. - Rollback, drop incompatible functions in a separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159206/new/ https://reviews.llvm.org/D159206 Files:

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

sammccall added a comment. In D153114#4630318 , @ChuanqiXu wrote: > @sammccall @nridge while I am looking for the initial support for modules in > clangd, I failed to find the mechanism to update files after I update a > header file. > > e.g., when I

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi added a comment. Thanks @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158614/new/ https://reviews.llvm.org/D158614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D155858: Add a concept AST node.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2bf9baf5987: Add a concept AST node. (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c2bf9ba - Add a concept AST node.

Author: Jens Massberg Date: 2023-08-31T10:22:21+02:00 New Revision: c2bf9baf59870532d0c503066634bf438c35184f URL: https://github.com/llvm/llvm-project/commit/c2bf9baf59870532d0c503066634bf438c35184f DIFF: https://github.com/llvm/llvm-project/commit/c2bf9baf59870532d0c503066634bf438c35184f.diff

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. In D153114#4630408 , @nridge wrote: > In D153114#4630318 , @ChuanqiXu > wrote: > >> However, I can't search the caller of `reparseOpenFilesIfNeeded` which >> semantics matches the

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jmmartinez added a comment. @jhuber6 I was wondering if there is a reason you kept 3 versions of `mergeDefaultFunctionDefinitionAttributes` in https://reviews.llvm.org/D152391 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159256/new/

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

nridge added a comment. In D153114#4630318 , @ChuanqiXu wrote: > However, I can't search the caller of `reparseOpenFilesIfNeeded` which > semantics matches the behavior. The two callers of > `reparseOpenFilesIfNeeded` I found are >

[PATCH] D159256: [NFC][Clang] Remove redundant function definitions

jmmartinez created this revision. jmmartinez added a reviewer: jhuber6. Herald added a project: All. jmmartinez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There were 3 definitions of the mergeDefaultFunctionDefinitionAttributes

[PATCH] D159107: [analyzer] ArrayBoundCheckerV2 should disallow forming lvalues to out-of-bounds locations

steakhal abandoned this revision. steakhal added a comment. In D159107#4627903 , @donat.nagy wrote: > Good direction of development, this will be useful for providing better bug > reports (in addition to ensuring correct behavior some situations). >

[clang] 1968f0d - Add REQUIRES: staticanalyzer to some tests using clang -analyze

Author: Hans Wennborg Date: 2023-08-31T09:37:04+02:00 New Revision: 1968f0d7981df2d508c7c862d875b115837208b3 URL: https://github.com/llvm/llvm-project/commit/1968f0d7981df2d508c7c862d875b115837208b3 DIFF: https://github.com/llvm/llvm-project/commit/1968f0d7981df2d508c7c862d875b115837208b3.diff

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

hans added inline comments. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:10 + +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fcxx-exceptions -fexceptions %s -emit-llvm -S -verify=with -Wopenmp-target-exception -analyze +// RUN:

[PATCH] D159106: [analyzer] ArrayBoundCheckerV2 should listen to check::Bind as well

steakhal planned changes to this revision. steakhal added a comment. This patch would cause FPs on this code: struct S {}; void zero_size_array() { S arr[0]; (void)arr; } Being short on time, I'll just drop this commit from the stack and come back in a late future. This might be

[PATCH] D159247: [HLSL] Cleanup support for `this` as an l-value

cor3ntin added a comment. Thanks for working on this. This is going to conflict with deducing this (https://reviews.llvm.org/D140828) in interesting (ie, horrible) ways, so i guess I'll have to deal with that. For people following along we are trying to fix nasty lambda regression

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

ChuanqiXu added a comment. @sammccall @nridge while I am looking for the initial support for modules in clangd, I failed to find the mechanism to update files after I update a header file. e.g., when I am opening the following file: // a.cc #include "a.h" ... and there is a concurrent

[PATCH] D158266: Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 554920. koops added a comment. Using isOpenMPWorksharingDirective( ) for the "omp loop bind(parallel)" and "omp loop bind(teams)". Added extra tests in loop_bind_messages.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b40ced4e5ba: [RISCV] Add --print-supported-extensions support (authored by 4vtomat). Changed prior to commit:

[clang] 4b40ced - [RISCV] Add --print-supported-extensions support

Author: 4vtomat Date: 2023-08-31T00:24:06-07:00 New Revision: 4b40ced4e5ba10b841516b3970e7699ba8ded572 URL: https://github.com/llvm/llvm-project/commit/4b40ced4e5ba10b841516b3970e7699ba8ded572 DIFF: https://github.com/llvm/llvm-project/commit/4b40ced4e5ba10b841516b3970e7699ba8ded572.diff LOG:

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 554919. zyounan added a comment. Rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added a comment. Thanks for the review! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:26 +// Consume remaining notes/errors. +// expected-note@* 0+{{}} +// expected-error@* 0+{{}} erichkeane wrote: > Please don't do this, actually

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 554914. zyounan marked an inline comment as done. zyounan added a comment. Expand diagnostics in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files:

[PATCH] D157485: [X86][RFC] Support new feature AVX10

pengfei planned changes to this revision. pengfei added a comment. In D157485#4597603 , @e-kud wrote: > Just curious, in RFC we have `-mavx10.x-256/-mavx10.x-512` but here we refer > to `-mavx10.x/-mavx10.x,-mavx10-512bit`. Is it compliant with GCC, or

[PATCH] D130777: Enable embedded lto for XCOFF.

MaskRay added a comment. This needs rebase after fatLTO support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130777/new/ https://reviews.llvm.org/D130777 ___ cfe-commits mailing list

<    1   2   3   >