[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

2023-09-27 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/66862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/67515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread Fangrui Song via cfe-commits
@@ -401,6 +401,30 @@ // CHECK338-NOT: "--end-group" // CHECK338: "{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v60/fini.o" +// RUN: %clangxx -### -target hexagon-unknown-elf \ +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ +// RUN:

[libunwind] [libc++][lit] Allow overriding the executor for tests (PR #66545)

2023-09-27 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: [executorfix.diff.txt](https://github.com/llvm/llvm-project/files/12745676/executorfix.diff.txt) @arichardson , here is few updates for your fix (please see attached file): * added an escaping of quotes for the serialized lit parameter. There could be an executor string

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

2023-09-27 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: [executorfix.diff.txt](https://github.com/llvm/llvm-project/files/12745676/executorfix.diff.txt) @arichardson , here is few updates for your fix (please see attached file): * added an escaping of quotes for the serialized lit parameter. There could be an executor string

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread via cfe-commits
@@ -401,6 +401,30 @@ // CHECK338-NOT: "--end-group" // CHECK338: "{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v60/fini.o" +// RUN: %clangxx -### -target hexagon-unknown-elf \ +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ +// RUN:

[clang] 53a87b4 - [clang-repl] Disable LSan in clang-repl.

2023-09-27 Thread Lang Hames via cfe-commits
Author: Lang Hames Date: 2023-09-27T21:39:48-07:00 New Revision: 53a87b4a6903c0c47337ca18697bb6355cc087d4 URL: https://github.com/llvm/llvm-project/commit/53a87b4a6903c0c47337ca18697bb6355cc087d4 DIFF: https://github.com/llvm/llvm-project/commit/53a87b4a6903c0c47337ca18697bb6355cc087d4.diff

[clang] 0d8b864 - CGBuiltin: emit llvm.abs.* instead of neg+icmp+select for abs

2023-09-27 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-09-27T21:29:56-07:00 New Revision: 0d8b864829073cf6f0a40f1b257d6631fc4145d0 URL: https://github.com/llvm/llvm-project/commit/0d8b864829073cf6f0a40f1b257d6631fc4145d0 DIFF: https://github.com/llvm/llvm-project/commit/0d8b864829073cf6f0a40f1b257d6631fc4145d0.diff

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread via cfe-commits
@@ -401,6 +401,30 @@ // CHECK338-NOT: "--end-group" // CHECK338: "{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v60/fini.o" +// RUN: %clangxx -### -target hexagon-unknown-elf \ +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ +// RUN:

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread via cfe-commits
https://github.com/androm3da updated https://github.com/llvm/llvm-project/pull/67515 >From 87db8df7385b87f92f3bba2f80041e79039de78e Mon Sep 17 00:00:00 2001 From: Brian Cain Date: Wed, 27 Sep 2023 21:07:05 -0700 Subject: [PATCH 1/2] [clang][hexagon] Change driver tests to "--target="

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -757,6 +772,17 @@ getTOCEntryTypeForMO(const MachineOperand ) { llvm_unreachable("Unexpected operand type to get TOC type."); } } + +// FIXME: find alternative approach to get rid of this hack. +// On AIX, TLS-local-dynamic requires that the symbol for the module

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -370,11 +370,23 @@ namespace llvm { /// G8RC = TLSGD_AIX, TOC_ENTRY, TOC_ENTRY /// Op that combines two register copies of TOC entries /// (region handle into R3 and variable offset into R4) followed by a -/// GET_TLS_ADDR node which will be expanded to a

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -145,9 +163,88 @@ namespace { .addImm(0); if (IsAIX) { - // The variable offset and region handle are copied in r4 and r3. The - // copies are followed by

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -145,9 +163,88 @@ namespace { .addImm(0); if (IsAIX) { - // The variable offset and region handle are copied in r4 and r3. The - // copies are followed by

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -3412,13 +3416,23 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddressAIX(SDValue Op, return DAG.getNode(PPCISD::ADD_TLS, dl, PtrVT, TLSReg, VariableOffset); } - // Only Local-Exec, Initial-Exec and General-Dynamic TLS models are currently - // supported models. If

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -145,9 +163,88 @@ namespace { .addImm(0); if (IsAIX) { - // The variable offset and region handle are copied in r4 and r3. The - // copies are followed by

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -1622,6 +1629,9 @@ def TLSGDAIX8 : "#TLSGDAIX8", [(set i64:$rD, (PPCTlsgdAIX i64:$offset, i64:$handle))]>; +// This pseudo is expanded to load module-handle in X3, and the call to GETtlsMOD64AIX.

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -145,9 +163,88 @@ namespace { .addImm(0); if (IsAIX) { - // The variable offset and region handle are copied in r4 and r3. The - // copies are followed by

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -6,6 +6,6 @@ #endif static __thread int y __attribute((tls_model("global-dynamic"))); // no-warning -static __thread int y __attribute((tls_model("local-dynamic"))); // expected-error {{TLS model 'local-dynamic' is not yet supported on AIX}} +static __thread int y

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

2023-09-27 Thread Amy Kwan via cfe-commits
@@ -145,9 +163,88 @@ namespace { .addImm(0); if (IsAIX) { - // The variable offset and region handle are copied in r4 and r3. The - // copies are followed by

[clang] [RISCV][NFC] Move some common class/multiclass from riscv_vector.td to riscv_vector_common.td (PR #67587)

2023-09-27 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/67587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 11819a1 - [RISCV][NFC] Move some common class/multiclass from riscv_vector.td to riscv_vector_common.td (#67587)

2023-09-27 Thread via cfe-commits
Author: Brandon Wu Date: 2023-09-28T11:25:53+08:00 New Revision: 11819a1031fc67ef216de380a918dc5f33646fc4 URL: https://github.com/llvm/llvm-project/commit/11819a1031fc67ef216de380a918dc5f33646fc4 DIFF: https://github.com/llvm/llvm-project/commit/11819a1031fc67ef216de380a918dc5f33646fc4.diff

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

2023-09-27 Thread Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG315a407086b0: [Basic] Support 64-bit x86 target for UEFI (authored by prabhukr prabh...@google.com). Repository: rG LLVM Github Monorepo CHANGES

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-27 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: >edit: hopefully good after >https://github.com/llvm/llvm-project/commit/5aa3338930d15a59dd6ddbd36fc09ffa6610ca72 the test has been passed locally on the builder with this commit. Thank you for the fix. https://github.com/llvm/llvm-project/pull/66947

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-27 Thread via cfe-commits
https://github.com/goldsteinn edited https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-27 Thread via cfe-commits
goldsteinn wrote: Okay, rebased ontop of your vec support patches + added vec support/tests. https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

2023-09-27 Thread via cfe-commits
goldsteinn wrote: Okay, rebased ontop of your vec support patches + added vec support/tests. https://github.com/llvm/llvm-project/pull/65910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] f9558c6 - [C++20] [Modules] Handle import decl before module declaration without being in GMF

2023-09-27 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2023-09-28T10:24:50+08:00 New Revision: f9558c691128cbc1660f69bd3b5f547be90ed18b URL: https://github.com/llvm/llvm-project/commit/f9558c691128cbc1660f69bd3b5f547be90ed18b DIFF: https://github.com/llvm/llvm-project/commit/f9558c691128cbc1660f69bd3b5f547be90ed18b.diff

[clang] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

2023-09-27 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67514 >From e2e0e10e13748ba9369b73c7547c035ee75dfffa Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Tue, 26 Sep 2023 18:55:44 -0700 Subject: [PATCH] [Clang] Fix crash when visting a fold expression in a default

[clang] [Driver] Support -fsanitize=cfi-icall on loongarch64 (PR #67310)

2023-09-27 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Support -fsanitize=cfi-icall on loongarch64 (PR #67310)

2023-09-27 Thread via cfe-commits
Ami-zhang wrote: @MaskRay @xen0n Could you please review this PR and provide your feedback? Thank you! https://github.com/llvm/llvm-project/pull/67310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CodeGenPrepare] Transform ldexp into target supported intrinsics (PR #67552)

2023-09-27 Thread via cfe-commits
huhu233 wrote: > Why does this need special handling in CGP instead of being a normal custom > lowering for FLDEXP? @nikic , thanks for your suggestion, I'll update the patch as soon! https://github.com/llvm/llvm-project/pull/67552 ___ cfe-commits

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

2023-09-27 Thread H. Vetinari via Phabricator via cfe-commits
h-vetinari added a comment. Any update on this patchset? With the migration away from phabricator, it'd be good to get this in soonish (otherwise it'll need to be moved to github). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/

[clang] [CodeGenPrepare] Transform ldexp into target supported intrinsics (PR #67552)

2023-09-27 Thread via cfe-commits
huhu233 wrote: > I agree and custom lowering also gives a straight forward way to support > vectors types as well. You are right, I'll update the patch as soon, thanks! https://github.com/llvm/llvm-project/pull/67552 ___ cfe-commits mailing list

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

2023-09-27 Thread Anton Korobeynikov via cfe-commits
asl wrote: @sam-mccall As far as I can see, the bot was green before this change: https://lab.llvm.org/buildbot/#/builders/119/builds/15229 Have you not received email from the buildbot? https://github.com/llvm/llvm-project/pull/66947 ___

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -7304,6 +7382,21 @@ class BufferToAPValueConverter { return ArrayValue; } + std::optional visit(const VectorType *Ty, CharUnits Offset) { +SmallVector Bytes; +if (!Buffer.readObject(Offset, Info.Ctx.getTypeSizeInChars(Ty), Bytes)) + return std::nullopt;

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -2732,6 +2732,92 @@ static bool truncateBitfieldValue(EvalInfo , const Expr *E, return true; } +static bool BitcastAPIntToVector(EvalInfo , const VectorType *VTy, + const llvm::APInt , + SmallVectorImpl ) {

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -2732,6 +2732,92 @@ static bool truncateBitfieldValue(EvalInfo , const Expr *E, return true; } +static bool BitcastAPIntToVector(EvalInfo , const VectorType *VTy, + const llvm::APInt , + SmallVectorImpl ) {

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -7095,6 +7157,22 @@ class APValueToBufferConverter { return true; } + bool visitVector(const APValue , QualType Ty, CharUnits Offset) { +const VectorType *VTy = Ty->castAs(); + +APInt Bits; +if (!BitcastVectorToAPInt(Info, VTy, Val, Bits)) + return

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -2732,6 +2732,92 @@ static bool truncateBitfieldValue(EvalInfo , const Expr *E, return true; } +static bool BitcastAPIntToVector(EvalInfo , const VectorType *VTy, + const llvm::APInt , + SmallVectorImpl ) {

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -7304,6 +7382,21 @@ class BufferToAPValueConverter { return ArrayValue; } + std::optional visit(const VectorType *Ty, CharUnits Offset) { +SmallVector Bytes; +if (!Buffer.readObject(Offset, Info.Ctx.getTypeSizeInChars(Ty), Bytes)) + return std::nullopt;

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -2732,6 +2732,92 @@ static bool truncateBitfieldValue(EvalInfo , const Expr *E, return true; } +static bool BitcastAPIntToVector(EvalInfo , const VectorType *VTy, + const llvm::APInt , + SmallVectorImpl ) {

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid commented: Thanks, I like the code reuse! There are some minor optimization and simplification opportunities in the code you're reusing that might be worth addressing now. I'm worried that vectors with padding (which I think is only vectors of x86 `long double`)

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid edited https://github.com/llvm/llvm-project/pull/66894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 22433cc - [Driver][test] Fix hexagon-toolchain-elf.c

2023-09-27 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-09-27T16:55:58-07:00 New Revision: 22433cc541ff706d9e845774ef1c8c959dc67799 URL: https://github.com/llvm/llvm-project/commit/22433cc541ff706d9e845774ef1c8c959dc67799 DIFF: https://github.com/llvm/llvm-project/commit/22433cc541ff706d9e845774ef1c8c959dc67799.diff

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-09-27 Thread Matt Harding via cfe-commits
https://github.com/majaha edited https://github.com/llvm/llvm-project/pull/65876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-09-27 Thread Matt Harding via cfe-commits
@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -;

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-09-27 Thread Matt Harding via cfe-commits
@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -;

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-09-27 Thread Heejin Ahn via cfe-commits
aheejin wrote: > Yeah you've got it, that's the main point. It can be set via the C++ API, and > when I tried doing so in the Rust compiler I found it broke the WebAssembly > backend. Sorry if I didn't make that clear enough earlier, I'm glad we're on > the same page now. The other points I

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread Shafik Yaghmour via cfe-commits
shafik wrote: I wonder does this also fix this: https://github.com/llvm/llvm-project/issues/67058 https://github.com/llvm/llvm-project/pull/67538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [mlir][sparse] Change tests to use new syntax for ELL and slice (PR #67569)

2023-09-27 Thread Yinying Li via cfe-commits
https://github.com/yinying-lisa-li closed https://github.com/llvm/llvm-project/pull/67569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Michael Spencer via cfe-commits
@@ -0,0 +1,267 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

2023-09-27 Thread Matt Harding via cfe-commits
@@ -1,33 +1,133 @@ -; RUN: llc < %s -asm-verbose=false -verify-machineinstrs | FileCheck %s -; RUN: llc < %s -asm-verbose=false -fast-isel -fast-isel-abort=1 -verify-machineinstrs | FileCheck %s - -; Test that LLVM unreachable instruction and trap intrinsic are lowered to -;

[clang] [clang-format] Don't align ctors and dtors with other functions (PR #67618)

2023-09-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Changes Fixed #67604. --- Full diff: https://github.com/llvm/llvm-project/pull/67618.diff 2 Files Affected: - (modified) clang/lib/Format/WhitespaceManager.cpp (+5-1) - (modified) clang/unittests/Format/FormatTest.cpp (+12)

[clang] [clang-format] Don't align ctors and dtors with other functions (PR #67618)

2023-09-27 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67618 Fixed #67604. >From dfa92b41b74e554157467ea51f5db9dfcec4fcce Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 27 Sep 2023 16:06:48 -0700 Subject: [PATCH] [clang-format] Don't align ctors and dtors with other

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread David Li via cfe-commits
@@ -1048,27 +1052,29 @@ class FunctionSamples { }; if (isDeclaration(SymbolMap.lookup(getFuncName( { // Add to the import list only when it's defined out of module. - S.insert(getGUID(getName())); + S.insert(getGUID()); } // Import hot

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread David Li via cfe-commits
@@ -1048,27 +1052,29 @@ class FunctionSamples { }; if (isDeclaration(SymbolMap.lookup(getFuncName( { // Add to the import list only when it's defined out of module. - S.insert(getGUID(getName())); + S.insert(getGUID()); } // Import hot

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added subscribers: sammccall, dblaikie. dblaikie added a comment. @sammccall @rsmith - figure if this does impact us, we'll use the flag to opt-out in the short term while we figure out longer-term solution, yeah? Is there any pre-emptive testing you think is worth doing? Repository:

[clang] [RISCV][GISel] Select G_SELECT (PR #67614)

2023-09-27 Thread Michael Maitland via cfe-commits
@@ -239,6 +245,11 @@ bool RISCVInstructionSelector::select(MachineInstr ) { } case TargetOpcode::G_SEXT_INREG: return selectSExtInreg(MI, MIB); + case TargetOpcode::G_SELECT: +if (!selectSelect(MI, MIB, MRI)) + return false; +MI.eraseFromParent();

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
WenleiHe wrote: > When testing on an internal large profile (> 1 GB, with more than 10 million > functions), the full profile load time is reduced from 28 sec to 25 sec in > average, and reading function offset table from 0.78s to 0.7s What is the E2E compile time change for the case you

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
WenleiHe wrote: > When testing on an internal large profile (> 1 GB, with more than 10 million > functions), the full profile load time is reduced from 28 sec to 25 sec in > average, and reading function offset table from 0.78s to 0.7s What is the E2E compile time change for the case you

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -1048,27 +1052,29 @@ class FunctionSamples { }; if (isDeclaration(SymbolMap.lookup(getFuncName( { // Add to the import list only when it's defined out of module. - S.insert(getGUID(getName())); + S.insert(getGUID()); } // Import hot

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -85,7 +86,7 @@ class ProfiledCallGraph { std::queue Queue; for (auto : ContextTracker.getRootContext().getAllChildContext()) { ContextTrieNode *Callee = - addProfiledFunction(ContextTracker.getFuncNameFor(Callee)); +

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -1048,27 +1052,29 @@ class FunctionSamples { }; if (isDeclaration(SymbolMap.lookup(getFuncName( { // Add to the import list only when it's defined out of module. - S.insert(getGUID(getName())); + S.insert(getGUID()); } // Import hot

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -836,7 +840,7 @@ std::error_code SampleProfileWriterBinary::writeBody(const FunctionSamples ) { encodeULEB128(Sample.getSamples(), OS); encodeULEB128(Sample.getCallTargets().size(), OS); for (const auto : Sample.getSortedCallTargets()) { - StringRef

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -0,0 +1,222 @@ +//===--- ProfileFuncRef.h - Sample profile function name ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

2023-09-27 Thread via cfe-commits
@@ -305,6 +304,10 @@ struct LineLocation { return LineOffset != O.LineOffset || Discriminator != O.Discriminator; } + uint64_t getHashCode() const { WenleiHe wrote: LineLocationHash should reuse getHashCode to avoid future divergence.

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-27 Thread Amy Huang via cfe-commits
https://github.com/amykhuang edited https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-27 Thread Amy Huang via cfe-commits
amykhuang wrote: Added a section for target specific spellings in `GenerateHasAttrSpellingStringSwitch`, and a check for "existsInTarget" in `ParseCXX11AttributeArgs`, and looks like all tests are passing now. https://github.com/llvm/llvm-project/pull/67199

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

2023-09-27 Thread Alexander Richardson via cfe-commits
arichardson wrote: > @arichardson > > here is a problem with your changes when building the libraries on the > windows cross toolchain builders > > * https://lab.llvm.org/buildbot/#/builders/60/builds/14086 > * https://lab.llvm.org/buildbot/#/builders/119/builds/15283 > >

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

2023-09-27 Thread Amy Huang via cfe-commits
https://github.com/amykhuang updated https://github.com/llvm/llvm-project/pull/67199 >From b1f0feeaed93edfdd692858e9d63ab6bbb94c0a5 Mon Sep 17 00:00:00 2001 From: Amy Huang Date: Fri, 22 Sep 2023 14:40:14 -0700 Subject: [PATCH 1/3] Recommit "Implement [[msvc::no_unique_address]] (#65675)"

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-27 Thread Emilia Kond via cfe-commits
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3e87829 - [clang-format] Fix requires misannotation with comma (#65908)

2023-09-27 Thread via cfe-commits
Author: Emilia Kond Date: 2023-09-28T01:34:30+03:00 New Revision: 3e87829a8a9ab6a5f62078c590eec09f5024f95f URL: https://github.com/llvm/llvm-project/commit/3e87829a8a9ab6a5f62078c590eec09f5024f95f DIFF: https://github.com/llvm/llvm-project/commit/3e87829a8a9ab6a5f62078c590eec09f5024f95f.diff

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-27 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-27 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-27 Thread via cfe-commits
https://github.com/mydeveloperday resolved https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-27 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/66755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support target names with dots in more utilities (PR #65812)

2023-09-27 Thread via cfe-commits
@@ -1696,6 +1696,40 @@ TEST(Support, ReplacePathPrefix) { EXPECT_EQ(Path, "C:\\old/foo\\bar"); } +TEST(Support, FindProgramName) { + StringRef WindowsProgName = + path::program_name("C:\\Test\\foo.exe", path::Style::windows); + EXPECT_EQ(WindowsProgName, "foo"); + +

[clang] [clang-format] Handle __attribute/__declspec/AttributeMacro consistently (PR #67518)

2023-09-27 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/67518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 63544af - [Driver][test] Clean up hexagon-*

2023-09-27 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-09-27T15:24:44-07:00 New Revision: 63544af9e4197650b725dcc80152a8c2cde1cdbd URL: https://github.com/llvm/llvm-project/commit/63544af9e4197650b725dcc80152a8c2cde1cdbd DIFF: https://github.com/llvm/llvm-project/commit/63544af9e4197650b725dcc80152a8c2cde1cdbd.diff

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

2023-09-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8ff77a8f04e5a385115c1790a5f03ec263a00faf 0f63068d1085e5064d47916a86fac089c4417e57 --

[clang] [RISCV][NFC] Move some common class/multiclass from riscv_vector.td to riscv_vector_common.td (PR #67587)

2023-09-27 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

2023-09-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes Also add the filename to the comments it emits, to help identify where included text ends. --- Patch is 25.05 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/67613.diff 5 Files

[clang] Make -frewrite-includes put an endif at the end of the included text (PR #67613)

2023-09-27 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/67613 Also add the filename to the comments it emits, to help identify where included text ends. >From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Wed, 27 Sep 2023

[clang-tools-extra] [ORC] Unify symbol mapping logic to IRLayer (PR #67612)

2023-09-27 Thread Lucas Reis via cfe-commits
https://github.com/lucasreis1 created https://github.com/llvm/llvm-project/pull/67612 Remove the old `IRSymbolMapper` and unify symbol mapping logic to IRLayer. Allows clients to provide their own version of a `IRSymbolMapper` function for custom mappings. This is my first contribution, so

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread Fangrui Song via cfe-commits
@@ -401,6 +401,30 @@ // CHECK338-NOT: "--end-group" // CHECK338: "{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v60/fini.o" +// RUN: %clangxx -### -target hexagon-unknown-elf \ +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ +// RUN:

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread Fangrui Song via cfe-commits
@@ -401,6 +401,30 @@ // CHECK338-NOT: "--end-group" // CHECK338: "{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v60/fini.o" +// RUN: %clangxx -### -target hexagon-unknown-elf \ +// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ +// RUN:

[clang] [clang][hexagon] Add support for -nolibc (PR #67515)

2023-09-27 Thread Fangrui Song via cfe-commits
@@ -401,6 +401,30 @@ // CHECK338-NOT: "--end-group" // CHECK338: "{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v60/fini.o" +// RUN: %clangxx -### -target hexagon-unknown-elf \ MaskRay wrote: use `--target=` for new tests. `-target ` has been

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-09-27 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav updated this revision to Diff 557427. chaitanyav added a comment. Add parentheses to the conditional expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files:

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

2023-09-27 Thread Shilei Tian via cfe-commits
shiltian wrote: > Where is the code that prevents the init/deinit calls from being created? It's in the early exit. https://github.com/llvm/llvm-project/pull/66844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

2023-09-27 Thread Shilei Tian via cfe-commits
@@ -752,27 +751,41 @@ void CGOpenMPRuntimeGPU::emitNonSPMDKernel(const OMPExecutableDirective , EntryFunctionState EST; WrapperFunctionsMap.clear(); + bool IsBareKernel = D.getSingleClause(); shiltian wrote: So `target teams` is generic mode. Since we

  1   2   3   4   5   6   >