[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
@@ -49,7 +49,7 @@ struct ExprDependenceScope { using ExprDependence = ExprDependenceScope::ExprDependence; struct TypeDependenceScope { - enum TypeDependence : uint8_t { + enum TypeDependence : unsigned { Endilll wrote: In this particular case, width of

[clang] [RISCV] Support Xsfvfwmaccqqq extensions (PR #68296)

2023-10-26 Thread Craig Topper via cfe-commits
@@ -991,6 +992,7 @@ static const char *ImpliedExtsF[] = {"zicsr"}; static const char *ImpliedExtsV[] = {"zvl128b", "zve64d"}; static const char *ImpliedExtsXTHeadVdot[] = {"v"}; static const char *ImpliedExtsXsfvcp[] = {"zve32x"}; +static const char *ImpliedExtsXsfvfwmaccqqq[]

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/70349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
@@ -49,7 +49,7 @@ struct ExprDependenceScope { using ExprDependence = ExprDependenceScope::ExprDependence; struct TypeDependenceScope { - enum TypeDependence : uint8_t { + enum TypeDependence : unsigned { Endilll wrote: The only place this enum is stored

[clang] [RISCV] Support Xsfvfwmaccqqq extensions (PR #68296)

2023-10-26 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/68296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support Xsfvfwmaccqqq extensions (PR #68296)

2023-10-26 Thread Craig Topper via cfe-commits
@@ -813,6 +813,14 @@ def HasVendorXSfcie : Predicate<"Subtarget->hasVendorXSfcie()">, AssemblerPredicate<(all_of FeatureVendorXSfcie), "'XSfcie' (SiFive Custom Instruction Extension SCIE.)">; +def FeatureVendorXSfvfwmaccqqq +

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-26 Thread Petr Hosek via cfe-commits
petrhosek wrote: We have noticed that after this change, `clang-format` would behave differently depending on the input formatting. (I'm using `--style="{BasedOnStyle: google, ColumnLimit: 0}"` in the examples below.) For example, if the input is ``` return os << "ClientEnd<" <<

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread via cfe-commits
@@ -49,7 +49,7 @@ struct ExprDependenceScope { using ExprDependence = ExprDependenceScope::ExprDependence; struct TypeDependenceScope { - enum TypeDependence : uint8_t { + enum TypeDependence : unsigned { cor3ntin wrote: Can you explain this change? Making

[clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-10-26 Thread via cfe-commits
@@ -20,7 +20,7 @@ namespace clang { /// Describes the different kinds of linkage /// (C++ [basic.link], C99 6.2.2) that an entity may have. -enum Linkage : unsigned char { +enum Linkage : unsigned { cor3ntin wrote: can you explain this change?

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-10-26 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support Xsfvfnrclipxfqf extensions (PR #68297)

2023-10-26 Thread Brandon Wu via cfe-commits
4vtomat wrote: ping https://github.com/llvm/llvm-project/pull/68297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support Xsfvfwmaccqqq extensions (PR #68296)

2023-10-26 Thread Brandon Wu via cfe-commits
4vtomat wrote: ping https://github.com/llvm/llvm-project/pull/68296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

2023-10-26 Thread Brandon Wu via cfe-commits
4vtomat wrote: ping https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-26 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/70316 >From 41278ca046ae5d4be4ac4ac1bc673b5010668d9c Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 26 Oct 2023 18:54:05 +0800 Subject: [PATCH 1/2] [clang-tidy]Fix PreferMemberInitializer false positive

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-26 Thread via cfe-commits
serge-sans-paille wrote: Updated compile time metrics: https://llvm-compile-time-tracker.com/compare.php?from=f9906508bc4f05d3950e2219b4c56f6c078a61ef=2631a5163de552a8e482f5cbc51525fb8bb5082f=instructions:u https://github.com/llvm/llvm-project/pull/70381

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: [Mozilla](https://firefox-source-docs.mozilla.org/code-quality/coding-style/coding_style_cpp.html), [WebKit](https://webkit.org/code-style-guidelines/), [GCC](https://gcc.gnu.org/codingconventions.html#Cxx_Conventions),

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Wang Pengcheng via cfe-commits
wangpc-pp wrote: Xiangshan is of great famousness in China and there is already a community in which many individual developers and organiztions/companies like PLCT, T-Head have participated. So I think we needn't worry about the maintenance. :-)

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-26 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Thanks for the heads up. I'll request backporting in a few hours when buildbots finish running tests. https://github.com/llvm/llvm-project/pull/67817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: Thanks. Don't forget to trigger a backport to clang 17 https://github.com/llvm/llvm-project/pull/67817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Fix complexity guarantee in std::clamp (PR #68413)

2023-10-26 Thread via cfe-commits
@@ -37,9 +37,10 @@ struct __fn { _LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj, __high), std::invoke(__proj, __low))), "Bad bounds passed to std::ranges::clamp"); -if (std::invoke(__comp,

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-26 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/67817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b88a9f9 - [clang][ExprConst] Fix crash on uninitialized array subobject (#67817)

2023-10-26 Thread via cfe-commits
Author: Takuya Shimizu Date: 2023-10-27T14:11:27+09:00 New Revision: b88a9f9670bb71e1eadeea76b16be6b953714883 URL: https://github.com/llvm/llvm-project/commit/b88a9f9670bb71e1eadeea76b16be6b953714883 DIFF:

[clang-tools-extra] [clang-tidy]Fix PreferMemberInitializer false positive for reassignment (PR #70316)

2023-10-26 Thread Congcong Cai via cfe-commits
@@ -570,3 +570,19 @@ struct PR52818 { int bar; }; + +struct RefReassignment { + RefReassignment(int ) : m_i{i} { +m_i = 1; + } + int & m_i; +}; + +struct ReassignmentAfterUnsafetyAssignment { + ReassignmentAfterUnsafetyAssignment() { +int a = 10; +m_i =

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-26 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/67817 >From 7f4db6d81f24adb72416e79bde65a1a13d9a82b8 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Fri, 29 Sep 2023 23:49:11 +0900 Subject: [PATCH 1/4] [clang][ExprConst] Fix crash on uninitialized array

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Mark declarators invalid in the presence of ill-formed explicit parameters. (PR #70018)

2023-10-26 Thread Shafik Yaghmour via cfe-commits
@@ -542,3 +542,46 @@ void foo(C c) { } } + + +namespace GH69838 { +struct S { + S(this auto ) {} // expected-error {{an explicit object parameter cannot appear in a constructor}} + virtual void f(this S self) {} // expected-error {{an explicit object parameter cannot

[clang] 88934a8 - [clang-format][NFC] Remove extraneous newlines in some unit test files

2023-10-26 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-26T21:43:27-07:00 New Revision: 88934a82dced0116227e4ad9af8896d8fa0943b8 URL: https://github.com/llvm/llvm-project/commit/88934a82dced0116227e4ad9af8896d8fa0943b8 DIFF: https://github.com/llvm/llvm-project/commit/88934a82dced0116227e4ad9af8896d8fa0943b8.diff

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Alex Bradbury via cfe-commits
asb wrote: > > @dtcxzyw Could you please confirm the status of this core - is it > > commercially available, an academic test chip, something else? > > It's maintained by Beijing Institute of Open Source Chip (BOSC), a non-profit > organziation founded by companies and researech institutions.

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-26 Thread Fangrui Song via cfe-commits
@@ -96,13 +97,39 @@ bool MultilibSet::select(const Multilib::flags_list , llvm::SmallVector ) const { llvm::StringSet<> FlagSet(expandFlags(Flags)); Selected.clear(); - llvm::copy_if(Multilibs, std::back_inserter(Selected), -

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-26 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,69 @@ +# REQUIRES: shell +# UNSUPPORTED: system-windows + +# RUN: rm -rf %t + +# RUN: mkdir -p %t/baremetal_multilib/bin +# RUN: ln -s %clang %t/baremetal_multilib/bin/clang + +# RUN: mkdir -p %t/baremetal_multilib/lib/clang-runtimes +# RUN: ln -s %s

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-26 Thread Fangrui Song via cfe-commits
@@ -152,6 +180,7 @@ template <> struct llvm::yaml::MappingTraits { static void mapping(llvm::yaml::IO , MultilibSerialization ) { io.mapRequired("Dir", V.Dir); io.mapRequired("Flags", V.Flags); +io.mapOptional("ExclusiveGroup", V.ExclusiveGroup);

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-26 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,69 @@ +# REQUIRES: shell +# UNSUPPORTED: system-windows + +# RUN: rm -rf %t + +# RUN: mkdir -p %t/baremetal_multilib/bin +# RUN: ln -s %clang %t/baremetal_multilib/bin/clang + +# RUN: mkdir -p %t/baremetal_multilib/lib/clang-runtimes +# RUN: ln -s %s

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-26 Thread Fangrui Song via cfe-commits
@@ -96,13 +97,39 @@ bool MultilibSet::select(const Multilib::flags_list , llvm::SmallVector ) const { llvm::StringSet<> FlagSet(expandFlags(Flags)); Selected.clear(); - llvm::copy_if(Multilibs, std::back_inserter(Selected), -

[clang] [Driver][Solaris][NFC] A little bit of clean up (PR #69867)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/69867 >From 9896afcd836cc87a051dd486034c395eda8493eb Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 22 Oct 2023 00:55:07 -0400 Subject: [PATCH] [Driver][Solaris][NFC] A little bit of clean up ---

[clang] [Driver][Solaris][NFC] A little bit of clean up (PR #69867)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/69867 >From 9530591f803a41e7d582c897477ec98fb39411e8 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 22 Oct 2023 00:55:07 -0400 Subject: [PATCH] [Driver][Solaris][NFC] A little bit of clean up ---

[clang] [Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types (PR #70355)

2023-10-26 Thread Wang Pengcheng via cfe-commits
@@ -345,6 +345,54 @@ class VString { !eq(nf, 8): !if(signed, "", "UvUvUvUvUvUvUvUv")); } + +class FixedVString { + string V = "(LFixedLog2LMUL:" # fixed_lmul # ")" # !if(signed, "v", "Uv"); + string S = !cond(!eq(num, 1): V, +

[clang] [Clang][RISCV] Add vcreate intrinsics for RVV non-tuple types (PR #70355)

2023-10-26 Thread Wang Pengcheng via cfe-commits
@@ -345,6 +345,54 @@ class VString { !eq(nf, 8): !if(signed, "", "UvUvUvUvUvUvUvUv")); } + +class FixedVString { + string V = "(LFixedLog2LMUL:" # fixed_lmul # ")" # !if(signed, "v", "Uv"); + string S = !cond(!eq(num, 1): V, +

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
@@ -78,7 +78,11 @@ static int GetCpuId(void) { // will seg fault as the address of __vdso_getcpu will be null. if (!memprof_inited) return -1; +#if SANITIZER_APPLE + return 0; teresajohnson wrote: If there is a way to do this on Apple then add a

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
@@ -0,0 +1,83 @@ +// UNSUPPORTED: ios + +// RUN: %clangxx_memprof -O0 %s -o %t +// RUN: %env_memprof_opts=print_binary_refs=true:print_text=true:log_path=stdout:verbosity=2 %run %t &> %t.log +// RUN: llvm-nm %t &> %t2.log +// RUN: cat %t2.log %t.log | FileCheck %s + +#include

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
@@ -747,8 +749,10 @@ endif() if (OS_NAME MATCHES "Linux|FreeBSD|Windows|NetBSD|SunOS") set(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME TRUE) + set(COMPILER_RT_MEMPROF_HAS_STATIC_RUNTIME TRUE) else() set(COMPILER_RT_ASAN_HAS_STATIC_RUNTIME FALSE) +

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
@@ -279,13 +286,54 @@ struct Allocator { Print(Value->mib, Key, bool(Arg)); } + using SegmentEntry = ::llvm::memprof::SegmentEntry; void FinishAndWrite() { if (print_text && common_flags()->print_module_map) DumpProcessMap();

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
@@ -0,0 +1,83 @@ +// UNSUPPORTED: ios + +// RUN: %clangxx_memprof -O0 %s -o %t +// RUN: %env_memprof_opts=print_binary_refs=true:print_text=true:log_path=stdout:verbosity=2 %run %t &> %t.log +// RUN: llvm-nm %t &> %t2.log +// RUN: cat %t2.log %t.log | FileCheck %s + +#include

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
@@ -63,6 +57,23 @@ struct AP64 { // Allocator64 parameters. Deliberately using a short name. template using PrimaryAllocatorASVT = SizeClassAllocator64>; using PrimaryAllocator = PrimaryAllocatorASVT; +#endif teresajohnson wrote: Combine these 2 lines into

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
@@ -43,6 +43,7 @@ enum class align_val_t : size_t {}; ReportOutOfMemory(size, ); \ return res; +#if !SANITIZER_APPLE teresajohnson wrote: How do operator new and delete get intercepted on Apple? Also, are

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
@@ -279,13 +286,54 @@ struct Allocator { Print(Value->mib, Key, bool(Arg)); } + using SegmentEntry = ::llvm::memprof::SegmentEntry; void FinishAndWrite() { if (print_text && common_flags()->print_module_map) DumpProcessMap();

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
https://github.com/teresajohnson commented: Thanks for sending the patch! I took an initial look through and have some comments/questions. @snehasish may also be interested in taking a look. https://github.com/llvm/llvm-project/pull/69640 ___

[clang] Support MemProf on darwin (PR #69640)

2023-10-26 Thread Teresa Johnson via cfe-commits
https://github.com/teresajohnson edited https://github.com/llvm/llvm-project/pull/69640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Fix std::is_invocable (PR #70369)

2023-10-26 Thread Yaxun Liu via cfe-commits
@@ -283,12 +283,18 @@ set(cuda_wrapper_files cuda_wrappers/cmath cuda_wrappers/complex cuda_wrappers/new + cuda_wrappers/type_traits ) set(cuda_wrapper_bits_files cuda_wrappers/bits/shared_ptr_base.h cuda_wrappers/bits/basic_string.h

[clang] [Driver][Solaris][NFC] A little bit of clean up (PR #69867)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/69867 >From 813cdfc23027f3b5494115653b458bc1df3ee2f2 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 22 Oct 2023 00:55:07 -0400 Subject: [PATCH] [Driver][Solaris][NFC] A little bit of clean up ---

[clang] [Driver][NFC] Make use of auto (PR #70400)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/70400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3ea0022 - [Driver][NFC] Make use of auto (#70400)

2023-10-26 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-26T22:30:14-04:00 New Revision: 3ea0022bef046d60b0caf477c6a460a5650e325e URL: https://github.com/llvm/llvm-project/commit/3ea0022bef046d60b0caf477c6a460a5650e325e DIFF: https://github.com/llvm/llvm-project/commit/3ea0022bef046d60b0caf477c6a460a5650e325e.diff

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/70294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Fangrui Song via cfe-commits
@@ -20,6 +20,17 @@ // MCPU-SYNTACORE-SCR1-MAX: "-target-feature" "+zicsr" "-target-feature" "+zifencei" // MCPU-SYNTACORE-SCR1-MAX: "-target-abi" "ilp32" +// RUN: %clang --target=riscv64 -### -c %s 2>&1 -mcpu=xiangshan-nanhu | FileCheck -check-prefix=MCPU-XIANGSHAN-NANHU %s

[clang] [RISCV] Add processor definition for XiangShan-NanHu (PR #70294)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/70294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on FreeBSD, NetBSD, OpenBSD, DragonFly and Haiku (PR #69817)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. LGTM, but [banach-space](https://github.com/banach-space) should check as well. https://github.com/llvm/llvm-project/pull/69817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver][NFC] Make use of auto (PR #70400)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/70400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-scan-deps] [P1689] Keep consistent behavior for make dependencies with clang (PR #69551)

2023-10-26 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @benlangmuir ping~ https://github.com/llvm/llvm-project/pull/69551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bfi precision (PR #66285)

2023-10-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: FYI @ldionne This patch causing test_vector2.pass.cpp trigger memory leak https://lab.llvm.org/buildbot/#/builders/168/builds/16422 Not sure if this was leaking but lsan didn't see, it's possible. Or some regression in lsan. https://github.com/llvm/llvm-project/pull/66285

[clang] [OpenMP] Unify the min/max thread/teams pathways (PR #70273)

2023-10-26 Thread Shilei Tian via cfe-commits
@@ -1,68 +1,20 @@ -// RUN: %clang_cc1 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple powerpc64le-unknown-unknown -emit-llvm %s -o - | FileCheck -allow-deprecated-dag-overlap %s -check-prefix=CHECK1 -// RUN: %clang_cc1 -fopenmp

[clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-openmp Author: Johannes Doerfert (jdoerfert) Changes [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument The KernelEnvironment is for compile time information about a kernel. It allows the compiler to feed

[clang-tools-extra] [clangd] Support `-specs` arguments when querying the driver. (PR #70285)

2023-10-26 Thread Chris Carlon via cfe-commits
https://github.com/cjc25 updated https://github.com/llvm/llvm-project/pull/70285 >From f171053854f3926641ecc450e35a625b5850a4be Mon Sep 17 00:00:00 2001 From: Chris Carlon Date: Tue, 24 Oct 2023 22:21:59 -0400 Subject: [PATCH 1/2] [clangd] Support `-specs` arguments when querying the driver.

[clang] [AArch64] Stack probing for function prologues (PR #66524)

2023-10-26 Thread Oskar Wirga via cfe-commits
@@ -9460,6 +9461,94 @@ bool AArch64InstrInfo::isReallyTriviallyReMaterializable( return TargetInstrInfo::isReallyTriviallyReMaterializable(MI); } +MachineBasicBlock::iterator +AArch64InstrInfo::insertStackProbingLoop(MachineBasicBlock::iterator MBBI, +

[clang] [Driver][NFC] Make use of auto (PR #70400)

2023-10-26 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/70400 None >From d0429f2f1e9cacaa5c9d9997b9cb1f60aed6bd8b Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 26 Oct 2023 19:50:37 -0400 Subject: [PATCH] [Driver][NFC] Make use of auto ---

[clang] [CUDA][HIP] Fix std::is_invocable (PR #70369)

2023-10-26 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu edited https://github.com/llvm/llvm-project/pull/70369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] Fix std::is_invocable (PR #70369)

2023-10-26 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/70369 >From 8199b47f5b84c6bdac9ab373a4e138ad9246d033 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 26 Oct 2023 15:09:49 -0400 Subject: [PATCH 1/2] [CUDA][HIP] Fix std::is_invocable Currently

[clang] [CUDA][HIP] Fix std::is_invocable (PR #70369)

2023-10-26 Thread Yaxun Liu via cfe-commits
@@ -283,12 +283,18 @@ set(cuda_wrapper_files cuda_wrappers/cmath cuda_wrappers/complex cuda_wrappers/new + cuda_wrappers/type_traits ) set(cuda_wrapper_bits_files cuda_wrappers/bits/shared_ptr_base.h cuda_wrappers/bits/basic_string.h

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

2023-10-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Change LLVM style to BreakAfterAttributes == ABS_Leave (PR #70360)

2023-10-26 Thread Owen Pan via cfe-commits
owenca wrote: This would change the default for every other predefined style, which might be ok if there's no mention of breaking after C++11 attributes in those styles. https://github.com/llvm/llvm-project/pull/70360 ___ cfe-commits mailing list

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

2023-10-26 Thread Fabian Mora via cfe-commits
https://github.com/fabianmcg approved this pull request. https://github.com/llvm/llvm-project/pull/69949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-26 Thread James E T Smith via cfe-commits
https://github.com/jamesETsmith edited https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-26 Thread James E T Smith via cfe-commits
https://github.com/jamesETsmith updated https://github.com/llvm/llvm-project/pull/68494 >From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001 From: James Smith Date: Thu, 28 Sep 2023 10:11:15 -0400 Subject: [PATCH 01/10] [libc++] Implement ranges::iota and

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-26 Thread James E T Smith via cfe-commits
https://github.com/jamesETsmith edited https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-26 Thread James E T Smith via cfe-commits
https://github.com/jamesETsmith updated https://github.com/llvm/llvm-project/pull/68494 >From c4a3ccfbad090ad8314aa8ad53092edc8d5432bc Mon Sep 17 00:00:00 2001 From: James Smith Date: Thu, 28 Sep 2023 10:11:15 -0400 Subject: [PATCH 01/10] [libc++] Implement ranges::iota and

[clang] [CUDA][HIP] Fix std::is_invocable (PR #70369)

2023-10-26 Thread Artem Belevich via cfe-commits
@@ -283,12 +283,18 @@ set(cuda_wrapper_files cuda_wrappers/cmath cuda_wrappers/complex cuda_wrappers/new + cuda_wrappers/type_traits ) set(cuda_wrapper_bits_files cuda_wrappers/bits/shared_ptr_base.h cuda_wrappers/bits/basic_string.h

[clang] 3911810 - Revert "[OpenMP] Patch for Support to loop bind clause : Checking Parent Region"

2023-10-26 Thread Chi Chun Chen via cfe-commits
Author: Chi Chun Chen Date: 2023-10-26T16:57:36-05:00 New Revision: 391181062f8d1b9277a9068a7edf41be721ca5cf URL: https://github.com/llvm/llvm-project/commit/391181062f8d1b9277a9068a7edf41be721ca5cf DIFF: https://github.com/llvm/llvm-project/commit/391181062f8d1b9277a9068a7edf41be721ca5cf.diff

[clang] [OpenMP] Associate the KernelEnvironment with the GenericKernelTy (PR #70383)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Johannes Doerfert (jdoerfert) Changes By associating the kernel environment with the generic kernel we can access middle-end information easily, including the launch bounds ranges that are acceptable. By constraining

[PATCH] D157879: [clang] Report missing designated initializers in C++

2023-10-26 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. This change has introduced a false positive for anonymous union members: struct A { int m; union { int n = 0; }; }; A a = A{.m = 0}; now produces a false positive warning saying that the anonymous union member in `A` is uninitialized. Repository:

[clang] [OpenMP] Pass min/max thread and team count to the OMPIRBuilder (PR #70247)

2023-10-26 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert closed https://github.com/llvm/llvm-project/pull/70247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Pass min/max thread and team count to the OMPIRBuilder (PR #70247)

2023-10-26 Thread Johannes Doerfert via cfe-commits
@@ -607,8 +608,13 @@ void CodeGenModule::handleAMDGPUFlatWorkGroupSizeAttr( if (Min != 0) { assert(Min <= Max && "Min must be less than or equal Max"); +if (MinThreadsVal) + *MinThreadsVal = Min; +if (MaxThreadsVal) + *MaxThreadsVal = Max;

[clang] 57cebc7 - [OpenMP][NFC] Fix test (remove wrong autogen header)

2023-10-26 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2023-10-26T14:38:24-07:00 New Revision: 57cebc709df0ce839807b852432eccf345d8a63e URL: https://github.com/llvm/llvm-project/commit/57cebc709df0ce839807b852432eccf345d8a63e DIFF:

[clang] ab34d71 - [OpenMP][NFC] Remove untested code emitting no-op call

2023-10-26 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2023-10-26T14:38:24-07:00 New Revision: ab34d71087a85a9d024657207683ea0eb775d326 URL: https://github.com/llvm/llvm-project/commit/ab34d71087a85a9d024657207683ea0eb775d326 DIFF:

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-26 Thread Chris B via cfe-commits
@@ -217,21 +221,21 @@ void i(); // CHECK-NEXT:"id": "0x{{.*}}", // CHECK-NEXT:"kind": "FunctionTemplateDecl", // CHECK-NEXT:"loc": { -// CHECK-NEXT: "offset": {{[0-9]+}}, +// CHECK-NEXT: "offset": 142, llvm-beanz wrote: To add a bit of

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

2023-10-26 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/70224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

2023-10-26 Thread Sang Ik Lee via cfe-commits
silee2 wrote: check-flang failed on Windows with two unresolved tests. Does not look related to this PR. Merging main again to run CI again. https://github.com/llvm/llvm-project/pull/69949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [MLIR] SPIRV Target Attribute (PR #69949)

2023-10-26 Thread Sang Ik Lee via cfe-commits
https://github.com/silee2 updated https://github.com/llvm/llvm-project/pull/69949 >From 1a4319cff8d95d5a6a6598f94162be28e56d68a8 Mon Sep 17 00:00:00 2001 From: "Lee, Sang Ik" Date: Mon, 23 Oct 2023 17:23:54 + Subject: [PATCH 1/3] [MLIR] SPIRV Target Attribute Create SPIRV Target Attribute

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-26 Thread James E T Smith via cfe-commits
jamesETsmith wrote: @philnik777, I've added tests for `ranges::iota` to several of the `ranges_robust_against_*` tests where I thought it was appropriate. Below is a breakdown (mostly for my own tracking) of what I've done and what I'm still sorting through

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 543f9e781032f086afa7438065b9ce7a9c07ca2b 2631a5163de552a8e482f5cbc51525fb8bb5082f --

[clang] [Driver] Reject unsupported -mcmodel= (PR #70262)

2023-10-26 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/70262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7e42545 - [Driver] Reject unsupported -mcmodel= (#70262)

2023-10-26 Thread via cfe-commits
Author: Fangrui Song Date: 2023-10-26T14:15:36-07:00 New Revision: 7e4254552481dbc4089b91941273ff8c42a7113c URL: https://github.com/llvm/llvm-project/commit/7e4254552481dbc4089b91941273ff8c42a7113c DIFF: https://github.com/llvm/llvm-project/commit/7e4254552481dbc4089b91941273ff8c42a7113c.diff

[clang] [clang] Document -Wglobal-constructors behavior (PR #68084)

2023-10-26 Thread via cfe-commits
https://github.com/serge-sans-paille closed https://github.com/llvm/llvm-project/pull/68084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a8a6b66 - [clang] Document -Wglobal-constructors behavior (#68084)

2023-10-26 Thread via cfe-commits
Author: serge-sans-paille Date: 2023-10-26T21:09:31Z New Revision: a8a6b66a266e8917caa4e9fb1371c24bd54c32b3 URL: https://github.com/llvm/llvm-project/commit/a8a6b66a266e8917caa4e9fb1371c24bd54c32b3 DIFF: https://github.com/llvm/llvm-project/commit/a8a6b66a266e8917caa4e9fb1371c24bd54c32b3.diff

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (serge-sans-paille) Changes Previous representation used an enumeration combined to a switch to dispatch to the appropriate lexer. Use function pointer so that the dispatching is just an indirect call, which is actually better

[clang] [clang] Change representation of CurLexerKind (PR #70381)

2023-10-26 Thread via cfe-commits
https://github.com/serge-sans-paille created https://github.com/llvm/llvm-project/pull/70381 Previous representation used an enumeration combined to a switch to dispatch to the appropriate lexer. Use function pointer so that the dispatching is just an indirect call, which is actually better

[clang] SwiftCallingConv: Fix the splitVectorEntry function (PR #69953)

2023-10-26 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. Oops. LGTM. https://github.com/llvm/llvm-project/pull/69953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve bugprone-unused-return-value check (PR #66573)

2023-10-26 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/66573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 543f9e7 - [clang-tidy] Improve bugprone-unused-return-value check (#66573)

2023-10-26 Thread via cfe-commits
Author: Piotr Zegar Date: 2023-10-26T22:58:20+02:00 New Revision: 543f9e781032f086afa7438065b9ce7a9c07ca2b URL: https://github.com/llvm/llvm-project/commit/543f9e781032f086afa7438065b9ce7a9c07ca2b DIFF: https://github.com/llvm/llvm-project/commit/543f9e781032f086afa7438065b9ce7a9c07ca2b.diff

[clang] e3ecdf7 - [clang-format][NFC] Remove some extraneous newlines at end of test cases

2023-10-26 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-26T13:37:23-07:00 New Revision: e3ecdf7d3b7ec8fa2c3c594ff39b20788e75eaf2 URL: https://github.com/llvm/llvm-project/commit/e3ecdf7d3b7ec8fa2c3c594ff39b20788e75eaf2 DIFF: https://github.com/llvm/llvm-project/commit/e3ecdf7d3b7ec8fa2c3c594ff39b20788e75eaf2.diff

[clang] [CUDA][HIP] Fix std::is_invocable (PR #70369)

2023-10-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Looks reasonable, the same approach we've always done for these things. https://github.com/llvm/llvm-project/pull/70369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   4   5   >