@@ -0,0 +1,193 @@
+//===--- EnumInitialValueCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/PiotrZSL requested changes to this pull request.
Overall looks fine.
Some minor style issues.
Try getting rid of findNextTokenSkippingComments, and maybe just jump to
begin() + token width
https://github.com/llvm/llvm-project/pull/86129
__
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/86129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
Well, its down to about 15 minutes from 1hr 40 min, which is a pretty great
improvement. 15 minutes does still seem to be too long for a file that's only
2KLOC. I know its more complex w/ headers and macros, but it does only take
about 1-2 minutes to compile normally, so I feel
minglotus-6 wrote:
> My concern with this approach is that compiler-rt is treated as a different
> project and updating the code within LLVM makes it easy to miss running the
> test locally for the other project. I think such issues will be caught by the
> buildbot but having it flagged earlie
@@ -560,6 +602,28 @@ Error InstrProfSymtab::addFuncWithName(Function &F,
StringRef PGOFuncName) {
return Error::success();
}
+uint64_t InstrProfSymtab::getVTableHashFromAddress(uint64_t Address) {
+ finalizeSymtab();
minglotus-6 wrote:
Added a comment.
T
https://github.com/diggerlin edited
https://github.com/llvm/llvm-project/pull/77732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/diggerlin edited
https://github.com/llvm/llvm-project/pull/77732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/QuietMisdreavus requested changes to this pull request.
Looks mostly good, though i would have preferred having multiple commits to
wade through rather than having to spend 2.5 hours walking through it in person
:wink: There are some comments that came out of that chat that i
@@ -119,20 +78,12 @@ static void
WalkupFromMostDerivedType(LibClangExtractAPIVisitor &Visitor,
break;
#include "clang/AST/DeclNodes.inc"
}
-
- for (auto *Parent = D->getDeclContext(); Parent != nullptr;
- Parent = Parent->getParent()) {
-if (WalkupParentContex
@@ -54,63 +55,21 @@ struct LibClangExtractAPIVisitor
if (!shouldDeclBeIncluded(Decl))
return true;
-const ObjCInterfaceDecl *Interface = Decl->getClassInterface();
-StringRef Name = Interface->getName();
-StringRef USR = API.recordUSR(Decl);
-Presumed
@@ -0,0 +1,82 @@
+//===--- EnumInitialValueCheck.cpp - clang-tidy
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/86599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Piotr Zegar
Date: 2024-03-26T18:20:25+01:00
New Revision: 313734795c67ca0bfb82f96b39e123774ddf24b4
URL:
https://github.com/llvm/llvm-project/commit/313734795c67ca0bfb82f96b39e123774ddf24b4
DIFF:
https://github.com/llvm/llvm-project/commit/313734795c67ca0bfb82f96b39e123774ddf24b4.diff
L
@@ -0,0 +1,49 @@
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+// RUN: %clang_cc1 -extract-api --pretty-sgf
--emit-sgf-symbol-labels-for-testing \
+// RUN: --emit-extension-symbol-graphs --symbol-graph-dir=%t/symbols \
+// RUN: --product-name=Module -fmodules -fimplicit-modul
https://github.com/keith updated https://github.com/llvm/llvm-project/pull/86602
>From 7bd6708e6ffc457c66ce71e7ba19d078c18cec34 Mon Sep 17 00:00:00 2001
From: Keith Smiley
Date: Mon, 25 Mar 2024 16:42:39 -0700
Subject: [PATCH] [cmake] Remove custom linker flag check function
Since LLVM now requ
@@ -88,6 +88,7 @@ sections with improvements to Clang's support for those
languages.
C++ Language Changes
+- Implemented _BitInt literal suffixes as ``__wb`` or ``__WB`` with unsigned
modifiers also allowed. (#GH85223).
AaronBallman wrot
@@ -88,6 +88,7 @@ sections with improvements to Clang's support for those
languages.
C++ Language Changes
+- Implemented _BitInt literal suffixes as ``__wb`` or ``__WB`` with unsigned
modifiers also allowed. (#GH85223).
AaronBallman wrot
@@ -1516,3 +1516,5 @@ def UnsafeBufferUsage : DiagGroup<"unsafe-buffer-usage",
[UnsafeBufferUsageInCon
// Warnings and notes InstallAPI verification.
def InstallAPIViolation : DiagGroup<"installapi-violation">;
+// Warnings related to _BitInt extension
+def BitIntExtension :
@@ -1241,7 +1260,9 @@ bool NumericLiteralParser::isValidUDSuffix(const
LangOptions &LangOpts,
return false;
// By C++11 [lex.ext]p10, ud-suffixes starting with an '_' are always valid.
- if (Suffix[0] == '_')
+ // Suffixes starting with '__' (double underscore) are fo
@@ -1117,19 +1118,37 @@ NumericLiteralParser::NumericLiteralParser(StringRef
TokSpelling,
if (isImaginary) break; // Cannot be repeated.
isImaginary = true;
continue; // Success.
+case '_':
+ if (isFPConstant)
+break; // Invalid for floats
@@ -1,965 +1,630 @@
// RUN: rm -rf %t
-// RUN: split-file %s %t
-// RUN: sed -e "s@INPUT_DIR@%{/t:regex_replacement}@g" \
-// RUN: %t/reference.output.json.in >> %t/reference.output.json
-// RUN: %clang_cc1 -extract-api -fblocks -triple arm64-apple-macosx \
-// RUN: -x objective-
https://github.com/smanna12 closed
https://github.com/llvm/llvm-project/pull/85962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: smanna12
Date: 2024-03-26T12:05:40-05:00
New Revision: 4c4ea249cef8db71d30517aab60a081e764260e1
URL:
https://github.com/llvm/llvm-project/commit/4c4ea249cef8db71d30517aab60a081e764260e1
DIFF:
https://github.com/llvm/llvm-project/commit/4c4ea249cef8db71d30517aab60a081e764260e1.diff
LOG:
smanna12 wrote:
Thank you for reviews!
https://github.com/llvm/llvm-project/pull/85962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?=
Message-ID:
In-Reply-To:
https://github.com/llvm-beanz approved this pull
llvmbot wrote:
>/cherry-pick
>https://github.com/llvm/llvm-project/commit/9c8dd5e6f6bd93deb95de9642632223f54a18a11
Error: Command failed due to missing milestone.
https://github.com/llvm/llvm-project/pull/86377
___
cfe-commits mailing list
cfe-commi
llvmbot wrote:
>/cherry-pick
>https://github.com/llvm/llvm-project/commit/e6f63a942a45e3545332cd9a43982a69a4d5667b
Error: Command failed due to missing milestone.
https://github.com/llvm/llvm-project/pull/86479
___
cfe-commits mailing list
cfe-commi
@@ -50,17 +51,20 @@
TypedefUnderlyingTypeResolver::getSymbolReferenceForType(QualType Type,
SmallString<128> TypeUSR;
const NamedDecl *TypeDecl = getUnderlyingTypeDecl(Type);
const TypedefType *TypedefTy = Type->getAs();
+ StringRef OwningModuleName;
if (TypeDecl)
llvm-beanz wrote:
Hi @aniplcc, thank you for the PR.
We do require test cases for bug fixes and new features (see the [Developer
Policy](https://llvm.org/docs/DeveloperPolicy.html#test-cases).
Because this general feature is already tested for OpenCL, we can make a really
simple test for this
https://github.com/tahonermann approved this pull request.
This looks fine to me. `LambdaCapture` consists of a pointer and two source
locations so is relatively small and thus, this doesn't address a performance
concern. Having the variable be `const` is good regardless to avoid unintended
mu
AtariDreams wrote:
/cherry-pick
https://github.com/llvm/llvm-project/commit/e6f63a942a45e3545332cd9a43982a69a4d5667b
https://github.com/llvm/llvm-project/pull/86479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
AtariDreams wrote:
/cherry-pick
https://github.com/llvm/llvm-project/commit/9c8dd5e6f6bd93deb95de9642632223f54a18a11
https://github.com/llvm/llvm-project/pull/86377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/smanna12 closed
https://github.com/llvm/llvm-project/pull/85944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: smanna12
Date: 2024-03-26T11:48:37-05:00
New Revision: e75989e93063d1ac2626c3478c28ca364e04ef28
URL:
https://github.com/llvm/llvm-project/commit/e75989e93063d1ac2626c3478c28ca364e04ef28
DIFF:
https://github.com/llvm/llvm-project/commit/e75989e93063d1ac2626c3478c28ca364e04ef28.diff
LOG:
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/86690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kazutakahirata wrote:
> I have already merged #86661
Thanks! I'll close this one then.
https://github.com/llvm/llvm-project/pull/86690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexey-bataev wrote:
> > Are you going to submit your code?
>
> Yes, but it's still incomplete. I can wait with this PR if you prefer.
Yes, I think better to introduce it with the actual user.
https://github.com/llvm/llvm-project/pull/8
___
cfe-c
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/86661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Zahira Ammarguellat
Date: 2024-03-26T12:43:38-04:00
New Revision: b06913103fe7d3abeb474369eb69e7dfab7f8893
URL:
https://github.com/llvm/llvm-project/commit/b06913103fe7d3abeb474369eb69e7dfab7f8893
DIFF:
https://github.com/llvm/llvm-project/commit/b06913103fe7d3abeb474369eb69e7dfab7f8893
AaronBallman wrote:
> > > According to the spec it's ill-formed, so I'm not sure it falls under any
> > > sensible category.
> >
> >
> > It's an extension we support so it's up to us to decide what sensible is.
>
> Sure. If we end up putting it in the array category we should probably
> coor
smanna12 wrote:
Thank you @tahonermann for reviews!
https://github.com/llvm/llvm-project/pull/85944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tahonermann approved this pull request.
These all look good to me. Thanks, @smanna12!
https://github.com/llvm/llvm-project/pull/85944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -826,430 +738,322 @@ StringRef
SymbolGraphSerializer::getConstraintString(ConstraintKind Kind) {
llvm_unreachable("Unhandled constraint kind");
}
-void SymbolGraphSerializer::serializeRelationship(RelationshipKind Kind,
-
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/85591
From f015496c511b4c2898b9f4d65ebfe39a34c5119c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 17 Mar 2024 20:50:17 -0400
Subject: [PATCH 1/5] [clang-tidy] Improved --verify
https://github.com/felix642 edited
https://github.com/llvm/llvm-project/pull/85591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -454,52 +454,31 @@ static constexpr StringLiteral VerifyConfigWarningEnd = "
[-verify-config]\n";
static bool verifyChecks(const StringSet<> &AllChecks, StringRef CheckGlob,
StringRef Source) {
- llvm::StringRef Cur, Rest;
+ GlobList Globs(CheckG
@@ -1117,19 +1118,37 @@ NumericLiteralParser::NumericLiteralParser(StringRef
TokSpelling,
if (isImaginary) break; // Cannot be repeated.
isImaginary = true;
continue; // Success.
+case '_':
+ if (isFPConstant)
+break; // Invalid for floats
@@ -454,52 +454,31 @@ static constexpr StringLiteral VerifyConfigWarningEnd = "
[-verify-config]\n";
static bool verifyChecks(const StringSet<> &AllChecks, StringRef CheckGlob,
StringRef Source) {
- llvm::StringRef Cur, Rest;
+ GlobList Globs(CheckG
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/85591
From f015496c511b4c2898b9f4d65ebfe39a34c5119c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 17 Mar 2024 20:50:17 -0400
Subject: [PATCH 1/4] [clang-tidy] Improved --verify
zahiraam wrote:
I have a PR ready for it.
https://github.com/llvm/llvm-project/pull/86690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Zahira Ammarguellat (zahiraam)
Changes
Sanitizer failure in https://lab.llvm.org/buildbot/#/builders/19/builds/25788
---
Full diff: https://github.com/llvm/llvm-project/pull/86661.diff
1 Files Affected:
- (modified) clang/lib/AST/TypePr
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/86661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Jonas Paulsson (JonPsson1)
Changes
- Factor out a shouldCastToInt() method.
- Also pass through pointer type values to not be casted to integer.
The follow up improvement patch per recent review. The non-ieee FP types left
out as
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
This patch fixes:
clang/lib/AST/TypePrinter.cpp:2307:9: error: misleading indentation;
statement is not part of the previous 'if'
[-Werror,-Wmisleading-indentation]
---
Full diff: https://github
https://github.com/JonPsson1 created
https://github.com/llvm/llvm-project/pull/86691
- Factor out a shouldCastToInt() method.
- Also pass through pointer type values to not be casted to integer.
The follow up improvement patch per recent review. The non-ieee FP types left
out as it seems easie
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/86690
This patch fixes:
clang/lib/AST/TypePrinter.cpp:2307:9: error: misleading indentation;
statement is not part of the previous 'if'
[-Werror,-Wmisleading-indentation]
>From f9b781e803e79dd3395dbb796f
https://github.com/coopp approved this pull request.
Looks good to me for what I can see in the code.
I took special care to make sure places where noticed the old size accessor
(CAT->getSize().getZExtValue() ) being called, was now using
(CAT->getZExtSize()).
https://github.com/llvm/llvm-pr
@@ -0,0 +1,61 @@
+// REQUIRES: aarch64-registered-target
kovdan01 wrote:
Ensured that it's not needed and deleted in
2fd8f6606c6d287085582b82145b05a635fbf776, thanks
https://github.com/llvm/llvm-project/pull/85235
___
@@ -0,0 +1,32 @@
+// Check that we can manually enable specific ptrauth features.
+
+// RUN: %clang --target=aarch64 -c %s -### 2>&1 | FileCheck %s --check-prefix
NONE
+// NONE: "-cc1"
+// NONE-NOT: "-fptrauth-intrinsics"
kovdan01 wrote:
Fixed, thanks, see 4fd37
@@ -0,0 +1,32 @@
+// Check that we can manually enable specific ptrauth features.
kovdan01 wrote:
Thanks, see f3abb4897fb9cd56b00eb6344489bbc972c40c5b and
4fd37cf125c13982ae0b6eb7254404fa3def6df5
https://github.com/llvm/llvm-project/pull/85235
_
@@ -7203,6 +7203,33 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
options::OPT_fno_ptrauth_intrinsics, false))
CmdArgs.push_back("-fptrauth-intrinsics");
+ if (Args.hasFlag(options::OPT_fptrauth_calls, options::OPT_fno_ptrauth_calls,
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/85235
>From 919af72c09216838bfe586c3da503f5d74104a7d Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 19 Mar 2024 23:57:06 +0300
Subject: [PATCH 1/7] [PAC][clang] Define ptrauth driver flags and preprocessor
@@ -0,0 +1,74 @@
+//===- SemaOpenACC.h - Semantic Analysis for OpenACC constructs
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,169 @@
+//===- ExtractAPI/Serialization/APISetVisitor.h *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
kparzysz wrote:
> Are you going to submit your code?
Yes, but it's still incomplete. I can wait with this PR if you prefer.
https://github.com/llvm/llvm-project/pull/8
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
Author: Cyndy Ishida
Date: 2024-03-26T11:56:16-04:00
New Revision: 6d579cd1d91cdde5adfa455bda7903e737e9d5cf
URL:
https://github.com/llvm/llvm-project/commit/6d579cd1d91cdde5adfa455bda7903e737e9d5cf
DIFF:
https://github.com/llvm/llvm-project/commit/6d579cd1d91cdde5adfa455bda7903e737e9d5cf.diff
cbi42 wrote:
Hi - would it make sense to call exit after all the diff_string is written to
stdout? This allows a preview of all lines that need to change. Right now, it
exits after printing out the changes needed for the first file.
https://github.com/llvm/llvm-project/pull/70883
_
alexey-bataev wrote:
> I don't think so, because nothing is failing without it. This is just for
> completeness.
>
> Edit: My code will use it, but at the moment there aren't any users that I
> know of.
Are you going to submit your code?
https://github.com/llvm/llvm-project/pull/8
__
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
(This patch depends on #86678)
Pretty straightforward change, addresses the FIXME's in
`computeDependence(MemberExpr*)` and `MemberExpr::Create` by moving the
template argument dependence computat
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/86682
(This patch depends on #86678)
Pretty straightforward change, addresses the FIXME's in
`computeDependence(MemberExpr*)` and `MemberExpr::Create` by moving the
template argument dependence computations to `co
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/86129
>From 4e0845a143a820d4a68ffbdced206654c7593359 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 15 Mar 2024 08:07:47 +0800
Subject: [PATCH 1/5] [clang-tidy] add new check readability-enum-initial-value
https://github.com/python3kgae edited
https://github.com/llvm/llvm-project/pull/83933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/python3kgae updated
https://github.com/llvm/llvm-project/pull/83933
>From b134854e7e183a1113ee6ae5c5f7b7910270c987 Mon Sep 17 00:00:00 2001
From: Xiang Li
Date: Mon, 4 Mar 2024 16:39:41 -0800
Subject: [PATCH 01/12] [DOC][HLSL] Add documentation for root signature
This patch
@@ -242,79 +260,168 @@ struct APIRecord {
/// Objective-C class/instance methods).
DeclarationFragments SubHeading;
- /// Information about the parent record of this record.
- HierarchyInformation ParentInformation;
-
/// Whether the symbol was defined in a system hea
@@ -242,79 +260,168 @@ struct APIRecord {
/// Objective-C class/instance methods).
DeclarationFragments SubHeading;
- /// Information about the parent record of this record.
- HierarchyInformation ParentInformation;
-
/// Whether the symbol was defined in a system hea
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Krystian Stasiowski (sdkrystian)
Changes
Currently, `MemberExpr` allocates a trailing `MemberExprNameQualifier` object
if it either has a `NestedNameSpecifierLoc`, or if it names a member found via
using declaration. Since the pre
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/86678
Currently, `MemberExpr` allocates a trailing `MemberExprNameQualifier` object
if it either has a `NestedNameSpecifierLoc`, or if it names a member found via
using declaration. Since the presence of a _nested-
https://github.com/philnik777 approved this pull request.
LGTM with the libunwind changes removed.
https://github.com/llvm/llvm-project/pull/86658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
philnik777 wrote:
Yes, it would be the only buildkite one (AFAIK). I don't think that would make
much of a difference though.
https://github.com/llvm/llvm-project/pull/86658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/85716
>From 4a11a73b4dd41637b1d730489954c2994489d6be Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Mon, 18 Mar 2024 17:30:41 -0500
Subject: [PATCH 1/5] [NFC] Refactor ConstantArrayType size storage
In PR #793
emaste wrote:
> The C++26 job is part of the first jobs that get run'
Oops, I did miss that. I think this would be the only buildkite job using
`generic-cxx26`
https://github.com/llvm/llvm-project/pull/86658
___
cfe-commits mailing list
cfe-commits@li
@@ -39,6 +39,9 @@
# if defined(__HAIKU__)
# define _LIBUNWIND_TARGET_HAIKU 1
# endif
+#if defined(__FreeBSD__)
emaste wrote:
Yes, libunwind change was included by accident - I just let the CI jobs finish
rather than restarting; I will update the pull req to
@@ -5317,6 +5318,12 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine
&Line,
if (Right.NewlinesBefore > 1 && Style.MaxEmptyLinesToKeep > 0)
return true;
+ if (Style.BreakFunctionDefinitionParameters && Line.MightBeFunctionDecl &&
ameerj wrote
https://github.com/ameerj updated
https://github.com/llvm/llvm-project/pull/84988
>From 0d0868ddffe1b0668a57c10cc89614ab7c840634 Mon Sep 17 00:00:00 2001
From: ameerj
Date: Sat, 16 Mar 2024 17:03:47 -0400
Subject: [PATCH 1/2] [clang-format] Add BreakFunctionDefinitionParameters
option
---
cl
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/85716
>From 4a11a73b4dd41637b1d730489954c2994489d6be Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Mon, 18 Mar 2024 17:30:41 -0500
Subject: [PATCH 1/4] [NFC] Refactor ConstantArrayType size storage
In PR #793
@@ -396,12 +405,85 @@ CharUnits
PPC32_SVR4_ABIInfo::getParamTypeAlignment(QualType Ty) const {
return CharUnits::fromQuantity(4);
}
+ABIArgInfo PPC32_SVR4_ABIInfo::handleComplex(uint64_t &TypeSize) const {
+ llvm::Type *ElemTy;
+ unsigned RegsNeeded; // Registers Needed f
@@ -421,6 +503,11 @@ ABIArgInfo PPC32_SVR4_ABIInfo::classifyReturnType(QualType
RetTy) const {
}
}
+ bool IsComplexInRegABI =
+ getCodeGenOpts().getComplexInRegABI() == CodeGenOptions::CMPLX_InGPR;
+ if (IsComplexInRegABI && RetTy->isAnyComplexType())
---
@@ -0,0 +1,306 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 2
+
+// RUN: %clang_cc1 -triple powerpc-unknown-linux-gnu \
+// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-DEF
+// RUN: %clang_cc1 -triple power
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 72c729f354d71697a1402720c90b57ff521b6739
cc5542353b1fa36a1d2c2637526af3dad522f7a0 --
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Daniel Grumberg (daniel-grumberg)
Changes
This allows to segregate symbols that are extending symbols from other modules
into a spearate graph. This also uses the opportunity to clean up the
emit-symbol-graph interface.
---
Patch
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Daniel Grumberg (daniel-grumberg)
Changes
This allows to segregate symbols that are extending symbols from other modules
into a spearate graph. This also uses the opportunity to clean up the
emit-symbol-graph interface.
---
Patch is 528
@@ -39,6 +39,9 @@
# if defined(__HAIKU__)
# define _LIBUNWIND_TARGET_HAIKU 1
# endif
+#if defined(__FreeBSD__)
philnik777 wrote:
Are these changes related?
https://github.com/llvm/llvm-project/pull/86658
___
cfe-co
philnik777 wrote:
The C++26 job is part of the first jobs that get run. Did you just miss it, or
do you mean something else?
https://github.com/llvm/llvm-project/pull/86658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/74440
>From aa9d6cd10ff32fdcdd3d1b2ef334aa70f56cccb1 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Tue, 5 Dec 2023 10:03:00 +0100
Subject: [PATCH 01/10] [Sema] Implement support for -Wformat-signedness
In
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (martinboehme)
Changes
This is currently only used in one place, but I'm working on a patch that will
use this from a second place. And I think this already improves the readability
of the one place this is used so far.
---
Full diff
https://github.com/martinboehme created
https://github.com/llvm/llvm-project/pull/86675
This is currently only used in one place, but I'm working on a patch that will
use this from a second place. And I think this already improves the readability
of the one place this is used so far.
>From 224
@@ -0,0 +1,223 @@
+// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -verify
-Wformat -Wformat-signedness %s
+// RUN: %clang_cc1 -triple=x86_64-pc-win32 -std=c11 -fsyntax-only -verify
-Wformat -Wformat-signedness %s
+
+// Verify that -Wformat-signedness alone
@@ -0,0 +1,223 @@
+// RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -std=c11 -fsyntax-only -verify
-Wformat -Wformat-signedness %s
+// RUN: %clang_cc1 -triple=x86_64-pc-win32 -std=c11 -fsyntax-only -verify
-Wformat -Wformat-signedness %s
+
+// Verify that -Wformat-signedness alone
https://github.com/ilovepi approved this pull request.
LGTM. Thanks for the quick fix. I’ll try this out later today and let you know
if this completely solves the issue or if there is something else that may
still warrant investigating.
https://github.com/llvm/llvm-project/pull/86596
___
201 - 300 of 405 matches
Mail list logo
