[clang-tools-extra] [clang-tidy] bugprone-lambda-function-name ignore macro in captures (PR #89076)

2024-04-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/89076 >From 49b4cd16c7f22bf31239f9474bb68c81ed76f057 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 17 Apr 2024 22:22:18 +0800 Subject: [PATCH 1/4] [clang-tidy] bugprone-lambda-function-name ignore macro i

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: @tbaederr -- this triggers an assertion with the new constexpr interpreter in `clang/test/AST/Interp/intap.cpp` but I'm not certain I understand why. Can you help me figure out how to fix that? https://github.com/llvm/llvm-project/pull/89254

[clang] [C23] Select the correct promoted type for a bit-field (PR #89254)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Bit-fields of bit-precise integer type do not promote to int, but instead promote to the type of the field. Fixes #87641 --- Full diff: https://github.com/llvm/llvm-project/pull/89254.diff 3 Files A

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Michael Buch via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -triple x86_64-unk-unk -o - -emit-llvm -debug-info-kind=standalone -gtemplate-alias %s -gsimple-template-names=simple \ +// RUN: | FileCheck %s + + Check that -gtemplate-alias causes DW_TAG_template_alias emission for + template aliase

[clang-tools-extra] [clang-tidy] bugprone-lambda-function-name ignore macro in captures (PR #89076)

2024-04-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/89076 >From 49b4cd16c7f22bf31239f9474bb68c81ed76f057 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 17 Apr 2024 22:22:18 +0800 Subject: [PATCH 1/4] [clang-tidy] bugprone-lambda-function-name ignore macro i

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-18 Thread Balázs Kéri via cfe-commits
@@ -48,7 +48,7 @@ Open Projects (Difficulty: Medium) - alpha.unix.StreamChecker + unix.StreamChecker balazske wrote: This section should be removed too. The problem is still not solved in the mentioned way ("delayed split"). I do not s

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-18 Thread Balázs Kéri via cfe-commits
@@ -910,8 +910,8 @@ Unix Alpha Checkers - -alpha.unix.Stream + +unix.Stream balazske wrote: Probably the checker must be removed entirely from this file? https://github.com/llvm/llvm-project/pull/89247 ___ cfe-co

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-18 Thread Balázs Kéri via cfe-commits
@@ -563,6 +563,20 @@ def MismatchedDeallocatorChecker : Checker<"MismatchedDeallocator">, Dependencies<[DynamicMemoryModeling]>, Documentation; +def StreamChecker : Checker<"Stream">, + HelpText<"Check stream handling functions">, + WeakDependencies<[NonNullParamChecker

[clang] [Clang] Fix the mangling of lambdas (PR #89204)

2024-04-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/89204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

2024-04-18 Thread Zahira Ammarguellat via cfe-commits
@@ -2922,7 +2922,7 @@ static bool handleFloatFloatBinOp(EvalInfo &Info, const BinaryOperator *E, // If during the evaluation of an expression, the result is not // mathematically defined [...], the behavior is undefined. // FIXME: C++ rules require us to not conform

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-18 Thread Balázs Kéri via cfe-commits
balazske wrote: The checker is usable enough to move to non-alpha state. This table contains some links to the results after the "Pedantic" option was added. The "new reports" are the ones that got removed if the option is turned on. At some projects there are still many results, for example at

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

2024-04-18 Thread Zahira Ammarguellat via cfe-commits
@@ -0,0 +1,51 @@ +// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \ +// RUN: -emit-llvm -o - %s | FileCheck %s + +// RUN %clang_cc1 -x c++ -triple x86_64-linux-gnu -emit-llvm -o - %s \ +// RUN -std=c++23 + +#define INFINITY ((float)(1e+300 * 1e+300)) +#define N

[clang] [Clang] Fix the mangling of lambdas (PR #89204)

2024-04-18 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/89204 >From 6382171fbd2075f1f0f3484bfde9ad96ec878f6e Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 18 Apr 2024 12:19:41 +0200 Subject: [PATCH 1/3] [Clang] Fix the mangling of lambdas Lambdas used in the in

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -triple x86_64-unk-unk -o - -emit-llvm -debug-info-kind=standalone -gtemplate-alias %s -gsimple-template-names=simple \ +// RUN: | FileCheck %s + + Check that -gtemplate-alias causes DW_TAG_template_alias emission for + template aliase

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-04-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. This is fine to me, I have some concerns about the out-of-bounds reads on the NumericLIteralParser, but if @cor3ntin and you have done the work to make sure it is ok, than I am ok with it. https://github.com/llvm/llvm-project/pull/86586

[clang] [clang][RISCV] Remove unneeded overloaded suffix for vcreate (PR #89241)

2024-04-18 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/89241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Rewrite] Fix offset computation in RemoveText (PR #73827)

2024-04-18 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: @jansvoboda11 this is another PR where I would appreciate your feedback if you can find the time. https://github.com/llvm/llvm-project/pull/73827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balázs Kéri (balazske) Changes --- Patch is 25.18 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/89247.diff 20 Files Affected: - (modified) clang/docs/analyzer/checkers.rs

[clang] [clang][analyzer] Move StreamChecker out of the alpha package. (PR #89247)

2024-04-18 Thread Balázs Kéri via cfe-commits
https://github.com/balazske created https://github.com/llvm/llvm-project/pull/89247 None From 7138f026e845ebb4f1a3e6a86bdeb534d666ae7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Thu, 18 Apr 2024 16:40:03 +0200 Subject: [PATCH] [clang][analyzer] Move StreamChecker

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Michael Buch via cfe-commits
https://github.com/Michael137 approved this pull request. LGTM, if @pogo59 and @dwblaikie are happy with the driver changes https://github.com/llvm/llvm-project/pull/87623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Michael Buch via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -triple x86_64-unk-unk -o - -emit-llvm -debug-info-kind=standalone -gtemplate-alias %s -gsimple-template-names=simple \ +// RUN: | FileCheck %s + + Check that -gtemplate-alias causes DW_TAG_template_alias emission for + template aliase

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-04-18 Thread Aaron Ballman via cfe-commits
@@ -80,7 +80,10 @@ class NumericLiteralParser { bool isFloat128 : 1; // 1.0q bool isFract : 1; // 1.0hr/r/lr/uhr/ur/ulr bool isAccum : 1; // 1.0hk/k/lk/uhk/uk/ulk - bool isBitInt : 1;// 1wb, 1uwb (C23) + // clang-format off + bool isBitInt

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-04-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Aside from a nit with clang-format commenting, LGTM! @Sirraide are you happy with the state of things (you've got a "request changes" for your review). @erichkeane are you happy as well? https://github.com/llvm/llvm-project/pull/86586

[clang] [BitInt] Expose a _BitInt literal suffix in C++ (PR #86586)

2024-04-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/86586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Rewrite] Fix offset computation in RemoveText (PR #73827)

2024-04-18 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/73827 >From f31443bb4de3cec4e7d98ac3c147f09a7ca297fe Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Wed, 16 Aug 2023 13:34:10 + Subject: [PATCH] [Rewrite] Fix offset computation in RemoveText When r

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-18 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: @jansvoboda11 since you've most recently touched this part of the code, would you mind having a look at the change? https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] [clangd] Propagate context into stdlib indexing thread (PR #87611)

2024-04-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/87611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] acd736e - [clangd] Propagate context into stdlib indexing thread (#87611)

2024-04-18 Thread via cfe-commits
Author: kadir çetinkaya Date: 2024-04-18T17:05:05+02:00 New Revision: acd736e3e1e7b8a20e28ed17fb59595ce1e670bb URL: https://github.com/llvm/llvm-project/commit/acd736e3e1e7b8a20e28ed17fb59595ce1e670bb DIFF: https://github.com/llvm/llvm-project/commit/acd736e3e1e7b8a20e28ed17fb59595ce1e670bb.dif

[clang] [clang-tools-extra] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-18 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: > have you tried an approach where this information is stored in `ExtQuals` > instead? Not yet, thanks for suggestion. I'll try and let you know about results https://github.com/llvm/llvm-project/pull/84384 ___ cfe-commits mailing lis

[clang-tools-extra] [clangd] Propagate context into stdlib indexing thread (PR #87611)

2024-04-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/87611 From 2b8899a6fd9477dd411f2a89409703a6e16aef2b Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Thu, 4 Apr 2024 10:57:44 +0200 Subject: [PATCH] [clangd] Propagate context into stdlib indexing thread Some FS

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Michael Buch via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-04-18 Thread Sebastian Poeplau via cfe-commits
https://github.com/sebastianpoeplau updated https://github.com/llvm/llvm-project/pull/72400 >From f260093f23fe599f2b91bbe0bf06304387549a22 Mon Sep 17 00:00:00 2001 From: Matthieu Eyraud Date: Mon, 11 Apr 2022 16:53:24 +0200 Subject: [PATCH] [libclang] Compute the right spelling location Locati

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread Gábor Horváth via cfe-commits
@@ -657,17 +658,22 @@ class TransferVisitor : public ConstStmtVisitor { } void VisitConditionalOperator(const ConditionalOperator *S) { -// FIXME: Revisit this once flow conditions are added to the framework. For -// `a = b ? c : d` we can add `b => a == c && !b =

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread Gábor Horváth via cfe-commits
@@ -657,17 +658,25 @@ class TransferVisitor : public ConstStmtVisitor { } void VisitConditionalOperator(const ConditionalOperator *S) { -// FIXME: Revisit this once flow conditions are added to the framework. For -// `a = b ? c : d` we can add `b => a == c && !b =

[clang-tools-extra] [clangd] Use TargetOpts from preamble when building ASTs (PR #88381)

2024-04-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/88381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 2cdbc9c - [clangd] Use TargetOpts from preamble when building ASTs (#88381)

2024-04-18 Thread via cfe-commits
Author: kadir çetinkaya Date: 2024-04-18T16:58:16+02:00 New Revision: 2cdbc9cff3b7ef262c45e749f0a942343a19808a URL: https://github.com/llvm/llvm-project/commit/2cdbc9cff3b7ef262c45e749f0a942343a19808a DIFF: https://github.com/llvm/llvm-project/commit/2cdbc9cff3b7ef262c45e749f0a942343a19808a.dif

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Orlando Cazalet-Hyams via cfe-commits
OCHyams wrote: I've rebased this so now this pull request contains only the Clang changes (LLVM side is here #88943). There's a discussion starting [here](https://github.com/llvm/llvm-project/pull/87623#discussion_r1567968127) that discusses whether or not we should include defaulted argument

[clang] [clang-tools-extra] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @AaronBallman See test results from compile-time-tracker here: > https://llvm-compile-time-tracker.com/compare.php?from=693a458287d019c5c6a66fe3019d099df2978cdb&to=dbb5e29d136a18060ba6759b328ad80fa9cea649. > > It looks like that there is a statistically meaningful differen

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

2024-04-18 Thread Zahira Ammarguellat via cfe-commits
@@ -2922,7 +2922,7 @@ static bool handleFloatFloatBinOp(EvalInfo &Info, const BinaryOperator *E, // If during the evaluation of an expression, the result is not // mathematically defined [...], the behavior is undefined. // FIXME: C++ rules require us to not conform

[clang] [llvm] [Clang] Emit DW_TAG_template_alias for template aliases (PR #87623)

2024-04-18 Thread Orlando Cazalet-Hyams via cfe-commits
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const TemplateSpecializationType *Ty, auto PP = getPrintingPolicy(); Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None); + SourceLocation Loc = AliasDecl->getLocation(); + + if (CGM.getCodeGenO

[clang] [clang-tools-extra] [PAC][clang] Define `PointerAuthQualifier` and `PointerAuthenticationMode` (PR #84384)

2024-04-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I've fixed the build failure > https://buildkite.com/llvm-project/github-pull-requests/builds/55986 in > clang-tidy by only taking fast qualifiers from the `uint64_t` opaque value > and casting the value to `unsigned` - see > [e3cb910](https://github.com/llvm/llvm-projec

[clang] 4c18681 - [InstallAPI] Add support for aliased exports (#88750)

2024-04-18 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-04-18T07:39:21-07:00 New Revision: 4c18681a2d5a5738233fce9d7746b968d4b4ab76 URL: https://github.com/llvm/llvm-project/commit/4c18681a2d5a5738233fce9d7746b968d4b4ab76 DIFF: https://github.com/llvm/llvm-project/commit/4c18681a2d5a5738233fce9d7746b968d4b4ab76.diff

[clang] [llvm] [InstallAPI] Add support for aliased exports (PR #88750)

2024-04-18 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/88750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][SME] Add intrinsics for multi-vector BFCLAMP (PR #88251)

2024-04-18 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. https://github.com/llvm/llvm-project/pull/88251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] Reland "[FMV] Remove useless features according the latest ACLE spec." (PR #89232)

2024-04-18 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/89232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [test] Avoid writing to a potentially write-protected dir (PR #89242)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Karl-Johan Karlsson (karka228) Changes These tests just don't check the output written to the current directory. The current directory may be write protected e.g. in a sandboxed environment. Typically one would write `clang -o %t.o` for a

[clang] [llvm] [test] Avoid writing to a potentially write-protected dir (PR #89242)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-powerpc Author: Karl-Johan Karlsson (karka228) Changes These tests just don't check the output written to the current directory. The current directory may be write protected e.g. in a sandboxed environment. Typically one would write `clang -o %

[clang] [llvm] [test] Avoid writing to a potentially write-protected dir (PR #89242)

2024-04-18 Thread Karl-Johan Karlsson via cfe-commits
https://github.com/karka228 created https://github.com/llvm/llvm-project/pull/89242 These tests just don't check the output written to the current directory. The current directory may be write protected e.g. in a sandboxed environment. Typically one would write `clang -o %t.o` for a writeable

[clang] [clang][RISCV] Remove unneeded overloaded suffix for vcreate (PR #89241)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Brandon Wu (4vtomat) Changes Since `vcreate` doesn't support overload, we can remove it. --- Full diff: https://github.com/llvm/llvm-project/pull/89241.diff 1 Files Affected: - (modified) clang/include/clang/Basic/riscv_vector

[clang] [clang][RISCV] Remove unneeded overloaded suffix for vcreate (PR #89241)

2024-04-18 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat created https://github.com/llvm/llvm-project/pull/89241 Since `vcreate` doesn't support overload, we can remove it. >From a29cda00de03552529b510eda427804f822278e6 Mon Sep 17 00:00:00 2001 From: Brandon Wu Date: Thu, 18 Apr 2024 07:29:42 -0700 Subject: [PATCH] [clang

[clang] NFC: Make clang resource headers an interface library (PR #88317)

2024-04-18 Thread Alexander Yermolovich via cfe-commits
ayermolo wrote: I am seeing a cmake error in one of the build steps in our enviroment: ``` CMake Error at CMakeLists.txt:86 (get_property): get_property could not find TARGET clang-resource-headers. Perhaps it has not yet been created. ``` Reverting this diff internally made build pass.

[clang] [llvm] [AArch64][SME] Add intrinsics for vector groups ZERO (PR #88114)

2024-04-18 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. https://github.com/llvm/llvm-project/pull/88114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

2024-04-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Please be sure to add a release note in clang/docs/ReleaseNotes.rst. The code changes themselves LGTM, but there are some issues with the tests. https://github.com/llvm/llvm-project/pull/88595 ___ cfe-commits

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

2024-04-18 Thread Aaron Ballman via cfe-commits
@@ -1,5 +1,5 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -Wformat %s -// RUN: %clang_cc1 -fsyntax-only -fdiagnostics-parseable-fixits -Wformat %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wformat-pedantic %s AaronBallman wrote: We're missin

[clang] Carving out -Wformat warning about scoped enums into a subwarning (PR #88595)

2024-04-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/88595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix -Wnullability-completeness false-positive in dependent code (PR #88727)

2024-04-18 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall closed https://github.com/llvm/llvm-project/pull/88727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7257c37 - [clang] fix -Wnullability-completeness false-positive in dependent code (#88727)

2024-04-18 Thread via cfe-commits
Author: Sam McCall Date: 2024-04-18T16:26:08+02:00 New Revision: 7257c37357ee4540d6a63e5d2854b97f43ae2c49 URL: https://github.com/llvm/llvm-project/commit/7257c37357ee4540d6a63e5d2854b97f43ae2c49 DIFF: https://github.com/llvm/llvm-project/commit/7257c37357ee4540d6a63e5d2854b97f43ae2c49.diff LO

[clang-tools-extra] [clangd] Use TargetOpts from preamble when building ASTs (PR #88381)

2024-04-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet updated https://github.com/llvm/llvm-project/pull/88381 From a99cb340ec6ede680a2b4d278b48d6062c42bef5 Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Thu, 11 Apr 2024 14:02:43 +0200 Subject: [PATCH] [clangd] Use TargetOpts from preamble when building ASTs Build

[clang] 9c51f9b - [AIX][NFC] Enable response-file-errs.c

2024-04-18 Thread via cfe-commits
Author: Jake Egan Date: 2024-04-18T10:21:54-04:00 New Revision: 9c51f9b7362d25b8c49258fa636fb95aaa07463a URL: https://github.com/llvm/llvm-project/commit/9c51f9b7362d25b8c49258fa636fb95aaa07463a DIFF: https://github.com/llvm/llvm-project/commit/9c51f9b7362d25b8c49258fa636fb95aaa07463a.diff LOG

[clang] XFAIL clang/Driver/test/compress.c on AIX (PR #87269)

2024-04-18 Thread David Tenty via cfe-commits
https://github.com/daltenty closed https://github.com/llvm/llvm-project/pull/87269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f981d86 - XFAIL clang/Driver/test/compress.c on AIX (#87269)

2024-04-18 Thread via cfe-commits
Author: azhan92 Date: 2024-04-18T10:16:32-04:00 New Revision: f981d860029411febac9200762dca47c1ef1af22 URL: https://github.com/llvm/llvm-project/commit/f981d860029411febac9200762dca47c1ef1af22 DIFF: https://github.com/llvm/llvm-project/commit/f981d860029411febac9200762dca47c1ef1af22.diff LOG:

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/89213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread via cfe-commits
@@ -657,17 +658,22 @@ class TransferVisitor : public ConstStmtVisitor { } void VisitConditionalOperator(const ConditionalOperator *S) { -// FIXME: Revisit this once flow conditions are added to the framework. For -// `a = b ? c : d` we can add `b => a == c && !b =

[clang] [clang][AIX] set OpenMP include path (PR #88545)

2024-04-18 Thread Jake Egan via cfe-commits
https://github.com/jakeegan closed https://github.com/llvm/llvm-project/pull/88545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8f07a67 - [clang][AIX] set OpenMP include path (#88545)

2024-04-18 Thread via cfe-commits
Author: Jake Egan Date: 2024-04-18T10:06:16-04:00 New Revision: 8f07a67f9731dfcd490f8aaefac34d95f207b39c URL: https://github.com/llvm/llvm-project/commit/8f07a67f9731dfcd490f8aaefac34d95f207b39c DIFF: https://github.com/llvm/llvm-project/commit/8f07a67f9731dfcd490f8aaefac34d95f207b39c.diff LOG

[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

2024-04-18 Thread via cfe-commits
https://github.com/martinboehme updated https://github.com/llvm/llvm-project/pull/89213 >From d4205b37d9ba3cecd7cd947a188ec84e9afec899 Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Thu, 18 Apr 2024 10:50:40 + Subject: [PATCH 1/2] [clang][dataflow] Model conditional operator correctly.

[clang] [compiler-rt] [llvm] [FMV] Remove useless features according the latest ACLE spec. (PR #88965)

2024-04-18 Thread Andrew Carlotti via cfe-commits
@@ -67,57 +67,42 @@ enum CPUFeatures { FEAT_FP, FEAT_SIMD, FEAT_CRC, - FEAT_SHA1, FEAT_SHA2, FEAT_SHA3, FEAT_AES, - FEAT_PMULL, FEAT_FP16, - FEAT_DIT, FEAT_DPB, FEAT_DPB2, FEAT_JSCVT, FEAT_FCMA, FEAT_RCPC, FEAT_RCPC2, FEAT_FRINTTS, - F

[clang] [OpenACC] Implement 'num_workers' clause for compute constructs (PR #89151)

2024-04-18 Thread Erich Keane via cfe-commits
@@ -156,6 +156,64 @@ class OpenACCSelfClause : public OpenACCClauseWithCondition { Expr *ConditionExpr, SourceLocation EndLoc); }; +/// Represents one of a handful of classes that have integer expressions. +/// Semantically, many only permit

[clang] [clang][dataflow] Support `CXXParenListInitExpr` in `PropagateResultObject()`. (PR #89235)

2024-04-18 Thread Yitzhak Mandelbaum via cfe-commits
@@ -401,6 +401,29 @@ class ResultObjectVisitor : public RecursiveASTVisitor { return true; } + void + PropagateResultObjectToRecordInitList(const RecordInitListHelper &InitList, +RecordStorageLocation *Loc) { +for (auto [Bas

[clang] [clang][dataflow] Support `CXXParenListInitExpr` in `PropagateResultObject()`. (PR #89235)

2024-04-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/89235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Support `CXXParenListInitExpr` in `PropagateResultObject()`. (PR #89235)

2024-04-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/89235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'num_workers' clause for compute constructs (PR #89151)

2024-04-18 Thread Alexey Bataev via cfe-commits
@@ -156,6 +156,64 @@ class OpenACCSelfClause : public OpenACCClauseWithCondition { Expr *ConditionExpr, SourceLocation EndLoc); }; +/// Represents one of a handful of classes that have integer expressions. +/// Semantically, many only permit

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-18 Thread via cfe-commits
yronglin wrote: Hope CI can be come back soon https://github.com/llvm/llvm-project/pull/88666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-18 Thread via cfe-commits
yronglin wrote: > LGTM assuming precommit CI on Windows eventually comes back green. Thanks for your review! https://github.com/llvm/llvm-project/pull/88666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [OpenACC] Implement 'num_workers' clause for compute constructs (PR #89151)

2024-04-18 Thread Erich Keane via cfe-commits
@@ -156,6 +156,64 @@ class OpenACCSelfClause : public OpenACCClauseWithCondition { Expr *ConditionExpr, SourceLocation EndLoc); }; +/// Represents one of a handful of classes that have integer expressions. +/// Semantically, many only permit

[clang] [OpenACC] Implement 'num_workers' clause for compute constructs (PR #89151)

2024-04-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/89151 >From d3894971090921b92c71ba5a18151cb2033c8cfa Mon Sep 17 00:00:00 2001 From: erichkeane Date: Tue, 16 Apr 2024 09:43:55 -0700 Subject: [PATCH 1/3] [OpenACC] Implement 'num_workers' clause for compute constru

[clang] [clang][dataflow] Support `CXXParenListInitExpr` in `PropagateResultObject()`. (PR #89235)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/89235.diff 4 Files Affected: - (modified) clang/include/clang/Analysis/FlowSensitive/ASTOps.h (+4) - (modified) c

[clang] [clang][dataflow] Support `CXXParenListInitExpr` in `PropagateResultObject()`. (PR #89235)

2024-04-18 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/89235 None >From 705f29ac1c31a7e206ed4c65102dbcfc45e952ec Mon Sep 17 00:00:00 2001 From: Martin Braenne Date: Thu, 18 Apr 2024 13:48:12 + Subject: [PATCH] [clang][dataflow] Support `CXXParenListInitExpr` in

[clang] [llvm] demangle function names in trace files (PR #87626)

2024-04-18 Thread Jamie Schmeiser via cfe-commits
jamieschmeiser wrote: Yes, the way to proceed is to rebase and resolve the conflicts. As far as the formatting changes, I think you should go with what the formatter wants. Everyone has different opinions about things like spacing, line length, etc and will never agree. The formatter keeps

[clang] [clang] Fix a "!CodeSynthesisContexts.empty()" assertion failure when constructing aggregate deduction guides. (PR #89227)

2024-04-18 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/89227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4c3514f - [clang] Fix a "!CodeSynthesisContexts.empty()" assertion failure when constructing aggregate deduction guides. (#89227)

2024-04-18 Thread via cfe-commits
Author: Haojian Wu Date: 2024-04-18T15:46:35+02:00 New Revision: 4c3514fa53cc39db5de4dbbca9a54977159f24e8 URL: https://github.com/llvm/llvm-project/commit/4c3514fa53cc39db5de4dbbca9a54977159f24e8 DIFF: https://github.com/llvm/llvm-project/commit/4c3514fa53cc39db5de4dbbca9a54977159f24e8.diff LO

[clang] [compiler-rt] [llvm] Reland "[FMV] Remove useless features according the latest ACLE spec." (PR #89232)

2024-04-18 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea converted_to_draft https://github.com/llvm/llvm-project/pull/89232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Use TargetOpts from preamble when building ASTs (PR #88381)

2024-04-18 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/88381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Propagate context into stdlib indexing thread (PR #87611)

2024-04-18 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/87611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement 'num_workers' clause for compute constructs (PR #89151)

2024-04-18 Thread Alexey Bataev via cfe-commits
@@ -156,6 +156,64 @@ class OpenACCSelfClause : public OpenACCClauseWithCondition { Expr *ConditionExpr, SourceLocation EndLoc); }; +/// Represents one of a handful of classes that have integer expressions. +/// Semantically, many only permit

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM assuming precommit CI on Windows eventually comes back green. https://github.com/llvm/llvm-project/pull/88666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [compiler-rt] [llvm] Reland "[FMV] Remove useless features according the latest ACLE spec." (PR #89232)

2024-04-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandros Lamprineas (labrinea) Changes As explained in https://github.com/ARM-software/acle/pull/315 we are deprecating features which aren't adding any value. These are: sha1, pmull, dit, dgh, ebf16, sve-bf16, sve-ebf16, sve-i8mm, sve2

[clang] [llvm] [SPIRV][HLSL] Add mad intrinsic lowering for spirv (PR #89130)

2024-04-18 Thread Vyacheslav Levytskyy via cfe-commits
https://github.com/VyacheslavLevytskyy approved this pull request. https://github.com/llvm/llvm-project/pull/89130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-18 Thread Erich Keane via cfe-commits
erichkeane wrote: > Wait for CI green, but seems windows bots fall into a trouble. Windows bot is typically pretty far behind(usually 4-5 hrs during the day), but 13 hours is a heck of a delay! I think all we can do is wait :/ https://github.com/llvm/llvm-project/pull/88666 __

[clang] [clang] Fix a "!CodeSynthesisContexts.empty()" assertion failure when constructing aggregate deduction guides. (PR #89227)

2024-04-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/89227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Distinguish unresolved templates in UnresolvedLookupExpr (PR #89019)

2024-04-18 Thread Erich Keane via cfe-commits
@@ -186,3 +186,74 @@ class E { #endif template using D = int; // expected-note {{declared here}} E ed; // expected-note {{instantiation of}} + +namespace non_functions { + +#if __cplusplus >= 201103L +namespace PR88832 { +template struct O { + static const T v = 0; +}; + +st

[clang] [Clang] Allow the value of unroll count to be zero in `#pragma GCC unroll` and `#pragma unroll` (PR #88666)

2024-04-18 Thread via cfe-commits
yronglin wrote: Wait for CI green, but seems windows bots fall into a trouble. https://github.com/llvm/llvm-project/pull/88666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Distinguish unresolved templates in UnresolvedLookupExpr (PR #89019)

2024-04-18 Thread Erich Keane via cfe-commits
@@ -186,3 +186,74 @@ class E { #endif template using D = int; // expected-note {{declared here}} E ed; // expected-note {{instantiation of}} + +namespace non_functions { + +#if __cplusplus >= 201103L +namespace PR88832 { +template struct O { + static const T v = 0; +}; + +st

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-04-18 Thread via cfe-commits
JinjinLi868 wrote: > > But In some target, it supply a HW instruction to complete the process > > (fp16->float32->bf16) . so it just supply a intrinsic (fp16 -> bf16) > > Which is not a bitcast. The correct IR representation of this conversion is > fpext+fptrunc i understand, i have changed.

[clang] [clang] fix half && bfloat16 convert node expr codegen (PR #89051)

2024-04-18 Thread via cfe-commits
https://github.com/JinjinLi868 updated https://github.com/llvm/llvm-project/pull/89051 >From 9e6c2a16172c66b7a9eec7957d95b4239f178368 Mon Sep 17 00:00:00 2001 From: Jinjin Li Date: Wed, 17 Apr 2024 16:44:50 +0800 Subject: [PATCH] [clang] Fix half && bfloat16 convert node expr codegen Data type

[clang] Stop double-diagnosing explicit convert operator in switch condition (PR #89142)

2024-04-18 Thread Erich Keane via cfe-commits
erichkeane wrote: > Did you try to use `ExprDependence::Error`? I've only ever seen that used in regards to the `RecoveryExpr`, so I think I am? Also, `RecoveryExpr` doesn't really have a way of changing its dependence to anything but what it is. https://github.com/llvm/llvm-project/pull/891

[clang] Stop double-diagnosing explicit convert operator in switch condition (PR #89142)

2024-04-18 Thread Erich Keane via cfe-commits
erichkeane wrote: > I'm having second thoughts about leveraging recovery expressions as a > side-band mechanism to de-duplicate diagnostics, because not modeling things > properly in AST might backfire in the future. But I don't have anything > better on my mind, so I don't want to block the p

[clang-tools-extra] [clang-tidy] fix add_new_check.py regex (PR #89189)

2024-04-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/89189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 743d090 - [clang-tidy] fix add_new_check.py regex (#89189)

2024-04-18 Thread via cfe-commits
Author: Congcong Cai Date: 2024-04-18T21:08:40+08:00 New Revision: 743d090b96e09fe7c2cea60a8962f579684c37ce URL: https://github.com/llvm/llvm-project/commit/743d090b96e09fe7c2cea60a8962f579684c37ce DIFF: https://github.com/llvm/llvm-project/commit/743d090b96e09fe7c2cea60a8962f579684c37ce.diff

[clang] [clang] Catch missing format attributes (PR #70024)

2024-04-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Pre-commit CI is crashing and it seems related to your changes: ``` [10077/10756] Generating ASAN_NOINST_TEST_OBJECTS.gtest-all.cc.x86_64-calls.o_bk;t=1713432335867 _bk;t=1713432335867FAILED: projects/compiler-rt/lib/asan/tests/ASAN_NOINST_TEST_OBJECTS.gtest

<    1   2   3   4   5   >