https://github.com/bcardosolopes approved this pull request.
https://github.com/llvm/llvm-project/pull/142059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fanju110 wrote:
> > > @fanju110, Thanks for seeing this through!
> >
> >
> > Hi @tarunprabhu , If everything looks good, could you please merge this PR
> > at your convenience (I don't have merge rights)? Thank you!
>
> It looks like you need to run `clang-format` on some of the code. See
>
https://github.com/bcardosolopes approved this pull request.
https://github.com/llvm/llvm-project/pull/142012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1075,6 +1089,135 @@ void CIRGenModule::emitTentativeDefinition(const
VarDecl *d) {
emitGlobalVarDefinition(d);
}
+static bool shouldAssumeDSOLocal(const CIRGenModule &cgm,
+ cir::CIRGlobalValueInterface gv) {
+ if (gv.hasLocalLinkage())
@@ -966,8 +966,7 @@ void
CIRToLLVMGlobalOpLowering::setupRegionInitializedLLVMGlobalOp(
const bool isConst = false;
assert(!cir::MissingFeatures::addressSpace());
const unsigned addrSpace = 0;
- assert(!cir::MissingFeatures::opGlobalDSOLocal());
- const bool isDsoLocal
@@ -1075,6 +1089,135 @@ void CIRGenModule::emitTentativeDefinition(const
VarDecl *d) {
emitGlobalVarDefinition(d);
}
+static bool shouldAssumeDSOLocal(const CIRGenModule &cgm,
+ cir::CIRGlobalValueInterface gv) {
+ if (gv.hasLocalLinkage())
@@ -1021,8 +1020,7 @@ mlir::LogicalResult
CIRToLLVMGlobalOpLowering::matchAndRewrite(
const bool isConst = false;
assert(!cir::MissingFeatures::addressSpace());
const unsigned addrSpace = 0;
- assert(!cir::MissingFeatures::opGlobalDSOLocal());
- const bool isDsoLocal =
https://github.com/bcardosolopes approved this pull request.
LGTM, some minor `auto` nits
https://github.com/llvm/llvm-project/pull/141973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/141973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@fleeting-xx Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a bu
https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/142090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fleeting-xx created
https://github.com/llvm/llvm-project/pull/142090
Simple module import dependencies, see
[module_dependencies.test](https://github.com/llvm/llvm-project/compare/main...fleeting-xx:llvm-project:fix_clangd_dependent_modules#diff-5510681cbe5b7ed3a72c5e683184e8
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: None (fleeting-xx)
Changes
Simple module import dependencies, see
[module_dependencies.test](https://github.com/llvm/llvm-project/compare/main...fleeting-xx:llvm-project:fix_clangd_dependent_modules#diff-5510681cbe5b7ed3a72c5e683184e83fa6
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/Harald-R updated
https://github.com/llvm/llvm-project/pull/140594
>From 2e261ba9fa08f7c482f9c9e11385d0975468b76f Mon Sep 17 00:00:00 2001
From: Harald-R
Date: Sun, 18 May 2025 19:07:59 +0300
Subject: [PATCH 1/9] Follow style configuration in clangd include cleaner
---
clang
https://github.com/punkyc updated
https://github.com/llvm/llvm-project/pull/141572
>From 385ae3040ae39d62702c430e2d0b79b80b30e36b Mon Sep 17 00:00:00 2001
From: punkyc
Date: Tue, 27 May 2025 17:21:12 +0800
Subject: [PATCH 1/3] [RISCV] Add shlcofideleg extension
---
clang/test/Driver/print-sup
punkyc wrote:
@topperc @wangpc-pp Please help to merge.
https://github.com/llvm/llvm-project/pull/141572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/132680
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,12 @@
+! RUN: env FCC_OVERRIDE_OPTIONS="#+-Os +-Oz +-O +-O3 +-Oignore +a +b +c xb Xa
Omagic ^-### " %flang -target x86_64-unknown-linux-gnu %s -O2 b -O3 2>&1 |
FileCheck %s
MaskRay wrote:
`--target=x86_64-unknown-linux-gnu` instead of the long depre
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/140556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay commented:
clang driver code looks good
https://github.com/llvm/llvm-project/pull/140556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -44,20 +45,24 @@ class SanitizerSpecialCaseList : public
llvm::SpecialCaseList {
StringRef Category = StringRef()) const;
// Query ignorelisted entries if any bit in Mask matches the entry's section.
- // Return 0 if not found. If found, return the line
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/142081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matheus Izvekov
Date: 2025-05-30T02:25:21-03:00
New Revision: 3609e09aa7ee03ee529e1c4cba0931027d674d8c
URL:
https://github.com/llvm/llvm-project/commit/3609e09aa7ee03ee529e1c4cba0931027d674d8c
DIFF:
https://github.com/llvm/llvm-project/commit/3609e09aa7ee03ee529e1c4cba0931027d674d8c.dif
MaskRay wrote:
> Thank you for confirming.
>
> @MaskRay, do you have any comments regarding the handling of warning messages?
Sorry for the delayed response. Does this implement the last-option-win
behavior as suggested in the last few comments of
https://discourse.llvm.org/t/the-priority-of
@@ -2997,6 +2997,7 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
LangOptions::ComplexRangeKind Range = LangOptions::ComplexRangeKind::CX_None;
std::string ComplexRangeStr = "";
std::string GccRangeComplexOption = "";
+ std::string LastC
@@ -2127,7 +2127,7 @@ static TemplateDeductionResult
DeduceTemplateArgumentsByTypeMatch(
TA = S.Context.getTypeDeclType(MPA->getMostRecentCXXRecordDecl());
} else {
NestedNameSpecifier *QA = MPA->getQualifier();
-TA = QualType(QA->translateToType(
@@ -409,6 +409,18 @@ void CIRGenFunction::emitCallArg(CallArgList &args, const
clang::Expr *e,
args.add(emitAnyExprToTemp(e), argType);
}
+QualType CIRGenFunction::getVarArgType(const Expr *arg) {
+ // System headers on Windows define NULL to 0 instead of 0LL on Win64. MSV
https://github.com/qinkunbao edited
https://github.com/llvm/llvm-project/pull/142027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,29 @@
+/// Invalid output path (%t is a file, not a directory).
+// RUN: rm -rf %t && touch %t
+// RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck %s
+// CHECK: clang-doc error:
+// CHECK: {{(Not a directory|no such file or directory)}}
+
+/// Invalid format op
@@ -2127,7 +2127,7 @@ static TemplateDeductionResult
DeduceTemplateArgumentsByTypeMatch(
TA = S.Context.getTypeDeclType(MPA->getMostRecentCXXRecordDecl());
} else {
NestedNameSpecifier *QA = MPA->getQualifier();
-TA = QualType(QA->translateToType(
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/142081
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -39,6 +39,26 @@ class RequiredArgs {
bool allowsOptionalArgs() const { return numRequired != ~0U; }
+ /// Compute the arguments required by the given formal prototype, given that
+ /// there may be some additional, non-formal arguments in play.
+ ///
+ /// If FD is n
https://github.com/Lancern updated
https://github.com/llvm/llvm-project/pull/141942
>From 862cb3bd98bc2ed6a6b01efe0f08ebfaf8ad63e0 Mon Sep 17 00:00:00 2001
From: Sirui Mu
Date: Thu, 29 May 2025 17:21:06 +0800
Subject: [PATCH] [CIR] Call to variadic functions
---
clang/include/clang/CIR/Missin
snarang181 wrote:
@ilovepi, wrapped the creation of the `Executor` in the error handler, created
a helper like you suggested, and added a test case for the creation of the
`Executor` failing.
https://github.com/llvm/llvm-project/pull/141699
___
cfe-
mizvekov wrote:
@gulfemsavrun thanks for reporting the issue.
This should be fixed soon by https://github.com/llvm/llvm-project/pull/142081
https://github.com/llvm/llvm-project/pull/132401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
@@ -0,0 +1,29 @@
+/// Invalid output path (%t is a file, not a directory).
+// RUN: rm -rf %t && touch %t
+// RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck %s
+// CHECK: clang-doc error:
+// CHECK: {{(Not a directory|no such file or directory)}}
+
+/// Invalid format op
https://github.com/qinkunbao edited
https://github.com/llvm/llvm-project/pull/142027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-nvptx64-nvidia-ubuntu` running on `as-builder-7` while building
`clang,llvm` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/160/builds/18334
Here is the relevant
https://github.com/fanju110 updated
https://github.com/llvm/llvm-project/pull/136098
>From 9494c9752400e4708dbc8b6a5ca4993ea9565e95 Mon Sep 17 00:00:00 2001
From: fanyikang
Date: Thu, 17 Apr 2025 15:17:07 +0800
Subject: [PATCH 01/14] Add support for IR PGO
(-fprofile-generate/-fprofile-use=/fi
@@ -48,11 +59,7 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask,
bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName,
StringRef Category) const {
- auto NoSan = SSCL->inSectionBlame(Mask, "src", FileName, Cate
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-nvptx-nvidia-ubuntu`
running on `as-builder-7` while building `clang,llvm` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/180/builds/18477
Here is the relevant p
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
This fixes a regression introduced in
https://github.com/llvm/llvm-project/pull/130537,
which was reported here:
https://github.com/llvm/llvm-project/pull/132401#issuecomment-2839690599
When deducing me
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/142081
This fixes a regression introduced in
https://github.com/llvm/llvm-project/pull/130537,
which was reported here:
https://github.com/llvm/llvm-project/pull/132401#issuecomment-2839690599
When deducing member p
@@ -44,13 +44,11 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask,
bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName,
StringRef Category) const {
- unsigned NoSanLine = SSCL->inSectionBlame(Mask, "src", FileN
@@ -29,6 +29,8 @@ class SanitizerSpecialCaseList;
class NoSanitizeList {
std::unique_ptr SSCL;
SourceManager &SM;
+ bool containsPrefix(SanitizerMask Mask, StringRef Prefix, StringRef Name,
vitalybuka wrote:
we have one spot where we can use default, we w
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/142027
>From 3b8af2c0d05fdd1fd95facd0afe0b52bacfe5690 Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Thu, 29 May 2025 19:58:08 +
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
=?U
@@ -65,7 +65,9 @@ void
TemplateArgumentHasher::AddTemplateArgument(TemplateArgument TA) {
switch (Kind) {
case TemplateArgument::Null:
-llvm_unreachable("Expected valid TemplateArgument");
+// These can occur in incomplete substitutions performed with code
+//
https://github.com/snarang181 updated
https://github.com/llvm/llvm-project/pull/141699
>From 1cddd0889b2aa322e1d1fce1225d6da0f5e8cc20 Mon Sep 17 00:00:00 2001
From: Samarth Narang
Date: Tue, 27 May 2025 21:32:41 -0400
Subject: [PATCH 01/12] [clang-doc] Refactor error handling to use ExitOnError
Acthink-Yang wrote:
Hi @shafik
Thanks for checking! I don't have commit access yet.
Could you please help merge my changes?
https://github.com/llvm/llvm-project/pull/141485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/shafik commented:
Can you elaborate in your summary.
I am guessing because the other checks are a lot cheaper and this overall
improves performance?
https://github.com/llvm/llvm-project/pull/141470
___
cfe-commits mailing list
cfe-
https://github.com/tarunprabhu commented:
Thanks for the changes, Abid. Regarding my suggestions in the documentation,
feel free to incorporate or discard them as you see fit.
I'll leave it you and @kiranchandramohan to decide what the name of the
environment variable should be.
Other than
@@ -65,7 +65,9 @@ void
TemplateArgumentHasher::AddTemplateArgument(TemplateArgument TA) {
switch (Kind) {
case TemplateArgument::Null:
-llvm_unreachable("Expected valid TemplateArgument");
+// These can occur in incomplete substitutions performed with code
+//
https://github.com/wangleiat approved this pull request.
LGTM, thanks.
https://github.com/llvm/llvm-project/pull/141703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -614,3 +614,30 @@ nvfortran defines `-fast` as
- `-Mcache_align`: there is no equivalent flag in Flang or Clang.
- `-Mflushz`: flush-to-zero mode - when `-ffast-math` is specified, Flang will
link to `crtfastmath.o` to ensure denormal numbers are flushed to zero.
+
+
+#
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/140556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qinkunbao ready_for_review
https://github.com/llvm/llvm-project/pull/142027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
Did you not do a release note b/c this was introduced w/ a recent change?
https://github.com/llvm/llvm-project/pull/141940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
sarnex wrote:
Sorry for the trouble
https://github.com/llvm/llvm-project/pull/141994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/qinkunbao updated
https://github.com/llvm/llvm-project/pull/142027
>From 3b8af2c0d05fdd1fd95facd0afe0b52bacfe5690 Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Thu, 29 May 2025 19:58:08 +
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
=?UT
kazutakahirata wrote:
@tbaederr I've landed 882e7331c4ba5582d3881b7bb93c0952e601336b to fix a warning
from this PR. Thanks!
https://github.com/llvm/llvm-project/pull/141952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
clang-tools-extra/clangd/IncludeCleaner.cpp
clang-
Author: Kazu Hirata
Date: 2025-05-29T15:48:14-07:00
New Revision: 882e7331c4ba5582d3881b7bb93c0952e601336b
URL:
https://github.com/llvm/llvm-project/commit/882e7331c4ba5582d3881b7bb93c0952e601336b
DIFF:
https://github.com/llvm/llvm-project/commit/882e7331c4ba5582d3881b7bb93c0952e601336b.diff
L
https://github.com/googlewalt closed
https://github.com/llvm/llvm-project/pull/142049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `ml-opt-dev-x86-64` running
on `ml-opt-dev-x86-64-b1` while building `clang,llvm` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/137/builds/19469
Here is the relevant
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Abhay Kanhere (AbhayKanhere)
Changes
ptrauth intrinsic to safely construct relative ptr for swift coroutines.
A ptrauth intrinsic for swift co-routine support that allows creation of
signed pointer
from offset stored at
https://github.com/AbhayKanhere created
https://github.com/llvm/llvm-project/pull/142047
ptrauth intrinsic to safely construct relative ptr for swift coroutines.
A ptrauth intrinsic for swift co-routine support that allows creation of
signed pointer
from offset stored at address relati
jansvoboda11 wrote:
Thanks for the concrete example! I think the key thing to realize is that the
`DiagnosticsEngine` and `DiagnosticOptions` used for command-line parsing are
typically throwaway and separate from those used for actual compilation. I
suggest looking at how `cc1_main()` orchest
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140294
>From 8889c7f28b29a1afc0d41da645216efeda30c991 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 16 May 2025 17:45:24 +
Subject: [PATCH 1/3] pre-req: add keywords
---
.../clang/Lex/HLSLRootSignatureTo
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/140294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/140293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Finn Plummer
Date: 2025-05-29T15:03:49-07:00
New Revision: 2b5b8db9dcf1b0b1bf2cbb24c3662d94b94a8aae
URL:
https://github.com/llvm/llvm-project/commit/2b5b8db9dcf1b0b1bf2cbb24c3662d94b94a8aae
DIFF:
https://github.com/llvm/llvm-project/commit/2b5b8db9dcf1b0b1bf2cbb24c3662d94b94a8aae.diff
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/140293
>From 1eabfe2fe30eaed793bdcf03f0e58d1e0c14548f Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 16 May 2025 16:38:33 +
Subject: [PATCH 1/4] pre-req: add keywords
---
.../clang/Lex/HLSLRootSignatureTo
@@ -252,6 +254,10 @@ TEST_F(ParseHLSLRootSignatureTest,
ValidParseStaticSamplerTest) {
ASSERT_TRUE(std::holds_alternative(Elem));
ASSERT_EQ(std::get(Elem).Reg.ViewType, RegisterType::SReg);
ASSERT_EQ(std::get(Elem).Reg.Number, 0u);
+ ASSERT_EQ(std::get(Elem).AddressU, T
evelez7 wrote:
I cannibalized the tags from class-template.mustache. By happy accident, I
realized that there is an `extractScopeChildren` so enums can be generated,
which means the placeholders in `generateDocForInfo` (`OS << IT_enum`) can be
filled in if the logic is moved to their own funct
https://github.com/evelez7 created
https://github.com/llvm/llvm-project/pull/142045
namespace-template.mustache only rendered placeholder text. Enum and record
tags were added to the template. Now, we can render an index.html for the
global namespace and other namespaces.
Added tests and dele
https://github.com/rjmccall approved this pull request.
https://github.com/llvm/llvm-project/pull/137719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/142019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sarnex edited
https://github.com/llvm/llvm-project/pull/142019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brunodf-snps wrote:
(Not sure if this requires re-approval, but I think this is ready to be merged.)
https://github.com/llvm/llvm-project/pull/137719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
@@ -34,7 +34,11 @@ bool NoSanitizeList::containsGlobal(SanitizerMask Mask,
StringRef GlobalName,
bool NoSanitizeList::containsType(SanitizerMask Mask, StringRef
MangledTypeName,
StringRef Category) const {
- return SSCL->inSection(Mask, "ty
https://github.com/JustinStitt commented:
LGTM (but I don't have official powers to `Approve`).
https://github.com/llvm/llvm-project/pull/142006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/JustinStitt edited
https://github.com/llvm/llvm-project/pull/142006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tarunprabhu wrote:
> > Seems ok now: "Changes can be cleanly merged."
> > If it's still not available, I may have messed something up on my side.
> > I'll review the GitHub docs to see if I missed something...
>
> It's probably fine, but I'd like to give the buildkites a chance to finish
> bef
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/141966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jan Svoboda
Date: 2025-05-29T13:51:57-07:00
New Revision: 572b89a1f42b83a0cb91534295ae7f360dff6d68
URL:
https://github.com/llvm/llvm-project/commit/572b89a1f42b83a0cb91534295ae7f360dff6d68
DIFF:
https://github.com/llvm/llvm-project/commit/572b89a1f42b83a0cb91534295ae7f360dff6d68.diff
L
@@ -32,9 +32,9 @@ struct X f(void);
// C11-O2-NEXT:[[A:%.*]] = getelementptr inbounds nuw [[STRUCT_X]], ptr
[[REF_TMP]], i32 0, i32 0
// C11-O2-NEXT:[[ARRAYDECAY:%.*]] = getelementptr inbounds [5 x i32], ptr
[[A]], i64 0, i64 0
// C11-O2-NEXT:call void @llvm.lifet
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/142013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight wrote:
I'm trying to update some non-in-tree code after this change, and I don't think
I understand the newly-expected lifetime rules after this change. I see all the
comments that say this makes lifetime clearer...so I expect I'm just
misunderstanding things.
Previously, Diagnostics
@@ -2313,12 +2340,12 @@ void Darwin::AddDeploymentTarget(DerivedArgList &Args)
const {
SDKInfo = parseSDKSettings(getVFS(), Args, getDriver());
// The OS and the version can be specified using the -target argument.
- std::optional OSTarget =
+ std::optional DP =
---
sarnex wrote:
Any final comments on this @AaronBallman @erichkeane @arsenm @AlexVlx
@yxsamliu, would appreciate a review, thanks!
https://github.com/llvm/llvm-project/pull/137882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
@@ -2313,12 +2340,12 @@ void Darwin::AddDeploymentTarget(DerivedArgList &Args)
const {
SDKInfo = parseSDKSettings(getVFS(), Args, getDriver());
// The OS and the version can be specified using the -target argument.
- std::optional OSTarget =
+ std::optional DP =
---
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/142013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan commented:
Generally looks fine.
https://github.com/llvm/llvm-project/pull/142013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1245,30 +1245,23 @@ void CodeGenFunction::EmitBoundsCheckImpl(const Expr
*E, llvm::Value *Bound,
}
llvm::DILocation *CodeGenFunction::SanitizerAnnotateDebugInfo(
-SanitizerKind::SanitizerOrdinal CheckKindOrdinal) {
- std::string Label;
- switch (CheckKindOrdinal) {
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/141937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/142021
Summary:
This patch identifies the CUDA path that clang used and forwards it to
the linker wrapper. This should make sure that we're using a consistent
CUDA path, but the behavior should be the same for normal us
vitalybuka wrote:
It does not let to add contributors into reviewers so just CC @JustinStitt
https://github.com/llvm/llvm-project/pull/142006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/schittir updated
https://github.com/llvm/llvm-project/pull/140282
>From abdbf8905d324f9b935b34bbc97c508ede5ac028 Mon Sep 17 00:00:00 2001
From: "Chittireddy, Sindhu"
Date: Fri, 16 May 2025 08:51:06 -0700
Subject: [PATCH 1/4] Add sycl_external attribute
---
clang/include/cla
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/142006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 387 matches
Mail list logo
