[clang-tools-extra] [clangd] Add feature modules registry (PR #153756)

2025-08-14 Thread Aleksandr Platonov via cfe-commits
https://github.com/ArcsinX edited https://github.com/llvm/llvm-project/pull/153756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add feature modules registry (PR #153756)

2025-08-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Aleksandr Platonov (ArcsinX) Changes This patch adds feature modules registry, as discussed with @kadircet in [discourse](https://discourse.llvm.org/t/rfc-registry-for-feature-modules/87733). Feature modules. which added into the feature

[clang] [llvm] [X86][APX] Remove CF feature from APXF and Diamond Rapids (PR #153751)

2025-08-14 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > Update description? > > Due to it results in more losses than gains. -> Due to it results in more > losses than gains w/o HWPGO. I assume HWPGO is not mature enough. https://github.com/llvm/llvm-project/pull/153751 ___ cfe-commit

[clang-tools-extra] [clangd] Add feature modules registry (PR #153756)

2025-08-14 Thread Aleksandr Platonov via cfe-commits
https://github.com/ArcsinX created https://github.com/llvm/llvm-project/pull/153756 This patch adds feature modules registry, as discussed with @kadircet in [discourse](https://discourse.llvm.org/t/rfc-registry-for-feature-modules/87733). Feature modules. which added into the feature module set

[clang] [NFC][Clang][Docs] Update Pointer Authentication documentation (PR #152596)

2025-08-14 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/152596 >From 8776323a7ef1dd625f1fbd02fab912a2dc8e2081 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Thu, 7 Aug 2025 13:42:48 -0700 Subject: [PATCH 1/4] [NFC][Clang][Docs] Update Pointer Authentication documentation

[clang] [Headers][X86] Remove duplicate __v8hu, NFCI (PR #153734)

2025-08-14 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon approved this pull request. https://github.com/llvm/llvm-project/pull/153734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][APX] Remove CF feature from APXF and Diamond Rapids (PR #153751)

2025-08-14 Thread Shengchen Kan via cfe-commits
KanRobert wrote: Update description? Due to it results in more losses than gains. -> Due to it results in more losses than gains w/o HWPGO. https://github.com/llvm/llvm-project/pull/153751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [llvm] [X86][APX] Remove CF feature from APXF and Diamond Rapids (PR #153751)

2025-08-14 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. https://github.com/llvm/llvm-project/pull/153751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add SpacemiT XSMTVDot (SpacemiT Vector Dot Product) extension. (PR #151706)

2025-08-14 Thread via cfe-commits
@@ -531,6 +531,9 @@ The current vendor extensions supported are: ``XAndesVDot`` LLVM implements `version 5.0.0 of the Andes Vector Dot Product Extension specification

[clang] [clang-tools-extra] [flang] [lld] [llvm] [LLVM][utils] Add script which clears release notes (PR #153593)

2025-08-14 Thread Tobias Hieta via cfe-commits
tru wrote: Hi this is great! Thanks for doing this. There are some things that might need to happen in libc++ as well. Is that something we can automate in this script @ldionne @philnik777 ? https://github.com/llvm/llvm-project/pull/153593 ___ cfe-co

[clang] [llvm] [X86][APX] Remove CF feature from APXF and Diamond Rapids (PR #153751)

2025-08-14 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/153751 Due to it results in more losses than gains. >From 155a039f02a9dcabeae70ac4ff9438bdc3357d41 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Fri, 15 Aug 2025 14:18:20 +0800 Subject: [PATCH] [X86][APX] Rem

[clang] [Clang] Add detailed notes explaining why is_aggregate evaluates to false (PR #152488)

2025-08-14 Thread Shamshura Egor via cfe-commits
egorshamshura wrote: > I am mostly afk, I will look at this over the weekend. > maybe @AaronBallman can help ping 🥺 https://github.com/llvm/llvm-project/pull/152488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [clang-tools-extra] [flang] [lld] [llvm] [LLVM][utils] Add script which clears release notes (PR #153593)

2025-08-14 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis updated https://github.com/llvm/llvm-project/pull/153593 >From 1fdf80aac85fdade340ac8ae17519a0b4d68d0f7 Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Thu, 14 Aug 2025 23:01:41 +0800 Subject: [PATCH 1/3] Add script to clear release notes --- clang-tools-extra/docs/Re

[clang] Fix Issue where libclang Does Not Include Standard Compiler Specific Headers (PR #153746)

2025-08-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fristender (Fristender) Changes As discussed in https://github.com/llvm/llvm-project/issues/54626, sometimes libclang is compiled without the standard compiler-specific headers. This results in the libclang python bindings consistently no

[clang] Fix Issue where libclang Does Not Include Standard Compiler Specific Headers (PR #153746)

2025-08-14 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Fix Issue where libclang Does Not Include Standard Compiler Specific Headers (PR #153746)

2025-08-14 Thread via cfe-commits
https://github.com/Fristender created https://github.com/llvm/llvm-project/pull/153746 As discussed in https://github.com/llvm/llvm-project/issues/54626, sometimes libclang is compiled without the standard compiler-specific headers. This results in the libclang python bindings consistently not

[clang] [Clang][Bytecode][NFS] Init Semantics non-static member of class Floating (PR #153671)

2025-08-14 Thread Timm Baeder via cfe-commits
tbaederr wrote: This was on purpose, see https://github.com/llvm/llvm-project/pull/144246#discussion_r2149988969 https://github.com/llvm/llvm-project/pull/153671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] Fix Issue where libclang Does Not Include Standard Compiler Specific Headers (PR #153667)

2025-08-14 Thread via cfe-commits
Fristender wrote: Accidentally used main branch. closing. https://github.com/llvm/llvm-project/pull/153667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix Issue where libclang Does Not Include Standard Compiler Specific Headers (PR #153667)

2025-08-14 Thread via cfe-commits
https://github.com/Fristender closed https://github.com/llvm/llvm-project/pull/153667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clangd][NFC] Normalize all file path root names (PR #153736)

2025-08-14 Thread via cfe-commits
https://github.com/EcutAtom336 updated https://github.com/llvm/llvm-project/pull/153736 >From 0a478fdde90e4b02aa349ca62073d51871875af3 Mon Sep 17 00:00:00 2001 From: zhujiatao <1975841...@qq.com> Date: Fri, 15 Aug 2025 11:23:01 +0800 Subject: [PATCH] [Clangd][NFC] Normalize all file path root na

[clang-tools-extra] [clangd] Retrieve documentation for member function instance from index (PR #153337)

2025-08-14 Thread Younan Zhang via cfe-commits
@@ -1887,7 +1887,19 @@ class CodeCompleteFlow { for (auto &Cand : C.first) { if (Cand.SemaResult && Cand.SemaResult->Kind == CodeCompletionResult::RK_Declaration) { -auto ID = clangd::getSymbolID(Cand.SemaResult->getDeclaration()); +

[clang-tools-extra] [clangd] Retrieve documentation for member function instance from index (PR #153337)

2025-08-14 Thread Younan Zhang via cfe-commits
@@ -1887,7 +1887,19 @@ class CodeCompleteFlow { for (auto &Cand : C.first) { if (Cand.SemaResult && Cand.SemaResult->Kind == CodeCompletionResult::RK_Declaration) { -auto ID = clangd::getSymbolID(Cand.SemaResult->getDeclaration()); +

[clang] [clang] Allow no trivial before C++ module directive (PR #153641)

2025-08-14 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/153641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow no trivial before C++ module directive (PR #153641)

2025-08-14 Thread via cfe-commits
@@ -1682,3 +1688,37 @@ const char *Preprocessor::getCheckPoint(FileID FID, const char *Start) const { return nullptr; } + +/// Whether allow C++ module directive. +bool Preprocessor::hasSeenNoTrivialPPDirective() const { + return DirTracer && DirTracer->hasSeenNoTrivialPPD

[clang] [clang] Allow no trivial before C++ module directive (PR #153641)

2025-08-14 Thread via cfe-commits
@@ -0,0 +1,388 @@ +//===--- TrivialDirectiveTracer.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang] Allow no trivial before C++ module directive (PR #153641)

2025-08-14 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/153641 >From 62ab3571fd1c528bab72193deaf0171028d4bb39 Mon Sep 17 00:00:00 2001 From: yronglin Date: Fri, 15 Aug 2025 02:12:23 +0800 Subject: [PATCH 1/2] [clang] Allow no trivial before C++ module directive Signed-off

[clang-tools-extra] [clangd] Retrieve documentation for member function instance from index (PR #153337)

2025-08-14 Thread Nathan Ridge via cfe-commits
@@ -1887,7 +1887,19 @@ class CodeCompleteFlow { for (auto &Cand : C.first) { if (Cand.SemaResult && Cand.SemaResult->Kind == CodeCompletionResult::RK_Declaration) { -auto ID = clangd::getSymbolID(Cand.SemaResult->getDeclaration()); +

[clang] [clang][LoongArch] Ensure `target("lasx")` implies LSX support (PR #153542)

2025-08-14 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#153739 https://github.com/llvm/llvm-project/pull/153542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][LoongArch] Ensure `target("lasx")` implies LSX support (PR #153542)

2025-08-14 Thread via cfe-commits
Ami-zhang wrote: /cherry-pick 793a6b4fd402c929e04f9da407fe4491d5d9d22e a1b6e7ff393533a5c4f3bdfd4efe5da106e2de2b https://github.com/llvm/llvm-project/pull/153542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang][LoongArch] Ensure `target("lasx")` implies LSX support (PR #153542)

2025-08-14 Thread via cfe-commits
https://github.com/Ami-zhang milestoned https://github.com/llvm/llvm-project/pull/153542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][LoongArch] Ensure `target("lasx")` implies LSX support (PR #153542)

2025-08-14 Thread via cfe-commits
Ami-zhang wrote: > Can it be backported to LLVM 21? Yes. https://github.com/llvm/llvm-project/pull/153542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clangd][NFC] Normalize all file path root names (PR #153736)

2025-08-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: zhujiatao (EcutAtom336) Changes Normalize all file path root names in GlobalChanges to uppercase to avoid case-sensitive copying on Windows. This will cause vscode-clangd to be unable to rename symbols (renaming cannot apply modification

[clang-tools-extra] [Clangd][NFC] Normalize all file path root names (PR #153736)

2025-08-14 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [Clangd][NFC] Normalize all file path root names (PR #153736)

2025-08-14 Thread via cfe-commits
https://github.com/EcutAtom336 created https://github.com/llvm/llvm-project/pull/153736 Normalize all file path root names in GlobalChanges to uppercase to avoid case-sensitive copying on Windows. This will cause vscode-clangd to be unable to rename symbols (renaming cannot apply modifications

[clang] [llvm] [RISCV] Support Base P RV32/64 Instructions (PR #150379)

2025-08-14 Thread via cfe-commits
realqhc wrote: > I missed this patch in my email. I posted #153458 for the other shift > instructions. I used RVPShiftD_ri instead of RVPShiftD_ri. D would be the > usual suffix for "doubleword" or 64 bits. Thanks, I will modify this patch to include p15-17 using your sugessions after #153629

[clang] [Headers][X86] Remove duplicate __v8hu, NFCI (PR #153734)

2025-08-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Phoebe Wang (phoebewang) Changes Newly added in xmmintrin.h by c8312bdd1665225c585dd2b0bff5e46d569edd45 --- Full diff: https://github.com/llvm/llvm-project/pull/153734.diff 1 Files Affected: - (modified) clang/lib/Headers/emmintrin.h (-

[clang] [Headers][X86] Remove duplicate __v8hu, NFCI (PR #153734)

2025-08-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Phoebe Wang (phoebewang) Changes Newly added in xmmintrin.h by c8312bdd1665225c585dd2b0bff5e46d569edd45 --- Full diff: https://github.com/llvm/llvm-project/pull/153734.diff 1 Files Affected: - (modified) clang/lib/Headers/emmintri

[clang] [Headers][X86] Remove duplicate __v8hu, NFCI (PR #153734)

2025-08-14 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/153734 Newly added in xmmintrin.h by c8312bdd1665225c585dd2b0bff5e46d569edd45 >From 40265a5b25d3bed04e99532b7202945f08c95dd8 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Fri, 15 Aug 2025 11:28:07 +0800 Subje

[clang] [llvm] [AIX] Implement the ifunc attribute. (PR #153049)

2025-08-14 Thread Fangrui Song via cfe-commits
@@ -397,6 +399,98 @@ void llvm::embedBufferInModule(Module &M, MemoryBufferRef Buf, appendToCompilerUsed(M, GV); } +void llvm::lowerIFuncsOnAIX(Module &M) { MaskRay wrote: Should not introduce new target-specific intrinsic uses in lib/Transform. I think t

[clang] [llvm] [AIX] Implement the ifunc attribute. (PR #153049)

2025-08-14 Thread Wael Yehia via cfe-commits
w2yehia wrote: I mistakenly thought ifunc can be forward declared with enough information to indicate it's an ifunc, so that all callsites of ifunc can be converted to indirect calls through the function descriptor (which is something that was planned as an immediate next step after this PR or

[clang] [clang][LoongArch] Ensure `target("lasx")` implies LSX support (PR #153542)

2025-08-14 Thread via cfe-commits
azuresky01 wrote: Can it be backported to LLVM 21? https://github.com/llvm/llvm-project/pull/153542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream GotoOp (PR #153701)

2025-08-14 Thread via cfe-commits
@@ -433,6 +435,25 @@ mlir::LogicalResult CIRGenFunction::emitReturnStmt(const ReturnStmt &s) { return mlir::success(); } +mlir::LogicalResult CIRGenFunction::emitGotoStmt(const clang::GotoStmt &s) { + // FIXME: LLVM codegen inserts emit stop point here for debug info + //

[clang] [NFC][Clang][Docs] Update Pointer Authentication documentation (PR #152596)

2025-08-14 Thread Oliver Hunt via cfe-commits
@@ -255,33 +260,160 @@ signing schema breaks down even more simply: It is important that the signing schema be independently derived at all signing and authentication sites. Preferably, the schema should be hard-coded everywhere it is needed, but at the very least, it must not

[clang] [llvm] [NVPTX] Consolidate and cleanup various NVPTXISD nodes (NFC) (PR #145581)

2025-08-14 Thread Alex MacLean via cfe-commits
AlexMaclean wrote: @ThomasRaoux thanks for the investigation. Please confirm if https://github.com/llvm/llvm-project/pull/153730 fixes the issue! https://github.com/llvm/llvm-project/pull/145581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang][Webassembly] Remove unrachable code in ParseTypeQualifierListOpt (PR #153729)

2025-08-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Static analysis flagged this goto as unreachable and indeed it is, so removing it. --- Full diff: https://github.com/llvm/llvm-project/pull/153729.diff 1 Files Affected: - (modified) clang/lib/Parse/Par

[clang] [clang-format] Add an option to format integer and float literal case (PR #151590)

2025-08-14 Thread Andy MacGregor via cfe-commits
@@ -47,14 +47,21 @@ TEST_F(NumericLiteralInfoTest, IntegerLiteral) { // Hexadecimal. EXPECT_TRUE(verifyInfo(NumericLiteralInfo("0xF"), 1)); EXPECT_TRUE(verifyInfo(NumericLiteralInfo("0XfZ"), 1, npos, npos, 3)); + + // C++ suffixes. + EXPECT_TRUE(verifyInfo(NumericLitera

[clang] [Clang][Webassembly] Remove unrachable code in ParseTypeQualifierListOpt (PR #153729)

2025-08-14 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/153729 Static analysis flagged this goto as unreachable and indeed it is, so removing it. >From 98ea646f9fb4331f24cb3492338efa0eaca7763b Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Thu, 14 Aug 2025 19:02:51 -

[clang] [NFC][Clang][Docs] Update Pointer Authentication documentation (PR #152596)

2025-08-14 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/152596 >From 8776323a7ef1dd625f1fbd02fab912a2dc8e2081 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Thu, 7 Aug 2025 13:42:48 -0700 Subject: [PATCH 1/3] [NFC][Clang][Docs] Update Pointer Authentication documentation

[clang] [llvm] [mlir] [Coroutines] Add llvm.coro.where and drop return value of llvm.coro.end (PR #153404)

2025-08-14 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: Did a quick scanning. It looks good generally. https://github.com/llvm/llvm-project/pull/153404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [Coroutines] Add llvm.coro.where and drop return value of llvm.coro.end (PR #153404)

2025-08-14 Thread Chuanqi Xu via cfe-commits
@@ -2117,6 +2118,30 @@ Example: %hdl.result = ... ; get address of returned coroutine handle ret ptr %hdl.result +'llvm.coro.where' Intrinsic +^^ +:: + + declare i1 @llvm.coro.where() + +Overview: +" + +The '``llvm.c

[clang] [llvm] [mlir] [Coroutines] Add llvm.coro.where and drop return value of llvm.coro.end (PR #153404)

2025-08-14 Thread Chuanqi Xu via cfe-commits
@@ -2117,6 +2118,30 @@ Example: %hdl.result = ... ; get address of returned coroutine handle ret ptr %hdl.result +'llvm.coro.where' Intrinsic +^^ +:: + + declare i1 @llvm.coro.where() ChuanqiXu9 wrote: I pr

[clang] [llvm] [mlir] [Coroutines] Add llvm.coro.where and drop return value of llvm.coro.end (PR #153404)

2025-08-14 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/153404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][LoongArch] Ensure `target("lasx")` implies LSX support (PR #153542)

2025-08-14 Thread via cfe-commits
https://github.com/Ami-zhang closed https://github.com/llvm/llvm-project/pull/153542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a1b6e7f - [clang][LoongArch] Ensure `target("lasx")` implies LSX support (#153542)

2025-08-14 Thread via cfe-commits
Author: Ami-zhang Date: 2025-08-15T09:53:08+08:00 New Revision: a1b6e7ff393533a5c4f3bdfd4efe5da106e2de2b URL: https://github.com/llvm/llvm-project/commit/a1b6e7ff393533a5c4f3bdfd4efe5da106e2de2b DIFF: https://github.com/llvm/llvm-project/commit/a1b6e7ff393533a5c4f3bdfd4efe5da106e2de2b.diff LOG

[clang] [clang][PAC][darwin] Set correct default ptrauth features for arm64e-darwin (PR #153722)

2025-08-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oliver Hunt (ojhunt) Changes This PR makes sure that when targeting arm64e on darwin platforms the correct flags are set for the userspace platform ABI. --- Full diff: https://github.com/llvm/llvm-project/pull/153722.diff 4 Files Affect

[clang] [clang][PAC][darwin] Set correct default ptrauth features for arm64e-darwin (PR #153722)

2025-08-14 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/153722 This PR makes sure that when targeting arm64e on darwin platforms the correct flags are set for the userspace platform ABI. >From eaeb3b514f56bb7f638712cb938c72de4b17dc14 Mon Sep 17 00:00:00 2001 From: Oliver Hu

[clang] [llvm] [NVPTX] Consolidate and cleanup various NVPTXISD nodes (NFC) (PR #145581)

2025-08-14 Thread Thomas Raoux via cfe-commits
ThomasRaoux wrote: @AlexMaclean I compared the runs in ncu and there are no differences in occupancy and the arithmetic usage is roughly the same but I see some large stalls on `SR_CgaCtaId` read in a loop that comes from the extra global_smem copy: https://github.com/user-attachments/assets/3

[clang] [Clang] unrecognized html tag causing undesirable comment lexing (PR #152944)

2025-08-14 Thread via cfe-commits
mdenson wrote: let me know if you want the extra changes backed out. otherwise, you will need to merge it since i don't have access. https://github.com/llvm/llvm-project/pull/152944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [clang][Sema] Diagnose passing function pointer to `__builtin_assume_aligned` (PR #153552)

2025-08-14 Thread Victor Chernyakin via cfe-commits
@@ -1,9 +0,0 @@ -// RUN: %clang_cc1 -fsyntax-only -Wno-int-conversion -triple x86_64-linux -verify %s localspook wrote: The pointer is now always converted to `const void *`, so we no longer need to disallow these integer conversions. https://github.com/llvm/l

[clang] [DebugInfo] When referencing structured bindings use the reference's location, not the binding's declaration's location (PR #153637)

2025-08-14 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Really, the AST design is weird: we're not supposed to do any computation when you reference parts of the binding. We represent it as an expression just to reduce the code required to handle bindings. As such, the set of expressions actually allowed in a binding are quit

[clang] [clang][Sema] Diagnose passing function pointer to `__builtin_assume_aligned` (PR #153552)

2025-08-14 Thread Victor Chernyakin via cfe-commits
localspook wrote: I've switched to `checkBuiltinArgument`, but it causes an issue that I'd like input on before I continue. `clang/test/CodeGen/catch-alignment-assumption-ignorelist.c` tests that UBSan doesn't validate the alignment of pointers to volatile. With this change, the `volatile`-ne

[clang] [CIR] Upstream GotoOp (PR #153701)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -433,6 +435,25 @@ mlir::LogicalResult CIRGenFunction::emitReturnStmt(const ReturnStmt &s) { return mlir::success(); } +mlir::LogicalResult CIRGenFunction::emitGotoStmt(const clang::GotoStmt &s) { + // FIXME: LLVM codegen inserts emit stop point here for debug info + //

[clang] [CIR] Upstream GotoOp (PR #153701)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -433,6 +435,25 @@ mlir::LogicalResult CIRGenFunction::emitReturnStmt(const ReturnStmt &s) { return mlir::success(); } +mlir::LogicalResult CIRGenFunction::emitGotoStmt(const clang::GotoStmt &s) { + // FIXME: LLVM codegen inserts emit stop point here for debug info + //

[clang] [CIR] Upstream GotoOp (PR #153701)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -1649,7 +1649,27 @@ void cir::FuncOp::print(OpAsmPrinter &p) { // TODO(CIR): The properties of functions that require verification haven't // been implemented yet. -mlir::LogicalResult cir::FuncOp::verify() { return success(); } +mlir::LogicalResult cir::FuncOp::verify() {

[clang] [CIR] Upstream GotoOp (PR #153701)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -433,6 +435,25 @@ mlir::LogicalResult CIRGenFunction::emitReturnStmt(const ReturnStmt &s) { return mlir::success(); } +mlir::LogicalResult CIRGenFunction::emitGotoStmt(const clang::GotoStmt &s) { + // FIXME: LLVM codegen inserts emit stop point here for debug info + //

[clang] [CIR] Upstream GotoOp (PR #153701)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,203 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm %s -o %t.ll +// RUN: FileCheck --input-file=%t.ll %s

[clang] [CIR] Upstream GotoOp (PR #153701)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -1649,7 +1649,27 @@ void cir::FuncOp::print(OpAsmPrinter &p) { // TODO(CIR): The properties of functions that require verification haven't // been implemented yet. -mlir::LogicalResult cir::FuncOp::verify() { return success(); } +mlir::LogicalResult cir::FuncOp::verify() {

[clang] [CIR] Upstream GotoOp (PR #153701)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -433,6 +435,25 @@ mlir::LogicalResult CIRGenFunction::emitReturnStmt(const ReturnStmt &s) { return mlir::success(); } +mlir::LogicalResult CIRGenFunction::emitGotoStmt(const clang::GotoStmt &s) { + // FIXME: LLVM codegen inserts emit stop point here for debug info -

[clang] [clang][Obj-C][PAC] Make block descriptor pointer signing configurable (PR #153700)

2025-08-14 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt closed https://github.com/llvm/llvm-project/pull/153700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fb14f91 - [clang][Obj-C][PAC] Make block descriptor pointer signing configurable (#153700)

2025-08-14 Thread via cfe-commits
Author: Oliver Hunt Date: 2025-08-14T17:20:27-07:00 New Revision: fb14f91305dd512f28927ee17766c1b00ae114dc URL: https://github.com/llvm/llvm-project/commit/fb14f91305dd512f28927ee17766c1b00ae114dc DIFF: https://github.com/llvm/llvm-project/commit/fb14f91305dd512f28927ee17766c1b00ae114dc.diff L

[clang] [llvm] [AMDGPU] Error out in clang if wavefront64 is used on gfx1250 (PR #153693)

2025-08-14 Thread Stanislav Mekhanoshin via cfe-commits
@@ -774,6 +774,18 @@ static bool isWave32Capable(StringRef GPU, const Triple &T) { return IsWave32Capable; } +static bool isWave64Capable(StringRef GPU, const Triple &T) { + if (T.isAMDGCN()) { rampitec wrote: Do you want to add a new feature to every tar

[clang] [clang][analyzer] Support non-default address spaces in the cstring checker (PR #153498)

2025-08-14 Thread Isaac Nudelman via cfe-commits
@@ -1,11 +1,26 @@ // RUN: %clang_analyze_cc1 -triple amdgcn-unknown-unknown \ -// RUN: -analyzer-checker=core -verify %s +// RUN: -analyzer-checker=core,unix -verify %s // expected-no-diagnostics // // By default, pointers are 64-bits. +#define ADDRESS_SPACE_64BITS __att

[clang] [clang][analyzer] Support non-default address spaces in the cstring checker (PR #153498)

2025-08-14 Thread Isaac Nudelman via cfe-commits
@@ -1,11 +1,26 @@ // RUN: %clang_analyze_cc1 -triple amdgcn-unknown-unknown \ -// RUN: -analyzer-checker=core -verify %s +// RUN: -analyzer-checker=core,unix -verify %s nuudlman wrote: Done https://github.com/llvm/llvm-project/pull/153498 __

[clang] [clang][analyzer] Support non-default address spaces in the cstring checker (PR #153498)

2025-08-14 Thread Isaac Nudelman via cfe-commits
@@ -1,11 +1,26 @@ // RUN: %clang_analyze_cc1 -triple amdgcn-unknown-unknown \ -// RUN: -analyzer-checker=core -verify %s +// RUN: -analyzer-checker=core,unix -verify %s nuudlman wrote: Thanks for pointing this out, applied! https://github.com/llvm/llvm-proj

[clang] [clang][Sema] Diagnose passing function pointer to `__builtin_assume_aligned` (PR #153552)

2025-08-14 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/153552 >From 63c02556bc65571a84e27debde2e2cfd724a0e9b Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Thu, 14 Aug 2025 00:52:37 -0700 Subject: [PATCH 1/2] [clang][Sema] Diagnose passing function pointer to `

[clang] [clang][analyzer] Support non-default address spaces in the cstring checker (PR #153498)

2025-08-14 Thread Isaac Nudelman via cfe-commits
https://github.com/nuudlman updated https://github.com/llvm/llvm-project/pull/153498 >From 9b7fd4839440ade71e1b9561b158dd37969b7def Mon Sep 17 00:00:00 2001 From: Isaac Nudelman <62861466+nuudl...@users.noreply.github.com> Date: Wed, 13 Aug 2025 23:02:11 +0200 Subject: [PATCH 1/2] Support non-de

[clang] [llvm] [AMDGPU] Error out in clang if wavefront64 is used on gfx1250 (PR #153693)

2025-08-14 Thread Matt Arsenault via cfe-commits
@@ -774,6 +774,18 @@ static bool isWave32Capable(StringRef GPU, const Triple &T) { return IsWave32Capable; } +static bool isWave64Capable(StringRef GPU, const Triple &T) { + if (T.isAMDGCN()) { arsenm wrote: This should be added to the feature flags in th

[clang] [CIR] Implement Statement Expressions (PR #153677)

2025-08-14 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/153677 >From d68b52a0af50bb4d18df40e81c54c32bd700e702 Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Thu, 14 Aug 2025 22:44:35 +0200 Subject: [PATCH 1/3] [CIR] Implement Statement Expressions This patch adds support f

[clang] [Clang][Sema] Add nullptr check in IsFunctionConversion (PR #153710)

2025-08-14 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. Yeah, I can’t see how that if statement wouldn’t just explode if `ToFPT` ended up being null, so this makes sense. https://github.com/llvm/llvm-project/pull/153710 ___ cfe-commits mailing list cf

[clang] [CIR] Implement codegen for inline assembly without input and output operands (PR #153546)

2025-08-14 Thread Andy Kaylor via cfe-commits
andykaylor wrote: Can you rebase this on your merged commits? https://github.com/llvm/llvm-project/pull/153546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Implement Statement Expressions (PR #153677)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,166 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir andykaylor wrote: Can you add a test that requires a cleanup related to the scope of the statement expression? In the incubator, I see `stmt-expr.c`, `stmt-

[clang] [CIR] Implement Statement Expressions (PR #153677)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -23,16 +25,57 @@ using namespace clang; using namespace clang::CIRGen; using namespace cir; -void CIRGenFunction::emitCompoundStmtWithoutScope(const CompoundStmt &s) { - for (auto *curStmt : s.body()) { -if (emitStmt(curStmt, /*useCurrentScope=*/false).failed()) -

[clang] [CIR] Implement Statement Expressions (PR #153677)

2025-08-14 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor commented: This looks great, but I'd like to see some additional tests brought in if possible. https://github.com/llvm/llvm-project/pull/153677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [CIR] Implement Statement Expressions (PR #153677)

2025-08-14 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/153677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP][WIP] Use ATTACH maps for array-sections/subscripts on pointers. (PR #153683)

2025-08-14 Thread Abhinav Gaba via cfe-commits
https://github.com/abhinavgaba edited https://github.com/llvm/llvm-project/pull/153683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Add nullptr check in IsFunctionConversion (PR #153710)

2025-08-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Static analysis flagged this code b/c ToFPT could be nullptr but we were not checking it even though in the previous if statement we did. It looks like this was a mistaken refactor from: https://github.co

[clang] [Clang][Sema] Add nullptr check in IsFunctionConversion (PR #153710)

2025-08-14 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/153710 Static analysis flagged this code b/c ToFPT could be nullptr but we were not checking it even though in the previous if statement we did. It looks like this was a mistaken refactor from: https://github.com/llvm

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/153698 >From 1de984292efcc907405812ccb02f348e0a36e0af Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Fri, 15 Aug 2025 00:05:14 +0200 Subject: [PATCH 1/3] [CIR] Implement __builtin_return_address and __builtin_frame_ad

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/lib/CIR/CodeGen/CIRGenBuilder.h clang/lib/CIR

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Morris Hafner via cfe-commits
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/153698 >From 1de984292efcc907405812ccb02f348e0a36e0af Mon Sep 17 00:00:00 2001 From: Morris Hafner Date: Fri, 15 Aug 2025 00:05:14 +0200 Subject: [PATCH 1/2] [CIR] Implement __builtin_return_address and __builtin_frame_ad

[clang] [clang][Obj-C][PAC] Make block descriptor pointer signing configurable (PR #153700)

2025-08-14 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/153700 >From 0ec32635312dd35a38d75df53d58541817a25c17 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sat, 9 Aug 2025 21:28:40 -0700 Subject: [PATCH 1/2] [clang][Obj-C][PAC] Make block descriptor pointer signing confi

[clang] [clang][Obj-C][PAC] Make block descriptor pointer signing configurable (PR #153700)

2025-08-14 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha approved this pull request. https://github.com/llvm/llvm-project/pull/153700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -2210,6 +2210,67 @@ def CIR_CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { ]; } +//===--===// +// ReturnAddrOp and FrameAddrOp +//===--

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -312,6 +312,20 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID, case Builtin::BI__builtin_rotateright64: return emitRotate(e, /*isRotateLeft=*/false); + case Builtin::BI__builtin_return_address: + case Builtin::BI__builtin_frame_a

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -2210,6 +2210,67 @@ def CIR_CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { ]; } +//===--===// +// ReturnAddrOp and FrameAddrOp +//===--

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -267,6 +267,26 @@ void convertSideEffectForCall(mlir::Operation *callOp, bool isNothrow, } } +static mlir::LLVM::CallIntrinsicOp +createCallLLVMIntrinsicOp(mlir::ConversionPatternRewriter &rewriter, + mlir::Location loc, const llvm::Twine &intrin

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -1097,6 +1117,24 @@ mlir::LogicalResult CIRToLLVMCallOpLowering::matchAndRewrite( getTypeConverter(), op.getCalleeAttr()); } +mlir::LogicalResult CIRToLLVMReturnAddrOpLowering::matchAndRewrite( +cir::ReturnAddrOp op, OpAdaptor adaptor, +

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -312,6 +312,20 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID, case Builtin::BI__builtin_rotateright64: return emitRotate(e, /*isRotateLeft=*/false); + case Builtin::BI__builtin_return_address: + case Builtin::BI__builtin_frame_a

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -312,6 +312,20 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl &gd, unsigned builtinID, case Builtin::BI__builtin_rotateright64: return emitRotate(e, /*isRotateLeft=*/false); + case Builtin::BI__builtin_return_address: + case Builtin::BI__builtin_frame_a

[clang] [CIR] Implement __builtin_return_address and __builtin_frame_address (PR #153698)

2025-08-14 Thread Andy Kaylor via cfe-commits
@@ -2210,6 +2210,67 @@ def CIR_CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { ]; } +//===--===// +// ReturnAddrOp and FrameAddrOp +//===--

  1   2   3   4   5   >