[clang] 6e77a67 - Fix clang Visual Studio build instructions

Author: Alessandro Vergani Date: 2021-04-20T11:17:29-07:00 New Revision: 6e77a67171e68d9eda811799d5b1c2530282478e URL: https://github.com/llvm/llvm-project/commit/6e77a67171e68d9eda811799d5b1c2530282478e DIFF:

Re: [PATCH] D70701: Fix more VFS tests on Windows

BTW, I hope I didn't come across as overly negative in my previous response. I'd love to see the situation improved. I just don't know what that would look like. > One thing I see, but wasn't obvious from your description, is that the mixed/hybrid separator behaviour only happens for

Re: [PATCH] D70701: Fix more VFS tests on Windows

I didn't design VFS. I just fixed a bunch of portability bugs that prevented us from running most of the VFS tests on Windows. If I were designing it, I (hope) I wouldn't have done it this way. But the horse is already out of the barn. Here's my background with VFS (and, specifically, the

Re: [PATCH] D88666: DirectoryWatcher: add an implementation for Windows

If I had to guess, my money would be on a deadlock. To unblock, I'd propose reverting this patch until we can figure it out. During the review, a deadlock was fixed related to the watcher thread, but perhaps we missed one for the notifier thread. On Tue, Oct 13, 2020 at 8:40 AM Hans Wennborg

[clang] 14dde43 - With MSVC, file needs to be compiled with /BIGOBJ

Author: Adrian McCarthy Date: 2020-07-17T09:43:06-07:00 New Revision: 14dde438d69c81ab4651157a94d32ee804ff URL: https://github.com/llvm/llvm-project/commit/14dde438d69c81ab4651157a94d32ee804ff DIFF:

[clang] a549c0d - Fix template class debug info for Visual Studio visualizers

Author: Adrian McCarthy Date: 2020-05-13T14:20:18-07:00 New Revision: a549c0d00486bf01cb485e343d778fe4a3649a43 URL: https://github.com/llvm/llvm-project/commit/a549c0d00486bf01cb485e343d778fe4a3649a43 DIFF:

Re: [PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

I completed the bisect, and it is indeed the change in spacing between the `>`s that triggers the problem with the visualizers. That said, I'm still suspicious that the std::map visualizer isn't quite right with how it uses the wild cards and the template parameter placeholder(s), but I don't

[clang] da45bd2 - [VFS] More consistent support for Windows

Author: Adrian McCarthy Date: 2020-02-05T11:38:20-08:00 New Revision: da45bd232165eab5d6ec4f1f4f18db8644289142 URL: https://github.com/llvm/llvm-project/commit/da45bd232165eab5d6ec4f1f4f18db8644289142 DIFF:

[clang] 738b5c9 - Fix more VFS tests on Windows

Author: Adrian McCarthy Date: 2019-12-18T11:38:04-08:00 New Revision: 738b5c9639b4323f75b03e21494bef13d9adfa86 URL: https://github.com/llvm/llvm-project/commit/738b5c9639b4323f75b03e21494bef13d9adfa86 DIFF:

[clang] 9d38fd8 - [NFC] Update FIXME for one VFS test

Author: Adrian McCarthy Date: 2019-12-18T11:38:04-08:00 New Revision: 9d38fd8d0be3074af036e9e3e36489f5b854faf4 URL: https://github.com/llvm/llvm-project/commit/9d38fd8d0be3074af036e9e3e36489f5b854faf4 DIFF:

[clang] 1275ab1 - Improve VFS compatibility on Windows

Author: Adrian McCarthy Date: 2019-11-14T08:48:47-08:00 New Revision: 1275ab1620b665eb06231ce3c4e5068c97d9b618 URL: https://github.com/llvm/llvm-project/commit/1275ab1620b665eb06231ce3c4e5068c97d9b618 DIFF:

r322136 - Reland "Emit Function IDs table for Control Flow Guard"

Author: amccarth Date: Tue Jan 9 15:49:30 2018 New Revision: 322136 URL: http://llvm.org/viewvc/llvm-project?rev=322136=rev Log: Reland "Emit Function IDs table for Control Flow Guard" Adds option /guard:cf to clang-cl and -cfguard to cc1 to emit function IDs of functions that have their

r322008 - Revert "Emit Function IDs table for Control Flow Guard"

Author: amccarth Date: Mon Jan 8 09:12:01 2018 New Revision: 322008 URL: http://llvm.org/viewvc/llvm-project?rev=322008=rev Log: Revert "Emit Function IDs table for Control Flow Guard" The new test fails on the Hexagon bot. Reverting while I investigate. This reverts

r322005 - Emit Function IDs table for Control Flow Guard

Author: amccarth Date: Mon Jan 8 08:33:42 2018 New Revision: 322005 URL: http://llvm.org/viewvc/llvm-project?rev=322005=rev Log: Emit Function IDs table for Control Flow Guard Adds option /guard:cf to clang-cl and -cfguard to cc1 to emit function IDs of functions that have their address taken

r313192 - Mark static member functions as static in CodeViewDebug

Author: amccarth Date: Wed Sep 13 13:53:55 2017 New Revision: 313192 URL: http://llvm.org/viewvc/llvm-project?rev=313192=rev Log: Mark static member functions as static in CodeViewDebug Summary: To improve CodeView quality for static member functions, we need to make the static explicit. In

Re: r279765 - Omit column info for CodeView by default

Sorry, no, I don't have plans to implement column ranges at this time. On Mon, Aug 29, 2016 at 2:10 PM, Adrian Prantl <apra...@apple.com> wrote: > > > On Aug 25, 2016, at 11:24 AM, Adrian McCarthy via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > >

Re: r279765 - Omit column info for CodeView by default

11:32 AM Adrian McCarthy via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: amccarth >> Date: Thu Aug 25 13:24:35 2016 >> New Revision: 279765 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=279765=rev >> Log: >> Omit colu

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

amccarth added inline comments. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:68 @@ +67,3 @@ +return Name_; +return ParentPath + "-" + Name_; +} OK, cool. I assumed that the root had a name. Thus a node with no

Re: [PATCH] D23720: Omit column info for CodeView by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL279765: Omit column info for CodeView by default (authored by amccarth). Changed prior to commit: https://reviews.llvm.org/D23720?vs=68713=69274#toc Repository: rL LLVM

r279765 - Omit column info for CodeView by default

Author: amccarth Date: Thu Aug 25 13:24:35 2016 New Revision: 279765 URL: http://llvm.org/viewvc/llvm-project?rev=279765=rev Log: Omit column info for CodeView by default Clang tracks only start columns, not start-end ranges. CodeView allows for that, but the VS debugger doesn't handle anything

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

amccarth added a comment. I don't know enough C# to review for language usage. I was mostly reading for understandability. Overall, I think this looks really nice. Comment at: clang-tidy-vs/ClangTidy/CheckTree.cs:67 @@ +66,3 @@ +if (ParentPath == null) +

[PATCH] D23720: Omit column info for CodeView by default

amccarth created this revision. amccarth added a subscriber: cfe-commits. Clang tracks only start columns, not start-end ranges. CodeView allows for that, but the VS debugger doesn't handle anything less than a complete range well--it either highlights the wrong part of a statement or

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth closed this revision. amccarth added a comment. Closed by r278861 https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r278861 - Emit debug info for dynamic classes if they are imported from a DLL.

Author: amccarth Date: Tue Aug 16 17:11:18 2016 New Revision: 278861 URL: http://llvm.org/viewvc/llvm-project?rev=278861=rev Log: Emit debug info for dynamic classes if they are imported from a DLL. With -debug-info-kind=limited, we omit debug info for dynamic classes that live in other TUs.

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1688-1689 @@ -1687,3 +1687,4 @@ - if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass()) + if (CXXDecl->hasDefinition() && CXXDecl->isDynamicClass() && + !CXXDecl->hasAttr()) return true;

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth updated this revision to Diff 68225. amccarth added a comment. Add comment as requested. https://reviews.llvm.org/D23462 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-dllimport-base-class.cpp Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth updated this revision to Diff 68114. amccarth added a comment. Added a test. https://reviews.llvm.org/D23462 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCXX/debug-info-dllimport-base-class.cpp Index: test/CodeGenCXX/debug-info-dllimport-base-class.cpp

Re: [PATCH] D23462: Emit debug info for dynamic classes if they are imported from a DLL

amccarth added a comment. Thank, dblaikie, for correcting my terminology. https://reviews.llvm.org/D23462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23462: Emit debug info for abstract classes if they are imported from a DLL

amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. With -debug-info-kind=limited, we omit debug info for abstract classes that live in other TUs. This reduces duplicate type information. When statically linked, the type information comes

r276317 - Reroll "Include unreferenced nested types in member list only for CodeView"

Author: amccarth Date: Thu Jul 21 13:43:20 2016 New Revision: 276317 URL: http://llvm.org/viewvc/llvm-project?rev=276317=rev Log: Reroll "Include unreferenced nested types in member list only for CodeView" Another attempt at r276271, hopefully without breaking ModuleDebugInfo test. Modified:

r276279 - Revert "Include unreferenced nested types in member list only for CodeView"

Author: amccarth Date: Thu Jul 21 08:41:25 2016 New Revision: 276279 URL: http://llvm.org/viewvc/llvm-project?rev=276279=rev Log: Revert "Include unreferenced nested types in member list only for CodeView" Patch broke ModuleDebugInfo test on the build bots (but not locally). Again. svn

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

amccarth marked 2 inline comments as done. amccarth added a comment. https://reviews.llvm.org/D22577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

amccarth updated this revision to Diff 64761. amccarth added a comment. Addressed feedback. https://reviews.llvm.org/D22577 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-dup-fwd-decl.cpp test/CodeGenCXX/debug-info-ms-abi.cpp

[PATCH] D22577: Include unreferenced nested types in member list only for CodeView

amccarth created this revision. amccarth added reviewers: rnk, dblaikie. amccarth added a subscriber: cfe-commits. Unreferenced nested structs and classes were omitted from the debug info. In DWARF, this was intentional, to avoid bloat. But, for CodeView, we want this information to be

Re: r274628 - Include debug info for nested structs and classes

> Under what conditions do nested types appear in the member list? (my > simple test case on a fresh clang didn't seem to produce anything about the > nested type: struct outer { struct inner { int i; }; int j; }; outer o; ) > > On Wed, Jul 6, 2016 at 7:46 AM, Adrian McCarthy via

r274706 - Revert "Retry "Include debug info for nested structs and classes""

Author: amccarth Date: Wed Jul 6 18:28:34 2016 New Revision: 274706 URL: http://llvm.org/viewvc/llvm-project?rev=274706=rev Log: Revert "Retry "Include debug info for nested structs and classes"" Reverting because it causes a test failure on build bots (Modules/ModuleDebugInfo.cpp). Failure

r274698 - Retry "Include debug info for nested structs and classes"

Author: amccarth Date: Wed Jul 6 17:39:15 2016 New Revision: 274698 URL: http://llvm.org/viewvc/llvm-project?rev=274698=rev Log: Retry "Include debug info for nested structs and classes" This should work now that the LLVM-side of the change has landed successfully. Original Differential

Re: r274633 - Revert "Include debug info for nested structs and classes"

Reverted because this depended upon an LLVM patch that was reverted because of test failures on the buildbots. I'm still investigating the root cause. SVN revision was rL274628. On Wed, Jul 6, 2016 at 8:15 AM, Adrian McCarthy via cfe-commits < cfe-commits@lists.llvm.org> wrote: &g

r274633 - Revert "Include debug info for nested structs and classes"

Author: amccarth Date: Wed Jul 6 10:15:38 2016 New Revision: 274633 URL: http://llvm.org/viewvc/llvm-project?rev=274633=rev Log: Revert "Include debug info for nested structs and classes" This reverts commit 0af5ee9631c7c167dc40498b415876553e314c95. Modified:

Re: [PATCH] D21705: Include debug info for nested structs and classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL274628: Include debug info for nested structs and classes (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D21705?vs=62283=62869#toc Repository: rL LLVM

Re: [PATCH] D21705: Include debug info for nested structs and classes

amccarth updated this revision to Diff 62283. amccarth added a comment. Applied suggestion from the comments, which eliminates the need to alter the ObjectiveC test. http://reviews.llvm.org/D21705 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h

Re: [PATCH] D21705: Include debug info for nested structs and classes

amccarth marked 2 inline comments as done. amccarth added a comment. http://reviews.llvm.org/D21705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21705: Include debug info for nested structs and classes

amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. This includes nested types in the member list, even if there are no members of that type. Note that structs and classes have themselves as an "implicit struct" as the first member, so we

Re: [PATCH] D21107: Generate codeview for array types

amccarth added inline comments. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); majnemer wrote: >

[PATCH] D21107: Generate codeview for array types

amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. Creates codeview type records for arrays and adds a simple test for one. http://reviews.llvm.org/D21107 Files: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

Re: [PATCH] D20454: Eliminate unnecessary file access checks in Clang driver on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL270226: Eliminate unnecessary file access checks in Clang driver on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D20454?vs=57872=57936#toc Repository: rL LLVM

r270226 - Eliminate unnecessary file access checks in Clang driver on Windows

Author: amccarth Date: Fri May 20 10:46:23 2016 New Revision: 270226 URL: http://llvm.org/viewvc/llvm-project?rev=270226=rev Log: Eliminate unnecessary file access checks in Clang driver on Windows Differential Revision: http://reviews.llvm.org/D20454 Modified:

[PATCH] D20454: Eliminate unnecessary file access checks in Clang driver on Windows

amccarth created this revision. amccarth added a reviewer: majnemer. amccarth added a subscriber: cfe-commits. This fixes the problem where the driver will look for cl.exe.exe while walking the PATH. I looked into changing the Windows implementation of llvm::sys::fs::can_execute(), but there

r269515 - Get default -fms-compatibility-version from cl.exe's version

Author: amccarth Date: Fri May 13 18:20:11 2016 New Revision: 269515 URL: http://llvm.org/viewvc/llvm-project?rev=269515=rev Log: Get default -fms-compatibility-version from cl.exe's version -fms-compatibility-version was defaulting to 18 (VS 2013), which is a pain if your environment is

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rL269515: Get default -fms-compatibility-version from cl.exe's version (authored by amccarth). Changed prior to commit:

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth marked an inline comment as done. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, majnemer wrote: > amccarth wrote: > > majnemer wrote:

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:481 @@ +480,3 @@ + + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize, majnemer wrote: > It might be nicer to use a

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth updated this revision to Diff 57196. amccarth marked an inline comment as done. amccarth added a comment. Addressed additional comments. http://reviews.llvm.org/D20136 Files: include/clang/Driver/ToolChain.h lib/Driver/MSVCToolChain.cpp lib/Driver/ToolChains.h

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth marked 2 inline comments as done. Comment at: lib/Driver/MSVCToolChain.cpp:42 @@ -40,1 +41,3 @@ + + #pragma comment(lib, "version.lib") #endif aaron.ballman wrote: > Eh, I am lightening up on this sort of thing, so this is fine by me. I was following

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added a comment. Are there any remaining concerns with this patch? Is everyone satisfied with the performance numbers? http://reviews.llvm.org/D20136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); amccarth wrote: > thakis wrote:

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); thakis wrote: > amccarth wrote:

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); amccarth wrote: > thakis wrote:

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); thakis wrote: > amccarth wrote:

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth marked 4 inline comments as done. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); Yes, it looks in the

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth updated this revision to Diff 56833. amccarth marked an inline comment as done. amccarth added a comment. Addressed most comments: now using wide-chars for WinAPI calls, made getMSVCVersionFromExe a virtual method, removed extraneous typo-correction. http://reviews.llvm.org/D20136

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:472 @@ +471,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeA(ClExe.c_str(), nullptr); + if (VersionSize == 0) { majnemer wrote: > Why not use the `GetFileVersionInfoSizeW`

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:477 @@ +476,3 @@ + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoA(ClExe.c_str(), 0, VersionSize, + VersionBlock.data())) { thakis wrote: >

r266887 - Add warning about CR+LF line endings on Windows.

Author: amccarth Date: Wed Apr 20 11:43:34 2016 New Revision: 266887 URL: http://llvm.org/viewvc/llvm-project?rev=266887=rev Log: Add warning about CR+LF line endings on Windows. s/checkout/check out/ when used as a verb. Differential Revision: http://reviews.llvm.org/D19285 Modified: