r316689 - Simplify codegen and debug info generation for block context parameters.

Author: adrian Date: Thu Oct 26 13:08:52 2017 New Revision: 316689 URL: http://llvm.org/viewvc/llvm-project?rev=316689&view=rev Log: Simplify codegen and debug info generation for block context parameters. The exisiting code goes out of its way to put block parameters into an alloca only at -O0,

r316686 - Revert "Simplify codegen and debug info generation for block context parameters."

Author: adrian Date: Thu Oct 26 11:32:16 2017 New Revision: 316686 URL: http://llvm.org/viewvc/llvm-project?rev=316686&view=rev Log: Revert "Simplify codegen and debug info generation for block context parameters." This reverts commit r316684 while investigating buildbot breakage. Added: cf

r316684 - Simplify codegen and debug info generation for block context parameters.

Author: adrian Date: Thu Oct 26 11:16:05 2017 New Revision: 316684 URL: http://llvm.org/viewvc/llvm-project?rev=316684&view=rev Log: Simplify codegen and debug info generation for block context parameters. The exisiting code goes out of its way to put block parameters into an alloca only at -O0,

r315392 - Include getting generated struct offsets in CodegenABITypes

Author: adrian Date: Tue Oct 10 16:54:21 2017 New Revision: 315392 URL: http://llvm.org/viewvc/llvm-project?rev=315392&view=rev Log: Include getting generated struct offsets in CodegenABITypes This change adds a new function, CodeGen::getFieldNumber, that enables a user of clang's code generation

r314700 - Add a testcase to check that debug info is upgraded when compiling LLVM IR

Author: adrian Date: Mon Oct 2 11:31:52 2017 New Revision: 314700 URL: http://llvm.org/viewvc/llvm-project?rev=314700&view=rev Log: Add a testcase to check that debug info is upgraded when compiling LLVM IR through clang. Added: cfe/trunk/test/CodeGen/verify-debuginfo.ll Added: cfe/trunk/te

Re: [PATCH] D37604: Disable debuginfo-tests for non-native configurations

> On Sep 8, 2017, at 11:43 AM, Adrian Prantl wrote: > > >> On Sep 8, 2017, at 10:54 AM, Paul Robinson via Phabricator >> wrote: >> >> probinson added a comment. >> >> In https://reviews.llvm.org/D37604#864187, @aprantl wrote: >> >>> This seems reasonable to me, thanks! >>> When you commit

Re: [PATCH] D37604: Disable debuginfo-tests for non-native configurations

> On Sep 8, 2017, at 10:54 AM, Paul Robinson via Phabricator > wrote: > > probinson added a comment. > > In https://reviews.llvm.org/D37604#864187, @aprantl wrote: > >> This seems reasonable to me, thanks! >> When you commit this, could you please double-check that the tests are still >> run

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

On Aug 28, 2017, at 4:43 PM, David Blaikie wrote: >> >> Seems like a rather complex test case - could you explain what's going on >> there? (maybe in the form of a comment in the code - what path through all >> those classes is required to tickle this) >> >

r312175 - Test-case golfing.

Author: adrian Date: Wed Aug 30 14:31:16 2017 New Revision: 312175 URL: http://llvm.org/viewvc/llvm-project?rev=312175&view=rev Log: Test-case golfing. Modified: cfe/trunk/test/CodeGenCXX/debug-info-inlined.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-inlined.cpp URL: http://llvm.org/

r312148 - Adapt testcases to LLVM change r312144 in DIGlobalVariableExpression

Author: adrian Date: Wed Aug 30 11:22:23 2017 New Revision: 312148 URL: http://llvm.org/viewvc/llvm-project?rev=312148&view=rev Log: Adapt testcases to LLVM change r312144 in DIGlobalVariableExpression Modified: cfe/trunk/test/CodeGen/2009-10-20-GlobalDebug.c cfe/trunk/test/CodeGen/debug-

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

David Blaikie wrote: > > Seems like a rather complex test case - could you explain what's going on > there? (maybe in the form of a comment in the code - what path through all > those classes is required to tickle this) > > On Wed, Aug 23, 2017 at 2:25 PM Adrian Prantl v

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

I temporarily reverted the commit in r311680 to get the bots going again. -- adrian > On Aug 24, 2017, at 11:12 AM, Adrian Prantl via cfe-commits > wrote: > > It looks like this broke / found errors on the green dragon bot: > > http://green.lab.llvm.org/green/job/

r311680 - Revert "[ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this'

Author: adrian Date: Thu Aug 24 11:18:24 2017 New Revision: 311680 URL: http://llvm.org/viewvc/llvm-project?rev=311680&view=rev Log: Revert "[ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

It looks like this broke / found errors on the green dragon bot: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4115/consoleFull#15752874848254eaf0-7326-4999-85b0-388101f2d404 TEST 'LLVM-Unit :: ADT/./ADTTests/FilterIteratorTest.FunctionPointer' FAILED **

r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

Author: adrian Date: Wed Aug 23 14:24:12 2017 New Revision: 311601 URL: http://llvm.org/viewvc/llvm-project?rev=311601&view=rev Log: Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be parented in function declarations. Fixes PR33997. https://bugs.llvm.org/show_bug.cgi?id=

Re: r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

Great. Thanks! -- adrian > On Aug 22, 2017, at 3:11 PM, Dan Albert wrote: > > r311488 was submitted moments later and should fix this (one of the other > buildbots caught this really quickly). > > On Tue, Aug 22, 2017 at 3:09 PM, Adrian Prantl > wrote: > > > On Aug

Re: r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

> On Aug 22, 2017, at 2:05 PM, Dan Albert via cfe-commits > wrote: > > Author: danalbert > Date: Tue Aug 22 14:05:01 2017 > New Revision: 311487 > > URL: http://llvm.org/viewvc/llvm-project?rev=311487&view=rev > Log: > Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for > non-Li

r310147 - Debug Info: Set the DICompileUnit's isOptimized flag when compiling with LTO.

Author: adrian Date: Fri Aug 4 16:08:57 2017 New Revision: 310147 URL: http://llvm.org/viewvc/llvm-project?rev=310147&view=rev Log: Debug Info: Set the DICompileUnit's isOptimized flag when compiling with LTO. rdar://problem/27640939 Added: cfe/trunk/test/CodeGen/debug-info-lto.c Modified:

r309427 - Adopt to LLVM API change (llvm.dbg.value no longer has an offset)

Author: adrian Date: Fri Jul 28 13:21:08 2017 New Revision: 309427 URL: http://llvm.org/viewvc/llvm-project?rev=309427&view=rev Log: Adopt to LLVM API change (llvm.dbg.value no longer has an offset) Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/test/CodeGenObjC/debug-info-bloc

r308938 - Debug Info: Avoid completing class types when a definition is in a module.

Author: adrian Date: Mon Jul 24 16:48:51 2017 New Revision: 308938 URL: http://llvm.org/viewvc/llvm-project?rev=308938&view=rev Log: Debug Info: Avoid completing class types when a definition is in a module. This patch adds an early exit to CGDebugInfo::completeClassData() when compiling with -gm

Re: [PATCH v3] [PPC64]: Add support for Swift calling convention

> On Jun 21, 2017, at 11:32 PM, Andrew Jeffery wrote: > > For the tests I've extracted the int5 and int8 cases to cater for > different alignments for different platform ABIs. For Linux on POWER the > 5 and 8 element vectors must be naturally aligned with respect to the > total "soft" vector siz

r308399 - Update for LLVM IR metadata changes (DIImportedEntity now needs a DIFile).

Author: adrian Date: Tue Jul 18 17:09:58 2017 New Revision: 308399 URL: http://llvm.org/viewvc/llvm-project?rev=308399&view=rev Log: Update for LLVM IR metadata changes (DIImportedEntity now needs a DIFile). https://bugs.llvm.org/show_bug.cgi?id=33822 Differential Revision: https://reviews.llvm

r308397 - Debug Info: Set the MainFileName when generating -gmodules debug info for PCM.

Author: adrian Date: Tue Jul 18 16:58:34 2017 New Revision: 308397 URL: http://llvm.org/viewvc/llvm-project?rev=308397&view=rev Log: Debug Info: Set the MainFileName when generating -gmodules debug info for PCM. Previously it was uninitialized and thus always defaulted to "". This is mostly a cos

r303222 - Fix scope of namespaced DISubprograms when the function definition is out-of-line.

Author: adrian Date: Tue May 16 18:46:10 2017 New Revision: 303222 URL: http://llvm.org/viewvc/llvm-project?rev=303222&view=rev Log: Fix scope of namespaced DISubprograms when the function definition is out-of-line. This fixes a regression introduced in r302915. Using the lexical decl context is

Re: r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

> On May 11, 2017, at 5:05 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On May 11, 2017, at 4:43 PM, Richard Smith wrote: >> >> I don't think that's quite right; the AST doesn't merge NamespaceDecls. It >> looks like the i

r302915 - Simplify DINamespace caching in CGDebugInfo

Author: adrian Date: Fri May 12 11:23:53 2017 New Revision: 302915 URL: http://llvm.org/viewvc/llvm-project?rev=302915&view=rev Log: Simplify DINamespace caching in CGDebugInfo This addresses review feedback from r302840. By not canonicalizing namespace decls and using lexical decl context inste

Re: r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

> On May 11, 2017, at 4:43 PM, Richard Smith wrote: > > On 11 May 2017 at 15:59, Adrian Prantl via cfe-commits > wrote: > Author: adrian > Date: Thu May 11 17:59:19 2017 > New Revision: 302840 > > URL: http://llvm.org/viewvc/llvm-project?rev=302840&view=rev &

r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

Author: adrian Date: Thu May 11 17:59:19 2017 New Revision: 302840 URL: http://llvm.org/viewvc/llvm-project?rev=302840&view=rev Log: Module Debug Info: Emit namespaced C++ forward decls in the correct module. The AST merges NamespaceDecls, but for module debug info it is important to put a namesp

r302809 - Add a test that local submodule visibility has no effect on debug info

Author: adrian Date: Thu May 11 11:40:48 2017 New Revision: 302809 URL: http://llvm.org/viewvc/llvm-project?rev=302809&view=rev Log: Add a test that local submodule visibility has no effect on debug info rdar://problem/27876262 Modified: cfe/trunk/test/Modules/DebugInfoSubmoduleImport.c Mod

Re: [PATCH v2] [PPC64]: Add support for Swift calling convention

Thanks, with the testcase this LGTM! -- adrian > On May 11, 2017, at 12:07 AM, Andrew Jeffery wrote: > > Ping - does anyone have a moment to take a look? > > Cheers, > > Andrew > > On Thu, 2017-04-27 at 13:52 +0930, Andrew Jeffery wrote: >> For the tests I've extracted the int5 and int8 cases

r302740 - Partially revert r302685 and swith Apple-style full LTO builds to

Author: adrian Date: Wed May 10 17:14:23 2017 New Revision: 302740 URL: http://llvm.org/viewvc/llvm-project?rev=302740&view=rev Log: Partially revert r302685 and swith Apple-style full LTO builds to -gline-tables-only. The memory consumption is apparently still too much for some of the green drago

r302685 - Build the Apple-style stage2 with full debug info

Author: adrian Date: Wed May 10 10:58:22 2017 New Revision: 302685 URL: http://llvm.org/viewvc/llvm-project?rev=302685&view=rev Log: Build the Apple-style stage2 with full debug info Green dragon had a green stage2 modules bot for a long time now[1] and it is time to retire it and make a modules

r302577 - Update testcase for upstream LLVM changes (r302469).

Author: adrian Date: Tue May 9 14:47:41 2017 New Revision: 302577 URL: http://llvm.org/viewvc/llvm-project?rev=302577&view=rev Log: Update testcase for upstream LLVM changes (r302469). Modified: cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp Modified: cfe/trunk/test/CodeGenCXX/lin

r302556 - Build the Apple-style stage2 with modules

Author: adrian Date: Tue May 9 12:27:03 2017 New Revision: 302556 URL: http://llvm.org/viewvc/llvm-project?rev=302556&view=rev Log: Build the Apple-style stage2 with modules Green dragon had a green stage2 modules bot for a long time now[1] and it is time to retire it and make a modules build th

r302476 - Update testcase for upstream LLVM changes.

Author: adrian Date: Mon May 8 17:44:00 2017 New Revision: 302476 URL: http://llvm.org/viewvc/llvm-project?rev=302476&view=rev Log: Update testcase for upstream LLVM changes. Modified: cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp Modified: cfe/trunk/test/CodeGenCXX/linetable-vir

r301805 - Relax testcase to fix a PS4 buildbot failure.

Author: adrian Date: Mon May 1 10:49:40 2017 New Revision: 301805 URL: http://llvm.org/viewvc/llvm-project?rev=301805&view=rev Log: Relax testcase to fix a PS4 buildbot failure. Modified: cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-names

Re: r301707 - Adapt to LLVM API change (DINamespace no longer takes line/file info).

tches seems to have one extra import on the > PS4 target. Can you take a look? > > Douglas Yung > >> -Original Message- >> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of >> Adrian Prantl via cfe-commits >> Sent: Friday,

r301707 - Adapt to LLVM API change (DINamespace no longer takes line/file info).

Author: adrian Date: Fri Apr 28 17:25:53 2017 New Revision: 301707 URL: http://llvm.org/viewvc/llvm-project?rev=301707&view=rev Log: Adapt to LLVM API change (DINamespace no longer takes line/file info). rdar://problem/17484998 https://reviews.llvm.org/D32648 Modified: cfe/trunk/lib/CodeGen/

r300523 - Debug Info: Remove special-casing of indirect function argument handling.

Author: adrian Date: Mon Apr 17 20:22:01 2017 New Revision: 300523 URL: http://llvm.org/viewvc/llvm-project?rev=300523&view=rev Log: Debug Info: Remove special-casing of indirect function argument handling. LLVM has changed the semantics of dbg.declare for describing function arguments. After thi

Re: [PATCH] [PPC64]: Add support for Swift calling convention

Is it possible to add a testcase for this? -- adrian > On Mar 22, 2017, at 5:00 AM, Andrew Jeffery via cfe-commits > wrote: > > Signed-off-by: Andrew Jeffery > --- > lib/Basic/Targets.cpp | 11 +++ > lib/CodeGen/TargetInfo.cpp | 14 -- > 2 files changed, 23 insertions(

Re: r298913 - Added `applyAtomicChanges` function.

Note that the green dragon bot doesn't use local submodule visibility, so every #include pulls in the entire clang module that header belongs to. Does this explain what you are seeing? (You should be able to reproduce with cmake -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=0) -- adrian > On Mar 30

r297791 - Make a blind attempt to fix this testcase on Windows.

Author: adrian Date: Tue Mar 14 18:29:40 2017 New Revision: 297791 URL: http://llvm.org/viewvc/llvm-project?rev=297791&view=rev Log: Make a blind attempt to fix this testcase on Windows. Modified: cfe/trunk/test/Modules/modules-cache-path-canonicalization.m Modified: cfe/trunk/test/Modules/m

r297790 - Canonicalize the path provided by -fmodules-cache-path.

Author: adrian Date: Tue Mar 14 18:07:49 2017 New Revision: 297790 URL: http://llvm.org/viewvc/llvm-project?rev=297790&view=rev Log: Canonicalize the path provided by -fmodules-cache-path. This fixes lookup mismatches that could happen when the module cache path contained a '/./' component. Di

r297162 - Revert "Document that code inlined into a nodebug function also won't get any"

Author: adrian Date: Tue Mar 7 11:28:56 2017 New Revision: 297162 URL: http://llvm.org/viewvc/llvm-project?rev=297162&view=rev Log: Revert "Document that code inlined into a nodebug function also won't get any" This reverts commit r296776. This statement is no longer true. Modified: cfe/tru

Re: [libcxx] r296840 - Work around test failure on 32 bit OS X

Does that mean there is a bug in libcxx that should be documented somewhere? -- adrian > On Mar 2, 2017, at 3:18 PM, Eric Fiselier via cfe-commits > wrote: > > Author: ericwf > Date: Thu Mar 2 17:18:40 2017 > New Revision: 296840 > > URL: http://llvm.org/viewvc/llvm-project?rev=296840&view=re

r296776 - Document that code inlined into a nodebug function also won't get any

Author: adrian Date: Thu Mar 2 12:06:51 2017 New Revision: 296776 URL: http://llvm.org/viewvc/llvm-project?rev=296776&view=rev Log: Document that code inlined into a nodebug function also won't get any debug info. Suggested by Paul Robinson in feedback on r296488, thanks! Modified: cfe/trun

r296388 - PR32042: Create inlined debug info for EmitInlinedInheritingCXXConstructorCall.

Author: adrian Date: Mon Feb 27 15:30:05 2017 New Revision: 296388 URL: http://llvm.org/viewvc/llvm-project?rev=296388&view=rev Log: PR32042: Create inlined debug info for EmitInlinedInheritingCXXConstructorCall. When clang emits an inheriting C++ constructor it may inline code during the CodeGen

Re: [PATCH] D16135: Macro Debug Info support in Clang

> On Feb 8, 2017, at 2:31 PM, David Blaikie wrote: > > > > On Wed, Feb 8, 2017 at 2:25 PM Amjad Aboud via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > aaboud added a comment. > > > How much does the build directory grow? > > Is there any noticeable compile time regression? > >

r290155 - Update for LLVM global variable debug info API change.

Author: adrian Date: Mon Dec 19 20:10:02 2016 New Revision: 290155 URL: http://llvm.org/viewvc/llvm-project?rev=290155&view=rev Log: Update for LLVM global variable debug info API change. This reapplies r289921. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebu

Re: r289996 - IRGen: Fix assertion failure when creating debug info for an integer constant wider than 64 bits.

> On Dec 16, 2016, at 2:10 PM, Peter Collingbourne via cfe-commits > wrote: > > Author: pcc > Date: Fri Dec 16 16:10:52 2016 > New Revision: 289996 > > URL: http://llvm.org/viewvc/llvm-project?rev=289996&view=rev > Log: > IRGen: Fix assertion failure when creating debug info for an integer con

r289984 - Revert "Update for LLVM global variable debug info API change."

Author: adrian Date: Fri Dec 16 13:39:18 2016 New Revision: 289984 URL: http://llvm.org/viewvc/llvm-project?rev=289984&view=rev Log: Revert "Update for LLVM global variable debug info API change." This reverts commit r289921. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/

r289921 - Update for LLVM global variable debug info API change.

Author: adrian Date: Thu Dec 15 22:26:15 2016 New Revision: 289921 URL: http://llvm.org/viewvc/llvm-project?rev=289921&view=rev Log: Update for LLVM global variable debug info API change. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h cfe/trunk/tes

r289908 - Revert "Update for LLVM global variable debug info API change."

Author: adrian Date: Thu Dec 15 19:01:40 2016 New Revision: 289908 URL: http://llvm.org/viewvc/llvm-project?rev=289908&view=rev Log: Revert "Update for LLVM global variable debug info API change." This reverts commit 289901 while investigating bot breakage. Modified: cfe/trunk/lib/CodeGen/CG

r289901 - Update for LLVM global variable debug info API change.

Author: adrian Date: Thu Dec 15 18:35:42 2016 New Revision: 289901 URL: http://llvm.org/viewvc/llvm-project?rev=289901&view=rev Log: Update for LLVM global variable debug info API change. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h cfe/trunk/tes

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

> On Dec 8, 2016, at 7:31 PM, Duncan P. N. Exon Smith > wrote: > > >> On 2016-Dec-08, at 19:29, Richard Smith wrote: >> >> On 8 Dec 2016 7:17 pm, "Duncan P. N. Exon Smith via cfe-commits" >> wrote: >> +Eric, Marshall >> >> I haven't looked, but: from the test name, "copy.fail.cpp", I susp

Re: r288866 - [c++17] P0135R1: Guaranteed copy elision.

Hi Richard, at this point this is more a heads-up than anything actionable, but I wanted to let you know that I bisected this bot failure (http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2721/consoleFull#10584592348254eaf0-7326-4999-85b0-388101f2d404) of std/input.output/strea

r287141 - Relax testcase.

Author: adrian Date: Wed Nov 16 13:31:44 2016 New Revision: 287141 URL: http://llvm.org/viewvc/llvm-project?rev=287141&view=rev Log: Relax testcase. This removes checks that are irrelevant for what is being tested. Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk-msabi.cpp Modified: cfe/

r287139 - Add the missing FileCheck invocation to this testcase.

Author: adrian Date: Wed Nov 16 13:26:11 2016 New Revision: 287139 URL: http://llvm.org/viewvc/llvm-project?rev=287139&view=rev Log: Add the missing FileCheck invocation to this testcase. Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk-msabi.cpp Modified: cfe/trunk/test/CodeGenCXX/debug

r287134 - Fix PR31029 by attaching an artificial debug location to msabi thunks.

Author: adrian Date: Wed Nov 16 12:49:47 2016 New Revision: 287134 URL: http://llvm.org/viewvc/llvm-project?rev=287134&view=rev Log: Fix PR31029 by attaching an artificial debug location to msabi thunks. This was a latent bug that was recently uncovered by r286400. Added: cfe/trunk/test/CodeG

Re: r285625 - DebugInfo: support for DW_TAG_atomic_type

Ping. > On Nov 2, 2016, at 9:18 AM, Adrian Prantl wrote: > > Ping? > >> On Oct 31, 2016, at 12:41 PM, Adrian Prantl via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >>> >>> On Oct 31, 2016, at 12:09 PM, Victor Leschuk

r286412 - Remove extra whitespace

Author: adrian Date: Wed Nov 9 17:10:44 2016 New Revision: 286412 URL: http://llvm.org/viewvc/llvm-project?rev=286412&view=rev Log: Remove extra whitespace Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp URL: http://llvm.org

r286411 - Relax testcase so it also works on Windows.

Author: adrian Date: Wed Nov 9 17:05:16 2016 New Revision: 286411 URL: http://llvm.org/viewvc/llvm-project?rev=286411&view=rev Log: Relax testcase so it also works on Windows. Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-thunk.cpp U

r286400 - Use an artificial debug location for non-virtual thunks.

Author: adrian Date: Wed Nov 9 15:43:51 2016 New Revision: 286400 URL: http://llvm.org/viewvc/llvm-project?rev=286400&view=rev Log: Use an artificial debug location for non-virtual thunks. Thunks are artificial and have no corresponding source location except for the line number on the DISubprogr

r286322 - Emit debug info for global constants whose address is taken exactly once.

Author: adrian Date: Tue Nov 8 18:42:03 2016 New Revision: 286322 URL: http://llvm.org/viewvc/llvm-project?rev=286322&view=rev Log: Emit debug info for global constants whose address is taken exactly once. Add a check to the DeclCache before emitting debug info for a GlobalVariable a second time

r285960 - Add debug info support for C++11 inline namespaces.

Author: adrian Date: Thu Nov 3 14:42:14 2016 New Revision: 285960 URL: http://llvm.org/viewvc/llvm-project?rev=285960&view=rev Log: Add debug info support for C++11 inline namespaces. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp Mo

Re: r285625 - DebugInfo: support for DW_TAG_atomic_type

Ping? > On Oct 31, 2016, at 12:41 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On Oct 31, 2016, at 12:09 PM, Victor Leschuk via cfe-commits >> wrote: >> >> Author: vleschuk >> Date: Mon Oct 31 14:09:47 2016 >> New Revision: 285625

Re: r285625 - DebugInfo: support for DW_TAG_atomic_type

> On Oct 31, 2016, at 12:09 PM, Victor Leschuk via cfe-commits > wrote: > > Author: vleschuk > Date: Mon Oct 31 14:09:47 2016 > New Revision: 285625 > > URL: http://llvm.org/viewvc/llvm-project?rev=285625&view=rev > Log: > DebugInfo: support for DW_TAG_atomic_type > > Mark C11 _Atomic variabl

[PATCH] D26145: DebugInfo: support for DW_TAG_atomic_type

aprantl added a comment. One more inline comment. Comment at: test/CodeGen/debug-info-atomic.c:4 +// CHECK: !DIGlobalVariable(name: "i"{{.*}}type: !5, isLocal: false, isDefinition: true) +// CHECK: !5 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !6) +// CHECK: !6 = !DIDe

[PATCH] D26145: DebugInfo: support for DW_TAG_atomic_type

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with inline comments addressed. Comment at: test/CodeGen/debug-info-atomic.c:3 + +// CHECK: !DIDerivedType(tag: DW_TAG_const_type +// CHECK: !DIDerivedType(tag: DW_TAG

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499 case Type::Adjusted: - case Type::Decayed: + case Type::Decayed: { // Decayed and adjusted types use the adjusted type in LLVM and DWARF. -return CreateType( -cast(cast(Ty)->get

[PATCH] D25621: DebugInfo: use uin32_t for alignment

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, this LGTM! https://reviews.llvm.org/D25621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D25621: DebugInfo: use uin32_t for alignment

aprantl added a comment. This patch is conflating two set of changes: (1) NFC: rename all occurrences of unsigned for alignment purposes in the frontend with uint32_t (2) shrink all debug-info-related alignment variables from uint64_t -> unint32_t. I think this patch should only be doing the ch

r284423 - Explicitly pass an isysroot to avoid the SDKROOT overriding the deployment target.

Author: adrian Date: Mon Oct 17 15:37:56 2016 New Revision: 284423 URL: http://llvm.org/viewvc/llvm-project?rev=284423&view=rev Log: Explicitly pass an isysroot to avoid the SDKROOT overriding the deployment target. This fixes the green dragon builders after r284416. Modified: cfe/trunk/test

Re: r284416 - Driver/Darwin: Set the DWARF version based on the deployment target.

s.llvm.org] On Behalf Of >> Adrian Prantl via cfe-commits >> Sent: Monday, October 17, 2016 12:36 PM >> To: cfe-commits@lists.llvm.org >> Subject: r284416 - Driver/Darwin: Set the DWARF version based on the >> deployment target. >> >> Author: adrian >>

r284420 - Improve the CHECK lines in debug-options.c by separating out the check

Author: adrian Date: Mon Oct 17 15:14:23 2016 New Revision: 284420 URL: http://llvm.org/viewvc/llvm-project?rev=284420&view=rev Log: Improve the CHECK lines in debug-options.c by separating out the check for debug info kind and dwarf version. Modified: cfe/trunk/test/Driver/debug-options.c M

r284417 - Update testcase for r284416.

Author: adrian Date: Mon Oct 17 14:46:26 2016 New Revision: 284417 URL: http://llvm.org/viewvc/llvm-project?rev=284417&view=rev Log: Update testcase for r284416. Modified: cfe/trunk/test/CodeGen/dwarf-version.c Modified: cfe/trunk/test/CodeGen/dwarf-version.c URL: http://llvm.org/viewvc/llv

r284416 - Driver/Darwin: Set the DWARF version based on the deployment target.

Author: adrian Date: Mon Oct 17 14:36:18 2016 New Revision: 284416 URL: http://llvm.org/viewvc/llvm-project?rev=284416&view=rev Log: Driver/Darwin: Set the DWARF version based on the deployment target. System utilities such as atos only support DWARF 4 on OS X 10.11+ and iOS 9+. We thus want to e

r284400 - Fix a typo.

Author: adrian Date: Mon Oct 17 12:41:51 2016 New Revision: 284400 URL: http://llvm.org/viewvc/llvm-project?rev=284400&view=rev Log: Fix a typo. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/To

[PATCH] D25621: DebugInfo: use DIAlignment type.

aprantl added inline comments. Comment at: include/clang/AST/ASTContext.h:83 uint64_t Width; -unsigned Align; +llvm::DIAlignment Align; bool AlignIsRequired : 1; I'm not sure we want to use a debug info type inside the AST. I think we only want

r283810 - [Driver] Let -gline-tables-only win when it comes after -gmodules.

Author: adrian Date: Mon Oct 10 16:56:20 2016 New Revision: 283810 URL: http://llvm.org/viewvc/llvm-project?rev=283810&view=rev Log: [Driver] Let -gline-tables-only win when it comes after -gmodules. The -gmodules option is all about putting debug type info into clang modules and for line tables t

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

aprantl accepted this revision. aprantl added a reviewer: aprantl. aprantl added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rL LLVM https://reviews.llvm.org/D25321 ___ cfe-commits mailing list cfe-commit

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

aprantl added inline comments. > ReachableCode.cpp:64 > +const FunctionDecl *FDecl = dyn_cast(DRE->getDecl()); > +return FDecl && FDecl->getIdentifier() && > + FDecl->getBuiltinID() == Builtin::BI__builtin_unreachable; Maybe also wrap the inner dyn_cast in an if for symmetry?

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Can you double-check that the memory layout is actually what we think it is by inspecting the generated IR? Otherwise this LGTM. https://reviews.llvm.org/D7 _

[PATCH] D22227: [ubsan] Disable bounds-check for flexible array ivars

aprantl added a comment. Not knowing the specifics of the ObjC class layout: Does this work correctly with private ivars (i.e.: Does this need an extra check that there are no extra ivars in a later @implementation)? https://reviews.llvm.org/D7 __

Re: [PATCH] D24820: Add -stats-stats option

aprantl added a comment. Awesome. Sorry! Repository: rL LLVM https://reviews.llvm.org/D24820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24820: Add -stats-file option

aprantl added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:111 @@ -110,1 +110,3 @@ +def warn_fe_unable_to_open_stats_file : Warning< +"unable to open statistic output file '%0': '%1'">; def err_fe_no_pch_in_dir : Error< statstic

Re: [PATCH] D24426: DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:979 @@ -978,4 +978,3 @@ llvm::DIType * -CGDebugInfo::createFieldType(StringRef name, QualType type, SourceLocation loc, - AccessSpecifier AS, uint64_t offsetInBits, -

r281094 - Debug info: Bump the default DWARF version on Darwin to 4.

Author: adrian Date: Fri Sep 9 16:10:35 2016 New Revision: 281094 URL: http://llvm.org/viewvc/llvm-project?rev=281094&view=rev Log: Debug info: Bump the default DWARF version on Darwin to 4. This is a spiritual re-commit of r201375 with only a brief delay for upgrading the green dragon builders.

Re: r279765 - Omit column info for CodeView by default

> On Aug 25, 2016, at 11:24 AM, Adrian McCarthy via cfe-commits > wrote: > > Author: amccarth > Date: Thu Aug 25 13:24:35 2016 > New Revision: 279765 > > URL: http://llvm.org/viewvc/llvm-project?rev=279765&view=rev > Log: > Omit column info for CodeView by default > > Clang tracks only start

r280009 - Fix a bug preventing the cause of a module-out-of-date error from being printed

Author: adrian Date: Mon Aug 29 15:46:56 2016 New Revision: 280009 URL: http://llvm.org/viewvc/llvm-project?rev=280009&view=rev Log: Fix a bug preventing the cause of a module-out-of-date error from being printed Modified: cfe/trunk/lib/Serialization/ASTReader.cpp cfe/trunk/test/Modules/e

r280010 - Fix a bug preventing the cause for a module file-not-found from being displayed

Author: adrian Date: Mon Aug 29 15:46:59 2016 New Revision: 280010 URL: http://llvm.org/viewvc/llvm-project?rev=280010&view=rev Log: Fix a bug preventing the cause for a module file-not-found from being displayed Modified: cfe/trunk/lib/Serialization/ASTReader.cpp cfe/trunk/test/Modules/e

Re: r279485 - Module debug info: Don't assert when encountering an incomplete definition

ind an assertion. (put another way: "we expect > something specific to happen, not just for clang not to assert/crash") > > On Mon, Aug 22, 2016 at 3:32 PM Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: adrian > Date: Mon Au

r279490 - Add comments. NFC

Author: adrian Date: Mon Aug 22 17:38:16 2016 New Revision: 279490 URL: http://llvm.org/viewvc/llvm-project?rev=279490&view=rev Log: Add comments. NFC Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe

r279491 - Typo.

Author: adrian Date: Mon Aug 22 17:38:18 2016 New Revision: 279491 URL: http://llvm.org/viewvc/llvm-project?rev=279491&view=rev Log: Typo. Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp Modified: cfe/trunk/test/Modules/ExtDebugInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/t

r279489 - Add the second half of the testcase I should have added in 279485.

Author: adrian Date: Mon Aug 22 17:30:34 2016 New Revision: 279489 URL: http://llvm.org/viewvc/llvm-project?rev=279489&view=rev Log: Add the second half of the testcase I should have added in 279485. Added: cfe/trunk/test/Modules/ModuleModuleDebugInfo.cpp Added: cfe/trunk/test/Modules/Module

Re: r267464 - Module Debugging: Fix the condition for determining whether a template

> On Apr 26, 2016, at 4:11 PM, Richard Smith wrote: > > On Tue, Apr 26, 2016 at 3:10 PM, Adrian Prantl via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Apr 25, 2016, at 5:34 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote:

r279485 - Module debug info: Don't assert when encountering an incomplete definition

Author: adrian Date: Mon Aug 22 17:23:58 2016 New Revision: 279485 URL: http://llvm.org/viewvc/llvm-project?rev=279485&view=rev Log: Module debug info: Don't assert when encountering an incomplete definition in isDefinedInClangModule() and assume that the incomplete definition is not defined in th

r279004 - Support object-file-wrapped modules in clang -module-file-info.

Author: adrian Date: Wed Aug 17 18:13:53 2016 New Revision: 279004 URL: http://llvm.org/viewvc/llvm-project?rev=279004&view=rev Log: Support object-file-wrapped modules in clang -module-file-info. rdar://problem/24504815 Modified: cfe/trunk/include/clang/Frontend/FrontendActions.h cfe/tr

r279005 - Print the module format in clang -module-file-info.

Author: adrian Date: Wed Aug 17 18:14:00 2016 New Revision: 279005 URL: http://llvm.org/viewvc/llvm-project?rev=279005&view=rev Log: Print the module format in clang -module-file-info. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp cfe/trunk/test/Modules/module_file_info.m Modified

r278952 - Module debug info: Fix a bug in handling record decls without fields.

Author: adrian Date: Wed Aug 17 13:27:24 2016 New Revision: 278952 URL: http://llvm.org/viewvc/llvm-project?rev=278952&view=rev Log: Module debug info: Fix a bug in handling record decls without fields. The previous condition would erroneously mark all CXXRecordDecls that didn't have any fields a

<    1   2   3   4   5   6   >