[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d9ccd7a9693: [OpenMP] Migrate dispatch related utility functions from Clang codegen to… (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

TIFitis updated this revision to Diff 550729. TIFitis added a comment. Updated test with correct function attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157994/new/ https://reviews.llvm.org/D157994 Files:

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:532 MemoryAttr(MemoryEffects::argMemOnly() | MemoryEffects::inaccessibleMemOnly(ModRefInfo::Ref))) -: AttributeSet(EnumAttr(NoUnwind))) __OMP_ATTRS_SET(

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, jdoerfert, raghavendhra. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald

[PATCH] D152554: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG227012cbd71f: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github

[PATCH] D152554: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152554: [OpenMP] Migrate device code privatisation from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 537680. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d8d71817119: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:1444 +/// alloca address where the runtime returns the device pointers. +llvm::DenseMap CaptureDeviceAddrMap; }; jdoerfert wrote: > If it is an alloca (for sure) use

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 536226. TIFitis marked 4 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files:

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 536216. TIFitis added a comment. Rebased to fix build error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10395-10399 +if (CGF.ConstantFoldsToSimpleInteger(IfCond, CondConstant)) { + IfCondVal = CGF.Builder.getInt1(CondConstant); +} else { + IfCondVal = CGF.EvaluateExprAsBool(IfCond);

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 535455. TIFitis marked an inline comment as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files:

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added a comment. Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 533619. TIFitis added a comment. Moved device clause emition after if clause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files:

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10399 +DeviceID = CGF.Builder.getInt64(OMP_DEVICEID_UNDEF); + } jdoerfert wrote: > Move this behind the if generation and guard the emit scalar with a > conditional, all is

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa032dc139dda: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 531761. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1487 + // possible, or else at the end of the function. + void emitBlock(BasicBlock *BB, Function *CurFn, bool IsFinished = false); + jdoerfert wrote: > jdoerfert

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 531760. TIFitis marked 3 inline comments as done. TIFitis added a comment. Addressed reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 531401. TIFitis added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 531395. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 530865. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4741 + if (IsFinished && BB->use_empty()) { +delete BB; +return; jdoerfert wrote: > you should not just delete BB. eraseFromParent is a better way. That said, it > is

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530680. TIFitis added a comment. Update MLIR BodyGen callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530671. TIFitis marked 6 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis updated this revision to Diff 530548. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152554/new/ https://reviews.llvm.org/D152554 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 530533. TIFitis marked an inline comment as done. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files:

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4727 + Builder.ClearInsertionPoint(); +} + jdoerfert wrote: > This function doesn't make sense to me. For one, I don't know what a "unreal > block" is. Nor would I have

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 530518. TIFitis marked 5 inline comments as done and an inline comment as not done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3401a5f7584a: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and… (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 530508. TIFitis marked 4 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files:

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7170-7234 +const llvm::Value *DevPtr = nullptr; // In order to identify the right initializer we need to match the // declaration used by the mapping logic. In some cases we may get

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, jdoerfert, kiranktp. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1.

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:355-356 // Region 00 +// CK2-DAG: [[DEV:%[^,]+]] = sext i32 [[DEVi32:%[^,]+]] to i64 +// CK2-DAG: [[DEVi32]] = load i32, ptr %{{[^,]+}}, // CK2: br i1

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 527931. TIFitis marked 2 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files:

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

TIFitis accepted this revision. TIFitis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

TIFitis added inline comments. Comment at: flang/lib/Lower/OpenMP.cpp:2552 + +void handleDeclareTarget(Fortran::lower::AbstractConverter , + Fortran::lower::pft::Evaluation , This seems to be the only function name with the 'handle'

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis marked 2 inline comments as not done. TIFitis added a comment. Ping for reviews :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 ___ cfe-commits

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 524333. TIFitis added a comment. Renamed from processMapOp to genMapInfos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis updated this revision to Diff 524310. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 524301. TIFitis added a comment. Moved map processing code from functor to new static function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:67-68 - // CK1-DAG: call void @__tgt_target_data_end_mapper(ptr @{{.+}}, i64 [[DEV:%[^,]+]], i32 1, ptr [[GEPBP:%.+]], ptr [[GEPP:%.+]], ptr [[SIZE00]], ptr [[MTYPE00]], ptr null, ptr null) -

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 523340. TIFitis added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, dpalermo, kiranktp, jdoerfert. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr,

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523331. TIFitis added a comment. Try to fix patch application. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523318. TIFitis added a comment. Fix lint messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523316. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

TIFitis updated this revision to Diff 523304. TIFitis edited the summary of this revision. TIFitis added a comment. Small fix to code comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 523303. TIFitis added a comment. Done migrating from Clang. This makes use of the clang functions now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis marked 3 inline comments as done. TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 ___ cfe-commits mailing

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 520730. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 519822. TIFitis added a comment. Changed std::function to llvm::function_ref for the callbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files:

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis created this revision. TIFitis added reviewers: jdoerfert, jsjodin. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

This revision was automatically updated to reflect the committed changes. TIFitis marked 2 inline comments as done. Closed by commit rG35309db7dcef: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github Monorepo

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848 + class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy { + public: MapExprsArrayTy Exprs; jdoerfert wrote:

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis updated this revision to Diff 519054. TIFitis added a comment. Changed name from llvm::OpenMPIRBuilder::MapCombinedInfoTy to llvm::OpenMPIRBuilder::MapInfosTy, and changed to struct instead of class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis updated this revision to Diff 518847. TIFitis marked 2 inline comments as done. TIFitis added a comment. Merged MapDevPtrsArrayTy and MapMappersArrayTy into single type named MapValueDeclsArrayTy in CGOpenMPRuntime.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6848 + class MapCombinedInfoTy : public llvm::OpenMPIRBuilder::MapCombinedInfoTy { + public: MapExprsArrayTy Exprs; jdoerfert wrote:

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, jdoerfert, dpalermo. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis planned changes to this revision. TIFitis added a comment. @kiranchandramohan I am in the process of submitting a new patch for review which moves the map processing from Clang Codegen to OMPIRBuilder. Once that is moved we can just use that for dealing with the map operands. Thus

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 517921. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 517548. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. In D146557#4295550 , @kiranchandramohan wrote: > In D146557#4292223 , @TIFitis wrote: > >> Cleaned up how IsBegin argument is passed for createTargetData call. > > Please submit this

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 516379. TIFitis marked an inline comment as done. TIFitis added a comment. Cleaned up how IsBegin argument is passed for createTargetData call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 3 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1491 +mapTypes = exitDataOp.getMapTypes(); +mapperFunc = false; +return success();

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapOpCB, bodyCB)); + } else {

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1533 +ompLoc, builder.saveIP(), mapTypeFlags, mapNames, mapperAllocas, +mapperFunc, deviceID, ifCond, processMapOpCB, bodyCB)); + } else {

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/test/Target/LLVMIR/omptarget-llvm.mlir:4-5 -llvm.func @_QPopenmp_target_data() { - %0 = llvm.mlir.constant(1 : i64) : i64 - %1 = llvm.alloca %0 x i32 {bindc_name = "i", in_type = i32,

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 515805. TIFitis marked an inline comment as done. TIFitis edited the summary of this revision. TIFitis added a comment. Updated tests. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. In D146557#4283149 , @kiranchandramohan wrote: > Please update the summary to convey all the changes introduced in the patch. > > From the tests, it looks like there is a substantial change in the IR. I was > hoping this to be

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. ping for reviews. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 513599. TIFitis added a comment. Updated to use opaque pointers, removed BitCast Insts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files:

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added a comment. Herald added a subscriber: bviyer. ping for reviews. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 ___ cfe-commits mailing

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 2 inline comments as not done. TIFitis added a comment. Polite request for reviews. Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 509725. TIFitis added a comment. Updated unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357-1362 +int64_t getSizeInBytes(DataLayout , const mlir::Type ) { + if (isa(type)) +return DL.getTypeSize(cast(type).getElementType()); + + return -1; +}

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 509698. TIFitis marked an inline comment as done. TIFitis added a comment. Changed how size is calculated. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4064-4077 +Value *BaseGEPPtr = Builder.CreateInBoundsGEP( +ArrI8PtrTy, MapperAllocas.ArgsBase, +{Builder.getInt32(0),

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis marked 3 inline comments as done. TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4181-4191 +for (auto : UseDeviceInfos) { + auto *UseDeviceVal = UseDeviceOp.first; + auto = UseDeviceOp.second; + SmallDenseSet

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 507430. TIFitis added a comment. Updated tests. All tests pass now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146557: [MLIR][OpenMP] Added OMPIRBuilder support for use_device_ptr clause

TIFitis updated this revision to Diff 507337. TIFitis added a comment. Removed use_dev_ptr clause related code. This patch only refactors the map clause prcoessing now. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146557: [MLIR][OpenMP] Added OMPIRBuilder support for use_device_ptr clause

TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4181-4191 +for (auto : UseDeviceInfos) { + auto *UseDeviceVal = UseDeviceOp.first; + auto = UseDeviceOp.second; + SmallDenseSet ReplaceUses; + for (auto :

[PATCH] D146557: [MLIR][OpenMP] Added OMPIRBuilder support for use_device_ptr clause

TIFitis created this revision. TIFitis added reviewers: kiranchandramohan, raghavendhra, dpalermo, jsjodin, domada, jdoerfert, skatrak. Herald added subscribers: sunshaoce, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d373e4dc7e9: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 506563. TIFitis added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1523 + auto bodyCB = [&](InsertPointTy allocaIP, InsertPointTy codeGenIP) { +// DataOp has only one region associated with it. +auto = cast(op).getRegion();

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 506054. TIFitis marked 5 inline comments as done. TIFitis added a comment. Addresed reviewer comments. Removed flang changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 505456. TIFitis marked an inline comment as done. TIFitis added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 505116. TIFitis added a comment. Herald added a project: Flang. Added TODO for unsupported map operand types in Flang frontend Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase , LLVM::ModuleTranslation ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 503741. TIFitis added a comment. Added names for offload mapper variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1357 +/// Process MapOperands for Target Data directives. +static LogicalResult processMapOperand( +llvm::IRBuilderBase ,

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1561 + /// should be placed. + /// \param HasRegion True if the op has a region associated with it, false + /// otherwise kiranchandramohan wrote: > TIFitis wrote: > >

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 503137. TIFitis marked 3 inline comments as done. TIFitis added a comment. Addressed comments. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

  1   2   >