[PATCH] D154402: [compiler-rt] Enable profile instrumentation for SerenityOS

ADKaster updated this revision to Diff 558045. ADKaster added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154402/new/ https://reviews.llvm.org/D154402 Files: clang/lib/Driver/ToolChains/Serenity.cpp

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster updated this revision to Diff 558043. ADKaster added a comment. test LTO with option fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 Files: clang/lib/Basic/Targets.cpp

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster updated this revision to Diff 558012. ADKaster added a comment. Add more tests and remove items per comments More tests for crt*, eh-frame-hdr, stdlib arguments remove /usr/local/include remove -fno-use-init-array claim stdlib= args remove -nopie I hope that the new tests are more

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:76 + if (!IsStatic || IsStaticPIE) +CmdArgs.push_back("--eh-frame-hdr"); + MaskRay wrote: > ADKaster wrote: > > MaskRay wrote: > > > This is not tested > > Hm. this also

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:76 + if (!IsStatic || IsStaticPIE) +CmdArgs.push_back("--eh-frame-hdr"); + MaskRay wrote: > This is not tested Hm. this also seems like incorrect logic. In my next push I

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster added inline comments. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:202 + addSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/local/include")); + addSystemInclude(DriverArgs, CC1Args, concat(D.SysRoot, "/usr/include"));

[PATCH] D154402: [compiler-rt] Enable profile instrumentation for SerenityOS

ADKaster updated this revision to Diff 557946. ADKaster added a comment. updates from D154396 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154402/new/ https://reviews.llvm.org/D154402 Files:

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster updated this revision to Diff 557945. ADKaster added a comment. Brad's comments, and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/ https://reviews.llvm.org/D154396 Files: clang/lib/Basic/Targets.cpp

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster added a comment. In D154396#4655496 , @brad wrote: > In D154396#4655494 , @ADKaster > wrote: > >> @MaskRay @phosek Daniel and I have updated the patch set, Would you rather >> I update the phab patch

[PATCH] D154402: [compiler-rt] Enable profile instrumentation for SerenityOS

ADKaster updated this revision to Diff 557931. ADKaster added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update Driver as well, and add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154402/new/

[PATCH] D154401: [tools] Support building shared libLLVM and libClang for SerenityOS

ADKaster updated this revision to Diff 557930. ADKaster added a comment. prefer CMake platform defined name SERENITYOS over CMAKE_SYSTEM_NAME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154401/new/ https://reviews.llvm.org/D154401 Files:

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster updated this revision to Diff 557927. ADKaster added a comment. Herald added subscribers: wangpc, s.egerton, ormris, simoncook, asb. Base on Generic_ELF driver, add tests, add myself as co-author Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster added a comment. @MaskRay @phosek Daniel and I have updated the patch set, Would you rather I update the phab patch series, or re-upload the set as GitHub PRs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154396/new/

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster planned changes to this revision. ADKaster added a comment. Planning to rebase on top of Generic_ELF per Petr's suggestion. Comment at: clang/lib/Driver/ToolChains/Serenity.cpp:85 + auto linkerIs = [Exec](const char *name) { +return

[PATCH] D154397: [Driver] Default to -ftls-model=initial-exec on SerenityOS

ADKaster abandoned this revision. ADKaster added a comment. In D154397#4470094 , @jrtc27 wrote: > This is pretty dodgy, I don't think it belongs upstream Fair enough, the original patch had "probably don't upstream this" in the commit description.

[PATCH] D154401: [tools] Support building shared libLLVM and libClang for SerenityOS

ADKaster created this revision. Herald added subscribers: mstorsjo, fedor.sergeev. Herald added a project: All. ADKaster requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch tells CMake that the --whole-archive

[PATCH] D154397: [Driver] Default to -ftls-model=initial-exec on SerenityOS

ADKaster created this revision. Herald added a project: All. ADKaster requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Force Clang use the initial-exec TLS model instead of the default local-exec when building code for Serenity.

[PATCH] D154396: [clang] Add support for SerenityOS

ADKaster created this revision. Herald added a project: All. ADKaster requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adds support for the `$arch-pc-serenity` target to the Clang front end. This makes the compiler look for

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

ADKaster added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:353 + if (IsSystem || + IncludeDelimiter == Config::IncludeDelimiterPolicy::AlwaysBrackets) Suggested = "<" + Suggested + ">"; I couldn't tell looking at other code in

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

ADKaster updated this revision to Diff 506409. ADKaster added a comment. Change from a boolean parameter to an enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145843/new/ https://reviews.llvm.org/D145843 Files:

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

ADKaster added a comment. If this patch is accepted, I don't have commit access. If someone could commit as "Andrew Kaster " that would be much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145843/new/

[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

ADKaster created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ADKaster requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Projects can now add the following