[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVCallingConv.td:52 // Same as CSR_Interrupt, but including all 64-bit FP registers. def CSR_XLEN_F64_Interrupt: CalleeSavedRegs<(add CSR_Interrupt, (sequence

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat updated this revision to Diff 556995. 4vtomat added a comment. Add VRM2, VRM4 and VRM8 to CalleeSaved register list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154576/new/ https://reviews.llvm.org/D154576 Files:

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat updated this revision to Diff 555307. 4vtomat edited the summary of this revision. 4vtomat added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158050/new/ https://reviews.llvm.org/D158050 Files:

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat added a comment. `RVVArgDispatcher` is the class used to compute and maximize the register usage by using the vector argument information placed in `std::vector`, it's both used by `frontend` and `backend`. Currently I'm not sure where is the better file to place this class, so I just

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat updated this revision to Diff 555304. 4vtomat added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Finish handling vector arguments in backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b40ced4e5ba: [RISCV] Add --print-supported-extensions support (authored by 4vtomat). Changed prior to commit:

[PATCH] D158257: [RISCV] Add feature checks for vector crypto C intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8609819eb1c3: [RISCV] Add feature checks for vector crypto C intrinsics (authored by 4vtomat). Changed prior to commit:

[PATCH] D158255: [RISCV][NFC] Update compile options for some vector crypto C intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb47721fb743: [RISCV][NFC] Update compile options for some vector crypto C intrinsics (authored by 4vtomat). Repository: rG LLVM Github Monorepo

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 554609. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added a comment. In D146054#4596571 , @MaskRay wrote: > In D146054#4587210 , @4vtomat wrote: > >> In D146054#4586067 , @MaskRay >> wrote: >> >>> I think the best

[PATCH] D158255: [RISCV][NFC] Update compile options for some vector crypto C intrinsics

4vtomat updated this revision to Diff 554591. 4vtomat added a comment. Update Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158255/new/ https://reviews.llvm.org/D158255 Files:

[PATCH] D158257: [RISCV] Add feature checks for vector crypto C intrinsics

4vtomat updated this revision to Diff 551419. 4vtomat added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158257/new/ https://reviews.llvm.org/D158257 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D158257: [RISCV] Add feature checks for vector crypto C intrinsics

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, sunshaoce, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29f11e4fb704: [RISCV] Bump vector crypto to v1.0 RC2 (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158067: [RISCV] Bump vector crypto to v1.0 RC2

4vtomat updated this revision to Diff 551364. 4vtomat added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158067/new/

[PATCH] D158050: [RISCV] RISCV vector calling convention (2/2)

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 550185. 4vtomat added a comment. 1. Apply clang-format for this patch 2. Replace FileCheck --implicit-check-not=warning: with %clang -Werror Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked 2 inline comments as done. 4vtomat added a comment. In D146054#4586067 , @MaskRay wrote: > I think the best place to test `RISCVISAInfo.cpp` is > `llvm/unittests/Support/RISCVISAInfoTest.cpp`. > >

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. 4vtomat marked an inline comment as done. Closed by commit rGa23d65ac89ce: [RISCV] Add missing Xsfvcp extension check in clang sema (authored by 4vtomat). Repository:

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157651: [RISCV] Rewrite CheckInvalidVLENandLMUL to avoid floating point.

4vtomat accepted this revision. 4vtomat added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Sema/SemaChecking.cpp:4484 + unsigned EGS = EGW / ElemSize; + // If EGS is more than our minimum number of elements we're done. + if

[PATCH] D157580: [RISCV][NFC] Use named arguments in newly added changes

4vtomat accepted this revision. 4vtomat added a comment. LGTM, thanks~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157580/new/ https://reviews.llvm.org/D157580 ___ cfe-commits mailing list

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

4vtomat marked an inline comment as done. 4vtomat added inline comments. Comment at: clang/test/Sema/rvv-required-features-invalid.c:16 +void test_sf_vc_x_se_u64m1(uint64_t rs1, size_t vl) { // expected-note {{'test_sf_vc_x_se_u64m1' declared here}} +

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

4vtomat updated this revision to Diff 548843. 4vtomat added a comment. Rename the function in the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157474/new/ https://reviews.llvm.org/D157474 Files:

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

4vtomat updated this revision to Diff 548509. 4vtomat added a comment. Add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157474/new/ https://reviews.llvm.org/D157474 Files: clang/lib/Sema/SemaRISCVVectorLookup.cpp

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D157467: [RISCV] Add missing REQUIRES for zvk-invalid.c test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadb76c31ec42: [RISCV] Add missing REQUIRES for zvk-invalid.c test (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157467: [RISCV] Add missing REQUIRES for zvk-invalid.c test

4vtomat created this revision. Herald added subscribers: jobnoorman, VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: All. 4vtomat requested review of this revision. Herald added

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added a comment. In D138810#4571579 , @dyung wrote: > The test you added clang/test/Sema/zvk-invalid.c is failing on bots, for > example https://lab.llvm.org/buildbot/#/builders/139/builds/47055. > > Is the test missing a `REQUIRES:

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a05a5215f69: [RISCV] Support vector crypto extension C intrinsics (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ce925083d2: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546746. 4vtomat added a comment. This update does a few things: 1. Update test cases based on rvv-intrinsic-doc. 2. Add checks for "zvknh[a|b]" instructions. 3. Rename and restructure the function from CheckInvalidEGW to CheckInvalidVLENandLMUL.

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546677. 4vtomat added a comment. Update missing comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2405 + defvar suffix = !if(IsVV, "vv", "vi"); + defvar prototype = !if(IsVV, "UvUvUvUv", "UvUvUvKz"); + defm "" : RVVBuiltinSet; craig.topper wrote: > Can we split this into

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 546671. 4vtomat marked 3 inline comments as done. 4vtomat added a comment. This update does a few things: 1. Update Craig's comments. 2. Make `LMUL=8` valid(https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/234#discussion_r1282568330). 3. Rebase.

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545500. 4vtomat added a comment. Updated test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added inline comments. Comment at: clang/include/clang/Frontend/FrontendOptions.h:290 + /// Output time trace profile. + unsigned TimeTrace : 1; + MaskRay wrote: > stray change? Oh, maybe it was added accidentally during rebase lol~

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545499. 4vtomat marked 6 inline comments as done. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files:

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat updated this revision to Diff 545413. 4vtomat marked 2 inline comments as done. 4vtomat added a comment. Resolved Aaron's comments. Also group some code and refactoring some code to make it much clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545412. 4vtomat added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 545411. 4vtomat marked 6 inline comments as done. 4vtomat added a comment. Resolved MaskRay's comments, thanks for reviewing!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat marked 2 inline comments as done. 4vtomat added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3267 case CC_PreserveAll: + case CC_RISCVVectorCall: // FIXME: we should be mangling all of the above. aaron.ballman wrote: > Is it

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat added a comment. In D154576#4483919 , @lhtin wrote: > In D154576#4476300 , @4vtomat wrote: > >> In D154576#4476291 , @craig.topper >> wrote: >> >>> Does this

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 544624. 4vtomat marked 5 inline comments as done. 4vtomat added a comment. After discusstion in https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/234, we will have multiple lmuls for scalar type operands. Currently the test cases for those instructions

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

4vtomat added inline comments. Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:136 case Invalid: + case Undefined: llvm_unreachable("Unhandled type."); eopXD wrote: > Could we just reuse `Invalid`? We can't reuse Invalid, since `ScalarType` in

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

4vtomat updated this revision to Diff 544254. 4vtomat added a comment. Add a test case for invalid example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156223/new/ https://reviews.llvm.org/D156223 Files:

[PATCH] D156223: [RISCV] Resolve a few bugs in RISCVVIntrinsicUtils.cpp

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat marked 2 inline comments as done. 4vtomat added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2378 + +multiclass RVVOutBuiltinSetP { craig.topper wrote: > What does `P` in this name mean? Is this because they use OP_P as their >

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 539402. 4vtomat marked 12 inline comments as done. 4vtomat added a comment. Resolved Craig's and Michael's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked an inline comment as done. 4vtomat added a comment. @MaskRay if you are available, please help me to check the revision, thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat added a comment. In D154576#4476291 , @craig.topper wrote: > Does this only change the calling convention when > `__attribute__((riscv_vector_cc))` is used? The attribute should be mentioned > in the patch description. Yes it only changes

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, ormris, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat marked an inline comment as done. 4vtomat added inline comments. Comment at: clang/test/Driver/print-supported-extensions.c:3 + +// REQUIRES: riscv-registered-target + MaskRay wrote: > If you remove `all` and `RISCV` from `LLVM_TARGETS_TO_BUILD`, you can

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added inline comments. Comment at: clang/test/Driver/print-supported-extensions.c:6 +// RUN: %clang --target=riscv64 --print-supported-extensions 2>&1 | \ +// RUN: FileCheck %s --check-prefix=CHECK-RISCV + MaskRay wrote: > MaskRay wrote: > > Use

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat updated this revision to Diff 536947. 4vtomat marked 27 inline comments as done. 4vtomat added a comment. Herald added a subscriber: wangpc. Sorry for late update. Resolved MaskRay's comments, thanks for detailed review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154050: [Clang][RISCV] Fix RISC-V vector / SiFive intrinsic inclusion in SemaLookup

4vtomat accepted this revision. 4vtomat added a comment. LGTM, thanks~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154050/new/ https://reviews.llvm.org/D154050 ___ cfe-commits mailing list

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 535696. 4vtomat added a comment. Herald added a subscriber: wangpc. Ready for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files:

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02f94a655fb6: [RISCV] Bump vector crypto to v1.0.0-rc1 (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

4vtomat added a comment. In D153836#4452236 , @asb wrote: > Agreed that looking at > https://github.com/riscv/riscv-crypto/compare/v20230531...v20230620 there are > no changes that need to be reflected on the LLVM side beyond the version bump > here.

[PATCH] D153836: [RISCV] Bump vector crypto to v1.0.0-rc1

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat added a comment. Sorry for late reply, this is the relevant spec for C intrinsics: https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/234 I will update the patch according to this! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

4vtomat updated this revision to Diff 522411. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

4vtomat updated this revision to Diff 520904. 4vtomat added a comment. Remove -march=help alias. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

4vtomat added inline comments. Comment at: clang/lib/Driver/Driver.cpp:110 +extern void RISCVMarchHelp(); + craig.topper wrote: > Can we declare this in RISCVISAInfo.h and include that here? Yes, we can. Comment at:

[PATCH] D149655: [tests] Add missing REQUIRES: riscv-registered-target to clang test

4vtomat closed this revision. 4vtomat added a comment. Merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149655/new/ https://reviews.llvm.org/D149655 ___ cfe-commits mailing list

[PATCH] D149655: [tests] Add missing REQUIRES: riscv-registered-target to clang test

4vtomat created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312515 , @dyung wrote: > In D148223#4312460 , @4vtomat wrote: > >> Hi @craig.topper and @kito-cheng , the build error message was: >>

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312460 , @4vtomat wrote: > Hi @craig.topper and @kito-cheng , the build error message was: > 'Z:\test\llvm-project\clang\test\CodeGen\RISCV\rvv-intrinsics-autogenerated\non-policy\non-overloaded\xsfvcp-x-rv64.c:4:10:

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. Hi @craig.topper and @kito-cheng , the build error message was: 'z:\test\build\lib\clang\17\include\sifive_vector.h:12:10: fatal error: 'riscv_vector.h' file not found'. Have you ever met this before? I'm not sure if I forgot to add something or not.. Repository:

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

4vtomat added a comment. In D148223#4312296 , @TWeaver wrote: > Hello and Good Afternoon from the UK, > > I believe this revision has started the following build bot to start failing > on these 5 tests: > >

[PATCH] D148308: [RISCV][RISCV][clang] Split out SiFive VCIX C intrinsics from riscv_vector.td

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa43608d1649: [RISCV][RISCV][clang] Split out SiFive Vector C intrinsics from riscv_vector.td (authored by 4vtomat). Changed prior to commit:

[PATCH] D148680: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bf846ba40f1: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td (authored by 4vtomat). Repository: rG LLVM Github Monorepo

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ed9cf06e900: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension. (authored by Nelson1225, committed by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c1fa60b5f5: [RISCV] Add Smaia and Ssaia extensions support (authored by 4vtomat). Changed prior to commit: https://reviews.llvm.org/D148066?vs=516137=518634#toc Repository: rG LLVM Github Monorepo

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 517113. 4vtomat added a comment. Update to version 0.5.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

4vtomat updated this revision to Diff 516708. 4vtomat added a comment. Rename clang/test/Driver/print-supported-marchs.c to clang/test/Driver/print-supported-extensions.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 516598. 4vtomat added a comment. Removed unnecessary comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 516596. 4vtomat added a comment. Resolved Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vector.td

[PATCH] D147935: [RISCV] Add SiFive extension support

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd5c4cb7e0ae: [RISCV] Add SiFive extension support (authored by kito-cheng, committed by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat updated this revision to Diff 516137. 4vtomat added a comment. Resolved Alex's comment. Moved both of extensions to experimental. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 Files:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514821. 4vtomat added a comment. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vector.td

[PATCH] D148680: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

4vtomat added a comment. In D148680#4279291 , @craig.topper wrote: > Are we running tablegen separately for each vendor extension? Yes, I guess the vendor extensions should be separated into different tablegen file so that they don't be in

[PATCH] D148308: [RISCV] Split out SiFive VCIX C intrinsics from riscv_vector.td

4vtomat updated this revision to Diff 514817. 4vtomat added a comment. Resolved Kito's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148308/new/ https://reviews.llvm.org/D148308 Files: clang/include/clang/Basic/BuiltinsRISCVVector.def

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514812. 4vtomat added a comment. Rename riscv_sifive_vcix.td to riscv_sifive_vector.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 514810. 4vtomat added a comment. Resolved Kito's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files: clang/include/clang/Basic/riscv_sifive_vcix.td

[PATCH] D148680: [RISCV] Split out part of riscv_vector.td to riscv_vector_common.td

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat updated this revision to Diff 514302. 4vtomat added a comment. Resolved MaskRay's comments. Should we use @Kito's approach to deal with -march=help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054

[PATCH] D148308: [RISCV] Split out SiFive VCIX C intrinsics from riscv_vector.td

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat updated this revision to Diff 513464. 4vtomat added a comment. Herald added a subscriber: arphaman. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 Files:

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat updated this revision to Diff 513223. 4vtomat added a comment. Resolved Alex's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/ https://reviews.llvm.org/D147935 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat added a comment. In D147935#4259687 , @craig.topper wrote: > Is there a different patch with the .td for these intrinsics? Yes, it's in this patch: D148223 Comment at:

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

4vtomat created this revision. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project:

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat updated this revision to Diff 512655. 4vtomat added a comment. Resolved Kito's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D147935: [RISCV] Add SiFive extension support

4vtomat created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 508539. 4vtomat added a comment. Herald added subscribers: jobnoorman, luke. Updated to spec version 20230206. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files:

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat updated this revision to Diff 508475. 4vtomat added a comment. Resolved Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

4vtomat updated this revision to Diff 508461. 4vtomat added a comment. Resolved MaskRay and Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files:

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

This revision was automatically updated to reflect the committed changes. Closed by commit rG9795aa042a84: [RISCV] Support vector crypto extension ISA string and assembly (authored by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 506894. 4vtomat added a comment. Resolved Craig's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141672/new/ https://reviews.llvm.org/D141672 Files: clang/test/Preprocessor/riscv-target-features.c

  1   2   >