[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. Reverted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. Hi @efriedma, thanks your comments. You're right, that was hasty of me. Apologies for that, it won't happen again. RE: R6 Case in point: you're right. We're definitely not handling this correctly. I'll revert the patch, or

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil accepted this revision. carwil added a comment. This revision is now accepted and ready to land. I think there's been plenty of time for comments here. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. Just want to double check with @efriedma, before we except this. I believe this patch now catches all the points you made on https://reviews.llvm.org/D56005. Anything we've missed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. In D68862#1708132 , @chill wrote: > In D68862#1708079 , @carwil wrote: > > > > IMHO, since reserved registes are per-function, this strongly suggests > > > implementation as function

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. > IMHO, since reserved registes are per-function, this strongly suggests > implementation as function attribute(s), rather than subtarget features (also > for the pre-existing r9). What do you mean reserved registers are per-function? That sounds like you're describing

[PATCH] D56003: [RFC] [CFE] Allocatable Global Register Variables for ARM

carwil abandoned this revision. carwil added a comment. Superseded by https://reviews.llvm.org/D68862. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56003/new/ https://reviews.llvm.org/D56003 ___ cfe-commits mailing list

[PATCH] D65000: [ARM] Set default alignment to 64bits

carwil added a comment. In D65000#1595920 , @peter.smith wrote: > test case missing A8 aside this looks ok to me. Would like to see if there > are any comments from the Pacific time zone. Are you happy to approve this now @peter.smith? Repository:

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

This revision was automatically updated to reflect the committed changes. Closed by commit rC356776: [ARM] Fix bug 39982 - pcs(aapcs-vfp) is not consistent (authored by carwil, committed by ). Changed prior to commit: https://reviews.llvm.org/D59094?vs=190798=191895#toc Repository: rC Clang

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

carwil updated this revision to Diff 190798. carwil added a comment. Done. I've added an extra parameter over what you might expect as classifyArgumentTypes doesn't seem to consider AAPCS16, whereas classifyReturnTypes does. I've also renamed the variable to make the distinction between it and

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

carwil updated this revision to Diff 190653. carwil marked an inline comment as done. carwil added a comment. I got bit a confused earlier. That does actually seem like correct behaviour (once we're no longer able to treat the struct as a homogeneous aggregate). I've tightened up the conditional

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

carwil added a comment. In D59094#1421893 , @efriedma wrote: > Not sure how to write a testcase off the top of my head... have you tried > homogeneous aggregates with more than two elements? Good catch! Seems like if we surpass

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

carwil created this revision. Herald added subscribers: cfe-commits, jdoerfert, kristof.beyls, javed.absar. Herald added a project: clang. See: https://bugs.llvm.org/show_bug.cgi?id=39982 When considering how to classify homogeneous aggregates as return/argument types, the ABI of the function

[PATCH] D56003: [RFC] [CFE] Allocatable Global Register Variables for ARM

carwil updated this revision to Diff 185277. carwil added a comment. Removed the complicated frame pointer/ffixed combination errors in favour of an always on warning (in a new group, so it can be silenced). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56003/new/

[PATCH] D56003: [RFC] [CFE] Allocatable Global Register Variables for ARM

carwil updated this revision to Diff 183114. carwil added a comment. More tests, and better handling of argument combination errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56003/new/ https://reviews.llvm.org/D56003 Files: docs/ClangCommandLineReference.rst

[PATCH] D56003: [RFC] [CFE] Allocatable Global Register Variables for ARM

carwil updated this revision to Diff 181766. carwil set the repository for this revision to rC Clang. carwil added a comment. Herald added a subscriber: cfe-commits. Added cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56003/new/

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

This revision was automatically updated to reflect the committed changes. Closed by commit rL349335: [Docs] Expand -fstack-protector and -fstack-protector-all (authored by carwil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

carwil updated this revision to Diff 177828. carwil marked an inline comment as done. carwil added a comment. Reworded -fstack-protector-all to bring it in line with the changes to the other two options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55428/new/

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

carwil updated this revision to Diff 177668. carwil added a comment. Make thopre's suggested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55428/new/ https://reviews.llvm.org/D55428 Files: include/clang/Driver/Options.td Index: include/clang/Driver/Options.td

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

carwil updated this revision to Diff 177239. carwil added a comment. Edited Options.td directly, rather than the generated docs file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55428/new/ https://reviews.llvm.org/D55428 Files: include/clang/Driver/Options.td Index:

[PATCH] D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info

carwil created this revision. carwil added a project: clang. Herald added a subscriber: cfe-commits. Improve the description of these command line options by providing specific heuristic information, as outlined for the ssp function attribute(s) in LLVM's documentation. Repository: rC Clang