[PATCH] D108241: [hwasan] Flag stack safety check as requiring aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG2afb9394a745: [hwasan] Flag stack safety check as requiring aarch64 (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108241/new/

[PATCH] D108241: [hwasan] Flag stack safety check as requiring aarch64

ctetreau created this revision. Herald added a subscriber: kristof.beyls. ctetreau requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108241 Files:

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

ctetreau accepted this revision. ctetreau added inline comments. Comment at: llvm/lib/CodeGen/ValueTypes.cpp:17 +unsigned EVT::getVectorNumElements() const { + auto Error = []() { sdesmalen wrote: > ctetreau wrote: > > Out of curiosity, what is the eventual

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

ctetreau added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:31-35 +namespace TypeSizeClOpt { +/// The ScalableErrorAsWarning is a temporary measure to suppress errors from +/// using the wrong interface. +extern cl::opt ScalableErrorAsWarning; +} //

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

ctetreau accepted this revision. ctetreau added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/lib/CodeGen/ValueTypes.cpp:17 +unsigned EVT::getVectorNumElements() const { + auto Error = []() { Out of curiosity, what is the

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39970764af39: [CMake] Require python 3.6 if enabling LLVM test targets (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau added a comment. In D95635#2619804 , @serge-sans-paille wrote: > would it make sense to syndicate the minimal version in a single variable, > say `LLVM_MINIMAL_PYTHON_VERSION`, and use it in several place instead of > hard-coding the value

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau updated this revision to Diff 330078. ctetreau added a comment. set a var for the minimum bound Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 Files: clang/CMakeLists.txt lld/CMakeLists.txt

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

ctetreau requested review of this revision. ctetreau added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___ cfe-commits mailing list

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau updated this revision to Diff 329965. ctetreau added a comment. This revision is now accepted and ready to land. Only require if adding test suite targets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau planned changes to this revision. ctetreau added a comment. Herald added subscribers: dcaballe, cota. I plan to revive this patch. I will try to rig it to only require 3.6 or above is testing is enabled using LLVM_INCLUDE_TESTS. Hopefully if any build bots haven't been fixed by now,

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG55448ab540de: [AArch64] Adding Neon Polynomial vadd Intrinsics (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

ctetreau accepted this revision. ctetreau added a comment. LGTM. I'll land it for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.org/D96825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau added a comment. @JDevlieghere I personally have no skin in this game. This is actually quite an obnoxious development for me since my linux machine is stuck on an old version and Python 3.5 is the newest version in the repos. I sent a message to llvm-dev so hopefully this will get

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0703b0753c40: [CMake] Actually require python 3.6 or greater (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau added a comment. In D95635#2528851 , @JDevlieghere wrote: >> However, the project claims to require 3.6 or greater, and 3.6 features are >> being used. > > Can you link to where it says that? I'm not opposed to making 3.6 the > minimally

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. ctetreau requested review of this revision. Herald

[PATCH] D86065: [SVE] Make ElementCount members private

ctetreau accepted this revision. ctetreau added a comment. I think this is good to go as is. Assuming @paulwalker-arm is satisfied with leaving operator/ as is, then LGTM. Comment at: llvm/include/llvm/Support/TypeSize.h:66 + + ElementCount /=(unsigned RHS) { +Min /=

[PATCH] D86065: [SVE] Make ElementCount members private

ctetreau added a comment. In D86065#2241146 , @david-arm wrote: > Hi @ctetreau, ok for now I'm going to completely remove the operators and > revert the code using those operators to how it was before. ... This is probably for the best. In

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG19e883fc5988: [SVE] Remove calls to VectorType::getNumElements from clang (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau updated this revision to Diff 287755. ctetreau marked 4 inline comments as done. ctetreau added a comment. address code review issues, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 Files:

[PATCH] D86065: [SVE] Make ElementCount members private

ctetreau added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:56 + friend bool operator>(const ElementCount , const ElementCount ) { +assert(LHS.Scalable == RHS.Scalable && fpetrogalli wrote: > paulwalker-arm wrote: > > david-arm wrote:

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau marked 8 inline comments as done. ctetreau added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1765 } auto *VectorTy = dyn_cast( cast(Addr.getPointer()->getType())->getElementType()); c-rhodes wrote: > cast here that would be a

[PATCH] D86065: [SVE] Make ElementCount members private

ctetreau added a comment. Perhaps now would be a good time to combine TypeSize and ElementCount into a single Polynomial type? We don't have to implement the whole abstraction of `c*x^n` (since we currently don't use the exponent, and don't distinguish between X's) but if it's ever needed in

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau updated this revision to Diff 284926. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau planned changes to this revision. ctetreau added a comment. I plan to investigate the changes proposed by @c-rhodes. I'm a bit swamped right now so it may take a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau updated this revision to Diff 280254. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau marked an inline comment as done. ctetreau added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5612-5613 llvm::VectorType *VTy = GetNeonType(this, Type, HasLegalHalfType, false, AllowBFloatArgsAndRet);

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau updated this revision to Diff 279370. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. ctetreau added a child revision: D78127: [SVE] Mark VectorType::getNumElements() deprecated. Repository: rG LLVM Github Monorepo

[PATCH] D80342: [SVE] Deprecate default false variant of VectorType::get

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb81c85afdcd: [SVE] Deprecate default false variant of VectorType::get (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80342/new/

[PATCH] D80342: [SVE] Deprecate default false variant of VectorType::get

ctetreau updated this revision to Diff 271217. ctetreau added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. catch stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80342/new/

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

ctetreau abandoned this revision. ctetreau added a comment. After some further investigation, I have come to believe that the root cause of the issue I am seeing is on line 783 of clang/lib/Lex/HeaderSearch.cpp. A path is constructed using string concatenation (dir + '/' + file), which is

[PATCH] D81117: Fix path separator issue on Windows

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following 3 tests fail on Windows: Clang :: ClangScanDeps/header_stat_before_open.m Clang :: ClangScanDeps/static-analyzer.c Clang :: ClangScanDeps/vfsoverlay.cpp The issue is that bad

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

ctetreau added a comment. @amccarth The assert that I am getting is at line 1701 of VirtualFileSystem.cpp: assert(!isTraversalComponent(*Start) && !isTraversalComponent(From->getName()) && "Paths should not contain traversal components"); path is

[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ctetreau added reviewers: efriedma, apazos, zzheng, dexonsmith, rnk. Modify clang::FileManager::FixupRelativePath to use the existing path separator style, if one exists. Prior to this change,

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG796898172c48: [SVE] Eliminate calls to default-false VectorType::get() from Clang (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau added a comment. @rjmccall Given the outcome of the call yesterday, may I merge this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80323/new/ https://reviews.llvm.org/D80323 ___

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau updated this revision to Diff 267002. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80323/new/ https://reviews.llvm.org/D80323 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGExpr.cpp

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau updated this revision to Diff 265542. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80323/new/ https://reviews.llvm.org/D80323 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau added a comment. In D80323#2048457 , @rjmccall wrote: > I'm sympathetic to wanting to get rid of the boolean flag, but this is a > really invasive change for pretty minimal benefit. Why not leave > `VectorType::get` as meaning a non-scalable

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau created this revision. Herald added subscribers: cfe-commits, dmgreen, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. ctetreau added reviewers: david-arm, fpetrogalli, ddunbar, rjmccall. Repository: rG LLVM Github Monorepo

[PATCH] D79054: [NFC] Improve doc string to mention that paths in diff are used as-is

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a77b958e250: [NFC] Improve doc string to mention that paths in diff are used as-is (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79054: [NFC] Improve doc string to mention that paths in diff are used as-is

ctetreau added a comment. In D79054#2018912 , @efriedma wrote: > We should probably encourage people to use git-clang-format with git > repositories. It naturally doesn't have this sort of fragility because it > integrates with the repository more

[PATCH] D79054: [NFC] Improve doc string to mention that paths in diff are used as-is

ctetreau updated this revision to Diff 262433. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79054/new/ https://reviews.llvm.org/D79054 Files: clang/tools/clang-format/clang-format-diff.py

[PATCH] D79054: [NFC] Improve documentation for -i and update example git one liner

ctetreau added a comment. I considered trying to find a way to work around the issue. Something like "if the file is not found, and the current directory is `/foo/bar/`, and the computed filename is `bar/baz.c`, then use `/foo/bar/baz.c`". But I don't think there's any way we can reliably know

[PATCH] D79054: [NFC] Improve documentation for -i and update example git one liner

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ctetreau added reviewers: djasper, alexfh. ctetreau added a comment. I considered trying to find a way to work around the issue. Something like "if the file is not found, and the current

[PATCH] D78958: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType

This revision was automatically updated to reflect the committed changes. Closed by commit rGef3678cfeea6: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

This revision was automatically updated to reflect the committed changes. Closed by commit rGda8918f27e30: [SVE][NFC] Use ScalableVectorType in CGBuiltin (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78842/new/

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

ctetreau updated this revision to Diff 260491. ctetreau added a comment. fix syntax error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78842/new/ https://reviews.llvm.org/D78842 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D78958: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType

ctetreau updated this revision to Diff 260474. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78958/new/ https://reviews.llvm.org/D78958 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

ctetreau updated this revision to Diff 260472. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78842/new/ https://reviews.llvm.org/D78842 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D78958: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added a project: clang. Removes usage of VectorType::getNumElements identified by test located at

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. ctetreau added a parent revision: D78841: [SVE] Add specialized overloads of VectorType::get. ctetreau added reviewers: david-arm,

[PATCH] D77278: Remove asserting getters from base Type

This revision was automatically updated to reflect the committed changes. Closed by commit rGc858debebc13: Remove asserting getters from base Type (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258411. ctetreau added a comment. catch straggler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D77278 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258392. ctetreau added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. catch stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/

[PATCH] D77278: Remove asserting getters from base Type

ctetreau updated this revision to Diff 258393. ctetreau added a comment. fix permissions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77278/new/ https://reviews.llvm.org/D77278 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D78131: [SVE] Fix unsigned is always >= 0

This revision was automatically updated to reflect the committed changes. Closed by commit rG464a0697e36a: [SVE] Fix unsigned is always = 0 (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78131/new/

[PATCH] D77903: [SVE] Remove calls to getBitWidth from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG670f2f694bba: [SVE] Remove calls to getBitWidth from clang (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77903/new/

[PATCH] D78131: [SVE] Fix unsigned is always >= 0

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. ctetreau added a reviewer: sdesmalen. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78131 Files:

[PATCH] D77903: [SVE] Remove calls to getBitWidth from clang

ctetreau updated this revision to Diff 257162. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77903/new/ https://reviews.llvm.org/D77903 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D77257: Clean up usages of asserting vector getters in Type

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22fbe3a152e: Clean up usages of asserting vector getters in Type (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/

[PATCH] D77903: [SVE] Remove calls to getBitWidth from clang

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77903 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 256611. ctetreau added a comment. Address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 256408. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D77825: Fix syntax error

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2a1418f242ab: Fix syntax error (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

ctetreau added inline comments. Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:119 + case types::TY_CUDA_DEVICE: +return types::TY_CUDA: default: ctetreau wrote: > Syntax error here, master is broken I went ahead and fixed it.

[PATCH] D77825: Fix syntax error

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ctetreau added reviewers: tra, sammccall, ADRAADRA. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77825 Files: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

ctetreau added inline comments. Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:119 + case types::TY_CUDA_DEVICE: +return types::TY_CUDA: default: Syntax error here, master is broken Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 255390. ctetreau added a comment. Address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added a comment. Herald added a subscriber: grosul1. What's the status on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75661/new/ https://reviews.llvm.org/D75661 ___ cfe-commits

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 254570. ctetreau added a comment. Note that this is NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove usages of asserting vector getters in Type in preparation for the VectorType refactor. The existence of these functions complicates the refactor while adding little value. Repository:

[PATCH] D77254: Clean up usages of asserting vector getters in Type

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove usages of asserting vector getters in Type in preparation for the VectorType refactor. The existence of these functions complicates the refactor while adding little value. Repository:

[PATCH] D77236: [SVE] Cleanup prior to introdution of FixedVectorType

ctetreau updated this revision to Diff 254327. ctetreau added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Split commit up into multiple smaller commits: 1 commit per llvm library, 1 for clang, and 1 for mlir. Plus one final commit to remove the functions

[PATCH] D77236: [SVE] Cleanup prior to introdution of FixedVectorType

ctetreau added a comment. > 1. This is orthogonal to splitting VectorType, as far as I can tell. > `Ty->getVectorNumElements()` works equally well whether the implementation > asserts it's a VectorType that isn't scalable, or asserts it's a > FixedVectorType. While it's not strictly

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added inline comments. Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:81 static llvm::Type *getInnermostElementType(llvm::Type *type) { - while (isa(type)) -type = type->getSequentialElementType(); - return type; + do { +if (auto *arrayTy =

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added a comment. I'd like the see the clang-format complaints actually addressed, but don't bother unless you need to upload another patch for some other reason anyways. That aside, LGTM. This has been looked at by 3 people (plus yourself). So far, nobody has had any serious

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1078 } + // FIXME: Do we need to handle tail padding in vectors? return constant; efriedma wrote: > ctetreau wrote: > > The fact that you have to ask this question tells me that you

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added inline comments. Herald added a reviewer: aartbik. Comment at: clang/lib/CodeGen/CGDecl.cpp:1059 +llvm::Type *ElemTy = ArrayTy->getElementType(); +bool ZeroInitializer = constant->isNullValue(); llvm::Constant *OpValue, *PaddedOp; I

[PATCH] D75661: Remove SequentialType from the type heirarchy.

ctetreau added a comment. > I'm concerned though about having getSequentialElementType and > getSequentialNumElements apply to different sets of types. That's bound to > lead to confusion which causes bugs. Can we have one name for all types that > are homogenous sequences of the same element

[PATCH] D75486: [SVE] Make CompositeType not inherit from Type

ctetreau updated this revision to Diff 248050. ctetreau added a comment. Cleaned up code, resolved clang-format lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75486/new/ https://reviews.llvm.org/D75486 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D75486: [SVE] Make CompositeType not inherit from Type

ctetreau created this revision. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, psnobl, rkruppe, hiraditya, tschuett, nhaehnle, jvesely, arsenm. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. This patch is a work in progress Make CompositeType not inherit

[PATCH] D75370: [test] Fix flang test failures due to not handling .exe

ctetreau created this revision. Herald added subscribers: cfe-commits, DavidTruby. Herald added a project: clang. ctetreau added reviewers: efriedma, rsmith, peterwaller-arm. - Update flang tests to account for the fact that the binary is called flang.exe on windows Repository: rG LLVM

[PATCH] D72467: Remove "mask" operand from shufflevector.

ctetreau added inline comments. Comment at: llvm/lib/IR/ConstantsContext.h:153 cast(C1->getType())->getElementType(), - cast(C3->getType())->getElementCount()), + Mask.size(), C1->getType()->getVectorIsScalable()),

[PATCH] D72467: Remove "mask" operand from shufflevector.

ctetreau added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:2544 +SmallVector IntMask; +ShuffleVectorInst::getShuffleMask(cast(Mask), IntMask); +return CreateShuffleVector(V1, V2, IntMask, Name); spatel wrote: > Add an assert that

[PATCH] D68882: [test] Fix test failure

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The version mismatch symbol is version 9 on 32 bit android. Since this test isn't actually testing any android specific functionality, we force the target triple to x86_64-unknown-unknown in