Author: Clement Courbet
Date: 2022-01-05T14:33:40+01:00
New Revision: ed8ff29aa6835187f3d5e7b64de022fe6b33a131
URL:
https://github.com/llvm/llvm-project/commit/ed8ff29aa6835187f3d5e7b64de022fe6b33a131
DIFF:
Author: Clement Courbet
Date: 2021-11-24T16:47:55+01:00
New Revision: 3b72448084052785b79566fa5bd374feb8ae3907
URL:
https://github.com/llvm/llvm-project/commit/3b72448084052785b79566fa5bd374feb8ae3907
DIFF:
Author: Clement Courbet
Date: 2021-11-24T08:07:21+01:00
New Revision: ba4411e7c6a5879ce8acf246b0cd03ec738d9d6b
URL:
https://github.com/llvm/llvm-project/commit/ba4411e7c6a5879ce8acf246b0cd03ec738d9d6b
DIFF:
Author: Clement Courbet
Date: 2021-11-05T11:44:19+01:00
New Revision: 737f540abd578df094f04f690a9b5b52028374b4
URL:
https://github.com/llvm/llvm-project/commit/737f540abd578df094f04f690a9b5b52028374b4
DIFF:
Author: Clement Courbet
Date: 2021-11-04T15:43:32+01:00
New Revision: d3dc7d077f1d9c9478813a34ed38abbcb4fc1ef5
URL:
https://github.com/llvm/llvm-project/commit/d3dc7d077f1d9c9478813a34ed38abbcb4fc1ef5
DIFF:
Author: Clement Courbet
Date: 2021-11-03T15:51:35+01:00
New Revision: 45b84a547efe8991b28883c73efa2de798dc2c30
URL:
https://github.com/llvm/llvm-project/commit/45b84a547efe8991b28883c73efa2de798dc2c30
DIFF:
Author: Clement Courbet
Date: 2021-11-03T13:32:48+01:00
New Revision: 1427742750ed1fcd2ead639c4ec5178fc34c9257
URL:
https://github.com/llvm/llvm-project/commit/1427742750ed1fcd2ead639c4ec5178fc34c9257
DIFF:
Author: Clement Courbet
Date: 2021-10-29T08:41:03+02:00
New Revision: fc1b24d7360f59c8b89f1b6290fe849a6207dc44
URL:
https://github.com/llvm/llvm-project/commit/fc1b24d7360f59c8b89f1b6290fe849a6207dc44
DIFF:
Author: Clement Courbet
Date: 2019-11-22T08:47:55+01:00
New Revision: 95fe54931fddf9740b3247219e30504da447
URL:
https://github.com/llvm/llvm-project/commit/95fe54931fddf9740b3247219e30504da447
DIFF:
Author: courbet
Date: Tue Sep 10 07:20:08 2019
New Revision: 371522
URL: http://llvm.org/viewvc/llvm-project?rev=371522=rev
Log:
[clang][codegen][NFC] Make test patterns more permissive.
See the discussion in:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190909/692736.html
Author: courbet
Date: Tue Jun 11 05:12:06 2019
New Revision: 363053
URL: http://llvm.org/viewvc/llvm-project?rev=363053=rev
Log:
[clang-tidy] Fix typo in bugprone-string-constructor.
s/bigger then/bigger than/
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/StringConstructorCheck.cpp
Author: courbet
Date: Mon Mar 25 01:18:00 2019
New Revision: 356871
URL: http://llvm.org/viewvc/llvm-project?rev=356871=rev
Log:
[clang-tidy] Fix more false positives for bugprone-string-integer-assignment
Summary:
And add various tests gleaned for our codebase.
See PR27723.
Reviewers:
Author: courbet
Date: Thu Feb 28 05:39:01 2019
New Revision: 355089
URL: http://llvm.org/viewvc/llvm-project?rev=355089=rev
Log:
[clang-tidy] bugprone-string-integer-assignment: Reduce false positives.
Summary: Detect a few expressions as likely character expressions, see PR27723.
Reviewers:
Author: courbet
Date: Thu Feb 28 02:33:32 2019
New Revision: 355076
URL: http://llvm.org/viewvc/llvm-project?rev=355076=rev
Log:
[clang-tidy] misc-string-integer-assignment: fix false positive
Summary:
using CodePoint = uint32_t;
CodePoint cp;
basic_string s;
s += cp;
See PR27723.
Reviewers:
Author: courbet
Date: Mon Feb 25 05:09:02 2019
New Revision: 354780
URL: http://llvm.org/viewvc/llvm-project?rev=354780=rev
Log:
[clang-tidy] misc-string-integer-assignment: ignore toupper/tolower
Summary: Tis represents ~20% of false positives. See PR27723.
Reviewers: xazax.hun, alexfh
Author: courbet
Date: Thu Feb 14 04:00:34 2019
New Revision: 354023
URL: http://llvm.org/viewvc/llvm-project?rev=354023=rev
Log:
[Builtins] Treat `bcmp` as a builtin.
Summary:
This makes it consistent with `memcmp` and `__builtin_bcmp`.
Also see the discussion in
Author: courbet
Date: Wed Jan 16 00:36:23 2019
New Revision: 351308
URL: http://llvm.org/viewvc/llvm-project?rev=351308=rev
Log:
[clang-tidy] bugprone-string-constructor: Catch string from nullptr.
Summary: Context: https://twitter.com/willkirkby/status/1084219580799741953
Subscribers:
Author: courbet
Date: Thu Dec 20 05:30:40 2018
New Revision: 349755
URL: http://llvm.org/viewvc/llvm-project?rev=349755=rev
Log:
[Sema][NFC] Add test for static_assert diagnistics with constexpr template
functions.
Modified:
cfe/trunk/test/SemaCXX/static-assert-cxx17.cpp
Modified:
Author: courbet
Date: Thu Dec 20 01:05:15 2018
New Revision: 349729
URL: http://llvm.org/viewvc/llvm-project?rev=349729=rev
Log:
[Sema] Better static assert diagnostics for expressions involving
temporaries/casts/
Summary:
Handles expressions such as:
- `std::is_const()`
-
Author: courbet
Date: Tue Dec 11 00:39:11 2018
New Revision: 348834
URL: http://llvm.org/viewvc/llvm-project?rev=348834=rev
Log:
Reland r348741 "[Sema] Further improvements to to static_assert diagnostics."
Fix a dangling reference to temporary, never return nullptr.
Modified:
Author: courbet
Date: Mon Dec 10 23:28:00 2018
New Revision: 348831
URL: http://llvm.org/viewvc/llvm-project?rev=348831=rev
Log:
Revert r348830 "[Sema]improve static_assert(!expr)"
Submitted the wrong change.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Author: courbet
Date: Mon Dec 10 23:04:49 2018
New Revision: 348830
URL: http://llvm.org/viewvc/llvm-project?rev=348830=rev
Log:
[Sema]improve static_assert(!expr)
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
cfe/trunk/test/SemaCXX/static-assert.cpp
Modified:
Author: courbet
Date: Mon Dec 10 00:53:17 2018
New Revision: 348742
URL: http://llvm.org/viewvc/llvm-project?rev=348742=rev
Log:
Revert r348741 "[Sema] Further improvements to to static_assert diagnostics."
Seems to break build bots.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Author: courbet
Date: Mon Dec 10 00:19:38 2018
New Revision: 348741
URL: http://llvm.org/viewvc/llvm-project?rev=348741=rev
Log:
[Sema] Further improvements to to static_assert diagnostics.
Summary:
We're now handling cases like `static_assert(!expr)` and
static_assert(!(expr))`.
Reviewers:
Author: courbet
Date: Mon Dec 3 23:59:57 2018
New Revision: 348239
URL: http://llvm.org/viewvc/llvm-project?rev=348239=rev
Log:
[WIP][Sema] Improve static_assert diagnostics for type traits.
Summary:
In our codebase, `static_assert(std::some_type_trait::value, "msg")`
(where `some_type_trait`
Author: courbet
Date: Thu Nov 22 06:26:33 2018
New Revision: 347463
URL: http://llvm.org/viewvc/llvm-project?rev=347463=rev
Log:
Revert rL347462 "[ASTMatchers] Add hasSideEffect() matcher."
Breaks some buildbots.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Author: courbet
Date: Thu Nov 22 06:00:56 2018
New Revision: 347462
URL: http://llvm.org/viewvc/llvm-project?rev=347462=rev
Log:
[ASTMatchers] Add hasSideEffect() matcher.
Summary: Exposes Expr::HasSideEffects.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Differential Revision:
Author: courbet
Date: Thu Nov 22 02:44:36 2018
New Revision: 347453
URL: http://llvm.org/viewvc/llvm-project?rev=347453=rev
Log:
[ASTMatchers] Re-generate ast matchers doc after rL346455.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified:
Author: courbet
Date: Wed May 23 00:58:41 2018
New Revision: 333066
URL: http://llvm.org/viewvc/llvm-project?rev=333066=rev
Log:
[clang-tidy] new cppcoreguidelines-narrowing-conversions check.
Summary:
Checks for narrowing conversions, e.g.
int i = 0;
i += 0.1;
This has what some might
I should have fixed it in r332576.
On Wed, May 16, 2018 at 11:49 PM, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Also few other builders are affected:
>
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test
>
Author: courbet
Date: Wed May 16 23:46:15 2018
New Revision: 332576
URL: http://llvm.org/viewvc/llvm-project?rev=332576=rev
Log:
Fix rL332458: [AST] Added a helper to extract a user-friendly text of a comment.
Older gcc versions do not support raw string literals within macros.
Modified:
Author: courbet
Date: Wed Mar 21 03:54:29 2018
New Revision: 328087
URL: http://llvm.org/viewvc/llvm-project?rev=328087=rev
Log:
[ASTMatchers] Remove extra qualifier for consistency
(LibASTMatchersReference.html)
+ Regenerate doc.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Author: courbet
Date: Wed Mar 21 03:48:00 2018
New Revision: 328086
URL: http://llvm.org/viewvc/llvm-project?rev=328086=rev
Log:
[ASTMatchers] Regenerate doc.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersReference.html
URL:
Author: courbet
Date: Tue Jul 11 08:45:22 2017
New Revision: 307663
URL: http://llvm.org/viewvc/llvm-project?rev=307663=rev
Log:
[ASTMatchers][NFC] integerLiteral(): Mention negative integers in
documentation.
Trying to match integerLiteral(-1) will silently fail, because an numeric
literal is
Author: courbet
Date: Thu Dec 22 08:12:31 2016
New Revision: 290340
URL: http://llvm.org/viewvc/llvm-project?rev=290340=rev
Log:
[clang-tidy] cppcoreguidelines-slicing: display discarded state size in bytes
https://reviews.llvm.org/D27212
Modified:
courbet added a comment.
Thanks.
https://reviews.llvm.org/D23641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: courbet
Date: Fri Jul 22 08:45:00 2016
New Revision: 276415
URL: http://llvm.org/viewvc/llvm-project?rev=276415=rev
Log:
Revert "Revert "[clang-tidy] new cppcoreguidelines-slicing""
Second try for r276408
Added:
clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/SlicingCheck.cpp
Author: courbet
Date: Fri Jul 22 08:33:51 2016
New Revision: 276413
URL: http://llvm.org/viewvc/llvm-project?rev=276413=rev
Log:
Revert "[clang-tidy] new cppcoreguidelines-slicing"
Tests fail on clang-x64-ninja-win7 due to too narrow expectation.
Removed:
Author: courbet
Date: Fri Jul 22 07:42:19 2016
New Revision: 276408
URL: http://llvm.org/viewvc/llvm-project?rev=276408=rev
Log:
[clang-tidy] new cppcoreguidelines-slicing
Flags slicing of member variables or vtable. See:
courbet added a comment.
I can submit, thanks.
https://reviews.llvm.org/D21992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet updated this revision to Diff 65028.
courbet marked an inline comment as done.
https://reviews.llvm.org/D21992
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/SlicingCheck.cpp
courbet marked an inline comment as done.
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.h:19
@@ +18,3 @@
+
+/// Flags slicing of member variables or vtable. See:
+/// -
Prazek wrote:
> some short description what does this check do?
There is already a
courbet updated this revision to Diff 64642.
courbet added a comment.
rebase
https://reviews.llvm.org/D21992
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/SlicingCheck.cpp
courbet added a comment.
Thanks for the review.
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:86
@@ +85,3 @@
+ "slicing object from type %0 to %1 discards override %2")
+ << << << Method;
+}
alexfh wrote:
> The "slicing ...
courbet updated this revision to Diff 64641.
courbet marked an inline comment as done.
courbet added a comment.
cosmetics
https://reviews.llvm.org/D21992
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
courbet updated this revision to Diff 64302.
courbet marked 3 inline comments as done.
courbet added a comment.
Cosmetics.
https://reviews.llvm.org/D21992
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
Author: courbet
Date: Tue Jul 12 01:36:00 2016
New Revision: 275157
URL: http://llvm.org/viewvc/llvm-project?rev=275157=rev
Log:
[ASTMatchers] isSignedInteger() and isUnsignedInteger()
Complementary to isInteger(), these match signed and unsigned integers
respectively.
Review:
courbet updated this revision to Diff 63644.
courbet added a comment.
Regenerate doc.
http://reviews.llvm.org/D2
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
courbet added a comment.
Thanks.
http://reviews.llvm.org/D2
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet created this revision.
courbet added a reviewer: aaron.ballman.
courbet added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
I could not find a way to match signedness of integers in the AST, so I'm
adding these two matchers.
http://reviews.llvm.org/D2
Files:
courbet added a comment.
I've ran this check on llvm. There are 0 instances of virtual function slicing
(which is not surprising since these usually result in actual bugs) and 71
instances of member varaible slicing:
- 'FullSourceLoc' to 'SourceLocation': 57
- 'APSInt' to 'APInt': 5
-
courbet added a comment.
Thanks for the comments.
Comment at: clang-tidy/cppcoreguidelines/SlicingCheck.cpp:48
@@ +47,3 @@
+
+ // Assignement slicing: "a = b;" and "a = std::move(b);" variants.
+ const auto SlicesObjectInAssignment =
hokein wrote:
> Looks
courbet updated this revision to Diff 63477.
courbet marked 4 inline comments as done.
courbet added a comment.
- Add a test case following comments.
- Add more comments in tests.
- Add examples in doc.
- Simplify code a bit.
http://reviews.llvm.org/D21992
Files:
courbet updated this revision to Diff 62845.
courbet added a comment.
Update release notes.
http://reviews.llvm.org/D21992
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/SlicingCheck.cpp
Author: courbet
Date: Tue Jul 5 02:49:31 2016
New Revision: 274531
URL: http://llvm.org/viewvc/llvm-project?rev=274531=rev
Log:
[ASTMatchers] New forEachOverriden matcher.
Matches methods overridden by the given method.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
courbet closed this revision.
courbet added a comment.
This was submitted as r272386.
http://reviews.llvm.org/D19324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: courbet
Date: Fri Jun 10 06:54:43 2016
New Revision: 272386
URL: http://llvm.org/viewvc/llvm-project?rev=272386=rev
Log:
[ASTMatchers] New forEachOverriden matcher.
Matches methods overridden by the given method.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Author: courbet
Date: Fri Jun 10 03:12:37 2016
New Revision: 272378
URL: http://llvm.org/viewvc/llvm-project?rev=272378=rev
Log:
test commit: remove trailing whitespace in comments
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified:
courbet added a comment.
That could work :) I'm not sure my commit history is considered a "track record
of submitting high quality patches" but I'll give it a try.
http://reviews.llvm.org/D19324
___
cfe-commits mailing list
courbet added a comment.
@sbenza @aaron.ballman I don't have write access. Can one of you submit this on
my behalf ? Thanks !
http://reviews.llvm.org/D19324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
courbet updated this revision to Diff 59502.
courbet added a comment.
Rebase on origin/master
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang/AST/DeclCXX.h
include/clang/ASTMatchers/ASTMatchers.h
courbet marked 10 inline comments as done.
courbet added a comment.
http://reviews.llvm.org/D19324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3776
@@ +3775,3 @@
+ bool Matched = false;
+ for (const auto *Overridden : Node.overridden_methods()) {
+BoundNodesTreeBuilder OverriddenBuilder(*Builder);
Thanks for the
courbet updated this revision to Diff 57757.
courbet added a comment.
clang-format diff
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang/AST/DeclCXX.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTContext.cpp
courbet updated this revision to Diff 57756.
courbet added a comment.
Rebase on HEAD.
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang/AST/DeclCXX.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTContext.cpp
courbet added a comment.
Thanks. Could please you submit this for me ?
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724
@@ +3723,3 @@
+ bool Matched = false;
+ for (const auto *Overridden : Node.overridden_methods()) {
+BoundNodesTreeBuilder
courbet updated this revision to Diff 57473.
courbet added a comment.
cometics
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang/AST/DeclCXX.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTContext.cpp
courbet updated this revision to Diff 57462.
courbet added a comment.
Use iterator_range instead of ArrayRef for overridden_methods
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
include/clang/AST/DeclCXX.h
courbet added a comment.
Thanks. I don't have write access, could you please submit this for me ?
http://reviews.llvm.org/D19534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet updated this revision to Diff 56529.
courbet marked an inline comment as done.
http://reviews.llvm.org/D19534
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/DefaultArgumentsCheck.cpp
clang-tidy/google/DefaultArgumentsCheck.h
clang-tidy/google/GoogleTidyModule.cpp
courbet added inline comments.
Comment at: include/clang/AST/ASTContext.h:824
@@ -823,1 +823,3 @@
unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
+ const ArrayRef overridden_methods(
+ const CXXMethodDecl *Method) const;
courbet added inline comments.
Comment at: include/clang/AST/ASTContext.h:824
@@ -823,1 +823,3 @@
unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
+ const ArrayRef overridden_methods(
+ const CXXMethodDecl *Method) const;
courbet added inline comments.
Comment at: clang-tidy/google/GoogleTidyModule.cpp:40
@@ -38,1 +39,3 @@
void addCheckFactories(ClangTidyCheckFactories ) override {
+CheckFactories.registerCheck(
+"google-default-arguments");
hokein wrote:
> Please
courbet updated this revision to Diff 56000.
courbet marked 4 inline comments as done.
courbet added a comment.
Cosmetics + change error message.
http://reviews.llvm.org/D19534
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/DefaultArgumentsCheck.cpp
courbet created this revision.
courbet added a reviewer: alexfh.
courbet added a subscriber: cfe-commits.
To check the google style guide rule here:
https://google.github.io/styleguide/cppguide.html#Default_Arguments
http://reviews.llvm.org/D19534
Files:
clang-tidy/google/CMakeLists.txt
courbet added a comment.
In http://reviews.llvm.org/D18442#411785, @alexfh wrote:
> Looks good now. Thank you for the new check!
Thanks for the review.
> Do you need me to submit the patch for you?
Yes, please.
http://reviews.llvm.org/D18442
courbet added inline comments.
Comment at: docs/clang-tidy/checks/misc-fold-init-type.rst:16-17
@@ +15,4 @@
+
+.. code:: c++
+ auto a = {0.5f, 0.5f, 0.5f, 0.5f};
+ return std::accumulate(std::begin(a), std::end(a), 0);
alexfh wrote:
> Prazek wrote:
> > Doesn't
courbet updated this revision to Diff 54969.
courbet marked 2 inline comments as done.
courbet added a comment.
Fix doc formatting and add more doc.
http://reviews.llvm.org/D18442
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/FoldInitTypeCheck.cpp
courbet updated this revision to Diff 54833.
courbet marked 3 inline comments as done.
courbet added a comment.
Refactoring matchers & cosmetics.
http://reviews.llvm.org/D18442
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/FoldInitTypeCheck.cpp
clang-tidy/misc/FoldInitTypeCheck.h
courbet added inline comments.
Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:89
@@ +88,3 @@
+
+/// Returns true if ValueType is allowed to fold into InitType, i.e. if:
+/// static_cast(ValueType{some_value})
alexfh wrote:
> Is "fold" a commonly used term in
courbet updated this revision to Diff 54830.
courbet marked an inline comment as done.
courbet added a comment.
overridden_methods return ArrayRef instead of TinyPtrVector*
http://reviews.llvm.org/D19324
Files:
docs/LibASTMatchersReference.html
include/clang/AST/ASTContext.h
courbet added a comment.
Thanks !
http://reviews.llvm.org/D19362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet added a comment.
Thanks! Would you mind submitting this for me ?
http://reviews.llvm.org/D19362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet created this revision.
courbet added a reviewer: aaron.ballman.
courbet added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Statically specify ownership of verifiers in tests. NFC
http://reviews.llvm.org/D19362
Files:
unittests/ASTMatchers/ASTMatchersTest.cpp
courbet updated this revision to Diff 54462.
courbet marked an inline comment as done.
courbet added a comment.
Fix typo in doc.
http://reviews.llvm.org/D19324
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
courbet created this revision.
courbet added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Matches methods overridden by the given method.
http://reviews.llvm.org/D19324
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
courbet added a comment.
Thanks, PTAL.
Comment at: clang-tidy/misc/FoldInitTypeCheck.cpp:21
@@ +20,3 @@
+/// Returns the value_type for an InputIterator type.
+static QualType getInputIteratorValueType(const Type ,
+ const ASTContext ) {
courbet updated the summary for this revision.
courbet updated this revision to Diff 54045.
courbet marked 7 inline comments as done.
courbet added a comment.
- Use matchers for most of the check logic,
- Implement checking for reduce and inner_product,
- more tests.
courbet added a comment.
Thanks for the review !
> I can submit the patch on your behalf if you would like.
That'd be great, thank you.
Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:109-111
@@ -107,5 +108,5 @@
SourceLocation Start = Function->getLocStart();
courbet updated this revision to Diff 53735.
courbet added a comment.
Fix error message in case of type alias declaration.
http://reviews.llvm.org/D19117
Files:
clang-tidy/modernize/RedundantVoidArgCheck.cpp
clang-tidy/modernize/RedundantVoidArgCheck.h
courbet marked an inline comment as done.
Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:109-110
@@ -107,4 +108,4 @@
SourceLocation Start = Function->getLocStart();
-SourceLocation End = Body ? Body->getLocStart().getLocWithOffset(-1) :
-
courbet added a comment.
Thanks for the review ! I don't have write access, could you please submit this
for me ?
http://reviews.llvm.org/D19113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
courbet updated this revision to Diff 53732.
courbet marked 2 inline comments as done.
courbet added a comment.
Regenerate doc, cosmetics.
http://reviews.llvm.org/D19113
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
courbet added a comment.
Example of where this is useful as a drop-in replacement for typedefDecl():
http://reviews.llvm.org/D19117
http://reviews.llvm.org/D19113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
courbet created this revision.
courbet added a subscriber: cfe-commits.
RedundantVoidArgCheck will now warn on:
using f_t = int (*(void))(void);
too.
(Depends on http://reviews.llvm.org/D19113)
http://reviews.llvm.org/D19117
Files:
clang-tidy/modernize/RedundantVoidArgCheck.cpp
courbet added a comment.
In http://reviews.llvm.org/D19113#401095, @aaron.ballman wrote:
> If we're going to add this (which I think is a good idea), perhaps we should
> also add `typeAliasDecl()` at the same time?
Makes sense, done.
http://reviews.llvm.org/D19113
courbet updated the summary for this revision.
courbet updated this revision to Diff 53724.
courbet marked an inline comment as done.
courbet added a comment.
Added typeAliasDecl. More tests.
http://reviews.llvm.org/D19113
Files:
include/clang/ASTMatchers/ASTMatchers.h
courbet created this revision.
courbet added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
- hasType() should be able to match the types of TypedefAliasDecl in addition
to TypedefDecl, so made it work on TypedefNameDecl.
- new typedefNameDecl() matcher, which should be mostly
courbet added a comment.
That'd be great. Thanks all for the review.
http://reviews.llvm.org/D18649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet updated this revision to Diff 53001.
courbet added a comment.
Rebase on HEAD for submission.
http://reviews.llvm.org/D18649
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
101 - 200 of 215 matches
Mail list logo
