Re: [clang-tools-extra] 894c476 - [clangd] Add llvm:: qualifier to work around GCC bug. NFC

Would be handy to include a comment to document which compiler version, etc - so we know when we can remove this/don't waste time trying to remove it too soon. On Thu, Dec 17, 2020 at 3:51 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sam McCall > Date:

[clang] c4af1c8 - PR48383: Disallow decltype(auto) in pseudodestructor calls

Author: David Blaikie Date: 2020-12-03T20:41:06-08:00 New Revision: c4af1c8d939b21ac7deb631887fc26db7451c592 URL: https://github.com/llvm/llvm-project/commit/c4af1c8d939b21ac7deb631887fc26db7451c592 DIFF: https://github.com/llvm/llvm-project/commit/c4af1c8d939b21ac7deb631887fc26db7451c592.diff

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Mon, Nov 16, 2020 at 7:24 PM Richard Smith wrote: > > On Mon, 16 Nov 2020 at 18:49, David Blaikie wrote: >> >> On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits >> wrote: >> > >> > >> > Author: Richard Smith >> > Date: 2020-11-11T15:05:51-08:00 >> > New Revision:

Re: [clang] e7f3e21 - Suppress printing template arguments that match default template

On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-11-11T15:05:51-08:00 > New Revision: e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > > URL: > https://github.com/llvm/llvm-project/commit/e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 > DIFF: >

Re: [clang] 5f12f4f - Suppress printing of inline namespace names in diagnostics by default,

Neat! On Wed, Nov 11, 2020 at 3:08 PM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-11-11T15:05:51-08:00 > New Revision: 5f12f4ff9078455cad9d4806da01f570553a5bf9 > > URL: > https://github.com/llvm/llvm-project/commit/5f12f4ff9078455cad9d4806da01f570553a5bf9 >

[clang] 724877e - Roll otherwise-unused variable into assert

Author: David Blaikie Date: 2020-11-09T23:27:47-08:00 New Revision: 724877e219cd219c4b757f10ac4484193cd30c6a URL: https://github.com/llvm/llvm-project/commit/724877e219cd219c4b757f10ac4484193cd30c6a DIFF: https://github.com/llvm/llvm-project/commit/724877e219cd219c4b757f10ac4484193cd30c6a.diff

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Nov 4, 2020 at 9:07 PM Fāng-ruì Sòng wrote: > > It is rare to report an error in BackendUtil.cpp . So I checked the > other Diags.Report instance and noticed that -split-dwarf-file a.dwo > -split-dwarf-output a.dwo (when a.dwo is not writable) suppresses the > output. So there is no

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Nov 4, 2020 at 8:08 PM Fāng-ruì Sòng wrote: > I checked chmod -w a.dwo; clang -cc1 -debug-info-kind=limited > -dwarf-version=4 -split-dwarf-file a.dwo -split-dwarf-output a.dwo > -emit-obj -o - split-debug-output.c > which suppresses the output, so -fbasic-block-sections=list= should >

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Tue, Oct 27, 2020 at 2:21 PM Sriraman Tallam via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Oct 27, 2020 at 2:14 PM David Blaikie via Phabricator < > revi...@reviews.llvm.org> wrote: > >> dblaikie added a comment. >> >> @tmsriram ping on the follow-up here >> > > I checked

[clang] fd14a1f - [clang][Frontend] Add missing error handling

Author: LemonBoy Date: 2020-10-22T14:14:19-07:00 New Revision: fd14a1f6fff37ef62a35ca0f8bc630ac8b23516d URL: https://github.com/llvm/llvm-project/commit/fd14a1f6fff37ef62a35ca0f8bc630ac8b23516d DIFF: https://github.com/llvm/llvm-project/commit/fd14a1f6fff37ef62a35ca0f8bc630ac8b23516d.diff

Re: [clang] a8503b8 - [NFC] Remove unused static function

On Sat, Sep 12, 2020 at 1:15 AM Vitaly Buka wrote: > build fails with -DLLVM_ENABLE_WERROR=ON > Oh, I see - it's a -Wunused-function when building with LLVM_ENABLE_DUMP off. Kristof - if/when you want to recommit this, I think the only thing you need to do is make this function not

Re: [clang] a8503b8 - [NFC] Remove unused static function

LLVM_DUMP_METHOD is meant to be used for annotating functions that might be useful to execute from a debugger to dump data structures, etc - so it's expected that they'd be unused. Do you find that this function is not useful to use from a debugger/similar situation? (or perhaps because the

[clang] 928d419 - Fix a couple of tests that relied on the clang binary having 'clang' somewhere in the name

Author: David Blaikie Date: 2020-09-11T17:45:56-07:00 New Revision: 928d419797ea173090e26f624f08801c7d6661e3 URL: https://github.com/llvm/llvm-project/commit/928d419797ea173090e26f624f08801c7d6661e3 DIFF: https://github.com/llvm/llvm-project/commit/928d419797ea173090e26f624f08801c7d6661e3.diff

Re: [clang] 589ce5f - [DebugInfo] Move constructor homing case in shouldOmitDefinition.

On Mon, Aug 24, 2020 at 9:32 PM Voss, Matthew via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Amy, > > Looks like there's some test failures on the PS4 Linux bot as a result of > this commit. Could you take a look? If the failure persists for a while, I > may need to revert this to

Re: [clang] c9b45ce - [clang][NFC] Fix a GCC warning in ASTImporterTest.cpp

Usually this would be addressed with a "using Base::Function" - makes it clear you aren't intending to override any base behavior, just want to continue to expose the full overload set On Mon, Aug 24, 2020 at 8:11 AM Raphael Isemann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > >

Re: [clang] 4dcbb9c - [clang] Add -fno-delayed-template-parsing to the added unit tests in DeclPrinterTest.cpp

Would be helpful to document in the commit message why a change is being made. On Wed, Aug 5, 2020 at 6:13 AM Bruno Ricci via cfe-commits wrote: > > > Author: Bruno Ricci > Date: 2020-08-05T14:13:05+01:00 > New Revision: 4dcbb9cef71afa549afe8f6b4d335b1c996f8079 > > URL: >

[clang] b198de6 - Merge some of the PCH object support with modular codegen

Author: David Blaikie Date: 2020-07-22T12:46:12-07:00 New Revision: b198de67e0bab462217db50814b1434796fa7caf URL: https://github.com/llvm/llvm-project/commit/b198de67e0bab462217db50814b1434796fa7caf DIFF: https://github.com/llvm/llvm-project/commit/b198de67e0bab462217db50814b1434796fa7caf.diff

Re: [clang-tools-extra] 82dbb1b - Fix the clang-tidy build after get/isIntegerConstantExpression

Thanks for that! Sorry I was a bit slow to get that cleaned up. On Wed, Jul 22, 2020 at 12:41 AM Haojian Wu via cfe-commits wrote: > > > Author: Haojian Wu > Date: 2020-07-22T09:38:56+02:00 > New Revision: 82dbb1b2b4f1e70ca453cca60a4ba5b856058fc0 > > URL: >

[clang] 6aea36f - Follow-on fixes for get/isIntegerConstantExpression

Author: David Blaikie Date: 2020-07-21T21:51:59-07:00 New Revision: 6aea36fb98ed1e0c89cd6e3a24b76339a75aef68 URL: https://github.com/llvm/llvm-project/commit/6aea36fb98ed1e0c89cd6e3a24b76339a75aef68 DIFF: https://github.com/llvm/llvm-project/commit/6aea36fb98ed1e0c89cd6e3a24b76339a75aef68.diff

[clang] 36036aa - Reapply "Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression"

Author: David Blaikie Date: 2020-07-21T20:57:12-07:00 New Revision: 36036aa70ec1df7b51b5d30b2dd8090ad2b6e783 URL: https://github.com/llvm/llvm-project/commit/36036aa70ec1df7b51b5d30b2dd8090ad2b6e783 DIFF: https://github.com/llvm/llvm-project/commit/36036aa70ec1df7b51b5d30b2dd8090ad2b6e783.diff

Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

Cool - thanks for the context! On Tue, Jul 21, 2020 at 5:44 AM Aaron Ballman wrote: > On Mon, Jul 20, 2020 at 5:44 PM David Blaikie wrote: > > > > Should the warning be disabled for LLVM overall, rather than only for > > this subproject? (& be good tohave some details in the commit at least >

Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

Should the warning be disabled for LLVM overall, rather than only for this subproject? (& be good tohave some details in the commit at least of why this warning is being disabled - how it is noisy/unhelpful/etc) On Sun, Jul 19, 2020 at 8:20 AM Aaron Ballman via cfe-commits wrote: > > > Author:

[clang] c943329 - Revert "Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression"

Author: David Blaikie Date: 2020-07-12T20:29:19-07:00 New Revision: c94332919bd922032e979b3ae3ced5ca5bdf9650 URL: https://github.com/llvm/llvm-project/commit/c94332919bd922032e979b3ae3ced5ca5bdf9650 DIFF: https://github.com/llvm/llvm-project/commit/c94332919bd922032e979b3ae3ced5ca5bdf9650.diff

[clang] 49e5f60 - Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

Author: David Blaikie Date: 2020-07-12T19:43:24-07:00 New Revision: 49e5f603d40083dce9c05796e3cde3a185c3beba URL: https://github.com/llvm/llvm-project/commit/49e5f603d40083dce9c05796e3cde3a185c3beba DIFF: https://github.com/llvm/llvm-project/commit/49e5f603d40083dce9c05796e3cde3a185c3beba.diff

[clang] 1111678 - [clang] Add -Wsuggest-override

Author: Logan Smith Date: 2020-07-12T16:05:24-07:00 New Revision: 67895d47558989f9f3a593a82527b016c7e7 URL: https://github.com/llvm/llvm-project/commit/67895d47558989f9f3a593a82527b016c7e7 DIFF: https://github.com/llvm/llvm-project/commit/67895d47558989f9f3a593a82527b016c7e7.diff

[clang-tools-extra] 11cd977 - Add missing #include

Author: David Blaikie Date: 2020-06-29T22:08:20-07:00 New Revision: 11cd9770174603aa62deabbe96c7d0db64d07058 URL: https://github.com/llvm/llvm-project/commit/11cd9770174603aa62deabbe96c7d0db64d07058 DIFF: https://github.com/llvm/llvm-project/commit/11cd9770174603aa62deabbe96c7d0db64d07058.diff

[clang] 31c689e - Move Sema::PragmaStack::Act into Sema.h so it can be instantiated as needed

Author: David Blaikie Date: 2020-06-29T18:02:12-07:00 New Revision: 31c689e69404bb8208de9599626f60c77b6fa81d URL: https://github.com/llvm/llvm-project/commit/31c689e69404bb8208de9599626f60c77b6fa81d DIFF: https://github.com/llvm/llvm-project/commit/31c689e69404bb8208de9599626f60c77b6fa81d.diff

Re: [clang] 1b8125b - Don't assert if we find a dependently-typed variable in the

Could/should this test be testing something more than "does not crash"? I'd expect here's some specific behavior that would be tested/desired rather than "anything other than crashing" - but I understand if it's not practical to test, or perhap insufficiently interesting with the new

Re: [clang] 719c87e - remove gold linker

(ah, sorry, saw the follow-up commit where this was reverted/committed by accident) On Wed, Jun 24, 2020 at 1:50 PM David Blaikie wrote: > > "Remove gold linker support from the PS4 toolchain" might've been a > more precise commit message - "Remove gold linker" seems a bit too > vague. > > On

Re: [clang] 719c87e - remove gold linker

"Remove gold linker support from the PS4 toolchain" might've been a more precise commit message - "Remove gold linker" seems a bit too vague. On Tue, Jun 16, 2020 at 1:03 PM Yuanfang Chen via cfe-commits wrote: > > > Author: Yuanfang Chen > Date: 2020-06-16T13:03:31-07:00 > New Revision:

Re: [clang] 9d8d064 - [NFC] Silence compiler warning [-Wmissing-braces].

Generally it'd be helpful to describe what the change is in the subject line ("Add braces around initialization of a subobject [-Wmissing-braces]") as that's more informative than "Silence compiler warning [-Wmissing braces]", the latter doesn't say how it was silenced, which might make a

[clang] 4935419 - Remove clang::Codegen::EHPadEndScope as unused

Author: David Blaikie Date: 2020-06-23T15:18:49-07:00 New Revision: 4935419d779bdc6cc2f1c2f9e78821ad550d3b56 URL: https://github.com/llvm/llvm-project/commit/4935419d779bdc6cc2f1c2f9e78821ad550d3b56 DIFF: https://github.com/llvm/llvm-project/commit/4935419d779bdc6cc2f1c2f9e78821ad550d3b56.diff

Re: [clang] e4b3fc1 - Get rid of -Wunused warnings in release build, NFC.

On Tue, Jun 16, 2020 at 8:17 AM Kristóf Umann wrote: > > Apologies for the inconvenience, though I wonder why I haven't gotten > builtbot mails :/ > > On Tue, 16 Jun 2020 at 09:54, Haojian Wu wrote: >> >> On Mon, 15 Jun 2020 at 18:29, David Blaikie wrote: >>> >>> I don't think the comment's

Re: [clang] e4b3fc1 - Get rid of -Wunused warnings in release build, NFC.

I don't think the comment's adding value here - it should be fairly clear from the context that the whole loop only exists for some assertions. Also: Could you remove the "(void)" casts now that the whole thing's wrapped in NDEBUG? (an alternative way of phrasing this that doesn't require the

Re: [clang] 4e3d462 - Fix undefined behaviour when trying to deref nullptr.

Is this covered by existing tests? On Thu, Jun 4, 2020 at 2:52 PM Alexey Bataev via cfe-commits wrote: > > > Author: Alexey Bataev > Date: 2020-06-04T17:52:06-04:00 > New Revision: 4e3d4622b1e7bd419815510e5f7cd0f96595b2a3 > > URL: >

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Ah, thanks for the context/update! On Tue, Jun 2, 2020 at 12:37 AM Jean-Baptiste Lespiau wrote: > Yes it was: https://reviews.llvm.org/D80800#2065643 > > Thanks to Sam, I understand the situation better, but I have been slowed > down quite a lot by the fact that > (a) the logic to print types

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Did this end up moving to a review thread? Could someone include a link to that phab review, if it did. Otherwise - I'd still be curious about the answer to Sam's question about SuppressUnwrittenScope & see if the inline namespaces could be avoided & then going for the "modifying

Re: [clang-tools-extra] 61559d0 - [clangd] Squash GCC error with StringRef + gtest MatchesRegex()

Might be handy to link to a buildbot and/or quote the specific error message in the commit message for changes like this so it's clear what's being addressed by the change. On Tue, May 19, 2020 at 4:58 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sam McCall >

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

On Tue, May 12, 2020 at 12:40 PM Jean-Baptiste Lespiau wrote: > Hi, > > thanks for your answer. > > Just a few remarks: > > 1. I imagine that we cannot know if people are using > getFullyQualifiedName. In particular, people could have developed their own > internal tools, thus we cannot be aware

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

+Mr. Smith for visibility. I'm /guessing/ the right path might be to change the implementation of getFullyQualifiedName to use the type printing/pretty printer approach with the extra feature you're suggesting. That way all users get the desired behavior +Sam McCall who (if I understand

Re: [clang] d82538b - Fix -Wunused compiler warning.

On Mon, May 11, 2020 at 12:21 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Haojian Wu > Date: 2020-05-11T09:20:48+02:00 > New Revision: d82538b3f691f3ba1cb7a945a5f8594f71816fdf > > URL: >

[clang] 6288292 - SymbolManager::SymbolDependencies: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:17-07:00 New Revision: 628829254d35bd3dfd1bff29f8afeaf464aafde9 URL: https://github.com/llvm/llvm-project/commit/628829254d35bd3dfd1bff29f8afeaf464aafde9 DIFF: https://github.com/llvm/llvm-project/commit/628829254d35bd3dfd1bff29f8afeaf464aafde9.diff

[clang] e265f92 - AnalysisDeclContext::ManagedAnalyses: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:16-07:00 New Revision: e265f92b6e5e56b21fefdb83aec90f6e39c94857 URL: https://github.com/llvm/llvm-project/commit/e265f92b6e5e56b21fefdb83aec90f6e39c94857 DIFF: https://github.com/llvm/llvm-project/commit/e265f92b6e5e56b21fefdb83aec90f6e39c94857.diff

[clang] fcee807 - ASTContext::OMPTraitInfoVector: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:16-07:00 New Revision: fcee80737c3272dc9de2dfd9635a1e90db215c7a URL: https://github.com/llvm/llvm-project/commit/fcee80737c3272dc9de2dfd9635a1e90db215c7a DIFF: https://github.com/llvm/llvm-project/commit/fcee80737c3272dc9de2dfd9635a1e90db215c7a.diff

[clang] 9b77242 - CodeGenTypes::CGRecordLayouts: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:16-07:00 New Revision: 9b77242c9a0089dca1ac4f80420b29492c5ed555 URL: https://github.com/llvm/llvm-project/commit/9b77242c9a0089dca1ac4f80420b29492c5ed555 DIFF: https://github.com/llvm/llvm-project/commit/9b77242c9a0089dca1ac4f80420b29492c5ed555.diff

[clang] cbae0d8 - BugReporter::StrBugTypes: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:16-07:00 New Revision: cbae0d8221c7a5de229913754d4a6bf562a7db67 URL: https://github.com/llvm/llvm-project/commit/cbae0d8221c7a5de229913754d4a6bf562a7db67 DIFF: https://github.com/llvm/llvm-project/commit/cbae0d8221c7a5de229913754d4a6bf562a7db67.diff

[clang] 4bd5fbe - PragmaNamespace::Handlers: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T22:31:15-07:00 New Revision: 4bd5fbec4bef71d79cbcd916237c8c7b467fb782 URL: https://github.com/llvm/llvm-project/commit/4bd5fbec4bef71d79cbcd916237c8c7b467fb782 DIFF: https://github.com/llvm/llvm-project/commit/4bd5fbec4bef71d79cbcd916237c8c7b467fb782.diff

[clang] 409df39 - ASTWriter::FileDeclIDs: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T18:05:28-07:00 New Revision: 409df3987cb8d6c4a9005b2e633d0116c315375d URL: https://github.com/llvm/llvm-project/commit/409df3987cb8d6c4a9005b2e633d0116c315375d DIFF: https://github.com/llvm/llvm-project/commit/409df3987cb8d6c4a9005b2e633d0116c315375d.diff

[clang] d9485df - ASTUnit::FileDecls: Use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T17:59:45-07:00 New Revision: d9485dfbc12b277e4ba222f4c0e371c5914fe51e URL: https://github.com/llvm/llvm-project/commit/d9485dfbc12b277e4ba222f4c0e371c5914fe51e DIFF: https://github.com/llvm/llvm-project/commit/d9485dfbc12b277e4ba222f4c0e371c5914fe51e.diff

[clang] c98a7e9 - AllocatedCXCodeCompleteResults::DiagnosticWrappers: use unique_ptr to simplify memory management

Author: David Blaikie Date: 2020-04-28T17:45:07-07:00 New Revision: c98a7e9bcc26a13d5e0b3fd199a7d0298777d85e URL: https://github.com/llvm/llvm-project/commit/c98a7e9bcc26a13d5e0b3fd199a7d0298777d85e DIFF: https://github.com/llvm/llvm-project/commit/c98a7e9bcc26a13d5e0b3fd199a7d0298777d85e.diff

[clang] e9644e6 - DebugInfo: Fix default template parameter computation for dependent non-type template parameters

Author: David Blaikie Date: 2020-04-05T16:31:30-07:00 New Revision: e9644e6f4f21e6b6177ef9085cdc9ed9f44b7783 URL: https://github.com/llvm/llvm-project/commit/e9644e6f4f21e6b6177ef9085cdc9ed9f44b7783 DIFF: https://github.com/llvm/llvm-project/commit/e9644e6f4f21e6b6177ef9085cdc9ed9f44b7783.diff

Re: [clang] db92719 - DebugInfo: Defaulted non-type template parameters of bool type

On Wed, Apr 1, 2020 at 1:21 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: David Blaikie > Date: 2020-04-01T13:21:13-07:00 > New Revision: db92719c1d17f5052e7cd1309b0e1e92240f47be > > URL: > https://github.c

[clang] db92719 - DebugInfo: Defaulted non-type template parameters of bool type

Author: David Blaikie Date: 2020-04-01T13:21:13-07:00 New Revision: db92719c1d17f5052e7cd1309b0e1e92240f47be URL: https://github.com/llvm/llvm-project/commit/db92719c1d17f5052e7cd1309b0e1e92240f47be DIFF: https://github.com/llvm/llvm-project/commit/db92719c1d17f5052e7cd1309b0e1e92240f47be.diff

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Fri, Mar 27, 2020 at 5:16 PM Arthur O'Dwyer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Richard: Okay, filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94376 ! > > David: You are correct, the bug in function_ref appeared only when > constructing from `const function_ref&&`. When I

Re: [clang] 2ec59a0 - Buildbot debugging of 0d0b90105f92f6cd9cc7004d565834f4429183fb (lambda/function_ref lifetime issues)

with "[&]" for simplicity/clarity. On Sun, Mar 22, 2020 at 10:44 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: David Blaikie > Date: 2020-03-22T22:43:44-07:00 > New Revision: 2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9 > > URL: > ht

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, Mar 26, 2020 at 8:49 PM Richard Smith wrote: > On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer >> wrote: >> >>> I'm not sure, but I

[clang] 819e540 - Use llvm_unreachable after a fully covered/always-returning switch

Author: David Blaikie Date: 2020-03-26T20:09:57-07:00 New Revision: 819e540208d5d62e7841d0dbdef3580eecc2c2b6 URL: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6 DIFF: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6.diff

Re: [clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

Usually this sort of thing is addressed with llvm_unreachable, rather than a return statement that's not expected to be reached by any valid execution of LLVM (it'd require a carefully hand-crafted CPU kind to reach that return (since all the actual enumerators result in returns earlier, in the

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

age-test/clang-ppc64be-multistage/stage1/bin/clang+0x109635b8) >> #24 0x108b838c main >> (/home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/bin/clang+0x108b838c) >> #25 0x7fffb4a55b10 generic_start_main.isra.0 >> (/lib64/powe

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

the reuse in the outer. Looking back at the code I cannot say anymore >> how I got that impression. >> >> If you think the reference is problematic, I'm totally happy to remove >> it. If the windows bots (or any other ones) don't like it we need to >> inv

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Thanks again for talking it through & the documentation update - it's a great reference point to keep in mind for future reviews, etc. On Tue, Mar 24, 2020 at 1:08 PM Aaron Ballman wrote: > Thank you for the discussion on IRC about this topic. For reference, > this generated

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Sent https://reviews.llvm.org/D76646 to hopefully make this a bit more legible On Mon, Mar 23, 2020 at 2:38 PM David Blaikie wrote: > Ah, thanks. (I'm going to see about renaming/restructuring that API - to > return Optional and be called 'get' rather than 'is' to make this > more clear) > >

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Mon, Mar 23, 2020 at 5:24 AM Aaron Ballman wrote: > On Sun, Mar 22, 2020 at 3:31 PM David Blaikie wrote: > > > > On Sun, Mar 22, 2020 at 9:34 AM Aaron Ballman > wrote: > >> > >> On Sun, Mar 22, 2020 at 12:19 PM David Blaikie > wrote: > >> > > >> > On Sun, Mar 22, 2020 at 6:34 AM Aaron

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Ah, thanks. (I'm going to see about renaming/restructuring that API - to return Optional and be called 'get' rather than 'is' to make this more clear) On Mon, Mar 23, 2020 at 5:04 AM Mikhail Maltsev wrote: > Yes, it does. isIntegerConstantExpr assigns a value to CoprocNoAP. > > -- > Regards, >

[clang] 2ec59a0 - Buildbot debugging of 0d0b90105f92f6cd9cc7004d565834f4429183fb (lambda/function_ref lifetime issues)

Author: David Blaikie Date: 2020-03-22T22:43:44-07:00 New Revision: 2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9 URL: https://github.com/llvm/llvm-project/commit/2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9 DIFF: https://github.com/llvm/llvm-project/commit/2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9.diff

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

t like it we need to > investigate why. As mentioned, I had a problem recreating the problem > locally before. > > Cheers, >Johannes > > > On 3/22/20 1:37 PM, Arthur O'Dwyer wrote: > > On Sun, Mar 22, 2020 at 1:48 PM David Blaikie via cfe-commits < > > cfe-c

[clang] 0d0b901 - Revert "[FIX] Do not copy an llvm::function_ref if it has to be reused"

Author: David Blaikie Date: 2020-03-22T18:43:39-07:00 New Revision: 0d0b90105f92f6cd9cc7004d565834f4429183fb URL: https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb DIFF: https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb.diff

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sun, Mar 22, 2020 at 9:34 AM Aaron Ballman wrote: > On Sun, Mar 22, 2020 at 12:19 PM David Blaikie wrote: > > > > On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballman > wrote: > >> > >> On Sat, Mar 21, 2020 at 11:31 PM David Blaikie > wrote: > >> > > >> > Why the change? this seems counter to

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Sun, Mar 22, 2020 at 10:40 AM Johannes Doerfert wrote: > Some buildbots, I think only Windows buildbots for some reason, crashed > in this function. > > The reason, as described, is that an `llvm::function_ref` cannot be > copied and then reused. It just happened to work on almost all >

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballman wrote: > On Sat, Mar 21, 2020 at 11:31 PM David Blaikie wrote: > > > > Why the change? this seems counter to LLVM's style which pretty > consistently uses unreachable rather than assert(false), so far as I know? > > We're not super consistent (at

Re: [clang] 7a42bab - Reland "[DebugInfo][clang][DWARF5]: Added support for debuginfo generation for defaulted parameters

In the future, please include more detail in the commit message of a recommit about how the patch addresses the problems that lead to the previous revert. This makes it easier for someone reviewing the code to examine the new changes & ensure they're correct/appropriate. On Mon, Mar 2, 2020 at

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Also, this patch was reverted and recommitted several times (more than I think would be ideal) - please include more details in the commit message about what went wrong, what was fixed, what testing was missed in the first place and done in subsequent precommit validation (& is there anything more

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

"a problem" seems a smidge vague - was there a specific explanation for the kind of problem that was signalled? Or was this fix a bit of a shot in the dark? On Sat, Feb 15, 2020 at 10:55 PM Johannes Doerfert via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Johannes Doerfert >

Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

Probably worth a bit more detail when recommitting a patch that was reverted - in the future please include more detail about the reason for the original revert and the specific changes to the previous version that address that (so someone who might've reviewed the previous patch can more quickly

Re: [clang] 736385c - EHScopeStack::Cleanup has virtual functions so the destructor should be too.

I've reverted this in b5eafda8d3ef02f9f78e090725564dd28e573322 - the warning isn't accurate/appropriate - this type is safe as it was previously written (having a protected non-virtual dtor and derived classes being final with a non-virtual dtor - so there's no way (well, inside the base class you

[clang] b5eafda - Revert "EHScopeStack::Cleanup has virtual functions so the destructor should be too."

Author: David Blaikie Date: 2020-03-21T21:17:33-07:00 New Revision: b5eafda8d3ef02f9f78e090725564dd28e573322 URL: https://github.com/llvm/llvm-project/commit/b5eafda8d3ef02f9f78e090725564dd28e573322 DIFF: https://github.com/llvm/llvm-project/commit/b5eafda8d3ef02f9f78e090725564dd28e573322.diff

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Does "isIntegerConstantExpr" have side effects that are desired/necessary? Otherwise please change this to roll the isIntegerConstantExpr into the assert (so that it is only executed when asserts are enabled) On Tue, Mar 10, 2020 at 10:11 AM Mikhail Maltsev via cfe-commits <

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Why the change? this seems counter to LLVM's style which pretty consistently uses unreachable rather than assert(false), so far as I know? On Tue, Mar 10, 2020 at 11:22 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date:

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Please include the "Differential Revision" line so that Phab picks up commits like this and ties them into the review (& also makes it conveniently clickable to jump from the commit mail to the review) On Thu, Mar 19, 2020 at 5:58 AM Djordje Todorovic via cfe-commits < cfe-commits@lists.llvm.org>

Re: [clang] bde15de - Revert "Allow remapping the sysroot with -fdebug-prefix-map."

Please include the reason for the revert in the revert message (including links/quotes from buildbots, etc) On Fri, Mar 20, 2020 at 4:28 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Adrian Prantl > Date: 2020-03-20T16:27:23-07:00 > New Revision:

[clang] 65eb74e - PointerLikeTypeTraits: Standardize NumLowBitsAvailable on static constexpr rather than anonymous enum

Author: David Blaikie Date: 2020-01-16T15:30:50-08:00 New Revision: 65eb74e94b414fcde6bfa810d1c30c7fcb136b77 URL: https://github.com/llvm/llvm-project/commit/65eb74e94b414fcde6bfa810d1c30c7fcb136b77 DIFF: https://github.com/llvm/llvm-project/commit/65eb74e94b414fcde6bfa810d1c30c7fcb136b77.diff

Re: [clang] d801823 - Revert "CWG2352: Allow qualification conversions during reference binding."

On Fri, Dec 27, 2019 at 3:48 PM Richard Smith wrote: > On Fri, 27 Dec 2019 at 12:27, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: David Blaikie >> Date: 2019-12-27T12:27:20-08:00 >> New Revision: d8018233d1ea4234de68d

Re: [clang] de21704 - CWG2352: Allow qualification conversions during reference binding.

Sorry if this is expected behavior, but saw a regression that looks /plausibly/ correct & is rendered ambiguous by this change so I've gone ahead and reverted this patch in d8018233d1ea4234de68d5b4593abd773db79484 Comment from the original: Regressed/causes this to error due to ambiguity:

[clang] d801823 - Revert "CWG2352: Allow qualification conversions during reference binding."

Author: David Blaikie Date: 2019-12-27T12:27:20-08:00 New Revision: d8018233d1ea4234de68d5b4593abd773db79484 URL: https://github.com/llvm/llvm-project/commit/d8018233d1ea4234de68d5b4593abd773db79484 DIFF: https://github.com/llvm/llvm-project/commit/d8018233d1ea4234de68d5b4593abd773db79484.diff

Re: [clang] ce1f95a - Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag"

On Thu, Dec 26, 2019 at 11:58 PM Djordje Todorovic < djordje.todoro...@rt-rk.com> wrote: > Hi David, > > It's a good question. > > Current approach of the debug entry values will consider an entry value as > a valid value until the variable gets modified. > > Please consider this. > > void fn(int

Re: [clang] 3f4b70c - Revert "[clang][modules] Add support for merging lifetime-extended temporaries"

Please include details about the reason for the revert (links to and quotes from buildbots are helpful, etc) in the commit message - so others can follow along more easily (if they're seeing a local regression, they might be able to check if this revert is likely to address it - if they want to

Re: [clang] ce1f95a - Reland "[clang] Remove the DIFlagArgumentNotModified debug info flag"

On Wed, Nov 20, 2019 at 1:08 AM Djordje Todorovic via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Djordje Todorovic > Date: 2019-11-20T10:08:07+01:00 > New Revision: ce1f95a6e077693f93d8869245f911aff3eb7e4c > > URL: >

[clang] e956952 - DebugInfo: Flag Dwarf Version metadata for merging during LTO

Author: David Blaikie Date: 2019-11-22T17:16:35-08:00 New Revision: e956952edec140d2475aa7c8cbe20fbdd3320634 URL: https://github.com/llvm/llvm-project/commit/e956952edec140d2475aa7c8cbe20fbdd3320634 DIFF: https://github.com/llvm/llvm-project/commit/e956952edec140d2475aa7c8cbe20fbdd3320634.diff

Re: [clang] dd870f6 - Fix warning about unused std::unique result, erase shifted elements

OK - thanks for the context! On Mon, Nov 18, 2019 at 5:07 PM Ben Langmuir wrote: > Nice find. > > The change LGTM, and is clearly what I always intended it to do. I was > confused how this ever worked at all, but I see that (at least in libc++) > we move the values into place rather than swap

Re: [clang] dd870f6 - Fix warning about unused std::unique result, erase shifted elements

Hey Ben - if you're still involved with this part of the project - could you check that this change (to code you committed back in 2014, r215810) is correct & add a test case if possible? On Thu, Nov 7, 2019 at 10:39 AM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > >

Re: [clang] d0f3c82 - Fix uninitialized variable warnings. NFCI.

Which compiler/what sort of warning was this addressing? (it can be beneficial to leave variables uninitialized if their value isn't intended to be used - so things like asan can catch bugs where the read of uninitialized is unintended) On Sat, Nov 2, 2019 at 11:27 AM Simon Pilgrim via

[clang] 8d8f9c2 - [clang] Add -fdebug-default-version for specifying the default DWARF version

Author: David Blaikie Date: 2019-11-07T12:05:58-08:00 New Revision: 8d8f9c24407461fadf1730e80ebcf7c767254715 URL: https://github.com/llvm/llvm-project/commit/8d8f9c24407461fadf1730e80ebcf7c767254715 DIFF: https://github.com/llvm/llvm-project/commit/8d8f9c24407461fadf1730e80ebcf7c767254715.diff

[clang] 1de2a05 - DebugInfo: Accept -gdwarf even in clang-cl

Author: David Blaikie Date: 2019-11-01T15:36:15-07:00 New Revision: 1de2a05701e73f8ef5914c2f6ea2dcbe617ce18b URL: https://github.com/llvm/llvm-project/commit/1de2a05701e73f8ef5914c2f6ea2dcbe617ce18b DIFF: https://github.com/llvm/llvm-project/commit/1de2a05701e73f8ef5914c2f6ea2dcbe617ce18b.diff

[clang] 098d901 - DebugInfo: Let -gdwarf use the toolchain default DWARF version, instead of hardcoded/aliased to -gdwarf-4

Author: David Blaikie Date: 2019-11-01T15:17:51-07:00 New Revision: 098d901bd1be07f60c41450fa4af775b130117b9 URL: https://github.com/llvm/llvm-project/commit/098d901bd1be07f60c41450fa4af775b130117b9 DIFF: https://github.com/llvm/llvm-project/commit/098d901bd1be07f60c41450fa4af775b130117b9.diff

[clang] 42465f4 - DebugInfo: (NFC) Refactor DWARF version calculation to make a future change (-fdebug-default-version) easier

Author: David Blaikie Date: 2019-11-01T14:56:43-07:00 New Revision: 42465f406bcea5ea06001ccc52ab779120b68e87 URL: https://github.com/llvm/llvm-project/commit/42465f406bcea5ea06001ccc52ab779120b68e87 DIFF: https://github.com/llvm/llvm-project/commit/42465f406bcea5ea06001ccc52ab779120b68e87.diff

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

On Thu, Oct 24, 2019 at 3:24 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator < > revi...@reviews.llvm.org> wrote: > > dblaikie added a comment. > > In D67723#1720509 ,

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Thanks for the details! Generally it's fine to have these discussions on-list, or at least to include a summary reply so it's clear loose ends were tied up. On Mon, Oct 28, 2019 at 4:26 PM Jian Cai wrote: > Hi David, > > Thanks for the follow up. I already discussed it with Nico over email and

Re: [clang] 9671d1d - [clang]Fixup clang -Werror, , -Wcovered-switch-default build failures

FWIW that probably produces a -Wreturn-type warning because other compilers don't conservatively assume that only the enumerator values can be in an enum variable (rather than all of its representable values). The subsequent -Wreturn-type warning was fixed in 45787e56829f (moving the unreachable

Re: r374844 - Revert "Dead Virtual Function Elimination"

+1/ping on this - Jorge, could you include some details about the reason for the revert & the revision? On Mon, Oct 14, 2019 at 5:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Jorge, > > Please mention the reason for a revert in revert commit messages. Also, >

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

+1 to what Nico said/ping on this. Jian - could you see if these tests could be made portable as Nico's suggested? On Mon, Oct 14, 2019 at 3:54 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hm, this means the test can't run on non-linux, so if someone breaks it on > e.g.

<    1   2   3   4   5   6   7   8   9   10   >