[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

devnexen added inline comments. Comment at: lib/Driver/ToolChains/OpenBSD.cpp:189 if (getToolChain().ShouldLinkCXXStdlib(Args)) -getToolChain().AddCXXStdlibLibArgs(Args, CmdArgs); +ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); if

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

devnexen updated this revision to Diff 142740. devnexen added a comment. - Making base gcc 4.2.1 stdc++ having profile version supported as well. https://reviews.llvm.org/D45662 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/ToolChains/OpenBSD.h Index:

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

devnexen updated this revision to Diff 142686. devnexen added a comment. - Putting the change on the driver itself. https://reviews.llvm.org/D45662 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib/Driver/ToolChains/OpenBSD.cpp

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

devnexen added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:678-679 TC.AddCXXStdlibLibArgs(Args, CmdArgs); + if (TC.getTriple().getOS() == llvm::Triple::OpenBSD) +CmdArgs.push_back(Args.hasArg(options::OPT_pg) ? "-lc++_p" : "-lc++"); +

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

devnexen added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:678-679 TC.AddCXXStdlibLibArgs(Args, CmdArgs); + if (TC.getTriple().getOS() == llvm::Triple::OpenBSD) +CmdArgs.push_back(Args.hasArg(options::OPT_pg) ? "-lc++_p" : "-lc++"); +

[PATCH] D45662: Fuzzer, add libcxx for OpenBSD

devnexen created this revision. devnexen added reviewers: dberris, alexfh, alekseyshl. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. - On platform supported by clang, libcxx is too. - Adding explicitly to avoid to have to add manually. Repository: rC Clang

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44878: Adding fuzzer flags support to OpenBSD driver

devnexen added a comment. Hope it s good enough now :-) https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44878: libFuzzer OpenBSD support

devnexen added a comment. Thanks ! anybody who can land it for me I ll be grateful. https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45458: MallocChecker refactoring of calls checkers

devnexen added a comment. Splitting from https://reviews.llvm.org/D45149 as requested. Repository: rC Clang https://reviews.llvm.org/D45458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45458: MallocChecker refactoring of calls checkers

devnexen created this revision. devnexen added reviewers: NoQ, thakis. Herald added a subscriber: cfe-commits. - Splitting some by family to reduce the list of function identifiers. Repository: rC Clang https://reviews.llvm.org/D45458 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp

[PATCH] D44878: libFuzzer OpenBSD support

devnexen added a comment. the sanitizer part had been accepted https://reviews.llvm.org/D44877 https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45149: MallocChecker, adding specific BSD calls

devnexen added a comment. ping https://reviews.llvm.org/D45149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44878: libFuzzer OpenBSD support

devnexen updated this revision to Diff 141534. https://reviews.llvm.org/D44878 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib/Driver/ToolChains/OpenBSD.cpp === --- lib/Driver/ToolChains/OpenBSD.cpp +++

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

devnexen added a comment. That's good enough for me the changes look neat. We ll see what others think. https://reviews.llvm.org/D45243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. Yes I can t land anything myself :-) thanks ! https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. Just realised he s not active since February, hopes it will make it somehow :-) https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

devnexen added a comment. Do the unit tests have same outcome with these changes ? Otherwise, appreciate the simplification. https://reviews.llvm.org/D45243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44878: libFuzzer OpenBSD support

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. > Fixed: http://llvm.org/PR36985 Nice ! The NetBSD version will benefit it as well (not sure it s really done in the frontend side). https://reviews.llvm.org/D45126 ___ cfe-commits mailing list

[PATCH] D45126: Xray, OpenBSD support

devnexen updated this revision to Diff 140762. https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp === --- lib/Driver/XRayArgs.cpp +++

[PATCH] D45126: Xray, OpenBSD support

devnexen added a comment. In https://reviews.llvm.org/D45126#1055266, @dberris wrote: > LGTM -- at some point, it would be good to refactor all these flag settings > to a single place. Maybe file a bug so that we can track that issue on XRay? > If you can't do it now, I'd be happy to do it

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

devnexen created this revision. devnexen added reviewers: george.karpenkov, NoQ. Herald added a subscriber: cfe-commits. strlcpy/strlcat are bounded but unlike their strn* counterparts, they can overlap. Repository: rC Clang https://reviews.llvm.org/D45177 Files:

[PATCH] D45149: MallocChecker, adding specific BSD calls

devnexen updated this revision to Diff 140607. devnexen added a comment. Using groups of functions. https://reviews.llvm.org/D45149 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/bsd-malloc.c Index: test/Analysis/bsd-malloc.c

[PATCH] D45149: MallocChecker, adding specific BSD calls

devnexen created this revision. devnexen added reviewers: NoQ, jdenny. Herald added a subscriber: cfe-commits. - reallocarray/recallocarray - freezero Repository: rC Clang https://reviews.llvm.org/D45149 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/bsd-malloc.c

[PATCH] D45002: [test] Fix an XRay test on FreeBSD

devnexen added a comment. Since I do not have commit permissions hopefully @dberris will come by or kamil if he s less busy. Repository: rC Clang https://reviews.llvm.org/D45002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45002: [test] Conservatively re-enable a FreeBSD/XRay test

devnexen added a comment. Looks ok to me except I would change a bit the title maybe. Repository: rC Clang https://reviews.llvm.org/D45002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44878: libFuzzer OpenBSD support

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45002: [test] Conservatively re-enable a FreeBSD/XRay test

devnexen added inline comments. Comment at: test/Driver/XRay/xray-instrument-os.c:2 // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s -// XFAIL: -linux- +// XFAIL: -linux-, -freebsd // REQUIRES-ANY: amd64, x86_64, x86_64h, arm, aarch64, arm64 What

[PATCH] D44878: libFuzzer OpenBSD support

devnexen created this revision. devnexen added reviewers: brad, thakis. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D44878 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib/Driver/ToolChains/OpenBSD.cpp

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added a comment. Yes I do ☺ thanks. https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added a comment. ping would be nice if it was commited this week :-) especially the other bits are already https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44250: MmapWriteExecChecker supporting mprotect call

devnexen created this revision. devnexen added a reviewer: dergachev.a. Herald added a subscriber: cfe-commits. In addition of checking mmap call, checking as well mprotect to detect possible writable-executable promotions. Repository: rC Clang https://reviews.llvm.org/D44250 Files:

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 137448. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,25 @@ //

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 137447. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,21 @@ //

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added inline comments. Comment at: test/Driver/fsanitize.c:392 +// RUN %clang -target i386-pc-openbsd -fsanitize=undefined %s -### 2>&1 | FileCheck --check-prefix=CHECK_UBSAN-OPENBSD +// CHECK-UBSAN-OPENBSD: -fsanitize=undefined + vsk wrote: > Why does

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 137284. https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@ -388,6 +388,12 @@ //

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 136924. devnexen added a comment. Enable UBsan test https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c test/Driver/unknown-arg.c Index: test/Driver/unknown-arg.c === ---

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added a comment. In https://reviews.llvm.org/D44069#1026563, @krytarowski wrote: > Revert: http://llvm.org/viewvc/llvm-project?revision=326652=revision > > And fix. I launched llvm-lit to the whole directory and this is the fixes. https://reviews.llvm.org/D44069

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 136919. devnexen added a comment. - Only Asan is not working under OpenBSD - unknown-arg test fails under OpenBSD https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c test/Driver/unknown-arg.c Index: test/Driver/unknown-arg.c

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added a comment. In https://reviews.llvm.org/D44069#1026551, @krytarowski wrote: > This is not breaking (only?) on OpenBSD, but the triple is breaking all > tested platforms. > Please support it properly. What needs to be done ? I mean I have all OpenBSD compiler-rt code in my side

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen created this revision. devnexen added a reviewer: krytarowski. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. OpenBSD supporting only UBsan unsupported this particular test Repository: rC Clang https://reviews.llvm.org/D44069

[PATCH] D43818: Better OpenBSD frontend support

devnexen updated this revision to Diff 136804. devnexen added a comment. backtrace on OpenBSD is not base library but a package. Plus not needed for the UBsan subset. https://reviews.llvm.org/D43818 Files: lib/Driver/ToolChain.cpp lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D43961: OpenBSD Driver basic sanitiser support

devnexen created this revision. devnexen added reviewers: krytarowski, vitalybuka, kettenis. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Basic support of Sanitiser to follow-up ubsan support in compiler-rt. Needs to use lld instead of base ld

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. ping :) https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43818: Better OpenBSD frontend support

devnexen added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:545 CmdArgs.push_back("-lpthread"); -CmdArgs.push_back("-lrt"); +if (TC.getTriple().getOS() != llvm::Triple::OpenBSD) + CmdArgs.push_back("-lrt"); krytarowski

[PATCH] D43818: Better OpenBSD frontend support

devnexen added a comment. Alright then. I ll probably try to push the compiler-rt counterpart (for only ubsan) within the week, it can detects integer overflow already rightfully. Repository: rC Clang https://reviews.llvm.org/D43818 ___

[PATCH] D43818: Better OpenBSD frontend support

devnexen added a comment. Also true ... on OpenBSD the number of sanitisers support list won t be enormous ... ubsan maybe tsan ... the xray instrumentation perharps ... Repository: rC Clang https://reviews.llvm.org/D43818 ___ cfe-commits

[PATCH] D43818: Better OpenBSD frontend support

devnexen added a comment. In https://reviews.llvm.org/D43818#1020577, @krytarowski wrote: > OpenBSD ships with an aggressive ASLR (or ASR) implementation with > fragmentation of user address space. As far as I can tell, it's not possible > to disable it. This means that you are restricted to

[PATCH] D43818: Better OpenBSD frontend support

devnexen created this revision. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, krytarowski. devnexen added reviewers: dlj, krytarowski. - Like other *BSD, conditioning certain flags to pass - To prepare future OpenBSD sanitisers. Repository:

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 135258. devnexen added a comment. Rephrasing Checkers.td comment https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp

[PATCH] D42645: New simple Checker for mmap calls

devnexen added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until

[PATCH] D42645: New simple Checker for mmap calls

devnexen added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:417-419 +// Operating systems specific PROT_READ/PROT_WRITE values is not implemented, +// thus ought to be overriden with the proper analyser-config variables +// remain in alpha until

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 135067. devnexen added a comment. Updating tests accordingly https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 135027. devnexen added a comment. Moving back the checker to alpha.security level. https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added a comment. In https://reviews.llvm.org/D43378#1010464, @emaste wrote: > LGTM with one small note. > > What will it take for us to enable this on the rest of the platforms > Clang/FreeBSD supports? As I see only x86_64 arch implements everything (e.g. custom event), making

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134659. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xray-instrument-os.c test/Driver/XRay/xray-shared-noxray.cpp Index: lib/Driver/XRayArgs.cpp

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. ping Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added inline comments. Comment at: lib/Driver/XRayArgs.cpp:54 +if (Triple.getArch() != llvm::Triple::x86_64) { + D.Diag(diag::err_drv_clang_unsupported) + << (std::string(XRayInstrumentOption) + " on " + Triple.str());

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134634. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xray-instrument-os.c test/Driver/XRay/xray-shared-noxray.cpp Index:

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134628. devnexen added a comment. Herald added a subscriber: srhines. Enabling one test for FreeBSD https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134622. devnexen added a comment. Reusing generic message/reformating. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen added inline comments. Comment at: lib/Driver/XRayArgs.cpp:56 +<< (std::string(XRayInstrumentOption) + " only on " +"FreeBSD x86_64"); +} krytarowski wrote: > krytarowski wrote: > > I think it's better to not

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134605. devnexen added a comment. Updating the warning messages. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen updated this revision to Diff 134586. devnexen edited the summary of this revision. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp Index: lib/Driver/XRayArgs.cpp ===

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

devnexen created this revision. devnexen added reviewers: krytarowski, vitalybuka, dberris. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. devnexen edited the summary of this revision. -pthread was into linkage step. -Warning about the

[PATCH] D43148: Adding msan support for FreeBSD

devnexen updated this revision to Diff 134331. https://reviews.llvm.org/D43148 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === --- lib/Driver/ToolChains/FreeBSD.cpp +++

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen updated this revision to Diff 134244. devnexen added a comment. Changing to pthread flag. https://reviews.llvm.org/D43279 Files: lib/Driver/ToolChains/FreeBSD.cpp Index: lib/Driver/ToolChains/FreeBSD.cpp === ---

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added inline comments. Comment at: FreeBSD.cpp:139 + CmdArgs.push_back("--no-as-needed"); + CmdArgs.push_back("-lpthread"); + CmdArgs.push_back("-lrt"); krytarowski wrote: > `-pthread`? Did not seem needed maybe it s different for NetBSD ?

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen added a comment. Counterpart of the compiler-rt work here https://reviews.llvm.org/D43278 Repository: rC Clang https://reviews.llvm.org/D43279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43279: Add Xray instrumentation compile-time/link-time support to FreeBSD

devnexen created this revision. devnexen added reviewers: vitalybuka, krytarowski. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, dberris, emaste. Similarly to the GNU driver version, adding proper compile and linker flags. Repository: rC

[PATCH] D43148: Adding msan support for FreeBSD

devnexen created this revision. devnexen added a reviewer: krytarowski. devnexen created this object with visibility "All Users". Herald added subscribers: cfe-commits, emaste. Enabling memory sanitiser for X86_64 arch only. To match the sanitiser counterpart. Repository: rC Clang

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133564. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. None of the possible solutions are ideal, but I think I chose the least complex (e.g. via analyzer-config), less edgy one, and 4 is the most common value I ve found so far for PROT_EXEC. Repository: rC Clang https://reviews.llvm.org/D42645

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133164. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133010. devnexen added a comment. Will work on most modern Linux/Glibc versions, BSD variants and Illumos. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 133008. devnexen added a comment. Both Linux/Darwin unit tests passed. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Driver/ToolChains/FreeBSD.cpp

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132969. Herald added a subscriber: emaste. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/Driver/ToolChains/FreeBSD.cpp lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#998732, @a.sidorin wrote: > Hello David, > > I have looked into mmap constant definitions in different implementations and > found them pretty inconsistent. For example, MMAP_EXEC can be 0x01, 0x04 and > I even found 0x00 in some

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132873. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Correcting last typos in unit test. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132850. devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132829. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132826. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Your remarks make sense. Ok will update the general "tone" accordingly. Repository: rC Clang https://reviews.llvm.org/D42645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#997062, @NoQ wrote: > This failed on the buildbots (for example > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/14910 - > committer gets notified of those), so i reverted it for now as r324167. > > I guess the reason

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132728. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132727. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132715. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#996668, @NoQ wrote: > All right, so the code looks good now, but in order to commit this, we also > need tests. We've got those automatic tests of ours in `test/Analysis/` that > feed small code snippets into the analyzer and verify

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132713. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp test/Analysis/mmap-writeexec.c

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132578. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Updated. I ve tried (with few personal code) called as f/ptr, prots set via variable as well. Might sounds obvious to you though this is my first contribution to this :-) Any chance it get pushed ? Just asking I test constantly/carry patches between 3 machines :-)

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132459. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. Another example with pcre2, more specifically its JIT engine In file included from /home/dcarlier/Contribs/php-src/ext/pcre/pcre2lib/pcre2_jit_compile.c:78: In file included from /home/dcarlier/Contribs/php-src/ext/pcre/pcre2lib/sljit/sljitLir.c:261:

[PATCH] D42645: New simple Checker for mmap calls

devnexen added a comment. In https://reviews.llvm.org/D42645#990771, @a.sidorin wrote: > Hello David, > > Do you have any results of this checker on the real code? If yes, could you > please share them? > There are also some inline comments regarding implementation. I did a quick test on the

[PATCH] D42645: New simple Checker for mmap calls

devnexen updated this revision to Diff 132054. Repository: rC Clang https://reviews.llvm.org/D42645 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp Index:

<    1   2   3   >