[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fe632ba18f1: [clang][HeaderSearch] Treat framework headers as Angled for suggestPath (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 547011. dgoldman added a comment. run clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files:

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 546927. dgoldman added a comment. Rename IsSystem to IsAngled Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files:

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman updated this revision to Diff 546017. dgoldman added a comment. run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156704/new/ https://reviews.llvm.org/D156704 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp

[PATCH] D156704: [clang][HeaderSearch] Treat framework headers as System for suggestPath

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. All callers

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa42ce094d903: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl (authored by dgoldman). Repository: rG LLVM Github Monorepo

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman updated this revision to Diff 534714. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150978/new/ https://reviews.llvm.org/D150978 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b66840f7103: [clangd][ObjC] Support ObjC class rename from implementation decls (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 534618. dgoldman marked an inline comment as done. dgoldman added a comment. Fixes for review + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files:

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:787 + // names like class and protocol names. + if (const auto *CD = dyn_cast()) +if (CD->getName() != IdentifierToken->text(SM)) kadircet wrote: > this special casing

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533993. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files:

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman updated this revision to Diff 533969. dgoldman marked an inline comment as done. dgoldman added a comment. Add a contextAllowsHeaderInsertion helper to clangd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150978/new/

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:716 +void VisitObjCImplementationDecl(const ObjCImplementationDecl *OIMD) { + if (const auto *CI = OIMD->getClassInterface()) +

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533769. dgoldman marked an inline comment as done. dgoldman added a comment. Add more FindTarget tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files:

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533640. dgoldman added a comment. Disable renaming categories Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:131 return HighlightingKind::Interface; - if (isa(D)) + if (isa(D)) return HighlightingKind::Namespace; kadircet wrote: > let's do this in a separate

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 531439. dgoldman added a comment. - Implement discussed fixes + category support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files:

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 530665. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. - Use this new

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. In D140275#4203456 , @tupos wrote: > Could you please also advice me what else need to be done for the ObjC, since > there were many years since I wrote ObjC last time I'm not sure what else > need to be done there. > >

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added a comment. Herald added a subscriber: ChuanqiXu. Hey, are you still planning to work on this? Otherwise, is it okay if I take over this patch to implement this feature? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140275/new/

[PATCH] D140275: [clangd] Tweak to add doxygen comment to the function declaration

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddDoxygenComment.cpp:37 +//* @param bar +//* @return +//*/ sammccall wrote: > I'm a bit concerned about people generating these `@param bar` and `@return` > and

[PATCH] D139458: [clangd] Full support for #import insertions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG042dd99484d6: [clangd] Full support for #import insertions (authored by dgoldman). Changed prior to

[PATCH] D139446: [clangd] Add flag to control #import include insertions

This revision was automatically updated to reflect the committed changes. Closed by commit rG814c0bb31660: [clangd] Add flag to control #import include insertions (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139446/new/

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:572 + // case where a header file contains ObjC decls but no #imports. + Symbol::IncludeDirective Directive = preferredIncludeDirective( +

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 486706. dgoldman added a comment. Respect ImportInsertions flag in IncludeFixer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files:

[PATCH] D139446: [clangd] Add flag to control #import include insertions

dgoldman updated this revision to Diff 486700. dgoldman marked 2 inline comments as done. dgoldman added a comment. Update comment + default value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139446/new/ https://reviews.llvm.org/D139446 Files:

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 486291. dgoldman marked 4 inline comments as done. dgoldman added a comment. Update comment + test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files:

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:88 /// (These should be const, but RecursiveASTVisitor requires Decl*). - ArrayRef getLocalTopLevelDecls(); + ArrayRef getLocalTopLevelDecls() const; kadircet wrote: > can

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 486111. dgoldman marked 7 inline comments as done. dgoldman added a comment. Minor fixes for review, moving stuff around Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 483205. dgoldman added a comment. Don't pass ASTSignals through ParsedAST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files:

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 482950. dgoldman marked 5 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files:

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 481022. dgoldman added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/ASTSignals.cpp

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman created this revision. Herald added subscribers: kadircet, arphaman, javed.absar. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are still disabled by

[PATCH] D139446: [clangd] Add flag to control #import include insertions

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This will be

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc46d6e67fab: [clang][Tooling] Add support for generating #import edits (authored by dgoldman). Changed prior to commit:

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51f1ae52b0c9: [clangd] Add new IncludeDirective to IncludeHeaderWithReferences (authored by dgoldman). Changed prior to commit:

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 480524. dgoldman marked 2 inline comments as done. dgoldman added a comment. Use raw string literal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files:

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 480513. dgoldman marked 2 inline comments as done. dgoldman added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files:

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman added inline comments. Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:65 +TEST_F(HeaderIncludesTest, InsertImportWithSameInclude) { + std::string Code = "#include \"a.h\"\n"; kadircet wrote: > can you also add a removal test? > > i know

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 480482. dgoldman marked 9 inline comments as done. dgoldman added a comment. Fixes for review + fix diffbase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files:

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 480465. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes + hopefully proper diffbase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 479665. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 479664. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D128677: [clangd] Add support for generating #import edits

dgoldman updated this revision to Diff 479659. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files:

[PATCH] D128677: [clangd] Support #import insertions

dgoldman updated this revision to Diff 479343. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D128677: [clangd] Support #import insertions

dgoldman updated this revision to Diff 479342. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 479066. dgoldman added a comment. Herald added a project: clang. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files:

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 479024. dgoldman marked 6 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files:

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 476220. dgoldman marked 10 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files:

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d5c4b8f6e04: Fix use of dangling stack allocated string in IncludeFixer (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman added a comment. In D138047#3930211 , @kadircet wrote: > yeah unfortunately testing this is hard, but bug are obvious so it's fine > to land without a test. > > but i think we should rather fix the broken call site at >

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman updated this revision to Diff 475850. dgoldman added a comment. Fix in ParsedAST.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/ https://reviews.llvm.org/D138047 Files: clang-tools-extra/clangd/ParsedAST.cpp Index:

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman added a comment. LMK of the best way to add a test for this, maybe I can somehow make a test with relative path arguments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/ https://reviews.llvm.org/D138047

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. IncludeFixer uses this BuildDir

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 475180. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/SourceCode.cpp

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 474571. dgoldman marked an inline comment as done. dgoldman added a comment. Fix serialization and isSelfContainedHeader - Keep serialization as a single var uint32 - Keep old imported logic in isSelfContainedHeader in addition to a new check for import

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman marked 4 inline comments as done. dgoldman added a comment. Also LMK if you want more in this change (such as a flag to control it, just not sure where it should live + what it should be called). Comment at: clang-tools-extra/clangd/index/Symbol.h:116 +/// this

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 473347. dgoldman marked an inline comment as done. dgoldman added a comment. Fixes for review - Swap over IncludeType to IncludeDirective and update the protos accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 470868. dgoldman added a comment. Change IncludeTypes to be a bitset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files:

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:863 + Tok.addModifier(HighlightingModifier::Declaration); +if (const auto Func = dyn_cast(Decl)) { + if (Func->isThisDeclarationADefinition())

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1716 + Incomplete |= SpecRes.first; + return std::move(SpecRes.second); } dgoldman wrote: > Can this be safely moved - looks like it wasn't before? Ah nevermind,

[PATCH] D133479: [clangd] Set Incompleteness for spec fuzzyfind requests

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1716 + Incomplete |= SpecRes.first; + return std::move(SpecRes.second); } Can this be safely moved - looks like it wasn't before? Repository: rG LLVM Github

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rGe09c75049854: [clangd][ObjC] Improve completions for protocols + category names (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1731 SymbolSlab::Builder ResultsBuilder; -if (Opts.Index->fuzzyFind(Req, [&](const Symbol ) { - if (includeSymbolFromIndex(Sym)) -

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 458724. dgoldman added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457258. dgoldman added a comment. Run clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457257. dgoldman added a comment. Fix strings + test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457067. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman added a comment. In D132962#3761463 , @kadircet wrote: > can you also add test cases for the other two (filtering both for speculative > index queries/regular ones, and making sure we don't suggest symbols from > index for category names), so

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman updated this revision to Diff 457049. dgoldman added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132962/new/ https://reviews.llvm.org/D132962 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Render

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added a comment. Ah my bad didn't realize you hadn't accepted this, was there anything else you wanted me to change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG61ef0ab70196: [clangd] Add decl/def support to SymbolDetails (authored by dgoldman). Repository: rG LLVM Github

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 449050. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 449033. dgoldman added a comment. Fix broken test and swap to AST.tuPath() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1528 } - + auto MainFilePath = + getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM); dgoldman wrote: > sammccall wrote: > > kadircet wrote: > > > let's just pass

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 447813. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1528 } - + auto MainFilePath = + getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM); sammccall wrote: > kadircet wrote: > > let's just pass the TUPath from

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 447771. dgoldman marked 5 inline comments as done. dgoldman added a comment. Minor fixes for review (some still pending based on discussion) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG88a2ac6ad623: [clangd] Improve XRefs support for ObjCMethodDecl (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D130095?vs=445951=447739#toc Repository: rG LLVM Github

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman updated this revision to Diff 445951. dgoldman added a comment. Minor grammar update to comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:174 auto L = D.getLocation(); + // Use the start of the first selector fragment instead of the -/+ location. + if (const auto *MD = dyn_cast()) kadircet wrote: > can we do this in

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman updated this revision to Diff 445873. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. -

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added a comment. For more context see the discussion on b/187405187 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 ___ cfe-commits mailing list

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 445618. dgoldman added a comment. Revert unintended change in symbol-info.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files:

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman created this revision. dgoldman added reviewers: kadircet, sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc6c1f181b8a: [clangd][ObjC] Fix ObjC method definition completion (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

dgoldman updated this revision to Diff 441685. dgoldman added a comment. - Use codeCompletionString(Result) for RK_Pattern Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128821/new/ https://reviews.llvm.org/D128821 Files:

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:866 case CodeCompletionResult::RK_Pattern: - return Result.Pattern->getTypedText(); + CCS = Result.Pattern; + break; sammccall wrote: > weirdly,

[PATCH] D128821: [clangd][ObjC] Fix ObjC method definition completion

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D128677: [clangd] Support #import insertions

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang,

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: wenlei, usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D127125: [clangd] Improve ObjC protocol suggestions from the index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc1f24332af3: [clangd] Improve ObjC protocol suggestions from the index (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) ckandeler

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) Do we need

[PATCH] D127125: [clangd] Improve ObjC protocol suggestions from the index

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When querying the index

[PATCH] D127116: [clangd] Add flags to symbol requests to restrict to ObjC symbols

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. clangd will set this flag for

  1   2   3   4   5   6   >